| *** hamzy has joined #openstack-ironic | 00:22 | |
| *** bfournie has joined #openstack-ironic | 00:42 | |
| openstackgerrit | Bob Fournier proposed openstack/ironic-inspector master: Remove PXE filter logging https://review.openstack.org/643494 | 01:11 |
|---|---|---|
| *** hwoarang has quit IRC | 01:12 | |
| *** hwoarang has joined #openstack-ironic | 01:14 | |
| *** whoami-rajat has joined #openstack-ironic | 01:17 | |
| *** hjensas has joined #openstack-ironic | 01:34 | |
| *** dsneddon has joined #openstack-ironic | 01:50 | |
| *** penick has quit IRC | 02:09 | |
| *** dteselkin has quit IRC | 02:36 | |
| *** dteselkin has joined #openstack-ironic | 02:38 | |
| *** MattMan_ has quit IRC | 03:25 | |
| *** MattMan_ has joined #openstack-ironic | 03:25 | |
| *** Lucas_Gray has joined #openstack-ironic | 03:48 | |
| *** dsneddon has quit IRC | 04:15 | |
| *** dsneddon has joined #openstack-ironic | 04:50 | |
| openstackgerrit | Merged openstack/ironic master: Kg key for IPMIv2 authentication https://review.openstack.org/641658 | 05:02 |
| *** dsneddon has quit IRC | 05:04 | |
| *** Lucas_Gray has quit IRC | 05:11 | |
| *** dsneddon has joined #openstack-ironic | 05:26 | |
| openstackgerrit | paresh sao proposed openstack/ironic master: [WIP]oob disk erase https://review.openstack.org/641582 | 05:36 |
| *** rcernin has quit IRC | 05:58 | |
| *** rachit7 has joined #openstack-ironic | 06:08 | |
| openstackgerrit | Merged openstack/ironic master: Make metrics usable https://review.openstack.org/643436 | 06:09 |
| *** rcernin has joined #openstack-ironic | 06:13 | |
| *** e0ne has joined #openstack-ironic | 06:24 | |
| *** e0ne has quit IRC | 06:27 | |
| openstackgerrit | John Haan proposed openstack/bifrost master: Add log file argument for ironic services https://review.openstack.org/639590 | 06:33 |
| *** diga has joined #openstack-ironic | 07:04 | |
| *** dsneddon has quit IRC | 07:09 | |
| *** dsneddon has joined #openstack-ironic | 07:21 | |
| arne_wiebalck | good morning, ironic | 07:23 |
| *** jimyeh7543 has joined #openstack-ironic | 07:29 | |
| jimyeh7543 | test | 07:30 |
| jimyeh7543 | HI, I am Jim from ITRI Taiwan | 07:30 |
| *** yolanda has joined #openstack-ironic | 07:30 | |
| jimyeh7543 | @chihhsin | 07:31 |
| chihhsin_ | jimyeh7543: hi | 07:31 |
| jimyeh7543 | chinhsin_ hi | 07:32 |
| rachit7 | openstack-tox-lower-constraints failed. Any idea how to resolve this test? | 07:36 |
| *** pcaruana has joined #openstack-ironic | 07:36 | |
| *** priteau has joined #openstack-ironic | 07:40 | |
| *** rcernin has quit IRC | 07:59 | |
| *** rachit7 has quit IRC | 08:12 | |
| *** Qianbiao has joined #openstack-ironic | 08:12 | |
| Qianbiao | hello, ironic | 08:13 |
| *** tssurya has joined #openstack-ironic | 08:15 | |
| rpittau|afk | good morning ironic! o/ | 08:17 |
| *** rpittau|afk is now known as rpittau | 08:17 | |
| *** sburette has joined #openstack-ironic | 08:21 | |
| *** pcaruana has quit IRC | 08:24 | |
| *** pcaruana|afk| has joined #openstack-ironic | 08:24 | |
| *** emine__ has joined #openstack-ironic | 08:26 | |
| *** rachit7 has joined #openstack-ironic | 08:27 | |
| *** e0ne has joined #openstack-ironic | 08:35 | |
| openstackgerrit | Merged openstack/ironic master: Deprecates `hash_distribution_replicas` config option https://review.openstack.org/643002 | 08:38 |
| *** jtomasek has joined #openstack-ironic | 08:41 | |
| *** derekh has joined #openstack-ironic | 08:47 | |
| iurygregory | TheJulia, you rock! o/ | 08:53 |
| iurygregory | good morning ppl | 08:53 |
| openstackgerrit | Kaifeng Wang proposed openstack/python-ironic-inspector-client master: Find misteriously missing pep8 import check https://review.openstack.org/643535 | 08:53 |
| rpittau | hey iurygregory :) | 08:55 |
| iurygregory | its green https://review.openstack.org/#/c/636169/ XD | 08:56 |
| patchbot | patch 636169 - ironic-tempest-plugin - Run all defined jobs defined in check and gate - 16 patch sets | 08:56 |
| rpittau | lol | 08:56 |
| *** dsneddon has quit IRC | 08:59 | |
| *** dougsz has joined #openstack-ironic | 09:02 | |
| rachit7 | rpittau: openstack-tox-lower-constraints failed. Any idea how to resolved? | 09:04 |
| *** hwoarang has quit IRC | 09:11 | |
| rpittau | rachit7, there was an issue yesterday with that but it should be fixed now, when did it fail and how ? | 09:11 |
| rachit7 | rpittau: yesterday it failed. should i try to update my patch set now? | 09:14 |
| *** dsneddon has joined #openstack-ironic | 09:14 | |
| rpittau | rachit7, can you link the patchset please ? | 09:15 |
| *** hwoarang has joined #openstack-ironic | 09:16 | |
| rachit7 | rpittau: https://review.openstack.org/#/c/639698/ | 09:17 |
| patchbot | patch 639698 - ironic - Set boot_mode in node properties during OOB Intros... - 8 patch sets | 09:17 |
| rpittau | rachit7, yes please, do a recheck, it should be ok | 09:17 |
| *** boteium has joined #openstack-ironic | 09:17 | |
| rachit7 | rpittau: I will try. thanks alot. | 09:18 |
| rpittau | rachit7, np | 09:19 |
| *** logan- has quit IRC | 09:23 | |
| *** boteium has quit IRC | 09:24 | |
| *** logan- has joined #openstack-ironic | 09:27 | |
| *** boteium has joined #openstack-ironic | 09:28 | |
| openstackgerrit | Rachit Kapadia proposed openstack/ironic master: Set boot_mode in node properties during OOB Introspection https://review.openstack.org/639698 | 09:29 |
| openstackgerrit | Kaifeng Wang proposed openstack/python-ironic-inspector-client master: Find misteriously missing pep8 import check https://review.openstack.org/643535 | 09:39 |
| *** dtantsur|afk is now known as dtantsur | 09:47 | |
| dtantsur | morning ironic | 09:47 |
| iurygregory | morning dtantsur o/ | 09:49 |
| mgoddard | morning all | 09:50 |
| dtantsur | morning mgoddard! could you also check https://review.openstack.org/#/c/643264/ it blocks the patch you've just approved. | 09:51 |
| patchbot | patch 643264 - ironic-tempest-plugin - discovery: optional support for testing changing d... - 1 patch set | 09:51 |
| *** jimyeh7543 has quit IRC | 09:52 | |
| mgoddard | dtantsur: yeah, looked at that. Any idea what the test failures are about? One was a cleaning issue | 09:52 |
| dtantsur | mgoddard: I think the tempest-plugin CI is pretty broken on stable :( | 09:53 |
| dtantsur | mgoddard: iurygregory was looking into it, but with limited success so far | 09:53 |
| rpittau | hi dtantsur :) | 09:53 |
| rpittau | hey mgoddard :) | 09:53 |
| dtantsur | mgoddard: I can rebase that patch on top of https://review.openstack.org/#/c/636169/ and see | 09:53 |
| patchbot | patch 636169 - ironic-tempest-plugin - Run all defined jobs defined in check and gate - 16 patch sets | 09:53 |
| mgoddard | hi rpittau | 09:53 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-tempest-plugin master: discovery: optional support for testing changing driver https://review.openstack.org/643264 | 09:54 |
| dtantsur | done | 09:54 |
| mgoddard | dtantsur: ack | 09:54 |
| dtantsur | mgoddard: we have a problem with your latest patch, see the last comment on https://review.rdoproject.org/r/#/c/19386/ | 09:58 |
| dtantsur | I don't think we should build namedtuples like that | 09:58 |
| mgoddard | dtantsur: looking | 10:00 |
| mgoddard | dtantsur: I see - unit tests now not backwards compatible. | 10:02 |
| dtantsur | yeah | 10:02 |
| mgoddard | dtantsur: I guess we could list the fields in the tuple, and include only valid fields | 10:02 |
| dtantsur | mgoddard: yeah | 10:03 |
| mgoddard | dtantsur: I do wonder how much extra we're actually testing in the unit-with-driver-libs tests | 10:04 |
| dtantsur | mgoddard: at least mocks with autospec do realy autospeccing | 10:04 |
| dtantsur | * real | 10:04 |
| dtantsur | no, I cannot type today | 10:04 |
| dtantsur | rpittau: could you review https://review.openstack.org/#/c/636169/ ? | 10:08 |
| patchbot | patch 636169 - ironic-tempest-plugin - Run all defined jobs defined in check and gate - 16 patch sets | 10:08 |
| rpittau | dtantsur, yeah, I don't know why I skipped it before | 10:09 |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Deploy Templates: factor out ironic.conductor.steps https://review.openstack.org/642059 | 10:10 |
| *** dtantsur is now known as dtantsur|brb | 10:15 | |
| *** dsneddon has quit IRC | 10:32 | |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Fix idrac driver unit test backwards compat issue https://review.openstack.org/643557 | 10:44 |
| hjensas | good morning | 10:45 |
| hjensas | rpittau: so, I was looking at the pxelinux.0 not being loaded last night. Turn's out this is the issue derekh brought up on ML [ironic][neutron] nf_conntrack_helper now disabled by default | 10:46 |
| hjensas | rpittau: looks like consensus was to look at patching neutron so that some additional iptables rules are created in namespaces. see: https://home.regit.org/netfilter-en/secure-use-of-helpers/ | 10:47 |
| rpittau | hjensas, hey! thanks for looking at that! | 10:48 |
| hjensas | rpittau: I will do a bit more verification, and then I can start cooking a neutron patch. | 10:49 |
| rpittau | hjensas, great, let me know if I can be of any help :) | 10:50 |
| openstackgerrit | Arne Wiebalck proposed openstack/ironic-specs master: Add details on target_raid_config for Software RAID support https://review.openstack.org/643100 | 10:50 |
| *** dsneddon has joined #openstack-ironic | 10:58 | |
| *** dsneddon has quit IRC | 11:03 | |
| *** e0ne has quit IRC | 11:03 | |
| Qianbiao | hi dtantsur, could u visit the CI log yet | 11:07 |
| *** dsneddon has joined #openstack-ironic | 11:38 | |
| *** diga has quit IRC | 11:38 | |
| rachit7 | rpittau: Thanks my patch(https://review.openstack.org/639698) resolved zul test | 11:40 |
| patchbot | patch 639698 - ironic - Set boot_mode in node properties during OOB Intros... - 9 patch sets | 11:40 |
| rpittau | rachit7, yep no problem | 11:42 |
| *** dsneddon has quit IRC | 11:43 | |
| arne_wiebalck | in case someone has a moment: linters fails for my spec update ^, passes locally (TM) ... am I missing sth obvious? | 11:44 |
| *** Lucas_Gray has joined #openstack-ironic | 11:50 | |
| *** rh-jelabarre has joined #openstack-ironic | 11:51 | |
| *** dsneddon has joined #openstack-ironic | 11:55 | |
| *** dsneddon has quit IRC | 12:00 | |
| *** dtantsur|brb is now known as dtantsur | 12:01 | |
| rpittau | arne_wiebalck, that's weird, it looks like a potential bug with stestr | 12:04 |
| rpittau | actually os_testr | 12:05 |
| arne_wiebalck | rpittau: thx for checking , I don't see the corresponding code, actually | 12:06 |
| arne_wiebalck | rpittau: like the _to_int function | 12:06 |
| rpittau | arne_wiebalck, the concurrency parameter can be set manually or by default to 0 | 12:06 |
| rpittau | but it's instead None | 12:07 |
| arne_wiebalck | and the conversion fails | 12:07 |
| rpittau | yep | 12:07 |
| arne_wiebalck | where does the code come from? | 12:08 |
| arne_wiebalck | is that os dependent? | 12:08 |
| rpittau | oh snap, there was a bug | 12:08 |
| *** dsneddon has joined #openstack-ironic | 12:08 | |
| arne_wiebalck | huh? | 12:09 |
| rpittau | it was corrected but I dont think we're taking the commit yet | 12:09 |
| arne_wiebalck | oh ... do you have a pointer? | 12:09 |
| rpittau | https://github.com/mtreinish/stestr/commit/ac8dac07f5faa487254c649e7411515616392403 | 12:09 |
| rpittau | mmm that's just the exception | 12:10 |
| rpittau | no I think the bug is still there | 12:10 |
| dtantsur | Qianbiao: the logs look good today, many thanks! A small (non-blocking) request: if possible, please enable DEBUG logging for services. | 12:11 |
| Qianbiao | dtantsur will do | 12:11 |
| arne_wiebalck | rpittau: right this is just catching the erorr | 12:11 |
| arne_wiebalck | rpittau: I'm wondering what that might have triggered? ;) | 12:12 |
| Qianbiao | if everything is ok, hope the merge progress could start | 12:12 |
| rpittau | arne_wiebalck, this is the code that is breaking the execution https://github.com/mtreinish/stestr/blob/master/stestr/commands/run.py#L37 | 12:12 |
| *** e0ne has joined #openstack-ironic | 12:12 | |
| rpittau | ah hold on | 12:12 |
| arne_wiebalck | this should fix it | 12:13 |
| arne_wiebalck | it resorts to 0 in case of None, no? | 12:13 |
| *** dsneddon has quit IRC | 12:13 | |
| rpittau | ok so that is the actual fix | 12:13 |
| rpittau | the commit I post before | 12:14 |
| *** derekh has quit IRC | 12:14 | |
| rpittau | it catches the correct exception | 12:14 |
| arne_wiebalck | yes | 12:14 |
| arne_wiebalck | kind of | 12:14 |
| *** FlorianFa has quit IRC | 12:14 | |
| rpittau | just tested and works fine :) | 12:15 |
| rpittau | the release we're using it doesnt include that | 12:15 |
| arne_wiebalck | how did you test this? | 12:15 |
| rpittau | I applied the patch and run tox :) | 12:15 |
| arne_wiebalck | on bionic | 12:15 |
| arne_wiebalck | ? | 12:16 |
| rpittau | oh the distro is not important | 12:16 |
| dtantsur | Qianbiao: +2 | 12:16 |
| Qianbiao | thanks | 12:16 |
| arne_wiebalck | ah, I was looking to _to_int in .tox | 12:16 |
| arne_wiebalck | looking for | 12:17 |
| rpittau | arne_wiebalck, that's correct | 12:17 |
| * arne_wiebalck is confused | 12:17 | |
| rpittau | arne_wiebalck, you can apply the patch in .tox under ironic-specs, then run tox again with the same environment | 12:17 |
| arne_wiebalck | this I understood, but I don't think I have the _to_int function ... | 12:18 |
| * arne_wiebalck double checks | 12:18 | |
| rpittau | it's in the stestr package | 12:18 |
| arne_wiebalck | that's what I mean | 12:18 |
| arne_wiebalck | I looked in the wrong place | 12:18 |
| rpittau | oh ok :) | 12:18 |
| arne_wiebalck | and was puzzled where that code comes from | 12:19 |
| rpittau | so we need a new release of stestr \o/ | 12:19 |
| arne_wiebalck | looks like it | 12:19 |
| arne_wiebalck | how is that triggered? | 12:19 |
| rpittau | I'm not sure :D | 12:19 |
| rpittau | maybe dtantsur can help ? :) | 12:19 |
| dtantsur | I may have lost some of the scrollback, what's the question? | 12:25 |
| dtantsur | rpittau: if you have a minute, you can make RDO happier by reviewing https://review.openstack.org/#/c/643557/1 | 12:25 |
| patchbot | patch 643557 - ironic - Fix idrac driver unit test backwards compat issue - 1 patch set | 12:25 |
| rpittau | dtantsur, an issue with stestr, I'm opening an issue on github for that, but I don't know if that's the correct way to approach this | 12:26 |
| *** pcaruana has joined #openstack-ironic | 12:26 | |
| dtantsur | ah, found it | 12:26 |
| dtantsur | yeah, I can reproduce it locally on a fresh environment | 12:27 |
| *** pcaruana|afk| has quit IRC | 12:28 | |
| rpittau | arne_wiebalck, dtantsur, https://github.com/mtreinish/stestr/issues/235 | 12:28 |
| openstackgerrit | Nikolay Fedotov proposed openstack/ironic-python-agent master: Discover IPv6 BMC address https://review.openstack.org/640795 | 12:29 |
| dtantsur | rpittau: good catch. /me notified infra | 12:29 |
| arne_wiebalck | rpittau: sth else must have changed to trigger this error, no? | 12:30 |
| arne_wiebalck | rpittau: also, I don't get why it worked locally | 12:30 |
| rpittau | arne_wiebalck, the _to_int function was introduced in the latest release | 12:30 |
| arne_wiebalck | rpittau: here we go | 12:30 |
| rpittau | arne_wiebalck, maybe you ran with an old env ? | 12:30 |
| arne_wiebalck | rpittau: probably | 12:31 |
| arne_wiebalck | rpittau: thanks for taking the time! | 12:31 |
| arne_wiebalck | dtantsur: that means my spec patch is ready for review ;) | 12:31 |
| rpittau | arne_wiebalck, no problem, I like investigating these things :D | 12:32 |
| dtantsur | cool :) | 12:32 |
| iurygregory | dtantsur, rpittau doing some tests for python-ironicclient with python3 virtual env here i notice that we have different messages from openstack client o.o http://paste.openstack.org/show/747856/ | 12:33 |
| * rpittau is in low battery mode | 12:34 | |
| iurygregory | tests failling with python3 http://logs.openstack.org/74/642474/10/check/ironicclient-functional/3a3bc51/job-output.txt.gz#_2019-03-13_10_37_56_268334 (in python2 ironicclient.tests.functional.osc.v1.test_baremetal_allocation.BaremetalAllocationTests.test_create_negative_11_____candidate_node____banana_____ is failling too and locally i already fixed for py2 and py3) | 12:35 |
| dtantsur | iurygregory: FUN | 12:35 |
| dtantsur | I think it's because of different argparse versions | 12:35 |
| iurygregory | always \o/ | 12:35 |
| rpittau | Python 3 has its grammar wrong :P | 12:36 |
| rpittau | and with this I go to eat | 12:36 |
| *** EmilienM is now known as EvilienM | 12:37 | |
| iurygregory | rpittau, lol enjoy your meal | 12:37 |
| *** priteau has quit IRC | 12:38 | |
| iurygregory | should we verify the version and add specific tests for py3? | 12:39 |
| dtantsur | iurygregory: maybe just check the presence of --resource-class? | 12:40 |
| dtantsur | checking the exact error message is not the goal here | 12:40 |
| iurygregory | sure makes sense | 12:40 |
| hjensas | rpittau: https://review.openstack.org/643570 <- Seems to work, but I will follow up on mailing list to get input from neutron team. (I'm not convinced a global opt for all router namespaces is what we want...) | 12:41 |
| patchbot | patch 643570 - neutron - WiP/PoC - Router Namespace - Connection Tracker he... - 1 patch set | 12:41 |
| *** dsneddon has joined #openstack-ironic | 12:49 | |
| *** dsneddon has quit IRC | 12:54 | |
| openstackgerrit | Merged openstack/ironic-inspector master: Removing two deprecated values from json responses https://review.openstack.org/643350 | 12:58 |
| openstackgerrit | Merged openstack/ironic master: Fix idrac driver unit test backwards compat issue https://review.openstack.org/643557 | 12:58 |
| Qianbiao | hi dtantsur, may i trouble u for a minute. | 12:58 |
| dtantsur | sure | 12:58 |
| Qianbiao | A few nits inline can be fixed in a follow-up to avoid respinning the whole patch. | 12:58 |
| Qianbiao | what is this mean. | 12:58 |
| Qianbiao | do u mean i should not submit new patch | 12:59 |
| Qianbiao | fix it in another patch? | 12:59 |
| dtantsur | Qianbiao: yes, another patch. You don't have to update this patch unless other reviewers find issues that qualify for a -1. | 12:59 |
| Qianbiao | ok i got u. | 12:59 |
| Qianbiao | Got an c in my english class. :) | 13:00 |
| dtantsur | Qianbiao: don't worry :) we have some established terminology here that you simply don't have to know. | 13:01 |
| Qianbiao | like a spy :) | 13:02 |
| dtantsur | heh | 13:02 |
| Qianbiao | I am a freelancer, maybe i could do some contributing later too. | 13:03 |
| dtantsur | ++ | 13:03 |
| *** dsneddon has joined #openstack-ironic | 13:10 | |
| iurygregory | yay deploy templates tests are broken with py3 too | 13:11 |
| iurygregory | Py3 | 13:11 |
| iurygregory | openstack baremetal deploy template create: error: the following arguments are required: <name>, --steps | 13:11 |
| iurygregory | Py2 | 13:11 |
| iurygregory | openstack baremetal deploy template create: error: too few arguments | 13:11 |
| iurygregory | the test except "too few arguments" in the message D: | 13:11 |
| mgoddard | iurygregory: boo | 13:11 |
| iurygregory | tell me how can i handle this mgoddard =D | 13:12 |
| mgoddard | iurygregory: in the client | 13:12 |
| mgoddard | ? | 13:12 |
| iurygregory | yes sir | 13:12 |
| mgoddard | iurygregory: got a link? | 13:12 |
| iurygregory | functional tests | 13:12 |
| iurygregory | sure | 13:12 |
| iurygregory | 1min | 13:12 |
| iurygregory | http://logs.openstack.org/74/642474/10/check/ironicclient-functional/3a3bc51/job-output.txt.gz#_2019-03-13_10_37_56_288054 logs | 13:12 |
| iurygregory | https://review.openstack.org/#/c/642474/ | 13:13 |
| patchbot | patch 642474 - python-ironicclient - Run jobs under python2 and python3 - 10 patch sets | 13:13 |
| mgoddard | iurygregory: just comment it out :p | 13:13 |
| iurygregory | https://github.com/openstack/python-ironicclient/blob/4af8a791f01176b4c1bb0c376fae2a97383695fc/ironicclient/tests/functional/osc/v1/test_baremetal_deploy_template_basic.py#L162 | 13:13 |
| iurygregory | mgoddard, remove this line ? | 13:14 |
| mgoddard | iurygregory: no, it's a valid test case. we should fix the test | 13:14 |
| *** dsneddon has quit IRC | 13:14 | |
| iurygregory | mgoddard, ok but it works for py2 | 13:15 |
| iurygregory | XD | 13:15 |
| iurygregory | but py3 is broken becuase the message from the client is different \o/ | 13:15 |
| etingof | anyone has a link handy of the bionic image being used in CI? | 13:16 |
| mgoddard | iurygregory: do we need to support both py2 and py3 in func tests? | 13:21 |
| TheJulia | iurygregory: what did I do?!? | 13:21 |
| iurygregory | mgoddard, well i dont have the answer I would say yes since stein can run under py2 | 13:22 |
| iurygregory | TheJulia, https://review.openstack.org/643436 =) | 13:22 |
| patchbot | patch 643436 - ironic - Make metrics usable (MERGED) - 2 patch sets | 13:22 |
| TheJulia | hehe | 13:22 |
| iurygregory | XD | 13:22 |
| TheJulia | Have fun with a plugin :) | 13:23 |
| * iurygregory hope will be more fun than the CI \o/ | 13:23 | |
| TheJulia | heh | 13:23 |
| iurygregory | TheJulia, maybe you can answer mgoddard question XD | 13:23 |
| iurygregory | we have a little problem for functional tests running under py3 for the client because the client gives different messages for py2 and py3 | 13:24 |
| mgoddard | iurygregory: how about something like this: http://paste.openstack.org/show/747865/ | 13:25 |
| iurygregory | mgoddard, magic | 13:26 |
| * iurygregory trying | 13:26 | |
| iurygregory | dtantsur, wdyt? would be valid do this for the tests ? :D | 13:31 |
| dtantsur | iurygregory: fine with me | 13:31 |
| *** sthussey has joined #openstack-ironic | 13:31 | |
| iurygregory | dtantsur, ack | 13:31 |
| Qianbiao | Thanks all, the patch is approved finally. | 13:34 |
| *** mjturek has joined #openstack-ironic | 13:35 | |
| *** pcaruana has quit IRC | 13:36 | |
| rpittau | hjensas, thanks, checking | 13:37 |
| TheJulia | sorry what | 13:37 |
| * TheJulia needs a coffee IV | 13:37 | |
| rpittau | hey TheJulia :D | 13:38 |
| efried | dustinc: you may want to join #openstack-nova for discussions on ironicclient removal | 13:38 |
| TheJulia | heh, similar issue to what I ran into last night | 13:38 |
| TheJulia | iurygregory: I think we should focus on py3 and behavior there. I think, where it makes sense, to tag and skip additional checks like content checks where we are running into issues due to things we cannot control | 13:40 |
| TheJulia | dtantsur: replied to https://review.openstack.org/#/c/643484 I'm sure this is one of those "nobody is going to be happy patches" :( | 13:40 |
| patchbot | patch 643484 - nova - [ironic] ignore conflict upon cleaning up node - 3 patch sets | 13:40 |
| *** dsneddon has joined #openstack-ironic | 13:43 | |
| iurygregory | TheJulia, let me see if understood correct, we should make tests ok for py3 and if necessary we skip them in py2 ? | 13:43 |
| TheJulia | yes | 13:45 |
| iurygregory | gotcha =) going to see how to fix without workaround for py3 and see how to skip in py2 =) | 13:46 |
| TheJulia | py2 will no longer be supported in 9 months, and I kind of feel like it is kind of pointless to give ourselves headaches for minor py2/py3 behavior differences on things like returned data/error structure as long as ultimately the correct behavior is still occuring | 13:46 |
| iurygregory | makes sense | 13:47 |
| * rpittau update his bye-bye-py2 countdown | 13:48 | |
| TheJulia | rpittau: is it a beautiful countdown? | 13:48 |
| dtantsur | just keep in mind that ~ everyone still runs openstack with python 2 in production | 13:48 |
| *** dsneddon has quit IRC | 13:48 | |
| rpittau | TheJulia, it's a simple one, but there will be fireworks and cookies at the end | 13:49 |
| iurygregory | cookies \o/ | 13:49 |
| iurygregory | send to Brno o/ | 13:49 |
| rpittau | probably cookies-releasing-fireworks | 13:49 |
| openstackgerrit | Dmitry Tantsur proposed openstack/metalsmith master: Accept hostname in reserve_node in addition to provision_node https://review.openstack.org/640397 | 13:51 |
| TheJulia | speaking of cookies, I approved the ibmc driver. \o/ | 13:54 |
| Qianbiao | lol, thanks TheJulia. | 13:56 |
| Qianbiao | Should send you all cookies. | 13:57 |
| Qianbiao | Now, i should waiting for zuul merge code to master branch, right? | 13:57 |
| *** e0ne has quit IRC | 13:58 | |
| TheJulia | Yup | 13:58 |
| TheJulia | Hey, it is friday! Casual nick friday time | 13:59 |
| *** TheJulia is now known as needssleep | 13:59 | |
| rpittau | oh | 13:59 |
| needssleep | since I always need more sleep | 13:59 |
| rpittau | now I get it :D | 13:59 |
| *** rpittau is now known as elfosardo | 13:59 | |
| *** dtantsur is now known as creepy_owlet | 13:59 | |
| *** efried is now known as fried_rice | 14:00 | |
| needssleep | elfosardo: so the funny thing is, I actually HAVE to take medication to sleep. Otherwise I tend to be awake for hours an hours... and then I get on the computer... and my wife yells at me eventually | 14:00 |
| elfosardo | oO | 14:01 |
| Qianbiao | needssleep i thought you are a girl :) | 14:01 |
| needssleep | Qianbiao: I am | 14:01 |
| Qianbiao | sorry, you said "you wife". no offence. | 14:02 |
| * needssleep goes and makes more coffee | 14:02 | |
| needssleep | Qianbiao: none taken :) | 14:02 |
| Qianbiao | :) | 14:03 |
| * iurygregory everyone is changing their irc nicks Xd | 14:03 | |
| elfosardo | fun for fun, this is my original nickname and it goes way back to the 90's :) | 14:04 |
| * iurygregory going to change for nickname i use in games | 14:04 | |
| *** iurygregory is now known as skolt | 14:04 | |
| *** e0ne has joined #openstack-ironic | 14:06 | |
| elfosardo | hjensas, did you test the patch? I did add the iptables rule when I was testing on bionic and it didn't work :/ | 14:09 |
| *** Qianbiao is now known as Qianbiao|afk | 14:10 | |
| *** Qianbiao|afk has quit IRC | 14:11 | |
| needssleep | I've pondered recovering my ancient nickname... But I think someone else still owns it on freenode | 14:12 |
| hjensas | elfosardo: I did test, and cleaning a node worked for me. (I will re-do it on a clean setup, just in case I had contaminated something at some point.) | 14:15 |
| *** dsneddon has joined #openstack-ironic | 14:15 | |
| *** pcaruana has joined #openstack-ironic | 14:17 | |
| *** pcaruana|afk| has joined #openstack-ironic | 14:17 | |
| *** pcaruana|afk| has quit IRC | 14:17 | |
| *** jhesketh_ has quit IRC | 14:20 | |
| *** dsneddon has quit IRC | 14:20 | |
| * needssleep needs a coffee IV | 14:24 | |
| *** hjensas is now known as skogsharald | 14:26 | |
| *** jtomasek has quit IRC | 14:36 | |
| *** rachit7 has quit IRC | 14:37 | |
| *** priteau has joined #openstack-ironic | 14:41 | |
| *** baha has joined #openstack-ironic | 14:42 | |
| *** jhesketh_ has joined #openstack-ironic | 14:46 | |
| *** jhesketh has quit IRC | 14:49 | |
| *** jhesketh has joined #openstack-ironic | 14:49 | |
| *** jhesketh_ has quit IRC | 14:51 | |
| *** jhesketh has quit IRC | 14:54 | |
| *** dsneddon has joined #openstack-ironic | 14:56 | |
| fried_rice | needssleep: FYI you can ask them to see if a nick has been used recently. They'll release it if it hasn't. I had to do that for fried_rice. | 14:56 |
| needssleep | fried_rice: good to know! | 14:57 |
| skogsharald | elfosardo: re-tested. It works for me. | 14:57 |
| * creepy_owlet loves this casual nick party | 14:57 | |
| *** w14161_1 has quit IRC | 14:58 | |
| elfosardo | skogsharald, ok, must be me doing something wrong :/ | 14:58 |
| mgoddard | I think I just witnessed the first working deploy-time RAID \o/ | 14:59 |
| mgoddard | It took 32 minutes from instance creation to ACTIVE... | 15:00 |
| needssleep | oooohhhh ahhhhhh | 15:00 |
| needssleep | ouch | 15:00 |
| needssleep | with reboots right? | 15:00 |
| mgoddard | I think I can shave a couple reboots off though | 15:00 |
| creepy_owlet | mgoddard: \o/ nice start | 15:00 |
| skogsharald | elfosardo: here is the devstack conf I used - http://paste.openstack.org/show/747880/ -- then while it's waiting for nodes to clean I add ct_target_rules = {helper: tftp, proto: udp, port: 69} in /etc/neutron/l3_agent.ini, reload devstack@q-l3.service and virsh reset node-0 to make it retry pxeboot. | 15:01 |
| elfosardo | skogsharald, thanks, I'll try that instead of adding the iptables rule manually | 15:02 |
| *** jhesketh has joined #openstack-ironic | 15:03 | |
| * arne_wiebalck wants deploy-time software RAID | 15:15 | |
| creepy_owlet | arne_wiebalck: we're getting closer to it ;) | 15:17 |
| creepy_owlet | I think it can be one of the goals for Train | 15:17 |
| arne_wiebalck | creepy_owlet: that's be great | 15:18 |
| arne_wiebalck | creepy_owlet: that'd | 15:18 |
| openstackgerrit | Merged openstack/ironic stable/rocky: Fix TypeError: __str__ returned non-string (type ImageRefValidationFailed) https://review.openstack.org/641584 | 15:19 |
| creepy_owlet | ++ we have a lot of interest downstream as well | 15:19 |
| arne_wiebalck | creepy_owlet: we should probably get the s/w RAID via cleaning done first :) | 15:20 |
| creepy_owlet | arne_wiebalck: yes, that's step #1 | 15:20 |
| arne_wiebalck | creepy_owlet: but the plan was from the beginning to move that to the deploy steps framework | 15:20 |
| arne_wiebalck | awesome work mgoddard ! | 15:21 |
| creepy_owlet | yeah, it makes little sense for actual cleaning, but since it's the same mechanism.. | 15:21 |
| arne_wiebalck | I guess there is maybe also a use cases for doing it when cleaning | 15:22 |
| * creepy_owlet thinks | 15:22 | |
| arne_wiebalck | e.g. when the layout is with the provider of the hardware and not a user/instance owner choice | 15:22 |
| creepy_owlet | arne_wiebalck: yeah, if it's set up to survive disk wiping (e.g. goes after it) | 15:23 |
| arne_wiebalck | creepy_owlet: anyway, one step after the other :) | 15:24 |
| creepy_owlet | right | 15:24 |
| *** Lucas_Gray has quit IRC | 15:25 | |
| *** Lucas_Gray has joined #openstack-ironic | 15:26 | |
| *** absubram has joined #openstack-ironic | 15:43 | |
| *** rachit7 has joined #openstack-ironic | 15:47 | |
| *** absubram has quit IRC | 15:48 | |
| *** e0ne has quit IRC | 15:51 | |
| *** rachit7 has quit IRC | 16:01 | |
| * needssleep is out of meetings for the day and needs migraine meds already | 16:03 | |
| needssleep | I was thinking that a solid goal would be focusing on eventual deploy time software raid | 16:04 |
| openstackgerrit | Jason Anderson proposed openstack/python-ironicclient master: Use endpoint_override in version negotiation https://review.openstack.org/643624 | 16:18 |
| arne_wiebalck | needssleep: and make clean time software an intermediate step to reach that cycle goal? | 16:23 |
| *** gyee has joined #openstack-ironic | 16:23 | |
| *** andrein has joined #openstack-ironic | 16:25 | |
| openstackgerrit | Jason Anderson proposed openstack/python-ironicclient master: Use endpoint_override in version negotiation https://review.openstack.org/643624 | 16:25 |
| needssleep | arne_wiebalck: huh? | 16:26 |
| openstackgerrit | Jason Anderson proposed openstack/python-ironicclient master: Use endpoint_override in version negotiation https://review.openstack.org/643624 | 16:26 |
| needssleep | could you elaborate a little, it might just be words are hard today it seems | 16:26 |
| openstackgerrit | Jason Anderson proposed openstack/python-ironicclient master: Use endpoint_override in version negotiation https://review.openstack.org/643624 | 16:27 |
| arne_wiebalck | I was just thinking that deploy time s/w RAID is the goal for Train (and clean time s/w RAID just a by-product) | 16:29 |
| needssleep | Yeah, that was kind of actually how I was thinking about it too | 16:31 |
| needssleep | enable raid steps as part of deployment has long been a major ask | 16:31 |
| arne_wiebalck | it's certainly what we would use here, too | 16:33 |
| arne_wiebalck | I'll make add some more changes (as discussed during the last weekly) and then remove the WIP | 16:34 |
| needssleep | Thanks :) | 16:39 |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/python-ironicclient master: Run jobs under python2 and python3 https://review.openstack.org/642474 | 16:43 |
| skolt | lets see what CI will think \o/ | 16:44 |
| needssleep | \o/ | 16:45 |
| skolt | not sure if the best approach but we have all tests running py2 and py3 without skip I think XD | 16:46 |
| needssleep | we do what we must some days | 16:46 |
| needssleep | some days that means doing things we also don't like :) | 16:47 |
| *** sziviani has quit IRC | 16:47 | |
| skolt | truth | 16:47 |
| elfosardo | and we're lucky someone decided to build six :) | 16:48 |
| skolt | respect++ for the person who did XD | 16:49 |
| skolt | now i wonder why the sushy emulator doesnt work on python3 CI =( | 16:50 |
| skolt | etingof, you got any ideas how we can solve the problem ? https://review.openstack.org/#/c/591828/ | 16:51 |
| patchbot | patch 591828 - sushy - Change sushy devstack job to python3 - 4 patch sets | 16:51 |
| etingof | skolt, so it's still no daemon up? -- http://logs.openstack.org/28/591828/4/check/sushy-tempest-ironic-partition-redfish-src/31f7267/controller/logs/screen-ir-cond.txt.gz?level=ERROR#_Mar_12_09_41_59_704241 | 16:53 |
| skolt | no =( | 16:53 |
| needssleep | Guys, I'm going to go run an errand that is going to take a couple hours most likely while I go get lunch as well. I'll likely write the prelude for the stein release tonight, if there is anything anyone wants me to stress specifically, please let me know | 16:53 |
| mgoddard | deploy time RAID down to 11 minutes after skipping some upgrades \o/ | 16:54 |
| needssleep | mgoddard: \o/ | 16:54 |
| mgoddard | s/upgrades/reboots/ | 16:54 |
| needssleep | heh | 16:54 |
| skolt | mgoddard, yay \o/ | 16:54 |
| needssleep | I'm all for skipping reboots if we can | 16:54 |
| mgoddard | fried brain, you know what I mean | 16:54 |
| * needssleep asks the fried brain gods to grant her migraine meds to take effect faster | 16:54 | |
| mgoddard | skipped one reboot by deleting existing config in the same step as creating new config | 16:55 |
| needssleep | is that actually safe on the idracs? | 16:55 |
| *** sburette has quit IRC | 16:55 | |
| needssleep | because of task order execution | 16:55 |
| mgoddard | then another by allowing the agent to come up from the RAID step reboot | 16:56 |
| rpioso | mgoddard: Congrats on the progress! | 16:56 |
| mgoddard | needssleep: seems to be. rpioso should know better than I | 16:56 |
| mgoddard | it's what we do in our ansible module, don't think it's caused an issue there | 16:57 |
| mgoddard | I expect this stuff is all a bit too late for Stein | 16:58 |
| skolt | etingof, have you ever tested with python3? just wondering =) | 16:58 |
| etingof | skolt, sushy-tools? yes | 16:58 |
| openstackgerrit | Merged openstack/ironic master: Add Huawei iBMC driver support https://review.openstack.org/639288 | 16:59 |
| * skolt blames devstack | 16:59 | |
| etingof | skolt, no worlddump, right? | 17:02 |
| needssleep | mgoddard: yeah, but it is a good addition for early train | 17:02 |
| needssleep | mgoddard: I would be be supper happy to cut 2-4 releases during train | 17:02 |
| needssleep | super | 17:03 |
| needssleep | yay another driver | 17:03 |
| skolt | etingof, nope | 17:03 |
| needssleep | mgoddard: I think I might be thinking ilo and the same thing as well | 17:03 |
| skolt | [ERROR] /opt/stack/ironic/devstack/lib/ironic:2020 Node did not reach manageable state in 120 seconds | 17:04 |
| mgoddard | needssleep: yeah I think it's quite similar, but I don't have hardware to test with | 17:04 |
| skolt | one thing i think is strange is it says that did not found neutron-* process, but it should be q-* i think | 17:04 |
| needssleep | mgoddard: one of them I know requires a reboot at some odd case too.. I just don't remember | 17:05 |
| * needssleep thinks it might be good to go run an errand and get away from the large adding machine with pretty graphics | 17:05 | |
| *** mjturek has quit IRC | 17:05 | |
| elfosardo | good night and have a great weekend! o/ | 17:08 |
| *** elfosardo is now known as rpittau|afk | 17:08 | |
| skolt | good night eveyone and nice weekend | 17:09 |
| *** skolt is now known as iurygregory | 17:09 | |
| etingof | skolt, that second error is the consequence of the first error | 17:09 |
| *** e0ne has joined #openstack-ironic | 17:10 | |
| *** e0ne has quit IRC | 17:11 | |
| rpioso | mgoddard: How do you delete the existing config? | 17:12 |
| mgoddard | rpioso: delete_virtual_disk(), without committing | 17:12 |
| mgoddard | rpioso: then create_virtual_disk | 17:12 |
| mgoddard | rpioso: then commit | 17:12 |
| rpioso | mgoddard: That's safe. | 17:13 |
| *** Lucas_Gray has quit IRC | 17:13 | |
| mgoddard | rpioso: great | 17:13 |
| needssleep | awesome | 17:13 |
| mgoddard | rpioso: am seeing a few odd messages though | 17:13 |
| mgoddard | Reason: size set to 'MAX' but could not allocate physical disk space: DracOperationError: DRAC operation failed. Reason: size set to 'MAX' but could not allocate physical disk space | 17:13 |
| mgoddard | rpioso: and | 17:15 |
| mgoddard | Reason: DRAC operation failed. Messages: ['Virtual Disk not found'] | 17:15 |
| rpioso | mgoddard: Those don't sound like success. | 17:15 |
| *** dsneddon has quit IRC | 17:15 | |
| mgoddard | rpioso: no | 17:15 |
| rpioso | mgoddard: But it works? | 17:16 |
| mgoddard | rpioso: not in those cases | 17:16 |
| rpioso | mgoddard: How are they different from the ones that do work? | 17:16 |
| mgoddard | rpioso: I'd guess there was no existing RAID config when it worked, or possibly I used RAID1 rather than RAID10, meaning I always had unused disks to use | 17:17 |
| mgoddard | rpioso: I think in the 'not found' case, there is an uncommitted pending vdisk | 17:18 |
| rpioso | Interesting. Perhaps there can't be an intersection between the physical disks used by a vdisk that's being deleted and a new one that's being created. I haven't tried that. | 17:19 |
| *** dsneddon has joined #openstack-ironic | 17:19 | |
| mgoddard | rpioso: it's possible | 17:20 |
| * rpioso heads to lunch | 17:22 | |
| *** rpioso is now known as rpioso|afk | 17:22 | |
| creepy_owlet | have a great weekend | 17:22 |
| *** creepy_owlet is now known as dtantsur|afk | 17:22 | |
| *** tssurya has quit IRC | 17:24 | |
| * needssleep steps away, bbl | 17:26 | |
| *** priteau has quit IRC | 17:30 | |
| arne_wiebalck | bye, everyone o/ | 17:40 |
| *** priteau has joined #openstack-ironic | 18:01 | |
| *** dougsz has quit IRC | 18:10 | |
| *** dougsz has joined #openstack-ironic | 18:20 | |
| *** mjturek has joined #openstack-ironic | 18:23 | |
| *** dsneddon has quit IRC | 18:24 | |
| *** rpioso|afk is now known as rpioso | 18:27 | |
| *** dsneddon has joined #openstack-ironic | 18:28 | |
| *** dougsz has quit IRC | 18:33 | |
| *** skogsharald is now known as hjensas | 18:40 | |
| *** e0ne has joined #openstack-ironic | 18:53 | |
| openstackgerrit | Varsha Verma proposed openstack/sushy master: Add mappings for `system_type` https://review.openstack.org/640766 | 19:05 |
| openstackgerrit | Bill Dodd proposed openstack/sushy master: Update model to support ApplyTime annotations https://review.openstack.org/643656 | 19:06 |
| *** priteau has quit IRC | 19:13 | |
| *** stevebaker has quit IRC | 19:17 | |
| *** dmellado has quit IRC | 19:17 | |
| *** e0ne has quit IRC | 19:37 | |
| *** openstack has joined #openstack-ironic | 19:43 | |
| *** ChanServ sets mode: +o openstack | 19:43 | |
| *** pcaruana has quit IRC | 19:59 | |
| *** emine__ has quit IRC | 20:14 | |
| openstackgerrit | Merged openstack/ironic-tempest-plugin master: Run all defined jobs defined in check and gate https://review.openstack.org/636169 | 20:24 |
| openstackgerrit | Merged openstack/ironic-tempest-plugin master: discovery: optional support for testing changing driver https://review.openstack.org/643264 | 20:24 |
| *** dmellado has joined #openstack-ironic | 20:29 | |
| *** stevebaker has joined #openstack-ironic | 20:41 | |
| *** whoami-rajat has quit IRC | 20:46 | |
| *** bdodd has quit IRC | 20:52 | |
| *** bdodd has joined #openstack-ironic | 20:52 | |
| *** hjensas has quit IRC | 21:17 | |
| *** hjensas has joined #openstack-ironic | 21:23 | |
| *** mjturek has quit IRC | 21:48 | |
| *** hwoarang has quit IRC | 21:49 | |
| *** hwoarang has joined #openstack-ironic | 21:50 | |
| *** baha has quit IRC | 21:51 | |
| openstackgerrit | Merged openstack/ironic-inspector master: Pass reset_interfaces when updating a driver from the rules https://review.openstack.org/641340 | 22:31 |
| needssleep | rpioso: mgoddard (since I know you were looking at idrac stuff recently): the driver constraint for the python-dracclient library is 1.3.0. Should that be 2.0.0? | 22:43 |
| rpioso | mgoddard, needsleep: Seems to me it should be 2.0.0. After all, mgoddard fixed a bug that's encountered in 2.0.0. Would you like me to propose a change? | 22:54 |
| openstackgerrit | Merged openstack/ironic stable/queens: Fix TypeError: __str__ returned non-string (type ImageRefValidationFailed) https://review.openstack.org/641585 | 22:55 |
| rpioso | needssleep: ^^^ | 22:55 |
| rpioso | mgoddard, needssleep: s/encountered in/encountered with/ | 22:55 |
| *** andrein has quit IRC | 23:04 | |
| rpioso | bdodd: \o/ re: https://review.openstack.org/643656 | 23:20 |
| patchbot | patch 643656 - sushy - Update model to support ApplyTime annotations - 1 patch set | 23:20 |
| bdodd | rpioso o/ | 23:35 |
| needssleep | rpioso: sure :) | 23:35 |
| needssleep | rpioso: a quick release note would be good as well | 23:36 |
| rpioso | bdodd: :-) | 23:36 |
| * needssleep has been working on release notes/prelude stuff this afternoon | 23:36 | |
| rpioso | needssleep: May I do it tomorrow or is it pressing? It's getting late on the East Coast. | 23:37 |
| rpioso | needssleep: I found another change that doesn't work with 1.3.0 -- https://review.openstack.org/#/c/617951 | 23:40 |
| patchbot | patch 617951 - ironic - Fix OOB introspection to use pxe_enabled flag in i... (MERGED) - 17 patch sets | 23:40 |
| rpioso | needssleep: dusty | 23:41 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add prelude and update release notes for 12.1.0 https://review.openstack.org/643692 | 23:42 |
| needssleep | rpioso: tomorrow is fine | 23:42 |
| needssleep | \o/ | 23:42 |
| rpioso | needssleep: ack | 23:43 |
| needssleep | Hopefully everyone finds https://review.openstack.org/#/c/643692/1/releasenotes/notes/prelude-to-the-stein-f25b6073b6d1c598.yaml my normal level of whimsical | 23:44 |
| patchbot | patch 643692 - ironic - Add prelude and update release notes for 12.1.0 - 1 patch set | 23:44 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!