*** nishagb has quit IRC | 00:42 | |
*** w14161_1 has joined #openstack-ironic | 01:21 | |
*** w14161_1 has quit IRC | 01:25 | |
*** gkadam_ has joined #openstack-ironic | 02:11 | |
*** gkadam_ has quit IRC | 02:17 | |
*** irclogbot_1 has quit IRC | 02:23 | |
*** edleafe has quit IRC | 02:27 | |
*** MattMan_ has quit IRC | 03:25 | |
*** MattMan_ has joined #openstack-ironic | 03:26 | |
*** whoami-rajat has joined #openstack-ironic | 03:46 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Adds config option to iLO driver to pass IPA params https://review.openstack.org/643848 | 04:10 |
---|---|---|
*** Lucas_Gray has joined #openstack-ironic | 04:20 | |
*** absubram has joined #openstack-ironic | 05:23 | |
*** absubram_ has joined #openstack-ironic | 05:27 | |
*** absubram has quit IRC | 05:28 | |
*** absubram_ is now known as absubram | 05:28 | |
*** nishagb has joined #openstack-ironic | 05:30 | |
*** rcernin has quit IRC | 05:43 | |
*** rachit7 has joined #openstack-ironic | 05:48 | |
*** rcernin has joined #openstack-ironic | 05:59 | |
*** andrein has joined #openstack-ironic | 06:04 | |
*** e0ne has joined #openstack-ironic | 06:40 | |
*** absubram has quit IRC | 06:45 | |
*** Qianbiao has joined #openstack-ironic | 06:49 | |
Qianbiao | Hello ironic | 06:51 |
Qianbiao | Hello, if i want to fix anything, should i create a task first? Or, i could just submit the patch. | 06:52 |
*** e0ne has quit IRC | 07:02 | |
*** jtomasek has joined #openstack-ironic | 07:13 | |
*** pcaruana has joined #openstack-ironic | 07:19 | |
*** hjensas has quit IRC | 07:25 | |
openstackgerrit | QianBiao Ng proposed openstack/ironic master: Optimize: HUAWEI iBMC driver utils https://review.openstack.org/643870 | 07:33 |
*** hjensas has joined #openstack-ironic | 07:36 | |
arne_wiebalck | good morning, ironic | 07:38 |
arne_wiebalck | Qianbiao: I'd say it depends, but for everything beyond | 07:39 |
arne_wiebalck | trivial things it's probably good to have a story. | 07:40 |
Qianbiao | Sure, i thought some some fixes like https://review.openstack.org/643870 | 07:40 |
patchbot | patch 643870 - ironic - Optimize: HUAWEI iBMC driver utils - 1 patch set | 07:40 |
Qianbiao | is not worth a task. | 07:41 |
arne_wiebalck | Agreed. For these, it'd be nice to have a short description in the commit message. | 07:41 |
*** iurygregory has joined #openstack-ironic | 07:49 | |
iurygregory | good morning | 07:52 |
arne_wiebalck | hey iurygregory o/ | 07:52 |
iurygregory | arne_wiebalck, o/ | 07:52 |
Qianbiao | ok <arne_wiebalck> | 07:55 |
*** Qianbiao is now known as Qianbiao|xmufive | 08:01 | |
openstackgerrit | QianBiao Ng proposed openstack/ironic master: Optimize: HUAWEI iBMC driver utils https://review.openstack.org/643870 | 08:01 |
*** Qianbiao|xmufive is now known as Qianbiao|leave | 08:01 | |
*** zhangfei has joined #openstack-ironic | 08:14 | |
rpittau|afk | good morning ironic! o/ | 08:18 |
*** rpittau|afk is now known as rpittau | 08:19 | |
iurygregory | morning rpittau o/ | 08:19 |
rpittau | hi iurygregory :) | 08:19 |
rpittau | oh interesting now zuul supports ansible 2.7 | 08:21 |
iurygregory | wasn't supported? O.o | 08:22 |
rpittau | nope | 08:26 |
*** priteau has joined #openstack-ironic | 08:26 | |
*** lennyb has joined #openstack-ironic | 08:31 | |
*** sburette has joined #openstack-ironic | 08:31 | |
*** tssurya has joined #openstack-ironic | 08:36 | |
*** andrein has quit IRC | 08:37 | |
arne_wiebalck | rpittau: good morning o/ | 09:00 |
rpittau | hi arne_wiebalck :) | 09:00 |
*** andrein has joined #openstack-ironic | 09:00 | |
iurygregory | rpittau, when you have some time https://review.openstack.org/#/c/642474/ =) | 09:03 |
patchbot | patch 642474 - python-ironicclient - Run jobs under python2 and python3 - 11 patch sets | 09:03 |
rpittau | iurygregory, nice! :) | 09:04 |
*** dougsz has joined #openstack-ironic | 09:08 | |
iurygregory | its magic \o/ | 09:09 |
*** dtantsur|afk is now known as dtantsur | 09:11 | |
*** zhangfei has quit IRC | 09:15 | |
dtantsur | morning ironic | 09:16 |
rpittau | hi dtantsur :) | 09:16 |
iurygregory | morning dtantsur | 09:16 |
mgoddard | morning all | 09:18 |
rachit7 | dtantsur: Updated my patch as you suggested. here is a link : https://review.openstack.org/#/c/639698/ | 09:18 |
patchbot | patch 639698 - ironic - Set boot_mode in node properties during OOB Intros... - 10 patch sets | 09:18 |
rpittau | hey mgoddard :) | 09:19 |
mgoddard | hi rpittau | 09:19 |
iurygregory | morning mgoddard o/ | 09:24 |
*** zhangfei has joined #openstack-ironic | 09:27 | |
mgoddard | hi iurygregory | 09:27 |
*** S4ren has joined #openstack-ironic | 09:29 | |
arne_wiebalck | hey mgoddard o/ | 09:30 |
mgoddard | hi arne_wiebalck | 09:35 |
openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 09:36 |
openstackgerrit | Mark Goddard proposed openstack/tenks master: DNM: Test libvirt-host fix for issue 13 https://review.openstack.org/643903 | 09:36 |
openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 09:39 |
*** verma-varsha has joined #openstack-ironic | 09:43 | |
*** diga has joined #openstack-ironic | 09:45 | |
diga | arne_wiebalck: dtantsur: Hi | 09:45 |
arne_wiebalck | diga: o/ | 09:45 |
diga | please go through this updated patch on realtime - https://review.openstack.org/#/c/634903/ | 09:45 |
patchbot | patch 634903 - ironic - Modify the iDRAC driver to use realtime RAID creation - 7 patch sets | 09:45 |
diga | arne_wiebalck: I updated patch by resolving your comments | 09:46 |
arne_wiebalck | diga: I have left additional comments already :) | 09:46 |
verma-varsha | Hi everyone! I, Varsha, am an outreachy applicant. I was working on the task here: https://storyboard.openstack.org/#!/story/1411272 | 09:46 |
diga | Also tested all the scenarios, able to execute all the scenarios :) | 09:46 |
verma-varsha | I wanted to know what's left to be done for the python-ironic-inspector-client | 09:47 |
diga | arne_wiebalck: :) Yes, just saw | 09:47 |
arne_wiebalck | diga: The logic looks ok to me now. | 09:48 |
diga | arne_wiebalck: Thank you | 09:48 |
diga | arne_wiebalck: I hv gone through your comment https://review.openstack.org/#/c/634903/7/ironic/tests/unit/drivers/modules/drac/test_raid.py | 09:49 |
patchbot | patch 634903 - ironic - Modify the iDRAC driver to use realtime RAID creation - 7 patch sets | 09:49 |
diga | It tries to execure multiple controllers for reboot and realtime scenario | 09:50 |
diga | arne_wiebalck: I got your point, how can we pass mock_create_virtual_disk.return_value = [{}], any idea | 09:55 |
diga | because I am getting failure in this case | 09:55 |
arne_wiebalck | diga: The point I am not clear on is: the check at the end is basically that a mock'ed function returned the mock'ed values. I don't see what this tests. | 09:55 |
iurygregory | etingof, morning o/ about the problem with sushy not working in CI with python3 I've found that radvd is not working (maybe this is the root cause) the configuration file doesn't exist http://logs.openstack.org/28/591828/4/check/sushy-tempest-ironic-partition-redfish-src/31f7267/job-output.txt.gz#_2019-03-12_09_27_05_947985 | 09:56 |
arne_wiebalck | diga: This seems to have been like this already before, though :) | 09:56 |
iurygregory | maybe a package missing for ubuntu I would say | 09:56 |
etingof | iurygregory, Router Advertisement Daemon seems irrelevant to sushy, no? o/ | 09:57 |
diga | arne_wiebalck: okay | 09:58 |
diga | arne_wiebalck: I missed return values for multiple controller response | 09:58 |
arne_wiebalck | diga: Maybe I misunderstand, but also the test above tests that the mock'ed function was called ... which the test just did :) | 09:58 |
diga | okay | 09:59 |
iurygregory | etingof, not sure tbh, this was one of the things i spotted in the logs | 09:59 |
arne_wiebalck | diga: not in the test above, but in the same test; I meant the check just above: mock_create_virtual_disk.assert_has_call | 09:59 |
arne_wiebalck | diga: Again, maybe I'm missing sth :) | 09:59 |
iurygregory | yeah python2 has the same things in logs D: | 10:00 |
dtantsur | verma-varsha: hi, responded to your email. Review speed on OpenStack is usually a bit slow, so don't get too frustrated if your patches take some time to get review. It's fine, feel free to learn related topics in the meantime. | 10:00 |
etingof | iurygregory, I think radvd deals with IPv6 routing | 10:00 |
iurygregory | yeah | 10:00 |
etingof | iurygregory, so it may or may not affect the whole thing, but sushy-emulator should happily run without it at least over IPv4 | 10:01 |
openstackgerrit | Merged openstack/python-ironicclient master: Run jobs under python2 and python3 https://review.openstack.org/642474 | 10:01 |
iurygregory | etingof, yeah, its strange that with python2 works fine and python3 dont | 10:02 |
diga | arne_wiebalck: sure :) | 10:03 |
diga | arne_wiebalck: is it fine if we can ignore this one | 10:03 |
diga | arne_wiebalck: as there are many tests are handling this scenario :) | 10:04 |
etingof | iurygregory, no logs from gunicorn? | 10:05 |
arne_wiebalck | diga: you mean to remove the test altogether? | 10:06 |
diga | arne_wiebalck: yes | 10:06 |
*** Lucas_Gray has joined #openstack-ironic | 10:06 | |
diga | arne_wiebalck: what do you think ? | 10:09 |
verma-varsha | dtantsur: Thank you for the reply! I would be really grateful if someone could find time to help me figure out the remaining work here - https://storyboard.openstack.org/#!/story/1411272 No hurries! :) | 10:09 |
iurygregory | etingof, didnt found any | 10:10 |
iurygregory | double checking | 10:10 |
arne_wiebalck | diga: I'd say 'yes' as long as there a test covering this change. You've added quite some tests. | 10:11 |
arne_wiebalck | diga: But do the other tests have the same 'issue'? | 10:11 |
arne_wiebalck | diga: I haven't checked, I focused on the code patch. | 10:12 |
dtantsur | verma-varsha: I'll defer it to etingof since he added the outreachy tag. However, you've made enough contributions already, so you can just relax and keep reading for now :) | 10:13 |
*** diga has quit IRC | 10:13 | |
etingof | iurygregory, may be start gunicorn with --error-logfile & --access-logfile ? | 10:13 |
etingof | or redirect gunicorn to syslog | 10:14 |
etingof | iurygregory, or may be even better if we run gunicorn from syslogd, we will get logs for both gunicorn and sushy-emulator | 10:15 |
etingof | ah, s/syslogd/systemd/ | 10:16 |
iurygregory | etingof, humm gotcha I will look how to do this | 10:16 |
etingof | iurygregory, https://github.com/openstack/sushy-tools/blob/master/doc/source/admin/index.rst | 10:17 |
iurygregory | etingof, we will need to update in openstack/ironic right? | 10:17 |
verma-varsha | dtantsur: Thanks for the feedback! I'll switch to reading about RAID and Redfish then and get back for discussion on the final application | 10:17 |
etingof | iurygregory, you mean to create the unit file? | 10:19 |
* etingof is +1 for verma-varsha to relax and review some patches | 10:20 | |
iurygregory | etingof, to run gunicorn from systemd no? | 10:21 |
etingof | iurygregory, well, if this is where that job starts sushy-emulator, then - yes. my thought is to invoke sushy-emulator from systemd because it logs its own stuff + stdout/err from the process it manages. that way we'd get more information on the failed process. | 10:24 |
etingof | iurygregory, we'd need to create a systemd unit file from the job, then pass it to systemd, reload it and start the service | 10:25 |
rpittau | I have serious issues connecting to r.o.o. this morning, anyone else ? | 10:26 |
iurygregory | etingof, gotcha, i will do some search about this in my free time XD | 10:26 |
dtantsur | rpittau: gets stuck for me as well | 10:26 |
rpittau | dtantsur, oh ok, feel less alone | 10:27 |
etingof | iurygregory, I am poking at devstack@bionic, let's see if I could reproduce sushy-emulator failure on py3 | 10:27 |
rpittau | problem is that I left comments and some didn't get saved :/ | 10:28 |
iurygregory | etingof, ack | 10:28 |
*** e0ne has joined #openstack-ironic | 10:28 | |
dtantsur | rpittau: you may want to check out gertty. it's not without problems, but it does have an offline mode. | 10:28 |
dtantsur | https://pypi.org/project/gertty/ | 10:28 |
rpittau | dtantsur, thanks! I'll have a look :) | 10:29 |
*** diga has joined #openstack-ironic | 10:29 | |
*** Lucas_Gray has quit IRC | 10:32 | |
*** Lucas_Gray has joined #openstack-ironic | 10:33 | |
*** verma-varsha has quit IRC | 10:44 | |
*** verma-varsha has joined #openstack-ironic | 10:45 | |
*** diga has quit IRC | 10:45 | |
*** zhangfei has quit IRC | 11:04 | |
openstackgerrit | Arne Wiebalck proposed openstack/ironic-specs master: Add details on target_raid_config for Software RAID support https://review.openstack.org/643100 | 11:16 |
*** rcernin has quit IRC | 11:46 | |
jroll | morning y'all | 11:56 |
*** rh-jelabarre has joined #openstack-ironic | 11:57 | |
*** nishagb has quit IRC | 11:59 | |
dtantsur | morning jroll | 12:07 |
*** trown|outtypewww is now known as trown | 12:09 | |
*** sburette has quit IRC | 12:11 | |
openstackgerrit | Merged openstack/python-ironic-inspector-client master: Find misteriously missing pep8 import check https://review.openstack.org/643535 | 12:15 |
*** sburette has joined #openstack-ironic | 12:18 | |
iurygregory | morning jroll | 12:18 |
*** Qianbiao has joined #openstack-ironic | 12:20 | |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: Invoke `vbmcd` in a healthy `stack` environment https://review.openstack.org/637971 | 12:21 |
Qianbiao | Hello, what should i if zuul merge gate job failed | 12:21 |
openstackgerrit | Merged openstack/bifrost master: Change uwsgi-plugin-python to uwsgi-plugin-python2 https://review.openstack.org/640780 | 12:21 |
Qianbiao | https://review.openstack.org/#/c/643870/ | 12:21 |
patchbot | patch 643870 - ironic - Optimize: HUAWEI iBMC driver utils - 2 patch sets | 12:21 |
*** edleafe has joined #openstack-ironic | 12:21 | |
dtantsur | Qianbiao: I've rechecked. The CI is not 100% stable. | 12:25 |
*** whoami-rajat has quit IRC | 12:35 | |
*** Lucas_Gray has quit IRC | 12:50 | |
*** e0ne has quit IRC | 12:51 | |
*** Lucas_Gray has joined #openstack-ironic | 12:51 | |
*** e0ne has joined #openstack-ironic | 12:52 | |
*** Lucas_Gray has quit IRC | 12:53 | |
*** bfournie has quit IRC | 12:53 | |
*** Lucas_Gray has joined #openstack-ironic | 12:53 | |
*** pcaruana|afk| has joined #openstack-ironic | 12:54 | |
*** pcaruana has quit IRC | 12:56 | |
*** jtomasek has quit IRC | 13:03 | |
*** jtomasek_ has joined #openstack-ironic | 13:03 | |
*** jtomasek_ has quit IRC | 13:05 | |
*** verma-varsha has quit IRC | 13:05 | |
*** jtomasek has joined #openstack-ironic | 13:05 | |
*** whoami-rajat has joined #openstack-ironic | 13:08 | |
openstackgerrit | Merged openstack/ironic master: Deploy Templates: factor out ironic.conductor.steps https://review.openstack.org/642059 | 13:16 |
*** needssleep is now known as TheJulia | 13:18 | |
TheJulia | Good morning everyone | 13:19 |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: Invoke `vbmcd` in a healthy `stack` environment https://review.openstack.org/637971 | 13:19 |
dtantsur | morning TheJulia. Time to start branching things? :) | 13:20 |
*** rachit7 has quit IRC | 13:20 | |
rpittau | hey TheJulia :) | 13:22 |
TheJulia | dtantsur: likely! | 13:23 |
* dtantsur looks at IPA | 13:23 | |
* dtantsur sighs and edits release notes\ | 13:24 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Add prelude and update release notes for 12.1.0 https://review.openstack.org/643692 | 13:27 |
TheJulia | I kind of thought they were okay when I read them on friday | 13:27 |
TheJulia | nothing screamed "this needs to be revised" | 13:27 |
*** bfournie has joined #openstack-ironic | 13:28 | |
dtantsur | TheJulia: I have a few quick corrections, stay tuned | 13:30 |
TheJulia | k | 13:30 |
iurygregory | morning TheJulia o/ | 13:31 |
dtantsur | is building release notes broken for everyone or just me? | 13:31 |
rpittau | dtantsur, ipa ? | 13:32 |
dtantsur | I keep getting errors like ValueError: '3.2.0' is not in list | 13:32 |
dtantsur | rpittau: essentially everything | 13:32 |
dtantsur | dhellmann: when you're online ^^ | 13:32 |
rpittau | dtantsur, I just tried with ironic and IPA and they both work fine for me | 13:36 |
dtantsur | :( | 13:36 |
rpittau | "it works on my machine" :P | 13:36 |
dtantsur | back to the times when I could test docs build only in the CI :) | 13:37 |
* TheJulia raises an eyebrow | 13:37 | |
*** hwoarang has quit IRC | 13:37 | |
*** hwoarang has joined #openstack-ironic | 13:38 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: Update release notes https://review.openstack.org/643946 | 13:40 |
dtantsur | TheJulia: this ^^ but I cannot see how it renders | 13:40 |
*** absubram has joined #openstack-ironic | 13:41 | |
*** baha has joined #openstack-ironic | 13:41 | |
TheJulia | dtantsur: re: https://review.openstack.org/#/c/643716/1 I don't think we need to worry about fixing stable branchs and ripping the backports out, given dates | 13:42 |
patchbot | patch 643716 - ironic - Advance python-dracclient version requirement - 1 patch set | 13:42 |
*** absubram_ has joined #openstack-ironic | 13:42 | |
dtantsur | TheJulia: well, if we landed changes that require a major bump, we have to | 13:43 |
dtantsur | or we can stop declaring that we support the stable policy | 13:43 |
TheJulia | look at the actual date the library was released | 13:43 |
dtantsur | TheJulia: I'm not sure how date is related. Nobody is seriously expected to make a major bump on stable/pike. | 13:43 |
* TheJulia ponders for a moment | 13:44 | |
TheJulia | when did we cut that branch | 13:44 |
dtantsur | ages ago :) | 13:44 |
TheJulia | yeah, we do at least need to pull it from pike | 13:44 |
TheJulia | looks like ages ago was 2017 days | 13:44 |
dtantsur | I don't think 2.0.0 is actually required for anything mentioned there | 13:45 |
Qianbiao | dtantsur ok thanks | 13:45 |
dtantsur | np | 13:45 |
dtantsur | I think the last time somebody from Dell mentioned that 1.5.0 (?) is required for the pxe_enabled fix | 13:45 |
*** absubram has quit IRC | 13:45 | |
*** absubram_ is now known as absubram | 13:45 | |
dtantsur | and mgoddard claims his change with status is backward compatible back to the dark ages | 13:45 |
dtantsur | so what I'm trying to do is to understand where the truth is :) | 13:46 |
TheJulia | lol | 13:46 |
TheJulia | ++ | 13:46 |
rpittau | dtantsur, for https://review.openstack.org/643946 "releasenotes: commands succeeded" and local render looks fine :) | 13:47 |
patchbot | patch 643946 - ironic-python-agent - Update release notes - 1 patch set | 13:47 |
dtantsur | magic | 13:47 |
dtantsur | dear DNS, I CAN HAZ SOM INTERNETZ PLIZ? | 13:48 |
*** pcaruana|afk| has quit IRC | 13:48 | |
dtantsur | ok, I can confirm that s/status/state/ did indeed happen in 0.1.0: https://github.com/openstack/python-dracclient/commit/9ff7c3197225d816df4c5fd04d2fcef6e39bc724 | 13:49 |
dtantsur | eeeehm, s/state/status/ (nobody expected me to do it right from the first attempt, ya?) | 13:49 |
*** mjturek has joined #openstack-ironic | 13:51 | |
dtantsur | TheJulia: are you doing the other parts of the release checklist (object versions, etc) or should I? | 13:52 |
TheJulia | dtantsur: I was likely going to get started those in a little bit | 13:54 |
TheJulia | looking at 1.5.0, it looks like that the patch for pxe_enabled has everything there in 1.5.0 | 13:54 |
dtantsur | TheJulia: actially, the BIOS parts were also introduced in 0.1.0 | 13:55 |
TheJulia | but were the nic settings introduced in 0.1.0? | 13:55 |
* dtantsur dunno | 13:55 | |
TheJulia | 1.0.0 lacks nics | 13:56 |
*** diga has joined #openstack-ironic | 13:56 | |
TheJulia | nic list settings was 1.5.0 | 13:56 |
TheJulia | file didn't exist in 1.4.0 | 13:56 |
diga | TheJulia: dtantsur: please review multiple_controller test case - https://review.openstack.org/#/c/634903/7 | 13:57 |
patchbot | patch 634903 - ironic - Modify the iDRAC driver to use realtime RAID creation - 7 patch sets | 13:57 |
dtantsur | TheJulia: which probably means we should revert the change for Pike.. | 13:57 |
diga | Need help on how to mock multiple values for return | 13:57 |
dtantsur | diga: quick guess without knowing the context: did you try side_effect = [v1, v2] ? | 13:58 |
TheJulia | eh, nics was a non-breaking additive change it looks like | 13:58 |
dtantsur | TheJulia: right, but pike has >= 1.3.0 IIRC | 13:58 |
*** e0ne has quit IRC | 13:58 | |
diga | dtantsur: no, I will try | 13:58 |
arne_wiebalck | diga: I think you just got an update on the review for this. | 13:58 |
TheJulia | dtantsur: I think your right | 13:58 |
TheJulia | september 2018 is when 1.5.0 | 13:58 |
TheJulia | so yeah, that patch needs to go from pike | 13:58 |
dtantsur | TheJulia: well, everything has >= 1.3.0, which means we need to revert like all of them..... | 13:59 |
* TheJulia goes and presses buttons | 13:59 | |
dtantsur | diga: this is re pxe_enabled ^^^ | 13:59 |
diga | arne_wiebalck: its now a solution, he is suggesting different way for same implementation but I replied to it | 13:59 |
diga | dtantsur: no, its a realtime patch | 13:59 |
arne_wiebalck | diga: oh, sorry, yes...didn't realize you replied already | 13:59 |
dtantsur | diga: no, I mean what we discuss with TheJulia is about the pxe_enabled patch | 13:59 |
dtantsur | which violates the driver-requirements on stable branches, apparently | 14:00 |
diga | dtantsur: pxe_enabled patch I abandoned because of dependancy after the discussion with Chris | 14:00 |
dtantsur | I'm pretty sure a few of them merged | 14:00 |
diga | dtantsur: yes, till pike all the cherry picks merged | 14:00 |
dtantsur | diga: right, and it seems that they all need >= 1.5.0. which means, we have to revert them, until I'm missing something. | 14:01 |
dtantsur | s/until/unless/ | 14:01 |
diga | dtantsur: I abandoned cherry pick for stable/ocata | 14:01 |
diga | dtantsur: yes | 14:01 |
diga | it needs 1.5.0 which ocata doesn't support | 14:01 |
diga | dtantsur: what time we have weekly meeting of ironic, i would like to attend | 14:02 |
dtantsur | diga: so does pike, queens and rocky | 14:02 |
dtantsur | diga: the meeting is in a bit less than 1 hour | 14:02 |
diga | dtantsur: ohh.. ok | 14:02 |
openstackgerrit | Julia Kreger proposed openstack/ironic stable/pike: Revert "Fix OOB introspection to use pxe_enabled flag in idrac driver" https://review.openstack.org/643952 | 14:02 |
dtantsur | TheJulia: this ^^ indicates "Cannot merge" for some reason | 14:03 |
diga | dtantsur: queens and rocky, python-dracclient version 1.5.0 is supported | 14:03 |
TheJulia | ugh | 14:03 |
dtantsur | diga: https://github.com/openstack/ironic/blob/master/driver-requirements.txt#L12 | 14:03 |
dtantsur | it's >= 1.3.0 even on master | 14:04 |
TheJulia | diga: 1.5.0 was released after those versions were released | 14:04 |
TheJulia | dtantsur: taking another approach :( | 14:04 |
arne_wiebalck | diga: I think Dao still points to a valid issue. It's the same I mentioned earlier today when we discussed this. | 14:04 |
diga | TheJulia: okay, I will look at 1.3.0 | 14:05 |
diga | TheJulia: dtantsur: the only dependancy we have on python-dracclient list_nic_settings() | 14:05 |
*** e0ne has joined #openstack-ironic | 14:05 | |
dtantsur | diga: right, which is 1.5.0. we have 1.3.0 everywhere. am I missing something? | 14:05 |
TheJulia | diga: which was introduced as far as I can see in 1.5.0 | 14:06 |
diga | dtantsur: okay | 14:06 |
dtantsur | diga, TheJulia, I think the way forward that does NOT imply reverting everything is to adjust the code to not fail with 1.3.0 (fall back to the old behavior). | 14:06 |
diga | TheJulia: YEs, just checked, it is found in 1.5.0 | 14:06 |
TheJulia | dtantsur: I think that is acceptable | 14:06 |
diga | Rocky version is supporting 1.5.0 ? | 14:07 |
TheJulia | diga: can you do what dtantsur requests? | 14:07 |
TheJulia | diga: 1.5.0 was released the day after rocky was released | 14:07 |
dtantsur | diga: no versions require 1.5.0, all must be compatible with 1.3.0. | 14:07 |
diga | dtantsur: sure | 14:07 |
diga | TheJulia: sure | 14:07 |
diga | dtantsur: yes | 14:07 |
dtantsur | thanks! | 14:07 |
TheJulia | Thanks | 14:07 |
* TheJulia abandons the revert | 14:07 | |
dtantsur | diga: please start with master and pings us when it's ready. then we can backport it to all branches to recover the 1.3.0 support. | 14:08 |
diga | dtantsur: TheJulia: how we can address issues for merged patches ? | 14:08 |
dtantsur | diga: create a new patch addressing it. then we backport it, and the problem is solved. | 14:08 |
diga | dtantsur: okay, got it | 14:09 |
diga | dtantsur: will do | 14:09 |
TheJulia | dtantsur: any thoughts on https://review.openstack.org/#/c/643848/1 | 14:09 |
patchbot | patch 643848 - ironic - Adds config option to iLO driver to pass IPA params - 1 patch set | 14:09 |
dtantsur | TheJulia: I was trying to avoid it :) I'd prefer we have less driver-dependent options.. Cannot we generalize it? | 14:09 |
* dtantsur hasn't seen the code, just the summary | 14:09 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: Update release notes https://review.openstack.org/643946 | 14:11 |
TheJulia | Seems like the generalization would be relatively easy | 14:13 |
TheJulia | to me at elast | 14:13 |
dtantsur | and quite useful | 14:14 |
TheJulia | yup | 14:15 |
TheJulia | on the subject of drac https://review.openstack.org/#/c/639698/10 is safe | 14:15 |
patchbot | patch 639698 - ironic - Set boot_mode in node properties during OOB Intros... - 10 patch sets | 14:15 |
diga | arne_wiebalck: I will try his approach | 14:18 |
diga | TheJulia: rachit has tested set boot_mode multiple times, I dont see any problem in it | 14:20 |
TheJulia | rpioso: Following up re: https://review.openstack.org/#/c/643716/ | 14:21 |
patchbot | patch 643716 - ironic - Advance python-dracclient version requirement - 1 patch set | 14:21 |
*** Lucas_Gray has quit IRC | 14:22 | |
*** Lucas_Gray has joined #openstack-ironic | 14:23 | |
dtantsur | TheJulia: in case you haven't seen, our Forum sessions were accepted (most for Monday, I think) | 14:24 |
NobodyCam | Good Morning Ironic'ers | 14:26 |
TheJulia | dtantsur: \o/ | 14:26 |
iurygregory | morning NobodyCam | 14:26 |
dtantsur | morning NobodyCam. hmm, early up today? | 14:27 |
TheJulia | dtantsur: We basically had the amount of slots right around the number of requested sessions | 14:27 |
NobodyCam | morning iurygregory & dtantsur | 14:27 |
NobodyCam | just a little | 14:27 |
dtantsur | TheJulia: good planning :) no ops feedback session this time though? | 14:28 |
rpioso | Good morning, ironicers | 14:28 |
NobodyCam | morning rpioso :) | 14:28 |
iurygregory | morning rpioso | 14:28 |
* rpioso catches up on the backscroll | 14:28 | |
TheJulia | dtantsur: I guess not | 14:28 |
TheJulia | dtantsur: with everythign going on, I completely forgot | 14:29 |
TheJulia | which is fine, most in the states at least know enough of us to approach the community. I think in China it might be good to run an ops feedback session | 14:29 |
TheJulia | Hopefully we'll get in-country vendors in the room as well | 14:30 |
TheJulia | *hopefully* | 14:30 |
TheJulia | but... fishbowl style engagements might not really work either | 14:30 |
dtantsur | yeah, it's a must for China. I expect enough people will want to say something. | 14:30 |
dtantsur | the ops session in Berlin was pretty lively, even though the minority of people present used or planned to use ironic | 14:31 |
rpioso | iurygregory, NobodyCam: Hey! | 14:31 |
TheJulia | Oh, well... my impression, and maybe this is just from open infra days in beijing, is that there is a whole different approach where speakers are looked upon as the single voice. I suspect for fishbowls the context will need to be set that it is an interactive discussion and to politely interject | 14:32 |
TheJulia | For the meeting, I'm think we're good to skip reviewing everything this week, I've updated the agenda as such | 14:32 |
dtantsur | rpioso: tl;dr we need an update to the pxe_enabled patches to make them work with dracclient 1.3.0 (even if "work" means falling back to the old behavior of not setting pxe_enabled) | 14:33 |
dtantsur | this is because all stable branches have >= 1.3.0 | 14:33 |
*** hjensas has quit IRC | 14:33 | |
*** pcaruana has joined #openstack-ironic | 14:33 | |
NobodyCam | :) | 14:34 |
dtantsur | TheJulia: have you seen the failure at http://logs.openstack.org/04/641104/4/check/ironic-inspector-tempest-discovery-fast-track/b400fc9/testr_results.html.gz ? | 14:38 |
dtantsur | looks somewhat suspicious to me, but maybe our test case doesn't clean up enough | 14:39 |
* iurygregory saw "Conflict with state of target resource" in some patch | 14:39 | |
iurygregory | not first time i see tbh | 14:40 |
dtantsur | yeah, we have a race in the allocation API tests that I haven't been able to triage :( | 14:41 |
*** e0ne has quit IRC | 14:41 | |
dtantsur | this is different though | 14:41 |
iurygregory | gotcha | 14:42 |
*** e0ne has joined #openstack-ironic | 14:42 | |
*** stendulker has joined #openstack-ironic | 14:47 | |
dtantsur | TheJulia: https://etherpad.openstack.org/p/IronicWhiteBoard line 190, wdym by "merge but not release in stein"? it sounds like "do not merge until we release" :) | 14:47 |
dtantsur | sorry, I'm sure why I assume it's your comment. I hope it is :) | 14:47 |
TheJulia | I have seen random failures from secruity group deletes before, so I've not paid too much attention to it yet | 14:49 |
TheJulia | dtantsur: I think I've already tried to convey that a few times, but ++ | 14:50 |
TheJulia | err | 14:50 |
TheJulia | no, we've already cut sushy-tools | 14:50 |
dtantsur | TheJulia: have we? I think we've only cut sushy | 14:50 |
* TheJulia doesn't remember | 14:50 | |
dtantsur | I'm not sure sushy-tools is even branched | 14:50 |
dtantsur | (ditto vbmc) | 14:50 |
TheJulia | it might not be | 14:51 |
* TheJulia runs unit tests on release mapping changes and crosses her fingers | 14:51 | |
*** e0ne has quit IRC | 14:53 | |
*** e0ne has joined #openstack-ironic | 14:55 | |
rpioso | dtantsur: I agree. I will discuss the approach we want to take with cdearborn. | 14:56 |
openstackgerrit | Merged openstack/metalsmith master: Accept hostname in reserve_node in addition to provision_node https://review.openstack.org/640397 | 14:59 |
*** dnuka has joined #openstack-ironic | 14:59 | |
dnuka | good morning ironicers :) | 14:59 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Update release-mappings and api version data for Stein release https://review.openstack.org/644233 | 15:00 |
iurygregory | meeting Time! | 15:00 |
TheJulia | #startmeeting ironic | 15:01 |
openstack | Meeting started Mon Mar 18 15:01:01 2019 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
TheJulia | o/ | 15:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
*** openstack changes topic to " (Meeting topic: ironic)" | 15:01 | |
iurygregory | o/ | 15:01 |
openstack | The meeting name has been set to 'ironic' | 15:01 |
etingof | o/ | 15:01 |
dnuka | o/ | 15:01 |
bdodd | o/ | 15:01 |
arne_wiebalck | o/ | 15:01 |
rpittau | o/ | 15:01 |
rpioso | \o | 15:01 |
NobodyCam | o/ | 15:02 |
stendulker | o/ | 15:02 |
TheJulia | Our agenda is a little short this week on the wiki, given this is essentially release week for ironic, hopefully this meeting will be short. :) | 15:02 |
mgoddard | \o | 15:02 |
*** kaifeng has joined #openstack-ironic | 15:02 | |
jroll | \o | 15:02 |
TheJulia | #link https://wiki.openstack.org/wiki/Meetings/Ironic | 15:02 |
*** w14161_1 has joined #openstack-ironic | 15:02 | |
kaifeng | o/ | 15:03 |
TheJulia | #topic Announcements / Reminders | 15:03 |
*** openstack changes topic to "Announcements / Reminders (Meeting topic: ironic)" | 15:03 | |
*** w14161_1 has quit IRC | 15:03 | |
TheJulia | As previously mentioned, we're working to cut our Stein stable branches early this week. If there are any blockers that anyone is aware of, please raise that visibility as soon as possible. | 15:03 |
*** root has joined #openstack-ironic | 15:03 | |
TheJulia | #info Ironic to cut stable/stein this week. | 15:04 |
*** root is now known as Guest94089 | 15:04 | |
*** Guest94089 is now known as w14161_1 | 15:04 | |
TheJulia | There is a call for help to address issues with Bionic. We'll circle back to this, but we need reviews if there are any explicit remaining items for it. | 15:04 |
*** rachit7 has joined #openstack-ironic | 15:04 | |
*** baha has quit IRC | 15:04 | |
*** e0ne has quit IRC | 15:05 | |
dtantsur | right now, IIUC, the multinode grenade job, the UEFI job and the postgres/PXE job do not pass | 15:05 |
jroll | correct | 15:06 |
jroll | #link https://review.openstack.org/#/c/642015/ | 15:06 |
patchbot | patch 642015 - ironic - Move all testing to Bionic - 2 patch sets | 15:06 |
TheJulia | #info the PTG discussion topic etherpad is still available. Some forum sessions were submitted and approved. We do not have an explicit ops feedback session this time. Ops focused contributors are welcome to engage with the ironic community during our PTG meetings. | 15:06 |
iurygregory | we have te problem with sushy with py3 in bionic too | 15:06 |
iurygregory | https://review.openstack.org/#/c/591828/ | 15:06 |
patchbot | patch 591828 - sushy - Change sushy devstack job to python3 - 4 patch sets | 15:06 |
jroll | I have a question on the bionic thing, but can come back in open discussion if folks would rather | 15:07 |
TheJulia | #link https://etherpad.openstack.org/p/DEN-train-ironic-brainstorming | 15:07 |
TheJulia | Does anyone have anything they would like to announce or remind us of? | 15:07 |
TheJulia | I'm taking silence as a no. If there is no objection, we'll jump directly to Discussion/Open Discussion with first Bionic and then any remaining py3 needs. | 15:09 |
* iurygregory that was fast XD | 15:09 | |
dnuka | :) | 15:09 |
TheJulia | #topic Discussion | 15:10 |
*** openstack changes topic to "Discussion (Meeting topic: ironic)" | 15:10 | |
TheJulia | Bionic! | 15:10 |
TheJulia | jroll: you had a question | 15:10 |
jroll | yeah, so | 15:10 |
jroll | I was under the impression that march 15, a patch would land that would force legacy jobs to bionic | 15:10 |
jroll | but I assume our gate isn't broken, so maybe I missed something? or maybe we're doing something unexpected? | 15:10 |
dtantsur | I think it did happen | 15:11 |
dtantsur | but the legacy jobs and the UEFI job hardcode xenial | 15:11 |
dtantsur | the postgres job went down, but it's non-voting | 15:11 |
jroll | oh duh, ok | 15:11 |
iurygregory | XD | 15:11 |
dtantsur | the unit tests had problems, but they got quickly fixed | 15:11 |
TheJulia | There were a couple larger community wide problems, but those were also fixed very quickly | 15:11 |
iurygregory | yeah some jobs we have the node set to xenial, most are ok to switch | 15:12 |
jroll | cool, so we need to fix these things ASAP (because stein release), but we aren't broken | 15:12 |
dtantsur | yeah, so we're running bionic where we don't set xenial explicitly | 15:12 |
*** Qianbiao has quit IRC | 15:12 | |
jroll | awesome. thanks for getting me back into the loop I fell out of :) | 15:12 |
dtantsur | jroll: last think I heard was that fixing the postgres job requires a new feature in neutron.. | 15:12 |
dtantsur | * thing | 15:12 |
iurygregory | and since we moved most of things to zuulv3 we dont have legacy jobs and by default they are bionic | 15:12 |
dtantsur | iurygregory: grenades are legacy | 15:12 |
rpittau | this is still pending though https://review.openstack.org/642315 | 15:12 |
patchbot | patch 642315 - ironic - Migrate ironic-grenade-dsvm-multinode-multitenant ... - 2 patch sets | 15:12 |
dtantsur | or at least this ^^ one | 15:13 |
jroll | dtantsur: ugh. I'm not as concerned about fixing that one, but we should | 15:13 |
iurygregory | yeah grenades cant be moved to zuulv3 at least according to documentation | 15:13 |
dtantsur | jroll: it's the only job covering PXE (as opposed to iPXE) | 15:13 |
rpittau | for postgres, we should at least revert to xenial https://review.openstack.org/642430 | 15:13 |
patchbot | patch 642430 - ironic - Pinning postgres job to xenial - 8 patch sets | 15:13 |
dtantsur | iurygregory: we can try moving them to bionic even without moving them to zuul v3 | 15:13 |
iurygregory | yeap | 15:14 |
rpittau | then 2 patches are needed, one to fix the missing package https://review.openstack.org/642507 | 15:14 |
patchbot | patch 642507 - ironic - Update dist filter for devstack ubuntu - 1 patch set | 15:14 |
jroll | dtantsur: right, which is why I'm not saying "just drop it", it just seems less important than uefi/multinode | 15:14 |
TheJulia | Is it a reasonable test that someone would install rocky on bionic, and then upgrade to stein? | 15:14 |
jroll | I wouldn't be surprised if somebody did | 15:14 |
jroll | just to keep the two upgrades distinct | 15:14 |
dtantsur | but I don't think we supported bionic back then | 15:14 |
dtantsur | so the more reasonable path is rocky -> stein -> bionic | 15:15 |
dtantsur | (because stein was tested with xenial at least to some extent) | 15:15 |
TheJulia | what dtantsur said, so I'm actually less worried about grenade | 15:15 |
TheJulia | but, jroll, your making a good point, I just don't think we have the resources to cover every case either | 15:15 |
jroll | fair nuff | 15:15 |
TheJulia | I feel like there is going to be a larger grenade discussion, or maybe not... at the ptg | 15:16 |
jroll | feels kinda late :P | 15:16 |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: Explicitly start `vbmcd` supervisor https://review.openstack.org/637971 | 15:16 |
TheJulia | Anyway, well yeah. | 15:16 |
TheJulia | jroll: maintainership is the other issue | 15:16 |
dtantsur | it seems that infra will have to keep xenial floating for stein lifetime, at least for grenades | 15:17 |
TheJulia | so if we try and migrate grenade stuffs this next cycle, that just leaves us the uefi job right? | 15:17 |
rpittau | TheJulia, dtantsur, the patch on neutron side to fix postgres (and not only that) on bionic is just a PoC for now | 15:17 |
dtantsur | TheJulia: and PXE/postgres | 15:17 |
jroll | does anyone have a link explaining why the pxe job needs a neutron feature? | 15:18 |
TheJulia | rpittau: do you ahve a ink handy? | 15:18 |
jroll | that's very confusing | 15:18 |
rpittau | https://review.openstack.org/643570 | 15:18 |
patchbot | patch 643570 - neutron - WiP/PoC - Router Namespace - Connection Tracker he... - 1 patch set | 15:18 |
TheJulia | oh jeeze that | 15:18 |
rpittau | there may be a way to do that with some hack until it's merged | 15:18 |
dtantsur | should we raise this as a transition blocker? | 15:19 |
TheJulia | The last thing I saw was a desire to discuss at the PTG... | 15:19 |
jroll | ... short term it feels like we could turn on nf_conntrack_helper | 15:19 |
dtantsur | I think Derek was looking into it, but he seems offline | 15:19 |
dtantsur | if we get blocked on the neutron patch, we certainly miss stein with it | 15:20 |
TheJulia | jroll: only set on module load.... | 15:20 |
rpittau | jroll I think that requires a reboot | 15:20 |
TheJulia | the module may be able to be unloaded and reloaded, fwiw | 15:20 |
jroll | worst case, put it in the base devstack image | 15:20 |
TheJulia | I suspect that is going to be refused | 15:20 |
TheJulia | or never reviewed | 15:20 |
*** e0ne has joined #openstack-ironic | 15:20 | |
rpittau | we can create the rule with a script, get the route namespace and add it, in some way..... | 15:20 |
TheJulia | Lets do this. Raise it as a scenario blocker, document it in a release note. Try to fix it during the next cycle. It doesn't sound like postgres, but PXE that is taking the scenario | 15:22 |
dtantsur | is the UEFI problem the same or something else? | 15:22 |
dtantsur | TheJulia: we can keep testing it on xenial, rpittau has a patch for it | 15:22 |
TheJulia | dtantsur: I _think_ it is files moving around... | 15:22 |
dtantsur | s/can/must/? | 15:22 |
rpittau | xenial works fine with the pxelinux pkg installed | 15:22 |
TheJulia | pxelinux for libvirt's usage? | 15:23 |
TheJulia | dtantsur: must could work, we need to document it as a known issue | 15:23 |
dtantsur | ideally, we should update our docs with how to avoid the conntrack problem on bionic | 15:24 |
dtantsur | since it's really just a new installation procedure for PXE boot | 15:24 |
*** baha has joined #openstack-ironic | 15:24 | |
TheJulia | dtantsur: yeah, we don't need docs at this moment, they can get backported too | 15:24 |
TheJulia | release note is slightly more important | 15:25 |
dtantsur | probably. although it's not a bug we can ever fix. | 15:25 |
dtantsur | (if I get it right?) | 15:25 |
rpittau | that's not even a bug, it's "security enhancement" xD | 15:25 |
dtantsur | \o/ | 15:25 |
TheJulia | so uefi, yeah is libvirt fun | 15:26 |
TheJulia | the actual loader has a very limited text output | 15:27 |
TheJulia | heh, joy | 15:27 |
* dtantsur knows the top priority for this week now :) | 15:27 | |
TheJulia | I think that means the scenario was broken by the libvirt packages and likely can be fixed, but it doesn't mean the scenario is just completely broken. That being said, I think we can proceed to release with no additional note for uefi | 15:28 |
TheJulia | Can I get a volunteer to write a small known issue release note regarding the security enhancement in bionic? | 15:28 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Train: Bump semver for 12.2.0 to be master https://review.openstack.org/644246 | 15:28 |
rpittau | TheJulia, I can take care of that | 15:29 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Train: Bump semver to 12.2.0 for master https://review.openstack.org/644246 | 15:29 |
*** absubram has quit IRC | 15:29 | |
TheJulia | rpittau: thanks! | 15:29 |
TheJulia | Are we in agreement, and is there anything else pressing to discuss today? | 15:29 |
*** absubram has joined #openstack-ironic | 15:29 | |
dtantsur | TheJulia: priorities for the week, if we have any? | 15:29 |
TheJulia | dtantsur: none really, just get the release out I think | 15:29 |
* dtantsur imagines punching a bear out of the door | 15:30 | |
TheJulia | lol | 15:30 |
TheJulia | so can we get some artwork for this?!? | 15:30 |
TheJulia | lol | 15:30 |
TheJulia | #topic Open Discussion | 15:30 |
*** openstack changes topic to "Open Discussion (Meeting topic: ironic)" | 15:30 | |
dtantsur | cri.. | 15:31 |
dtantsur | .. | 15:32 |
iurygregory | ... | 15:32 |
dtantsur | ..ckets? | 15:32 |
jroll | love me some crickets | 15:32 |
TheJulia | \o/ | 15:33 |
TheJulia | In that case, thanks everyone! Time to go make more coffee! | 15:33 |
iurygregory | time for more coffee and more meetings yay | 15:34 |
rpittau | oh yeah I have time for proper coffee \o/ | 15:34 |
jroll | thanks TheJulia :) | 15:34 |
iurygregory | tks | 15:35 |
TheJulia | Thanks everyone! | 15:35 |
TheJulia | #endmeeting | 15:35 |
*** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75 | Contributors are generally present between 6 AM and 12 AM UTC, If we do not answer, please feel free to pose questions to openstack-dev mailing list." | 15:35 | |
openstack | Meeting ended Mon Mar 18 15:35:10 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:35 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/ironic/2019/ironic.2019-03-18-15.01.html | 15:35 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ironic/2019/ironic.2019-03-18-15.01.txt | 15:35 |
openstack | Log: http://eavesdrop.openstack.org/meetings/ironic/2019/ironic.2019-03-18-15.01.log.html | 15:35 |
openstackgerrit | Merged openstack/ironic-inspector master: Remove PXE filter logging https://review.openstack.org/643494 | 15:35 |
openstackgerrit | Merged openstack/ironic master: Add prelude and update release notes for 12.1.0 https://review.openstack.org/643692 | 15:35 |
openstackgerrit | Merged openstack/ironic-python-agent master: Update release notes https://review.openstack.org/643946 | 15:35 |
dtantsur | TheJulia: shall we ^^^? | 15:35 |
rpioso | dtantsur: Is driver_requirements.txt immutable on stable branches? | 15:36 |
dnuka | o/ | 15:37 |
*** dnuka has quit IRC | 15:37 | |
dtantsur | rpioso: not entirely, but it should be approached with extreme care | 15:37 |
dtantsur | the same logic applies as with the regular requirements: any substantial version bump can snow ball into more bumps and regressions | 15:38 |
TheJulia | rpittau: essentially but fix revisions are good reason, but when something is not a bug then it is questionable and that also involves cutting stable branch based version for those libraries. Adding features to those libraries for that is... less than ideal. | 15:39 |
rpittau | rpioso, I think this was for you ^^^ | 15:39 |
TheJulia | dtantsur: The mapping changes should still be in CI | 15:39 |
dtantsur | TheJulia: I'm proposing to start with IPA, then probably inspector | 15:40 |
TheJulia | https://review.openstack.org/#/c/644233/ | 15:40 |
patchbot | patch 644233 - ironic - Update release-mappings and api version data for S... - 1 patch set | 15:40 |
TheJulia | dtantsur: ++, ironic will need ^^^ patch first | 15:40 |
rpioso | rpittau: Indeed :-) Thank you! | 15:40 |
dtantsur | TheJulia: yeah, I'm following it | 15:40 |
rpioso | dtantsur, TheJulia: Our view is that https://review.openstack.org/#/c/617951/ is a bug fix. | 15:42 |
patchbot | patch 617951 - ironic - Fix OOB introspection to use pxe_enabled flag in i... (MERGED) - 17 patch sets | 15:43 |
dtantsur | rpioso: sure. but it is orthogonal to the requirements question. | 15:43 |
rpioso | dtantsur, TheJulia: It requires a minor version bump to python-dracclient. As dtantsur, suggested, we will closely re-review to ensure it doesn't introduce any incompatibilities on the stable branches. | 15:44 |
dtantsur | sigh | 15:44 |
* rpioso doesn't understand the orthogonality | 15:44 | |
dtantsur | rpioso: you need to make the code compatible with 1.3.0, the only other option is to revert all them, and nobody wants it. | 15:44 |
dtantsur | the feature version bump is not justified | 15:45 |
rpioso | dtantsur: That bug fix requires 1.4.0, a minor, backwards compatible version. | 15:45 |
dtantsur | rpioso: the situation is very simple: we promise the consumers to not break things on stable branches. We just did. If they have dracclient 1.3.0 (which we promised would be compatible), they'll have inspection broken. | 15:45 |
rpioso | dtantsur: The node fails to boot. | 15:46 |
*** kaifeng has quit IRC | 15:47 | |
dtantsur | rpioso: so, my suggestion was: rework the code to issue a warning and fall back to the old behavior if dracclient < 1.5.0 | 15:48 |
* rpioso welcomes a path forward that fixes the bug on stable branches and fulfills our promise | 15:48 | |
dtantsur | and we can issue a release note that says "if you experience this problem, please update to dracclient >= 1.5.0" | 15:48 |
dtantsur | this is strictly better than what we have now: >= 1.5.0 will still be fixed, while < 1.5.0 will be less broken. | 15:49 |
rpioso | dtantsur: I agree that what we have now is broken. | 15:53 |
rpioso | dtantsur: Using stable/rocky as an example, couldn't it be fixed by 1) reverting the cherry pick and 2) Reapplying the cherry-pick and bumping the requirement to >= 1.5.0? | 15:55 |
dtantsur | rpioso: "bumping requirement" is the problem. the content of driver-requirements is not immediately applied to every consumer out there. | 15:56 |
dtantsur | people will have 1.3.0, people will have 1.3.0 for the reasons they cannot control (packaging, bureaucracy, etc). | 15:56 |
dtantsur | I'm not sure why you resist to a 10 lines fix, to be honest. Landing a revert, then landing the change again sounds like more work than that. | 15:57 |
rpioso | dtantsur: I'm trying to understand. | 15:57 |
* rpioso is not familiar with how consumers manage updates to stable branch releases. | 15:58 | |
dtantsur | okay, if it makes things easier, let's consider *requirements.txt immutable on stable branches and try to figure the way out | 15:58 |
dtantsur | rpioso: a simple example: RDO Pike has dracclient 1.3.2 | 15:59 |
dtantsur | we cannot control everyone out there, but the usual expectation is that $ yum update openstack-ironic-conductor on a stable branch will not bring regressions | 16:00 |
* dtantsur has to jump on a long meeting | 16:00 | |
* rpioso needs to grab some lunch | 16:01 | |
*** rpioso is now known as rpioso|afk | 16:01 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Adds config option to iLO driver to pass IPA params https://review.openstack.org/643848 | 16:05 |
*** stendulker has quit IRC | 16:07 | |
*** e0ne has quit IRC | 16:14 | |
*** diga has quit IRC | 16:17 | |
*** e0ne has joined #openstack-ironic | 16:19 | |
*** andrein has quit IRC | 16:22 | |
*** hjensas has joined #openstack-ironic | 16:30 | |
*** tssurya has quit IRC | 16:44 | |
*** Lucas_Gray has quit IRC | 16:47 | |
*** mgoddard has quit IRC | 17:02 | |
*** trown is now known as trown|lunch | 17:03 | |
*** mgoddard has joined #openstack-ironic | 17:08 | |
*** rachit7 has quit IRC | 17:09 | |
*** sburette has quit IRC | 17:10 | |
*** e0ne has quit IRC | 17:14 | |
*** nishagb has joined #openstack-ironic | 17:19 | |
*** rpioso|afk is now known as rpioso | 17:25 | |
* rpioso has finished lunch, but is not satiated | 17:29 | |
rpittau | good night! o/ | 17:43 |
*** rpittau is now known as rpittau|afk | 17:43 | |
*** S4ren has quit IRC | 17:46 | |
openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 17:53 |
*** gyee has joined #openstack-ironic | 17:58 | |
*** dougsz has quit IRC | 17:59 | |
*** trown|lunch is now known as trown | 18:00 | |
*** sthussey has joined #openstack-ironic | 18:06 | |
* TheJulia returns from long meeting, and considers lunch() | 18:07 | |
dustinc | ^ | 18:13 |
*** dustinc is now known as dustinc|lunch | 18:13 | |
openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 18:17 |
*** iurygregory has quit IRC | 18:17 | |
*** jtomasek has quit IRC | 18:18 | |
*** andrein has joined #openstack-ironic | 18:18 | |
*** hjensas has quit IRC | 18:19 | |
*** jtomasek has joined #openstack-ironic | 18:19 | |
*** dtantsur is now known as dtantsur|afk | 18:23 | |
dtantsur|afk | \o | 18:23 |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: Explicitly start `vbmcd` supervisor https://review.openstack.org/637971 | 18:29 |
*** gmann is now known as gmann_afk | 18:34 | |
*** tram- has joined #openstack-ironic | 18:41 | |
nishagb | Dear Dmitry Tantsur and Ilya Etingof, I have sent you both an email regarding my interest in Outreachy projects. Please do guide me. | 18:49 |
*** cdearborn has joined #openstack-ironic | 18:52 | |
*** gmann_afk is now known as gmann | 18:56 | |
*** andrein has quit IRC | 19:06 | |
*** tram- has quit IRC | 19:17 | |
*** dougsz has joined #openstack-ironic | 19:17 | |
*** dustinc|lunch is now known as dustinc | 19:23 | |
openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 19:29 |
*** hjensas has joined #openstack-ironic | 19:44 | |
*** dougsz has quit IRC | 19:50 | |
*** whoami-rajat has quit IRC | 19:55 | |
*** andrein has joined #openstack-ironic | 19:55 | |
*** tram- has joined #openstack-ironic | 19:59 | |
*** tram- has quit IRC | 20:02 | |
*** tram-- has joined #openstack-ironic | 20:05 | |
*** irclogbot_1 has joined #openstack-ironic | 20:12 | |
*** Lucas_Gray has joined #openstack-ironic | 20:21 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Update release-mappings and api version data for Stein release https://review.openstack.org/644233 | 20:24 |
*** irclogbot_1 has quit IRC | 20:25 | |
*** tram-- has quit IRC | 20:26 | |
*** irclogbot_1 has joined #openstack-ironic | 20:27 | |
*** e0ne has joined #openstack-ironic | 20:28 | |
openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 20:37 |
TheJulia | nishagb: They are both in ?CEST? so you will likely have a response tomorrow. | 20:39 |
*** e0ne has quit IRC | 20:41 | |
*** chargedneutron_ has joined #openstack-ironic | 20:45 | |
nishagb | TheJulia: Thanks for the information. I would wait till tomorrow :) | 20:46 |
*** pcaruana has quit IRC | 20:54 | |
*** tram- has joined #openstack-ironic | 20:57 | |
*** trown is now known as trown|outtypewww | 20:59 | |
*** mjturek has quit IRC | 21:04 | |
*** baha has quit IRC | 21:05 | |
*** Lucas_Gray has quit IRC | 21:06 | |
*** rh-jelabarre has quit IRC | 21:07 | |
*** priteau has quit IRC | 21:12 | |
*** mgoddard has quit IRC | 21:20 | |
*** mgoddard has joined #openstack-ironic | 21:26 | |
*** irclogbot_1 has quit IRC | 21:26 | |
*** irclogbot_1 has joined #openstack-ironic | 21:28 | |
openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 21:44 |
*** bfournie has quit IRC | 21:48 | |
*** cdearborn has quit IRC | 22:02 | |
*** jtomasek has quit IRC | 22:05 | |
*** tram- has quit IRC | 22:20 | |
*** chargedneutron_ has quit IRC | 22:54 | |
*** rcernin has joined #openstack-ironic | 23:04 | |
*** andrein has quit IRC | 23:05 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!