*** igordc has quit IRC | 00:06 | |
*** k_mouza has joined #openstack-ironic | 00:23 | |
*** k_mouza has quit IRC | 00:28 | |
*** kaifeng has joined #openstack-ironic | 01:03 | |
*** yedongcan has joined #openstack-ironic | 01:48 | |
*** jdandrea has quit IRC | 02:01 | |
*** ociuhandu has joined #openstack-ironic | 02:13 | |
*** cdearborn has quit IRC | 02:15 | |
*** ociuhandu has quit IRC | 02:17 | |
*** rloo has quit IRC | 02:32 | |
*** gyee has quit IRC | 04:20 | |
*** TxGirlGeek has quit IRC | 04:42 | |
*** tzumainn has quit IRC | 05:33 | |
*** Lucas_Gray has joined #openstack-ironic | 06:58 | |
*** openstack has joined #openstack-ironic | 07:19 | |
*** ChanServ sets mode: +o openstack | 07:19 | |
*** Lucas_Gray has quit IRC | 07:20 | |
*** openstack has joined #openstack-ironic | 07:43 | |
*** ChanServ sets mode: +o openstack | 07:43 | |
openstackgerrit | Maël Kimmerlin proposed openstack/ironic master: Redfish: Add root_prefix to Sushy https://review.opendev.org/707342 | 07:45 |
---|---|---|
openstackgerrit | Maël Kimmerlin proposed openstack/ironic master: Redfish: Add root_prefix to Sushy https://review.opendev.org/707342 | 07:46 |
*** zzzeek has joined #openstack-ironic | 07:51 | |
*** zzzeek has quit IRC | 07:54 | |
*** Lucas_Gray has quit IRC | 07:55 | |
*** zzzeek has joined #openstack-ironic | 07:56 | |
arne_wiebalck | Good morning, ironic! | 07:57 |
*** Lucas_Gray has joined #openstack-ironic | 07:57 | |
openstackgerrit | Arne Wiebalck proposed openstack/ironic-python-agent master: tgtd session detach test fails on Centos7 https://review.opendev.org/686588 | 07:57 |
*** tesseract has joined #openstack-ironic | 08:06 | |
*** tkajinam has quit IRC | 08:11 | |
*** amoralej|off is now known as amoralej | 08:24 | |
gudrutis2 | o/ | 08:33 |
*** arne_wiebalck has quit IRC | 08:36 | |
*** vdrok has quit IRC | 08:36 | |
*** arne_wiebalck has joined #openstack-ironic | 08:37 | |
*** vdrok has joined #openstack-ironic | 08:37 | |
*** rpittau|afk is now known as rpittau | 08:37 | |
rpittau | good morning ironic! o/ | 08:37 |
*** etingof has quit IRC | 08:38 | |
iurygregory | arne_wiebalck, gudrutis2 rpittau o/ | 08:39 |
rpittau | hey iurygregory :) | 08:39 |
arne_wiebalck | hey iurygregory rpittau o/ | 08:43 |
rpittau | hey arne_wiebalck :) | 08:43 |
*** lucasagomes has joined #openstack-ironic | 08:58 | |
*** Lucas_Gray has quit IRC | 09:00 | |
*** dougsz has joined #openstack-ironic | 09:00 | |
*** mbeierl has quit IRC | 09:03 | |
*** mbeierl has joined #openstack-ironic | 09:03 | |
*** Lucas_Gray has joined #openstack-ironic | 09:07 | |
*** ociuhandu has joined #openstack-ironic | 09:08 | |
*** hjensas has joined #openstack-ironic | 09:09 | |
*** rachit7 has joined #openstack-ironic | 09:14 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Force DIB_PYTHON_VERSION to 3 for Debian https://review.opendev.org/705773 | 09:18 |
openstackgerrit | Merged openstack/ironic master: Use FIPS-compatible SHA256 for comparing files https://review.opendev.org/708388 | 09:20 |
*** ociuhandu has quit IRC | 09:25 | |
*** ociuhandu has joined #openstack-ironic | 09:27 | |
*** k_mouza has joined #openstack-ironic | 09:37 | |
*** k_mouza has quit IRC | 09:37 | |
*** k_mouza has joined #openstack-ironic | 09:38 | |
*** dtantsur|afk is now known as dtantsur | 09:38 | |
dtantsur | morning ironic | 09:38 |
gudrutis2 | dtantsur: o/ | 09:42 |
iurygregory | dtantsur, morning o/ | 09:42 |
*** derekh has joined #openstack-ironic | 09:43 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/train: Use FIPS-compatible SHA256 for comparing files https://review.opendev.org/708600 | 09:56 |
gudrutis2 | dtantsur: I was wondering if `ironic-python-agent-builder` is recommended over `disk-image-create` | 10:00 |
dtantsur | gudrutis2: if it covers your case - yes | 10:01 |
dtantsur | I'd recommend disk-image-create as an advanced option | 10:01 |
gudrutis2 | in theory, all environmental variables that use to work with diskimage-builder should work with ironic-python-agent-builder, rigth? | 10:02 |
gudrutis2 | except ELEMENT_PATH :) | 10:02 |
*** ociuhandu has quit IRC | 10:03 | |
dtantsur | gudrutis2: we do overwrite a couple of them, but yes. and ELEMENTS_PATH should work as well :) | 10:03 |
gudrutis2 | dtantsur: nope, it is being overwritten https://opendev.org/openstack/ironic-python-agent-builder/src/branch/master/ironic_python_agent_builder/__init__.py#L59 | 10:04 |
dtantsur | gudrutis2: right, it should work, it just doesn't because of a bug :) | 10:04 |
openstackgerrit | Arne Wiebalck proposed openstack/ironic-python-agent master: tgtd session detach test fails on Centos7 https://review.opendev.org/686588 | 10:04 |
dtantsur | we should take the existing ELEMENTS_PATH and prepend our path to it instead of overwriting | 10:05 |
dtantsur | patches welcome (or I can get to it later today) | 10:05 |
gudrutis2 | prepend like `ELEMENTS_PATH="path1:path2"`? | 10:08 |
dtantsur | gudrutis2: I *think* so, I'm not sure. Maybe DIB docs state it somewhere? | 10:11 |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: Fix None for instance_uuid label https://review.opendev.org/706346 | 10:16 |
iurygregory | grenade could help me a little bin in stable/stein without failling during "Running base smoke test" -.-' | 10:19 |
iurygregory | and ofc is test_network_basic_ops XD | 10:21 |
*** Lucas_Gray has quit IRC | 10:34 | |
*** derekh has quit IRC | 10:37 | |
*** Lucas_Gray has joined #openstack-ironic | 10:38 | |
*** k_mouza has quit IRC | 10:40 | |
*** k_mouza has joined #openstack-ironic | 10:40 | |
gudrutis2 | dtantsur: I tried to build image using IPAB and it failed to unmount: `ERROR: failed to umount the /tmp/dib_image.d5MPE8w8 tmpfs mount point` | 10:50 |
gudrutis2 | I should say I am running it in a docker container | 10:50 |
dtantsur | gudrutis2: I'm not sure DIB works in containers, to be honest | 10:51 |
gudrutis2 | DIB works | 10:52 |
dtantsur | well, IPA-builder uses a plain DIB | 10:52 |
dtantsur | you've seen the script, it merely builds the command line and a few environment variables | 10:52 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Test with the new DIB centos8 support https://review.opendev.org/708610 | 10:53 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: [DNM] Test with the new DIB centos8 support https://review.opendev.org/708610 | 10:53 |
gudrutis2 | Yes, so I am puzzled why it gives so many issue. In theory, it should be interchangeable with DIB | 10:53 |
dtantsur | exactly (modulo the ELEMENTS_PATH issue) | 10:54 |
dtantsur | if plain DIB works, just stick with it I guess? | 10:54 |
dtantsur | rpittau: FYI we have our jobs on DIB, you can just watch them | 10:55 |
*** Lucas_Gray has quit IRC | 10:55 | |
*** Lucas_Gray has joined #openstack-ironic | 10:58 | |
rpittau | dtantsur: yeah, I know, I thought if anything needs to be changed I could've tested it on a separate patch in ipa-B preemptively | 10:59 |
dtantsur | rpittau: we don't use the new element, do we? we're using centos-minimal (which is probably right) | 11:00 |
*** samc-bbc has quit IRC | 11:01 | |
rpittau | dtantsur: yeah, we use that | 11:04 |
rpittau | I mean centos-minimal | 11:04 |
rpittau | well I guess it's useless to test then :) | 11:09 |
dtantsur | there may be regressions in centos7, I guess.. | 11:09 |
rpittau | the test for centos7 is failing though | 11:09 |
rpittau | heh yeah that :) | 11:09 |
rpittau | but it might be because we still running on master and not on train | 11:10 |
dtantsur | rpittau: could you rebase https://review.opendev.org/#/c/706292/ on master then? it's ready to be merged. | 11:11 |
patchbot | patch 706292 - ironic-python-agent-builder - Use train branch for centos7 job - 4 patch sets | 11:11 |
rpittau | dtantsur: I will, but not sure it will pass without the virtualenv workaround | 11:11 |
dtantsur | rpittau: it uses to pass before the python 3 thing, we shouldn't it now? | 11:12 |
dtantsur | * why | 11:12 |
dtantsur | I still cannot wrap my head around the virtualenv patch. I have a gut feeling we're missing something obvious that will render it unnecessary.. | 11:13 |
rpittau | dtantsur: I tried multiple things for that, of course I might've missed something, the only thing that worked was upgrading wheel and setuptools | 11:14 |
dtantsur | rpittau: looking at https://zuul.opendev.org/t/openstack/build/74427d60106c46e6b4045606f5360d74/log/job-output.txt have you tried installing python3-wheel? I don't think it's pulled by default in ubuntu (similar to python3-venv). | 11:15 |
rpittau | I saw reports of the same issue and it looks like it might be a bug in how the virtualenv is managed in certain cases for python 3.6.9 and forward | 11:16 |
dtantsur | I seem to remember I had to install it when I played with a container | 11:16 |
rpittau | dtantsur: I'll give that a try, I don't remember if I tried that before | 11:16 |
dtantsur | it seems that it's not installed, just recommended: https://zuul.opendev.org/t/openstack/build/74427d60106c46e6b4045606f5360d74/log/job-output.txt#2995 | 11:16 |
rpittau | dtantsur: ok, let me test it in the test patch I have | 11:17 |
dtantsur | rpittau: I tried installing IPA from source in a bionic container and I think I succeeded without pip upgrades | 11:17 |
dtantsur | but with installing stuff from packages | 11:17 |
rpittau | dtantsur: that worked for me too, but not on CI afterwards :/ | 11:18 |
dtantsur | lovely | 11:18 |
rpittau | "it works on my container" is getting old already..... | 11:18 |
iurygregory | it works on devstack is better XD | 11:19 |
iurygregory | s/on/in | 11:19 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: [DNM] test bionic job https://review.opendev.org/708413 | 11:27 |
*** hjensas has quit IRC | 11:30 | |
rpittau | dtantsur: same issue https://d0d8bc9ca56f7cbc677b-839132c9f2f257823716e8f40ef80a9a.ssl.cf5.rackcdn.com/708413/2/check/ironic-python-agent-check-image-dib-ubuntu/0e4a02b/job-output.txt | 11:38 |
openstackgerrit | Verification of a change to openstack/ironic-tempest-plugin failed: Remove the SW RAID configuration https://review.opendev.org/706961 | 11:39 |
*** rpittau is now known as rpittau|bbl | 11:40 | |
dtantsur | rpittau|bbl: maybe we should enable site-packages in the venv? | 11:42 |
dtantsur | I'm still not convinced we have to update packages; we simply miss one of them in the venv | 11:42 |
dtantsur | (damn, ubuntu, why are you like that?) | 11:43 |
dtantsur | wait, wut, you're actually failing while installing wheel itself Oo | 11:44 |
rpittau|bbl | dtantsur: yeah... that's the problem :/ | 11:45 |
dtantsur | also wut https://github.com/pypa/pip/issues/7309 | 11:46 |
dtantsur | rpittau|bbl: I think I'm starting to get understanding what we should do. I think we should split installing setuptools (with constraints, not just --upgrade) from everything else | 11:47 |
dtantsur | we can probably do the same with pip in the venv | 11:48 |
dtantsur | rpittau|bbl: I can try updating your patch if you're busy | 11:48 |
rpittau|bbl | dtantsur: sure, I'm yelling at my bank at the moment :/ | 11:50 |
dtantsur | rpittau|bbl: good luck :( | 11:50 |
*** ajya[m] has quit IRC | 11:51 | |
*** ajya[m] has joined #openstack-ironic | 11:53 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: [DNM] test bionic job https://review.opendev.org/708413 | 11:54 |
dtantsur | let's try this variation ^^ | 11:54 |
dtantsur | I'll add the centos 7 job to be sure we're not breaking it | 11:56 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: [DNM] test bionic job https://review.opendev.org/708413 | 11:57 |
*** Lucas_Gray has quit IRC | 12:02 | |
*** hjensas has joined #openstack-ironic | 12:03 | |
*** yedongcan has quit IRC | 12:08 | |
*** ociuhandu has joined #openstack-ironic | 12:10 | |
*** ociuhandu has quit IRC | 12:11 | |
*** ociuhandu has joined #openstack-ironic | 12:12 | |
dtantsur | rpittau|bbl: ehhhhhhmmmm. my setuptools hack didn't work because setuptools is not in constraints. but the ubuntu job is green Oo https://955f32f8268e5d475e65-6c8f4c6e546a0854b4c11cc7c78829ca.ssl.cf5.rackcdn.com/708413/4/check/ironic-python-agent-check-image-dib-ubuntu/1ec2f0a/job-output.txt | 12:13 |
dtantsur | I wonder if removing pip upgrade actually fixes it Oo | 12:13 |
openstackgerrit | Ankit Kumar proposed openstack/ironic-tempest-plugin master: Test cases for iLO driver in standalone ironic https://review.opendev.org/708379 | 12:13 |
dtantsur | what's the... | 12:14 |
*** mkowalski has quit IRC | 12:16 | |
dtantsur | centos 7 has also passed this, lemme try removing the setuptools hack completely | 12:16 |
*** ociuhandu has quit IRC | 12:16 | |
*** mgoddard has quit IRC | 12:16 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: [DNM] test bionic job https://review.opendev.org/708413 | 12:16 |
*** mkowalski has joined #openstack-ironic | 12:17 | |
*** mgoddard has joined #openstack-ironic | 12:21 | |
*** Lucas_Gray has joined #openstack-ironic | 12:24 | |
*** derekh has joined #openstack-ironic | 12:25 | |
openstackgerrit | Merged openstack/ironic-python-agent master: Catch ValueError for FIPS 140-2 mode https://review.opendev.org/708492 | 12:29 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent stable/train: Catch ValueError for FIPS 140-2 mode https://review.opendev.org/708637 | 12:34 |
*** etingof has joined #openstack-ironic | 12:36 | |
*** rcernin has quit IRC | 12:37 | |
openstackgerrit | Maël Kimmerlin proposed openstack/ironic master: Redfish: Add root_prefix to Sushy https://review.opendev.org/707342 | 12:38 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Provide a foundation for purely out-of-band deploy/clean steps execution https://review.opendev.org/708638 | 12:41 |
dtantsur | rpittau|bbl: lovely, not upgrading pip seems to help: https://review.opendev.org/#/c/708413/5/dib/ironic-python-agent-ramdisk/install.d/ironic-python-agent-ramdisk-source-install/60-ironic-python-agent-ramdisk-install | 12:41 |
patchbot | patch 708413 - ironic-python-agent-builder - [DNM] test bionic job - 5 patch sets | 12:41 |
dtantsur | Oo | 12:41 |
*** rh-jelabarre has joined #openstack-ironic | 12:50 | |
*** Goneri has joined #openstack-ironic | 12:54 | |
iurygregory | black magic... | 12:57 |
rpittau|bbl | oh well | 13:02 |
*** rpittau|bbl is now known as rpittau | 13:02 | |
rpittau | dtantsur: I'm going to update the main workaround patch with that | 13:04 |
dtantsur | ++ | 13:04 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Workaround for Python virtualenv https://review.opendev.org/705060 | 13:10 |
dtantsur | rpittau: you need to update the commit message ^^^ | 13:10 |
rpittau | yeah | 13:10 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Provide a foundation for purely out-of-band deploy/clean steps execution https://review.opendev.org/708638 | 13:11 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Upgrade pip if it's too old https://review.opendev.org/705060 | 13:11 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Use train branch for centos7 job https://review.opendev.org/706292 | 13:16 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Make Ubuntu Bionic job green again https://review.opendev.org/705627 | 13:16 |
*** ociuhandu has joined #openstack-ironic | 13:23 | |
*** amoralej is now known as amoralej|lunch | 13:31 | |
*** mbeierl has quit IRC | 13:36 | |
openstackgerrit | Merged openstack/ironic stable/train: Use FIPS-compatible SHA256 for comparing files https://review.opendev.org/708600 | 13:36 |
*** mbeierl has joined #openstack-ironic | 13:36 | |
*** mbeierl has quit IRC | 13:37 | |
*** mbeierl has joined #openstack-ironic | 13:37 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: WIP: Generalize clean step functions to support deploy steps https://review.opendev.org/698768 | 13:38 |
*** rloo has joined #openstack-ironic | 13:41 | |
*** mbeierl has quit IRC | 13:42 | |
*** khansa has joined #openstack-ironic | 13:44 | |
*** Goneri has quit IRC | 13:47 | |
dtantsur | Trying to make both in-band and out-of-band steps work together is a nightmare... | 13:48 |
TheJulia | dtantsur: delineating out of band a little more help at all? | 13:58 |
TheJulia | reason being we do need to tag them all for identification so we can delay booting | 13:58 |
TheJulia | things like reset the bmc kind of stuff | 13:58 |
*** amoralej|lunch is now known as amoralej | 14:00 | |
*** khansa has quit IRC | 14:15 | |
openstackgerrit | Riccardo Pittau proposed openstack/bifrost master: [DNM] getting some libvirt info https://review.opendev.org/707162 | 14:15 |
*** jdandrea has joined #openstack-ironic | 14:17 | |
*** Lucas_Gray has quit IRC | 14:24 | |
* gudrutis2 bashing the head wondering why IPAB doesn't work | 14:24 | |
*** khansa has joined #openstack-ironic | 14:25 | |
*** Goneri has joined #openstack-ironic | 14:25 | |
dtantsur | TheJulia: I'm nearly done with supporting them, but I got stuck with execute_clean_step | 14:28 |
dtantsur | which has no way to understand where the step is coming from.. | 14:28 |
dtantsur | then we get the fun with overriding steps, of course.. | 14:28 |
openstackgerrit | Riccardo Pittau proposed openstack/bifrost master: [DNM] getting some libvirt info https://review.opendev.org/707162 | 14:29 |
*** hjensas has quit IRC | 14:31 | |
*** tzumainn has joined #openstack-ironic | 14:35 | |
*** rachit7 has quit IRC | 14:43 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent stable/train: Ignore pyudev errors about device number https://review.opendev.org/708663 | 14:48 |
gudrutis2 | dtantsur: I am getting "error: invalid command 'bdist_wheel'" using IPAB http://paste.openstack.org/show/789752/ . Maybe you have sean it? | 14:50 |
TheJulia | dtantsur: so the other idea that did come up in Shanghai... if memory serves is to consider delimiting the list that the conductor creates in memory and then stores. Naturally there is an upgrade issue if done as full body, but I think the idea was to do it in the step fields themselves because we didn't constrain that structure. That way, with-in a step it could be know if this is oob or from ipa, or in-band | 14:53 |
*** irclogbot_3 has quit IRC | 14:56 | |
TheJulia | dtantsur: I guess where I'm going is there may be ideas/thoughts from the notes that might be helpful | 14:56 |
dtantsur | oh, I see, cool | 14:58 |
dtantsur | gudrutis2: it's something rpittau is trying to solve | 14:59 |
rpittau | gudrutis2: we're trying to make wheel work again, some weird behavior in recent versions of python 3.6, should be fixed soon | 15:00 |
rpittau | gudrutis2: there's a series of patches that is going to land and should help with that | 15:01 |
*** irclogbot_0 has joined #openstack-ironic | 15:01 | |
gudrutis2 | How is it not triggered by calling DIB directly? :) | 15:02 |
* dtantsur no idea | 15:02 | |
openstackgerrit | Riccardo Pittau proposed openstack/bifrost master: [DNM] getting some libvirt info https://review.opendev.org/707162 | 15:06 |
rpittau | gudrutis2: are you using DIB to build the ipa ramdisk using a virtualenv? | 15:10 |
*** ociuhandu has quit IRC | 15:11 | |
gudrutis2 | rpittau: yes | 15:11 |
*** Lucas_Gray has joined #openstack-ironic | 15:11 | |
gudrutis2 | When using docker I got different issues. | 15:12 |
*** ociuhandu has joined #openstack-ironic | 15:17 | |
iurygregory | anyone with ideas on why the ironic-grenade-dsvm keeps failling in https://review.opendev.org/#/c/707676/ .-. always during Smoke test for test_network_basic_ops http://paste.openstack.org/show/789755/, any tips? o/ | 15:19 |
patchbot | patch 707676 - ironic (stable/stein) - Don't require root partition when installing a who... - 1 patch set | 15:19 |
rpittau | iurygregory: it's laso failing the python3 lib drivers test | 15:21 |
rpittau | s/laso/also | 15:21 |
iurygregory | rpittau, this one was working before the recheck XD | 15:21 |
rpittau | not a good sign :) | 15:21 |
iurygregory | ironic-tox-unit-with-driver-libs-python3 SUCCESS in 8m 54s | 15:22 |
iurygregory | agree | 15:22 |
*** TxGirlGeek has joined #openstack-ironic | 15:27 | |
*** lucasagomes has quit IRC | 15:28 | |
dtantsur | TheJulia: a really quick review that has a surprisingly large impact: https://review.opendev.org/#/c/705060/ | 15:30 |
patchbot | patch 705060 - ironic-python-agent-builder - Upgrade pip if it's too old - 12 patch sets | 15:30 |
dtantsur | also, w00t, finally: https://pypi.org/project/sushy-cli/ :) | 15:31 |
*** priteau has joined #openstack-ironic | 15:31 | |
rpittau | \o/ | 15:32 |
TheJulia | WOW! that iss a huge impact dtantsur | 15:35 |
gudrutis2 | dtantsur: https://storyboard.openstack.org/#!/story/2007309 quick draft, I will have a look and propose a patch shortly | 15:36 |
TheJulia | dtantsur: I thought we needed >9.0.1 for ubuntu/debian for something... silly... I'm trying to remember what it was | 15:36 |
khansa | waw! congrats rpittau \o/ | 15:37 |
dtantsur | TheJulia: bionic has 9.0.1 currently | 15:38 |
dtantsur | build works correctly, so we're probably fine | 15:38 |
rpittau | congrats to you khansa and etingof! :) | 15:38 |
*** lucasagomes has joined #openstack-ironic | 15:38 | |
dtantsur | thanks gudrutis2! | 15:38 |
etingof | yay! what a fishy awesomeness! | 15:39 |
dtantsur | :D | 15:46 |
khansa | but I had always the idea that we can add it only if we have a finished version! how it comes? :D | 15:46 |
TheJulia | dtantsur: ship it! | 15:47 |
dtantsur | :) | 15:47 |
dtantsur | khansa: you mean, the release? | 15:47 |
dtantsur | we can release often, especially while it's still in its 0.* numbers | 15:47 |
* TheJulia pushes the button and remotely hears the machiens begin to spin :) | 15:47 | |
rpittau | well we have something :) | 15:47 |
khansa | dtantsur Yes | 15:47 |
dtantsur | TheJulia: a bit philosophical thought: I feel like we have too many redirections in ironic's internals | 15:49 |
dtantsur | * indirections (oh cmon) | 15:49 |
TheJulia | dtantsur: what is a good example in your mind (so I have shared mutual context of what spurred the thought.) | 15:50 |
TheJulia | I know there is some double redirection stuff that was done for compatability long ago that we could likely strip | 15:51 |
*** ociuhandu_ has joined #openstack-ironic | 15:51 | |
dtantsur | TheJulia: deploy steps handling goes through like 5-8 (depending on the case) functions across 5 (?) files | 15:51 |
khansa | aha! this is great! dtantsur rpittau thanks :) | 15:52 |
dtantsur | I seem to remember similar problems before | 15:52 |
TheJulia | dtantsur: ahh, yeah | 15:52 |
TheJulia | dtantsur: A good refactoring for ironic 16 perhaps? | 15:52 |
dtantsur | the very existence of deploy_utils, pxe_utils and a few others | 15:52 |
TheJulia | or maybe 15? | 15:52 |
dtantsur | maybe? I started decomposing manager.py, which arguably makes indirection worse, but also makes manager.py manageable (heh) | 15:53 |
TheJulia | some of the utils make sense but we should only be calling them from drivers imho | 15:53 |
dtantsur | I hate deploy_utils because it can contain anything | 15:53 |
TheJulia | Yeah, Some of that code was very static too so it made sense there | 15:53 |
dtantsur | and yes, it also contains deploy/clean steps handling, why wouldn't it | 15:53 |
TheJulia | ++ I also hate the double classes that occur in the deploy interfaces as a result of deploy_utils | 15:53 |
TheJulia | "like, which method did this call?!?!" | 15:54 |
dtantsur | too many refacorings, too little time | 15:54 |
*** ociuhandu has quit IRC | 15:54 | |
dtantsur | TheJulia: how's your human cloning research progressing? | 15:54 |
*** ociuhandu_ has quit IRC | 15:55 | |
TheJulia | I believe it was assigned to mordred, who convinced robynbergeron to take part... and last I heard there was some discussion at RH summit of nanotech and how we could use such in cloning... and yeah. | 15:56 |
TheJulia | I believe we're awaiting nanites. | 15:57 |
dtantsur | that's why mordred is so busy recently, I see | 15:57 |
TheJulia | We may also need time machines to... but that task has not yet been assigned | 15:58 |
TheJulia | s/to/too/ | 15:59 |
TheJulia | Maybe mordred was going to do the time machine work | 15:59 |
iurygregory | time machines we can get with c++ | 15:59 |
* TheJulia twitches | 15:59 | |
TheJulia | machine hardware clocks can also be great time machines | 16:00 |
openstackgerrit | Merged openstack/ironic-specs master: Update the CLI section https://review.opendev.org/706956 | 16:00 |
iurygregory | https://abstrusegoose.com/249 <- how it works | 16:00 |
TheJulia | Esp if the frequency into the power-supply is not perfectly stable. | 16:00 |
rpittau | you can trigger some interesting paradox if hw clock is not in sync with sw clock | 16:00 |
etingof | we will get to Jan 1-st 1970 in 2028, no worries | 16:01 |
etingof | oops, 2038 I mean | 16:01 |
TheJulia | I had a data center once that was not a continuous dual conversion UPS, so we would see the frequency drift subtly on the grid with how we were connected and all and the machines often thought they were from the future or far in the past, esp when they were left off but connected to power for a while. | 16:02 |
TheJulia | Next datacenter we built in the same building, we got a MUCH better facility UPS for that space, and the output signal was basically always perfect and never had any issues like that | 16:03 |
* rpittau shuddered at "the machines often thought" | 16:03 | |
TheJulia | iurygregory: great comic | 16:04 |
TheJulia | rpittau: #opslife | 16:04 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Refactoring: rename agent_base_vendor to agent_base https://review.opendev.org/708676 | 16:06 |
dtantsur | the first step in making the world a better place ^^ | 16:06 |
dtantsur | this is just git mv + sed, so should be an easy review | 16:06 |
TheJulia | that would actually make things cleaner to read through/follow, hopefully it doesn't explode | 16:06 |
dtantsur | okay, on to some actual code move | 16:07 |
TheJulia | dtantsur: https://twitter.com/ashinclouds/status/1229981841404248064 | 16:09 |
dtantsur | LOL, so true | 16:09 |
rpittau | maybe a chat ? we need a new chat tool | 16:10 |
arne_wiebalck | retestuefi | 16:11 |
arne_wiebalck | sorry wrong window | 16:11 |
jroll | TheJulia: but how will we upstream our siteops-email-queue-deploy-driver? | 16:12 |
jroll | obligatory "that is a joke", because it's completely believable | 16:13 |
openstackgerrit | Tzu-Mainn Chen proposed openstack/ironic master: Use auth values from neutron conf when managing Neutron ports https://review.opendev.org/708678 | 16:15 |
TheJulia | jroll: That is not allowing humans to read email ;) | 16:15 |
openstackgerrit | Merged openstack/ironic-tempest-plugin master: Remove the SW RAID configuration https://review.opendev.org/706961 | 16:15 |
jroll | TheJulia: select text from messages where node_uuid='foo'; | 16:17 |
jroll | :D | 16:17 |
jroll | fair enough :) | 16:17 |
iurygregory | or 'bar' | 16:18 |
dtantsur | jroll, TheJulia, thinking of it, we can totally build a chat tool on top of node.extra! | 16:21 |
jroll | YES | 16:21 |
jroll | it's the most obvious use of that field | 16:21 |
TheJulia | Can someone have tequila delivered to me today? Or maybe some Scotch? | 16:21 |
dtantsur | fly here, we've got some great whiskey at home | 16:22 |
iurygregory | I only have beer at home .-. | 16:22 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Refactoring: move generic agent clean step functions to agent_base https://review.opendev.org/708681 | 16:24 |
dtantsur | okay, this actually moves some code around | 16:24 |
openstackgerrit | Will Szumski proposed openstack/networking-generic-switch stable/train: Use train version of upper constraints https://review.opendev.org/708682 | 16:24 |
openstackgerrit | Merged openstack/ironic-python-agent master: tgtd session detach test fails on Centos7 https://review.opendev.org/686588 | 16:29 |
*** gyee has joined #openstack-ironic | 16:36 | |
*** Lucas_Gray has quit IRC | 16:38 | |
openstackgerrit | Merged openstack/ironic-python-agent stable/train: Catch ValueError for FIPS 140-2 mode https://review.opendev.org/708637 | 16:40 |
rpittau | bye all, talk tomorrow! o/ | 16:48 |
*** rpittau is now known as rpittau|afk | 16:48 | |
*** ociuhandu has joined #openstack-ironic | 16:48 | |
*** ociuhandu has quit IRC | 16:52 | |
*** bfournie has quit IRC | 16:52 | |
*** igordc has joined #openstack-ironic | 16:59 | |
*** jdandrea has quit IRC | 17:01 | |
*** lucasagomes has quit IRC | 17:03 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Refactoring: rename agent_base_vendor to agent_base https://review.opendev.org/708676 | 17:08 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Refactoring: move generic agent clean step functions to agent_base https://review.opendev.org/708681 | 17:09 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Refactoring: move iSCSI deploy code to iscsi_deploy.py https://review.opendev.org/708697 | 17:11 |
dtantsur | okay, I'm done for today, see you tomorrow :) | 17:11 |
*** dtantsur is now known as dtantsur|afk | 17:11 | |
*** jcoufal has joined #openstack-ironic | 17:20 | |
gudrutis2 | dtantsur|afk: o/ | 17:24 |
openstackgerrit | Merged openstack/ironic-python-agent-builder master: Upgrade pip if it's too old https://review.opendev.org/705060 | 17:26 |
openstackgerrit | Verification of a change to openstack/ironic-python-agent-builder failed: Use train branch for centos7 job https://review.opendev.org/706292 | 17:26 |
*** igordc has quit IRC | 17:46 | |
*** k_mouza_ has joined #openstack-ironic | 17:46 | |
*** k_mouza has quit IRC | 17:49 | |
*** dougsz has quit IRC | 17:51 | |
*** k_mouza_ has quit IRC | 17:51 | |
*** ociuhandu has joined #openstack-ironic | 17:53 | |
*** ociuhandu has quit IRC | 17:59 | |
*** derekh has quit IRC | 18:00 | |
openstackgerrit | Merged openstack/ironic-python-agent-builder master: Make Ubuntu Bionic job green again https://review.opendev.org/705627 | 18:03 |
*** TxGirlGeek has quit IRC | 18:06 | |
*** igordc has joined #openstack-ironic | 18:22 | |
*** jdandrea has joined #openstack-ironic | 18:22 | |
*** priteau has quit IRC | 18:27 | |
*** priteau has joined #openstack-ironic | 18:28 | |
openstackgerrit | Merged openstack/ironic-python-agent master: Convert apply_result to mock object https://review.opendev.org/707166 | 18:29 |
openstackgerrit | Merged openstack/ironic-python-agent stable/train: Ignore pyudev errors about device number https://review.opendev.org/708663 | 18:29 |
*** priteau has quit IRC | 18:33 | |
openstackgerrit | Verification of a change to openstack/ironic-inspector failed: Change CoreOS to Centos for IPA https://review.opendev.org/707174 | 18:39 |
*** k_mouza has joined #openstack-ironic | 18:47 | |
*** k_mouza has quit IRC | 18:50 | |
*** khansa has quit IRC | 19:09 | |
*** hjensas has joined #openstack-ironic | 19:13 | |
*** tesseract has quit IRC | 19:16 | |
*** amoralej is now known as amoralej|off | 19:22 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Project Contributing updates for Goal https://review.opendev.org/707930 | 19:39 |
*** jcoufal has quit IRC | 19:44 | |
*** alexmcleod has quit IRC | 19:50 | |
*** ociuhandu has joined #openstack-ironic | 20:12 | |
*** ociuhandu has quit IRC | 20:16 | |
*** tzumainn has quit IRC | 20:21 | |
*** ociuhandu has joined #openstack-ironic | 20:24 | |
*** iurygregory has quit IRC | 20:27 | |
*** ociuhandu has quit IRC | 20:31 | |
*** ociuhandu has joined #openstack-ironic | 20:31 | |
*** k_mouza has joined #openstack-ironic | 20:51 | |
*** k_mouza has quit IRC | 20:56 | |
*** TxGirlGeek has joined #openstack-ironic | 21:24 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Change force_raw_images to use sha256 if md5 is selected https://review.opendev.org/708499 | 21:34 |
*** yolanda has quit IRC | 21:38 | |
*** yolanda has joined #openstack-ironic | 21:52 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP: Hash the rescue_password https://review.opendev.org/691413 | 22:04 |
* TheJulia sighs since it has been up since october | 22:04 | |
TheJulia | also seeing three random test failures, so hopefully CI will come back happier than my local testing | 22:05 |
*** yolanda has quit IRC | 22:06 | |
*** stevebaker has quit IRC | 22:08 | |
* TheJulia goes and adults, and prepares a stack of papers to go to the accountant | 22:13 | |
*** bfournie has joined #openstack-ironic | 22:14 | |
openstackgerrit | Ilya Etingof proposed openstack/virtualbmc master: Add `failing` instance status to `vbmc` reporing https://review.opendev.org/708763 | 22:30 |
*** ociuhandu has quit IRC | 22:38 | |
*** jdandrea has quit IRC | 22:39 | |
*** tkajinam has joined #openstack-ironic | 22:58 | |
*** rcernin has joined #openstack-ironic | 23:04 | |
*** rh-jelabarre has quit IRC | 23:06 | |
*** diurnalist has joined #openstack-ironic | 23:11 | |
*** diurnalist has quit IRC | 23:14 | |
*** stevebaker has joined #openstack-ironic | 23:17 | |
*** diurnalist has joined #openstack-ironic | 23:19 | |
*** diurnalist has left #openstack-ironic | 23:19 | |
*** k_mouza has joined #openstack-ironic | 23:20 | |
*** k_mouza has quit IRC | 23:24 | |
*** diurnalist has joined #openstack-ironic | 23:25 | |
openstackgerrit | Merged openstack/ironic master: Remove the [pxe]ipxe_enabled configuration option https://review.opendev.org/696810 | 23:26 |
*** ociuhandu has joined #openstack-ironic | 23:45 | |
*** diurnalist has joined #openstack-ironic | 23:49 | |
*** diurnalist has quit IRC | 23:49 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!