Wednesday, 2020-06-10

*** Goneri has quit IRC00:08
* TheJulia begins the pre-heatening for the pre-bake of the crust00:14
*** cdearborn has quit IRC00:30
openstackgerritJulia Kreger proposed openstack/ironic-python-agent master: Fix apidoc build  https://review.opendev.org/73471200:48
*** Goneri has joined #openstack-ironic00:49
*** Goneri has quit IRC01:03
*** jawad_axd has joined #openstack-ironic01:12
*** threestrands has joined #openstack-ironic01:19
openstackgerritJulia Kreger proposed openstack/ironic-python-agent master: Fix apidoc build  https://review.opendev.org/73471201:27
*** Qianbiao has joined #openstack-ironic01:28
openstackgerritJulia Kreger proposed openstack/ironic master: WIP Add a driver compatability matrix  https://review.opendev.org/73371601:35
*** jawad_axd has quit IRC01:45
openstackgerritJulia Kreger proposed openstack/ironic-python-agent master: WIP: Handle odd timeouts  https://review.opendev.org/73470901:45
openstackgerritJulia Kreger proposed openstack/ironic master: WIP Add a driver compatability matrix  https://review.opendev.org/73371601:48
openstackgerritJulia Kreger proposed openstack/ironic-specs master: Clean up specs  https://review.opendev.org/73341101:50
* TheJulia wonders if I need to put up a sign for https://review.opendev.org/#/c/720100/01:51
patchbotpatch 720100 - ironic-specs - Victoria Cycle Priorities - 7 patch sets01:51
openstackgerritJulia Kreger proposed openstack/ironic-python-agent master: Fix apidoc build  https://review.opendev.org/73471201:52
*** tzumainn has quit IRC01:55
*** rh-jelabarre has quit IRC01:58
*** Qianbiao has quit IRC02:12
*** Qianbiao has joined #openstack-ironic02:13
QianbiaoHello TheJulia02:14
QianbiaoI am curious what timezone are you at.02:15
TheJuliaQianbiao: GMT-702:16
TheJuliaQianbiao: so I'm looking at 728123 (sorry, finally, things have been chaos recently)02:24
TheJuliaand I noticed you don't bump requirements. Are the methods already present in your client library?02:24
QianbiaoTheJulia yes02:24
Qianbiaoall feature has been finished. and released with python-ibmcclient lib02:25
QianbiaoTheJulia thanks in adavance. I know all core members is very buzy recently.02:27
TheJuliaQianbiao: does the minimum version need to be updated in the requirements text?02:28
TheJuliarequirements.txt ?02:28
Qianbiaohas been updated. in driver-requirements.txt.02:28
TheJuliaQianbiao: ok, I noticed you've got some questions, so I'm leaving some comments, they should be relatively quick02:28
TheJuliaQianbiao: awesome02:28
QianbiaoTheJulia the review should be pretty simple. To reduce review workloud, i have move all logical implementation to client lib.02:32
TheJuliaThat is much appreciated :)02:36
*** jdandrea has quit IRC02:37
Qianbiao:)02:37
TheJuliaQianbiao: feedback posted, let me know if you have any questions, but also... I'm likely going to bed soon02:38
Qianbiaosure, i will reply to them and you may see them when you wake up. :)02:38
Qianbiaogood night.02:39
TheJuliagoodnight! Have a wonderful day!02:45
*** rcernin has quit IRC02:53
*** rcernin_ has joined #openstack-ironic02:53
openstackgerritVerification of a change to openstack/ironic-python-agent failed: Add ffi development lib to bindep  https://review.opendev.org/73382103:07
*** rcernin_ has quit IRC03:07
*** rcernin_ has joined #openstack-ironic03:19
openstackgerritQianBiao Ng proposed openstack/ironic master: Feature: Add raid configuration support for ibmc driver  https://review.opendev.org/72812303:23
*** rcernin_ has quit IRC03:24
*** rcernin has joined #openstack-ironic03:25
*** yaawang has quit IRC04:04
*** yaawang has joined #openstack-ironic04:04
*** ricolin has joined #openstack-ironic04:23
*** Qianbiao has quit IRC04:25
*** diurnalist has quit IRC04:31
*** yaawang has quit IRC04:40
*** yaawang has joined #openstack-ironic04:41
*** jawad_axd has joined #openstack-ironic04:48
*** jtomasek has joined #openstack-ironic04:48
*** yaawang has quit IRC05:00
*** yaawang has joined #openstack-ironic05:01
*** dking has quit IRC05:47
*** zaneb has quit IRC06:17
*** zaneb has joined #openstack-ironic06:17
*** vesper has quit IRC06:18
*** vesper11 has joined #openstack-ironic06:18
*** zaneb has quit IRC06:19
*** zaneb has joined #openstack-ironic06:21
openstackgerritMichael Chapman proposed openstack/ironic master: virtualbmc no longer in global requirements  https://review.opendev.org/73474806:26
*** Qianbiao has joined #openstack-ironic06:37
*** rcernin has quit IRC06:44
*** rcernin_ has joined #openstack-ironic06:44
*** rcernin_ has quit IRC06:50
openstackgerritQianBiao Ng proposed openstack/ironic master: Feature: Add raid configuration support for ibmc driver  https://review.opendev.org/72812306:52
*** rcernin_ has joined #openstack-ironic06:52
arne_wiebalckGood morning, ironic!06:58
*** rcernin_ has quit IRC06:59
*** iurygregory has quit IRC07:11
*** ricolin_ has joined #openstack-ironic07:18
*** ricolin has quit IRC07:20
*** ricolin has joined #openstack-ironic07:21
Qianbiaogood morning arnewiebalck07:21
Qianbiao* arne_wiebalck07:21
*** rpittau|afk is now known as rpittau07:21
rpittaugood morning ironic! o/07:21
*** ricolin_ has quit IRC07:23
*** rcernin_ has joined #openstack-ironic07:23
*** rcernin_ has quit IRC07:28
*** ricolin_ has joined #openstack-ironic07:30
arne_wiebalckHey Qianbiao rpittau o/07:32
rpittauhey arne_wiebalck :)07:32
*** ricolin has quit IRC07:33
Qianbiaogood morning arne_wiebalck and rpittau07:33
*** iurygregory has joined #openstack-ironic07:33
rpittauhey Qianbiao :)07:33
iurygregorygood morning arne_wiebalck and Ironic o/07:33
iurygregoryhey rpittau and Qianbiao o/07:33
*** ricolin_ has quit IRC07:34
rpittauhey iurygregory :)07:34
QianbiaoLooks like I am a member of ironic too, o/07:34
QianbiaoFake member :)07:34
iurygregorylol07:34
*** dustinc has quit IRC07:35
Qianbiaorpittau thanks for the review. checking.07:50
rpittauQianbiao: sure :)07:50
openstackgerritRiccardo Pittau proposed openstack/ironic master: Fix uefi jobs with native ubuntu ovmf package  https://review.opendev.org/71688907:55
*** alexmcleod has joined #openstack-ironic07:56
openstackgerritIury Gregory Melo Ferreira proposed openstack/bifrost master: Add openstack collection  https://review.opendev.org/73459207:59
openstackgerritRiccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib  https://review.opendev.org/73475907:59
*** rcernin_ has joined #openstack-ironic07:59
Qianbiaorpittau did not understand: ibmc.rst#Line 207:08:03
Qianbiao'to avoid' means08:03
*** rcernin_ has quit IRC08:03
Qianbiaoline 221 nit: add comma ','08:03
iurygregoryQianbiao, on L207 you need to use to avoid instead of avoid08:06
QianbiaoThis is to avoid instead of "This is avoid" ?08:06
iurygregoryyes08:07
Qianbiaook08:07
Qianbiaothis is out of my english acknowleage. :)08:08
iurygregoryno worries08:08
QianbiaoI thought it's used like "To avoid something, xxxx"08:08
*** lucasagomes has joined #openstack-ironic08:14
*** kaiokmo has joined #openstack-ironic08:18
openstackgerritQianBiao Ng proposed openstack/ironic master: Feature: Add raid configuration support for ibmc driver  https://review.opendev.org/72812308:20
Qianbiao^^ thanks rpittau, patch 13 has been submit according to your review.08:20
patchbotNo data found for patch 1308:20
openstackgerritRiccardo Pittau proposed openstack/ironic master: [DNM] Test CI with Ubuntu focal  https://review.opendev.org/73476308:23
*** ravsingh has joined #openstack-ironic08:24
rpittauanyone with a minute to spare please review https://review.opendev.org/73167908:25
patchbotpatch 731679 - virtualbmc - Remove unneded Babel config - 5 patch sets08:25
iurygregoryrpittau, doing now08:26
rpittauthanks :)08:26
*** ricolin has joined #openstack-ironic08:26
*** diurnalist has joined #openstack-ironic08:27
Qianbiaorpittau commit message "unneded" or unneeded08:29
rpittauQianbiao: unneeded08:30
*** diurnalist has quit IRC08:31
*** dtantsur|afk is now known as dtantsur08:32
dtantsurmorning ironic08:32
iurygregorymorning dtantsur08:33
iurygregorygood news for you, collection works =)08:33
dtantsur\o/08:35
dtantsurthat's good news indeed08:35
iurygregoryafter 3 more patches.. locally it was working08:35
iurygregorybut for CI i had to change scripts/test-bifrost also hehe08:35
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic master: Add api-ref for indicators API  https://review.opendev.org/73214908:41
dtantsuriurygregory: the patch LGTM, only one question: do we need to update the docs to mention ANSIBLE_COLLECTIONS_PATH?08:42
iurygregorywe probably should08:43
openstackgerritMerged openstack/sushy-cli master: drop mock from lower-constraints  https://review.opendev.org/73455608:45
iurygregoryat least mention that they should set ANSIBLE_COLLECTIONS_PATHS to the location where they will be installed08:46
iurygregoryif they are not using venv it should install in the default location and they should face any problems08:47
iurygregoryrpittau, I just saw your comment, I think we don't need to have the export in the non virtualenv so I will just remove L6908:48
rpittauiurygregory: I added one more after that, how is ANSIBLE_COLLECTIONS_PATHS set when not in venv? (if we care)08:50
iurygregoryrpittau, it has a default value08:50
dtantsurI think the venv is more problematic08:51
rpittauiurygregory: ok, maybe add a definition for that as it's done for ANSIBLE_COLLECTION_REQ08:51
dtantsursince it's the default, we need to document the right value to set08:51
rpittauyeah08:51
rpittaualso it's really weird that we need to export that in test-bifrost.sh08:52
dtantsurrpittau: could you check this backport please: https://review.opendev.org/73459408:55
patchbotpatch 734594 - ironic-python-agent (stable/ussuri) - Make the install_bootloader command asynchronous - 1 patch set08:55
rpittaudone08:56
dtantsurthx08:57
openstackgerritMerged openstack/ironic-ui master: Cleanup py27 support  https://review.opendev.org/73459309:02
dtantsurTheJulia: could you please add your voice to https://doodle.com/poll/5yg93gv7casu3ate ?09:13
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI  https://review.opendev.org/73355909:41
openstackgerritMerged openstack/sushy master: Make Volume/VolumeCollection operations blocking  https://review.opendev.org/73099009:42
openstackgerritMerged openstack/virtualbmc master: drop mock from lower-constraints  https://review.opendev.org/73457309:45
openstackgerritMerged openstack/virtualbmc master: Remove unneded Babel config  https://review.opendev.org/73167909:51
*** sshnaidm|afk is now known as sshnaidm10:14
*** ociuhandu has joined #openstack-ironic10:18
*** rpittau is now known as rpittau|bbl10:19
*** ociuhandu has quit IRC10:21
*** ociuhandu has joined #openstack-ironic10:23
*** rcernin_ has joined #openstack-ironic10:29
*** rcernin_ has quit IRC10:34
openstackgerritVerification of a change to openstack/ironic failed: Add `get_node_network_data` to non-Neutron NetworkInterface  https://review.opendev.org/68826610:37
*** ociuhandu has quit IRC10:41
*** k_mouza has joined #openstack-ironic10:47
*** derekh has joined #openstack-ironic10:49
*** tkajinam has quit IRC10:53
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI  https://review.opendev.org/73355911:16
*** threestrands has quit IRC11:16
openstackgerritMerged openstack/ironic-python-agent stable/ussuri: Make the install_bootloader command asynchronous  https://review.opendev.org/73459411:33
iurygregorydtantsur, I was wondering here if we only want to let the user specify ANSIBLE_COLLECTIONS_PATHS if he is not using the virtualenv11:37
dtantsuriurygregory: mm, will it even work without specifying the paths?11:41
*** zigo has quit IRC11:41
iurygregorydtantsur, well we can make it work11:41
dtantsurif we can, let's make it work :)11:41
iurygregoryif ANSIBLE_COLLECTIONS_PATHS is set we install with -p, if not set install without -p11:41
iurygregoryso it will be installed in the default given by ansible.cfg11:42
*** rcernin_ has joined #openstack-ironic11:48
*** k_mouza has quit IRC11:48
*** k_mouza has joined #openstack-ironic11:51
*** rcernin_ has quit IRC11:53
dtantsurmm, so how will it work with a venv?11:56
*** zigo has joined #openstack-ironic11:56
*** rh-jelabarre has joined #openstack-ironic11:57
iurygregorylet me do some tests here11:58
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI  https://review.opendev.org/73355912:00
openstackgerritArne Wiebalck proposed openstack/ironic master: [doc] Fix indentation in admin/troubleshooting  https://review.opendev.org/73480612:01
Qianbiaoanyone familiar with metal3 may help look at this comment https://github.com/metal3-io/baremetal-operator/issues/529#issuecomment-64187082912:03
*** rpittau|bbl is now known as rpittau12:05
*** derekh has quit IRC12:06
*** derekh has joined #openstack-ironic12:06
dtantsurQianbiao: not sure, probably ironic-inspector logs could be useful too12:11
Qianbiaodtantsur thanks will check12:11
*** derekh has quit IRC12:12
*** derekh has joined #openstack-ironic12:12
Qianbiaodtantsur It says "Introspection data storage is disabled"12:16
*** ravsingh has quit IRC12:20
dtantsurQianbiao: did you change any configuration?\12:23
*** derekh has quit IRC12:24
Qianbiaono, i did not update my inspector.conf file, because it's very old..12:24
*** derekh has joined #openstack-ironic12:24
Qianbiaoa template from rocky version12:24
dtantsuroh, so you're not using the metal3 provided inspector?12:24
Qianbiaoi see, it seems i need to update "store_data = database"12:24
Qianbiaoyes12:24
dtantsuryep12:25
Qianbiaoi use a standalone ironic env12:25
dtantsurit wasn't there in rocky though12:25
Qianbiaowill try thanks dtantsur12:25
*** rloo has joined #openstack-ironic12:29
openstackgerritRiccardo Pittau proposed openstack/ironic master: Enforce autospec in test_rpc_api and test_steps  https://review.opendev.org/73413212:43
openstackgerritRiccardo Pittau proposed openstack/ironic master: Enforce autospec in test_base_manager  https://review.opendev.org/73481112:43
TheJuliagood morning12:43
kaiokmomorning!12:44
rpittaugood morning TheJulia :)12:44
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Add an option to use pre-built DIB images  https://review.opendev.org/73481212:45
TheJuliahow is everyone this morning12:46
openstackgerritRiccardo Pittau proposed openstack/ironic master: [DNM] Test CI with Ubuntu focal  https://review.opendev.org/73476312:47
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI  https://review.opendev.org/73355912:47
rpittauI choose the other envelope12:47
dtantsurmorning TheJulia12:47
dtantsurTheJulia: sleepy, so sleepy12:47
*** Goneri has joined #openstack-ironic12:48
Qianbiaodtantsur inspect finished :). thanks.12:51
Qianbiaomorning TheJulia12:51
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Install packages all at once instead of looping over them  https://review.opendev.org/73482612:53
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Add an option to use pre-built DIB images  https://review.opendev.org/73481212:54
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI  https://review.opendev.org/73355912:54
*** ociuhandu has joined #openstack-ironic12:56
openstackgerritArne Wiebalck proposed openstack/ironic master: [doc] Fix indentation in admin/troubleshooting  https://review.opendev.org/73480612:56
dtantsurTheJulia: could you check https://review.opendev.org/#/c/733111/ when you have some time? It's a bit non-trivial and could use your expertise12:57
patchbotpatch 733111 - bifrost - Get rid of the shade dependency - 5 patch sets12:57
*** rloo has quit IRC13:01
*** rajinir has quit IRC13:01
*** mkowalski has quit IRC13:01
TheJuliadtantsur: I started looking at it around 7 PM last night and was just like "nope, not tonight!"13:01
dtantsurI can imagine :D13:02
*** ociuhandu has quit IRC13:02
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Add an option to use pre-built DIB images  https://review.opendev.org/73481213:03
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI  https://review.opendev.org/73355913:03
*** rajinir has joined #openstack-ironic13:04
openstackgerritRiccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib  https://review.opendev.org/73475913:06
*** jdandrea has joined #openstack-ironic13:06
*** rloo has joined #openstack-ironic13:07
dtantsurinc/python:get_from_global_requirements:236 :   die 236 'Can'\''t find package virtualbmc in requirements'13:07
dtantsurthis seems to be breaking metalsmith all of a sudden13:07
*** ravsingh has joined #openstack-ironic13:07
rpittaudtantsur: virtualbmc was removed by global reqs13:07
*** mkowalski has joined #openstack-ironic13:07
dtantsurso nice of them13:07
TheJuliawtf13:08
* TheJulia notes the coffee cup only has coffee for it is logically waaaaaaay too early for anything else13:09
*** ociuhandu has joined #openstack-ironic13:09
dtantsurI've proposed a revert13:09
*** ociuhandu has quit IRC13:11
TheJuliaok13:11
*** ociuhandu has joined #openstack-ironic13:12
openstackgerritSean McGinnis proposed openstack/ironic master: Add virtualbmc as an extra dependency  https://review.opendev.org/73483613:27
derekhTheJulia: the release of sushy-tools for the reboot fix https://review.opendev.org/#/c/734837/13:28
patchbotpatch 734837 - releases - Release sushy-tools 0.10.0 - 1 patch set13:28
*** cdearborn has joined #openstack-ironic13:28
openstackgerritRiccardo Pittau proposed openstack/bifrost master: Convert with_items to loop  https://review.opendev.org/73384713:28
openstackgerritRiccardo Pittau proposed openstack/bifrost master: Convert with_items to loop  https://review.opendev.org/73384713:30
TheJuliaderekh: done13:34
derekhTheJulia: ty13:35
*** ociuhandu has quit IRC13:42
TheJuliaderekh: thanks for proposing the release!13:45
*** jawad_axd has quit IRC13:47
*** tzumainn has joined #openstack-ironic13:48
*** ociuhandu has joined #openstack-ironic13:58
*** ociuhandu has quit IRC14:03
*** ociuhandu has joined #openstack-ironic14:05
Qianbiaooh finally, metal3 provisioning test against ibmc finished.14:08
dtantsur\o/14:08
QianbiaoBut i did not see any metal3 document desc how to set up raid configuration.14:08
dtantsurI don't think it's supported (yet)14:09
Qianbiao~~ ok14:09
dtantsurQianbiao: like https://github.com/metal3-io/baremetal-operator/pull/292/14:10
openstackgerritMerged openstack/ironic master: Add virtualbmc as an extra dependency  https://review.opendev.org/73483614:11
Qianbiaodtantsur nice, but it seems metal3 development is not quite active.14:12
dtantsurit's active, just everyone has a lot of different priorities14:13
dtantsurRAID doesn't seem to be high on the list for people from Red Hat at the moment14:13
iurygregory^ this14:13
Qianbiaodtantsur personal feelings, when asking questions, most time, it need a long time to get answer.14:14
*** bfournie has quit IRC14:15
dtantsurQianbiao: have you tried their slack or their upstream mailing list?14:15
Qianbiaoyes, i am on slack channel.14:15
openstackgerritVerification of a change to openstack/bifrost failed: Set default deploy/rescue kernel/ramdisk in ironic.conf  https://review.opendev.org/73386014:17
Qianbiaodtantsur btw, when you are convenience, take a look at https://review.opendev.org/#/c/728123/, since TheJulia and rpittau have gave their review, i think it's very close to start merge workflow :)14:19
patchbotpatch 728123 - ironic - Feature: Add raid configuration support for ibmc d... - 13 patch sets14:19
*** sshnaidm is now known as sshnaidm|bbl14:23
dtantsurQianbiao: reviewed. Btw great job writing such detailed docs on *how* things work14:28
*** rcernin_ has joined #openstack-ironic14:28
Qianbiaodtantsur thanks, checking.14:31
*** rcernin_ has quit IRC14:33
*** bfournie has joined #openstack-ironic14:34
NobodyCamGood Morning Ironic folks, jlvillal sorry I missed you yesterday :) doing okay for being all stay at home, like! :)14:40
jlvillalHi NobodyCam :) I'm about the same. Don't leave the house too often :(14:46
*** ociuhandu has quit IRC14:50
iurygregorymorning NobodyCam happy hump day =)14:51
*** diurnalist has joined #openstack-ironic14:57
*** priteau has joined #openstack-ironic14:58
rpittauhey NobodyCam :)15:02
*** dking has joined #openstack-ironic15:03
rpittauTheJulia, dtantsur, should we ask for a stable ussuri and train release for ironic-lib? Asking because of this recent fix: https://review.opendev.org/#/q/I82a94e68e1aa1f634c7f0877ccd674574d1c9bb015:07
dtantsurmorning NobodyCam, jlvillal15:08
dtantsurrpittau: yep15:09
rpittauactually only ussuri15:09
rpittautrain has it in 2.21.115:09
TheJuliarpittau: if you want to propose the release, I'll be happy to check it and +1 it15:10
rpittauTheJulia: sure :)15:10
*** dustinc has joined #openstack-ironic15:11
openstackgerritHarald Jensås proposed openstack/ironic master: Switch Ironic to openstacksdk for Neutron  https://review.opendev.org/73487315:11
Qianbiaohi, if a review has got a +2, but there are still something need to patch according to this review. Should i submit new patch after current review merged? or I can just submit a new patch in current review.15:14
Qianbiao~~ a stupid question. ^^15:14
dtantsurQianbiao: you have options: you can decide to update the patch in question OR you post a new patch on top of that once it is approved15:15
dtantsur(you don't strictly need to wait for the 1st patch to be completely merged, just be careful not to rebase it accidentally)15:16
* jlvillal waves at dtantsur 15:17
QianbiaoSure, I hope I could just submit a new patch upon this review. But if i do so, core members need to redo +2, so i am afraid this will waste their times.15:18
jlvillaldtantsur, Dobroye utro15:19
dtantsur:)15:19
dtantsurQianbiao: yep, that's why it's recommended to create a new review on top of the old one15:19
dtantsurunless you get more important comments later15:19
Qianbiaoi see. :)15:19
Qianbiaogot thanks dtantsur15:19
rpittauTheJulia, dtantsur: https://review.opendev.org/73487515:20
patchbotpatch 734875 - releases - Release ironic-lib 4.2.1 for ussuri - 1 patch set15:20
dtantsurthanks!15:20
rpittau:)15:21
jlvillaldtantsur, Marina wanted me to tell you hello. She said to me, "he's a good guy" :)15:21
dkingTheJulia: There was some discussion about container images during the PTG. Did that go anywhere?15:22
rpittaummmm ironic-standalone seems to work with minimal change in ubuntu focal with Python 3.8, which is kind of scary -> https://review.opendev.org/73476315:24
patchbotpatch 734763 - ironic - [DNM] Test CI with Ubuntu focal - 2 patch sets15:24
dtantsurjlvillal: heh, that's sweet of her :) send her my greetings as well15:25
dtantsurrpittau: well, we have a bifrost job passing on focal15:26
rpittauthat's right, I was expecting more shenanigans though :)15:26
dtantsurwait until you get to the multinode jobs :D15:28
rpittauoh gosh15:28
rpittauthe uefi jobs is already dominating my nightmares enough, now with the ironic-python-agent that can't find any suitable root devaice15:31
* dtantsur thinks about UEFI support in Bifrost and blood freezes in his veins15:33
* rpittau needs more vanilla ice-cream15:36
openstackgerritRiccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib  https://review.opendev.org/73475915:36
openstackgerritRiccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib  https://review.opendev.org/73475915:36
*** Qianbiao is now known as Qianbiao|afk15:36
openstackgerritRiccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib  https://review.opendev.org/73475915:37
NobodyCammorning jlvillal iurygregory rpittau and ofcourse dtantsur :)15:44
jlvillal:)15:44
*** ociuhandu has joined #openstack-ironic15:50
*** gyee has joined #openstack-ironic15:54
openstackgerritMerged openstack/bifrost master: Set default deploy/rescue kernel/ramdisk in ironic.conf  https://review.opendev.org/73386015:55
TheJuliadking: There was no real objection besides the natural concern that they take on a "one way to" sort of pattern, which in itself is concerning. So the concept of like Dockerfiles was agreeable, but creating/posting pre-built images not as much, and the hope is to try and make ironic easier to adopt in general.15:56
TheJuliaI think that sums it up15:56
dkingOkay. I didn't know if anybody every got with the Kolla group regarding any of that, since they were in a different meeting at the time, and there was some mention about the overlap.15:57
TheJuliaYeah, I don't think there has been an opportunity for anyone to really sync up15:58
TheJuliamgoddard: ^^^15:58
*** lucasagomes has quit IRC16:00
rpittaubye everyone! o/16:07
*** rpittau is now known as rpittau|afk16:07
mgoddardTheJulia: yeah, we should talk about this at some point. There are kolla images for ironic on Dockerhub16:19
*** rloo has quit IRC16:33
TheJuliamgoddard: I don't think that is a bad thing, they are just opinionated in kolla's use case16:36
TheJulia?use cases?16:36
*** ravsingh has quit IRC16:36
TheJuliatl;dr not a bad thing in my mind, but yes, we should talk because I don't think there is or really can be a single path to use16:36
TheJulia(no matter how much we may want one)16:36
mgoddardthey're kind of opinionated, but you could also just pick them up and run them16:37
*** gyee has quit IRC16:42
*** ociuhandu has quit IRC16:46
*** rloo has joined #openstack-ironic16:50
*** derekh has quit IRC17:00
*** priteau has quit IRC17:01
*** gyee has joined #openstack-ironic17:08
*** dtantsur is now known as dtantsur|afk17:10
TheJuliamostly yes, we've had a few people come in with issues in the  past, but surprisingly few17:17
*** Lucas_Gray has joined #openstack-ironic17:31
*** Lucas_Gray has quit IRC17:33
openstackgerritMerged openstack/bifrost master: Install packages all at once instead of looping over them  https://review.opendev.org/73482617:37
*** sshnaidm|bbl is now known as sshnaidm17:40
*** ociuhandu has joined #openstack-ironic17:43
*** ociuhandu has quit IRC17:48
*** rloo has quit IRC17:56
*** rloo has joined #openstack-ironic17:56
*** k_mouza has quit IRC18:14
openstackgerritHervé Beraud proposed openstack/ironic master: Use unittest.mock instead of mock  https://review.opendev.org/73435018:18
openstackgerritHervé Beraud proposed openstack/ironic-inspector master: Use unittest.mock instead of mock  https://review.opendev.org/73435118:21
*** rcernin_ has joined #openstack-ironic18:30
*** rcernin_ has quit IRC18:34
*** ricolin has quit IRC18:54
*** sshnaidm is now known as sshnaidm|afk19:05
*** eliaswimmer_ has joined #openstack-ironic19:24
eliaswimmer_Hi, install_bootloader in image.py takes a root_uuid as argument. Where is this coming from?19:34
TheJuliaeliaswimmer_: it gets collected or determined (depending on the deploy interface) and what is written to disk19:56
eliaswimmer_TheJulia: I'm using software raid with uefi and it chooses the wrong partition as root19:57
TheJuliaeliaswimmer_: I believe it gets that from glance properties in that case19:58
TheJuliahow so is it getting the wrong value?19:58
eliaswimmer_I'm using bifrost19:58
eliaswimmer_without glance19:59
TheJuliaokay19:59
TheJuliaarne_wiebalck: ^^^ fyi19:59
eliaswimmer_that is what I'm trying to find out19:59
TheJuliaI'm trying to remember how it determines it at the moment without that property20:00
TheJuliawhat is it trying to send as the root_uuid ?20:00
eliaswimmer_from the code in ipa image.py it has to be set somewhere20:00
eliaswimmer_it sends the second md partition20:01
TheJuliainteresting20:01
eliaswimmer_I will give it an other try to figure it out20:03
TheJuliaif you look at the driver_internal_info field, do you see a root uuid value?20:03
eliaswimmer_sorry that will take some time20:03
TheJuliathis is likely where things are going sideways https://github.com/openstack/ironic/blob/dac810aaf41612d0199cd87f900f5c365bc06b4a/ironic/drivers/modules/agent_base.py#L1153-L117120:03
TheJuliaThat is likely a relatively easy change to make it be able to be user definable in the iamge20:04
TheJuliawait20:04
TheJuliayou said second md device, that should be the root filesystem20:04
TheJuliawhere is this actually failing?20:05
eliaswimmer_when mounting the root for updating the grub config20:06
eliaswimmer_in my case that's some other partition20:06
TheJuliaI guess there are multiple partitions inside your disk image?20:07
eliaswimmer_yes, first is efi, second I have to find out, third is root20:07
TheJuliathat _shouldnt_ break it, but if you ahve any log entries or examples of output that might help us figure out what is going on and how to fix it20:08
eliaswimmer_One fix for uefi we have to add is https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/image.py#L630-L63420:11
eliaswimmer_Where we also need to write /etc/grub2-efi.cfg20:11
eliaswimmer_Ok, bad news. Even it fails node is now in state active20:31
eliaswimmer_no deploy logs for this run in ironic20:34
eliaswimmer_I will now run it with rpdb20:34
eliaswimmer_'root_uuid_or_disk_id': '0x00000000'20:38
TheJuliacan  you share with us some information about the structure of your disk image, as well as what distribution your trying to deploy since it sounds like your distribution's mechanics require something different than what we've tested or expected based on grub's documentation20:43
TheJulia0x00000000 is basically tl;dr for we don't know20:43
TheJuliawhich happens with whole disk images20:44
eliaswimmer_it's a centos 8 image built wit dib20:44
eliaswimmer_block-device-efi, vm, grub220:45
eliaswimmer_uses a config drive20:45
eliaswimmer_I'm using kayobe20:46
TheJuliaminus kayobe, sounds like what cern uses20:46
eliaswimmer_the use koji20:47
*** ociuhandu has joined #openstack-ironic20:48
eliaswimmer_I run ipa with a debugger yesterday and set the root device right, then it worked20:49
eliaswimmer_root_uuid = internal_info.get('root_uuid_or_disk_id') shouldn't it throw a key error if key is not present?20:52
*** ociuhandu has quit IRC20:53
eliaswimmer_https://github.com/openstack/ironic/blob/dac810aaf41612d0199cd87f900f5c365bc06b4a/ironic/drivers/modules/agent_base.py#L1199-L120620:54
eliaswimmer_That's the reason why I don't get an error20:54
eliaswimmer_Arne told me yesterday that they set the root_uuid in glance!20:56
eliaswimmer_I have to quit for today, tomorrow I will run ipa with a debugger21:05
eliaswimmer_thx you21:06
*** kaiokmo has quit IRC21:35
TheJuliaeliaswimmer_: yeah, I think we could change that so we could look in instance_info if there is a user defined uuid as well21:53
*** threestrands has joined #openstack-ironic21:55
*** rcernin_ has joined #openstack-ironic21:59
*** rcernin_ has quit IRC22:04
*** rcernin has joined #openstack-ironic22:04
*** rcernin is now known as rcernin|brekkie22:05
*** rh-jelabarre has quit IRC22:10
*** rcernin|brekkie has quit IRC22:19
*** k_mouza has joined #openstack-ironic22:21
*** k_mouza has quit IRC22:33
openstackgerritMerged openstack/ironic-python-agent master: Add ffi development lib to bindep  https://review.opendev.org/73382122:41
*** tkajinam has joined #openstack-ironic22:45
*** rloo has quit IRC22:56
*** alexmcleod has quit IRC23:07
*** rcernin|brekkie has joined #openstack-ironic23:09
*** rcernin|brekkie has quit IRC23:10
*** rcernin has joined #openstack-ironic23:10

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!