*** diurnalist has joined #openstack-ironic | 00:05 | |
*** Lucas_Gray has joined #openstack-ironic | 00:10 | |
openstackgerrit | Verification of a change to openstack/ironic failed: Do not validate driver on changing non-driver fields https://review.opendev.org/739699 | 01:21 |
---|---|---|
*** tkajinam has quit IRC | 01:32 | |
*** tkajinam has joined #openstack-ironic | 01:32 | |
*** ianychoi_ has quit IRC | 01:48 | |
*** ianychoi_ has joined #openstack-ironic | 01:50 | |
*** Wryhder has joined #openstack-ironic | 01:59 | |
*** Lucas_Gray has quit IRC | 02:00 | |
*** Wryhder is now known as Lucas_Gray | 02:00 | |
*** Goneri has quit IRC | 02:48 | |
*** tzumainn has quit IRC | 03:39 | |
*** sshnaidm|afk has quit IRC | 04:08 | |
*** bdodd has quit IRC | 04:08 | |
*** bnemec has quit IRC | 04:08 | |
*** adrianc has quit IRC | 04:08 | |
*** shadower has quit IRC | 04:08 | |
*** early has quit IRC | 04:08 | |
*** zigo has quit IRC | 04:08 | |
*** yolanda has quit IRC | 04:08 | |
*** benj_ has quit IRC | 04:08 | |
*** buhman has quit IRC | 04:08 | |
*** persia has quit IRC | 04:08 | |
*** andy_ has quit IRC | 04:08 | |
*** mjturek has quit IRC | 04:08 | |
*** maelk has quit IRC | 04:08 | |
*** jlvillal has quit IRC | 04:08 | |
*** fdegir has quit IRC | 04:08 | |
*** baha has quit IRC | 04:08 | |
*** seba has quit IRC | 04:08 | |
*** diurnalist has quit IRC | 04:08 | |
*** iurygregory has quit IRC | 04:08 | |
*** bfournie has quit IRC | 04:08 | |
*** phrobb has quit IRC | 04:08 | |
*** vkmc has quit IRC | 04:08 | |
*** v1k0d3n has quit IRC | 04:08 | |
*** gmann has quit IRC | 04:08 | |
*** erbarr has quit IRC | 04:08 | |
*** portdirect has quit IRC | 04:08 | |
*** vdrok has quit IRC | 04:08 | |
*** seongsoocho has quit IRC | 04:08 | |
*** mnaser has quit IRC | 04:08 | |
*** arne_wiebalck has quit IRC | 04:08 | |
*** antonym has quit IRC | 04:08 | |
*** jhesketh has quit IRC | 04:08 | |
*** jroll has quit IRC | 04:08 | |
*** fungi has quit IRC | 04:08 | |
*** ianychoi_ has quit IRC | 04:08 | |
*** lifeless has quit IRC | 04:08 | |
*** gryf has quit IRC | 04:08 | |
*** naved001 has quit IRC | 04:08 | |
*** jmccrory has quit IRC | 04:08 | |
*** mgoddard has quit IRC | 04:08 | |
*** mcarden has quit IRC | 04:08 | |
*** akahat has quit IRC | 04:08 | |
*** melwitt has quit IRC | 04:08 | |
*** yaawang has quit IRC | 04:08 | |
*** rpittau has quit IRC | 04:08 | |
*** cp- has quit IRC | 04:08 | |
*** dhellmann has quit IRC | 04:08 | |
*** zer0c00l_ has quit IRC | 04:08 | |
*** stbenjam has quit IRC | 04:08 | |
*** ftarasenko has quit IRC | 04:08 | |
*** zzzeek has quit IRC | 04:08 | |
*** brtknr has quit IRC | 04:08 | |
*** mrda has quit IRC | 04:08 | |
*** ddurst has quit IRC | 04:08 | |
*** clarkb has quit IRC | 04:08 | |
*** trident has quit IRC | 04:08 | |
*** SpamapS has quit IRC | 04:08 | |
*** chihhsin_ has quit IRC | 04:08 | |
*** eandersson has quit IRC | 04:08 | |
*** dansmith has quit IRC | 04:08 | |
*** ianw_pto has quit IRC | 04:08 | |
*** openstackgerrit has quit IRC | 04:08 | |
*** sw3 has quit IRC | 04:08 | |
*** whizzz has quit IRC | 04:08 | |
*** johnthetubaguy has quit IRC | 04:08 | |
*** vesper11 has quit IRC | 04:08 | |
*** ajya has quit IRC | 04:08 | |
*** mgagne has quit IRC | 04:08 | |
*** samueldmq has quit IRC | 04:08 | |
*** pas-ha has quit IRC | 04:08 | |
*** johnhaan has quit IRC | 04:08 | |
*** ildikov has quit IRC | 04:08 | |
*** NobodyCam has quit IRC | 04:08 | |
*** tonyb[m] has quit IRC | 04:08 | |
*** ab-a has quit IRC | 04:08 | |
*** jungleboyj has quit IRC | 04:08 | |
*** dking has quit IRC | 04:08 | |
*** tonyb has quit IRC | 04:08 | |
*** JayF has quit IRC | 04:08 | |
*** mugsie has quit IRC | 04:08 | |
*** zaneb has quit IRC | 04:08 | |
*** hoonetorg has quit IRC | 04:08 | |
*** rnoriega- has quit IRC | 04:08 | |
*** michchap has quit IRC | 04:08 | |
*** Lucas_Gray has quit IRC | 04:08 | |
*** hjensas has quit IRC | 04:08 | |
*** spotz has quit IRC | 04:08 | |
*** patchbot has quit IRC | 04:08 | |
*** dtruong has quit IRC | 04:08 | |
*** m1p has quit IRC | 04:08 | |
*** mnasiadka has quit IRC | 04:08 | |
*** irclogbot_0 has quit IRC | 04:08 | |
*** logan- has quit IRC | 04:08 | |
*** markmcclain has quit IRC | 04:08 | |
*** johnsom has quit IRC | 04:08 | |
*** donnyd has quit IRC | 04:08 | |
*** sean-k-mooney has quit IRC | 04:08 | |
*** dtantsur|afk has quit IRC | 04:08 | |
*** tkajinam has quit IRC | 04:08 | |
*** mkowalski has quit IRC | 04:08 | |
*** andrein has quit IRC | 04:08 | |
*** rpioso has quit IRC | 04:08 | |
*** sziviani has quit IRC | 04:08 | |
*** bfournie has joined #openstack-ironic | 04:14 | |
*** iurygregory has joined #openstack-ironic | 04:14 | |
*** diurnalist has joined #openstack-ironic | 04:14 | |
*** fungi has joined #openstack-ironic | 04:14 | |
*** jroll has joined #openstack-ironic | 04:14 | |
*** jhesketh has joined #openstack-ironic | 04:14 | |
*** antonym has joined #openstack-ironic | 04:14 | |
*** arne_wiebalck has joined #openstack-ironic | 04:14 | |
*** mnaser has joined #openstack-ironic | 04:14 | |
*** seongsoocho has joined #openstack-ironic | 04:14 | |
*** vdrok has joined #openstack-ironic | 04:14 | |
*** portdirect has joined #openstack-ironic | 04:14 | |
*** erbarr has joined #openstack-ironic | 04:14 | |
*** gmann has joined #openstack-ironic | 04:14 | |
*** v1k0d3n has joined #openstack-ironic | 04:14 | |
*** vkmc has joined #openstack-ironic | 04:14 | |
*** phrobb has joined #openstack-ironic | 04:14 | |
*** seba has joined #openstack-ironic | 04:14 | |
*** baha has joined #openstack-ironic | 04:14 | |
*** jlvillal has joined #openstack-ironic | 04:14 | |
*** maelk has joined #openstack-ironic | 04:14 | |
*** mjturek has joined #openstack-ironic | 04:14 | |
*** andy_ has joined #openstack-ironic | 04:14 | |
*** persia has joined #openstack-ironic | 04:14 | |
*** buhman has joined #openstack-ironic | 04:14 | |
*** benj_ has joined #openstack-ironic | 04:14 | |
*** yolanda has joined #openstack-ironic | 04:14 | |
*** johnthetubaguy has joined #openstack-ironic | 04:14 | |
*** whizzz has joined #openstack-ironic | 04:14 | |
*** sw3 has joined #openstack-ironic | 04:14 | |
*** openstackgerrit has joined #openstack-ironic | 04:14 | |
*** ianw_pto has joined #openstack-ironic | 04:14 | |
*** dansmith has joined #openstack-ironic | 04:14 | |
*** eandersson has joined #openstack-ironic | 04:14 | |
*** chihhsin_ has joined #openstack-ironic | 04:14 | |
*** SpamapS has joined #openstack-ironic | 04:14 | |
*** trident has joined #openstack-ironic | 04:14 | |
*** zzzeek has joined #openstack-ironic | 04:14 | |
*** zaneb has joined #openstack-ironic | 04:14 | |
*** mugsie has joined #openstack-ironic | 04:14 | |
*** JayF has joined #openstack-ironic | 04:14 | |
*** tonyb has joined #openstack-ironic | 04:14 | |
*** dking has joined #openstack-ironic | 04:14 | |
*** jungleboyj has joined #openstack-ironic | 04:14 | |
*** ab-a has joined #openstack-ironic | 04:14 | |
*** tonyb[m] has joined #openstack-ironic | 04:14 | |
*** NobodyCam has joined #openstack-ironic | 04:14 | |
*** ildikov has joined #openstack-ironic | 04:14 | |
*** ajya has joined #openstack-ironic | 04:14 | |
*** mgagne has joined #openstack-ironic | 04:14 | |
*** vesper11 has joined #openstack-ironic | 04:14 | |
*** mcarden has joined #openstack-ironic | 04:14 | |
*** mgoddard has joined #openstack-ironic | 04:14 | |
*** naved001 has joined #openstack-ironic | 04:14 | |
*** jmccrory has joined #openstack-ironic | 04:14 | |
*** gryf has joined #openstack-ironic | 04:14 | |
*** lifeless has joined #openstack-ironic | 04:14 | |
*** ianychoi_ has joined #openstack-ironic | 04:14 | |
*** melwitt has joined #openstack-ironic | 04:14 | |
*** akahat has joined #openstack-ironic | 04:14 | |
*** ftarasenko has joined #openstack-ironic | 04:14 | |
*** stbenjam has joined #openstack-ironic | 04:14 | |
*** zer0c00l_ has joined #openstack-ironic | 04:14 | |
*** dhellmann has joined #openstack-ironic | 04:14 | |
*** cp- has joined #openstack-ironic | 04:14 | |
*** rpittau has joined #openstack-ironic | 04:14 | |
*** yaawang has joined #openstack-ironic | 04:14 | |
*** michchap has joined #openstack-ironic | 04:14 | |
*** rnoriega- has joined #openstack-ironic | 04:14 | |
*** hoonetorg has joined #openstack-ironic | 04:14 | |
*** mkrai has joined #openstack-ironic | 04:14 | |
*** fdegir5 has joined #openstack-ironic | 04:14 | |
*** Lucas_Gray has joined #openstack-ironic | 04:14 | |
*** tkajinam has joined #openstack-ironic | 04:14 | |
*** m1p has joined #openstack-ironic | 04:14 | |
*** mnasiadka has joined #openstack-ironic | 04:14 | |
*** johnsom has joined #openstack-ironic | 04:14 | |
*** andrein has joined #openstack-ironic | 04:14 | |
*** samueldmq has joined #openstack-ironic | 04:14 | |
*** pas-ha has joined #openstack-ironic | 04:14 | |
*** johnhaan has joined #openstack-ironic | 04:14 | |
*** rpioso has joined #openstack-ironic | 04:14 | |
*** donnyd has joined #openstack-ironic | 04:14 | |
*** hjensas has joined #openstack-ironic | 04:14 | |
*** sziviani has joined #openstack-ironic | 04:14 | |
*** dtruong has joined #openstack-ironic | 04:14 | |
*** patchbot has joined #openstack-ironic | 04:14 | |
*** spotz has joined #openstack-ironic | 04:14 | |
*** sean-k-mooney has joined #openstack-ironic | 04:14 | |
*** irclogbot_0 has joined #openstack-ironic | 04:14 | |
*** logan- has joined #openstack-ironic | 04:14 | |
*** markmcclain has joined #openstack-ironic | 04:14 | |
*** dtantsur|afk has joined #openstack-ironic | 04:14 | |
*** brtknr has joined #openstack-ironic | 04:15 | |
*** mrda has joined #openstack-ironic | 04:15 | |
*** ddurst has joined #openstack-ironic | 04:15 | |
*** clarkb has joined #openstack-ironic | 04:15 | |
*** sshnaidm|afk has joined #openstack-ironic | 04:15 | |
*** bdodd has joined #openstack-ironic | 04:15 | |
*** bnemec has joined #openstack-ironic | 04:15 | |
*** adrianc has joined #openstack-ironic | 04:15 | |
*** shadower has joined #openstack-ironic | 04:15 | |
*** early has joined #openstack-ironic | 04:15 | |
*** zigo has joined #openstack-ironic | 04:15 | |
*** vkmc has quit IRC | 04:16 | |
*** gmann has quit IRC | 04:16 | |
*** mnaser has quit IRC | 04:16 | |
*** vkmc has joined #openstack-ironic | 04:17 | |
*** erbarr has quit IRC | 04:17 | |
*** erbarr has joined #openstack-ironic | 04:18 | |
*** gmann has joined #openstack-ironic | 04:19 | |
*** mkowalski has joined #openstack-ironic | 04:23 | |
*** mkrai has quit IRC | 04:29 | |
*** mkrai has joined #openstack-ironic | 04:46 | |
*** mkrai has quit IRC | 05:15 | |
*** Lucas_Gray has quit IRC | 05:19 | |
*** mkrai has joined #openstack-ironic | 05:27 | |
arne_wiebalck | Good morning, ironic! | 05:56 |
*** ociuhandu has joined #openstack-ironic | 06:12 | |
*** fdegir5 is now known as fdegir | 06:16 | |
*** ociuhandu has quit IRC | 06:17 | |
*** ianychoi_ has quit IRC | 06:22 | |
*** ianychoi_ has joined #openstack-ironic | 06:23 | |
*** tkajinam has quit IRC | 06:25 | |
*** tkajinam has joined #openstack-ironic | 06:26 | |
*** janders has joined #openstack-ironic | 06:44 | |
*** janders96 has joined #openstack-ironic | 06:44 | |
*** mkrai has quit IRC | 06:47 | |
*** mkrai has joined #openstack-ironic | 06:48 | |
*** Qianbiao has joined #openstack-ironic | 06:51 | |
*** janders has quit IRC | 07:11 | |
*** janders has joined #openstack-ironic | 07:16 | |
*** janders has quit IRC | 07:22 | |
*** ricolin has joined #openstack-ironic | 07:24 | |
*** janders has joined #openstack-ironic | 07:30 | |
*** dougsz has joined #openstack-ironic | 07:32 | |
*** janders has quit IRC | 07:32 | |
iurygregory | good morning arne_wiebalck and Ironic o/ | 07:38 |
arne_wiebalck | hey iurygregory o/ | 07:45 |
*** mkrai has quit IRC | 07:48 | |
*** janders has joined #openstack-ironic | 08:00 | |
*** diurnalist has quit IRC | 08:05 | |
*** ociuhandu has joined #openstack-ironic | 08:06 | |
*** derekh has joined #openstack-ironic | 08:07 | |
*** dtantsur|afk is now known as dtantsur | 08:09 | |
dtantsur | morning ironic | 08:09 |
*** ociuhandu has quit IRC | 08:10 | |
iurygregory | morning dtantsur o/ | 08:11 |
dtantsur | we're still seeing No Valid Host found in the CI, I wonder if we need to update more jobs | 08:11 |
dtantsur | or just change ironic-base to use two VMs.. | 08:11 |
iurygregory | dtantsur, do you have links? | 08:11 |
iurygregory | in theory only the ones with cleaning would need 2 | 08:12 |
iurygregory | (before they were fine.. | 08:12 |
dtantsur | iurygregory: https://review.opendev.org/#/c/740309/ maybe cleaning is not the cause | 08:13 |
patchbot | patch 740309 - ironic-python-agent - Ignore devices with size 0 when collecting inventory - 3 patch sets | 08:13 |
dtantsur | oh, and now we need to remove half of the jobs | 08:13 |
dtantsur | because we run two tests per job | 08:13 |
iurygregory | yeah | 08:14 |
iurygregory | I'm making a list of the jobs we can probably remove | 08:14 |
*** mkrai has joined #openstack-ironic | 08:14 | |
iurygregory | but wait it's tinyipa job | 08:15 |
*** lucasagomes has joined #openstack-ironic | 08:15 | |
iurygregory | normaly we have more than 1 VM... | 08:15 |
iurygregory | but ofc it uses ironic-base and we didn't override =D | 08:15 |
dtantsur | ironic.common.exception.InvalidParameterValue: Invalid or missing agent token received. | 08:16 |
dtantsur | eehhmmmm\ | 08:16 |
iurygregory | dtantsur, we don't need to override in ironic-base if we want to increase | 08:16 |
iurygregory | we can just do on ironic-ipa-base or directly on ipa-tempest-wholedisk-bios-ipmi-direct-dib-src ipa-tempest-partition-bios-ipmi-direct-src | 08:17 |
iurygregory | ouch that hurts =( | 08:17 |
dtantsur | that's probably a red herring though | 08:18 |
dtantsur | iurygregory: okay, let's update these jobs: de-duplicate them and increase the VM count (also for their DIB counterparts) | 08:18 |
dtantsur | and then ditto for ironic-lib, I guess | 08:18 |
dtantsur | could you take a look? | 08:18 |
iurygregory | dtantsur, sure | 08:18 |
iurygregory | I will take care of that | 08:18 |
dtantsur | thx | 08:19 |
dtantsur | oh, and we need to take a look what is going on in inspector jobs | 08:19 |
iurygregory | what happen to inspector? | 08:19 |
iurygregory | happened* | 08:20 |
*** ociuhandu has joined #openstack-ironic | 08:20 | |
*** Lucas_Gray has joined #openstack-ironic | 08:22 | |
janders | good morning guys. Can I nag you with some beginner's questions around the libselinux-python fix? | 08:24 |
iurygregory | janders, sure | 08:24 |
janders | thanks iurygregory! :) | 08:25 |
iurygregory | good evening probably for you XD | 08:25 |
janders | 1) do I need a story on storyboard for something trivial like this? I suppose not? | 08:25 |
iurygregory | I would say it's not required, you just need a release not saying the reason | 08:26 |
iurygregory | probably with "fixes" | 08:26 |
janders | right! | 08:28 |
janders | if there was a story, I would reference the ID in the commit message. If there isn't, what do I reference? | 08:28 |
iurygregory | You just need to have your Commit message | 08:29 |
janders | ok! | 08:30 |
iurygregory | something like "removing libselinux-python" "this lib is only used on python2 env and bifrost is python3 only" | 08:30 |
iurygregory | something on those lines I would say | 08:30 |
janders | on a related note - in this case, can I name the branch I'm using libselinux-python-fix or sth like this? | 08:30 |
dtantsur | iurygregory: the inspector job is also red on the patch, but I haven't looked into it | 08:30 |
dtantsur | janders: we rarely care about branch names | 08:30 |
janders | ok! | 08:31 |
iurygregory | dtantsur, oh ok /me only looked at the other jobs | 08:31 |
dtantsur | only in cases where we need to track several patches belonging to one topic like https://review.opendev.org/#/q/topic:story/2006963 | 08:31 |
dtantsur | speaking of which, mgoddard, could you maybe check https://review.opendev.org/#/c/731180/ today? | 08:31 |
patchbot | patch 731180 - ironic - Decompose the core deploy step on iscsi and ansibl... - 15 patch sets | 08:31 |
janders | when working with gerrit, can I push the code while working in the branch, or would that cause noise/mess? | 08:31 |
dtantsur | it's hopefully the last major change for in-band deploy steps | 08:31 |
dtantsur | janders: you can submit review with WIP or [WIP] in the beginning of its title | 08:32 |
dtantsur | then we'll know it's not ready for review | 08:32 |
iurygregory | yeah | 08:32 |
janders | ok! | 08:32 |
dtantsur | if you *think* the patch may be complete, but you're not sure, use Workflow-1 button instead | 08:32 |
dtantsur | and reset workflow to 0 once you're sure it's done | 08:32 |
iurygregory | or also mark "workflow -1 by or own", but normally we put [WIP] | 08:32 |
janders | and the last question (for now): what's a reasonable way to sufficiently test my patch? | 08:33 |
dtantsur | iurygregory: these are different cases | 08:33 |
dtantsur | janders: if it works for you, it's fine in this case | 08:33 |
iurygregory | janders, I would say test running on F30 running with python3 | 08:33 |
janders | ok! | 08:33 |
dtantsur | the CI runs F30 | 08:33 |
dtantsur | so just make sure that job passes (it's non-voting) | 08:34 |
janders | this actually opens a whole different can of worms (or questions) about my test-server setup | 08:34 |
iurygregory | yeah so he would now if it would fail before | 08:34 |
dtantsur | it's called blah-blah-fedora-latest (yes, 30 is not latest :) | 08:34 |
janders | I'm kinda tempted to deploy OSP13 packstack-allinone on the test server that Tomas has given me | 08:34 |
dtantsur | janders: if you can check F32, the CI will check F30 for you | 08:34 |
dtantsur | I'm using vagrant on my test server | 08:34 |
dtantsur | whatever works for you, really | 08:35 |
janders | how do you guys manage OS on your test-servers? | 08:35 |
*** Lucas_Gray has quit IRC | 08:35 | |
janders | is there a kickstart setup in the lab, or do we drink our own champagne and have ironic sitting somewhere? | 08:35 |
dtantsur | this is my vagrant file http://paste.openstack.org/show/795739/ | 08:36 |
dtantsur | janders: you should have received access to Beaker | 08:36 |
dtantsur | talk to shadower if you haven't | 08:36 |
* iurygregory uses Beaker | 08:36 | |
* iurygregory can't find janders on internal irc | 08:37 | |
janders | I do have access to Beaker, but I don't think my reqest for a machine was approved just yet (so shadower gave me another system) | 08:38 |
janders | iurygregory: which one is this? | 08:38 |
iurygregory | will sent you a pm | 08:38 |
*** Lucas_Gray has joined #openstack-ironic | 08:39 | |
dtantsur | janders: it doesn't have to be approved, shadower should just lend you the machine in beaker | 08:52 |
dtantsur | it's one button click | 08:52 |
janders | let me ask him | 08:52 |
*** seba has quit IRC | 08:56 | |
mgoddard | dtantsur: downstream this morning, should get time later | 09:06 |
dtantsur | okie | 09:07 |
*** diurnalist has joined #openstack-ironic | 09:09 | |
*** diurnalist has quit IRC | 09:14 | |
*** janders has quit IRC | 09:18 | |
*** janders has joined #openstack-ironic | 09:26 | |
*** k_mouza has joined #openstack-ironic | 10:04 | |
arne_wiebalck | ftarasenko: did you check once more if the ESP is on all disks? | 10:07 |
arne_wiebalck | ftarasenko: I have just launched a test node and this one has indeed only an ESP on one disk | 10:07 |
*** seba has joined #openstack-ironic | 10:08 | |
*** ricolin has quit IRC | 10:10 | |
*** dougsz has quit IRC | 10:15 | |
*** dtantsur is now known as dtantsur|brb | 10:21 | |
*** dougsz has joined #openstack-ironic | 10:29 | |
*** mkrai has quit IRC | 10:45 | |
janders | I'm about to wrap up for the day - have a great weekend everyone | 10:55 |
openstackgerrit | liuyuanfeng proposed openstack/ironic master: fix error word presistent in docs https://review.opendev.org/740445 | 10:58 |
*** janders has quit IRC | 11:01 | |
*** k_mouza has quit IRC | 11:23 | |
*** Lucas_Gray has quit IRC | 11:23 | |
*** derekh has quit IRC | 11:23 | |
*** iurygregory has quit IRC | 11:23 | |
*** bfournie has quit IRC | 11:23 | |
*** diurnalist has joined #openstack-ironic | 11:24 | |
*** k_mouza has joined #openstack-ironic | 11:27 | |
*** Lucas_Gray has joined #openstack-ironic | 11:27 | |
*** derekh has joined #openstack-ironic | 11:27 | |
*** iurygregory has joined #openstack-ironic | 11:27 | |
*** bfournie has joined #openstack-ironic | 11:27 | |
*** diurnalist has quit IRC | 11:29 | |
iurygregory | wow a lot of disconnect / re connect | 11:33 |
*** hjensas has quit IRC | 11:44 | |
*** Wryhder has joined #openstack-ironic | 11:49 | |
*** diurnalist has joined #openstack-ironic | 11:52 | |
*** Lucas_Gray has quit IRC | 11:52 | |
*** Wryhder is now known as Lucas_Gray | 11:52 | |
*** diurnalist has quit IRC | 11:57 | |
*** Lucas_Gray has quit IRC | 11:58 | |
*** Lucas_Gray has joined #openstack-ironic | 12:05 | |
*** dtantsur|brb is now known as dtantsur | 12:12 | |
*** rh-jelabarre has joined #openstack-ironic | 12:12 | |
*** rh-jelabarre has quit IRC | 12:19 | |
*** rh-jelabarre has joined #openstack-ironic | 12:19 | |
*** derekh has quit IRC | 12:29 | |
*** Lucas_Gray has quit IRC | 12:36 | |
openstackgerrit | Merged openstack/ironic master: fix error word presistent in docs https://review.opendev.org/740445 | 12:39 |
*** k_mouza has quit IRC | 12:44 | |
*** k_mouza has joined #openstack-ironic | 12:51 | |
*** k_mouza has quit IRC | 12:53 | |
*** k_mouza has joined #openstack-ironic | 12:53 | |
*** Lucas_Gray has joined #openstack-ironic | 12:55 | |
openstackgerrit | Verification of a change to openstack/ironic failed: Do not validate driver on changing non-driver fields https://review.opendev.org/739699 | 13:00 |
*** diurnalist has joined #openstack-ironic | 13:01 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent master: Update jobs https://review.opendev.org/740454 | 13:02 |
*** hjensas has joined #openstack-ironic | 13:05 | |
*** k_mouza has quit IRC | 13:06 | |
*** mnaser has joined #openstack-ironic | 13:09 | |
dougsz | I'm looking at this bug: https://storyboard.openstack.org/#!/story/2007905 | 13:11 |
*** jamesdenton has joined #openstack-ironic | 13:11 | |
dougsz | and wondering about other block devices of type 'md' apart from partitions | 13:12 |
dtantsur | dougsz: you need mdadm on your *instance* image | 13:12 |
*** tzumainn has joined #openstack-ironic | 13:12 | |
*** k_mouza has joined #openstack-ironic | 13:13 | |
dougsz | thanks dtantsur, I injected it with virt-customize | 13:13 |
dtantsur | mm, right, I misread it | 13:14 |
dtantsur | yeah, we need to ignore holder disks when detecting root device | 13:14 |
dougsz | I think in this case it get messed up by list_all_block devices returning mdraid paritions when include_partitions=False | 13:16 |
dougsz | seems to be related to this: https://github.com/openstack/ironic-python-agent/commit/fbfdc49140d6d3145a08a35a34ebf92818c8c865 | 13:16 |
*** k_mouza has quit IRC | 13:17 | |
*** rloo has joined #openstack-ironic | 13:17 | |
dtantsur | arne_wiebalck: ^^^ | 13:18 |
dougsz | struggling to create anything of type 'md' which isn't a partition, but it seems arne saw that before | 13:18 |
TheJulia | good morning | 13:19 |
dtantsur | mmm, we definitely don't need type 'md' for root device detection | 13:19 |
dtantsur | morning TheJulia | 13:19 |
dtantsur | but we do need it for cleaning | 13:19 |
* dtantsur scratches head | 13:20 | |
dougsz | yeah - and I see the logic for skipping devices of type md which are partitions in cleaning | 13:20 |
*** derekh has joined #openstack-ironic | 13:20 | |
dougsz | wondering if some extra probing of devices of type 'md' is required, to distinguish between what is a partition and what is something else | 13:21 |
*** shadower has quit IRC | 13:21 | |
iurygregory | good morning TheJulia | 13:22 |
iurygregory | =) | 13:22 |
openstackgerrit | Doug Szumski proposed openstack/ironic-python-agent master: WIP: Fix bootloader install issue with MDRAID https://review.opendev.org/740331 | 13:22 |
dtantsur | dougsz: I guess I'll have to defer to arne_wiebalck who's our RAID specialist :) | 13:22 |
dtantsur | but I absolutely agree that the bug is valid | 13:22 |
dougsz | I will push some sort of strawman fix to the bug above - thanks for the sanity check dtantsur | 13:23 |
*** shadower has joined #openstack-ironic | 13:24 | |
*** irclogbot_0 has quit IRC | 13:27 | |
arne_wiebalck | dougsz: hi! | 13:28 |
dougsz | hey arne! | 13:29 |
*** irclogbot_3 has joined #openstack-ironic | 13:29 | |
* arne_wiebalck is reading the backlog | 13:29 | |
*** markmcclain has quit IRC | 13:29 | |
arne_wiebalck | dougsz: I guess your image is not having the rootfs uuid set in the metadata of the image? | 13:30 |
*** k_mouza has joined #openstack-ironic | 13:30 | |
*** bdodd has quit IRC | 13:30 | |
dougsz | correct - this is with bifrost | 13:30 |
*** logan- has quit IRC | 13:30 | |
dougsz | (legacy boot) | 13:30 |
*** markmcclain has joined #openstack-ironic | 13:30 | |
*** gmann has quit IRC | 13:30 | |
*** m1p has quit IRC | 13:30 | |
arne_wiebalck | dougsz: ok, I guess this is where the second 'p1' comes from: the code will assume the root fs is on the first partition | 13:31 |
arne_wiebalck | dougsz: I don't see where the first 'p1' comes from, though | 13:31 |
*** gmann has joined #openstack-ironic | 13:32 | |
arne_wiebalck | dougsz: which version is this? | 13:32 |
dougsz | train | 13:32 |
*** bdodd has joined #openstack-ironic | 13:32 | |
*** logan- has joined #openstack-ironic | 13:32 | |
*** m1p has joined #openstack-ironic | 13:33 | |
*** k_mouza has quit IRC | 13:34 | |
dougsz | but inspecting master, I see the same issue in list_block_devices, that when include_partitions=False, it can still return partitions on the mdraid device | 13:34 |
dougsz | We should see it on the unit test failures on https://review.opendev.org/740331 | 13:35 |
patchbot | patch 740331 - ironic-python-agent - WIP: Fix bootloader install issue with MDRAID - 2 patch sets | 13:35 |
arne_wiebalck | dougsz: the roofs uuid only comes with Ussuri anyway | 13:36 |
dougsz | yeah, that is something on the todo list :) | 13:36 |
arne_wiebalck | dougsz: this is what is adding the second p1: https://github.com/openstack/ironic-python-agent/blob/stable/train/ironic_python_agent/extensions/image.py#L68 | 13:37 |
dougsz | yeah - so the device there should be the root device, and not the partition | 13:37 |
arne_wiebalck | dougsz: right, so it seems bifrost provides the partition already | 13:38 |
dougsz | It comes from a whole disk image, written just before the bootloader is installed | 13:38 |
arne_wiebalck | dougsz: but this is inside _get_partition, so why is the partition passed to this function? | 13:39 |
arne_wiebalck | dougsz: the function is supposed to returned it :) | 13:39 |
dougsz | agree! list_all_block_devices returns the root device, the holder disks *and* the raid partitions | 13:39 |
dougsz | the raid partition then gets selected (wrongly) as the root device and passed to that function | 13:40 |
arne_wiebalck | hmm ... where is that happening? | 13:40 |
dougsz | In this call I think: https://github.com/openstack/ironic-python-agent/blob/stable/train/ironic_python_agent/extensions/image.py#L542 | 13:41 |
dougsz | I understand you have seen mdraid devices, of type 'md' that aren't partitions? from: https://github.com/openstack/ironic-python-agent/commit/fbfdc49140d6d3145a08a35a34ebf92818c8c865 | 13:42 |
dougsz | I haven't been able to make one so far (spares seem to show up as type raidx) for me, but I expect I haven't reproduced the scenario | 13:43 |
*** k_mouza has joined #openstack-ironic | 13:43 | |
dougsz | Naive fix is to restore this: https://github.com/openstack/ironic-python-agent/commit/fbfdc49140d6d3145a08a35a34ebf92818c8c865#diff-edff6855c0b0863a855b77705d21581bL292 | 13:44 |
dougsz | But I don't want to break your scenario | 13:44 |
arne_wiebalck | dougsz: yes, but this was for broken raid devices, e.g. a RAID-0 where one disk was missing | 13:45 |
openstackgerrit | Bob Fournier proposed openstack/ironic master: Use min_command_interval when ironic does IPMI retries https://review.opendev.org/740466 | 13:45 |
dougsz | arne_wiebalck: thanks, that helps, I will re-creating that scenario | 13:45 |
dougsz | *try | 13:45 |
arne_wiebalck | dougsz: I think it'd be good to see which devices are considered | 13:46 |
arne_wiebalck | dougsz: since it seems the code after does not expect a partition | 13:47 |
arne_wiebalck | dougsz: at least the RAID code | 13:47 |
*** k_mouza has quit IRC | 13:48 | |
*** k_mouza has joined #openstack-ironic | 13:48 | |
dougsz | Ok, thanks arne_wiebalck, I will see what I can come up with and update the patch for review sometime | 13:50 |
arne_wiebalck | dougsz: thanks! | 13:50 |
dougsz | np, you've put a lot of nice work into software raid, along with others from the project, much appreciated | 13:51 |
*** diurnalist has quit IRC | 14:05 | |
*** ricolin has joined #openstack-ironic | 14:15 | |
*** diurnalist has joined #openstack-ironic | 14:23 | |
TheJulia | brraaaainssss | 14:32 |
*** TheJulia is now known as zombieJulia | 14:32 | |
zombieJulia | set casualnickfriday=1 | 14:33 |
zombieJulia | okay, https://review.opendev.org/#/c/740344 passed... rechecked to see if we just need to be slightly more explicit on what we return | 14:35 |
patchbot | patch 740344 - ironic-inspector - WIP: Additional debugging around inspection start - 2 patch sets | 14:35 |
zombieJulia | We may just need to set a content type for the empty body, which makes no sense | 14:35 |
*** dtantsur is now known as creepy_owlet | 14:36 | |
zombieJulia | then again, I have no idea what an empty body would be content wise | 14:36 |
creepy_owlet | zombieJulia: could you check https://review.opendev.org/#/c/731180/ today? I have a selfish goal of closing this task downstream today :) | 14:37 |
patchbot | patch 731180 - ironic - Decompose the core deploy step on iscsi and ansibl... - 15 patch sets | 14:37 |
zombieJulia | creepy_owlet: sure, i'll start in a moment. It was on my list yesterday but I ran out of spoons completely | 14:37 |
creepy_owlet | I can imagine :( on the other hand, it's very similar to the direct deploy patch | 14:38 |
*** iurygregory is now known as skolt | 14:45 | |
zombieJulia | creepy_owlet: yeah, I remember looking, got distracted, wanted to table flip about something. Yesterday was not a good day | 14:46 |
creepy_owlet | :( | 14:46 |
*** bnemec is now known as beekneemech | 14:47 | |
zombieJulia | Done | 14:50 |
zombieJulia | any chance I could get some eyes on https://review.opendev.org/#/c/727480 | 14:50 |
patchbot | patch 727480 - ironic - Iso booting via redfish virtual media - 6 patch sets | 14:50 |
creepy_owlet | looking now | 14:50 |
creepy_owlet | zombieJulia: a question https://review.opendev.org/#/c/727480/6/ironic/drivers/modules/deploy_utils.py | 14:53 |
patchbot | patch 727480 - ironic - Iso booting via redfish virtual media - 6 patch sets | 14:53 |
zombieJulia | creepy_owlet: I don't... think so | 14:57 |
creepy_owlet | zombieJulia: won't check_for_missing_params get upset if neither image is present? | 14:58 |
zombieJulia | I'm a little fuzzy on that and I think there was a reason not to. | 14:58 |
zombieJulia | wait | 14:58 |
creepy_owlet | or does it only check for stuff that is explicitly None | 14:58 |
zombieJulia | that is the list generation one isent it | 14:58 |
creepy_owlet | (maybe the latter) | 14:58 |
zombieJulia | the entire code for validating the deployment stuffs is super convoluted | 14:59 |
creepy_owlet | oh yeah | 14:59 |
zombieJulia | pulling down the patch and give that a quick spin in unit tests and see what implodes | 14:59 |
creepy_owlet | mmm, yeah, check_for_missing_params only fails on items that are None | 14:59 |
creepy_owlet | zombieJulia: https://review.opendev.org/#/c/727480/6/ironic/drivers/modules/redfish/boot.py@784 comes from parse_deploy_info | 15:01 |
patchbot | patch 727480 - ironic - Iso booting via redfish virtual media - 6 patch sets | 15:01 |
creepy_owlet | and that needs to be populated | 15:01 |
zombieJulia | did I do that in the later patch? | 15:02 |
creepy_owlet | not sure, but it looks like info has to be populated | 15:03 |
zombieJulia | I'm not entirely sure, again, this is all super convoluted | 15:05 |
zombieJulia | strong possibility it is int he second patch :\ | 15:05 |
*** mkrai has joined #openstack-ironic | 15:08 | |
zombieJulia | tox running | 15:14 |
zombieJulia | skolt: https://review.opendev.org/#/c/739715/ fyi | 15:15 |
patchbot | patch 739715 - ironic - CI: Make ipv6 job to voting - 1 patch set | 15:15 |
skolt | done \o/ | 15:17 |
zombieJulia | rofl | 15:19 |
zombieJulia | no failed tests changing that | 15:19 |
*** tkajinam has quit IRC | 15:37 | |
gudrutis | zombieJulia: eh, cov-19 got to you as well? | 15:46 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Iso booting via redfish virtual media https://review.opendev.org/727480 | 15:47 |
*** gyee has joined #openstack-ironic | 15:48 | |
zombieJulia | gudrutis: well, likely got it on my CDG->BOS flight right before transalantic flights began shutting down | 15:49 |
zombieJulia | gudrutis: but... couldn't get any sort of testing because I didn't meet the qualifiers | 15:49 |
gudrutis | and that is how zombieJulia was born? | 15:50 |
*** mkrai has quit IRC | 15:52 | |
*** lucasagomes has quit IRC | 16:00 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: iPXE ISO Ramdisk booting https://review.opendev.org/729464 | 16:01 |
zombieJulia | gudrutis: I don't remember, it just seemed to represent my present state of feeling | 16:02 |
zombieJulia | creepy_owlet: so.. yeah... that was in the ipxe patch | 16:02 |
zombieJulia | rechecking https://review.opendev.org/#/c/736383/11 for good measure | 16:03 |
patchbot | patch 736383 - ironic - ISO ramdisk virtual media test enablement - 11 patch sets | 16:03 |
*** diurnalist has quit IRC | 16:13 | |
*** creepy_owlet is now known as dtantsur|afk | 16:19 | |
dtantsur|afk | have a great weekend | 16:19 |
*** diurnalist has joined #openstack-ironic | 16:23 | |
zombieJulia | dtantsur|afk: have a good weekend | 16:23 |
*** diurnalist has quit IRC | 16:27 | |
openstackgerrit | Doug Szumski proposed openstack/ironic-python-agent master: Fix bootloader install issue with MDRAID https://review.opendev.org/740331 | 16:29 |
*** dougsz has quit IRC | 16:32 | |
*** Qianbiao has quit IRC | 16:32 | |
*** diurnalist has joined #openstack-ironic | 16:35 | |
openstackgerrit | Verification of a change to openstack/ironic failed: Stop using md5 for __repr__ of objects https://review.opendev.org/740329 | 16:35 |
dking | When I move a node from active to available using the "deleted" target, does it also clean the node? | 16:37 |
*** k_mouza has quit IRC | 16:45 | |
*** Lucas_Gray has quit IRC | 16:46 | |
*** dmellado has joined #openstack-ironic | 16:50 | |
*** dmellado has quit IRC | 17:04 | |
*** dmellado has joined #openstack-ironic | 17:08 | |
*** derekh has quit IRC | 17:09 | |
NobodyCam | Good morning Ironicer's. and ofc TGIF! | 17:10 |
*** ociuhandu has quit IRC | 17:20 | |
*** dmellado has quit IRC | 17:26 | |
*** aedc has joined #openstack-ironic | 17:28 | |
arne_wiebalck | dking: yes | 17:40 |
arne_wiebalck | bye everyone, have a good week-end o/ | 17:40 |
dking | arne_wiebalck: Have a good weekend. | 17:41 |
*** dougsz has joined #openstack-ironic | 17:51 | |
openstackgerrit | Verification of a change to openstack/ironic failed: Do not validate driver on changing non-driver fields https://review.opendev.org/739699 | 17:52 |
*** Goneri has joined #openstack-ironic | 17:54 | |
*** Goneri has quit IRC | 18:00 | |
zombieJulia | bfournie: re your min command interval change. Is the internal retry logic still taking account for the interval as well? | 18:12 |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent master: Update jobs https://review.opendev.org/740454 | 18:16 |
skolt | this will unblock our ipa CI | 18:17 |
*** dougsz has quit IRC | 18:20 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent-builder master: Update ipa jobs https://review.opendev.org/740519 | 18:35 |
bfournie | zombieJulia: yes, it takes it into account here https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L515 | 18:39 |
openstackgerrit | Verification of a change to openstack/ironic failed: Decompose the core deploy step on iscsi and ansible deploy https://review.opendev.org/731180 | 18:47 |
*** ricolin has quit IRC | 19:22 | |
*** zaneb has quit IRC | 19:39 | |
*** zbitter has joined #openstack-ironic | 19:39 | |
*** Goneri has joined #openstack-ironic | 20:01 | |
openstackgerrit | Merged openstack/ironic master: CI: Make ipv6 job to voting https://review.opendev.org/739715 | 20:05 |
zombieJulia | bfournie: thanks! | 20:20 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: iPXE ISO Ramdisk booting https://review.opendev.org/729464 | 20:26 |
openstackgerrit | Harald Jensås proposed openstack/ironic master: Switch Ironic to openstacksdk for Neutron https://review.opendev.org/734873 | 20:32 |
*** diurnalist has quit IRC | 20:40 | |
*** diurnalist has joined #openstack-ironic | 20:44 | |
*** Goneri has quit IRC | 20:51 | |
*** diurnali1t has joined #openstack-ironic | 21:00 | |
*** diurnalist has quit IRC | 21:00 | |
*** diurnalist has joined #openstack-ironic | 21:05 | |
*** diurnali1t has quit IRC | 21:05 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Remove locks before RPC bus is started https://review.opendev.org/740360 | 21:34 |
zombieJulia | dtantsur|afk: you mentioned the adopt-failed power state issue when we spoke earlier that hardys encountered. I noted that the machine's state itself was recorded as off, which kind of invalidates anything we could do because "fixing it" for adopt-failed is just pushing the problem around. | 21:44 |
zombieJulia | zer0c00l_: o/ | 21:47 |
zombieJulia | zer0c00l_: I commented on https://storyboard.openstack.org/#!/story/2007839 I think we're going to need a little more detail as to what you anticipate a kickstart deploy interface to do, even at high level mechanics or responsibilities of the deploy_interface as proposed so we can better understand | 21:47 |
openstackgerrit | Merged openstack/ironic-python-agent master: Update jobs https://review.opendev.org/740454 | 21:48 |
*** Goneri has joined #openstack-ironic | 21:49 | |
openstackgerrit | Merged openstack/ironic stable/ussuri: add tempest boot_mode config https://review.opendev.org/740221 | 21:53 |
*** rcernin has joined #openstack-ironic | 22:09 | |
*** dmellado has joined #openstack-ironic | 22:20 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic stable/train: add tempest boot_mode config https://review.opendev.org/740529 | 22:27 |
*** rloo has quit IRC | 22:43 | |
*** tzumainn has quit IRC | 23:13 | |
*** rh-jelabarre has quit IRC | 23:38 | |
*** rh-jelabarre has joined #openstack-ironic | 23:41 | |
*** rh-jelabarre has quit IRC | 23:42 | |
*** rh-jelabarre has joined #openstack-ironic | 23:42 | |
*** rh-jelabarre has quit IRC | 23:47 | |
*** sean-k-mooney has quit IRC | 23:53 | |
*** sean-k-mooney has joined #openstack-ironic | 23:56 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!