Friday, 2020-07-10

*** diurnalist has joined #openstack-ironic00:05
*** Lucas_Gray has joined #openstack-ironic00:10
openstackgerritVerification of a change to openstack/ironic failed: Do not validate driver on changing non-driver fields  https://review.opendev.org/73969901:21
*** tkajinam has quit IRC01:32
*** tkajinam has joined #openstack-ironic01:32
*** ianychoi_ has quit IRC01:48
*** ianychoi_ has joined #openstack-ironic01:50
*** Wryhder has joined #openstack-ironic01:59
*** Lucas_Gray has quit IRC02:00
*** Wryhder is now known as Lucas_Gray02:00
*** Goneri has quit IRC02:48
*** tzumainn has quit IRC03:39
*** sshnaidm|afk has quit IRC04:08
*** bdodd has quit IRC04:08
*** bnemec has quit IRC04:08
*** adrianc has quit IRC04:08
*** shadower has quit IRC04:08
*** early has quit IRC04:08
*** zigo has quit IRC04:08
*** yolanda has quit IRC04:08
*** benj_ has quit IRC04:08
*** buhman has quit IRC04:08
*** persia has quit IRC04:08
*** andy_ has quit IRC04:08
*** mjturek has quit IRC04:08
*** maelk has quit IRC04:08
*** jlvillal has quit IRC04:08
*** fdegir has quit IRC04:08
*** baha has quit IRC04:08
*** seba has quit IRC04:08
*** diurnalist has quit IRC04:08
*** iurygregory has quit IRC04:08
*** bfournie has quit IRC04:08
*** phrobb has quit IRC04:08
*** vkmc has quit IRC04:08
*** v1k0d3n has quit IRC04:08
*** gmann has quit IRC04:08
*** erbarr has quit IRC04:08
*** portdirect has quit IRC04:08
*** vdrok has quit IRC04:08
*** seongsoocho has quit IRC04:08
*** mnaser has quit IRC04:08
*** arne_wiebalck has quit IRC04:08
*** antonym has quit IRC04:08
*** jhesketh has quit IRC04:08
*** jroll has quit IRC04:08
*** fungi has quit IRC04:08
*** ianychoi_ has quit IRC04:08
*** lifeless has quit IRC04:08
*** gryf has quit IRC04:08
*** naved001 has quit IRC04:08
*** jmccrory has quit IRC04:08
*** mgoddard has quit IRC04:08
*** mcarden has quit IRC04:08
*** akahat has quit IRC04:08
*** melwitt has quit IRC04:08
*** yaawang has quit IRC04:08
*** rpittau has quit IRC04:08
*** cp- has quit IRC04:08
*** dhellmann has quit IRC04:08
*** zer0c00l_ has quit IRC04:08
*** stbenjam has quit IRC04:08
*** ftarasenko has quit IRC04:08
*** zzzeek has quit IRC04:08
*** brtknr has quit IRC04:08
*** mrda has quit IRC04:08
*** ddurst has quit IRC04:08
*** clarkb has quit IRC04:08
*** trident has quit IRC04:08
*** SpamapS has quit IRC04:08
*** chihhsin_ has quit IRC04:08
*** eandersson has quit IRC04:08
*** dansmith has quit IRC04:08
*** ianw_pto has quit IRC04:08
*** openstackgerrit has quit IRC04:08
*** sw3 has quit IRC04:08
*** whizzz has quit IRC04:08
*** johnthetubaguy has quit IRC04:08
*** vesper11 has quit IRC04:08
*** ajya has quit IRC04:08
*** mgagne has quit IRC04:08
*** samueldmq has quit IRC04:08
*** pas-ha has quit IRC04:08
*** johnhaan has quit IRC04:08
*** ildikov has quit IRC04:08
*** NobodyCam has quit IRC04:08
*** tonyb[m] has quit IRC04:08
*** ab-a has quit IRC04:08
*** jungleboyj has quit IRC04:08
*** dking has quit IRC04:08
*** tonyb has quit IRC04:08
*** JayF has quit IRC04:08
*** mugsie has quit IRC04:08
*** zaneb has quit IRC04:08
*** hoonetorg has quit IRC04:08
*** rnoriega- has quit IRC04:08
*** michchap has quit IRC04:08
*** Lucas_Gray has quit IRC04:08
*** hjensas has quit IRC04:08
*** spotz has quit IRC04:08
*** patchbot has quit IRC04:08
*** dtruong has quit IRC04:08
*** m1p has quit IRC04:08
*** mnasiadka has quit IRC04:08
*** irclogbot_0 has quit IRC04:08
*** logan- has quit IRC04:08
*** markmcclain has quit IRC04:08
*** johnsom has quit IRC04:08
*** donnyd has quit IRC04:08
*** sean-k-mooney has quit IRC04:08
*** dtantsur|afk has quit IRC04:08
*** tkajinam has quit IRC04:08
*** mkowalski has quit IRC04:08
*** andrein has quit IRC04:08
*** rpioso has quit IRC04:08
*** sziviani has quit IRC04:08
*** bfournie has joined #openstack-ironic04:14
*** iurygregory has joined #openstack-ironic04:14
*** diurnalist has joined #openstack-ironic04:14
*** fungi has joined #openstack-ironic04:14
*** jroll has joined #openstack-ironic04:14
*** jhesketh has joined #openstack-ironic04:14
*** antonym has joined #openstack-ironic04:14
*** arne_wiebalck has joined #openstack-ironic04:14
*** mnaser has joined #openstack-ironic04:14
*** seongsoocho has joined #openstack-ironic04:14
*** vdrok has joined #openstack-ironic04:14
*** portdirect has joined #openstack-ironic04:14
*** erbarr has joined #openstack-ironic04:14
*** gmann has joined #openstack-ironic04:14
*** v1k0d3n has joined #openstack-ironic04:14
*** vkmc has joined #openstack-ironic04:14
*** phrobb has joined #openstack-ironic04:14
*** seba has joined #openstack-ironic04:14
*** baha has joined #openstack-ironic04:14
*** jlvillal has joined #openstack-ironic04:14
*** maelk has joined #openstack-ironic04:14
*** mjturek has joined #openstack-ironic04:14
*** andy_ has joined #openstack-ironic04:14
*** persia has joined #openstack-ironic04:14
*** buhman has joined #openstack-ironic04:14
*** benj_ has joined #openstack-ironic04:14
*** yolanda has joined #openstack-ironic04:14
*** johnthetubaguy has joined #openstack-ironic04:14
*** whizzz has joined #openstack-ironic04:14
*** sw3 has joined #openstack-ironic04:14
*** openstackgerrit has joined #openstack-ironic04:14
*** ianw_pto has joined #openstack-ironic04:14
*** dansmith has joined #openstack-ironic04:14
*** eandersson has joined #openstack-ironic04:14
*** chihhsin_ has joined #openstack-ironic04:14
*** SpamapS has joined #openstack-ironic04:14
*** trident has joined #openstack-ironic04:14
*** zzzeek has joined #openstack-ironic04:14
*** zaneb has joined #openstack-ironic04:14
*** mugsie has joined #openstack-ironic04:14
*** JayF has joined #openstack-ironic04:14
*** tonyb has joined #openstack-ironic04:14
*** dking has joined #openstack-ironic04:14
*** jungleboyj has joined #openstack-ironic04:14
*** ab-a has joined #openstack-ironic04:14
*** tonyb[m] has joined #openstack-ironic04:14
*** NobodyCam has joined #openstack-ironic04:14
*** ildikov has joined #openstack-ironic04:14
*** ajya has joined #openstack-ironic04:14
*** mgagne has joined #openstack-ironic04:14
*** vesper11 has joined #openstack-ironic04:14
*** mcarden has joined #openstack-ironic04:14
*** mgoddard has joined #openstack-ironic04:14
*** naved001 has joined #openstack-ironic04:14
*** jmccrory has joined #openstack-ironic04:14
*** gryf has joined #openstack-ironic04:14
*** lifeless has joined #openstack-ironic04:14
*** ianychoi_ has joined #openstack-ironic04:14
*** melwitt has joined #openstack-ironic04:14
*** akahat has joined #openstack-ironic04:14
*** ftarasenko has joined #openstack-ironic04:14
*** stbenjam has joined #openstack-ironic04:14
*** zer0c00l_ has joined #openstack-ironic04:14
*** dhellmann has joined #openstack-ironic04:14
*** cp- has joined #openstack-ironic04:14
*** rpittau has joined #openstack-ironic04:14
*** yaawang has joined #openstack-ironic04:14
*** michchap has joined #openstack-ironic04:14
*** rnoriega- has joined #openstack-ironic04:14
*** hoonetorg has joined #openstack-ironic04:14
*** mkrai has joined #openstack-ironic04:14
*** fdegir5 has joined #openstack-ironic04:14
*** Lucas_Gray has joined #openstack-ironic04:14
*** tkajinam has joined #openstack-ironic04:14
*** m1p has joined #openstack-ironic04:14
*** mnasiadka has joined #openstack-ironic04:14
*** johnsom has joined #openstack-ironic04:14
*** andrein has joined #openstack-ironic04:14
*** samueldmq has joined #openstack-ironic04:14
*** pas-ha has joined #openstack-ironic04:14
*** johnhaan has joined #openstack-ironic04:14
*** rpioso has joined #openstack-ironic04:14
*** donnyd has joined #openstack-ironic04:14
*** hjensas has joined #openstack-ironic04:14
*** sziviani has joined #openstack-ironic04:14
*** dtruong has joined #openstack-ironic04:14
*** patchbot has joined #openstack-ironic04:14
*** spotz has joined #openstack-ironic04:14
*** sean-k-mooney has joined #openstack-ironic04:14
*** irclogbot_0 has joined #openstack-ironic04:14
*** logan- has joined #openstack-ironic04:14
*** markmcclain has joined #openstack-ironic04:14
*** dtantsur|afk has joined #openstack-ironic04:14
*** brtknr has joined #openstack-ironic04:15
*** mrda has joined #openstack-ironic04:15
*** ddurst has joined #openstack-ironic04:15
*** clarkb has joined #openstack-ironic04:15
*** sshnaidm|afk has joined #openstack-ironic04:15
*** bdodd has joined #openstack-ironic04:15
*** bnemec has joined #openstack-ironic04:15
*** adrianc has joined #openstack-ironic04:15
*** shadower has joined #openstack-ironic04:15
*** early has joined #openstack-ironic04:15
*** zigo has joined #openstack-ironic04:15
*** vkmc has quit IRC04:16
*** gmann has quit IRC04:16
*** mnaser has quit IRC04:16
*** vkmc has joined #openstack-ironic04:17
*** erbarr has quit IRC04:17
*** erbarr has joined #openstack-ironic04:18
*** gmann has joined #openstack-ironic04:19
*** mkowalski has joined #openstack-ironic04:23
*** mkrai has quit IRC04:29
*** mkrai has joined #openstack-ironic04:46
*** mkrai has quit IRC05:15
*** Lucas_Gray has quit IRC05:19
*** mkrai has joined #openstack-ironic05:27
arne_wiebalckGood morning, ironic!05:56
*** ociuhandu has joined #openstack-ironic06:12
*** fdegir5 is now known as fdegir06:16
*** ociuhandu has quit IRC06:17
*** ianychoi_ has quit IRC06:22
*** ianychoi_ has joined #openstack-ironic06:23
*** tkajinam has quit IRC06:25
*** tkajinam has joined #openstack-ironic06:26
*** janders has joined #openstack-ironic06:44
*** janders96 has joined #openstack-ironic06:44
*** mkrai has quit IRC06:47
*** mkrai has joined #openstack-ironic06:48
*** Qianbiao has joined #openstack-ironic06:51
*** janders has quit IRC07:11
*** janders has joined #openstack-ironic07:16
*** janders has quit IRC07:22
*** ricolin has joined #openstack-ironic07:24
*** janders has joined #openstack-ironic07:30
*** dougsz has joined #openstack-ironic07:32
*** janders has quit IRC07:32
iurygregorygood morning arne_wiebalck and Ironic o/07:38
arne_wiebalckhey iurygregory o/07:45
*** mkrai has quit IRC07:48
*** janders has joined #openstack-ironic08:00
*** diurnalist has quit IRC08:05
*** ociuhandu has joined #openstack-ironic08:06
*** derekh has joined #openstack-ironic08:07
*** dtantsur|afk is now known as dtantsur08:09
dtantsurmorning ironic08:09
*** ociuhandu has quit IRC08:10
iurygregorymorning dtantsur o/08:11
dtantsurwe're still seeing No Valid Host found in the CI, I wonder if we need to update more jobs08:11
dtantsuror just change ironic-base to use two VMs..08:11
iurygregorydtantsur, do you have links?08:11
iurygregoryin theory only the ones with cleaning would need 208:12
iurygregory(before they were fine..08:12
dtantsuriurygregory: https://review.opendev.org/#/c/740309/ maybe cleaning is not the cause08:13
patchbotpatch 740309 - ironic-python-agent - Ignore devices with size 0 when collecting inventory - 3 patch sets08:13
dtantsuroh, and now we need to remove half of the jobs08:13
dtantsurbecause we run two tests per job08:13
iurygregoryyeah08:14
iurygregoryI'm making a list of the jobs we can probably remove08:14
*** mkrai has joined #openstack-ironic08:14
iurygregorybut wait it's tinyipa job08:15
*** lucasagomes has joined #openstack-ironic08:15
iurygregorynormaly we have more than 1 VM...08:15
iurygregorybut ofc it uses ironic-base and we didn't override =D08:15
dtantsurironic.common.exception.InvalidParameterValue: Invalid or missing agent token received.08:16
dtantsureehhmmmm\08:16
iurygregorydtantsur, we don't need to override in ironic-base if we want to increase08:16
iurygregorywe can just do on ironic-ipa-base or directly on ipa-tempest-wholedisk-bios-ipmi-direct-dib-src  ipa-tempest-partition-bios-ipmi-direct-src08:17
iurygregoryouch that hurts =(08:17
dtantsurthat's probably a red herring though08:18
dtantsuriurygregory: okay, let's update these jobs: de-duplicate them and increase the VM count (also for their DIB counterparts)08:18
dtantsurand then ditto for ironic-lib, I guess08:18
dtantsurcould you take a look?08:18
iurygregorydtantsur, sure08:18
iurygregoryI will take care of that08:18
dtantsurthx08:19
dtantsuroh, and we need to take a look what is going on in inspector jobs08:19
iurygregorywhat happen to inspector?08:19
iurygregoryhappened*08:20
*** ociuhandu has joined #openstack-ironic08:20
*** Lucas_Gray has joined #openstack-ironic08:22
jandersgood morning guys. Can I nag you with some beginner's questions around the libselinux-python fix?08:24
iurygregoryjanders, sure08:24
jandersthanks iurygregory! :)08:25
iurygregorygood evening probably for you XD08:25
janders1) do I need a story on storyboard for something trivial like this? I suppose not?08:25
iurygregoryI would say it's not required, you just need a release not saying the reason08:26
iurygregoryprobably with "fixes"08:26
jandersright!08:28
jandersif there was a story, I would reference the ID in the commit message. If there isn't, what do I reference?08:28
iurygregoryYou just need to have your Commit message08:29
jandersok!08:30
iurygregorysomething like "removing libselinux-python"   "this lib is only used on python2 env and bifrost is python3 only"08:30
iurygregorysomething on those lines I would say08:30
janderson a related note - in this case, can I name the branch I'm using libselinux-python-fix or sth like this?08:30
dtantsuriurygregory: the inspector job is also red on the patch, but I haven't looked into it08:30
dtantsurjanders: we rarely care about branch names08:30
jandersok!08:31
iurygregorydtantsur, oh ok /me only looked at the other jobs08:31
dtantsuronly in cases where we need to track several patches belonging to one topic like https://review.opendev.org/#/q/topic:story/200696308:31
dtantsurspeaking of which, mgoddard, could you maybe check https://review.opendev.org/#/c/731180/ today?08:31
patchbotpatch 731180 - ironic - Decompose the core deploy step on iscsi and ansibl... - 15 patch sets08:31
janderswhen working with gerrit, can I push the code while working in the branch, or would that cause noise/mess?08:31
dtantsurit's hopefully the last major change for in-band deploy steps08:31
dtantsurjanders: you can submit review with WIP or [WIP] in the beginning of its title08:32
dtantsurthen we'll know it's not ready for review08:32
iurygregoryyeah08:32
jandersok!08:32
dtantsurif you *think* the patch may be complete, but you're not sure, use Workflow-1 button instead08:32
dtantsurand reset workflow to 0 once you're sure it's done08:32
iurygregoryor also mark "workflow -1 by or own", but normally we put [WIP]08:32
jandersand the last question (for now): what's a reasonable way to sufficiently test my patch?08:33
dtantsuriurygregory: these are different cases08:33
dtantsurjanders: if it works for you, it's fine in this case08:33
iurygregoryjanders, I would say test running on F30 running with python308:33
jandersok!08:33
dtantsurthe CI runs F3008:33
dtantsurso just make sure that job passes (it's non-voting)08:34
jandersthis actually opens a whole different can of worms (or questions) about my test-server setup08:34
iurygregoryyeah so he would now if it would fail before08:34
dtantsurit's called blah-blah-fedora-latest (yes, 30 is not latest :)08:34
jandersI'm kinda tempted to deploy OSP13 packstack-allinone on the test server that Tomas has given me08:34
dtantsurjanders: if you can check F32, the CI will check F30 for you08:34
dtantsurI'm using vagrant on my test server08:34
dtantsurwhatever works for you, really08:35
jandershow do you guys  manage OS on your test-servers?08:35
*** Lucas_Gray has quit IRC08:35
jandersis there a kickstart setup in the lab, or do we drink our own champagne and have ironic sitting somewhere?08:35
dtantsurthis is my vagrant file http://paste.openstack.org/show/795739/08:36
dtantsurjanders: you should have received access to Beaker08:36
dtantsurtalk to shadower if you haven't08:36
* iurygregory uses Beaker08:36
* iurygregory can't find janders on internal irc08:37
jandersI do have access to Beaker, but I don't think my reqest for a machine was approved just yet (so shadower gave me another system)08:38
jandersiurygregory: which one is this?08:38
iurygregorywill sent you a pm08:38
*** Lucas_Gray has joined #openstack-ironic08:39
dtantsurjanders: it doesn't have to be approved, shadower should just lend you the machine in beaker08:52
dtantsurit's one button click08:52
janderslet me ask him08:52
*** seba has quit IRC08:56
mgoddarddtantsur: downstream this morning, should get time later09:06
dtantsurokie09:07
*** diurnalist has joined #openstack-ironic09:09
*** diurnalist has quit IRC09:14
*** janders has quit IRC09:18
*** janders has joined #openstack-ironic09:26
*** k_mouza has joined #openstack-ironic10:04
arne_wiebalckftarasenko: did you check once more if the ESP is on all disks?10:07
arne_wiebalckftarasenko: I have just launched a test node and this one has indeed only an ESP on one disk10:07
*** seba has joined #openstack-ironic10:08
*** ricolin has quit IRC10:10
*** dougsz has quit IRC10:15
*** dtantsur is now known as dtantsur|brb10:21
*** dougsz has joined #openstack-ironic10:29
*** mkrai has quit IRC10:45
jandersI'm about to wrap up for the day - have a great weekend everyone10:55
openstackgerritliuyuanfeng proposed openstack/ironic master: fix error word presistent in docs  https://review.opendev.org/74044510:58
*** janders has quit IRC11:01
*** k_mouza has quit IRC11:23
*** Lucas_Gray has quit IRC11:23
*** derekh has quit IRC11:23
*** iurygregory has quit IRC11:23
*** bfournie has quit IRC11:23
*** diurnalist has joined #openstack-ironic11:24
*** k_mouza has joined #openstack-ironic11:27
*** Lucas_Gray has joined #openstack-ironic11:27
*** derekh has joined #openstack-ironic11:27
*** iurygregory has joined #openstack-ironic11:27
*** bfournie has joined #openstack-ironic11:27
*** diurnalist has quit IRC11:29
iurygregorywow a lot of disconnect / re connect11:33
*** hjensas has quit IRC11:44
*** Wryhder has joined #openstack-ironic11:49
*** diurnalist has joined #openstack-ironic11:52
*** Lucas_Gray has quit IRC11:52
*** Wryhder is now known as Lucas_Gray11:52
*** diurnalist has quit IRC11:57
*** Lucas_Gray has quit IRC11:58
*** Lucas_Gray has joined #openstack-ironic12:05
*** dtantsur|brb is now known as dtantsur12:12
*** rh-jelabarre has joined #openstack-ironic12:12
*** rh-jelabarre has quit IRC12:19
*** rh-jelabarre has joined #openstack-ironic12:19
*** derekh has quit IRC12:29
*** Lucas_Gray has quit IRC12:36
openstackgerritMerged openstack/ironic master: fix error word presistent in docs  https://review.opendev.org/74044512:39
*** k_mouza has quit IRC12:44
*** k_mouza has joined #openstack-ironic12:51
*** k_mouza has quit IRC12:53
*** k_mouza has joined #openstack-ironic12:53
*** Lucas_Gray has joined #openstack-ironic12:55
openstackgerritVerification of a change to openstack/ironic failed: Do not validate driver on changing non-driver fields  https://review.opendev.org/73969913:00
*** diurnalist has joined #openstack-ironic13:01
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-python-agent master: Update jobs  https://review.opendev.org/74045413:02
*** hjensas has joined #openstack-ironic13:05
*** k_mouza has quit IRC13:06
*** mnaser has joined #openstack-ironic13:09
dougszI'm looking at this bug: https://storyboard.openstack.org/#!/story/200790513:11
*** jamesdenton has joined #openstack-ironic13:11
dougszand wondering about other block devices of type 'md' apart from partitions13:12
dtantsurdougsz: you need mdadm on your *instance* image13:12
*** tzumainn has joined #openstack-ironic13:12
*** k_mouza has joined #openstack-ironic13:13
dougszthanks dtantsur, I injected it with virt-customize13:13
dtantsurmm, right, I misread it13:14
dtantsuryeah, we need to ignore holder disks when detecting root device13:14
dougszI think in this case it get messed up by list_all_block devices returning mdraid paritions when include_partitions=False13:16
dougszseems to be related to this: https://github.com/openstack/ironic-python-agent/commit/fbfdc49140d6d3145a08a35a34ebf92818c8c86513:16
*** k_mouza has quit IRC13:17
*** rloo has joined #openstack-ironic13:17
dtantsurarne_wiebalck: ^^^13:18
dougszstruggling to create anything of type 'md' which isn't a partition, but it seems arne saw that before13:18
TheJuliagood morning13:19
dtantsurmmm, we definitely don't need type 'md' for root device detection13:19
dtantsurmorning TheJulia13:19
dtantsurbut we do need it for cleaning13:19
* dtantsur scratches head13:20
dougszyeah - and I see the logic for skipping devices of type md which are partitions in cleaning13:20
*** derekh has joined #openstack-ironic13:20
dougszwondering if some extra probing of devices of type 'md' is required, to distinguish between what is a partition and what is something else13:21
*** shadower has quit IRC13:21
iurygregorygood morning TheJulia13:22
iurygregory=)13:22
openstackgerritDoug Szumski proposed openstack/ironic-python-agent master: WIP: Fix bootloader install issue with MDRAID  https://review.opendev.org/74033113:22
dtantsurdougsz: I guess I'll have to defer to arne_wiebalck who's our RAID specialist :)13:22
dtantsurbut I absolutely agree that the bug is valid13:22
dougszI will push some sort of strawman fix to the bug above - thanks for the sanity check dtantsur13:23
*** shadower has joined #openstack-ironic13:24
*** irclogbot_0 has quit IRC13:27
arne_wiebalckdougsz: hi!13:28
dougszhey arne!13:29
*** irclogbot_3 has joined #openstack-ironic13:29
* arne_wiebalck is reading the backlog13:29
*** markmcclain has quit IRC13:29
arne_wiebalckdougsz: I guess your image is not having the rootfs uuid set in the metadata of the image?13:30
*** k_mouza has joined #openstack-ironic13:30
*** bdodd has quit IRC13:30
dougszcorrect - this is with bifrost13:30
*** logan- has quit IRC13:30
dougsz(legacy boot)13:30
*** markmcclain has joined #openstack-ironic13:30
*** gmann has quit IRC13:30
*** m1p has quit IRC13:30
arne_wiebalckdougsz: ok, I guess this is where the second 'p1' comes from: the code will assume the root fs is on the first partition13:31
arne_wiebalckdougsz: I don't see where the first 'p1' comes from, though13:31
*** gmann has joined #openstack-ironic13:32
arne_wiebalckdougsz: which version is this?13:32
dougsztrain13:32
*** bdodd has joined #openstack-ironic13:32
*** logan- has joined #openstack-ironic13:32
*** m1p has joined #openstack-ironic13:33
*** k_mouza has quit IRC13:34
dougszbut inspecting master, I see the same issue in list_block_devices, that when include_partitions=False, it can still return partitions on the mdraid device13:34
dougszWe should see it on the unit test failures on https://review.opendev.org/74033113:35
patchbotpatch 740331 - ironic-python-agent - WIP: Fix bootloader install issue with MDRAID - 2 patch sets13:35
arne_wiebalckdougsz: the roofs uuid only comes with Ussuri anyway13:36
dougszyeah, that is something on the todo list :)13:36
arne_wiebalckdougsz: this is what is adding the second p1: https://github.com/openstack/ironic-python-agent/blob/stable/train/ironic_python_agent/extensions/image.py#L6813:37
dougszyeah - so the device there should be the root device, and not the partition13:37
arne_wiebalckdougsz: right, so it seems bifrost provides the partition already13:38
dougszIt comes from a whole disk image, written just before the bootloader is installed13:38
arne_wiebalckdougsz: but this is inside _get_partition, so why is the partition passed to this function?13:39
arne_wiebalckdougsz: the function is supposed to returned it :)13:39
dougszagree! list_all_block_devices returns the root device, the holder disks *and* the raid partitions13:39
dougszthe raid partition then gets selected (wrongly) as the root device and passed to that function13:40
arne_wiebalckhmm ... where is that happening?13:40
dougszIn this call I think: https://github.com/openstack/ironic-python-agent/blob/stable/train/ironic_python_agent/extensions/image.py#L54213:41
dougszI understand you have seen mdraid devices, of type 'md' that aren't partitions? from: https://github.com/openstack/ironic-python-agent/commit/fbfdc49140d6d3145a08a35a34ebf92818c8c86513:42
dougszI haven't been able to make one so far (spares seem to show up as type raidx) for me, but I expect I haven't reproduced the scenario13:43
*** k_mouza has joined #openstack-ironic13:43
dougszNaive fix is to restore this: https://github.com/openstack/ironic-python-agent/commit/fbfdc49140d6d3145a08a35a34ebf92818c8c865#diff-edff6855c0b0863a855b77705d21581bL29213:44
dougszBut I don't want to break your scenario13:44
arne_wiebalckdougsz: yes, but this was for broken raid devices, e.g. a RAID-0 where one disk was missing13:45
openstackgerritBob Fournier proposed openstack/ironic master: Use min_command_interval when ironic does IPMI retries  https://review.opendev.org/74046613:45
dougszarne_wiebalck: thanks, that helps, I will re-creating that scenario13:45
dougsz*try13:45
arne_wiebalckdougsz: I think it'd be good to see which devices are considered13:46
arne_wiebalckdougsz: since it seems the code after does not expect a partition13:47
arne_wiebalckdougsz: at least the RAID code13:47
*** k_mouza has quit IRC13:48
*** k_mouza has joined #openstack-ironic13:48
dougszOk, thanks arne_wiebalck, I will see what I can come up with and update the patch for review sometime13:50
arne_wiebalckdougsz: thanks!13:50
dougsznp, you've put a lot of nice work into software raid, along with others from the project, much appreciated13:51
*** diurnalist has quit IRC14:05
*** ricolin has joined #openstack-ironic14:15
*** diurnalist has joined #openstack-ironic14:23
TheJuliabrraaaainssss14:32
*** TheJulia is now known as zombieJulia14:32
zombieJuliaset casualnickfriday=114:33
zombieJuliaokay, https://review.opendev.org/#/c/740344 passed... rechecked to see if we just need to be slightly more explicit on what we return14:35
patchbotpatch 740344 - ironic-inspector - WIP: Additional debugging around inspection start - 2 patch sets14:35
zombieJuliaWe may just need to set a content type for the empty body, which makes no sense14:35
*** dtantsur is now known as creepy_owlet14:36
zombieJuliathen again, I have no idea what an empty body would be content wise14:36
creepy_owletzombieJulia: could you check https://review.opendev.org/#/c/731180/ today? I have a selfish goal of closing this task downstream today :)14:37
patchbotpatch 731180 - ironic - Decompose the core deploy step on iscsi and ansibl... - 15 patch sets14:37
zombieJuliacreepy_owlet: sure, i'll start in a moment. It was on my list yesterday but I ran out of spoons completely14:37
creepy_owletI can imagine :( on the other hand, it's very similar to the direct deploy patch14:38
*** iurygregory is now known as skolt14:45
zombieJuliacreepy_owlet: yeah, I remember looking, got distracted, wanted to table flip about something. Yesterday was not a good day14:46
creepy_owlet:(14:46
*** bnemec is now known as beekneemech14:47
zombieJuliaDone14:50
zombieJuliaany chance I could get some eyes on https://review.opendev.org/#/c/72748014:50
patchbotpatch 727480 - ironic - Iso booting via redfish virtual media - 6 patch sets14:50
creepy_owletlooking now14:50
creepy_owletzombieJulia: a question https://review.opendev.org/#/c/727480/6/ironic/drivers/modules/deploy_utils.py14:53
patchbotpatch 727480 - ironic - Iso booting via redfish virtual media - 6 patch sets14:53
zombieJuliacreepy_owlet: I don't... think so14:57
creepy_owletzombieJulia: won't check_for_missing_params get upset if neither image is present?14:58
zombieJuliaI'm a little fuzzy on that and I think there was a reason not to.14:58
zombieJuliawait14:58
creepy_owletor does it only check for stuff that is explicitly None14:58
zombieJuliathat is the list generation one isent it14:58
creepy_owlet(maybe the latter)14:58
zombieJuliathe entire code for validating the deployment stuffs is super convoluted14:59
creepy_owletoh yeah14:59
zombieJuliapulling down the patch and give that a quick spin in unit tests and see what implodes14:59
creepy_owletmmm, yeah, check_for_missing_params only fails on items that are None14:59
creepy_owletzombieJulia: https://review.opendev.org/#/c/727480/6/ironic/drivers/modules/redfish/boot.py@784 comes from parse_deploy_info15:01
patchbotpatch 727480 - ironic - Iso booting via redfish virtual media - 6 patch sets15:01
creepy_owletand that needs to be populated15:01
zombieJuliadid I do that in the later patch?15:02
creepy_owletnot sure, but it looks like info has to be populated15:03
zombieJuliaI'm not entirely sure, again, this is all super convoluted15:05
zombieJuliastrong possibility it is int he second patch :\15:05
*** mkrai has joined #openstack-ironic15:08
zombieJuliatox running15:14
zombieJuliaskolt: https://review.opendev.org/#/c/739715/ fyi15:15
patchbotpatch 739715 - ironic - CI: Make ipv6 job to voting - 1 patch set15:15
skoltdone \o/15:17
zombieJuliarofl15:19
zombieJuliano failed tests changing that15:19
*** tkajinam has quit IRC15:37
gudrutiszombieJulia: eh, cov-19 got to you as well?15:46
openstackgerritJulia Kreger proposed openstack/ironic master: Iso booting via redfish virtual media  https://review.opendev.org/72748015:47
*** gyee has joined #openstack-ironic15:48
zombieJuliagudrutis: well, likely got it on my CDG->BOS flight right before transalantic flights began shutting down15:49
zombieJuliagudrutis: but... couldn't get any sort of testing because I didn't meet the qualifiers15:49
gudrutisand that is how zombieJulia was born?15:50
*** mkrai has quit IRC15:52
*** lucasagomes has quit IRC16:00
openstackgerritJulia Kreger proposed openstack/ironic master: iPXE ISO Ramdisk booting  https://review.opendev.org/72946416:01
zombieJuliagudrutis: I don't remember, it just seemed to represent my present state of feeling16:02
zombieJuliacreepy_owlet: so.. yeah... that was in the ipxe patch16:02
zombieJuliarechecking https://review.opendev.org/#/c/736383/11 for good measure16:03
patchbotpatch 736383 - ironic - ISO ramdisk virtual media test enablement - 11 patch sets16:03
*** diurnalist has quit IRC16:13
*** creepy_owlet is now known as dtantsur|afk16:19
dtantsur|afkhave a great weekend16:19
*** diurnalist has joined #openstack-ironic16:23
zombieJuliadtantsur|afk: have a good weekend16:23
*** diurnalist has quit IRC16:27
openstackgerritDoug Szumski proposed openstack/ironic-python-agent master: Fix bootloader install issue with MDRAID  https://review.opendev.org/74033116:29
*** dougsz has quit IRC16:32
*** Qianbiao has quit IRC16:32
*** diurnalist has joined #openstack-ironic16:35
openstackgerritVerification of a change to openstack/ironic failed: Stop using md5 for __repr__ of objects  https://review.opendev.org/74032916:35
dkingWhen I move a node from active to available using the "deleted" target, does it also clean the node?16:37
*** k_mouza has quit IRC16:45
*** Lucas_Gray has quit IRC16:46
*** dmellado has joined #openstack-ironic16:50
*** dmellado has quit IRC17:04
*** dmellado has joined #openstack-ironic17:08
*** derekh has quit IRC17:09
NobodyCamGood morning Ironicer's. and ofc TGIF!17:10
*** ociuhandu has quit IRC17:20
*** dmellado has quit IRC17:26
*** aedc has joined #openstack-ironic17:28
arne_wiebalckdking: yes17:40
arne_wiebalckbye everyone, have a good week-end o/17:40
dkingarne_wiebalck: Have a good weekend.17:41
*** dougsz has joined #openstack-ironic17:51
openstackgerritVerification of a change to openstack/ironic failed: Do not validate driver on changing non-driver fields  https://review.opendev.org/73969917:52
*** Goneri has joined #openstack-ironic17:54
*** Goneri has quit IRC18:00
zombieJuliabfournie: re your min command interval change. Is the internal retry logic still taking account for the interval as well?18:12
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-python-agent master: Update jobs  https://review.opendev.org/74045418:16
skoltthis will unblock our ipa CI18:17
*** dougsz has quit IRC18:20
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-python-agent-builder master: Update ipa jobs  https://review.opendev.org/74051918:35
bfourniezombieJulia: yes, it takes it into account here https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L51518:39
openstackgerritVerification of a change to openstack/ironic failed: Decompose the core deploy step on iscsi and ansible deploy  https://review.opendev.org/73118018:47
*** ricolin has quit IRC19:22
*** zaneb has quit IRC19:39
*** zbitter has joined #openstack-ironic19:39
*** Goneri has joined #openstack-ironic20:01
openstackgerritMerged openstack/ironic master: CI: Make ipv6 job to voting  https://review.opendev.org/73971520:05
zombieJuliabfournie: thanks!20:20
openstackgerritJulia Kreger proposed openstack/ironic master: iPXE ISO Ramdisk booting  https://review.opendev.org/72946420:26
openstackgerritHarald JensÃ¥s proposed openstack/ironic master: Switch Ironic to openstacksdk for Neutron  https://review.opendev.org/73487320:32
*** diurnalist has quit IRC20:40
*** diurnalist has joined #openstack-ironic20:44
*** Goneri has quit IRC20:51
*** diurnali1t has joined #openstack-ironic21:00
*** diurnalist has quit IRC21:00
*** diurnalist has joined #openstack-ironic21:05
*** diurnali1t has quit IRC21:05
openstackgerritJulia Kreger proposed openstack/ironic master: Remove locks before RPC bus is started  https://review.opendev.org/74036021:34
zombieJuliadtantsur|afk: you mentioned the adopt-failed power state issue when we spoke earlier that hardys encountered. I noted that the machine's state itself was recorded as off, which kind of invalidates anything we could do because "fixing it" for adopt-failed is just pushing the problem around.21:44
zombieJuliazer0c00l_: o/21:47
zombieJuliazer0c00l_: I commented on https://storyboard.openstack.org/#!/story/2007839 I think we're going to need a little more detail as to what you anticipate a kickstart deploy interface to do, even at high level mechanics or responsibilities of the deploy_interface as proposed so we can better understand21:47
openstackgerritMerged openstack/ironic-python-agent master: Update jobs  https://review.opendev.org/74045421:48
*** Goneri has joined #openstack-ironic21:49
openstackgerritMerged openstack/ironic stable/ussuri: add tempest boot_mode config  https://review.opendev.org/74022121:53
*** rcernin has joined #openstack-ironic22:09
*** dmellado has joined #openstack-ironic22:20
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic stable/train: add tempest boot_mode config  https://review.opendev.org/74052922:27
*** rloo has quit IRC22:43
*** tzumainn has quit IRC23:13
*** rh-jelabarre has quit IRC23:38
*** rh-jelabarre has joined #openstack-ironic23:41
*** rh-jelabarre has quit IRC23:42
*** rh-jelabarre has joined #openstack-ironic23:42
*** rh-jelabarre has quit IRC23:47
*** sean-k-mooney has quit IRC23:53
*** sean-k-mooney has joined #openstack-ironic23:56

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!