*** trandles has quit IRC | 00:09 | |
*** bdodd has quit IRC | 00:19 | |
*** bdodd has joined #openstack-ironic | 00:23 | |
JayF | rpioso: http://codesearch.openstack.org/?q=reboot_requested&i=nope&files=&repos=openstack/ironic returned a lot of results; I was thinking about https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/agent_base.py#L1132 but it looks like that general concept might exist in other drivers too | 01:04 |
---|---|---|
JayF | rpioso: I have no general familiarity with the concept; when we implemented it originally (5+!? years ago) there were almost zero other drivers with any cleaning steps | 01:05 |
*** yaawang has quit IRC | 01:26 | |
*** yaawang has joined #openstack-ironic | 01:28 | |
rpioso | JayF: Thank you! | 01:37 |
*** janders has quit IRC | 01:43 | |
*** gyee has quit IRC | 01:44 | |
*** yaawang has quit IRC | 01:53 | |
*** yaawang has joined #openstack-ironic | 01:54 | |
*** diurnalist has quit IRC | 02:33 | |
*** yaawang has quit IRC | 02:36 | |
*** yaawang has joined #openstack-ironic | 02:37 | |
*** Goneri has quit IRC | 03:10 | |
*** yaawang has quit IRC | 03:25 | |
*** yaawang has joined #openstack-ironic | 03:26 | |
*** rcernin has quit IRC | 03:29 | |
*** mkrai has joined #openstack-ironic | 03:36 | |
*** rcernin has joined #openstack-ironic | 03:40 | |
*** rh-jelabarre has quit IRC | 03:52 | |
*** rcernin has quit IRC | 03:58 | |
*** rcernin has joined #openstack-ironic | 04:15 | |
*** diurnalist has joined #openstack-ironic | 04:21 | |
*** mkrai has quit IRC | 04:24 | |
*** mkrai has joined #openstack-ironic | 04:31 | |
*** mkrai has quit IRC | 04:50 | |
*** mkrai has joined #openstack-ironic | 04:50 | |
*** tzumainn has quit IRC | 05:22 | |
*** mkrai has quit IRC | 05:33 | |
*** mkrai_ has joined #openstack-ironic | 05:33 | |
*** diurnalist has quit IRC | 05:34 | |
*** janders has joined #openstack-ironic | 06:18 | |
*** janders has quit IRC | 06:38 | |
*** janders has joined #openstack-ironic | 06:49 | |
*** ntt__ has joined #openstack-ironic | 06:54 | |
iurygregory | good morning Ironic, happy Friday! | 07:07 |
*** dougsz has joined #openstack-ironic | 07:26 | |
*** ociuhandu has quit IRC | 07:44 | |
*** dougsz has quit IRC | 07:53 | |
*** ociuhandu has joined #openstack-ironic | 08:00 | |
*** ianw has quit IRC | 08:01 | |
*** ianw has joined #openstack-ironic | 08:02 | |
*** ociuhandu has quit IRC | 08:03 | |
*** ociuhandu has joined #openstack-ironic | 08:03 | |
*** dougsz has joined #openstack-ironic | 08:09 | |
*** lucasagomes has joined #openstack-ironic | 08:10 | |
*** mkrai_ has quit IRC | 08:22 | |
*** mkrai__ has joined #openstack-ironic | 08:22 | |
rpittau | good morning ironic! o/ | 08:22 |
iurygregory | morning rpittau o/ | 08:23 |
rpittau | hey iurygregory :) | 08:23 |
janders | good morning iurygregory and rpittau | 08:24 |
rpittau | hey janders :) | 08:24 |
iurygregory | *afternoon* janders o/ | 08:25 |
openstackgerrit | Merged openstack/bifrost master: Support configuring credential-less deploy https://review.opendev.org/741894 | 08:31 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: migrate testing to ubuntu focal https://review.opendev.org/739448 | 08:31 |
openstackgerrit | Merged openstack/bifrost master: Make ironic logging more in line with other services. https://review.opendev.org/742854 | 08:31 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent master: Use ubuntu focal for ipa src https://review.opendev.org/725794 | 08:31 |
rpittau | rebase remix | 08:32 |
*** livelace has joined #openstack-ironic | 08:32 | |
*** derekh has joined #openstack-ironic | 08:34 | |
*** Lucas_Gray has joined #openstack-ironic | 08:43 | |
gudrutis0 | Hi ironic 0/ | 08:51 |
janders | g'day gudrutis0 | 08:53 |
janders | o/ | 08:53 |
gudrutis0 | janders: cool, I found an Australian 0/ | 08:58 |
gudrutis0 | rpittau: in devstack/local.con, 'IRONIC_VM_SPECS_RAM=2048' parameter is still suficient? | 08:59 |
gudrutis0 | or maybe you changed things? | 08:59 |
rpittau | gudrutis0: depends on the image you're using and the job you're running | 09:00 |
rpittau | where did you get that value from ? | 09:00 |
gudrutis0 | https://docs.openstack.org/ironic/latest/contributor/dev-quickstart.html#ironic | 09:01 |
gudrutis0 | just want to run default devstack setup and use ironic-inspector with my patches on top, but virtual barametal nodes fail to boot | 09:02 |
rpittau | gudrutis0: yeah, that's the minimum possible value | 09:02 |
gudrutis0 | they are in 'clean failed' state | 09:02 |
rpittau | you should check the logs and see why they're failing, if it's RAM you will probably see some truncated ipa logs | 09:03 |
rpittau | go with 3096 just to be sure | 09:03 |
rpittau | 3072* | 09:03 |
gudrutis0 | `Timeout reached while cleaning the node. Please check if the ramdisk responsible for the cleaning is running on the node. Failed on step {}.` | 09:04 |
*** yolanda has quit IRC | 09:06 | |
gudrutis0 | rpittau: these logs ? `journalctl -f -u devstack@ir-cond.service` i do not see anyting | 09:07 |
rpittau | gudrutis0: ideally, logs coming from ironic-python-agent | 09:08 |
gudrutis0 | heh, I can't ping nor ssh the machine | 09:08 |
gudrutis0 | so I guess it didnt even boot | 09:08 |
gudrutis0 | ill try to increase the memory | 09:09 |
janders | you know some people think that dev in devstack comes from devil not development... | 09:11 |
janders | oh well, sounds like the new season of Lucifer is airing in about ~3 weeks :) | 09:11 |
gudrutis0 | sometimes I think I develop devstack, not ironic | 09:12 |
janders | that is the devil-ish part... | 09:12 |
rpittau | we do also that, adjusting devstack to our needs | 09:12 |
rpittau | or is devstack adjusting us to its needs? | 09:12 |
janders | +1 | 09:13 |
janders | :) | 09:13 |
*** livelace has quit IRC | 09:15 | |
gudrutis0 | guys stop scaring me that devstack starts to become sentient like some sort of skynet | 09:16 |
*** yolanda has joined #openstack-ironic | 09:16 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-tempest-plugin master: Test software RAID in deploy-time on Victoria and newer https://review.opendev.org/741227 | 09:17 |
*** dtantsur|afk is now known as dtantsur | 09:19 | |
dtantsur | morning ironic | 09:19 |
janders | no need to get scared - devstack wouldn't scale to skynet levels | 09:20 |
dtantsur | gudrutis0: oh, you've just noticed that devstack has a will of its own? | 09:20 |
dtantsur | janders: exactly, because devstack does not scale :D | 09:20 |
janders | goodmorning dtantsur :) | 09:20 |
janders | +1 | 09:20 |
dtantsur | janders: hey-hey, happy Friday evening! does it feel like weekend already? | 09:20 |
gudrutis0 | :DDD | 09:20 |
janders | indeed | 09:20 |
janders | well past beer o clock here | 09:20 |
dtantsur | :) | 09:21 |
rpittau | fried eggs and beer for breakfast? | 09:21 |
janders | champagne breakfasts are best | 09:21 |
janders | (though I personally quite like prosecco) | 09:22 |
rpittau | janders: if you have the chance, and since you like prosecco, you should try Vermentino | 09:23 |
rpittau | might be hard to find on the other side of the world though :/ | 09:23 |
janders | https://www.danmurphys.com.au/white-wine/vermentino | 09:24 |
janders | looks like I can get it here. Thanks for the recommendation rpittau :) | 09:25 |
rpittau | I stand corrected :) | 09:25 |
janders | it seems they grow it here, too, not sure how successfully | 09:25 |
janders | Aussie prosecco is quite good | 09:25 |
rpittau | janders: this sounds authentic https://www.danmurphys.com.au/product/DM_ER_2000003334_010602/sant-armettu-verment | 09:25 |
janders | but there is a very specific Italian-Australian region in Victoria that does the best Aussie prosecco IMO | 09:26 |
rpittau | I see, they imported the grapes I guess | 09:26 |
rpittau | well the climate should be very similar | 09:26 |
*** k_mouza has joined #openstack-ironic | 09:26 | |
janders | indeed | 09:27 |
janders | it's an interesting story actually, not sure if I should be spamming the IRC channel with it but it's Friday night here and I will try to be brief | 09:27 |
janders | those guys came from Italy just after WW2 and used to grow tobacco | 09:28 |
janders | they were growing grapes and making wine but just for themselves | 09:28 |
janders | and when the big Aussie wine boom started, they figured they will scale up a bit :) | 09:28 |
janders | worked out pretty well | 09:28 |
rpittau | interesting, I know lots of Italians moved there after WWII, didn't know about the tobacco | 09:29 |
janders | I reckon wine is a much better option on all levels | 09:29 |
gudrutis0 | rpittau: looks my offering of 3072 MB RAM pleased the DEVstack | 09:39 |
openstackgerrit | Merged openstack/ironic master: Convert root controller to plain controller https://review.opendev.org/741064 | 09:41 |
openstackgerrit | Verification of a change to openstack/ironic failed: Convert v1 controller to plain, return JSON https://review.opendev.org/741065 | 09:42 |
janders | good to hear that four sacrificial gigs of memory do the trick for now :) | 09:43 |
janders | my old laptop only has that much but I'm hopefully getting a new one soon | 09:44 |
gudrutis0 | janders: my phone has almost triple of that... | 09:47 |
gudrutis0 | mmm, could I run devstack on my phone then though ? | 09:48 |
janders | you probably could, but do you want to? :) | 09:48 |
*** livelace has joined #openstack-ironic | 09:51 | |
*** Lucas_Gray has quit IRC | 10:10 | |
janders | given we don't distribute "default config" with ironic, what is the recommended way of adding new config options to the auto-generated one? | 10:13 |
openstackgerrit | Aija Jaunteva proposed openstack/ironic-specs master: Operationally efficient & fast-track provisioning https://review.opendev.org/740721 | 10:14 |
openstackgerrit | Jacob Anders proposed openstack/ironic master: [WIP]Generic way to configure clean step priorites https://review.opendev.org/744117 | 10:17 |
janders | Time to call it a night here. Have a great weekend all! o/ | 10:19 |
openstackgerrit | Aija Jaunteva proposed openstack/ironic-specs master: Operationally efficient & fast-track provisioning https://review.opendev.org/740721 | 10:19 |
gudrutis0 | Thanks, have a nice drink 0/ | 10:19 |
janders | thanks gudrutis0 :) | 10:20 |
gudrutis0 | at least you have winter there so it will be a cold one... | 10:21 |
*** Lucas_Gray has joined #openstack-ironic | 10:24 | |
*** rcernin has quit IRC | 10:33 | |
*** rcernin has joined #openstack-ironic | 10:50 | |
*** rcernin has quit IRC | 10:50 | |
*** ociuhandu_ has joined #openstack-ironic | 11:03 | |
openstackgerrit | Merged openstack/ironic master: Use TLS for json_rpc when configured https://review.opendev.org/743912 | 11:04 |
*** ociuhandu has quit IRC | 11:08 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/ussuri: Use TLS for json_rpc when configured https://review.opendev.org/744131 | 11:17 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/train: Use TLS for json_rpc when configured https://review.opendev.org/744132 | 11:17 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: set EVENTLET_NO_GREENDNS to 'yes' https://review.opendev.org/742011 | 11:22 |
dtantsur | TheJulia: trying another approach to tame pep8 ^^ | 11:23 |
*** ntt__ has quit IRC | 11:27 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: Import example hardware managers from ipa-example-hardware-managers https://review.opendev.org/743794 | 11:36 |
*** tkajinam has quit IRC | 11:36 | |
*** mkrai__ has quit IRC | 11:52 | |
openstackgerrit | vinay kumar muddu proposed openstack/ironic master: Allow HttpImageService to accept custom certificate https://review.opendev.org/742936 | 12:08 |
*** Lucas_Gray has quit IRC | 12:12 | |
*** rh-jelabarre has joined #openstack-ironic | 12:14 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: [PoC] A deploy step to update /etc/default/grub https://review.opendev.org/743771 | 12:37 |
*** Lucas_Gray has joined #openstack-ironic | 12:46 | |
rpittau | dtantsur, TheJulia: for https://review.opendev.org/742011 would it work to put that in __init__.py instead ? | 12:54 |
patchbot | patch 742011 - ironic-python-agent - set EVENTLET_NO_GREENDNS to 'yes' - 4 patch sets | 12:54 |
*** rloo has joined #openstack-ironic | 12:58 | |
dtantsur | probably | 13:00 |
rpittau | just thinking of a way we could avoid noqa or similar exceptions | 13:03 |
*** ntt__ has joined #openstack-ironic | 13:08 | |
*** ociuhandu_ has quit IRC | 13:23 | |
*** ociuhandu has joined #openstack-ironic | 13:24 | |
*** tzumainn has joined #openstack-ironic | 13:42 | |
TheJulia | it has to be before we monkey patch which gets invoked upon agent.py being loaded in general, but maybe move the monkeypatch around | 13:47 |
* TheJulia doesn't know but slept well last night | 13:47 | |
*** sdanni has joined #openstack-ironic | 13:48 | |
dtantsur | morning TheJulia | 13:51 |
dtantsur | TheJulia: the nuclear option is ironic_python_agent/__init__.py | 13:51 |
dtantsur | this is the first thing that is ever imorted | 13:51 |
jroll | do we really need eventlet in IPA? | 13:54 |
jroll | or is it just because we're using oslo.concurrency? | 13:55 |
dtantsur | oslo.service | 13:55 |
dtantsur | yeah, oslo.service is based on eventlet | 13:55 |
jroll | er, yeah, that | 13:55 |
jroll | anyway, I wonder if we really need it, just a random thought | 13:57 |
jroll | :q | 13:58 |
jroll | oops heh | 13:58 |
TheJulia | proper timeout handling on cases where tcp sockets can get stalled | 14:02 |
TheJulia | since the python requests code can stall mid-download | 14:03 |
TheJulia | if you oh... put the port in a LACP blocking state | 14:03 |
TheJulia | Which is also why I wrote https://review.opendev.org/#/c/743787/ | 14:04 |
patchbot | patch 743787 - ironic - Detail iPXE + LACP troubleshooting information - 1 patch set | 14:04 |
TheJulia | because... yeah | 14:04 |
TheJulia | Anyway, I'm taking today off :) | 14:04 |
bnemec | Generally speaking, if you're going to monkey patch you want to do it before anything else gets imported. | 14:05 |
*** diurnalist has joined #openstack-ironic | 14:06 | |
bnemec | Either in top-level __init__.py or possibly in a cli entrypoint if there are things in the project that don't want monkey patching. | 14:06 |
bnemec | https://specs.openstack.org/openstack/openstack-specs/specs/eventlet-best-practices.html#monkey-patching | 14:07 |
*** livelace has quit IRC | 14:09 | |
rpittau | TheJulia: enjoy :) | 14:11 |
*** Goneri has joined #openstack-ironic | 14:11 | |
rpittau | bnemec: yeah, that was what I was thinking, top-level __init__.py probably the best option | 14:12 |
openstackgerrit | Verification of a change to openstack/bifrost failed: bifrost_inventory: use stderr for logging https://review.opendev.org/743774 | 14:12 |
dtantsur | I can update since TheJulia is on PTO | 14:19 |
rpittau | dtantsur: yup | 14:19 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: set EVENTLET_NO_GREENDNS to 'yes' https://review.opendev.org/742011 | 14:21 |
dtantsur | something like this ^^? | 14:21 |
rpittau | heh yeah | 14:24 |
*** dougsz has quit IRC | 14:42 | |
*** diurnalist has quit IRC | 14:44 | |
*** Lucas_Gray has quit IRC | 14:44 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic-tempest-plugin master: Update basic_ops https://review.opendev.org/741445 | 14:45 |
*** Zempashi has joined #openstack-ironic | 14:46 | |
sdanni | Does anyone have issue when building a centos 7 ramdisk image with ironic-python-agent-builder? It always has error like 'ironic-python-agent requires Python '>=3.6' but the running Python is 2.7.5' | 14:46 |
clarkb | sdanni: you'll need to install an older IPA version that supports python2 or install python3 on centos7 and install IPA under that | 14:48 |
clarkb | I'm guessing that is a bug in yhe IPA dib element? | 14:49 |
dtantsur | sdanni: use release train or older | 14:49 |
dtantsur | --release=stable/train or something like that | 14:50 |
sdanni | dtantsur, clarkb: thanks! I'm having a try! | 14:50 |
dtantsur | if people keep having troubles with drivers, we may need to start supporting python 3 under centos 7 | 14:51 |
dtantsur | which is something we wanted to avoid.. :( | 14:51 |
rpittau | oh please no.... | 14:51 |
dtantsur | ikr? | 14:52 |
dking | It's just growing pains, I hope. Everything should be on CentOS 8 since train. | 14:52 |
dtantsur | CentOS/RHEL 8 dropped drivers for some hardware that can still be found in the wild | 14:53 |
dtantsur | I suspect that's why sdanni needs 7? | 14:53 |
*** diurnalist has joined #openstack-ironic | 14:53 | |
*** Lucas_Gray has joined #openstack-ironic | 14:55 | |
dking | That's a shame. That would make things frustrating. | 14:56 |
sdanni | dtantsur, yes. we are having issue with centos 8. after we login with dynamic-login element, we add the ip address (192.168.1.0/24) that the machine previously cannot connect with, and we can successfully curl this ip. After running ironic-python-agent python file, we again lose the connectivity with 192.168.1.0/24 | 14:56 |
sdanni | It's really weird | 14:57 |
*** livelace has joined #openstack-ironic | 14:58 | |
dtantsur | I've checked, it's possible to install IPA with Python 3 from CentOS 7 | 15:03 |
dtantsur | we can support that (SIGH) | 15:03 |
rpittau | I could have a look at that next week if noone else beat me at it :) | 15:09 |
*** livelace has quit IRC | 15:13 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: Support installing with Python 3 on CentOS 7 https://review.opendev.org/744197 | 15:14 |
dtantsur | rpittau: I think I just did ^^^ | 15:15 |
dtantsur | (assuming the CI passes, I haven't run the whole build locally) | 15:15 |
*** mkrai has joined #openstack-ironic | 15:15 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: Support installing with Python 3 on CentOS 7 https://review.opendev.org/744197 | 15:19 |
openstackgerrit | Merged openstack/bifrost stable/ussuri: bifrost_inventory: use stderr for logging https://review.opendev.org/743774 | 15:21 |
*** livelace has joined #openstack-ironic | 15:31 | |
*** Zempashi has quit IRC | 15:32 | |
*** mkrai has quit IRC | 15:32 | |
*** mkrai has joined #openstack-ironic | 15:33 | |
*** bnemec is now known as beekneemech | 15:35 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: Support installing with Python 3 on CentOS 7 https://review.opendev.org/744197 | 15:49 |
*** ociuhandu has quit IRC | 15:55 | |
*** irclogbot_1 has quit IRC | 15:56 | |
*** irclogbot_3 has joined #openstack-ironic | 15:57 | |
*** ociuhandu has joined #openstack-ironic | 15:59 | |
*** lucasagomes has quit IRC | 16:02 | |
rpittau | dtantsur: it looks good, I would just use yum on L23 as we're limiting to centos7/rhel7, but it's not really important | 16:04 |
dtantsur | rpittau: yeah, doing it in case it can be yum with some args | 16:04 |
* dtantsur watches zuul | 16:04 | |
rpittau | oh I see, ok makes sense | 16:04 |
*** ntt__ has quit IRC | 16:04 | |
*** ociuhandu has quit IRC | 16:04 | |
dtantsur | seems to work https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f61/744197/3/check/ironic-python-agent-check-image-dib-centos7-python3/f61f372/job-output.txt | 16:07 |
*** k_mouza has quit IRC | 16:07 | |
dtantsur | I guess we should release IPA-builder after it merges | 16:08 |
rpittau | yep :) | 16:08 |
rpittau | still holding on ipa for ussuri, unless we want to leave those out https://review.opendev.org/#/q/status:open+project:openstack/ironic-python-agent+branch:stable/ussuri | 16:10 |
*** ociuhandu has joined #openstack-ironic | 16:10 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: Support installing with Python 3 on CentOS 7 https://review.opendev.org/744197 | 16:12 |
dtantsur | a couple of tweaks ^^ | 16:12 |
rpittau | oh yeah, good point on putting the locale first | 16:13 |
*** ociuhandu has quit IRC | 16:15 | |
*** irclogbot_3 has quit IRC | 16:15 | |
*** irclogbot_3 has joined #openstack-ironic | 16:16 | |
dtantsur | https://review.opendev.org/#/c/742011/ seems to work as well | 16:39 |
patchbot | patch 742011 - ironic-python-agent - set EVENTLET_NO_GREENDNS to 'yes' - 5 patch sets | 16:39 |
rpittau | nice | 16:41 |
*** Lucas_Gray has quit IRC | 16:41 | |
*** Lucas_Gray has joined #openstack-ironic | 16:43 | |
iurygregory | GREEN | 16:44 |
iurygregory | I was about to give +2 but too late hehe | 16:44 |
*** k_mouza has joined #openstack-ironic | 16:47 | |
*** k_mouza has quit IRC | 16:51 | |
*** k_mouza has joined #openstack-ironic | 17:19 | |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Add developer mode to bifrost https://review.opendev.org/744233 | 17:21 |
*** Lucas_Gray has quit IRC | 17:21 | |
*** k_mouza has quit IRC | 17:24 | |
*** mkrai has quit IRC | 17:24 | |
dtantsur | I think many of you will like this ^^^ | 17:28 |
dtantsur | on this positive note I'm wishing y'all a great weekend! | 17:33 |
*** dtantsur is now known as dtantsur|afk | 17:33 | |
*** ntt has joined #openstack-ironic | 17:36 | |
ntt | Hi guys, I'm tring tu do "openstack overcloud node introspect --provide compute2" but I have an error at the end of the process: http://paste.openstack.org/show/796498/ ... please, can you give me some hint about this? Thank you | 17:37 |
*** gyee has joined #openstack-ironic | 17:45 | |
*** k_mouza has joined #openstack-ironic | 17:56 | |
*** livelace has quit IRC | 18:01 | |
*** k_mouza has quit IRC | 18:01 | |
openstackgerrit | Merged openstack/ironic-python-agent master: set EVENTLET_NO_GREENDNS to 'yes' https://review.opendev.org/742011 | 18:27 |
*** ntt has quit IRC | 18:36 | |
*** livelace has joined #openstack-ironic | 18:59 | |
*** k_mouza has joined #openstack-ironic | 19:03 | |
*** k_mouza has quit IRC | 19:08 | |
sdanni | I tried to build centos 7 ramdisk image with stable/train ipa by setting DIB_REPOREF_ironic_python_agent and DIB_REPOREF_requirements to be stable/train, and built with diskimage-builder. Still having error. Any hint for it? | 19:11 |
*** tzumainn has quit IRC | 19:44 | |
*** livelace has quit IRC | 19:46 | |
*** tzumainn has joined #openstack-ironic | 19:59 | |
*** Zempashi has joined #openstack-ironic | 20:23 | |
dhellmann | TheJulia, iurygregory : regarding the conversation we had a few weeks ago about setting the boot_mode under /properties/capabilities, I'm back to a point where I need to make that change and patching /properties/capabilities with a dict gives me an error: 'dict' object has no attribute 'split'; Unexpected exception, traceback saved into log by ironic conductor service | 20:42 |
dhellmann | so I think I need to patch it with something else? | 20:42 |
dhellmann | https://github.com/metal3-io/baremetal-operator/pull/612 is what I'm trying to do | 20:44 |
iurygregory | dhellmann, Julia is on PTO today, openstack baremetal node set --property capabilities="boot_mode:uefi" <node_uuid_name> | 20:46 |
* iurygregory looks | 20:46 | |
dhellmann | iurygregory : I need to know how to do this through the API in Go | 20:46 |
dhellmann | so I can't use ironic client or the CLI :-( | 20:46 |
iurygregory | gotcha | 20:47 |
dhellmann | that PR tries to assemble a patch using a dict, as you suggested the last time we talked but the API doesn't seem to like receiving a di t | 20:47 |
dhellmann | so I'm trying a string now but I think when I did that before it erased the capabilities from inspection | 20:48 |
iurygregory | humm | 20:48 |
clarkb | https://docs.openstack.org/api-ref/baremetal/?expanded=update-node-detail shows a list of dicts | 20:48 |
clarkb | which it appears you've got in your PR | 20:49 |
clarkb | dhellmann: I'm guessing boot_mode:uefi should be sent as a string and the split is on the : ? | 20:50 |
dhellmann | if I send only that, then it erases the other capabilities | 20:50 |
dhellmann | so I guess I have to build the full capabilities string myself? | 20:50 |
*** tzumainn has quit IRC | 20:51 | |
iurygregory | maybe because the operation is replace (but it should only replace the filed you are sending) | 20:51 |
clarkb | dhellmann: change replace t oadd? | 20:51 |
* iurygregory was thinking that | 20:51 | |
iurygregory | add normally you only use if the field is not present no? | 20:52 |
dhellmann | this is what I get: http://paste.openstack.org/show/796506/ | 20:52 |
clarkb | iurygregory: I'm reading jsonpatch now | 20:53 |
dhellmann | well apparently there's no way to set the boot mode for inspection except by using that field | 20:53 |
clarkb | iurygregory: and I think you are right | 20:53 |
clarkb | add wants to create a new node entirely. replace will replace it entirely | 20:53 |
clarkb | dhellmann: so ya I think you need to fetch the value, append to it locally then send the replace op | 20:54 |
dhellmann | ok | 20:54 |
iurygregory | ouch =X | 20:54 |
clarkb | http://jsonpatch.com/#operations fwiw | 20:54 |
*** Zempashi has quit IRC | 21:00 | |
jroll | dhellmann | so I can't use ironic client or the CLI :-( <- FWIW, the CLI is always my goto when I can't figure out the API. --debug printing curl equivalents ftw | 21:03 |
clarkb | also looks like there are a few golang jsonpatch libs that may simplify that for you | 21:04 |
* iurygregory takes note about what jroll said =) | 21:19 | |
dhellmann | I've got a ton of code built around gophercloud, so I'd rather not have to switch clients. | 21:26 |
dhellmann | dumping curl commands via the cli may help | 21:26 |
clarkb | dhellmann: I don't think it would require you to change cleints, they construct the ops list for the jsonpatch | 21:32 |
dhellmann | ok, you mentioned other patch libraries | 21:33 |
clarkb | I mean its still possible they would be at odds with each other, I don't know | 21:33 |
dhellmann | fwiw, that command line invocation also replaces the entire capabilities string | 21:35 |
dhellmann | so I've got some code now that munges the existing string and that seems to work | 21:35 |
*** k_mouza has joined #openstack-ironic | 21:36 | |
dhellmann | it's a bit janky but it works https://github.com/metal3-io/baremetal-operator/pull/612/files#diff-c3f8fb66d64901a306b6faf6f7019c9fR816 | 21:38 |
*** k_mouza has quit IRC | 21:41 | |
*** beekneemech is now known as bnemec-pto | 21:48 | |
*** sdanni has quit IRC | 21:55 | |
*** rloo has quit IRC | 22:16 | |
*** k_mouza has joined #openstack-ironic | 23:11 | |
*** k_mouza has quit IRC | 23:16 | |
*** diurnalist has quit IRC | 23:30 | |
*** k_mouza has joined #openstack-ironic | 23:30 | |
*** k_mouza has quit IRC | 23:35 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!