openstackgerrit | Yushiro FURUKAWA proposed openstack/ironic master: Support iRMC hardware type again https://review.opendev.org/752587 | 00:08 |
---|---|---|
*** ricolin has quit IRC | 00:22 | |
*** dsneddon has quit IRC | 00:31 | |
*** Qianbiao has quit IRC | 00:54 | |
*** gyee has quit IRC | 01:03 | |
*** dsneddon has joined #openstack-ironic | 01:08 | |
*** VisBits has joined #openstack-ironic | 01:15 | |
*** mushrushu_ has joined #openstack-ironic | 01:17 | |
*** VisBits_ has quit IRC | 01:19 | |
*** mushrushu has quit IRC | 01:19 | |
*** mushrushu_ is now known as mushrushu | 01:19 | |
*** zzzeek has quit IRC | 01:21 | |
*** zzzeek has joined #openstack-ironic | 01:22 | |
*** rloo has quit IRC | 01:26 | |
*** gregwork has quit IRC | 01:27 | |
*** Qianbiao has joined #openstack-ironic | 01:41 | |
*** dsneddon has quit IRC | 01:44 | |
*** dsneddon has joined #openstack-ironic | 01:46 | |
*** rcernin has quit IRC | 02:29 | |
*** vmud213 has joined #openstack-ironic | 02:49 | |
*** zzzeek has quit IRC | 02:54 | |
*** zzzeek has joined #openstack-ironic | 02:54 | |
*** zzzeek has quit IRC | 03:01 | |
*** zzzeek has joined #openstack-ironic | 03:04 | |
*** rcernin has joined #openstack-ironic | 03:15 | |
*** Qianbiao has quit IRC | 03:15 | |
*** Qianbiao has joined #openstack-ironic | 03:15 | |
*** rh-jelabarre has quit IRC | 03:20 | |
*** ricolin has joined #openstack-ironic | 03:23 | |
*** mkrai has joined #openstack-ironic | 03:25 | |
*** VisBits_ has joined #openstack-ironic | 03:39 | |
*** ricolin_ has joined #openstack-ironic | 03:42 | |
*** VisBits has quit IRC | 03:42 | |
*** Qianbiao has quit IRC | 04:06 | |
*** mkrai has quit IRC | 04:06 | |
*** mkrai_ has joined #openstack-ironic | 04:06 | |
*** VisBits has joined #openstack-ironic | 04:06 | |
openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Fix redfish BIOS to use @Redfish.SettingsApplyTime https://review.opendev.org/752614 | 04:08 |
*** VisBits_ has quit IRC | 04:09 | |
*** ianychoi has quit IRC | 04:29 | |
*** mkrai_ has quit IRC | 04:32 | |
*** mkrai has joined #openstack-ironic | 04:34 | |
*** Qianbiao has joined #openstack-ironic | 04:41 | |
*** tzumainn has quit IRC | 04:45 | |
*** mkrai has quit IRC | 04:50 | |
*** mkrai_ has joined #openstack-ironic | 04:50 | |
openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Add Redfish BIOS interface to idrac HW type https://review.opendev.org/749240 | 05:14 |
*** zzzeek has quit IRC | 05:19 | |
*** zzzeek has joined #openstack-ironic | 05:19 | |
*** Qianbiao has quit IRC | 05:22 | |
openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Add Redfish BIOS interface to idrac HW type https://review.opendev.org/749240 | 05:22 |
openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Add Redfish BIOS interface to idrac HW type https://review.opendev.org/749240 | 05:23 |
*** vmud213 has quit IRC | 05:28 | |
*** vmud213 has joined #openstack-ironic | 05:31 | |
arne_wiebalck | Good morning, ironic! | 05:50 |
*** Qianbiao has joined #openstack-ironic | 06:25 | |
*** mkrai_ has quit IRC | 06:40 | |
*** mkrai_ has joined #openstack-ironic | 06:40 | |
vmud213 | Good morning Ironic, arne_wiebalck | 06:40 |
arne_wiebalck | Good morning vmud213 o/ | 06:41 |
iurygregory | good morning arne_wiebalck vmud213 and Ironic! happy friday | 06:44 |
arne_wiebalck | hey iurygregory o/ | 06:45 |
vmud213 | Good morning iurygregory o/ | 06:45 |
iurygregory | o/ | 06:45 |
iurygregory | o/ | 06:45 |
*** jawad_axd has joined #openstack-ironic | 06:45 | |
* iurygregory grabs coffee | 06:46 | |
*** rajinir has quit IRC | 06:49 | |
*** rajinir has joined #openstack-ironic | 06:52 | |
*** portdirect has quit IRC | 06:53 | |
*** seongsoocho has quit IRC | 06:53 | |
*** guilhermesp has quit IRC | 06:53 | |
*** andrein has quit IRC | 06:53 | |
*** phrobb has quit IRC | 06:53 | |
*** johnsom has quit IRC | 06:53 | |
*** vdrok has quit IRC | 06:53 | |
*** rpittau|afk has quit IRC | 06:53 | |
*** pas-ha has quit IRC | 06:53 | |
*** donnyd has quit IRC | 06:53 | |
*** sri_ has quit IRC | 06:53 | |
*** buhman has quit IRC | 06:53 | |
*** TheJulia has quit IRC | 06:53 | |
*** ildikov has quit IRC | 06:53 | |
*** andrein has joined #openstack-ironic | 06:55 | |
*** phrobb has joined #openstack-ironic | 06:55 | |
*** vdrok has joined #openstack-ironic | 06:56 | |
*** ildikov has joined #openstack-ironic | 06:56 | |
*** portdirect has joined #openstack-ironic | 06:56 | |
*** seongsoocho has joined #openstack-ironic | 06:56 | |
*** guilhermesp has joined #openstack-ironic | 06:56 | |
*** rpittau|afk has joined #openstack-ironic | 06:56 | |
*** TheJulia has joined #openstack-ironic | 06:57 | |
*** donnyd has joined #openstack-ironic | 06:57 | |
*** johnsom has joined #openstack-ironic | 06:57 | |
*** buhman has joined #openstack-ironic | 06:58 | |
*** sri_ has joined #openstack-ironic | 06:58 | |
*** mkrai_ has quit IRC | 07:06 | |
iurygregory | arne_wiebalck, if you have a minute today https://review.opendev.org/#/c/705030/ we need to merge this change of the community goal o/ | 07:08 |
patchbot | patch 705030 - ironic - Native zuulv3 grenade multinode multitenant - 35 patch sets | 07:08 |
*** pas-ha has joined #openstack-ironic | 07:09 | |
openstackgerrit | zhen proposed openstack/ironic stable/ussuri: Allow configuring IPMI cipher suite https://review.opendev.org/752633 | 07:10 |
iurygregory | I don't remember an agreement that we can backport this... O.o | 07:11 |
*** derekh has joined #openstack-ironic | 07:20 | |
*** tosky has joined #openstack-ironic | 07:25 | |
*** tremble has joined #openstack-ironic | 07:27 | |
arne_wiebalck | I'd think strictly speaking this is a feature. But given that upgrading ipmitool may leave you with no access to your nodes, this may warrant an exception. There was no decision on this yet, from what I saw. | 07:37 |
*** ociuhandu has joined #openstack-ironic | 07:45 | |
iurygregory | arne_wiebalck, yup! | 07:46 |
*** lucasagomes has joined #openstack-ironic | 08:14 | |
*** ricolin_ has quit IRC | 08:22 | |
*** dtantsur|afk is now known as dtantsur | 08:27 | |
dtantsur | morning ironic | 08:28 |
iurygregory | morning dtantsur o/ | 08:29 |
*** Qianbiao has quit IRC | 08:30 | |
* dtantsur has learned that bifrost downgrade does not work :) | 08:30 | |
dtantsur | janders: hey, please let me know if https://review.opendev.org/#/c/752411/ fixed you deploy-dynamic struggles | 08:31 |
patchbot | patch 752411 - bifrost - Gather facts on localhost before running {enroll,d... - 1 patch set | 08:31 |
janders | good morning Ironic o/ | 08:34 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Gather facts on localhost before running {enroll,deploy}-dynamic https://review.opendev.org/752411 | 08:38 |
*** k_mouza has joined #openstack-ironic | 08:41 | |
*** Qianbiao has joined #openstack-ironic | 08:42 | |
*** derekh has quit IRC | 08:55 | |
*** mkrai has joined #openstack-ironic | 09:01 | |
*** k_mouza has quit IRC | 09:04 | |
*** k_mouza has joined #openstack-ironic | 09:12 | |
*** k_mouza has quit IRC | 09:16 | |
*** k_mouza has joined #openstack-ironic | 09:18 | |
*** derekh has joined #openstack-ironic | 09:26 | |
*** dking has quit IRC | 09:28 | |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Fix internal_ip detection in {enroll,deploy}-dynamic https://review.opendev.org/752411 | 09:51 |
dtantsur | janders: try this please ^^ | 09:51 |
*** uzumaki has joined #openstack-ironic | 09:51 | |
*** vmud213 has quit IRC | 09:54 | |
*** rcernin has quit IRC | 10:09 | |
janders | ACK, on it | 10:13 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: bifrost-cli: do not provide any release if non can be detected https://review.opendev.org/752658 | 10:14 |
janders | dtantsur success! ( http://paste.openstack.org/show/798057/ ) | 10:16 |
janders | nicely done | 10:16 |
dtantsur | cool, thanks for testing. now let's hope the CI agrees :) | 10:16 |
janders | on that positive note - have a great weekend everyone! | 10:20 |
janders | See you next week Ironic o/ | 10:20 |
dtantsur | o/ | 10:20 |
iurygregory | bye janders enjoy the weekend o/ | 10:23 |
*** mkrai has quit IRC | 10:34 | |
*** mkrai_ has joined #openstack-ironic | 10:34 | |
* dtantsur is impressed that test-bifrost.sh simply does not work on stable/ussuri outside of the CI, and nobody has complained | 10:39 | |
dtantsur | speaking of which, could I get some reviews on https://review.opendev.org/#/c/752473/ please? | 10:40 |
patchbot | patch 752473 - bifrost - Ensure that repositories are owned by the running ... - 2 patch sets | 10:40 |
iurygregory | dtantsur, I will look after lunch | 10:40 |
dtantsur | thx | 10:40 |
*** rcernin has joined #openstack-ironic | 10:44 | |
*** rcernin has quit IRC | 10:54 | |
Qianbiao | hello ironic. | 11:10 |
Qianbiao | hi, if i put inspect dhcp on an isolate vlan. | 11:10 |
Qianbiao | then how inspect IPA communicate with ironic-inspector | 11:10 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: bifrost-configdrives-dynamic: automatically find ed25519 SSH keys https://review.opendev.org/752673 | 11:15 |
*** rcernin has joined #openstack-ironic | 11:18 | |
*** rcernin has quit IRC | 11:23 | |
*** k_mouza has quit IRC | 11:45 | |
*** rh-jelabarre has joined #openstack-ironic | 11:46 | |
openstackgerrit | Verification of a change to openstack/ironic failed: Handle an older agent with agent_token https://review.opendev.org/749585 | 11:47 |
*** k_mouza has joined #openstack-ironic | 11:51 | |
*** rcernin has joined #openstack-ironic | 11:54 | |
openstackgerrit | Merged openstack/metalsmith master: Rework jobs so failed devstack does not retry the job https://review.opendev.org/749758 | 11:55 |
openstackgerrit | Merged openstack/metalsmith master: Change metalsmith nodeset to Focal https://review.opendev.org/750489 | 11:55 |
*** k_mouza has quit IRC | 11:55 | |
*** dking has joined #openstack-ironic | 11:56 | |
*** k_mouza has joined #openstack-ironic | 11:58 | |
*** rcernin has quit IRC | 11:59 | |
*** ricolin_ has joined #openstack-ironic | 12:02 | |
openstackgerrit | Dmitry Tantsur proposed openstack/metalsmith stable/victoria: Rework jobs so failed devstack does not retry the job https://review.opendev.org/752680 | 12:27 |
*** fgofurov_ has joined #openstack-ironic | 12:30 | |
dtantsur | Could someone please request releases for IPA-builder and virtualbmc? | 12:35 |
*** k_mouza_ has joined #openstack-ironic | 12:40 | |
*** k_mouza has quit IRC | 12:42 | |
*** Goneri has joined #openstack-ironic | 12:42 | |
iurygregory | dtantsur, sure! | 12:44 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: [PoC] A naive attempt at creating an upgrade job https://review.opendev.org/750376 | 12:46 |
openstackgerrit | Verification of a change to openstack/ironic failed: Do not assume that prepare_image is the last command to run https://review.opendev.org/749913 | 12:47 |
dtantsur | the upgrade job works locally but fails in the CI. computers were clearly a mistake. | 12:48 |
*** VisBits has quit IRC | 12:52 | |
*** VisBits has joined #openstack-ironic | 12:54 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Deprecate the iscsi deploy interface https://review.opendev.org/750204 | 12:57 |
iurygregory | you were trying in a fresh env? | 13:06 |
*** nam-est has joined #openstack-ironic | 13:09 | |
*** cdearborn has joined #openstack-ironic | 13:11 | |
dtantsur | iurygregory: yep, a new VM | 13:15 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Deprecate the iscsi deploy interface https://review.opendev.org/750204 | 13:16 |
*** k_mouza_ has quit IRC | 13:18 | |
*** tosky_ has joined #openstack-ironic | 13:18 | |
*** tosky is now known as Guest83047 | 13:18 | |
*** tosky_ is now known as tosky | 13:18 | |
iurygregory | dtantsur, damm =( | 13:20 |
*** k_mouza has joined #openstack-ironic | 13:22 | |
*** uzumaki has quit IRC | 13:23 | |
nam-est | Hi all, I have one question | 13:24 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: [PoC] A naive attempt at creating an upgrade job https://review.opendev.org/750376 | 13:25 |
nam-est | Does any know which commits created the version 15.1.1.dev16 of Ironic? | 13:26 |
dtantsur | nam-est: the versions that pbr generate are not exactly trivial to understand. this is the 16th commit after 15.1.0. | 13:26 |
nam-est | What is pbr? Sorry for my ignorance | 13:27 |
dtantsur | nam-est: pbr is a library that we (as the whole openstack) use to manage our python packages | 13:27 |
dtantsur | it handles some boilerplate tasks that distutils don't handle, like generating versions from git tags | 13:28 |
nam-est | dtantsur: I see.thanks for your answer and explanation | 13:29 |
dtantsur | nam-est: if you have a system with the ironic package installed, `pbr sha ironic` will tell you the git hash | 13:30 |
dtantsur | info even better. e.g. on my in-progress patch it outputs `ironic 15.2.1.dev94 pre-release 98426f00b` | 13:30 |
dtantsur | (I mean, `pbr info ironic`) | 13:30 |
TheJulia | good morning | 13:31 |
iurygregory | good morning TheJulia =) | 13:31 |
TheJulia | Sorry about being missing yesterday, sometimes stuff happens and takes far longer to get a replacement found and the work started to have the failed item replaced | 13:31 |
dtantsur | morning TheJulia, happy Monday | 13:31 |
TheJulia | wait, this is monday?!? | 13:31 |
iurygregory | happy what dtantsur ?! | 13:32 |
dtantsur | oh lol | 13:32 |
TheJulia | NOOOOOOO!!!!!! | 13:32 |
iurygregory | NOOOOOOOOO [2] | 13:32 |
dtantsur | well, you now know my state :) | 13:32 |
dtantsur | yeah, happy Friday all | 13:32 |
* dtantsur probably needs another week in the mountains | 13:32 | |
iurygregory | dtantsur, I think you need to finish work early today... | 13:32 |
TheJulia | dtantsur: ++ | 13:32 |
dtantsur | see? iurygregory permitted! | 13:32 |
TheJulia | So what did I miss yesterday? | 13:32 |
* dtantsur tries to remember yesterday | 13:32 | |
iurygregory | dtantsur, I'm not shadower ... | 13:33 |
iurygregory | but I think he will agree XD | 13:33 |
dtantsur | heh | 13:33 |
dtantsur | TheJulia: I remember cursing ansible and having some meetings | 13:34 |
dtantsur | that's all my memory holds | 13:34 |
TheJulia | memory overwise overflowed and yeah | 13:34 |
TheJulia | and then you lost the word for cat or something | 13:34 |
TheJulia | becaues overflow | 13:34 |
nam-est | dtantsur: Found it. `pbr sha ironic` is very userful. It is the commit 079b22a80. Thank you very much, dtantsur | 13:35 |
dtantsur | you're welcome | 13:35 |
openstackgerrit | Verification of a change to openstack/ironic-inspector failed: Power off before inspection https://review.opendev.org/749845 | 13:35 |
dtantsur | sigh | 13:36 |
iurygregory | it's friday and zuul is off already | 13:36 |
dtantsur | the inspector and IPA CIs are very unstable, ironic ussuri is pretty much dead | 13:36 |
TheJulia | are we in the typical end of cycle CI hates us period? | 13:36 |
iurygregory | yes | 13:36 |
dtantsur | ironic (master) and bifrost seem to behave | 13:36 |
iurygregory | because we are close to release | 13:36 |
iurygregory | =D | 13:37 |
TheJulia | is it just timeoutes? | 13:37 |
TheJulia | timeouts | 13:37 |
dtantsur | haven't looked at ussuri | 13:37 |
dtantsur | IPA was, I think, DIB images taking really long to run | 13:37 |
shadower | iurygregory, dtantsur: I'm not sure it's my place to jump in here as a non-contributor but yes, Fridays are for leaving early and having a good weekend \o/ | 13:37 |
dtantsur | inspector - our favourite non-standalone job | 13:37 |
dtantsur | shadower: thanks :) | 13:37 |
*** rloo has joined #openstack-ironic | 13:37 | |
TheJulia | I've seen some tox docs jobs have been observed as timing out recently | 13:37 |
TheJulia | there has been a whole discussion on it | 13:37 |
dtantsur | and by the way, everyone is welcome here, as long as you behave (better than zuul) | 13:37 |
TheJulia | shadower: ++++ | 13:37 |
shadower | lol | 13:37 |
TheJulia | dtantsur: ++++ | 13:38 |
dtantsur | TheJulia: I could use your input on this ansible mind-love: https://review.opendev.org/#/c/752411/ | 13:38 |
patchbot | patch 752411 - bifrost - Fix internal_ip detection in {enroll,deploy}-dynamic - 3 patch sets | 13:38 |
dtantsur | it fixes the problems janders had, but my ansible-fu is still not perfect | 13:38 |
TheJulia | dtantsur: still in my email and sipping coffee, give me about 20 minutes and I should be able to context switch | 13:39 |
dtantsur | enjoy your coffee | 13:39 |
dtantsur | speaking of which, we've got pumpkin-spice syrup, I should give it a go :) | 13:39 |
TheJulia | the iRMC folks emailed me worried we would remove their driver and stated that they almost have CI back up | 13:39 |
TheJulia | ohhhh ahhh | 13:39 |
TheJulia | I told them not to stress and to stay safe and that we understood delays right now due to the pandemic. | 13:40 |
dtantsur | I guess they have further delays.. I remember having a conversation with one contributor a week or two ago | 13:40 |
*** k_mouza has quit IRC | 13:40 | |
TheJulia | yeah | 13:40 |
TheJulia | Getting things "done" is interesting | 13:41 |
dtantsur | rewrite it in go \o/ | 13:41 |
* dtantsur ducks | 13:41 | |
TheJulia | like... parts to repair my car have a weird availability so I actually selected different parts entirely because of new delays | 13:41 |
TheJulia | Did tyler and his ports with pxe options appear in IRC yesterday? | 13:43 |
dtantsur | I don't recall that, but, as I mentioned, my memory is not to be trusted | 13:44 |
TheJulia | k | 13:44 |
dtantsur | if anybody has free cycles (haha), we should probably update bifrost to use Focal as the primary nodeset for jobs, leaving Bionic in a non-voting job | 13:47 |
derekh | Using the standalone client, shouldn't I be able to add multiple --driver-info ? or am I doing something wrong? http://paste.openstack.org/show/798069/ | 13:50 |
*** Qianbiao has quit IRC | 13:50 | |
iurygregory | derekh, it's a bit wrong | 13:50 |
iurygregory | --driver-info redfish_username=admin,redfish_password=pass test | 13:50 |
*** k_mouza has joined #openstack-ironic | 13:50 | |
iurygregory | try like this to see how it goes | 13:51 |
derekh | iurygregory: ahhh, gotcha, thanks | 13:51 |
*** k_mouza has quit IRC | 13:55 | |
*** rcernin has joined #openstack-ironic | 13:55 | |
derekh | hmm, that doesn't look right | 13:56 |
derekh | | driver_info | {'redfish_username': 'admin,redfish_password=******'} | | 13:56 |
*** fmuyassarov has joined #openstack-ironic | 13:56 | |
TheJulia | no, that doesn't look right | 13:59 |
*** rcernin has quit IRC | 14:00 | |
iurygregory | --driver-info <key=value> | 14:01 |
iurygregory | Key/value pair used by the driver, such as out-of-band management credentials. Can be specified multiple times. (the way you were doing before seems correct after reading this) | 14:01 |
*** k_mouza has joined #openstack-ironic | 14:02 | |
derekh | looks like the same problem came up in other clients in the passed https://review.opendev.org/#/c/459115/1 | 14:02 |
patchbot | patch 459115 - os-client-config - Make _fix_argv() somewhat compatible with Argparse... (MERGED) - 1 patch set | 14:02 |
iurygregory | if you are doing a request with post is a single dict with multiple key/value | 14:02 |
dtantsur | I've fixed it in openstacksdk recently | 14:04 |
dtantsur | but maybe it hasn't been released yet? | 14:04 |
derekh | dtantsur: this https://review.opendev.org/#/c/749903/ , checking if I have it | 14:05 |
patchbot | patch 749903 - openstacksdk - Fix a bogus error in config loader when using seve... (MERGED) - 1 patch set | 14:05 |
iurygregory | derekh, in CI logs I see we use like the first case you mentioned | 14:06 |
TheJulia | dtantsur: regarding the gather facts change. Did ansible stop the auto collection for localhost? | 14:06 |
iurygregory | https://zuul.opendev.org/t/openstack/build/e287ae5d46274d508b306b79cf90de27/log/job-output.txt --driver-info ipmi_address=10.176.193.84 --driver-info ipmi_username=admin --driver-info ipmi_password=password --driver-info ipmi_port=6230 | 14:06 |
dtantsur | TheJulia: not sure, honestly | 14:06 |
TheJulia | but you added it and things are now happier, I guess I'm trying to understand why things were not just working to begin with | 14:07 |
derekh | dtantsur: thanks, that was it https://review.opendev.org/#/c/749903/ <-- iurygregory | 14:09 |
patchbot | patch 749903 - openstacksdk - Fix a bogus error in config loader when using seve... (MERGED) - 1 patch set | 14:09 |
iurygregory | aha =) | 14:09 |
dtantsur | TheJulia: to be clear, I'm not sure which part of the patch is more important | 14:10 |
TheJulia | dtantsur: so did some tablescans in my brain | 14:14 |
TheJulia | it was default to always collect a long time ago | 14:14 |
TheJulia | at some point that changd so depending on how you invoked the run resulted in if facts got collected | 14:14 |
TheJulia | so I've +2'ed the change, I think it is good to land. | 14:14 |
dtantsur | at least it shouldn't hurt | 14:16 |
openstackgerrit | Julia Kreger proposed openstack/ironic stable/ussuri: Allow configuring IPMI cipher suite https://review.opendev.org/752633 | 14:22 |
TheJulia | dtantsur: ^^^ | 14:22 |
dtantsur | TheJulia: I wonder if we should add an 'issues' section to the release note, reflecting what ttx and I discussed this morning | 14:22 |
dtantsur | (see #openstack-release if you haven't already) | 14:22 |
TheJulia | I have not... | 14:23 |
*** trandles has quit IRC | 14:25 | |
TheJulia | The TC has already taken the stand that it is acceptable to backport "gray" area items of this nature to support operators. I think you basically rehashed the same discussion | 14:25 |
TheJulia | issues may make sense to go ahead and note in case they go "this looks like a feature!" | 14:26 |
TheJulia | and decide to be unreasonable | 14:26 |
dtantsur | TheJulia: yep, what I'd like to propose is a release note update to make it clear how this feature can be usable as a bug fix | 14:27 |
dtantsur | (and to warn the operators about the potential problem) | 14:27 |
TheJulia | so I already partially augmented, I can just add an issues item to provide additional background context | 14:28 |
dtantsur | ++ | 14:28 |
dtantsur | bloody upgrade jobs, what's wrong with you? | 14:28 |
iurygregory | dtantsur, ipa-builder 2.2.0 patch up (I've pushed 2.2.0 becasue we added the TLS support) | 14:29 |
dtantsur | yep, thx | 14:29 |
iurygregory | looking at vbmc now | 14:29 |
*** mkrai_ has quit IRC | 14:34 | |
openstackgerrit | Julia Kreger proposed openstack/ironic stable/ussuri: Allow configuring IPMI cipher suite https://review.opendev.org/752633 | 14:34 |
TheJulia | dtantsur: ^^^ | 14:34 |
dtantsur | thx, will look after another pathetic attempt to make the upgrade job work.. | 14:35 |
TheJulia | :( | 14:35 |
iurygregory | not much on virtualbmc, most updates on l-c docs so I've pushed 2.1.1 | 14:35 |
TheJulia | could be worse, I figured out why centos8 change for metalsmith was breaking | 14:35 |
iurygregory | TheJulia, I think someone already pushed a backport for it ... | 14:36 |
iurygregory | oh ok it was an update =) | 14:36 |
TheJulia | os-prober apparently goes on a vacation searching for disks and chewing up CPU resources | 14:36 |
*** mkrai has joined #openstack-ironic | 14:36 | |
TheJulia | and people have reported fedora 30/31 bugs indicating it can spin for 15-20+ minutes | 14:37 |
dtantsur | lovely | 14:37 |
TheJulia | yeah | 14:37 |
dtantsur | and in the upgrade jobs upgrade happens, but for some reason ironic starts with old code | 14:38 |
dtantsur | I couldn't reproduced it locally | 14:38 |
*** fmuyassarov has quit IRC | 14:38 | |
TheJulia | I put up a wip change on ipa to give that a try.... I'm not entirely sure that is a "good idea" though since the grub option to use doesn't seem documented | 14:38 |
*** Qianbiao has joined #openstack-ironic | 14:43 | |
Qianbiao | Hello,ironic. | 14:45 |
TheJulia | good morning | 14:45 |
Qianbiao | hi, when i move inspect network to a special vlan. | 14:45 |
Qianbiao | ipxe could not startup. it keeps using pxe. | 14:45 |
Qianbiao | any idea? | 14:45 |
Qianbiao | http://paste.openstack.org/show/798073/ | 14:46 |
Qianbiao | when move inspect dhcp to normal network without vlan, it can ipxe. | 14:46 |
TheJulia | looks like your chain loading is failing to work into ipxe | 14:46 |
TheJulia | I suspect your return tftp packet is not making it past any firewalling | 14:47 |
TheJulia | are you using ubuntu? | 14:47 |
Qianbiao | yes | 14:47 |
TheJulia | so they did remove the auto-insert of the connection tracker helper for tftp | 14:47 |
TheJulia | if you load the kmod, I think you'll be good | 14:47 |
Qianbiao | yes enable-tftp is not configed. | 14:47 |
Qianbiao | but what concerns me is that when without vlan, it can ipxe | 14:48 |
Qianbiao | when dnsmasq listen to a vlan interface. | 14:48 |
Qianbiao | it can not ipxe | 14:48 |
TheJulia | that doesn't really make sense | 14:50 |
openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Generate a TLS certificate and send it to ironic https://review.opendev.org/749930 | 14:50 |
TheJulia | because the reply is clearly getting through with the instruction to chainload, the undionly.kpxe binary | 14:50 |
TheJulia | it seems tftp is where things are going sideways to load that :\ | 14:50 |
*** Qianbiao has quit IRC | 14:51 | |
openstackgerrit | Julia Kreger proposed openstack/ironic stable/train: Allow configuring IPMI cipher suite https://review.opendev.org/752710 | 14:51 |
*** Qianbiao has joined #openstack-ironic | 14:52 | |
TheJulia | tremble: ^^^ | 14:52 |
dtantsur | TheJulia: do you recall why bifrost uses xinetd rather than built-in dnsmasq tftp? | 14:52 |
TheJulia | xinetd has some logic to guard the back-end binary against abuse | 14:54 |
TheJulia | also I don't think i managed to get the dnsmasq tftp service to behave | 14:55 |
*** fgofurov_ has quit IRC | 14:55 | |
Qianbiao | <TheJulia> ipxe requires tftp too? | 14:55 |
Qianbiao | i thought it directly visit http | 14:56 |
TheJulia | Qianbiao: depends on your Network cards | 14:56 |
TheJulia | Qianbiao: if your network cards HAVE ipxe embedded, they can go direct to HTTP | 14:56 |
Qianbiao | ok i see | 14:56 |
TheJulia | if they don't, they have to load ipxe from tftp | 14:56 |
TheJulia | In that case, you only end up sending ~600kb-1.4MB over tftp instead of hundreds of megabytes | 14:56 |
Qianbiao | got | 14:57 |
Qianbiao | i will try enabled tftp in dnsmasq | 14:57 |
*** ianychoi has joined #openstack-ironic | 14:59 | |
dtantsur | TheJulia: metal3 uses dnsmasq, I think, hence my question | 15:02 |
dtantsur | one less service for bifrost => faster deploy, less complexity | 15:02 |
TheJulia | ahh, yeah I think it is fine to give it a shot with the dnsmasq service | 15:03 |
* dtantsur dives into in-band deploy steps again because https://storyboard.openstack.org/#!/story/2008167 | 15:03 | |
TheJulia | it never changed because it just worked | 15:03 |
*** mkrai has quit IRC | 15:05 | |
*** Qianbiao has quit IRC | 15:05 | |
TheJulia | dtantsur: that seems super familiar to the error I was hitting on checking prepare_image command status when no other prior commands had executed | 15:08 |
dtantsur | well, there is a previous command in this case.. just.. it's considered done too early | 15:09 |
dtantsur | we.. have.. a race.. between.. two calls to RPC continue_node_deploy.... | 15:10 |
* dtantsur doesn't even have energy to flip a table | 15:10 | |
dtantsur | Successfully released exclusive lock for heartbeat on node b5c31dba-759b-4784-9e5e-708bba0ad46c (lock was held 37.81 sec) | 15:15 |
dtantsur | how many??? | 15:15 |
*** mkrai has joined #openstack-ironic | 15:15 | |
dtantsur | ah, iscsi deploy. sure. | 15:16 |
*** Qianbiao has joined #openstack-ironic | 15:17 | |
Qianbiao | Hmm, i found it already has a tftp process. | 15:20 |
Qianbiao | "/usr/sbin/in.tftpd --listen --user tftp --address :69 --secure /var/lib/tftpboot" | 15:20 |
Qianbiao | I do not know who start it, it watches wrong folder seems | 15:20 |
*** mkrai has quit IRC | 15:22 | |
*** mkrai_ has joined #openstack-ironic | 15:22 | |
* tremble thanks TheJulia | 15:29 | |
TheJulia | dtantsur: I guess the lock is retrying when it maybe should retry less or kill itself it is hangs open for too long? | 15:30 |
dtantsur | TheJulia: that's exactly the direction I'm going right now :) | 15:30 |
TheJulia | excellent | 15:32 |
*** trandles has joined #openstack-ironic | 15:33 | |
TheJulia | Good morning tremble | 15:33 |
TheJulia | err | 15:33 |
TheJulia | trandles: | 15:33 |
* TheJulia tries again | 15:33 | |
TheJulia | Good morning trandles | 15:33 |
trandles | good morning TheJulia | 15:33 |
trandles | lol | 15:33 |
trandles | It's Friday, almost there, hold it together ;) | 15:33 |
* tremble bids TheJulia a good afternoon and hopes she has a good weekend. | 15:34 | |
trandles | I rebooted my workstation 2 hours ago and forgot to fire up the IRC client again... | 15:34 |
TheJulia | Wednesday our water heater decided it no longer wanted to be a water heater... Most of thursday was spent cleaning... | 15:34 |
* trandles wonders what else he's forgetting | 15:34 | |
TheJulia | and now we have a wildfire under national forest service command | 15:34 |
TheJulia | so updates are not frequent | 15:34 |
trandles | yikes | 15:34 |
TheJulia | yeah :( | 15:35 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Do not retry locking when heartbeating https://review.opendev.org/752716 | 15:35 |
dtantsur | ^^^ | 15:35 |
dtantsur | ugh, wildfire-- | 15:35 |
TheJulia | We just pulled the cushions in from the courtyard because ash is now falling from the sky. | 15:35 |
trandles | last fall our water heater did the same, still have some minor drywall repair to do in the utility closet | 15:35 |
*** tremble has quit IRC | 15:35 | |
trandles | ok that's stressful | 15:36 |
dtantsur | TheJulia: thinking of it, it doesn't eliminate the race completely | 15:37 |
dtantsur | a heartbeat can still arrive between the previous heartbeat and the continue_node_deploy call it caused | 15:38 |
dtantsur | and the only cure is probably to get rid of the continue_node_deploy RPC... | 15:38 |
dtantsur | which is risky because it's used by drivers.... | 15:39 |
*** tkajinam has quit IRC | 15:44 | |
Qianbiao | TheJulia dtantsur thanks for the hint. | 15:49 |
Qianbiao | it's due to tftp-hpa service is start. | 15:49 |
Qianbiao | and xinetd.d failed to bind port. | 15:49 |
Qianbiao | we should disable tftp-hpa when install | 15:49 |
*** jawad_axd has quit IRC | 15:49 | |
*** ricolin_ has quit IRC | 15:50 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: When reporting that agent is busy, report the executed command https://review.opendev.org/752719 | 15:53 |
*** lucasagomes has quit IRC | 15:54 | |
*** uzumaki has joined #openstack-ironic | 15:55 | |
*** rcernin has joined #openstack-ironic | 15:56 | |
Qianbiao | Hello, TheJulia, the "/dev/ram0" does not exists issue occurs during load inspect ramdisk too now. | 15:56 |
Qianbiao | It 's because the way i build ramdisk is wrong? | 15:57 |
TheJulia | Qianbiao: download and double check hashes of hwat is in glance veruses what you can verify from upstream | 15:57 |
TheJulia | oh, your building your own | 15:57 |
TheJulia | hmmm | 15:57 |
Qianbiao | I did follow diskimage-build doc | 15:57 |
TheJulia | did you use ironic-python-agent-builder? | 15:57 |
Qianbiao | yes | 15:58 |
TheJulia | for your agent ramdisk? | 15:58 |
TheJulia | hmmmmmm | 15:58 |
Qianbiao | I set element path | 15:58 |
TheJulia | that doesn't make sense | 15:58 |
Qianbiao | I need to build it myself. | 15:58 |
Qianbiao | because our node need to support IB port. i need mellanox element to support it. | 15:58 |
TheJulia | and I guess continue_node_deploy is not waiting on a lock or blocked on a lock :\ | 15:59 |
Qianbiao | It's an issue from IPA? | 16:00 |
Qianbiao | TheJulia I built the ramdisk on a ubuntu server, does this matters? | 16:01 |
Qianbiao | And the inspect, it does not allways failed, it success before. | 16:02 |
*** rcernin has quit IRC | 16:03 | |
dtantsur | as promised, bailing out earlier. have a great weekend! | 16:10 |
*** dtantsur is now known as dtantsur|afk | 16:10 | |
*** mkrai_ has quit IRC | 16:19 | |
*** ociuhandu_ has joined #openstack-ironic | 16:23 | |
*** ociuhandu has quit IRC | 16:27 | |
*** ociuhandu_ has quit IRC | 16:28 | |
*** k_mouza has quit IRC | 16:29 | |
rpioso | TheJulia: I refactored the iDRAC Redfish BIOS into two changes. One is a bug fix and the other a new feature. The bug fix _could_ be considered for back porting. | 16:31 |
rpioso | TheJulia: The new feature depends on the bug fix. | 16:32 |
rpioso | TheJulia: Please let me know if that's an agreeable approach. If not, I'll revert. | 16:33 |
*** ociuhandu has joined #openstack-ironic | 16:33 | |
TheJulia | rpioso: that _sounds_ reasonable | 16:33 |
rpioso | bfournie: ^^^ | 16:33 |
rpioso | TheJulia: :-) | 16:33 |
rpioso | TheJulia: agreeable, reasonable, and _merge-able_ ;-) | 16:34 |
* rpioso grabs a meal | 16:35 | |
TheJulia | food sounds like a really good idea | 16:35 |
TheJulia | but also it is only 9:30 am | 16:35 |
TheJulia | Qianbiao: it doesn't seem like an issue with IPA. I guess I'm wondering "what changed" | 16:37 |
*** ociuhandu has quit IRC | 16:37 | |
Qianbiao | TheJulia I do not know where to start now. | 16:38 |
Qianbiao | any hint where i can begin to find out the issue. | 16:38 |
openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent-builder master: Advertise HTTPS in IPA ramdisk without Ironic assist https://review.opendev.org/752728 | 16:38 |
JayF | rloo: ^ Fixes the issue I referenced to you downstream | 16:38 |
TheJulia | the way to get the can't find ramdisk is maybe when the ramdisk uploaded is bad | 16:38 |
TheJulia | content wise or maybe was the wrong file? | 16:38 |
TheJulia | maybe download the file from glance and extrat it? | 16:38 |
TheJulia | extract | 16:39 |
* JayF currently living in the house of TLS-pain | 16:39 | |
Qianbiao | <TheJulia> so, i should start from the image. | 16:40 |
* TheJulia expects someone has a literal house named that | 16:40 | |
Qianbiao | make sure the image is right not broken. | 16:40 |
*** k_mouza has joined #openstack-ironic | 16:40 | |
Qianbiao | ok will try. | 16:40 |
TheJulia | Qianbiao: exactly | 16:40 |
* TheJulia expects only Klingon is spoken in the house of TLS-pain | 16:41 | |
*** k_mouza has quit IRC | 16:44 | |
dking | What are the options available for disk cleaning? Will ATA secure erase be used for all disk types? Is there a way to know what will be run or what has been run? | 16:50 |
JayF | Hey, that's completely configurable. | 16:51 |
*** k_mouza has joined #openstack-ironic | 16:51 | |
JayF | there are two erase "methods" at a high level: erase_device_metadata, which wipes off partition tables, boot loaders and other basic metadata, and generally operates near instantaneously | 16:51 |
dking | Is it configurable using a custom hardware manager, or can it be customized with the generic one? | 16:51 |
JayF | and erase_devices, which uses ATA secure erase if available, or shed if not | 16:52 |
JayF | and you can totally override either or both of those methods with a custom hardware manager | 16:52 |
JayF | it's literally the use case that was originally written for years and years ago :D | 16:52 |
JayF | https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/hardware.py#L679 this is the "generic" erase_devices". If you notice, it calls out to `erase_block_device` for each block device. | 16:53 |
JayF | So you have two choices -- override "erase_devices" and write a method that can erase all devices on system, or override "erase_block_device" and have that erase devices it can support, and raise an unsupported method exception if it can't, so you can build fallbacks, or mix-and-match hardware managers for different hardware | 16:54 |
JayF | the best place to start is here: https://opendev.org/openstack/ironic-python-agent/src/branch/master/examples -- these contain a couple of example custom hardware managers. You probably want to follow the "vendor-device" example, and by just putting either an `erase_devices` or `erase_block_device` method on that hardawre manager, and advertising "higher" than generic for hardware | 16:55 |
JayF | support, IPA will use your method instead | 16:55 |
JayF | this is also pretty well documented here: https://docs.openstack.org/ironic-python-agent/latest/contributor/hardware_managers.html#:~:text=Hardware%20managers%20are%20how%20IPA,methods%20compatible%20with%20most%20hardware. | 16:55 |
*** k_mouza has quit IRC | 16:55 | |
JayF | good luck! | 16:55 |
dking | Thank you very much! | 16:56 |
JayF | no problem; good luck! | 16:57 |
JayF | Happy to help if you hit a wall too, I've been down this road before | 16:57 |
*** Qianbiao has quit IRC | 16:58 | |
*** Qianbiao has joined #openstack-ironic | 17:00 | |
*** derekh has quit IRC | 17:01 | |
*** k_mouza has joined #openstack-ironic | 17:04 | |
JayF | TheJulia: if you have a second, trivial review here: https://review.opendev.org/#/c/752728/ | 17:05 |
patchbot | patch 752728 - ironic-python-agent-builder - Advertise HTTPS in IPA ramdisk without Ironic assist - 1 patch set | 17:05 |
JayF | would save me from having to backport that patch downstream :D | 17:05 |
*** k_mouza has quit IRC | 17:09 | |
*** iurygregory has quit IRC | 17:10 | |
*** k_mouza has joined #openstack-ironic | 17:14 | |
*** k_mouza has quit IRC | 17:19 | |
*** uzumaki has quit IRC | 17:26 | |
*** k_mouza has joined #openstack-ironic | 17:26 | |
*** uzumaki has joined #openstack-ironic | 17:26 | |
*** k_mouza has quit IRC | 17:30 | |
*** k_mouza has joined #openstack-ironic | 17:34 | |
*** gyee has joined #openstack-ironic | 17:35 | |
*** uzumaki has quit IRC | 17:38 | |
*** k_mouza has quit IRC | 17:39 | |
*** uzumaki has joined #openstack-ironic | 17:40 | |
*** k_mouza has joined #openstack-ironic | 17:42 | |
*** k_mouza has quit IRC | 17:47 | |
*** k_mouza has joined #openstack-ironic | 17:50 | |
*** uzumaki has quit IRC | 17:52 | |
*** k_mouza has quit IRC | 17:55 | |
openstackgerrit | Bob Fournier proposed openstack/ironic master: Handle a Redfish error response when turning power off https://review.opendev.org/752582 | 17:57 |
*** jawad_axd has joined #openstack-ironic | 18:11 | |
*** jawad_axd has quit IRC | 18:15 | |
*** irclogbot_0 has quit IRC | 18:19 | |
*** irclogbot_3 has joined #openstack-ironic | 18:23 | |
TheJulia | I think janders is interested in supporting blkdiscard as well, but I think we'll want to do a quick review of the code and mechanics to make sure we don't do anything horribly. I thought of adding trim support a long time ago but it looked just as bad as just zeroing out the device in terms of how long it could/would take :( | 18:24 |
*** irclogbot_3 has quit IRC | 18:31 | |
*** Qianbiao has quit IRC | 18:31 | |
*** jawad_axd has joined #openstack-ironic | 18:32 | |
*** irclogbot_3 has joined #openstack-ironic | 18:35 | |
*** jawad_axd has quit IRC | 18:36 | |
*** k_mouza has joined #openstack-ironic | 18:51 | |
*** jawad_axd has joined #openstack-ironic | 18:52 | |
*** k_mouza has quit IRC | 18:56 | |
*** jawad_axd has quit IRC | 18:56 | |
*** uzumaki has joined #openstack-ironic | 19:02 | |
*** k_mouza has joined #openstack-ironic | 19:21 | |
*** k_mouza has quit IRC | 19:26 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Guard conductor from consuming all of the ram https://review.opendev.org/726483 | 19:29 |
openstackgerrit | Merged openstack/ironic-python-agent-builder master: Advertise HTTPS in IPA ramdisk without Ironic assist https://review.opendev.org/752728 | 19:43 |
openstackgerrit | Merged openstack/bifrost master: Fix internal_ip detection in {enroll,deploy}-dynamic https://review.opendev.org/752411 | 19:43 |
*** k_mouza has joined #openstack-ironic | 19:47 | |
openstackgerrit | Merged openstack/ironic-python-agent-builder master: tinyipa: use python 3 for building on all systems https://review.opendev.org/751769 | 19:49 |
openstackgerrit | Merged openstack/ironic master: Clarify HPE Edgeline support https://review.opendev.org/751881 | 19:50 |
*** k_mouza has quit IRC | 19:51 | |
openstackgerrit | Merged openstack/ironic master: Detail iPXE + LACP troubleshooting information https://review.opendev.org/743787 | 20:05 |
*** zzzeek has quit IRC | 20:06 | |
*** uzumaki has quit IRC | 20:28 | |
*** k_mouza has joined #openstack-ironic | 20:30 | |
*** k_mouza has quit IRC | 20:34 | |
*** zzzeek has joined #openstack-ironic | 20:42 | |
*** zzzeek has quit IRC | 20:48 | |
*** zzzeek has joined #openstack-ironic | 20:54 | |
TheJulia | rpioso: if you could trim down the release note on https://review.opendev.org/#/c/752614/1, it would be much appreciated. I think you have way too much detail in it which results in the reader quickly thinking this is a feature when you look at the code it is more of a bug fix. | 20:57 |
patchbot | patch 752614 - ironic - Fix redfish BIOS to use @Redfish.SettingsApplyTime - 1 patch set | 20:57 |
*** zzzeek has quit IRC | 20:59 | |
*** ociuhandu has joined #openstack-ironic | 21:02 | |
*** zzzeek has joined #openstack-ironic | 21:03 | |
TheJulia | rpioso: also, https://review.opendev.org/#/c/749240's release note needs a little massaging, mostly splitting it down since the feature is one piece of information, the what is functionally a formal declaration of support with information about interface ordering and priorities is secondary to the key fact of the feature (and the audience reading trying to grok the important details). | 21:04 |
patchbot | patch 749240 - ironic - Add Redfish BIOS interface to idrac HW type - 8 patch sets | 21:04 |
*** zzzeek has quit IRC | 21:05 | |
*** zzzeek has joined #openstack-ironic | 21:06 | |
*** ociuhandu has quit IRC | 21:06 | |
rpioso | TheJulia: I'll work on addressing your feedback on https://review.opendev.org/#/c/752614/ now. | 21:07 |
patchbot | patch 752614 - ironic - Fix redfish BIOS to use @Redfish.SettingsApplyTime - 1 patch set | 21:07 |
JayF | TheJulia: I think someone said something about an ipa-builder release for TLS support? If so, you likely want https://review.opendev.org/752728 in that or as a patch release | 21:09 |
patchbot | patch 752728 - ironic-python-agent-builder - Advertise HTTPS in IPA ramdisk without Ironic assist (MERGED) - 1 patch set | 21:09 |
JayF | TheJulia: advise me if I need to backport it, and I will | 21:09 |
TheJulia | JayF: I did not on the highlights | 21:10 |
rpioso | Regarding https://review.opendev.org/#/c/749240's release note, it is modeled after this one: https://review.opendev.org/#/c/681745/3/releasenotes/notes/idrac-add-redfish-inspect-support-ce74bd3d4a97b588.yaml | 21:10 |
patchbot | patch 749240 - ironic - Add Redfish BIOS interface to idrac HW type - 8 patch sets | 21:10 |
patchbot | patch 681745 - ironic - Add Redfish inspect interface to idrac HW type (MERGED) - 3 patch sets | 21:10 |
TheJulia | it is just latest release JayF | 21:11 |
JayF | TheJulia: ack, do you want that backported then or not? I consume ipa-builder directly from git so I don't need it; but if folks are going to consume that support I'd rather them get the more ergonomic version | 21:11 |
TheJulia | JayF: there is no backport branch for ipab | 21:12 |
JayF | ack | 21:12 |
TheJulia | rpioso: hmm, then disregard my second comment I guess | 21:12 |
*** zzzeek has quit IRC | 21:13 | |
*** zzzeek has joined #openstack-ironic | 21:16 | |
*** zzzeek has quit IRC | 21:23 | |
*** zzzeek has joined #openstack-ironic | 21:24 | |
*** rcernin has joined #openstack-ironic | 21:27 | |
openstackgerrit | Verification of a change to openstack/sushy failed: Make message parsing more resilient https://review.opendev.org/748927 | 21:33 |
*** rcernin has quit IRC | 21:35 | |
*** rcernin has joined #openstack-ironic | 21:36 | |
*** Goneri has quit IRC | 21:39 | |
*** rcernin has quit IRC | 21:42 | |
rpioso | TheJulia: Which comment should I disregard, the one about the first paragraph or the one about the second? | 21:44 |
TheJulia | cdearborn: hey! https://review.opendev.org/#/c/749619/17 looking fairly good but it is going to take a monday morning with very strong coffee to go through the management unit tests. One thing, I would <3 an update to the utils to explain the lambda usage since largely it seems bizzar to need it, I feel like I need to understand. | 21:49 |
patchbot | patch 749619 - ironic - Redfish driver firmware update - 17 patch sets | 21:49 |
TheJulia | rpioso: Disregard the comment on the second paragraph | 21:50 |
TheJulia | cdearborn: also, just noticed the patch for which that one is parent. I'm slightly confused by idrac-redfish having a separate patch, maybe the primary reno just needs to be muted or soemthing. Anyway, coffee monday. | 21:51 |
rpioso | TheJulia: +1 re: comment on the 2d paragraph. While I'm very clearly not an English professor (shucks, I placed out of my engineering program's English course requirement and never looked back), I believe the language in the first paragraph is grammatically correct. Just saying. That said, I'm interested in this merging, so ... | 21:53 |
openstackgerrit | Merged openstack/ironic master: Adds ilo-uefi-https boot interface to ilo5 https://review.opendev.org/745501 | 21:53 |
TheJulia | rpioso: it is more about style and information conveyance for the target audience | 21:54 |
TheJulia | like looking at cdearborn's change that I just tagged him on, he is expressing what is being added first and that is the preferred style | 21:55 |
TheJulia | ugh, this reminds me I need to write the prelude soon | 21:55 |
TheJulia | gah! | 21:55 |
rpioso | TheJulia: Have we cut our final release of sushy for Victoria? | 21:56 |
rpioso | 3.4.0 back on September 7? | 21:56 |
TheJulia | <narator style="movie intro">In a world of bare metal provisioning systems, one system...<... | 21:57 |
TheJulia | rpioso: yes. Library release freeze | 21:57 |
cdearborn | TheJulia: yeah, the idrac-redfish patch is kinda weird. The code works fine without it. The main reason for it is that the code that auto generates the cleaning step tables in the docs does not pick up inherited cleaning steps. I assumed this was intended to make the driver explicitly declare support for the cleaning step. | 21:57 |
cdearborn | TheJulia: since there were a fair number of idrac specific changes, i broke it out in a separate patch | 21:58 |
TheJulia | we can bugfix it, but it won't really included in until after the press release and all goes out unless one of the release team folks approves it anyway | 21:58 |
TheJulia | cdearborn: hmm... interesting | 21:59 |
rpioso | TheJulia: Gotcha :-) | 22:00 |
*** rcernin has joined #openstack-ironic | 22:00 | |
TheJulia | rpioso: if we really really really need to get the library updated to 3.4.1 with the fix, add it to the meeting agenda and if nobody screams during the meeting we'll need to do a post to the ml and see if anyone screams | 22:01 |
rpioso | cdearborn: Please remind me, do we really, really need https://review.opendev.org/#/c/748927/ for firmware update? | 22:03 |
patchbot | patch 748927 - sushy - Make message parsing more resilient - 3 patch sets | 22:03 |
cdearborn | rpioso - welllllllll - i would say no, at least not for Dell hardware. i made those changes to get message parsing to work for Dell hardware, but, it turns out that Dell hardware returns already parsed messages in addition to the non-parsed ones. And, it doesn't return any substitution parameters to substitute in. The end result is that the pre-parsed messages are much better messages than the ones we can | 22:09 |
cdearborn | build with the message parsing. As a result, i made the code use the preparsed messages if they are returned by the BMC. So in the end, we don't need that patch for Dell hardware | 22:09 |
TheJulia | sounds like problem solved? | 22:10 |
*** rloo has quit IRC | 22:11 | |
cdearborn | TheJulia, thx for the review! I beefed up the release note based on feedback from Steve Baker. Will trim it down a bit | 22:13 |
TheJulia | cdearborn: much appreciated. I tend to lean toward shorter notes just because of the large quantity of them | 22:13 |
rpioso | cdearborn, TheJulia: Thank you! And, yes, problem solved for now :-) | 22:14 |
openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Add Redfish BIOS interface to idrac HW type https://review.opendev.org/749240 | 22:15 |
rpioso | TheJulia: I modified the first paragraph in the release note to be more like cdearborn's. | 22:16 |
cdearborn | have a great weekend all | 22:19 |
*** cdearborn is now known as cdearborn|afk | 22:20 | |
*** zzzeek has quit IRC | 22:25 | |
*** zzzeek has joined #openstack-ironic | 22:26 | |
*** zzzeek has quit IRC | 22:30 | |
*** zzzeek has joined #openstack-ironic | 22:31 | |
TheJulia | Much appreciated! Have a wonderful weekend everyone! | 22:54 |
openstackgerrit | Verification of a change to openstack/ironic failed: Native zuulv3 grenade multinode multitenant https://review.opendev.org/705030 | 23:00 |
*** rcernin has quit IRC | 23:06 | |
*** zzzeek has quit IRC | 23:08 | |
*** patchbot has quit IRC | 23:10 | |
*** zzzeek has joined #openstack-ironic | 23:11 | |
rpioso | TheJulia: Thank you, and you, too! | 23:13 |
*** zzzeek has quit IRC | 23:16 | |
*** zzzeek has joined #openstack-ironic | 23:17 | |
*** patchbot has joined #openstack-ironic | 23:18 | |
*** tosky has quit IRC | 23:31 | |
*** rcernin has joined #openstack-ironic | 23:39 | |
*** Goneri has joined #openstack-ironic | 23:44 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!