Tuesday, 2020-09-29

TheJuliatrandles: janders: new video link inbound from one of my gmail accounts00:21
TheJuliayou guys should have it in ~2 minutes00:21
openstackgerritwes hayutin proposed openstack/ironic-inspector master: Revert "Power off before inspection"  https://review.opendev.org/75478300:24
TheJuliaweshay|ruck: so yay, because the issue that was actually generated that chagne was another bug because people insist on being able to force reintrospect nodes00:29
TheJuliavia inspector00:29
* TheJulia sighs that tripleo wrote its own ansible modules00:34
*** yolanda has quit IRC00:38
*** yolanda has joined #openstack-ironic00:39
*** Goneri has quit IRC00:39
*** cdearborn has quit IRC00:58
*** gyee has quit IRC01:04
stevebakerTheJulia: depending on the module, it was expedience or the openstack modules really not doing what was required01:13
*** zzzeek has quit IRC01:30
*** zzzeek has joined #openstack-ironic01:34
*** SuiongNg|ITRI_TW has joined #openstack-ironic01:36
*** rh-jelabarre has quit IRC02:09
TheJuliaI guess by required, you meaned kept the behavior inshrined in the simplification of the interaction02:39
TheJuliaMeant02:39
openstackgerritMerged openstack/ironic-inspector master: Revert "Power off before inspection"  https://review.opendev.org/75478302:47
*** zzzeek has quit IRC02:47
*** zzzeek has joined #openstack-ironic02:49
*** JamesBenson has joined #openstack-ironic02:50
*** QianbiaoNG has joined #openstack-ironic02:52
*** rcernin_ has joined #openstack-ironic02:56
*** rcernin has quit IRC02:56
*** rcernin_ has quit IRC03:19
openstackgerritSteve Baker proposed openstack/ironic master: Handle patching node /protected value with None  https://review.opendev.org/75488403:20
*** rcernin_ has joined #openstack-ironic03:20
*** QianbiaoNG has quit IRC03:20
*** QianbiaoNG has joined #openstack-ironic03:21
*** rcernin_ has quit IRC03:37
openstackgerritSteve Baker proposed openstack/ironic master: New argument validate decorator  https://review.opendev.org/74279503:40
openstackgerritSteve Baker proposed openstack/ironic master: Add expose body decorator, status_code argument  https://review.opendev.org/74367703:40
openstackgerritSteve Baker proposed openstack/ironic master: Duplicate trait validation with jsonschema  https://review.opendev.org/74577803:40
openstackgerritSteve Baker proposed openstack/ironic master: Utility functions for REST API JSON handling  https://review.opendev.org/75116003:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert allocations endpoint to plain JSON  https://review.opendev.org/74367903:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert bios endpoint to plain JSON  https://review.opendev.org/74547503:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert chassis endpoint to plain JSON  https://review.opendev.org/74547603:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert conductors endpoint to plain JSON  https://review.opendev.org/74577903:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert deploy_templates endpoint to plain JSON  https://review.opendev.org/74578003:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert drivers endpoint to plain JSON  https://review.opendev.org/74186503:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert event endpoint to plain JSON  https://review.opendev.org/74662303:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert nodes endpoint to plain JSON  https://review.opendev.org/74782003:40
openstackgerritSteve Baker proposed openstack/ironic master: Convert ports endpoint to plain JSON  https://review.opendev.org/75012003:41
openstackgerritSteve Baker proposed openstack/ironic master: Convert portgroups endpoint to plain JSON  https://review.opendev.org/75086403:41
openstackgerritSteve Baker proposed openstack/ironic master: Convert ramdisk endpoint to plain JSON  https://review.opendev.org/75085703:41
openstackgerritSteve Baker proposed openstack/ironic master: Convert volume endpoint to plain JSON  https://review.opendev.org/75085803:41
openstackgerritSteve Baker proposed openstack/ironic master: Convert volume/connectors endpoint to plain JSON  https://review.opendev.org/75085903:41
openstackgerritSteve Baker proposed openstack/ironic master: Convert volume/targets endpoint to plain JSON  https://review.opendev.org/75086003:41
openstackgerritSteve Baker proposed openstack/ironic master: Expunge the internal version of WSME  https://review.opendev.org/75086103:41
*** rcernin_ has joined #openstack-ironic03:42
*** zigo has quit IRC04:38
*** JamesBenson has quit IRC04:55
*** JamesBenson has joined #openstack-ironic04:57
*** JamesBenson has quit IRC05:02
*** abdysn has joined #openstack-ironic05:11
*** tzumainn has quit IRC05:41
*** JamesBenson has joined #openstack-ironic05:53
*** JamesBenson has quit IRC05:57
*** uzumaki has joined #openstack-ironic06:04
arne_wiebalckGood morning, ironic!06:49
SuiongNg|ITRI_TWanyone interested in https://review.opendev.org/754260/ ?06:49
patchbotpatch 754260 - ironic - wipe token on power_on event. - 1 patch set06:49
SuiongNg|ITRI_TWI still have issue with the rescue mode.06:49
SuiongNg|ITRI_TWcurrently, I can prevent the problem by add a check to power on the node before rescue it again. But it would be nice to have it working again.06:51
jandersgood morning arne_wiebalck o/06:57
arne_wiebalckhey janders o/07:04
*** tosky has joined #openstack-ironic07:45
*** JamesBenson has joined #openstack-ironic07:53
maelkHello! I have a question regarding the adoption process. We are deploying with Metal3 from an ephemeral node and move the ironic containers to the target cluster, causing an adoption of the nodes with Ironic running on the target cluster (self-managed). In some cases (namely kube-proxy running in IPVS mode on the node with strict arp enabled) the a07:55
maelkdoption hangs for ever for nodes that were previously deployed while it succeeds for nodes that were not deployed. We can see in the logs in failing cases that the adoption call just returned "none". The nodes then are stuck in adopting and we cannot do anything with them. I was trying to understand the adoption code, but did not see anywhere somet07:55
maelkhing that could cause a return of "none" and cause the adoption process to hang when we would be hitting a networking issue. We are using the IPXE boot driver and both IPMI and Redfish management and power drivers. I would like to understand how the validation steps are differing when the node is deployed or not. Any clues or pointers would be high07:55
maelkly appreciated, thank you!07:55
*** dtantsur|afk is now known as dtantsur07:58
dtantsurmorning ironic07:58
*** JamesBenson has quit IRC07:59
*** lucasagomes has joined #openstack-ironic08:11
openstackgerritVerification of a change to openstack/ironic failed: Redfish driver firmware update  https://review.opendev.org/74961908:29
*** sshnaidm|off is now known as sshnaidm08:33
*** rcernin_ has quit IRC08:38
janders good morning dtantsur08:41
*** ociuhandu has joined #openstack-ironic08:44
*** derekh has joined #openstack-ironic08:44
*** priteau has joined #openstack-ironic08:45
*** mushrushu has quit IRC09:05
*** rcernin_ has joined #openstack-ironic09:07
*** mushrushu has joined #openstack-ironic09:09
*** k_mouza has joined #openstack-ironic09:10
*** rcernin_ has quit IRC09:42
*** JamesBenson has joined #openstack-ironic09:55
*** Abdallahyas has joined #openstack-ironic09:55
*** JamesBenson has quit IRC09:59
*** abdysn has quit IRC09:59
*** k_mouza has quit IRC10:02
*** k_mouza has joined #openstack-ironic10:03
QianbiaoNGHello ironic.10:15
iurygregoryhey QianbiaoNG dtantsur arne_wiebalck janders o/10:35
QianbiaoNGHey iurygregory, welcome back.10:42
dtantsurcould someone check https://review.opendev.org/#/c/754035/ please? it's release-critical10:50
patchbotpatch 754035 - ironic - Update release mappings and API history for 16.0 - 1 patch set10:50
*** k_mouza has quit IRC10:54
*** k_mouza has joined #openstack-ironic10:54
iurygregorynot officially back till tomorrow hehehe (I'm on PTO today, but doing a few things for my session in the OIS) XD10:56
dtantsurack10:59
*** k_mouza has quit IRC10:59
*** k_mouza has joined #openstack-ironic11:00
iurygregorydtantsur, +A11:00
dtantsurthank you!11:00
iurygregoryyw =)11:00
openstackgerritDmitry Tantsur proposed openstack/ironic master: Handle conductor_affinity earlier in the deployment process  https://review.opendev.org/75437511:00
openstackgerritDmitry Tantsur proposed openstack/ironic master: Remove compatibility with conductors that do not support groups  https://review.opendev.org/75441611:07
dtantsurthere are also two important bug fixes to get into the release, could someone not on PTO take a look? https://review.opendev.org/#/c/754362/ and https://review.opendev.org/#/c/754699/11:07
patchbotpatch 754362 - ironic - Fix a race condition in the hash ring code - 9 patch sets11:07
patchbotpatch 754699 - ironic - Do not silently ignore exceptions when running nex... - 2 patch sets11:07
dtantsurboth need 1 more +211:07
*** JamesBenson has joined #openstack-ironic11:09
*** abdysn has joined #openstack-ironic11:15
*** Abdallahyas has quit IRC11:18
iurygregoryI'm ok with https://review.opendev.org/#/c/754699 if there was a story/task =)11:28
patchbotpatch 754699 - ironic - Do not silently ignore exceptions when running nex... - 2 patch sets11:28
dtantsurI can file one later on, I discovered it while debugging CI :)11:30
iurygregoryno worries11:33
ftarasenkoHello, Ironic! Have question for you. How is conductor HA configured? I've shut down one conductor, but other conductors didn't took nodes from failed one. So I get error 500 trying to change state of node that belongs no inactive conductor.11:34
dtantsurftarasenko: what's the exact error you see? I honestly cannot imagine how it could happen..11:35
ftarasenko- I stop one conductor11:36
iurygregoryit takes sometime for the other conductor to take over (I hope you are waitting)11:37
ftarasenko- See that this conductor is not alive running openstack baremetal conductor list11:37
ftarasenko- Get error 500 while trying to make any state change with the node11:37
dtantsurftarasenko: any error text with the error 500?11:38
* dtantsur wonders if it's related to https://review.opendev.org/#/c/754362/11:38
patchbotpatch 754362 - ironic - Fix a race condition in the hash ring code - 9 patch sets11:38
dtantsurftarasenko: shooting in the darkness, really, but maybe ^^^ can help you11:39
*** hjensas_ has joined #openstack-ironic11:40
* ftarasenko openstack baremetal node undeploy $node11:40
* ftarasenko Gateway Timeout (HTTP 504)11:40
ftarasenkoNow have 504 error, let me check log files, maybe I'll find anything.11:41
dtantsurGateway timeout? hmm11:41
dtantsurI don't think ironic itself generates that11:41
iurygregoryin conductor logs you should see that the node is answering for the new conductor I assume11:43
*** hjensas has quit IRC11:43
ftarasenkohttp://paste.openstack.org/show/798514/ - I see message timeout in API log.11:46
dtantsurftarasenko: it starts feeling more like something https://review.opendev.org/754362 could fix11:46
patchbotpatch 754362 - ironic - Fix a race condition in the hash ring code - 9 patch sets11:46
dtantsurassuming that API never learns that the conductor is out11:46
ftarasenkotnx, I'll try to apply this patch and check.11:47
iurygregoryI'm puzzled by "python2.7"11:48
iurygregorythis is train?11:49
*** Goneri has joined #openstack-ironic11:51
ftarasenkoyep. train11:52
*** rh-jelabarre has joined #openstack-ironic11:53
*** rh-jelabarre has quit IRC11:53
*** rh-jelabarre has joined #openstack-ironic11:54
openstackgerritDmitry Tantsur proposed openstack/ironic master: Handle patching node /protected value with None  https://review.opendev.org/75488411:56
*** k_mouza has quit IRC11:58
dtantsurkai12:13
dtantsuroops12:13
openstackgerritMerged openstack/ironic master: Redfish driver firmware update  https://review.opendev.org/74961912:18
*** hjensas_ is now known as hjensas12:18
*** k_mouza has joined #openstack-ironic12:19
* iurygregory thinks dtantsur was trying to search for Cobra Kai on netflix LOL12:24
*** k_mouza has quit IRC12:24
dtantsuriurygregory: like your idea, but I was looking for Kaifeng :)12:24
iurygregoryhehehe12:24
openstackgerritMahendra Kamble proposed x/sushy-oem-idrac master: Add export system configuration  https://review.opendev.org/71032712:25
iurygregoryit has been a long time since I saw kaifeng online =(12:25
QianbiaoNGiurygregory i saw him on weekly meeting last night.12:29
iurygregoryI was out moving things =(12:29
QianbiaoNGChinese National Day is coming, i guess he is on vacation now.12:30
QianbiaoNGif he leaves earier. (10-1~10-8)12:30
iurygregoryI see12:30
QianbiaoNGI got an issue when boot os, http://paste.openstack.org/show/798512/12:31
QianbiaoNGdo not know why it auto reboot everytime.12:31
QianbiaoNGThis is a ramdisk deploy provisioning.12:31
QianbiaoNGIs it designed this way?12:31
*** yolanda has quit IRC12:38
*** yolanda has joined #openstack-ironic12:39
*** goneri_ has joined #openstack-ironic12:43
*** rloo has joined #openstack-ironic12:46
*** k_mouza has joined #openstack-ironic12:52
*** goneri_ has quit IRC12:56
*** e0ne has joined #openstack-ironic12:58
openstackgerritYushiro FURUKAWA proposed openstack/ironic master: Fix handling OctetString for pysnmp  https://review.opendev.org/75040113:00
openstackgerritMerged openstack/ironic master: Update release mappings and API history for 16.0  https://review.opendev.org/75403513:05
openstackgerritMerged openstack/ironic master: Release notes prelude for the Victoria release  https://review.opendev.org/75386713:05
e0nedtantsur:  hi. do you have a time to discuss ironic-ui jobs?13:05
arne_wiebalckhey iurygregory o/13:05
e0neespecially, integration tests13:06
* arne_wiebalck was recording presenstations all morning ...13:06
iurygregorynow arne_wiebalck will share tips so iurygregory will avoid problems13:07
arne_wiebalckyep ... wait for it ...13:07
iurygregoryit's gonna be legend... wait for it ...13:08
arne_wiebalckyou simply record the thing over and over again, abort at every little mistake, and restart until your expectations is low enough that a recording passes your personal quality check13:08
iurygregoryhehehehe13:09
arne_wiebalckthen you delete the 105 files you recorded13:09
iurygregoryNICE!13:09
openstackgerritVerification of a change to openstack/ironic failed: Do not silently ignore exceptions when running next steps  https://review.opendev.org/75469913:09
arne_wiebalck and keep the number secret so everyone thinks you're a professional talk recorder13:09
iurygregoryhahahaha13:10
arne_wiebalck:-D13:10
iurygregoryyou have more xp than me13:10
arne_wiebalckyes, exactly 1 talk :)13:10
iurygregoryyou had 2 in Shanghai no?13:10
*** priteau has quit IRC13:10
arne_wiebalckoh, I meant pre-recorded13:11
iurygregoryI see13:11
iurygregorywill be the same for me hehe13:12
*** iurygregory has quit IRC13:15
dtantsure0ne: hi, yep13:20
e0nedtantsur: loose like we've got some devstack and/or configuration issue: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_08c/754439/2/check/ironic-ui-integration-tests/08c9e0f/job-output.txt13:21
e0neopt/stack/ironic/devstack/lib/ironic:1720:die13:21
e0ne2020-09-25 22:57:58.591499 | controller | [ERROR] /opt/stack/ironic/devstack/lib/ironic:1720 SWIFT_ENABLE_TEMPURLS must be True. This is  required either because IRONIC_DEPLOY_DRIVER was  set to some agent_* driver OR configuration of  Glance with Swift was explicitly requested with  IRONIC_CONFIGURE_GLANCE_WITH_SWIFT=True13:21
dtantsure0ne: yep, lemme take a look13:22
e0newe don't do any specific configuration to  for devstack in this job13:22
TheJuliagood morning13:25
openstackgerritDmitry Tantsur proposed openstack/ironic master: Trivial: fix formatting in the prelude  https://review.opendev.org/75500113:25
dtantsurTheJulia: ^^13:25
dtantsurand morning :)13:25
TheJuliadtantsur: thanks! Always fixing my prelude formats! :)13:26
trandlesTheJulia: the new video layout and quality looks great! Thanks for sorting that out.13:28
dtantsur:)13:30
openstackgerritDmitry Tantsur proposed openstack/ironic master: devstack: do not default to swift if SWIFT_ENABLE_TEMPURLS is False  https://review.opendev.org/75500313:30
dtantsure0ne: I think this will fix it ^^13:30
*** iurygregory has joined #openstack-ironic13:30
dtantsurTheJulia: I should add rst to my skills on linkedin :D13:31
openstackgerritIvan Kolodyazhny proposed openstack/ironic-ui master: Add npm tox env  https://review.opendev.org/75443913:32
e0nedtantsur: thanks! let's see how integration tests job will work now13:33
dtantsuryep13:33
QianbiaoNGdtantsur ramdisk-image-create is not deprecated.13:38
QianbiaoNGit's required when build ramdisk13:38
QianbiaoNGHi TheJulia, when provisioning with ramdisk deploy interface, system auto reboot when starting, any idea why13:38
QianbiaoNGconsole log: http://paste.openstack.org/show/798512/13:39
*** e0ne has quit IRC13:44
*** tzumainn has joined #openstack-ironic13:44
TheJuliatrandles: thanks! Sounds like I should just upload it :)13:45
TheJuliadtantsur: apparently I should also add OBS to my skills on LinkedIn13:46
dtantsur++ a good skill to list13:46
TheJuliaQianbiaoNG: Wow... :\13:46
dtantsurI can only spot the incorrect use of the limited busybox grep that results in a huge interface name13:48
*** sshnaidm has quit IRC13:48
QianbiaoNGdtantsur do u mean there are too many IF in this server?13:49
dtantsurQianbiaoNG: no, it's a bug in whatever scripts are run on start-up13:49
openstackgerritMerged openstack/ironic stable/train: Fix deprecated 'idrac' interface '__init__'s  https://review.opendev.org/75459113:49
TheJuliaQianbiaoNG: how did you produce that ramdisk?13:49
QianbiaoNGTheJulia I fix the issue on dib (seems so)13:50
QianbiaoNGand build a ramdisk image13:50
TheJuliaokay13:50
QianbiaoNGBTW: the dib tool only works with dib 1.5.0 with trusty13:50
QianbiaoNGto build a ramdisk file.13:51
QianbiaoNGdib args i used: ubuntu baremetal ramdisk devuser openssh-server -o bionic-4-ramdisk13:52
TheJuliaout of curiosity, did you try just debian or debian-minimal ?13:54
QianbiaoNGTheJulia I can try it now13:56
QianbiaoNGonly debian, no with any other options?13:57
QianbiaoNGkeep it clean13:57
*** sshnaidm has joined #openstack-ironic13:58
TheJuliadebian-minimal ramdisk open-sshserver devuser13:58
TheJuliaugh, that version is dib is 5 years old13:59
dtantsurTheJulia: I'm afraid you'll throw a table at me... but is it a good idea to change the iscsi deploy in https://review.opendev.org/#/c/726483/ now that we've deprecated it?14:00
patchbotpatch 726483 - ironic - Guard conductor from consuming all of the ram - 16 patch sets14:00
TheJuliadtantsur: chair no14:01
TheJuliadtantsur: I think it is a semi-good idea to just go ahead and do it for consistency's sake and given people are likely going to drag out moving to direct no matter what we do14:01
* dtantsur prepares to dodge a chair and any wet cats directed at him14:02
TheJuliawet cats are for after I pickup mr corgi from the vet this afternoon14:02
TheJuliabut you'll already be gone....14:02
* TheJulia wonders who inherited the powers of the endless wet cats14:02
dtantsurthat must be pawsome powers!14:03
TheJuliamordred once yeilded such powers14:03
TheJuliaback in my HP days, wet cats were totally the thing14:04
openstackgerritVanou Ishii proposed openstack/ironic master: Support iRMC hardware type again  https://review.opendev.org/75258714:07
* QianbiaoNG wonders what is wet cats14:08
openstackgerritJulia Kreger proposed openstack/ironic master: Support iRMC hardware type again  https://review.opendev.org/75258714:08
TheJuliaQianbiaoNG: an old joke how if someone might be mad at you, they might throw wet cats because cats don't like to be wet14:09
TheJuliaPerhaps a old joke only used amongst friends14:09
QianbiaoNGaha, i see.14:09
TheJuliacan I get another core reviewer to take a look at https://review.opendev.org/#/c/754362/ ?14:12
patchbotpatch 754362 - ironic - Fix a race condition in the hash ring code - 9 patch sets14:12
*** uzumaki has quit IRC14:13
dtantsurTheJulia: left come comments that I think are worth fixing. can re-review today.14:13
openstackgerritShivanand Tendulker proposed openstack/ironic stable/ussuri: Use correct error handler instead of calling process_event('fail')  https://review.opendev.org/75501714:14
dtantsurhttps://review.opendev.org/#/c/749552/ also needs another +2, and that may be it for features in Victoria14:14
patchbotpatch 749552 - ironic - Minor agent version code cleanup - 5 patch sets14:14
TheJuliadtantsur: k, I'll take a look once I get back from dropping off the dog at the vet14:14
* dtantsur imagines throwing a wet cargo at a vet14:14
dtantsurcargo, lol14:15
dtantsurcorgi14:15
dtantsurwords don't work, let's communicate in wet animals14:15
TheJulialol14:16
TheJuliawet corgis would just want to cuddle and play14:16
TheJuliaafter the shame of being wet passes14:16
QianbiaoNGTheJulia debian auto reboot too14:19
QianbiaoNGoptions: debian ramdisk devuser openssh-server -o debian-4-ramdisk14:20
openstackgerritVanou Ishii proposed openstack/ironic master: Support iRMC hardware type again  https://review.opendev.org/75258714:22
QianbiaoNGlogs: http://paste.openstack.org/show/798521/14:23
*** lmcgann_ has joined #openstack-ironic14:32
openstackgerritVerification of a change to openstack/ironic failed: Fix deprecated 'idrac' interface '__init__'s  https://review.opendev.org/75459014:47
QianbiaoNGHello, TheJulia. I have push my temp fixes for dib based on tag 2.38.0: https://github.com/openstack/diskimage-builder/compare/2.38.0...IamFive:2.38.1?expand=114:54
QianbiaoNGNot sure whether i did it correct.14:54
QianbiaoNGAnd the reboot issue, it happens on debian-minimal too14:55
*** uzumaki has joined #openstack-ironic15:03
*** k_mouza has quit IRC15:03
*** abdysn has quit IRC15:07
openstackgerritArne Wiebalck proposed openstack/ironic-python-agent master: Software RAID: Get component devices by md UUID  https://review.opendev.org/75471715:09
*** k_mouza has joined #openstack-ironic15:11
*** iurygregory has quit IRC15:20
dkingI'm wanting to use a custom hardware manager to clean certain drives which do not support secure erase. I already have  continue_if_disk_secure_erase_fails set to false, so the GenericHardwareManager should fail instead of using shred, but it seems like that would fail the entire clean step rather than falling back to the generic step. Is that correct, and if so, what should I be doing to accomplish that?15:20
lmcgann_TheJulia: what did you have in mind when you added the 'validate' method to the security interface. I'm confused as to whether this should exist as a call that triggers an attestation to grab a security state or if it somehow plays with the validate function on a node (as you suggested in your one comment on the spec).15:23
openstackgerritArne Wiebalck proposed openstack/ironic-python-agent stable/ussuri: Software RAID: Don't delete partitions too early  https://review.opendev.org/75506215:23
arne_wiebalckdtantsur: TheJulia: ^^ backport of the partition clean up fix15:26
dtantsurthx!15:26
dtantsurlmcgann_: validate in ironic usually checks that the node has enough parameters for the interface to work15:26
dtantsurthis is a de-factor standard method on all interfaces, not only security15:26
dtantsurso e.g. if you need some linkage between ironic and keylime on a node, this is where to validate it15:27
JayFdking: so you should do something like this: make SpecificDiskHardwareManager. in evaluate_hardware_support return something like SERVICE_PROVIDER, implement erase_device (not erase_devices) on it & at the top of that method, detect if the drive you're being called with is the one you handle -- if not, raise IncompatibleManagerError (or something like that? It's obvious in IPA exceptions15:28
JayFcode), if it *is* the disk you can handle, secure erase it15:28
*** iurygregory has joined #openstack-ironic15:28
lmcgann_dtantsur: I am asking as based on the comments on the security-interface spec it seems that there is no clear idea as to what the 'validate' method put forth should do. Julia wrote that piece of the spec and in a comment wrote 'I guess I was thinking it could still operate the same and be used as a validate, and would be useful to raise that to users... Hmm.'15:29
lmcgann_So I was wondering what her thought was on this component15:29
dtantsurlmcgann_: yeah, not sure what TheJulia was planning, but that's what I will expect of the validate method15:29
*** gyee has joined #openstack-ironic15:31
lmcgann_dtantsur: In your suggestion, there is no need for the validate method to be in the spec as the SecurityInterface inherits from the base anyways, correct?15:33
dkingJayF: Thank you. So, that means that SpecificDiskHardwareManager should run first, and on the specific step, it should return incompatible, and then, regardless of whether it ran there, erase_devices from GenericHardwareManagers would run, but because I'm using  continue_if_disk_secure_erase_fails=False, and my custom tool doesn't handle ATA, there should be no overlap?15:33
dtantsurlmcgann_: yep15:34
JayFdking: yes; I believe so15:34
JayFdking: I'm putting an example together, gimme 5 minutes15:34
dkingJayF: Thank you. I got a couple of different commands as we have some NVMe and some ISCI devices. And with 140T on some servers, obviously shred isn't an option.15:36
lmcgann_I think a renaming what we have though to 'node_validate' which returns the security state (possibly after triggering an attestation call) might be appropriate? It might be redundant however15:36
dtantsurlmcgann_: if possible at all, I'd avoid the word "validate". although I don't have better ideas atm15:37
dtantsureven "verify" is less overloaded in ironic15:37
dkingSpeaking of which, I had to dig a bit to find continue_if_disk_secure_erase_fails, and by then, I already knew the program's flow. Could it perhaps be placed somewhere a little more obvious, like somewhere in https://docs.openstack.org/ironic/latest/admin/cleaning.html ?15:38
dtantsurdking: that would be great15:40
dkingdtantsur: Thanks. I'll see if I can find a sane place for it.15:41
openstackgerritJay Faulkner proposed openstack/ironic-python-agent master: Add example for custom disk erasure  https://review.opendev.org/75506615:41
JayFdking: ^15:41
dtantsurdking: I think the descriptions of all clean steps are automatically rendered on that page15:41
dtantsurJayF++15:42
dtantsurwe need moar examples15:42
JayFplease review that closely, I just banged it out real quick for dking15:42
JayFlol15:42
dkingJayF: Thank you very much! I hope that should be able to help other people, too.15:43
QianbiaoNGHello, TheJulia, i think we really need a document talking about how to build ramdisk image.15:44
QianbiaoNGI found the issue for reboot, it's triggered by ramdisk https://github.com/openstack/diskimage-builder/blob/master/diskimage_builder/elements/ramdisk-base/extra-data.d/scripts/init-end15:44
QianbiaoNGAnd if ramdisk element triggers a reboot, it could never be used in ramdisk deploy interface, right?15:44
TheJuliaQianbiaoNG: I'd push your change into gerrit review, that way the contributors can look it15:45
QianbiaoNG<TheJulia> I have push it15:46
TheJuliaQianbiaoNG: I think I wrote basic instructions last week but I don't remember what I did with them :( There are so many tutorials on ramdisk building out there15:46
QianbiaoNGhttps://review.opendev.org/#/c/755056/15:46
patchbotpatch 755056 - diskimage-builder - Fix: ramdisk image build issues - 2 patch sets15:46
openstackgerritMerged openstack/ironic-python-agent master: Simplify heartbeating by removing use of select()  https://review.opendev.org/74677415:47
QianbiaoNGTheJulia ok, i will google some example and test without dib.15:47
TheJulialmcgann_: validate is like a pre-flight operational call, if things look okay, not necessarilly if they are good or not after full examination15:47
QianbiaoNGTheJulia I remember you write a instructions, it does not work finally, stucked at "no /dev/ram0 device."15:49
QianbiaoNGhere: http://paste.openstack.org/show/797733/15:49
openstackgerritBob Fournier proposed openstack/sushy master: Log only fields set in redfish response, not entire json  https://review.opendev.org/75506815:49
openstackgerritShivanand Tendulker proposed openstack/ironic stable/train: Use correct error handler instead of calling process_event('fail')  https://review.opendev.org/75507115:52
lmcgann_TheJulia: does validate even need mentioning in the spec then? I'd think no as the interface base class already has a 'validate'15:56
TheJulialikely not15:57
TheJulialess is kind of more in that case15:57
*** lucasagomes has quit IRC15:58
*** ociuhandu_ has joined #openstack-ironic16:08
*** ociuhandu has quit IRC16:12
TheJuliadtantsur: don't hang out, It looks like I'm going to have to do more than a little adjustment to my patch16:12
*** ociuhandu_ has quit IRC16:13
dtantsurokay, I'm on a meeting still16:13
TheJuliawell, then there is some hope :)16:17
*** QianbiaoNG has quit IRC16:30
openstackgerritMahendra Kamble proposed x/sushy-oem-idrac master: Add export system configuration  https://review.opendev.org/71032716:31
openstackgerritMerged openstack/ironic master: Do not silently ignore exceptions when running next steps  https://review.opendev.org/75469916:32
*** tbonds has quit IRC16:33
*** tbonds has joined #openstack-ironic16:35
dkingJayF: Thank you for the example. I am curious about how that works. I see that your example doesn't contain get_clean_steps nor an erase step itself. Should those be created and then calls erase_block_device?16:40
JayFdking: if you look in the GenericHardwareManager in hardware.py, you'll see it defines erase_devices as a clean step there, and erase_devices does a slightly more complex version of "for drive: dispatch_to_managers(erase_block_device)"16:41
JayFnot defining the clean step there means all the machinary in config for overriding the erase_devices priority still works16:42
openstackgerritJulia Kreger proposed openstack/ironic master: Guard conductor from consuming all of the ram  https://review.opendev.org/72648316:43
openstackgerritLeo McGann proposed openstack/ironic-specs master: Add security interface spec  https://review.opendev.org/57671816:44
*** dking has quit IRC16:45
*** olivierbourdon38 has quit IRC16:51
*** dtantsur is now known as dtantsur|afk16:52
dtantsur|afko/16:52
*** olivierbourdon38 has joined #openstack-ironic16:52
*** dking has joined #openstack-ironic16:53
*** derekh has quit IRC17:00
*** uzumaki has quit IRC17:03
openstackgerritJulia Kreger proposed openstack/ironic master: Minor agent version code cleanup  https://review.opendev.org/74955217:04
openstackgerritJulia Kreger proposed openstack/ironic master: Add some tuning documentation  https://review.opendev.org/73978317:08
*** ianychoi_ has joined #openstack-ironic17:17
*** ianychoi has quit IRC17:20
*** trandles has quit IRC17:21
*** k_mouza has quit IRC17:24
*** k_mouza has joined #openstack-ironic17:25
*** k_mouza has quit IRC17:26
openstackgerritYogesh Ramachandra proposed openstack/ironic master: Fix idrac-wsman bios factory-reset setting  https://review.opendev.org/74869617:28
openstackgerritMerged openstack/bifrost master: bifrost-configdrives-dynamic: automatically find ed25519 SSH keys  https://review.opendev.org/75267317:30
openstackgerritYogesh Ramachandra proposed openstack/ironic master: Fix idrac-wsman bios factory-reset setting  https://review.opendev.org/74869617:33
*** k_mouza has joined #openstack-ironic17:34
*** erbarr has quit IRC17:37
*** pas-ha has quit IRC17:37
*** bbezak has quit IRC17:37
*** PrinzElvis has quit IRC17:37
*** sri_ has quit IRC17:37
*** andrein has quit IRC17:37
*** vkmc has quit IRC17:37
*** portdirect has quit IRC17:37
*** gmann has quit IRC17:37
*** mnaser has quit IRC17:37
*** v1k0d3n has quit IRC17:37
*** mnasiadka has quit IRC17:37
*** rajinir has quit IRC17:37
*** seongsoocho has quit IRC17:37
*** donnyd has quit IRC17:37
*** k_mouza has quit IRC17:38
*** ildikov has quit IRC17:38
*** johnsom has quit IRC17:38
*** guilhermesp has quit IRC17:38
*** phrobb has quit IRC17:38
*** rpioso has quit IRC17:38
*** arne_wiebalck has quit IRC17:39
*** gouthamr has quit IRC17:39
*** Qianbiao has quit IRC17:39
*** johnsom has joined #openstack-ironic17:39
*** JamesBenson has quit IRC17:42
*** JamesBenson has joined #openstack-ironic17:43
openstackgerritLeo McGann proposed openstack/ironic-specs master: Add security interface spec  https://review.opendev.org/57671817:46
*** JamesBenson has quit IRC17:48
*** guilhermesp has joined #openstack-ironic17:48
*** sri_ has joined #openstack-ironic17:49
*** vkmc has joined #openstack-ironic17:49
*** erbarr has joined #openstack-ironic17:49
*** mnasiadka has joined #openstack-ironic17:49
openstackgerritMerged openstack/ironic master: Support iRMC hardware type again  https://review.opendev.org/75258717:49
*** pas-ha has joined #openstack-ironic17:49
*** andrein has joined #openstack-ironic17:49
*** rajinir has joined #openstack-ironic17:50
*** gmann_ has joined #openstack-ironic17:54
*** phrobb has joined #openstack-ironic17:54
*** donnyd has joined #openstack-ironic17:54
*** mnaser has joined #openstack-ironic17:54
*** gmann_ is now known as gmann17:56
*** arne_wiebalck has joined #openstack-ironic17:59
*** gouthamr has joined #openstack-ironic17:59
*** gouthamr has quit IRC17:59
*** portdirect has joined #openstack-ironic17:59
*** Qianbiao has joined #openstack-ironic18:00
*** PrinzElvis has joined #openstack-ironic18:00
*** JamesBenson has joined #openstack-ironic18:01
*** bbezak has joined #openstack-ironic18:04
*** gouthamr has joined #openstack-ironic18:05
*** seongsoocho has joined #openstack-ironic18:05
*** gouthamr has quit IRC18:05
*** ildikov has joined #openstack-ironic18:05
*** v1k0d3n has joined #openstack-ironic18:05
*** gouthamr has joined #openstack-ironic18:09
*** gouthamr has quit IRC18:09
*** rpioso has joined #openstack-ironic18:15
*** gouthamr has joined #openstack-ironic18:15
*** gouthamr has quit IRC18:15
*** trandles has joined #openstack-ironic18:16
openstackgerritJulia Kreger proposed openstack/ironic stable/ussuri: CI: Disable automated cleaning on cross-gate integration job  https://review.opendev.org/75510018:17
*** gouthamr has joined #openstack-ironic18:20
*** gouthamr has quit IRC18:20
*** gouthamr__ has joined #openstack-ironic18:26
openstackgerritMerged openstack/ironic-python-agent-builder master: Add an element to install python-hardware  https://review.opendev.org/75396618:26
openstackgerritJulia Kreger proposed openstack/ironic-python-agent master: Don't update the grubenv  https://review.opendev.org/75230818:35
*** olivierbourdon38 has quit IRC18:36
*** olivierbourdon38 has joined #openstack-ironic18:40
*** tbonds has quit IRC18:40
*** tbonds has joined #openstack-ironic18:42
*** rpioso has quit IRC19:05
*** rpioso has joined #openstack-ironic19:06
*** ildikov has quit IRC19:07
*** ildikov has joined #openstack-ironic19:08
*** gouthamr__ is now known as gouthamr19:39
*** ociuhandu has joined #openstack-ironic19:44
openstackgerritMerged openstack/ironic master: devstack: do not default to swift if SWIFT_ENABLE_TEMPURLS is False  https://review.opendev.org/75500319:44
*** tosky has quit IRC19:51
openstackgerritVerification of a change to openstack/ironic failed: Fix a race condition in the hash ring code  https://review.opendev.org/75436219:51
NobodyCamGood Afternoon Ironic folks19:56
iurygregorygood afternoon NobodyCam19:59
NobodyCam👋19:59
*** ociuhandu has quit IRC20:05
*** JamesBenson has quit IRC20:05
*** ildikov has quit IRC20:16
*** ildikov has joined #openstack-ironic20:17
rpiosoiurygregory: I'm trying to create a python-dracclient release. It's failing: http://paste.openstack.org/show/798545/. Any suggestions?20:44
rpiosoNobodyCam: o/20:45
*** prometheanfire has joined #openstack-ironic20:46
prometheanfireare you aware that currently virtualbmc-2.2.0 is not in the wallaby release?20:46
prometheanfire(no FFE has been requested for it)20:46
iurygregoryrpioso, no idea =(20:47
iurygregoryprometheanfire, we are I think dtantsur|afk mentioned something20:48
rpiosoiurygregory: Thank you! :-)20:48
iurygregoryprometheanfire, check the comment in https://review.opendev.org/#/c/752708/20:48
patchbotpatch 752708 - releases - Release virtualbmc 2.2.0 (MERGED) - 2 patch sets20:48
prometheanfireok, just wanted to make sure that was OK, otherwise someone should request a FFE for it (as ironic is the only consumer...)20:48
iurygregoryyeah =)20:49
iurygregoryafaik we don't need in victoria20:49
prometheanfirewfm20:49
iurygregoryTheJulia, fyi ^20:49
prometheanfirehttps://review.opendev.org/75288820:49
patchbotpatch 752888 - requirements - update constraint for virtualbmc to new release 2.2.0 - 1 patch set20:49
iurygregoryI've added a comment20:50
iurygregoryrpioso, maybe people in #openstack-releases would have more ideas =)20:51
rpiosoiurygregory: Good idea!20:56
*** k_mouza has joined #openstack-ironic21:00
rpiosohttps://stackoverflow.com/questions/12061645/generating-a-gpg-key-for-git-tagging21:02
rpiosoOops21:02
*** k_mouza has quit IRC21:04
*** k_mouza has joined #openstack-ironic21:09
*** k_mouza has quit IRC21:14
*** k_mouza has joined #openstack-ironic21:35
NobodyCamhey hey rpioso o/21:37
rpioso:-)21:37
*** k_mouza has quit IRC21:39
*** k_mouza has joined #openstack-ironic21:44
*** k_mouza has quit IRC21:48
*** johnsom has quit IRC21:52
*** rpioso has quit IRC21:52
*** sri_ has quit IRC21:52
*** portdirect has quit IRC21:52
*** erbarr has quit IRC21:53
*** arne_wiebalck has quit IRC21:53
*** ildikov has quit IRC21:53
*** johnsom has joined #openstack-ironic21:53
*** guilhermesp has quit IRC21:53
*** rpittau|afk has quit IRC21:53
*** mnasiadka has quit IRC21:54
*** PrinzElvis has quit IRC21:54
*** Qianbiao has quit IRC21:54
*** rajinir has quit IRC21:54
*** andrein has quit IRC21:54
*** vkmc has quit IRC21:54
*** pas-ha has quit IRC21:54
*** erbarr has joined #openstack-ironic21:55
*** andrein has joined #openstack-ironic21:55
*** mnasiadka has joined #openstack-ironic21:55
*** vkmc has joined #openstack-ironic21:55
*** lmcgann_ has quit IRC21:55
*** rpioso has joined #openstack-ironic21:56
*** sri_ has joined #openstack-ironic21:56
*** Qianbiao has joined #openstack-ironic21:56
*** pas-ha has joined #openstack-ironic21:56
*** portdirect has joined #openstack-ironic21:56
*** rajinir has joined #openstack-ironic21:56
*** rpittau|afk has joined #openstack-ironic21:56
*** ildikov has joined #openstack-ironic21:57
*** arne_wiebalck has joined #openstack-ironic21:57
*** rcernin has joined #openstack-ironic21:57
*** PrinzElvis has joined #openstack-ironic21:57
*** guilhermesp has joined #openstack-ironic21:57
*** Goneri has quit IRC22:07
*** k_mouza has joined #openstack-ironic22:11
jandersgood morning Ironic o/22:13
iurygregorymorning janders22:13
*** k_mouza has quit IRC22:15
*** rcernin has quit IRC22:15
*** zzzeek has quit IRC22:23
*** zzzeek has joined #openstack-ironic22:25
*** Goneri has joined #openstack-ironic22:26
*** k_mouza has joined #openstack-ironic22:27
jandershey iurygregory :)22:32
jandersmove done and dusted?22:32
*** k_mouza has quit IRC22:32
iurygregoryyeah22:32
janderscongratulations, well done! :)22:32
jandersthese are always hard work22:32
iurygregorytks!22:32
*** zzzeek has quit IRC22:37
*** zzzeek has joined #openstack-ironic22:37
*** rcernin has joined #openstack-ironic22:42
*** rcernin has quit IRC22:43
*** k_mouza has joined #openstack-ironic22:45
openstackgerritJulia Kreger proposed openstack/ironic stable/ussuri: CI: Additional minor job changes to improve CI reliability  https://review.opendev.org/75510022:46
*** k_mouza has quit IRC22:49
*** rcernin has joined #openstack-ironic22:51
*** k_mouza has joined #openstack-ironic22:54
*** k_mouza has quit IRC22:58
*** ianychoi_ is now known as ianychoi23:00
*** k_mouza has joined #openstack-ironic23:11
*** k_mouza has quit IRC23:15
*** k_mouza has joined #openstack-ironic23:27
*** rloo has quit IRC23:30
*** k_mouza has quit IRC23:32
*** Goneri has quit IRC23:41
TheJuliarpioso: I see 5.0.0 and 5.1.0 hav ebeen pushed for python-dracclient23:42
rpiosoTheJulia: Indeed! Please disregard 5.0.0. There's an issue with mirroring to GitHub. Last commit mirrored was back in May. Unfortunately, that wasn't known until after the tag was applied to a fresh clone and pushed. I've worked with fungi on fixing that. A stuff for tomorrow.23:45
TheJuliaahh23:45
TheJuliadoh!23:45
rpiosoTheJulia: Meanwhile, 5.1.0 is correct. I kicked off a recheck which passed.23:45
TheJuliak, I removed my wf-123:45
rpiosoTheJulia: Woot! Thank you so much.23:46
rpiosoTheJulia: Should I address smth in upper-constraints?23:48
*** Goneri has joined #openstack-ironic23:53

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!