TheJulia | no problem, I do think the change is totally valid, just don't know why chris wanted to check the length field. Maybe the idrac always returns or at least did when he wrote it | 00:00 |
---|---|---|
rpioso | TheJulia: Isn't it proper to include the Content-Length header when content returned? | 00:01 |
rpioso | TheJulia: And that it be non-zero? | 00:02 |
TheJulia | it is not explicitly required | 00:02 |
TheJulia | afaik | 00:02 |
TheJulia | BUT HTTP accepted if memory serves is purley optional to have a payload and content | 00:02 |
TheJulia | purely | 00:02 |
*** rloo has quit IRC | 00:05 | |
openstackgerrit | Merged openstack/ironic master: Remove compatibility with conductors that do not support groups https://review.opendev.org/c/openstack/ironic/+/754416 | 00:08 |
rpioso | TheJulia: I understand the payload is optional for HTTP ACCEPTED or at least it is in Redfish async operations: http://redfish.dmtf.org/schemas/DSP0266_1.11.0.html#asynchronous-operations | 00:08 |
rpioso | TheJulia: "The response to an asynchronous operation shall return the HTTP 202 Accepted status code and set the HTTP Location response header to the URI of a task monitor associated with the task. The response may also include the Retry-After header that defines the amount of time that the client should wait before polling for status. The response body **should** contain a representation of the Task resource." | 00:09 |
TheJulia | nice | 00:09 |
TheJulia | so yeah | 00:10 |
TheJulia | got to love "should" | 00:10 |
TheJulia | hmm | 00:10 |
TheJulia | wonder if the code properly groks that it is "should" | 00:10 |
TheJulia | Anyway, I don't have braincells at the moment to context load that back into active memory | 00:10 |
rpioso | TheJulia: But my question is, if it does contain payload, shouldn't it contain a non-zero Content-Length header? | 00:10 |
TheJulia | based on the table on the header use requirement, I'm guessing no, plus it is still a niceity. Apparently the client can force it with requesting chunked encoding, at least that is the way I'm groking the doucment | 00:13 |
TheJulia | chunked, I think requires it for offsetting | 00:14 |
TheJulia | "I got x bytes, I need x+y starting at end of x" | 00:15 |
rpioso | TheJulia: Which table and doc are you referring to? | 00:16 |
TheJulia | the one you linked to even has the field as not required by clients or servers | 00:16 |
rpioso | TheJulia: "field"? | 00:17 |
TheJulia | Content-Length | 00:17 |
TheJulia | the header | 00:17 |
rpioso | TheJulia: ty | 00:17 |
rpioso | TheJulia: Where do you see that? | 00:17 |
rpioso | TheJulia: Link, please. | 00:18 |
TheJulia | http://redfish.dmtf.org/schemas/DSP0266_1.11.0.html#asynchronous-operations | 00:18 |
TheJulia | the One you linked to, section 7.1 | 00:18 |
* TheJulia goes and exercises | 00:19 | |
*** sshnaidm|afk has joined #openstack-ironic | 00:20 | |
*** sshnaidm|afk is now known as sshnaidm|off | 00:20 | |
rpioso | TheJulia: Got it, the table in section 7.1 of the linked doc. | 00:21 |
rpioso | TheJulia: TL;DR, I believe the change is good to go re: the question about the guard. If there's not enough data for all of the fields, the Task will be successfully constructed as long as its two (2) required fields, Id and Name, are present. And, if there is no data, its base class will GET it during __init__: | 00:26 |
rpioso | https://github.com/openstack/sushy/blob/af4adf56a665ebf90ccff35e12d1228a4cf91c65/sushy/resources/base.py#L599 | 00:26 |
rpioso | TheJulia: I'll add a comment to the review. | 00:26 |
TheJulia | thanks rpioso! | 00:28 |
*** guilhermesp has quit IRC | 00:56 | |
*** jungleboyj has quit IRC | 00:56 | |
*** jungleboyj has joined #openstack-ironic | 00:57 | |
*** gouthamr has quit IRC | 00:57 | |
*** mnasiadka has quit IRC | 00:57 | |
*** guilhermesp has joined #openstack-ironic | 00:58 | |
*** gouthamr has joined #openstack-ironic | 00:58 | |
*** mnasiadka has joined #openstack-ironic | 00:58 | |
*** tosky has quit IRC | 01:01 | |
*** ociuhandu has joined #openstack-ironic | 01:10 | |
*** paras333_ has quit IRC | 01:15 | |
*** ociuhandu has quit IRC | 01:15 | |
*** k_mouza has joined #openstack-ironic | 01:17 | |
*** k_mouza has quit IRC | 01:21 | |
*** openstackgerrit has quit IRC | 01:38 | |
rpioso | TheJulia: yw | 01:38 |
*** zzzeek has quit IRC | 02:14 | |
*** zzzeek has joined #openstack-ironic | 02:15 | |
*** Goneri has quit IRC | 02:19 | |
*** ociuhandu has joined #openstack-ironic | 02:59 | |
*** ociuhandu has quit IRC | 03:03 | |
*** mkrai has joined #openstack-ironic | 03:58 | |
*** k_mouza has joined #openstack-ironic | 04:02 | |
*** k_mouza has quit IRC | 04:06 | |
*** ociuhandu has joined #openstack-ironic | 04:47 | |
*** ociuhandu has quit IRC | 04:51 | |
*** k_mouza has joined #openstack-ironic | 05:07 | |
*** k_mouza has quit IRC | 05:11 | |
*** mkrai has quit IRC | 05:42 | |
*** mkrai has joined #openstack-ironic | 05:42 | |
*** lbragstad has quit IRC | 06:02 | |
*** lbragstad has joined #openstack-ironic | 06:03 | |
*** bburns has quit IRC | 06:28 | |
*** ociuhandu has joined #openstack-ironic | 06:35 | |
*** ociuhandu has quit IRC | 06:40 | |
*** ociuhandu has joined #openstack-ironic | 07:02 | |
*** rcernin has quit IRC | 07:04 | |
*** ociuhandu has quit IRC | 07:14 | |
*** rcernin has joined #openstack-ironic | 07:17 | |
*** rcernin has quit IRC | 07:18 | |
*** tzumainn has quit IRC | 07:20 | |
*** uzumaki has joined #openstack-ironic | 07:38 | |
*** ociuhandu has joined #openstack-ironic | 07:42 | |
*** mkrai has quit IRC | 07:43 | |
*** mkrai_ has joined #openstack-ironic | 07:43 | |
*** mkrai_ has quit IRC | 07:45 | |
*** ociuhandu has quit IRC | 07:47 | |
arne_wiebalck | Good morning, ironic! | 07:58 |
*** ociuhandu has joined #openstack-ironic | 08:02 | |
*** ociuhandu has quit IRC | 08:03 | |
*** belmoreira has joined #openstack-ironic | 08:05 | |
*** k_mouza has joined #openstack-ironic | 08:08 | |
*** ociuhandu has joined #openstack-ironic | 08:12 | |
*** k_mouza has quit IRC | 08:13 | |
*** ociuhandu has quit IRC | 08:18 | |
*** bburns has joined #openstack-ironic | 08:21 | |
*** uzumaki has quit IRC | 08:26 | |
*** tkajinam has quit IRC | 08:31 | |
*** tkajinam has joined #openstack-ironic | 08:32 | |
*** ociuhandu has joined #openstack-ironic | 08:32 | |
*** ociuhandu has quit IRC | 08:39 | |
*** uzumaki has joined #openstack-ironic | 08:59 | |
*** tosky has joined #openstack-ironic | 09:05 | |
*** derekh has joined #openstack-ironic | 09:09 | |
janders | good morning arne_wiebalck! | 09:11 |
janders | Happy Friday! | 09:11 |
arne_wiebalck | hey janders, happy Friday to you, too! | 09:11 |
*** lourot has quit IRC | 09:17 | |
*** lourot has joined #openstack-ironic | 09:18 | |
*** ociuhandu has joined #openstack-ironic | 09:41 | |
*** ociuhandu has quit IRC | 09:46 | |
janders | dinner running longer, will be ~15min late to the SPUC | 09:49 |
*** k_mouza has joined #openstack-ironic | 09:50 | |
*** ociuhandu has joined #openstack-ironic | 10:10 | |
*** ociuhandu has quit IRC | 10:19 | |
janders | in now if anyone feels like joining :) | 10:22 |
*** ociuhandu has joined #openstack-ironic | 10:25 | |
janders | this one wasn't too popular... another time! :) | 10:29 |
janders | (dropping off) | 10:29 |
*** ociuhandu has quit IRC | 10:29 | |
*** ociuhandu has joined #openstack-ironic | 11:39 | |
*** ociuhandu has quit IRC | 11:39 | |
iurygregory | good morning Ironic! | 11:42 |
*** ociuhandu has joined #openstack-ironic | 12:11 | |
*** ociuhandu has quit IRC | 12:20 | |
janders | hey iurygregory o/ | 12:33 |
janders | wrapping up for the day, so just dropped in to wish all of you a great weekend | 12:33 |
janders | see you next week Ironic o/ | 12:33 |
janders | (bonus: one week closer to Christmas :) ) | 12:34 |
iurygregory | janders, you too! | 12:36 |
*** zzzeek has quit IRC | 12:36 | |
iurygregory | 1 week so I can start going out and see family hehehe | 12:36 |
*** uzumaki has quit IRC | 12:37 | |
*** zzzeek has joined #openstack-ironic | 12:37 | |
*** tosin has joined #openstack-ironic | 12:41 | |
*** ociuhandu has joined #openstack-ironic | 12:51 | |
*** ociuhandu has quit IRC | 12:59 | |
*** ociuhandu has joined #openstack-ironic | 13:17 | |
*** ociuhandu has quit IRC | 13:17 | |
*** paras333 has joined #openstack-ironic | 13:17 | |
*** paras333 has quit IRC | 13:21 | |
*** paras333 has joined #openstack-ironic | 13:30 | |
*** ociuhandu has joined #openstack-ironic | 13:36 | |
*** ociuhandu has quit IRC | 13:43 | |
*** rloo has joined #openstack-ironic | 14:02 | |
*** tkajinam has quit IRC | 14:07 | |
*** tosin has quit IRC | 14:15 | |
TheJulia | good morning | 14:25 |
*** ociuhandu has joined #openstack-ironic | 14:33 | |
*** ociuhandu has quit IRC | 14:33 | |
*** uzumaki has joined #openstack-ironic | 14:36 | |
*** uzumaki has quit IRC | 14:37 | |
*** uzumaki has joined #openstack-ironic | 14:38 | |
*** ociuhandu has joined #openstack-ironic | 14:38 | |
*** ociuhandu has quit IRC | 14:43 | |
*** bnemec has joined #openstack-ironic | 14:44 | |
arne_wiebalck | Hey TheJulia, good morning! | 14:46 |
*** bnemec is now known as beekneemech | 14:50 | |
*** Goneri has joined #openstack-ironic | 14:54 | |
*** ociuhandu has joined #openstack-ironic | 14:56 | |
*** ociuhandu has quit IRC | 15:03 | |
*** sdanni has joined #openstack-ironic | 15:05 | |
*** anuradha1904 has joined #openstack-ironic | 15:13 | |
*** uzumaki has quit IRC | 15:53 | |
*** ociuhandu has joined #openstack-ironic | 16:04 | |
*** gyee has joined #openstack-ironic | 16:07 | |
*** ociuhandu has quit IRC | 16:09 | |
*** sdanni has quit IRC | 16:19 | |
*** sdanni has joined #openstack-ironic | 16:20 | |
*** lmcgann has joined #openstack-ironic | 16:44 | |
*** openstackgerrit has joined #openstack-ironic | 16:47 | |
openstackgerrit | Kaifeng Wang proposed openstack/ironic master: [WIP] Support port name: API https://review.opendev.org/c/openstack/ironic/+/765569 | 16:47 |
JayF | I'm already in the SPUC if anyone else wants to join early o/ | 16:53 |
JayF | TheJulia: dtantsur|afk: anyone else, coming? zbuhman and I are here | 17:05 |
TheJulia | ohhh completey forgot | 17:05 |
TheJulia | joining | 17:05 |
TheJulia | SPUC!!!!! | 17:08 |
*** ociuhandu has joined #openstack-ironic | 17:11 | |
*** ociuhandu has quit IRC | 17:11 | |
*** ociuhandu has joined #openstack-ironic | 17:12 | |
*** ociuhandu has quit IRC | 17:16 | |
*** ociuhandu has joined #openstack-ironic | 17:20 | |
iurygregory | spuc link? | 17:21 |
*** ociuhandu has quit IRC | 17:30 | |
*** ociuhandu has joined #openstack-ironic | 17:31 | |
*** ociuhandu has quit IRC | 17:31 | |
*** k_mouza has quit IRC | 17:39 | |
openstackgerrit | Dhuldev Valekar proposed x/sushy-oem-idrac master: Redfish management clean steps https://review.opendev.org/c/x/sushy-oem-idrac/+/721596 | 17:40 |
*** k_mouza has joined #openstack-ironic | 17:44 | |
*** beekneemech has quit IRC | 17:49 | |
TheJulia | SPUC has achieved technology nostalgia.... We're talking about serial ports, modems, BBSes | 17:57 |
*** k_mouza has quit IRC | 17:57 | |
TheJulia | and MP3 encoding | 18:00 |
*** sdanni has quit IRC | 18:03 | |
*** derekh has quit IRC | 18:04 | |
*** k_mouza has joined #openstack-ironic | 18:34 | |
*** k_mouza has quit IRC | 18:48 | |
*** anuradha1904 has quit IRC | 19:43 | |
*** k_mouza has joined #openstack-ironic | 19:48 | |
*** k_mouza has quit IRC | 19:52 | |
dking | I think I may have asked before, but is there a good way to unit test a method that uses dispatch_to_managers()? | 20:16 |
buhman | I read most of https://review.opendev.org/c/openstack/ironic-specs/+/764070/2/specs/approved/secure-rbac.rst ; I wish it went into more detail on reasoning behind making this change, particularly in the opening paragraphs. It's only later that "System scope" and "Project scope" are defined, and it still takes imagination from the reader to understand the use-cases. | 20:18 |
buhman | I also think it would be a nice indicator of policy symmetry if Nova were able to use Project-scoped authorization for most operations, because that would imply the end-user would have been able to make those exact Ironic API calls themselves if they so desired. | 20:21 |
buhman | It would be even cooler if the goal of the spec were restated in terms of that ^ sort of "policy symmetry", rather than the more obscure "Secure RBAC" term that is never actually defined or linked. | 20:22 |
buhman | IOW, that all of the cases where Nova is still required to use a System-scoped authorization are considered to be weaknesses/bugs in Ironic. | 20:25 |
TheJulia | lbragstad: ^^^ I keep hearing similar concerns and statements. I Everyone seems to be unable to find and identify the originating community wide driver. | 20:25 |
TheJulia | I think the idea, ultimately nova would handle the allocation/reservation as the service account, and then inside the request client it would be able to switch to using exclusively user token data. | 20:26 |
TheJulia | But that is definitely not an interation I spent much time thinking about | 20:27 |
*** belmoreira has quit IRC | 20:46 | |
*** lmcgann has quit IRC | 20:50 | |
*** jamesdenton has quit IRC | 20:51 | |
*** ociuhandu has joined #openstack-ironic | 20:51 | |
*** jamesdenton has joined #openstack-ironic | 20:52 | |
*** ociuhandu has quit IRC | 21:16 | |
openstackgerrit | Julia Kreger proposed openstack/ironic-lib master: Disable output cache https://review.opendev.org/c/openstack/ironic-lib/+/765387 | 21:36 |
*** ociuhandu has joined #openstack-ironic | 21:47 | |
*** k_mouza has joined #openstack-ironic | 21:57 | |
*** tkajinam has joined #openstack-ironic | 22:00 | |
*** k_mouza has quit IRC | 22:01 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: IPMI: Handle vendor set boot device differences https://review.opendev.org/c/openstack/ironic/+/757198 | 22:06 |
*** ociuhandu has quit IRC | 22:11 | |
*** ociuhandu has joined #openstack-ironic | 22:11 | |
*** ociuhandu has quit IRC | 22:16 | |
*** ociuhandu has joined #openstack-ironic | 22:22 | |
*** jamesdenton has quit IRC | 22:40 | |
*** jamesdenton has joined #openstack-ironic | 22:40 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Guard conductor from consuming all of the ram https://review.opendev.org/c/openstack/ironic/+/726483 | 22:45 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Set default to prevent out of memory conditions https://review.opendev.org/c/openstack/ironic/+/763107 | 22:45 |
buhman | TheJulia: why can't allocation be done with a user/project-scoped token? | 22:50 |
TheJulia | Well, the alloation API maybe, but a physical node can't be updated unless a user/project scoped token has access over the hardware, i.e. is a lessee already or it is owned by their project | 22:51 |
TheJulia | The allocation api may be a shortcut around that in ironic, but it is not what nova uses | 22:51 |
buhman | Yeah, so Nova would need to be updated to use the allocation API | 22:52 |
TheJulia | contributions welcome! | 22:52 |
TheJulia | It will likely need to be, or even optionally. I guess that is yet another thing we need to ferret out with this | 22:52 |
*** paras333 has quit IRC | 22:57 | |
TheJulia | buhman: good comments on the spec, thanks! | 23:00 |
TheJulia | I may revise this weekend or most likely early monday morning at this rate | 23:00 |
buhman | Thank Jay, I originally was just going unproductively complain to him privately :) | 23:01 |
TheJulia | Thanks JayF | 23:03 |
* TheJulia thinks it is time to either go exercise or enjoy whiskey | 23:03 | |
TheJulia | (... or both?) | 23:04 |
JayF | :D I'm an expert at nerd sniping | 23:04 |
JayF | but I also nerd sniped myself, I think I reviewed 3 specs today and security interface I'm saving for last | 23:04 |
TheJulia | Thanks guys! | 23:04 |
*** ociuhandu has quit IRC | 23:29 | |
*** ociuhandu has joined #openstack-ironic | 23:30 | |
*** ociuhandu has quit IRC | 23:35 | |
*** Goneri has quit IRC | 23:50 | |
*** tosky has quit IRC | 23:54 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!