| stevebaker | janders: hey | 00:00 |
|---|---|---|
| *** anuradha1904 has quit IRC | 00:01 | |
| *** ayoung has quit IRC | 00:04 | |
| *** ayoung has joined #openstack-ironic | 00:13 | |
| TheJulia | stevebaker: oddly enough, it seems more like the collection is getting returned, and that I'm just mentally lacking the connection since it doesn't seem to be get_all :\ | 00:29 |
| TheJulia | Anyway, will need to work backwards tomorrow | 00:29 |
| * TheJulia goes and processes stuff | 00:29 | |
| *** k_mouza has joined #openstack-ironic | 00:30 | |
| *** k_mouza has quit IRC | 00:34 | |
| *** ricolin has joined #openstack-ironic | 01:29 | |
| openstackgerrit | Verification of a change to openstack/ironic-python-agent-builder failed: Remove PYOPTIMIZE_TINYIPA capability https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775884 | 01:31 |
| *** k_mouza has joined #openstack-ironic | 01:49 | |
| *** k_mouza has quit IRC | 02:00 | |
| *** rcernin has quit IRC | 02:27 | |
| *** rcernin has joined #openstack-ironic | 03:07 | |
| *** mkrai has joined #openstack-ironic | 03:14 | |
| *** rh-jelabarre has quit IRC | 03:49 | |
| *** mkrai has quit IRC | 03:49 | |
| *** mkrai_ has joined #openstack-ironic | 03:50 | |
| openstackgerrit | Merged openstack/ironic-lib master: Split out a common helper for blkid https://review.opendev.org/c/openstack/ironic-lib/+/774931 | 03:57 |
| openstackgerrit | Merged openstack/ironic-lib master: utils.mounted: retry umount and allow retrying mount https://review.opendev.org/c/openstack/ironic-lib/+/774908 | 03:57 |
| openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 04:00 |
| *** k_mouza has joined #openstack-ironic | 04:00 | |
| janders | \o/ that was a bit of a tricky rebase | 04:03 |
| *** k_mouza has quit IRC | 04:04 | |
| *** k_mouza has joined #openstack-ironic | 04:13 | |
| *** ricolin has quit IRC | 04:16 | |
| *** k_mouza has quit IRC | 04:18 | |
| openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 04:22 |
| *** uzumaki has quit IRC | 04:40 | |
| *** gyee has quit IRC | 05:01 | |
| openstackgerrit | Merged openstack/ironic-python-agent-builder master: Remove PYOPTIMIZE_TINYIPA capability https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775884 | 05:09 |
| *** mkrai_ has quit IRC | 05:15 | |
| *** mkrai has joined #openstack-ironic | 05:28 | |
| *** uzumaki has joined #openstack-ironic | 05:36 | |
| *** monica_pardhi has joined #openstack-ironic | 05:39 | |
| *** monica_pardhi has quit IRC | 05:56 | |
| openstackgerrit | Kartikeya Jain proposed openstack/ironic-python-agent master: Fixes local boot for partition images https://review.opendev.org/c/openstack/ironic-python-agent/+/775799 | 06:14 |
| *** ricolin has joined #openstack-ironic | 06:29 | |
| *** mnaser has quit IRC | 06:32 | |
| *** mnaser has joined #openstack-ironic | 06:34 | |
| *** moshiur has joined #openstack-ironic | 07:05 | |
| *** mkrai has quit IRC | 07:19 | |
| *** mkrai has joined #openstack-ironic | 07:29 | |
| *** k_mouza has joined #openstack-ironic | 07:29 | |
| *** k_mouza has quit IRC | 07:34 | |
| *** rcernin has quit IRC | 07:47 | |
| *** ricolin has quit IRC | 08:08 | |
| *** rpittau|afk is now known as rpittau | 08:12 | |
| rpittau | good morning ironic! o/ | 08:12 |
| *** ricolin_ has joined #openstack-ironic | 08:12 | |
| *** rcernin has joined #openstack-ironic | 08:12 | |
| *** ricolin_ is now known as ricolin | 08:17 | |
| *** uzumaki has quit IRC | 08:18 | |
| *** rcernin has quit IRC | 08:19 | |
| *** rcernin has joined #openstack-ironic | 08:26 | |
| *** uzumaki has joined #openstack-ironic | 08:30 | |
| *** rcernin has quit IRC | 08:31 | |
| *** rcernin has joined #openstack-ironic | 08:37 | |
| *** dougsz has joined #openstack-ironic | 08:38 | |
| *** anuradha1904 has joined #openstack-ironic | 08:38 | |
| *** rcernin has quit IRC | 08:51 | |
| *** rcernin has joined #openstack-ironic | 08:56 | |
| *** rcernin has quit IRC | 09:02 | |
| *** ociuhandu has joined #openstack-ironic | 09:07 | |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent master: Move some raid specific functions to raid_utils https://review.opendev.org/c/openstack/ironic-python-agent/+/774854 | 09:11 |
| rpittau | ^ open for reviews, now typos free (hopefully) | 09:11 |
| *** lucasagomes has joined #openstack-ironic | 09:12 | |
| *** tosky has joined #openstack-ironic | 09:14 | |
| *** ociuhandu has quit IRC | 09:17 | |
| rpittau | TheJulia: why was dependencies removed from the tinyipa Makefile all entry in https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775884 ? | 09:19 |
| *** tosky_ has joined #openstack-ironic | 09:20 | |
| *** tosky has quit IRC | 09:24 | |
| *** tosky_ is now known as tosky | 09:25 | |
| *** rcernin has joined #openstack-ironic | 09:28 | |
| *** rcernin has quit IRC | 09:35 | |
| *** stendulker has joined #openstack-ironic | 09:38 | |
| *** derekh has joined #openstack-ironic | 09:39 | |
| *** ociuhandu has joined #openstack-ironic | 09:47 | |
| *** k_mouza has joined #openstack-ironic | 09:51 | |
| *** rcernin has joined #openstack-ironic | 09:59 | |
| janders | good morning rpittau and Ironic o/ | 10:00 |
| rpittau | hey janders :) | 10:00 |
| *** dtantsur|afk is now known as dtantsur | 10:01 | |
| dtantsur | morning ironic | 10:01 |
| dtantsur | TheJulia: I think you're right re subresources | 10:01 |
| rpittau | good morning dtantsur :) | 10:01 |
| dtantsur | JayF: could you elaborate on your comment on inject-files? there is not (and has never been) a way to run purely deploy steps in cleaning (and vice verse) | 10:02 |
| janders | rpittau thank you for your review, before I upload a revised patch, a quick one: https://review.opendev.org/c/openstack/ironic-python-agent/+/771904/29/ironic_python_agent/tests/unit/samples/hardware_samples.py#840 is it okay if I have several variants of the nvme-cli output, or do we need to parametrize this? | 10:02 |
| janders | good morning dtantsur o/ | 10:02 |
| dtantsur | o/ | 10:02 |
| janders | rpittau BTW great work on moving samples out of the main hardware test file | 10:02 |
| janders | I'm not trying to litter it too much hence the question | 10:02 |
| rpittau | janders: that's ok, I was wondering instead if we could base the result of nvme format on the exit code and not parsing the stdout | 10:03 |
| rpittau | janders: heh sorry if you had to rebase :P | 10:03 |
| janders | yeah I did and it was a fun one :) | 10:03 |
| janders | I have up on doing it with vim and fired up meld | 10:03 |
| dtantsur | oh, I remember when I moved a lot of code from manager.py to deployments.py/cleaning.py | 10:03 |
| janders | and then I slightly stuffed it up and realised git creates the .orig file manually, so didnt need to pull the old patches | 10:03 |
| dtantsur | all cherry-picks were a lot of fun after that | 10:03 |
| rpittau | we all have a very similar concept of "fun" around here :D | 10:04 |
| janders | :D rpittau good point with the exit codes. If we're moving away from parsing random text while going for the json output, we might just as well do this | 10:05 |
| rpittau | janders: 1k lines for the samples should not be a problem, you can even create your own nvme_samples file if you want | 10:05 |
| janders | rpittau if sanitize comes onboard it may be a good idea - for now I think it's okay the way it is | 10:05 |
| janders | I will get onto the revision now | 10:06 |
| rpittau | cool with me :) | 10:06 |
| * rpittau second breakfast time (coffee + cookie) | 10:06 | |
| dtantsur | we shouldn't hesitate to create more small files | 10:06 |
| *** ociuhandu has quit IRC | 10:10 | |
| janders | talking about small files in (even if slightly) NVMe related context alludes to my previous roles in a really funny way :) | 10:11 |
| janders | speaking of Meld, this week I came to a conclusion I need multiple screens in... my car | 10:17 |
| janders | the tablet on the dash should be pretty good split screen, but I think I will get a mount for the phone as well. Split screen tablet + phone should be enough I hope. | 10:18 |
| *** mkrai has quit IRC | 10:19 | |
| *** ociuhandu has joined #openstack-ironic | 10:20 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Fix the Debian Buster version number https://review.opendev.org/c/openstack/bifrost/+/776044 | 10:20 |
| * dtantsur facepalms at ^^^ | 10:20 | |
| dtantsur | janders: a whole mobile control center :) | 10:20 |
| janders | yeah! :) | 10:20 |
| janders | I actually call it that when I fly the drone from inside the car (life saver in strong sun) | 10:21 |
| janders | but having flightradar on the other screen while I fly would be awesome | 10:21 |
| rpittau | I facepalm too as I think I approved that in the past :/ | 10:21 |
| janders | for the actual driving - high-res maps, weather radar on the tablet and performance/telemetry data on the phone would be handy - with phone's half screen for whatever else might be handy at a given point in time | 10:22 |
| janders | but I could totally use three screens too | 10:23 |
| janders | habit from my work setup I suppose | 10:24 |
| janders | I wont be surprised if teslas have that or will in the near future, but in an electric car things might actually be simpler (and not need that much) | 10:24 |
| janders | motor itself is simpler and the electrical system is more central to the core functions, so it'l show key details on the factory dash | 10:25 |
| dtantsur | makes sense | 10:26 |
| * dtantsur has only two monitors: the main one and the laptop one | 10:26 | |
| janders | dtantsur efficiency! | 10:27 |
| rpittau | I have 3 and sometimes I feel the need for a 4th and another set of eyes | 10:27 |
| janders | I was genuinely using four half-screen terminals while merging code this morning, with the third running IRC and the terminal for running unit tests | 10:27 |
| rpittau | oh yeah, and a clone | 10:27 |
| dtantsur | my normal mode of operation is ViM split into 2 columns on the main screen and IRC on the laptop screen | 10:27 |
| dtantsur | with the separate slack application I could possible use another one.. | 10:27 |
| janders | *third monitor | 10:27 |
| dtantsur | but for now I tend to ignore slack instead! :D | 10:27 |
| janders | :D | 10:28 |
| janders | IRC aged gracefully | 10:28 |
| janders | I still find it more better'er :D | 10:28 |
| *** rcernin has quit IRC | 10:31 | |
| rpittau | to be honest I find slack nowadays more appealing :D | 10:32 |
| janders | it's good (I quite like the mobile side of it) but especially for our team, I can't justify the added "weight" relative to the functionality I actually use | 10:33 |
| janders | it does seem really heavy on resources for what it is | 10:34 |
| janders | IRC is the XFCE of communicators, but even whatsapp and Signal don't make my laptop work as hard as Slack | 10:34 |
| dtantsur | So, the mobile client is actually decent? Good to know, because the desktop application is mediocre | 10:38 |
| openstackgerrit | Merged openstack/bifrost master: Fix the Debian Buster version number https://review.opendev.org/c/openstack/bifrost/+/776044 | 10:39 |
| janders | that is my impression (and I agree regarding the desktop app - or the bloated browser based implementation) | 10:40 |
| janders | mobile one ain't perfect but it was very usable last time I checked | 10:40 |
| janders | I don't really need the mobile app at RHAT though so my experience is over 6 months old | 10:40 |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost stable/victoria: Fix the Debian Buster version number https://review.opendev.org/c/openstack/bifrost/+/775913 | 10:41 |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: More compact README.rst https://review.opendev.org/c/openstack/bifrost/+/776107 | 10:55 |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: More compact README.rst https://review.opendev.org/c/openstack/bifrost/+/776107 | 10:56 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Enforce autospec in test_chassis https://review.opendev.org/c/openstack/ironic/+/776108 | 10:56 |
| iurygregory | good morning Ironic o/ | 11:01 |
| dtantsur | \o | 11:05 |
| *** stendulker has quit IRC | 11:07 | |
| iurygregory | dtantsur, did I just woke up with a ping about sushy-tools + secure boot or I'm still sleeping? XD | 11:10 |
| openstackgerrit | Merged openstack/bifrost stable/victoria: Fix the Debian Buster version number https://review.opendev.org/c/openstack/bifrost/+/775913 | 11:14 |
| *** sshnaidm has quit IRC | 11:15 | |
| * iurygregory time for more coffee | 11:16 | |
| *** sshnaidm has joined #openstack-ironic | 11:18 | |
| *** tosin has joined #openstack-ironic | 11:21 | |
| openstackgerrit | Merged openstack/ironic-python-agent master: Fixes local boot for partition images https://review.opendev.org/c/openstack/ironic-python-agent/+/775799 | 11:27 |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: More compact README.rst https://review.opendev.org/c/openstack/bifrost/+/776107 | 11:45 |
| dtantsur | iurygregory: hehe, good morning :) | 11:46 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent stable/victoria: Fixes local boot for partition images https://review.opendev.org/c/openstack/ironic-python-agent/+/775914 | 11:47 |
| *** ociuhandu has quit IRC | 11:53 | |
| openstackgerrit | Merged openstack/ironic-python-agent-builder master: Support installing ironic-lib from source https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775153 | 12:05 |
| *** k_mouza has quit IRC | 12:16 | |
| *** k_mouza has joined #openstack-ironic | 12:17 | |
| *** uzumaki has quit IRC | 12:23 | |
| *** uzumaki has joined #openstack-ironic | 12:24 | |
| *** fdegir5 is now known as fdegir | 12:24 | |
| *** uzumaki has quit IRC | 12:27 | |
| *** uzumaki has joined #openstack-ironic | 12:27 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Validate configdrive string format https://review.opendev.org/c/openstack/ironic/+/775922 | 12:33 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Validate configdrive string format https://review.opendev.org/c/openstack/ironic/+/775922 | 12:38 |
| iurygregory | dtantsur, I have some questions about introspection-rules API to have the support on openstacksdk. 1- We have the DELETE for all rules and for a specific rule, I'm wondering if for the delete all we need to have some logic to list all rules and delete one at a time | 12:53 |
| iurygregory | 2- I think we are missing the link fields in the table https://docs.openstack.org/api-ref/baremetal-introspection/?expanded=create-introspection-rule-detail#id17 right? | 12:55 |
| *** rcernin has joined #openstack-ironic | 12:58 | |
| *** rcernin has quit IRC | 13:02 | |
| janders | dtantsur rpittau would it be a good idea to put references to NVMe spec explaining where the binary values (0b10 for format support; 0b100 for crypto format support) we're looking for come from? The way I see it: Pros: it's good to have it handy; Cons: It will get out of date and I dont think anyone will be checking the spec and updating figure | 13:04 |
| janders | numbers in the comment. We could specify the revision but might get taken offline with time. What do you think? | 13:04 |
| dtantsur | iurygregory: 1) why? DELETE /v1/rules does exactly that. | 13:05 |
| dtantsur | janders: I think it's okay if you just provide named constants for these | 13:05 |
| janders | dtantsur ok! | 13:05 |
| dtantsur | iurygregory: 2) probably, I never cared too much about links :) | 13:05 |
| janders | thank you | 13:05 |
| iurygregory | dtantsur, let me try to be more clear about 1 =) https://review.opendev.org/c/openstack/openstacksdk/+/775878/1/openstack/baremetal_introspection/v1/_proxy.py#207 delete_introspection_rules would be the equivalent for DELETE all, so inside of it we need to have the logic to list all rules and call "delete_introspection_rule" ? | 13:07 |
| iurygregory | hahaha poor links XD | 13:07 |
| dtantsur | iurygregory: no, just DELETE /v1/rules | 13:07 |
| dtantsur | maybe call the function delete_all_introspection_rules for clarity | 13:07 |
| dtantsur | (since most other resources don't have a delete-all call) | 13:07 |
| iurygregory | yeah | 13:07 |
| iurygregory | and should require any parameter | 13:08 |
| iurygregory | thanks for clarifying! | 13:08 |
| rpittau | janders: as dtantsur suggested, constants should suffice | 13:09 |
| janders | dtantsur rpittau where should I put these? in the class (GenericHardwareManager)? method (_nvme_erase)? | 13:10 |
| rpittau | janders: top of the file | 13:10 |
| janders | ok! | 13:10 |
| janders | easy | 13:10 |
| rpittau | :) | 13:10 |
| janders | I started with that but realised that aren't that many there | 13:10 |
| janders | so wasn't sure | 13:10 |
| iurygregory | oh we probably can't just call the _delete from _proxy https://github.com/openstack/openstacksdk/blob/58b28ee59231a53a66f8f5a3b8a5a5e7a3b79704/openstack/proxy.py#L374 since it requires the resource | 13:11 |
| openstackgerrit | OpenStack Release Bot proposed openstack/ironic-python-agent bugfix/6.6: Update .gitreview for bugfix/6.6 https://review.opendev.org/c/openstack/ironic-python-agent/+/776167 | 13:11 |
| dtantsur | iurygregory: yeah, you may need some custom code (or skip this call for now) | 13:13 |
| iurygregory | dtantsur, ack | 13:14 |
| openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 13:18 |
| *** rh-jelabarre has joined #openstack-ironic | 13:19 | |
| openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 13:27 |
| janders | ^ forgot to remove the nvme-cli outputs from samples the first time :) | 13:28 |
| janders | see you tomorrow Ironic o/ | 13:30 |
| rpittau | see ya janders :) | 13:30 |
| janders | closing my five terminal windows and meld with relief after the badass rebase earlier today :) | 13:34 |
| janders | how many more layers of windows before I can see the background? :) | 13:34 |
| rpittau | :D | 13:36 |
| openstackgerrit | Verification of a change to openstack/ironic-inspector failed: Fix memcached host address. https://review.opendev.org/c/openstack/ironic-inspector/+/775640 | 13:38 |
| iurygregory | ussuri is unhappy | 13:42 |
| rpittau | iurygregory: inspector? I think it's a timing issue | 13:42 |
| rpittau | it's quit erratic though | 13:43 |
| rpittau | quite* | 13:43 |
| iurygregory | yeah | 13:43 |
| dtantsur | folks, if someone could check https://review.opendev.org/c/openstack/python-ironicclient/+/775889 and https://review.opendev.org/c/openstack/python-ironicclient/+/775861 we may release python-ironicclient | 13:51 |
| rpittau | did the first and was doing trhe second now | 13:52 |
| *** zaneb has quit IRC | 13:55 | |
| iurygregory | same | 13:58 |
| *** rh-jelabarre has quit IRC | 14:08 | |
| *** rh-jelabarre has joined #openstack-ironic | 14:08 | |
| *** hoonetorg has quit IRC | 14:11 | |
| TheJulia | good morning | 14:12 |
| *** rloo has joined #openstack-ironic | 14:15 | |
| iurygregory | good morning TheJulia | 14:19 |
| openstackgerrit | Merged openstack/ironic-inspector master: Add upgrade check, and json2yaml policy handling https://review.opendev.org/c/openstack/ironic-inspector/+/763286 | 14:37 |
| TheJulia | \o/ | 14:37 |
| iurygregory | \o/ | 14:38 |
| *** hoonetorg has joined #openstack-ironic | 14:42 | |
| dtantsur | morning TheJulia :) | 14:45 |
| *** zzzeek has quit IRC | 14:49 | |
| *** zzzeek has joined #openstack-ironic | 14:50 | |
| *** jhesketh has quit IRC | 14:52 | |
| openstackgerrit | Merged openstack/python-ironicclient master: Clearer error message when unable to parse JSON https://review.opendev.org/c/openstack/python-ironicclient/+/775889 | 15:01 |
| *** ociuhandu has joined #openstack-ironic | 15:01 | |
| *** ociuhandu has quit IRC | 15:05 | |
| *** ociuhandu has joined #openstack-ironic | 15:06 | |
| *** uzumaki has quit IRC | 15:06 | |
| *** bburns has quit IRC | 15:09 | |
| dtantsur | aha, as I expected, configdrive_use_object_store is broken on python 3. yay? | 15:10 |
| * dtantsur fixes | 15:10 | |
| *** bburns has joined #openstack-ironic | 15:11 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-inspector master: Fix node id vs uuid in processing_logger_prefix https://review.opendev.org/c/openstack/ironic-inspector/+/776213 | 15:14 |
| *** ociuhandu has quit IRC | 15:15 | |
| *** ociuhandu has joined #openstack-ironic | 15:16 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Fix broken configdrive_use_object_store https://review.opendev.org/c/openstack/ironic/+/775924 | 15:18 |
| *** ociuhandu_ has joined #openstack-ironic | 15:19 | |
| *** ociuhandu_ has quit IRC | 15:19 | |
| *** ociuhandu_ has joined #openstack-ironic | 15:20 | |
| *** k_mouza has quit IRC | 15:20 | |
| *** ociuhandu has quit IRC | 15:21 | |
| * iurygregory brb lunch time | 15:21 | |
| *** anuradha1904 has quit IRC | 15:35 | |
| JayF | dtantsur: I looked at that deploy steps thing again, and I was just wrong. I'll go update the PR to say just that. Somehow, I had it stuck in my mind that you could run *any* HW manager method as a clean step | 15:42 |
| JayF | which is obviously not how it works, but I can't explain why I had that in my head yesterday /o\ | 15:42 |
| dtantsur | heh, no worries, you missed my patch this morning fixing the Debian version I had previously put it | 15:43 |
| dtantsur | for some reason I thought Debian Buster was 9 :) | 15:43 |
| * iurygregory back | 15:46 | |
| *** uzumaki has joined #openstack-ironic | 15:48 | |
| openstackgerrit | Merged openstack/ironic-python-agent stable/victoria: Fixes local boot for partition images https://review.opendev.org/c/openstack/ironic-python-agent/+/775914 | 15:50 |
| openstackgerrit | Merged openstack/python-ironicclient master: Support YAML files wherever JSON files are accepted https://review.opendev.org/c/openstack/python-ironicclient/+/775861 | 15:51 |
| dtantsur | iurygregory: if you by change have a second for the release ^^ | 15:51 |
| openstackgerrit | Merged openstack/ironic-python-agent bugfix/6.6: Update .gitreview for bugfix/6.6 https://review.opendev.org/c/openstack/ironic-python-agent/+/776167 | 15:52 |
| iurygregory | dtantsur, totally, this would be stable/wallaby ? | 15:52 |
| dtantsur | iurygregory: not yet. we have a couple of weeks more. | 15:52 |
| dtantsur | I just want to get --deploy-steps out together with the ironic release that supports it | 15:53 |
| iurygregory | oh ok =) (for some reason I had in my mind clients are in the deadline XD) | 15:53 |
| dtantsur | non-client libraries (sushy, ironic-lib) come first | 15:53 |
| iurygregory | 4.6.0 on the way | 15:59 |
| iurygregory | I love the 30s wait | 16:00 |
| iurygregory | dtantsur, https://review.opendev.org/c/openstack/releases/+/776222 | 16:00 |
| dtantsur | thanks! | 16:03 |
| openstackgerrit | Aija Jauntēva proposed x/sushy-oem-idrac master: Add Real time status check to Lifecycle service https://review.opendev.org/c/x/sushy-oem-idrac/+/776224 | 16:08 |
| iurygregory | yw =) | 16:10 |
| *** k_mouza has joined #openstack-ironic | 16:14 | |
| *** moshiur has quit IRC | 16:25 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-inspector master: Fix node id vs uuid in processing_logger_prefix https://review.opendev.org/c/openstack/ironic-inspector/+/776213 | 16:43 |
| rpittau | TheJulia: hi! Did you see my question on https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775884? was dependencies removed on purpose from the tinyipa makefile all entry? | 16:52 |
| dtantsur | a request for stable reviews: https://review.opendev.org/c/openstack/ironic/+/774409 | 16:55 |
| *** rcernin has joined #openstack-ironic | 16:58 | |
| *** ociuhandu_ has quit IRC | 17:02 | |
| *** rcernin has quit IRC | 17:02 | |
| *** ociuhandu has joined #openstack-ironic | 17:02 | |
| *** lucasagomes has quit IRC | 17:03 | |
| dtantsur | mm, tinycore 12 http://forum.tinycorelinux.net/index.php/topic,24798.0.html | 17:12 |
| rpittau | mmmmmm | 17:12 |
| rpittau | they still have some issues with the repo | 17:14 |
| *** dtantsur is now known as dtantsur|afk | 17:17 | |
| dtantsur|afk | o/ | 17:17 |
| TheJulia | rpittau: whoops | 17:19 |
| TheJulia | I didn't mean to remove deps | 17:19 |
| rpittau | TheJulia: ok, I can re-add it or you got it ? | 17:20 |
| TheJulia | posting now | 17:21 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent-builder master: Fix Makefile from accidential change https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/776244 | 17:23 |
| rpittau | JayF was too fast :D | 17:25 |
| JayF | I get email notifications for any patch posted to IPA-builder | 17:25 |
| JayF | and it happened to land in my inbox while I was checking mail | 17:26 |
| JayF | plus felt a pang of guilt for seeing that when I revivewed the change that caused it and assuming it was intentional instead of asking | 17:26 |
| rpittau | :D | 17:26 |
| JayF | unrelated: is stackalytics busted? It seems like https://www.stackalytics.com/report/contribution/ironic-group/30 isn't populated with new info | 17:27 |
| rpittau | oh yeah, I noticed that too | 17:28 |
| rpittau | seems like the latest update was done around mid january | 17:29 |
| TheJulia | There was an email thread that somethign was broken last month | 17:29 |
| JayF | I think someone said stackalytics.io should work | 17:29 |
| JayF | going to try that | 17:29 |
| rpittau | if you look at the main page you'll see the banner | 17:29 |
| rpittau | spoiler alert: that works :) | 17:30 |
| JayF | they don't have /report in stackalytics.io | 17:30 |
| JayF | that's kinda lame, but beggars can't be choosers | 17:30 |
| rpittau | the main page works fine for me, but yeah missing that | 17:32 |
| *** dougsz has quit IRC | 17:32 | |
| rpittau | good night! o/ | 17:41 |
| *** rpittau is now known as rpittau|afk | 17:41 | |
| *** gyee has joined #openstack-ironic | 17:43 | |
| *** ociuhandu has quit IRC | 17:54 | |
| TheJulia | stevebaker: yeah, if the parent is set at all, we need to override the node option/search and do policy checks based up on it :\ | 18:10 |
| *** derekh has quit IRC | 18:11 | |
| *** lmcgann has joined #openstack-ironic | 18:13 | |
| *** k_mouza has quit IRC | 18:14 | |
| *** anuradha1904 has joined #openstack-ironic | 18:45 | |
| openstackgerrit | Verification of a change to openstack/ironic failed: Prevent redfish-virtual-media from being used with Dell nodes https://review.opendev.org/c/openstack/ironic/+/774409 | 18:58 |
| *** tosin has quit IRC | 19:19 | |
| stevebaker | TheJulia: ah so its a genuine policy enforcement bug! | 19:44 |
| *** uzumaki has quit IRC | 19:59 | |
| TheJulia | stevebaker: no, more our style of delaying the use to far after checking | 20:04 |
| TheJulia | so we have to move policy checking way upfront on things | 20:05 |
| TheJulia | the _get_x_collections code has all of the parent handling to auto-constrain things | 20:05 |
| TheJulia | but... that is way too late to properly go "oh, you shouldn't be able to see this parent object. | 20:05 |
| TheJulia | " | 20:05 |
| stevebaker | i see | 20:05 |
| TheJulia | I need to head to the ford dealer to pickup my care ina few, but I'll get back to it a little later | 20:06 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP: port/portgroup project scoped access https://review.opendev.org/c/openstack/ironic/+/775465 | 20:07 |
| TheJulia | you can kind of see the direction I'm heading there | 20:07 |
| TheJulia | It involves extra db calls to handle the enforcement... which makes me think I'm going to be spending time on database performance soon() | 20:08 |
| TheJulia | luckily typical usage doesn't get those level of calls | 20:08 |
| TheJulia | I can has a "resource subcontrollers are evil" shirt? | 20:25 |
| iurygregory | ++ for the shirt | 20:31 |
| JayF | rpittau|afk: TheJulia closing the loop on previous chat: I emailed the list, it works, URL has changed: https://www.stackalytics.io/report/contribution?module=ironic-group&project_type=openstack&days=90 | 20:53 |
| *** rcernin has joined #openstack-ironic | 20:58 | |
| *** rcernin has quit IRC | 21:03 | |
| *** bfournie has quit IRC | 21:07 | |
| openstackgerrit | Merged openstack/ironic-python-agent-builder master: Fix Makefile from accidential change https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/776244 | 21:12 |
| *** rcernin has joined #openstack-ironic | 21:22 | |
| *** eandersson has quit IRC | 21:40 | |
| *** ccstone has quit IRC | 21:40 | |
| *** hoonetorg has quit IRC | 21:49 | |
| *** gmann is now known as gmann_afk | 21:51 | |
| *** rcernin has quit IRC | 21:53 | |
| *** rcernin has joined #openstack-ironic | 22:00 | |
| TheJulia | JayF: thanks | 22:07 |
| TheJulia | stevebaker: any thoughts on https://review.opendev.org/c/openstack/ironic/+/773924/8/ironic/conf/api.py I'm wondering if I should be using that in the portgroup controller | 22:07 |
| TheJulia | I guess it makes sense to... over sixty failing tests | 22:08 |
| JayF | Bluntly, I don't think there's any other security-hole-closure that we'd hide behind a config. | 22:10 |
| JayF | If it gets backported; config and default-off makes sense, for the tip of master, I don't think it's a good idea | 22:11 |
| stevebaker | TheJulia: what if we changed behaviour to just raise 404? We don't document in the API when a 403 is raised. And if there is a developer out there who codes for specific 40x errors then I'm yet to meet them ;) | 22:11 |
| TheJulia | I feel a lot better just returning 404 | 22:12 |
| TheJulia | because, to their perception of the universe, the thing just doesn't exist | 22:12 |
| JayF | Yep, exactly. | 22:12 |
| stevebaker | +1 | 22:12 |
| JayF | And exposing that it exists is a security concern | 22:12 |
| TheJulia | it is like "there is a microwormhole over in the corner, you can't see it to pet it, and you'll never cross-paths" | 22:12 |
| TheJulia | yup | 22:13 |
| * TheJulia will just go update tests and make sure there is a giant reno | 22:13 | |
| JayF | that config-based approach is +1 from me *for backports only* to avoid changing behavior in a stable branch ... but I find it tough to imagine backporting all this RBAC stuff in general | 22:13 |
| TheJulia | fwiw, it is feature work, so we'd never backport this | 22:13 |
| TheJulia | and if there is agreement there, I can nuke the config option in my next re-stack and lean towards 404s | 22:13 |
| stevebaker | Also there is precedent for error codes changing in the WSME removal series *cough* https://review.opendev.org/c/openstack/ironic/+/747820/22/ironic/tests/unit/api/controllers/v1/test_node.py#b4248 | 22:13 |
| JayF | I could see a (strained) excuse for backporting it as a security improvement | 22:14 |
| stevebaker | ... due to the quirks in pecan request routing | 22:14 |
| TheJulia | JayF: true | 22:14 |
| TheJulia | stevebaker: I know nothing about that ;) | 22:14 |
| *** jhesketh has joined #openstack-ironic | 22:32 | |
| TheJulia | The plus side of all of the extra tests, I can see i have an issue someplace to still hunt down | 22:34 |
| stevebaker | it is good test coverage to have, yes | 22:43 |
| stevebaker | TheJulia: progress! http://paste.openstack.org/show/802757/ | 22:50 |
| TheJulia | \o/ | 22:51 |
| JayF | I wasn't aware Ironic even had a feature like that | 22:56 |
| *** gmann_afk is now known as gmann | 23:22 | |
| *** anuradha1904 has quit IRC | 23:23 | |
| stevebaker | JayF: the spec just needs a bit of finishing off (REST API and CLI) https://specs.openstack.org/openstack/ironic-specs/specs/15.0/expose-hardware-indicators.html#openstack-baremetal-cli | 23:27 |
| JayF | this is a cool feature; we used this (via IPMI commands directly) all the time at rackspace | 23:28 |
| JayF | 'do thing X to the machine with the flashing yellow light' | 23:28 |
| TheJulia | We did it for operators to be able to find a troublesome node | 23:37 |
| TheJulia | just, I guess we never wrapped things up :( | 23:37 |
| TheJulia | so, just going the 404 route actually makes the code cleaner | 23:38 |
| TheJulia | I think | 23:38 |
| *** alexmcleod has quit IRC | 23:45 | |
| janders | good morning Ironic o/ | 23:46 |
| JayF | o/ | 23:47 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!