janders | good morning Ironic o/ | 00:04 |
---|---|---|
janders | stevebaker that's great work and great news - I will try to test it later today - thanks! | 00:06 |
stevebaker | janders: let me know how you go | 00:07 |
janders | stevebaker will do. The manual fix I've come up with on Friday was identical to https://review.opendev.org/c/openstack/diskimage-builder/+/779107/2/diskimage_builder/elements/bootloader/finalise.d/50-bootloader#219 in your patch so I am confident this will work; I will add a review after I tested this. Is there anything I need to know about i/r/t | 00:11 |
janders | running patched DIB, or can I just checkout the change and put DIB from the change earlier in my path? | 00:11 |
iurygregory | morning stevebaker janders =) | 00:16 |
*** zzzeek has quit IRC | 00:17 | |
*** zzzeek has joined #openstack-ironic | 00:18 | |
stevebaker | iurygregory: hey | 00:19 |
stevebaker | janders: I have a venv for dib, so I just pip install whenever I want to test a change | 00:21 |
janders | hey iurygregory o/ | 00:36 |
*** tosky has quit IRC | 00:42 | |
*** ricolin has quit IRC | 00:46 | |
janders | stevebaker pip install directly from a gerrit change - slick! thanks for the hint. | 00:49 |
*** ricolin has joined #openstack-ironic | 00:50 | |
*** benj_ has joined #openstack-ironic | 00:55 | |
*** benj_ has quit IRC | 01:01 | |
*** benj_ has joined #openstack-ironic | 01:02 | |
*** rcernin has quit IRC | 01:12 | |
*** rcernin_ has joined #openstack-ironic | 01:12 | |
*** benj_ has quit IRC | 01:17 | |
*** benj_ has joined #openstack-ironic | 01:17 | |
janders | stevebaker got this on first attempt https://pasteboard.co/JRAJbp2.png will hand-boot the image and see what got deployed | 01:33 |
stevebaker | janders: is this deployed with bifrost? | 01:35 |
janders | stevebaker yes | 01:35 |
janders | first I will see if the image has the GRUB config that your change creates - maybe I mixed something up | 01:35 |
stevebaker | I wonder if ipa isn't running efibootmgr. If you can boot something and run efibootmgr -v there should be an entry called 'ironic1' | 01:37 |
janders | http://paste.openstack.org/show/803320/ | 01:37 |
janders | efibootmgr output looks good to me, but the grub config isn't there - looking why | 01:38 |
stevebaker | it should be in /boot/efi/EFI/redhat/grub.cfg | 01:38 |
stevebaker | wait | 01:39 |
stevebaker | it should be in /boot/efi/EFI/centos/grub.cfg | 01:39 |
janders | yeah - and it isn't - which makes me think I need to check if I am building the image the right way (maybe due to some mistake I haven't used your patch properly) | 01:39 |
stevebaker | janders: setting export DIB_DEBUG_TRACE=1 will show what commands are actually run, its noisy though | 01:44 |
janders | I will re-generate the image and see if the file is inside, if not I will record the steps (with the above on) and run it by you | 01:44 |
janders | maybe I did something silly like activating the venv in one terminal and then getting distracted and running the image build in another terminal | 01:45 |
stevebaker | janders: also if you're running sudo disk-image-create you're not in a venv at all | 01:45 |
janders | stevebaker I am not - however it does ask me for password for sudo. Not sure what for (was assuming mounting loopback or something). Can this be causing the problem? | 01:46 |
janders | stevebaker I will uninstall the OS DIB to minimise potential for confusion | 01:47 |
stevebaker | there is a bunch of tasks inside which require sudo. I gave up on running it as non-root because there were cases which were assuming passwordless sudo and swallowing stdin. now I've got a shell script which activates the venv, sets env vars, then runs disk-image-create. I run that script as sudo | 01:49 |
janders | stevebaker nice! I've got the image build running, after it's done I will see if it has the grub config in the right place and we'll take it from there | 01:51 |
janders | stevebaker I re-ran the build and the file still isn't there. Here's some validation of my environment: http://paste.openstack.org/show/803321/ have a look and let me know if you see any obvious issues. | 01:59 |
janders | stevebaker If it's likely setup okay, just hitting weird issues that will go away when the patch merges, maybe I could ask you to build the image in your environment and upload it to the bifrost machine? | 01:59 |
janders | (sudo issues in my pip/venv setup may not be worth troubleshooting) | 02:00 |
openstackgerrit | Rotan proposed openstack/ironic-inspector master: [WIP]Support AEP, sst at introspection data https://review.opendev.org/c/openstack/ironic-inspector/+/768138 | 02:06 |
*** benj_ has quit IRC | 02:06 | |
*** benj_ has joined #openstack-ironic | 02:07 | |
*** k_mouza has joined #openstack-ironic | 02:15 | |
*** k_mouza has quit IRC | 02:19 | |
*** rh-jelabarre has joined #openstack-ironic | 02:21 | |
*** rh-jelabarre has quit IRC | 02:43 | |
*** zzzeek has quit IRC | 02:44 | |
*** zzzeek has joined #openstack-ironic | 02:47 | |
stevebaker | janders: the actual 50-bootloader its executing is probably ~/venv/dib/lib/python3.9/site-packages/diskimage_builder/elements/bootloader/finalise.d/50-bootloader | 02:53 |
stevebaker | I think ELEMENTS_PATH is not searched for the core elements | 02:53 |
janders | stevebaker I have ~/venv/dib/lib/python3.9/site-packages/diskimage-builder.egg-link which contains a single line (/home/janders/venv/dib/src/diskimage-builder) - I suppose that's making it work | 02:56 |
janders | (or - I should say - run - cause it doesn't quite work yet :) | 02:56 |
stevebaker | janders: ah, devmode pip install. I'm not sure if that plays nice with elements since they're not real python files | 02:57 |
janders | stevebaker would it make sense to try build the image in your environment? | 03:01 |
stevebaker | janders: yeah I could give it a crack, send me your build instructions | 03:02 |
janders | stevebaker ok! | 03:02 |
*** zzzeek has quit IRC | 03:10 | |
*** zzzeek has joined #openstack-ironic | 03:12 | |
*** rcernin_ has quit IRC | 03:14 | |
openstackgerrit | Merged openstack/ironic master: Allow instance_info to override node interface https://review.opendev.org/c/openstack/ironic/+/777434 | 03:19 |
*** rcernin_ has joined #openstack-ironic | 03:21 | |
*** jamesdenton has quit IRC | 03:58 | |
*** jamesden_ has joined #openstack-ironic | 03:58 | |
*** zzzeek has quit IRC | 04:02 | |
*** zzzeek has joined #openstack-ironic | 04:04 | |
*** k_mouza has joined #openstack-ironic | 04:50 | |
*** k_mouza has quit IRC | 04:55 | |
*** zzzeek has quit IRC | 05:26 | |
*** anuradha1904 has joined #openstack-ironic | 05:28 | |
*** zzzeek has joined #openstack-ironic | 05:29 | |
*** k_mouza has joined #openstack-ironic | 05:42 | |
*** k_mouza has quit IRC | 05:47 | |
*** zzzeek has quit IRC | 06:03 | |
*** zzzeek has joined #openstack-ironic | 06:05 | |
*** moshiur has joined #openstack-ironic | 06:59 | |
*** rcernin_ has quit IRC | 07:14 | |
openstackgerrit | Steve Baker proposed openstack/sushy master: Ensure Content-Type header is set when required https://review.opendev.org/c/openstack/sushy/+/779164 | 07:28 |
*** sshnaidm has quit IRC | 07:41 | |
*** k_mouza has joined #openstack-ironic | 07:43 | |
*** k_mouza has quit IRC | 07:48 | |
*** sshnaidm has joined #openstack-ironic | 08:01 | |
arne_wiebalck | Good morning, ironic! | 08:03 |
stevebaker | good evening! | 08:03 |
*** rpittau|afk is now known as rpittau | 08:23 | |
rpittau | good morning ironic! o/ | 08:23 |
*** tosky has joined #openstack-ironic | 08:34 | |
*** lucasagomes has joined #openstack-ironic | 08:57 | |
*** dougsz has joined #openstack-ironic | 09:00 | |
openstackgerrit | sonali bhausaheb borkar proposed x/sushy-oem-idrac master: Add export system configuration https://review.opendev.org/c/x/sushy-oem-idrac/+/710327 | 09:02 |
openstackgerrit | sonali bhausaheb borkar proposed openstack/ironic master: DRAC : idrac-redfish inspect updates pxe port https://review.opendev.org/c/openstack/ironic/+/693328 | 09:04 |
rpittau | tinyipa with tinycore 12 is GREEN \o/ https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/776587 | 09:19 |
*** derekh has joined #openstack-ironic | 09:22 | |
*** ociuhandu has joined #openstack-ironic | 09:27 | |
*** k_mouza has joined #openstack-ironic | 09:37 | |
*** k_mouza has quit IRC | 09:42 | |
*** ociuhandu has quit IRC | 09:44 | |
*** ociuhandu has joined #openstack-ironic | 09:44 | |
*** ociuhandu has quit IRC | 09:50 | |
*** ociuhandu has joined #openstack-ironic | 09:51 | |
*** frigo has joined #openstack-ironic | 09:56 | |
*** k_mouza has joined #openstack-ironic | 09:58 | |
openstackgerrit | Merged openstack/ironic master: Revert "Update iDRAC doc with missing interfaces" https://review.opendev.org/c/openstack/ironic/+/778835 | 10:09 |
*** mugsie__ is now known as mugsie | 10:11 | |
janders | good morning arne_wiebalck and rpittau | 10:23 |
rpittau | hey janders :) | 10:24 |
*** frigo has quit IRC | 10:25 | |
*** frigo has joined #openstack-ironic | 10:30 | |
arne_wiebalck | hey janders o/ | 10:33 |
openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Add Redfish RAID interface to idrac HW type https://review.opendev.org/c/openstack/ironic/+/774433 | 10:36 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: [WIP] Update dev quickstart docs https://review.opendev.org/c/openstack/ironic/+/779206 | 10:49 |
*** ociuhandu has quit IRC | 11:04 | |
openstackgerrit | Moshiur Rahman proposed openstack/ironic-python-agent-builder master: Fix: IPA image building with OpenSuse. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778726 | 11:05 |
*** ociuhandu has joined #openstack-ironic | 11:06 | |
openstackgerrit | Moshiur Rahman proposed openstack/ironic-python-agent-builder master: Fix: IPA image building with OpenSuse. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778726 | 11:09 |
iurygregory | good morning Ironic | 11:09 |
dtantsur | good morning ironic | 11:10 |
*** ociuhandu has quit IRC | 11:10 | |
* dtantsur declares a scrollback bankruptcy | 11:12 | |
rpittau | hey iurygregory and dtantsur :) | 11:16 |
openstackgerrit | Moshiur Rahman proposed openstack/ironic-python-agent-builder master: Fix: IPA image building with OpenSuse. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778726 | 11:19 |
*** frigo has quit IRC | 11:20 | |
iurygregory | o/ | 11:20 |
openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Update iDRAC doc on Redfish vendor passthru interface https://review.opendev.org/c/openstack/ironic/+/779221 | 11:23 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent stable/victoria: Increase the memory limit for qemu-img https://review.opendev.org/c/openstack/ironic-python-agent/+/779147 | 11:23 |
dtantsur | folks, don't forget to cherry-pick any fixes! | 11:23 |
dtantsur | at least to stable/victoria, so that we have at least one stable releases with all bug fixes included | 11:23 |
openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Update iDRAC doc with idrac-redfish-virtual-media https://review.opendev.org/c/openstack/ironic/+/779222 | 11:24 |
rpittau | to be honest I thought that was under discussion if backporting it or not to victoria, I probably misunderstood | 11:25 |
*** derekh has quit IRC | 11:25 | |
openstackgerrit | Moshiur Rahman proposed openstack/ironic-python-agent-builder master: Fix: IPA image building with OpenSuse. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778726 | 11:26 |
*** derekh has joined #openstack-ironic | 11:27 | |
*** ociuhandu has joined #openstack-ironic | 11:36 | |
dtantsur | rpittau: if it breaks people, it should be backported (and 2G is not a lot for a real bare metal machine) | 11:37 |
* dtantsur looks at his email backlog in despair | 11:39 | |
dtantsur | is there anything requiring my urgent attention? | 11:39 |
*** ociuhandu has quit IRC | 11:47 | |
*** frigo has joined #openstack-ironic | 11:47 | |
iurygregory | dtantsur, nothing I'm aware | 11:50 |
janders | good morning dtantsur o/ | 11:53 |
janders | how was your break? | 11:53 |
dtantsur | well.. I blinked a few times, and it was over :( | 11:53 |
janders | :( | 11:54 |
janders | Ironic cores - looking for the second +2 for this doco patch so that we can close off NVMe cleaning work: https://review.opendev.org/c/openstack/ironic/+/778134 thanks! :0 | 11:56 |
janders | :) | 11:56 |
*** ociuhandu has joined #openstack-ironic | 11:56 | |
*** ociuhandu has quit IRC | 11:56 | |
iurygregory | looking now | 11:56 |
janders | thank you iurygregory! :) | 11:57 |
*** ociuhandu has joined #openstack-ironic | 11:58 | |
*** ociuhandu has quit IRC | 11:58 | |
*** ociuhandu has joined #openstack-ironic | 11:58 | |
*** ociuhandu has quit IRC | 11:58 | |
*** ociuhandu has joined #openstack-ironic | 12:00 | |
iurygregory | one hour gerrit will apply the change hehe | 12:00 |
*** frigo has quit IRC | 12:00 | |
*** frigo has joined #openstack-ironic | 12:00 | |
janders | thank you iurygregory! :) | 12:01 |
*** ociuhandu has quit IRC | 12:06 | |
*** ociuhandu has joined #openstack-ironic | 12:13 | |
frigo | good afternoon Ironic:) I was looking at https://docs.openstack.org/ironic/latest/install/advanced.html#appending-kernel-parameters-to-boot-instances | 12:18 |
frigo | and wondering if we could not use the UEFI boot manager and just, use that to call the Linux kernel and provide options (something like efibootmgr... -u initrd=.. root=..), since the IPA already creates an "Ironic1" entry as discussed above. Could it be a clean option to specify custom kernel arguments? (also I don't know if it is the right place | 12:18 |
frigo | to get feedback on this kind of idea) | 12:18 |
*** outbrito has joined #openstack-ironic | 12:21 | |
*** ociuhandu has quit IRC | 12:22 | |
openstackgerrit | Merged openstack/ironic master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic/+/778134 | 12:24 |
*** iurygregory has quit IRC | 12:46 | |
*** bburns has quit IRC | 12:48 | |
*** bburns has joined #openstack-ironic | 12:50 | |
*** ociuhandu has joined #openstack-ironic | 12:52 | |
TheJulia | frigo: so efibootmgr just updates the system nvram | 12:54 |
TheJulia | so the system basically tends to chain from EFI Firmware -> efi bootloader ([shim -> grub typically) -> OS | 12:55 |
*** ociuhandu has quit IRC | 12:56 | |
frigo | I was thinking of doing EFI Firmware -> OS, but I realize now secureboot might get more tricky | 13:05 |
*** frigo has quit IRC | 13:10 | |
janders | see you tomorrow Ironic o/ | 13:18 |
TheJulia | yeah, the OS would need to grok how to wind down the EFI interface | 13:24 |
TheJulia | I *think* the linux kernel can | 13:24 |
TheJulia | but yeah, command line vars are a issue there | 13:24 |
dtantsur | morning TheJulia | 13:25 |
TheJulia | Good morning! | 13:25 |
*** frigo has joined #openstack-ironic | 13:26 | |
*** ociuhandu has joined #openstack-ironic | 13:29 | |
*** ociuhandu has quit IRC | 13:34 | |
*** ociuhandu has joined #openstack-ironic | 13:39 | |
*** frigo78 has joined #openstack-ironic | 13:41 | |
*** rh-jelabarre has joined #openstack-ironic | 13:41 | |
*** frigo has quit IRC | 13:42 | |
*** frigo78 is now known as frigo | 13:42 | |
frigo | if we assume both initrd and kernel are in the EFI partition, and the kernel is built with the CONFIG_EFI_STUB option, and that the firmware actually knows how to pass command parameters (which seems ok with iDRAC and iLO afaict), and that the kernel is signed with a key known by the firmware (and not the boot loader- lots of assumptions) and we | 13:45 |
*** rh-jelabarre has quit IRC | 13:45 | |
frigo | have a way to pass the cmdline into the IPA | 13:45 |
frigo | then we can have the IPA call efibootmgr with the vmlinuz.efi and the cmdline. Trivial! | 13:45 |
TheJulia | I don't think you can provide the command line that way | 13:51 |
TheJulia | at least, from the man page of efibootmgr | 13:51 |
*** rh-jelabarre has joined #openstack-ironic | 13:52 | |
dtantsur | yeah, I'm not sure UEFI has a notion of a command line | 13:58 |
TheJulia | So, there *is* a notion for UEFI http network booting | 13:58 |
dtantsur | and yes, secure boot will be problematic. I think shim is only able to load grub, without shim you need your own keys. | 13:58 |
TheJulia | err | 13:58 |
TheJulia | you can pass a command line through as a field value in dhcp, however I never found anything that actually implements that. | 13:59 |
frigo | oh it does, the man page is wrong :D | 13:59 |
TheJulia | https://meetpad.opendev.org/ironic | 14:00 |
TheJulia | The Review Jam starts :) | 14:00 |
frigo | it looks like -u "initrd=\EFI\... root=..." | 14:00 |
*** mnaser has quit IRC | 14:03 | |
*** mnaser has joined #openstack-ironic | 14:03 | |
*** mnaser has quit IRC | 14:03 | |
*** mnaser has joined #openstack-ironic | 14:03 | |
*** frigo65 has joined #openstack-ironic | 14:03 | |
*** frigo has quit IRC | 14:03 | |
*** frigo65 is now known as frigo | 14:03 | |
*** rloo has joined #openstack-ironic | 14:06 | |
*** moshiur has quit IRC | 14:32 | |
*** tzumainn has joined #openstack-ironic | 14:34 | |
*** moshiur has joined #openstack-ironic | 14:43 | |
*** Qianbiao has joined #openstack-ironic | 14:46 | |
TheJulia | Hmm | 14:48 |
TheJulia | Interesting | 14:48 |
*** kaifeng has joined #openstack-ironic | 14:55 | |
*** lmcgann has joined #openstack-ironic | 14:58 | |
*** stendulker has joined #openstack-ironic | 14:59 | |
TheJulia | #startmeeting ironic | 15:00 |
openstack | Meeting started Mon Mar 8 15:00:20 2021 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
TheJulia | o/ | 15:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
*** openstack changes topic to " (Meeting topic: ironic)" | 15:00 | |
openstack | The meeting name has been set to 'ironic' | 15:00 |
TheJulia | Good morning Ironic! | 15:00 |
stendulker | o/ | 15:00 |
erbarr | o/ | 15:00 |
rpioso | \o | 15:00 |
bfournie | o/ | 15:00 |
kaifeng | o/ | 15:00 |
bdodd | o/ | 15:00 |
arne_wiebalck | o/ | 15:00 |
ajya | o/ | 15:00 |
rloo | o/ | 15:00 |
rpittau | o/ | 15:01 |
TheJulia | Our agenda can be found on the wiki, as always. | 15:01 |
TheJulia | #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting | 15:01 |
TheJulia | #topic Announcements / Reminders | 15:01 |
*** openstack changes topic to "Announcements / Reminders (Meeting topic: ironic)" | 15:01 | |
TheJulia | #info This week is R-5 for the OpenStack Wallaby release, meaning final library releases and requirements freeze. | 15:02 |
TheJulia | #info The PTG has been announced to be on April 19th through April 23rd. | 15:02 |
TheJulia | #link https://april2021-ptg.eventbrite.com/ | 15:02 |
TheJulia | Please remember to register soon, and let us know if you will be attending. | 15:02 |
TheJulia | #info In relation to the upcoming PTG, an etherpad has been started. Please feel free to post ideas/topics for discussion. | 15:03 |
TheJulia | #link https://etherpad.opendev.org/p/ironic-xena-ptg | 15:03 |
TheJulia | One final note | 15:03 |
TheJulia | #info If anyone is interested, the TC/PTL Election candidacy submission window is open through March 9th at 23:45 UTC. | 15:04 |
TheJulia | Does anyone else have any announcements they would like to make? Anything to remind us of? | 15:05 |
* dtantsur does not | 15:05 | |
* TheJulia hears crickets | 15:06 | |
dtantsur | oh, we need cycle highlights | 15:06 |
dtantsur | FYI TheJulia ^^ | 15:06 |
TheJulia | dtantsur: oh! right | 15:06 |
TheJulia | When are they due? | 15:07 |
dtantsur | this week I think? | 15:07 |
dtantsur | yep, March 12th | 15:07 |
TheJulia | Okay, I've added it to my calendar | 15:07 |
TheJulia | Thanks for the reminder! | 15:07 |
*** derekh has quit IRC | 15:08 | |
TheJulia | Looks like we had no action items from last week | 15:08 |
TheJulia | Onward! | 15:09 |
TheJulia | #topic Review subteam status reports | 15:09 |
*** openstack changes topic to "Review subteam status reports (Meeting topic: ironic)" | 15:09 | |
TheJulia | #link https://etherpad.openstack.org/p/IronicWhiteBoard | 15:09 |
TheJulia | So privsep is definitely moving to Xena | 15:11 |
rpittau | nvme secure erase is all done | 15:12 |
TheJulia | yup | 15:13 |
dtantsur | very nice | 15:14 |
dtantsur | I hope we can finish redfish RAID this cycle | 15:14 |
TheJulia | I know it is early for zer0c00l, but I expect if his second patch can get revised there may be a possibility of getting that landed this cycle as well. | 15:14 |
TheJulia | dtantsur: sooooo close :) | 15:14 |
TheJulia | rpioso: any update on interop profiles? | 15:15 |
rpioso | TheJuliia: No change | 15:16 |
openstackgerrit | Merged openstack/ironic-python-agent stable/victoria: Increase the memory limit for qemu-img https://review.opendev.org/c/openstack/ironic-python-agent/+/779147 | 15:16 |
* rpioso had copied & pasted the date from last Monday | 15:16 | |
TheJulia | Okay then, are we good to proceed? | 15:17 |
rpittau | yup | 15:17 |
*** moshiur has quit IRC | 15:18 | |
dtantsur | ++ | 15:18 |
TheJulia | #topic Deciding on priorities for the coming week | 15:18 |
*** openstack changes topic to "Deciding on priorities for the coming week (Meeting topic: ironic)" | 15:18 | |
*** zzzeek has quit IRC | 15:19 | |
TheJulia | We've got https://review.opendev.org/q/status:open+hashtag:ironic-week-prio | 15:19 |
TheJulia | And a starting to shrink section on the etherpad | 15:20 |
TheJulia | #link https://review.opendev.org/q/status:open+hashtag:ironic-week-prio | 15:20 |
TheJulia | #link https://etherpad.opendev.org/p/IronicWhiteBoard starting around line 130 | 15:20 |
*** zzzeek has joined #openstack-ironic | 15:21 | |
TheJulia | Is there anything not listed on either list that people wish to propose to add? | 15:22 |
TheJulia | dtantsur: w/r/t the ironic lib fix you posted last week, I guess we're stuck until that hits requirements? | 15:25 |
dtantsur | well, I've reverted the requirements bump to 4.6.0 | 15:25 |
dtantsur | so we're testing with 4.5.0 until 4.6.1 is out and hits requirements | 15:25 |
TheJulia | okay | 15:25 |
TheJulia | at which point I take it we'll block 4.6.0 ? | 15:25 |
dtantsur | 4.6.0 is blocked https://review.opendev.org/c/openstack/requirements/+/778691 we may update our requirements.txt to sync it | 15:27 |
TheJulia | Do you know when the revert applied? | 15:27 |
TheJulia | okay, thanks | 15:27 |
TheJulia | That gives me the information I needed! | 15:27 |
TheJulia | Does anyone have anything they would like to propose for review priorities for the week before we move on? | 15:27 |
* TheJulia hears end of cycle crickets | 15:28 | |
rpittau | crickets FTW | 15:29 |
* dtantsur agrees from inside a pile of emails | 15:29 | |
TheJulia | Since we have no direct discussion topics, We'll take a stop over at the SIG | 15:29 |
TheJulia | #topic Baremetal SIG | 15:30 |
*** openstack changes topic to "Baremetal SIG (Meeting topic: ironic)" | 15:30 | |
TheJulia | #info Next Session is *Tomorrow*, March 9th at 2PMUTC | 15:30 |
TheJulia | iurygregory will be covering the Ironic Prometheus Exporter, and the session will try and gather input for the PTG topics. | 15:30 |
TheJulia | #link https://etherpad.opendev.org/p/bare-metal-sig | 15:31 |
TheJulia | Moving on! | 15:31 |
TheJulia | #topic Open Discussion | 15:31 |
*** openstack changes topic to "Open Discussion (Meeting topic: ironic)" | 15:31 | |
TheJulia | Does anyone have anything they would like to discuss? Zebras perhaps? | 15:31 |
ajya | no zebras :( | 15:32 |
erbarr | hi, I'd like to see if it would be okay to remove the Dell CI account from the Third-Party CI gerrit group | 15:32 |
dtantsur | Žebras are tasty :) | 15:32 |
ajya | anyone tried virtual media boot within devstack environment recently? IPA stuck at grub command line | 15:32 |
TheJulia | wait, what!?! | 15:32 |
erbarr | that would make it so that it sends emails to reviewers when it adds results as a comment | 15:32 |
TheJulia | dtantsur: you worry me :) | 15:32 |
rpittau | if they're like horses they do are tasty | 15:33 |
dtantsur | TheJulia: note Žebra vs Zebra ;) | 15:33 |
TheJulia | dtantsur: heh | 15:33 |
dtantsur | (the former is "ribs" in Czech) | 15:33 |
dtantsur | ajya: only on bifrost | 15:33 |
rloo | is this backportable? can't decide if it is a bug or a feature (and good for folks to know about this): https://review.opendev.org/c/openstack/ironic/+/776930 | 15:33 |
dtantsur | ajya: are you sure it's stuck? maybe it just doesn't output anything? | 15:33 |
TheJulia | erbarr: I'm not a fan of more email because I'm at the point where CI emails are all noise for me, so I'm kind of against the idea, but if others want it I can hapilly add antoerh mailbox rule | 15:33 |
TheJulia | rloo: should be backportable | 15:34 |
rloo | thx TheJulia! | 15:34 |
rpioso | TheJulia: Should we be consistent across our third party CIs? | 15:34 |
dtantsur | rloo: ++ to backportable | 15:34 |
TheJulia | rloo: Even if it was explicitly labeled a feature, it is a major performance improvement and should be backported as such | 15:34 |
ajya | dtantsur: there is recent change to efiboot image script in devstack/ironic, reverting it helps to get IPA booting, but then there is SSL error, but I have to take a closer look at that to ensure there is no mismatch. Same images with PXE works | 15:34 |
rloo | that's what I think too :) | 15:35 |
TheJulia | rpioso: ideally yes, and too many emails may be part of my problem. It is just not consciously in my mind and thus difficult to discuss | 15:35 |
dtantsur | ajya: which change? maybe you have OS mismatch? | 15:35 |
rpioso | TheJulia: Okay, then we'll remove it from the list so notification emails are sent from the Dell CI. | 15:36 |
TheJulia | So the question becomes, re: erbarr's question, do people want to see emails from 3rd party CI's votes. I suspect it would be good to do so for those that see value in it | 15:36 |
*** ociuhandu has quit IRC | 15:37 | |
TheJulia | rpioso: if that is the way the other ones are configured, then I think that is fine | 15:37 |
dtantsur | I see value in it | 15:37 |
*** ociuhandu has joined #openstack-ironic | 15:37 | |
TheJulia | Okay! | 15:37 |
erbarr | cool, thanks! | 15:37 |
ajya | dtantsur: this patch https://opendev.org/openstack/ironic/commit/31f3f9fca1ed492db0a98613c360d8b823628782 , running with CentOS8 from https://tarballs.opendev.org/openstack/ironic-python-agent/dib/files/ on devstack Ubuntu if that matters | 15:37 |
TheJulia | This feels like consensus | 15:37 |
ajya | dtantsur: older IPA from Oct2020 still works with newer Ironic | 15:38 |
TheJulia | centos8+devstack seems problematic, I tried it last friday and had waaaaay too many issues | 15:38 |
TheJulia | just, fwiw | 15:38 |
dtantsur | ajya: yeah, it assumes the same OS between IPA and devstack | 15:38 |
rpioso | TheJulia: FYI https://review.opendev.org/admin/groups/95d633d37a5d6b06df758e57b1370705ec071a57 | 15:38 |
dtantsur | which was too optimistic, I admit | 15:38 |
dtantsur | although.. it uses grub and shim from ubuntu.. so the whole thing is probably a mess | 15:39 |
ajya | TheJulia: dtantsur, thanks it was working OK earlier (last year) | 15:39 |
*** Guest58358 is now known as JayF | 15:39 | |
*** JayF has quit IRC | 15:39 | |
*** JayF has joined #openstack-ironic | 15:39 | |
TheJulia | Hmm, a JayF sneaks into the channel ;) | 15:39 |
ajya | dtantsur: so it takes some grub config from ubuntu and tries to use it for centos8? | 15:39 |
JayF | I've been here the whole time, I just lost my nick :) | 15:40 |
dtantsur | yeah, except that the previous version was an example of Works On DevStack :) it wasn't how real people use it | 15:40 |
dtantsur | (and it was incompatible with secure boot) | 15:40 |
TheJulia | we really need to do everything we can to avoid tryign to touch/generate/modify grub configuration | 15:40 |
TheJulia | and running grub2-install | 15:40 |
TheJulia | that should be an absolute last reesort sort of thing | 15:40 |
TheJulia | Mainly because doing so is incompatible with Secure Boot and *now* it is actually no longer supported by the newest grubs | 15:41 |
dtantsur | honestly, what we have now should work, I'm not sure why it does not | 15:41 |
ajya | dtantsur: to get virtual media boot working on bifrost need to have same OS too for both running script and IPA? | 15:41 |
dtantsur | probably worth dropping into the grub shell and looking around | 15:41 |
dtantsur | ajya: probably? at least bifrost works pretty well on centos | 15:42 |
dtantsur | (unlike devstack) | 15:42 |
TheJulia | dtantsur: it seems to, I think it is based upon the input situation | 15:42 |
TheJulia | dtantsur: I'm going to likely talk to stevebaker about this very thing later today | 15:42 |
TheJulia | so you know with grub2 blocking grub2-install | 15:43 |
TheJulia | we're going to need to backport *all* of those patches | 15:43 |
ajya | dtantsur: too many moving parts :) and what's the status with IPA on ubuntu? | 15:43 |
*** ociuhandu has quit IRC | 15:43 | |
dtantsur | ajya: I think there was some issue with it, but I'm obviously biased towards using RH distros :) | 15:43 |
dtantsur | I'm not debian IPA works pretty well | 15:44 |
dtantsur | wut | 15:44 |
dtantsur | * I'm sure | 15:44 |
*** anuradha1904 has quit IRC | 15:45 | |
ajya | dtantsur: ok, thanks, while devstack is said to best run on ubuntu, in this case it's not suitable anymore with centos8 IPAs+virtual media boot | 15:46 |
ajya | will take a look what can be done about it | 15:46 |
dtantsur | it should work.. but I don't think I have any cycles to dive into it | 15:47 |
*** ociuhandu has joined #openstack-ironic | 15:47 | |
*** ociuhandu has quit IRC | 15:47 | |
TheJulia | I'm not aware of any issues, but cycles are limited | 15:47 |
rpioso | Could we update the review jam agenda from week to week, or better still, from meeting to meeting, so folks are informed about what we expect to review? | 15:47 |
*** ociuhandu has joined #openstack-ironic | 15:48 | |
TheJulia | rpioso: sorry, I had to miss two of the sessions and it became moderately organic in nature which made sense as people were expressing what they needed at that moment. I'm not entirely convinced planned agendas are a super good idea, but I also need to skip tomorrow's session for another meeting so it wouldn't be fair for me to plan it for others. If anyone wants to update the agenda, they are totally welcome | 15:49 |
TheJulia | to! | 15:49 |
dtantsur | I sad question: should we abandon sushy-cli? | 15:49 |
dtantsur | I really like having a CLI for redfish, but there are alternatives, and given that etingof has been the main driving force behind it... | 15:50 |
rpioso | TheJulia: Understood. At least for me, I could make more informed decisions about my schedule if there was an agenda, even if'. I expect | 15:51 |
rpioso | *even if it's tentative. | 15:51 |
TheJulia | rpioso: yeah, I'd <3 people to propose items so it is easier | 15:51 |
TheJulia | I could like propose all zer0c00l's stuff, but I'm not sure he has time tomorrow | 15:51 |
TheJulia | that would also be mean | 15:52 |
rpioso | I expect it would help others, too. We're all over booked :-) | 15:52 |
TheJulia | +1000 | 15:52 |
*** ociuhandu has quit IRC | 15:53 | |
*** ociuhandu has joined #openstack-ironic | 15:54 | |
TheJulia | Well everyone, if there is nothing else, I guess that means this is the end of our meeting this week. | 15:54 |
dtantsur | see above | 15:54 |
TheJulia | oh right | 15:54 |
dtantsur | > a sad question: should we abandon sushy-cli? | 15:54 |
TheJulia | yeah sorry :( | 15:54 |
TheJulia | mixed feelings on that | 15:54 |
JayF | ignoring sad questions is not a valid coping mechanism? :D | 15:55 |
dtantsur | np, it's not urgent. the release team has reminded us that we haven't merged anything to it | 15:55 |
dtantsur | heh | 15:55 |
TheJulia | It is a good target for outreachy internship stuff, but I don't have spoons for the summer session | 15:55 |
TheJulia | dtantsur: yes, but that is okay... as much as it makes the release team twitch and get upset. | 15:55 |
dtantsur | well, it's a good target, but I'd rather have outreachy folks do something real | 15:56 |
dtantsur | not a dead-end project that is unlikely to ever get traction | 15:56 |
TheJulia | Yeah | 15:56 |
dtantsur | related: do we have anyone volunteering to mentor for outreachy this cycle? | 15:56 |
TheJulia | I don't really have the cycles this session nor did I propose anything | 15:56 |
TheJulia | The proposal deadline *WAS* extended to the 11th I believe | 15:57 |
rpioso | Has the deadline passed? | 15:57 |
dtantsur | rpittau: do you know anything re outreachy? | 15:57 |
* TheJulia opens that mailbox with the email from Sage | 15:57 | |
TheJulia | Yes, extended to the 11th | 15:58 |
rpioso | :-) | 15:58 |
TheJulia | https://www.outreachy.org/communities/cfp/openstack/ | 15:58 |
TheJulia | #link https://www.outreachy.org/communities/cfp/openstack/ | 15:58 |
rpittau | yeah, I was going to confirm the proposal was extended | 15:58 |
dtantsur | rpittau: do you or Iury plan on mentoring? | 15:59 |
* dtantsur doesn't see iurygregory around | 15:59 | |
rpittau | I haven't planned anything and I doubt I will have the time :/ | 15:59 |
TheJulia | I got an email from Sage Sharp on the extension sometime last last week. | 15:59 |
TheJulia | It does help help the community and grow new contributors | 15:59 |
TheJulia | FWIW | 16:00 |
dtantsur | okay, I get probably take on mentoring this time, but will sync with Iury first | 16:00 |
*** frigo has quit IRC | 16:00 | |
TheJulia | Okay | 16:00 |
dtantsur | I CAN take mentoring, but I cannot type | 16:00 |
TheJulia | :) | 16:00 |
TheJulia | Typing is not required ;) | 16:00 |
TheJulia | Anyway, thanks everyone! | 16:00 |
rpioso | Thank you! | 16:00 |
TheJulia | Have a wonderful week, and remember to review the priority changes list. This is review "crunch time" | 16:00 |
rpittau | thanks! | 16:01 |
*** gmann is now known as gmann_afk | 16:01 | |
TheJulia | And to revise changes with feedback or get that discussion going to resolve disagreements or differing perceptions. | 16:01 |
Qianbiao | thanks, have a good week. | 16:01 |
*** Qianbiao has quit IRC | 16:01 | |
TheJulia | #endmeeting | 16:01 |
*** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75 | Contributors are generally present between 6 AM and 12 AM UTC, If we do not answer, please feel free to pose questions to openstack-discuss mailing list." | 16:01 | |
TheJulia | :) | 16:01 |
openstack | Meeting ended Mon Mar 8 16:01:51 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:01 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-03-08-15.00.html | 16:01 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-03-08-15.00.txt | 16:01 |
openstack | Log: http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-03-08-15.00.log.html | 16:01 |
*** stendulker has quit IRC | 16:05 | |
zer0c00l | TheJulia: sorry, had to be out during the meeting time. I am available. | 16:09 |
zer0c00l | For tomorrow review jam | 16:09 |
TheJulia | no worries, if you want to review jam your patches tomorrow, I'd add an agenda item then | 16:10 |
zer0c00l | yes, please. | 16:11 |
zer0c00l | thanks TheJulia | 16:11 |
* TheJulia yawns | 16:18 | |
* TheJulia greatly dislikes 4:30 AM wakeup time | 16:18 | |
* TheJulia opens up the bag of random words and tries to use them | 16:28 | |
dtantsur | 4:30am, OMG. I woke up at 11am today and still cannot think coherently. | 16:31 |
* JayF does 6:30am daily, even on a weekend day without an alarm set | 16:31 | |
* dtantsur considers JayF a superman now | 16:31 | |
TheJulia | That is moderately superhero-ish | 16:32 |
TheJulia | I have to get up at 4:30 AM again tomorrow | 16:33 |
TheJulia | all good reasons | 16:33 |
JayF | My wife is a teacher, and that's when she wakes up. I get to work 7a-4p, and basically work during the time she's away from the house | 16:33 |
dtantsur | make sense. still sounds like a super-ability to me :) | 16:33 |
JayF | (and as a teacher, she got her first dose of Pfizer vax Saturday :D) | 16:33 |
dtantsur | good for her! | 16:33 |
TheJulia | \o/ | 16:33 |
TheJulia | I'm glad it is starting to make it into people's arms that are not the elderly | 16:33 |
dtantsur | same here, they're vaccinating school and daycare employees | 16:34 |
openstackgerrit | Ruby Loo proposed openstack/ironic stable/victoria: [Trivial] Fix testing of volume connector exception https://review.opendev.org/c/openstack/ironic/+/779154 | 16:34 |
rpittau | dtantsur: wdyt about https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/778620 ? | 16:35 |
dtantsur | -2 never again! | 16:35 |
* dtantsur opens the link | 16:35 | |
TheJulia | lol | 16:35 |
* rpittau hides | 16:35 | |
TheJulia | no -2's without reason | 16:35 |
rpittau | I broke his groove | 16:35 |
* TheJulia should post a disapproving corgi picture | 16:36 | |
TheJulia | approving corgi can't be seen, he runs so fast | 16:36 |
dtantsur | rpittau: ship it! | 16:36 |
rpittau | lol | 16:36 |
JayF | if you hate a patch you should +2 it so you never have to review it again /s | 16:36 |
rpittau | ok! | 16:36 |
JayF | -2 is the path of painful conversations! :P | 16:36 |
rpittau | this is getting out of hand :D | 16:36 |
TheJulia | JayF: so wise! | 16:36 |
dtantsur | "Hello! I regret to inform you that your patch was selected by our chaos-imposing reviewing bot. Your patch will -2 without further considerations. Thank you for contributing to ironic!" | 16:37 |
TheJulia | lol | 16:38 |
TheJulia | no no, we need a chaos-imposing +2+A bot | 16:38 |
JayF | it me | 16:38 |
TheJulia | "metalchaositor" | 16:38 |
rpittau | with cordi dis/approvgin pictures links | 16:39 |
rpittau | corgi* | 16:39 |
TheJulia | lol | 16:39 |
JayF | I don't actually review code, I just have a great gerrit api script which approves things that are likely to be ready to land /s | 16:39 |
dtantsur | JayF: on a serious note, I'm sure there was a couple of such accounts that +1 already approved things | 16:39 |
JayF | Back during my previous tenure as core, I became convinced we had some folks running automated spell check review bots | 16:40 |
TheJulia | JayF: This is a semi-valid approach | 16:40 |
TheJulia | Anyone have opinions on highlights for the cycle? | 16:40 |
dtantsur | my items include redfish secure boot, injecting files | 16:41 |
rpittau | nvme secure erase ? | 16:41 |
dtantsur | yep ^^ | 16:41 |
* dtantsur barely remembers what was happening recently | 16:41 | |
rpittau | I'm jsut scrolling the release notes :) | 16:41 |
TheJulia | oooh, I forgot about secure boot with redfish | 16:41 |
dtantsur | deploy steps in API | 16:41 |
dtantsur | your UEFI work in IPA? | 16:42 |
TheJulia | was that this cycle? | 16:42 |
dtantsur | maybe? | 16:43 |
TheJulia | wow | 16:43 |
TheJulia | yeah | 16:43 |
dtantsur | seems so https://docs.openstack.org/releasenotes/ironic-python-agent/unreleased.html#relnotes-6-5-0-bug-fixes | 16:43 |
dtantsur | not sure how much has been backported, but it's still a highlight | 16:43 |
JayF | IPA TLS was last cycle, right? | 16:43 |
TheJulia | yeah | 16:43 |
dtantsur | I think so | 16:43 |
dtantsur | and so were in-band deploy steps, I assume | 16:43 |
TheJulia | yup | 16:44 |
TheJulia | It is really impressive every time I go back and see what we did during the prior six months | 16:44 |
dtantsur | oh yeah | 16:45 |
TheJulia | "like, WOW! We did that?!?" | 16:45 |
dtantsur | I'm particularly impressed when I'm trying things for my posts and compare them with my experience 2-3 years ago | 16:45 |
JayF | I landed https://review.opendev.org/c/openstack/ironic/+/777434 yesterday | 16:46 |
* TheJulia thinks UEFI enhancements and bugfixes is nice and broad | 16:46 | |
JayF | that's a subtly awesome improvement worth calilng out I think | 16:46 |
rpittau | looooots of bugfixes | 16:46 |
TheJulia | also all the rbac work, of course I'll be contiuing that work into next cycle to a degree and 3 patches to go, but yeah | 16:47 |
dtantsur | JayF: mmm. I'm not exactly fond of an ability to override any interface, not just deploy, network and storage | 16:49 |
* dtantsur is considering implications for secure RBAC | 16:49 | |
dtantsur | maybe it's fine, dunno | 16:50 |
JayF | I'll note that said interfaces already have to be 1) configured in conductor config and 2) properly setup on the node to work at all | 16:50 |
dtantsur | fair | 16:50 |
JayF | which is part of why I wasn't concerned about it | 16:50 |
JayF | you can't run arbitrary code | 16:50 |
* dtantsur relocates the documentation to where it can be found | 16:50 | |
TheJulia | dtantsur: re interface overries? | 16:52 |
dtantsur | yep | 16:52 |
TheJulia | lmk what the link should be when you get a chance, I'm going to link to it in the highlights | 16:53 |
dtantsur | TheJulia: I want to move it to standalone docs | 16:54 |
dtantsur | which we should split eventually.. | 16:54 |
TheJulia | Yeah, it is a little more user oriented | 16:54 |
TheJulia | We do need to re-shuffle the docs again. Some stuff is just insanely too long now | 16:54 |
TheJulia | like "can't find what your looking for length" | 16:55 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: docs: move overriding interfaces to the standalone documentation https://review.opendev.org/c/openstack/ironic/+/779298 | 16:59 |
dtantsur | TheJulia: ^^^ | 16:59 |
TheJulia | thanks | 16:59 |
dtantsur | let me look into making the standalone guide more readable | 16:59 |
rpittau | TheJulia: the docs I was reviewing is the dev-quickstart, but I can wait for https://review.opendev.org/c/openstack/ironic/+/779061 to merge before moving out of WIP | 17:00 |
JayF | dtantsur: +2 but included a minor suggestion | 17:00 |
*** lucasagomes has quit IRC | 17:00 | |
TheJulia | rpittau: oh, dev-quickstart happens to be the doc that is too long and rifled with errors | 17:01 |
dtantsur | JayF: you mean, in the commit message? | 17:01 |
JayF | dtantsur: yes | 17:01 |
rpittau | TheJulia: exactly :D | 17:01 |
TheJulia | rpittau: so anything can merge, I had to pivot completely on friday | 17:01 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: docs: move overriding interfaces to the standalone documentation https://review.opendev.org/c/openstack/ironic/+/779298 | 17:02 |
dtantsur | okay done | 17:02 |
JayF | thanks! | 17:04 |
openstackgerrit | Bob Fournier proposed openstack/ironic-python-agent master: Check the base device if the read-only file cannot be read https://review.opendev.org/c/openstack/ironic-python-agent/+/779111 | 17:14 |
TheJulia | https://review.opendev.org/c/openstack/releases/+/779306 | 17:15 |
TheJulia | Presently a WIP, hoping redfish raid merges today :) | 17:15 |
*** iurygregory has joined #openstack-ironic | 17:17 | |
iurygregory | o/ | 17:17 |
iurygregory | I'm back :D | 17:17 |
TheJulia | welcome back! | 17:18 |
TheJulia | Did you take over the world? | 17:18 |
iurygregory | I couldn't because the doctor appointment took almost 2hrs D: | 17:19 |
TheJulia | Eek | 17:19 |
dtantsur | ouch | 17:19 |
dtantsur | iurygregory: I wanted to ask, do you plan on mentoring for outreachy this cycle? | 17:19 |
iurygregory | dtantsur, since we applied for an intern it would be a lot of time .-. | 17:20 |
iurygregory | so for this cycle I'm skipping outreachy | 17:20 |
dtantsur | iurygregory: okay, I think I'll go for it this time | 17:20 |
iurygregory | dtantsur, ack o/ if you need any help with reviews let me know | 17:21 |
dtantsur | sure, thanks | 17:21 |
TheJulia | That would be good since my early morning call tomorrow is about this subject of people getting time to do things like outreachy mentorship :) | 17:21 |
iurygregory | I will be happy to help ofc =) | 17:22 |
rpittau | dtantsur: I actually may have some time for co-mentoring if things settle a bit downstream | 17:22 |
dtantsur | great! | 17:22 |
* rpittau fighting against robo-army | 17:22 | |
dtantsur | okay, I'll take a look at our list of projects and pick something useful | 17:23 |
TheJulia | so one thing about mentees in outreachy, they tend to gravitate towards one person | 17:23 |
TheJulia | but people helping is always awesome | 17:23 |
rpittau | true | 17:23 |
dtantsur | oh, every time I start cleaning up docs it's a rabbit hole... | 17:29 |
openstackgerrit | Merged openstack/ironic master: Add Redfish RAID management to Ironic https://review.opendev.org/c/openstack/ironic/+/730000 | 17:29 |
dtantsur | \o/ | 17:29 |
TheJulia | oh noes, not the docs rabbit hole | 17:32 |
TheJulia | \o/ | 17:32 |
dtantsur | well, the standalone docs can use a lot of love | 17:32 |
TheJulia | all the docs need love | 17:35 |
dtantsur | here goes | 17:41 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Rework the standalone guide https://review.opendev.org/c/openstack/ironic/+/779311 | 17:41 |
* dtantsur considers this a post-PTO warm-up patch | 17:42 | |
openstackgerrit | Merged openstack/ironic master: docs: move overriding interfaces to the standalone documentation https://review.opendev.org/c/openstack/ironic/+/779298 | 17:48 |
dtantsur | tzumainn: JFYI ^^ | 17:48 |
*** iurygregory has quit IRC | 17:49 | |
*** dougsz has quit IRC | 17:51 | |
tzumainn | dtantsur, ah, thanks for fixing things up! | 18:02 |
arne_wiebalck | bye everyone, see you tomorrow o/ | 18:13 |
arne_wiebalck | don't miss the iurygregory show ;) | 18:14 |
openstackgerrit | Merged openstack/ironic stable/victoria: [Trivial] Fix testing of volume connector exception https://review.opendev.org/c/openstack/ironic/+/779154 | 18:15 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Enforce autospec in test_console_utils https://review.opendev.org/c/openstack/ironic/+/779339 | 18:16 |
rpittau | bye everyone! o/ | 18:16 |
*** rpittau is now known as rpittau|afk | 18:16 | |
*** dtantsur is now known as dtantsur|afk | 18:17 | |
dtantsur|afk | o/ | 18:17 |
*** ociuhandu has quit IRC | 18:20 | |
*** ociuhandu has joined #openstack-ironic | 18:22 | |
*** ociuhandu has quit IRC | 18:27 | |
*** iurygregory has joined #openstack-ironic | 18:46 | |
*** ociuhandu has joined #openstack-ironic | 18:51 | |
*** ociuhandu has quit IRC | 18:56 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: RBAC Follow-up: Review follow-up. https://review.opendev.org/c/openstack/ironic/+/779345 | 19:01 |
*** k_mouza has quit IRC | 19:08 | |
JayF | TheJulia: https://review.opendev.org/c/openstack/ironic-specs/+/777172 I just W-1'd that right after you approved it. Please see the comment. | 19:17 |
* JayF not having a good morning trying to implement that in ocata | 19:18 | |
JayF | conductor manager currently calls task.driver.deploy.heartbeat() in a separate thread, which means we can't return things from it | 19:18 |
JayF | tl;dr: to implement my spec as written, heartbeat handling has to become syncronous. I am suspicious that may lead to a handful of bugs around continue_cleaning and the like (e.g. what happens if the *same thread* that the conductor manager spawns is currently the same thread used to call to the BMC to do an OOB step?) | 19:19 |
* TheJulia stops to re-read this one more time | 19:20 | |
JayF | I'm checking to make sure this concern exists in master, but I'd be surprised if not | 19:20 |
JayF | https://opendev.org/openstack/ironic/src/branch/master/ironic/conductor/manager.py#L3089 | 19:21 |
JayF | spawn_after returns as soon as it queues that command for work | 19:21 |
TheJulia | hmmm | 19:21 |
JayF | which means we can't return anything from task.driver.deploy.heartbeat UNLESS we make it a sync command | 19:21 |
JayF | which downstream I can do, easily, because I don't have to worry about OOB cleaning/deploy steps | 19:21 |
JayF | however I suspect the implications of making that change upstream, even conditionally, are significant | 19:21 |
TheJulia | commented on the spec and removed wf+1 and +2, since I suspect your going ot revise it | 19:23 |
JayF | makes me worry less that you aren't as worried | 19:24 |
TheJulia | a mix of faith and not wanting to think about step iteration at the moment | 19:24 |
JayF | heh | 19:25 |
JayF | I have faith it'll work for me downstream | 19:25 |
TheJulia | but realistically, it shouldn't be that bad, we just likely need a divergent logic path | 19:25 |
JayF | and won't be my problem upstream for a few weeks | 19:25 |
TheJulia | heh | 19:25 |
* JayF buries future-Jay in painful work | 19:25 | |
TheJulia | heh | 19:26 |
openstackgerrit | Ruby Loo proposed openstack/ironic stable/victoria: Lazy-load node details from the DB https://review.opendev.org/c/openstack/ironic/+/779322 | 19:26 |
TheJulia | I need to look at tempest tests after my next two meetings | 19:26 |
TheJulia | I think the allocation tests do something naughty | 19:26 |
*** ociuhandu has joined #openstack-ironic | 19:30 | |
*** gmann_afk is now known as gmann | 19:32 | |
TheJulia | zer0c00l: question on https://review.opendev.org/c/openstack/ironic/+/772166 | 19:37 |
TheJulia | specifically posted to the release note | 19:37 |
zer0c00l | TheJulia: ack. | 19:39 |
zer0c00l | Let me move the release notes. | 19:39 |
TheJulia | also the patch following that with the template generation stuffs for the pxe driver, we should put some values in there even if they are fake | 19:41 |
TheJulia | It feels like order is flipped there, but if we approve/merge together it should be fine | 19:41 |
zer0c00l | so this is the order of patchsets - https://review.opendev.org/c/openstack/ironic/+/772166 (1) | 19:42 |
zer0c00l | https://review.opendev.org/c/openstack/ironic/+/775891 (2) | 19:42 |
zer0c00l | https://review.opendev.org/c/openstack/ironic/+/777448 (3) | 19:42 |
TheJulia | yeah, reno should get moved back until a little later :) | 19:42 |
zer0c00l | https://review.opendev.org/c/openstack/ironic/+/778058 (4) | 19:42 |
zer0c00l | reno? | 19:43 |
*** ociuhandu has quit IRC | 19:43 | |
zer0c00l | releasenotes? | 19:43 |
zer0c00l | ok :) | 19:43 |
TheJulia | yeah | 19:43 |
zer0c00l | i was wondering if i should ateast keep the part where it talks about adding of "default_ks_template" | 19:43 |
zer0c00l | or should i move all the release notes stuff to the last patchset in this series? | 19:44 |
TheJulia | I'm thinking the interface is not entirely there yet, so once it is usable it shoudl be there | 19:44 |
TheJulia | in the release notes, if that makes sense | 19:44 |
TheJulia | It could also be moot if everyone is good and we just want to merge in rapid succession | 19:44 |
zer0c00l | yeah that makes sense. | 19:44 |
zer0c00l | ack1 | 19:44 |
JayF | TheJulia: Obviously I want zer0c00l's changes in, but I think it's potentially dangerous if we merge them before we have a deploy using it running in CI | 20:03 |
openstackgerrit | Bob Fournier proposed openstack/ironic-specs master: Add support for Redfish BIOS Registry API https://review.opendev.org/c/openstack/ironic-specs/+/774681 | 20:04 |
TheJulia | I do agree, hopefully that will be soon() | 20:04 |
TheJulia | I'm less worried about having to backport a fix or two and cutting 17.0.1 a week or two after 17.0.0 is released | 20:05 |
TheJulia | https://review.opendev.org/c/openstack/releases/+/779306 <-- updated per dtantsur's feedback | 20:11 |
openstackgerrit | Merged openstack/ironic master: Volume targets/connectors Project Scoped RBAC https://review.opendev.org/c/openstack/ironic/+/776314 | 20:21 |
TheJulia | sweet | 20:21 |
*** iwoj has joined #openstack-ironic | 20:22 | |
openstackgerrit | Merged openstack/ironic master: Project scope driver vendor pass-through https://review.opendev.org/c/openstack/ironic/+/776767 | 20:22 |
openstackgerrit | Merged openstack/ironic master: Follow-up on project scoped trait tests https://review.opendev.org/c/openstack/ironic/+/776768 | 20:22 |
*** iwoj has left #openstack-ironic | 20:26 | |
*** mrda has quit IRC | 20:33 | |
openstackgerrit | Merged openstack/ironic master: Adds config parameter kernel_append_param for iLO https://review.opendev.org/c/openstack/ironic/+/755189 | 20:43 |
*** ociuhandu has joined #openstack-ironic | 20:53 | |
openstackgerrit | Ruby Loo proposed openstack/ironic stable/ussuri: [Trivial] Fix testing of volume connector exception https://review.opendev.org/c/openstack/ironic/+/779325 | 20:55 |
openstackgerrit | Ruby Loo proposed openstack/ironic stable/train: [Trivial] Fix testing of volume connector exception https://review.opendev.org/c/openstack/ironic/+/779326 | 20:55 |
*** gyee has joined #openstack-ironic | 20:56 | |
*** ociuhandu has quit IRC | 21:01 | |
TheJulia | stevebaker: major redfish change between weens and train is https://github.com/openstack/ironic/blame/master/ironic/drivers/modules/redfish/management.py#L81 area. You can see the two patches that make up that function | 21:02 |
stevebaker | TheJulia: so in the logs I should be seeing a second different PATCH call which succeeds after the first one fails. I'll check, that particular part might be working as expected | 21:05 |
TheJulia | Possibly | 21:05 |
TheJulia | if you go back through the backports, and the state of the queens branch | 21:06 |
TheJulia | it *did* have to get refactored differently, so it may look a little different | 21:06 |
TheJulia | in other words, I seem to remember it was basically an entirely new patch that far back | 21:06 |
*** k_mouza has joined #openstack-ironic | 21:08 | |
*** k_mouza has quit IRC | 21:13 | |
stevebaker | TheJulia: ok, I'll take a look | 21:14 |
TheJulia | but the tl;dr was somwehere ability to set persistance changed | 21:14 |
TheJulia | at first it was just ilo | 21:14 |
TheJulia | then dell | 21:14 |
TheJulia | and then I think dell reverted once it was clarified by the dmtf that it was an unintended thing | 21:15 |
TheJulia | and that these changes were leaking backwards. Like it was a side note in late 2019 schema docs, but and promptly implemented in new firmware but wasn't the intent or was taken out of context or soemthign | 21:16 |
TheJulia | stevebaker: are they in uefi mode? | 21:18 |
TheJulia | rloo: one minor change on that backport | 21:20 |
rloo | TheJulia: ? is there a bug with it? | 21:21 |
TheJulia | rloo: release note tuning :) | 21:21 |
rloo | OH | 21:21 |
TheJulia | Admittedly it is largely so the release team doesn't block us releasing it | 21:21 |
TheJulia | or argue with us | 21:21 |
rloo | yeah, makes sense. thx for noticing, i just 'blindly' clicked the cherry-pick thingy :) | 21:23 |
rpioso | bdodd: Congratulations!!!!! | 21:23 |
openstackgerrit | Ruby Loo proposed openstack/ironic stable/victoria: Lazy-load node details from the DB https://review.opendev.org/c/openstack/ironic/+/779322 | 21:26 |
* TheJulia ponders what to do with allocaitons | 21:33 | |
TheJulia | allocations | 21:33 |
bdodd | rpioso: Thanks! | 21:37 |
rpioso | bdodd: You're most welcome :) | 21:37 |
TheJulia | stevebaker: so the integration test failure is allocations and my unconditional storage of an allocation | 21:38 |
TheJulia | because of that, a filter is automatically applied | 21:38 |
TheJulia | well, allocation owner | 21:39 |
TheJulia | dtantsur|afk: tomorrow, lets talka bout allocations and owner | 21:43 |
* TheJulia wraps the day after starting a little before 5 am | 21:44 | |
openstackgerrit | Bob Fournier proposed openstack/ironic-specs master: Add support for Redfish BIOS Registry API https://review.opendev.org/c/openstack/ironic-specs/+/774681 | 21:50 |
*** rcernin has joined #openstack-ironic | 21:54 | |
*** ociuhandu has joined #openstack-ironic | 22:01 | |
*** ociuhandu has quit IRC | 22:06 | |
openstackgerrit | Merged openstack/sushy master: Ensure Content-Type header is set when required https://review.opendev.org/c/openstack/sushy/+/779164 | 22:11 |
*** lmcgann has quit IRC | 22:19 | |
*** ociuhandu has joined #openstack-ironic | 22:38 | |
*** ociuhandu has quit IRC | 22:44 | |
stevebaker | TheJulia: can you tell if its in uefi mode from this GET reponse? http://paste.openstack.org/show/803360/ | 22:52 |
*** trandles has joined #openstack-ironic | 22:55 | |
*** zzzeek has quit IRC | 23:08 | |
*** zzzeek has joined #openstack-ironic | 23:12 | |
*** ociuhandu has joined #openstack-ironic | 23:54 | |
*** ociuhandu has quit IRC | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!