Tuesday, 2021-03-23

jandersgood morning Ironic o/00:03
*** tosky has quit IRC00:09
iurygregorymorning janders o/00:12
*** sshnaidm is now known as sshnaidm|off00:12
openstackgerritSteve Baker proposed openstack/ironic-python-agent stable/victoria: Add fstab pointer to EFI partition  https://review.opendev.org/c/openstack/ironic-python-agent/+/78234300:26
stevebakerbackporting ^^ to ussuri will be hard00:26
stevebakerlet-alone train00:27
iurygregoryyeah =(00:27
stevebakeralso I'm tempted to backport token support to train so I can test stable/train IPA images with a recent ironic. But I might just be delirious due to this cold00:35
jandersI'm addressing Dmitry's feeback regarding https://review.opendev.org/c/openstack/ironic/+/774391 (merged). Do I submit the follow up change 1) in any special way (how) or 2) is follow up a completely separate patch and no need to set anything special on it?01:05
iurygregoryI know gerrit now has a "Follow-Up" button (I never used)01:13
iurygregorynormally what I do is just to create a new change and say in the commit message that is a follow-up for I3debcd1f32a2627dafd8456ec73a71fc7c402ebb01:13
iurygregoryI hope this helps janders ^01:14
jandersit does! thanks heaps iurygregory01:15
iurygregorynp01:15
openstackgerritMerged openstack/ironic master: Add Redfish RAID interface to idrac HW type  https://review.opendev.org/c/openstack/ironic/+/77443301:48
openstackgerritliuyuanfeng proposed openstack/ironic master: when the port_date is dict,port date from neutron doesnot have is_smartnic property  https://review.opendev.org/c/openstack/ironic/+/78234401:53
*** jamesdenton has quit IRC02:13
*** jamesden_ has joined #openstack-ironic02:13
openstackgerritSteve Baker proposed openstack/ironic-python-agent stable/ussuri: Option to enable bootloader config failure bypass  https://review.opendev.org/c/openstack/ironic-python-agent/+/78156902:20
openstackgerritSteve Baker proposed openstack/ironic-python-agent stable/ussuri: Refactor part of image module  https://review.opendev.org/c/openstack/ironic-python-agent/+/78234802:20
openstackgerritSteve Baker proposed openstack/ironic-python-agent stable/ussuri: Mount all vfat partitions before calling grub2  https://review.opendev.org/c/openstack/ironic-python-agent/+/78234902:20
openstackgerritSteve Baker proposed openstack/ironic-python-agent stable/ussuri: More refactoring of the image module  https://review.opendev.org/c/openstack/ironic-python-agent/+/78235002:20
openstackgerritSteve Baker proposed openstack/ironic-python-agent stable/ussuri: Prevent broken partition image UEFI deploys  https://review.opendev.org/c/openstack/ironic-python-agent/+/78235102:20
openstackgerritSteve Baker proposed openstack/ironic-python-agent stable/ussuri: Add fstab pointer to EFI partition  https://review.opendev.org/c/openstack/ironic-python-agent/+/78235202:20
*** rcernin has quit IRC02:28
*** rcernin has joined #openstack-ironic02:39
*** bdodd has quit IRC03:57
*** viks____ has quit IRC04:20
*** mkrai has joined #openstack-ironic04:23
*** gyee has quit IRC04:26
*** tzumainn has quit IRC05:06
*** jamesden_ has quit IRC05:25
*** jamesdenton has joined #openstack-ironic05:25
*** rcernin has quit IRC05:25
*** rcernin has joined #openstack-ironic05:26
*** ricolin_ has joined #openstack-ironic06:17
*** jamesdenton has quit IRC06:20
*** jamesden_ has joined #openstack-ironic06:21
*** ricolin_ has quit IRC06:23
openstackgerritankit proposed openstack/ironic master: Add security dashboard clean steps to ilo drivers  https://review.opendev.org/c/openstack/ironic/+/78236406:33
openstackgerritAlexander Evseev proposed openstack/bifrost master: Add network mask to the dnsmasq config  https://review.opendev.org/c/openstack/bifrost/+/78236506:36
*** frigo has joined #openstack-ironic06:43
*** frigo has quit IRC07:03
*** mkrai has quit IRC07:04
*** mkrai_ has joined #openstack-ironic07:05
*** moshiur has joined #openstack-ironic07:11
*** uzumaki has quit IRC07:17
*** uzumaki has joined #openstack-ironic07:22
*** mkrai_ has quit IRC07:23
arne_wiebalckGood morning, ironic!07:28
*** abhishekyadav has joined #openstack-ironic07:40
*** mkrai_ has joined #openstack-ironic07:43
*** rcernin has quit IRC07:46
*** rpittau|afk is now known as rpittau08:13
rpittaugood morning ironic! o/08:13
openstackgerritRiccardo Pittau proposed openstack/ironic-inspector master: Increase memory of ironic vm in grenade  https://review.opendev.org/c/openstack/ironic-inspector/+/78237108:18
*** rcernin has joined #openstack-ironic08:23
openstackgerritRiccardo Pittau proposed openstack/ironic-prometheus-exporter stable/wallaby: Increase RAM for ironic vm  https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/78212808:24
openstackgerritRiccardo Pittau proposed openstack/ironic-prometheus-exporter stable/victoria: Increase RAM for ironic vm  https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/78212908:25
*** anuradha1904 has joined #openstack-ironic08:32
*** sshnaidm|off has quit IRC08:34
openstackgerritRiccardo Pittau proposed openstack/python-ironicclient stable/wallaby: Fix --fields network_data  https://review.opendev.org/c/openstack/python-ironicclient/+/78213008:36
openstackgerritRiccardo Pittau proposed openstack/python-ironicclient stable/victoria: Fix --fields network_data  https://review.opendev.org/c/openstack/python-ironicclient/+/78213108:36
openstackgerritRiccardo Pittau proposed openstack/python-ironicclient stable/ussuri: Fix --fields network_data  https://review.opendev.org/c/openstack/python-ironicclient/+/78213208:36
*** ociuhandu has joined #openstack-ironic08:51
*** ociuhandu has quit IRC08:59
*** lucasagomes has joined #openstack-ironic09:02
*** derekh has joined #openstack-ironic09:02
*** tosky has joined #openstack-ironic09:04
*** ociuhandu has joined #openstack-ironic09:09
*** ociuhandu has quit IRC09:09
*** ociuhandu has joined #openstack-ironic09:20
openstackgerritMark Goddard proposed openstack/tenks master: DNM: test libvirt-host patch  https://review.opendev.org/c/openstack/tenks/+/78238309:25
jandershey arne_wiebalck and rpittau o/09:25
rpittauhey janders :)09:27
dtantsurmorning ironic09:44
jandersgood morning dtantsur o/09:45
*** abhishekyadav has quit IRC09:47
*** abhishekyadav has joined #openstack-ironic09:47
openstackgerritDhuldev Valekar proposed x/sushy-oem-idrac master: Add the high-level reset iDRAC method  https://review.opendev.org/c/x/sushy-oem-idrac/+/78225410:00
openstackgerritAija Jauntēva proposed openstack/ironic master: Update idrac-redfish RAID release note  https://review.opendev.org/c/openstack/ironic/+/78239110:03
*** uzumaki has quit IRC10:12
*** uzumaki has joined #openstack-ironic10:13
*** sshnaidm has joined #openstack-ironic10:13
*** sshnaidm is now known as sshnaidm|off10:13
*** tosky has quit IRC10:13
*** tosky has joined #openstack-ironic10:14
*** ociuhandu has quit IRC10:16
*** ociuhandu has joined #openstack-ironic10:22
*** ociuhandu has quit IRC10:28
*** uzumaki has quit IRC10:29
*** uzumaki has joined #openstack-ironic10:30
openstackgerritliuzhuangzhuang proposed openstack/ironic master: update grub2 file name  https://review.opendev.org/c/openstack/ironic/+/78048110:30
*** uzumaki has quit IRC10:31
*** uzumaki has joined #openstack-ironic10:32
*** ociuhandu has joined #openstack-ironic10:38
*** uzumaki has quit IRC10:44
*** rcernin has quit IRC10:46
*** mkrai_ has quit IRC10:47
*** anuradha1904 has quit IRC10:48
iurygregorygood morning arne_wiebalck  janders rpittau dtantsur and Ironic o/10:49
rpittauhey iurygregory :)10:50
jandershey iurygregory o/10:50
iurygregoryo/10:50
* arne_wiebalck upgraded to Ussuri10:57
arne_wiebalckHere is a plot of the thundering herd (which I stretched already). https://usercontent.irccloud-cdn.com/file/BVKPfFQW/upgrade_thundering_herd.png10:58
openstackgerritJacob Anders proposed openstack/ironic master: Follow up of Use OOB inspection to fetch MACs for IB inspection  https://review.opendev.org/c/openstack/ironic/+/78240610:58
arne_wiebalckAnd it seems, lazy loading is not as good as my first patch when it comes to DB activity. https://usercontent.irccloud-cdn.com/file/LRTPWSE6/upgrade_db_activity.png10:59
arne_wiebalckThis is not a fair comparison as there is of course an upgrade in between, though.11:00
arne_wiebalckSo maybe Ussuri does more on the DB ... ?11:00
openstackgerritRiccardo Pittau proposed openstack/bifrost stable/victoria: Increase memory of vm to adjust for new tinyipa  https://review.opendev.org/c/openstack/bifrost/+/78240711:00
dtantsurarne_wiebalck: not impossible, although I don't remember any increased activity11:01
dtantsurbut then, I cannot imagine why lazy loading would be worse11:01
dtantsurhas anyone looked at the bifrost CI? looks like insufficient RAM in upgrade jobs?11:01
rpittaudtantsur: jsut submitted a patch for that11:01
arne_wiebalckdtantsur: the real activity, as per the first plot, is about equal11:01
dtantsurrpittau: thanks!11:02
arne_wiebalckdtantsur: real == InnoDB activity11:02
dtantsurrpittau: we need to start with Victoria because of the upgrade, right?11:02
*** yoctozepto has quit IRC11:02
rpittaudtantsur: correct11:02
rpittauactually on master all's good, it's 1024 already11:03
*** yoctozepto has joined #openstack-ironic11:03
dtantsurnice11:03
rpittauI will rename tinyipa as moderatelysizedipa11:03
dtantsur:D11:05
dtantsurour cute little baby has grown11:05
rpittauoh yeah11:06
*** rcernin has joined #openstack-ironic11:09
arne_wiebalckdtantsur: the reason why lazy-loading is worse could be that the lazy-loading patch is not doing we think it does :)11:11
arne_wiebalckdtantsur: comparing with the plots I had before my local patch (which did not touch ports etc at all), the db activity is basically back to the old level11:13
*** rcernin has quit IRC11:17
*** rcernin has joined #openstack-ironic11:18
arne_wiebalckor, better, Arne branched before the lazy-load patch was back-ported and merged in stable/ussuri ...11:18
*** ociuhandu has quit IRC11:22
dtantsurarne_wiebalck: do you have a link to your lazy-loading patch?11:22
dtantsurhttps://review.opendev.org/c/openstack/ironic/+/77693011:23
arne_wiebalckdtantsur: the patch is not in the code I run11:24
dtantsurwell :)11:24
arne_wiebalckdtantsur: I branched before it was merged in stable/ussuri11:24
dtantsurriddle solved!11:24
arne_wiebalckyeah11:24
*** rcernin has quit IRC11:25
arne_wiebalckI will create new packages, let's see ...11:25
*** lourot has quit IRC11:25
*** ociuhandu has joined #openstack-ironic11:29
arne_wiebalckat least we will get a direct effect of the patch :-D11:33
openstackgerritAija Jauntēva proposed openstack/ironic master: Add known iDRAC virtual media boot issue  https://review.opendev.org/c/openstack/ironic/+/78243811:35
openstackgerritMerged openstack/ironic-inspector master: Increase memory of ironic vm in grenade  https://review.opendev.org/c/openstack/ironic-inspector/+/78237111:36
openstackgerritMerged openstack/ironic-prometheus-exporter stable/wallaby: Increase RAM for ironic vm  https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/78212811:36
openstackgerritMerged openstack/ironic-prometheus-exporter stable/victoria: Increase RAM for ironic vm  https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/78212911:36
openstackgerritMerged openstack/ironic master: Revise release notes for 17.0 release  https://review.opendev.org/c/openstack/ironic/+/78097311:36
iurygregorymoderatelysizedipa LOL11:39
openstackgerritJacob Anders proposed openstack/ironic master: Follow up of Use OOB inspection to fetch MACs for IB inspection  https://review.opendev.org/c/openstack/ironic/+/78240611:50
*** lourot has joined #openstack-ironic11:52
*** ociuhandu_ has joined #openstack-ironic12:12
*** ociuhandu has quit IRC12:13
*** ociuhandu has joined #openstack-ironic12:13
openstackgerritMerged openstack/ironic stable/victoria: [stable] Remove lower-constraints job  https://review.opendev.org/c/openstack/ironic/+/76705812:15
*** ociuhandu_ has quit IRC12:17
openstackgerritMerged openstack/bifrost stable/victoria: Increase memory of vm to adjust for new tinyipa  https://review.opendev.org/c/openstack/bifrost/+/78240712:19
*** frigo has joined #openstack-ironic12:19
frigothe moderatelysized IPA ended up filling my /tmp because of https://storyboard.openstack.org/#!/story/200874212:21
frigo(although you can't really blame it on tinyipa:D  )12:22
rpittaulol12:22
rpittaufrigo: patch welcome :)12:22
iurygregoryhehehe smooltinyipa12:25
frigoon it, on it...12:25
*** ociuhandu has quit IRC12:27
openstackgerritMerged openstack/ironic stable/ussuri: Fix broken configdrive_use_object_store  https://review.opendev.org/c/openstack/ironic/+/77734912:29
*** ociuhandu has joined #openstack-ironic12:33
*** ociuhandu has quit IRC12:38
openstackgerritFrancois Rigault proposed openstack/sushy-tools master: Delete temporary file after media ejection  https://review.opendev.org/c/openstack/sushy-tools/+/78251412:47
*** rloo has joined #openstack-ironic12:53
*** mgoddard has quit IRC12:53
*** ociuhandu has joined #openstack-ironic12:57
*** ociuhandu has quit IRC13:02
*** ociuhandu has joined #openstack-ironic13:08
*** ociuhandu has quit IRC13:08
*** ociuhandu has joined #openstack-ironic13:10
TheJuliagood morning13:13
*** ociuhandu has quit IRC13:15
dtantsurTheJulia: morning13:15
* TheJulia did not sleep well13:17
iurygregorymorning TheJulia13:20
* iurygregory is also in the same boat13:21
TheJuliabad wind storm here last night13:21
iurygregoryfor me it was because I received some bad news13:23
TheJuliaI'm sorry :(13:25
iurygregorytks ^^13:26
*** ociuhandu has joined #openstack-ironic13:26
arne_wiebalckaha! :) https://usercontent.irccloud-cdn.com/file/gBh3DQ04/lazy-loading.png13:27
*** abhishekyadav has quit IRC13:28
arne_wiebalckbefore 10:00 train with local DB patch, at 10:35 Ussuri vanilla with delayed startup (thundering herd), 14:00 Ussuri with lazy-loading and all conductors started at the same moment, and then the 5 min power sync interval13:29
arne_wiebalckso: lazy-loading reduces the DB load as intended, and it seems it also removes the thundering herd issue13:30
TheJuliawell13:30
TheJulia"removes as in reduces load so things don't thrash"13:30
arne_wiebalckright13:31
*** ociuhandu has quit IRC13:31
arne_wiebalckbut at least one can start the conductors all at once without having 10 times more load on the DB13:31
arne_wiebalcknote that the initial start at 10:35 took more than 30mins13:32
arne_wiebalckwhile the one at 14:00 took 5mins13:32
* arne_wiebalck is not saying there is no room for further improvement :)13:33
*** lmcgann has joined #openstack-ironic13:35
arne_wiebalckjitter when starting the power sync would still be sensible IMO13:38
TheJuliaYeah, i'm still pondering13:38
arne_wiebalckthat seems a low-hanging fruit to at least smear out requests13:39
TheJuliayeah13:39
arne_wiebalckrather than me having a bash loop with shuf :)13:40
*** ociuhandu has joined #openstack-ironic13:42
*** tzumainn has joined #openstack-ironic13:43
mnaseris there a simple doc somewhere on how i can get a devstack env up with something like virtualbmc13:43
mnaseror a shell script i can run and get a bunch of vms managed by ironic?13:43
* mnaser has grown tired of rebooting physical systems non stop13:44
TheJuliaDevstack does it by default.... You supply it the number of VMs you want, you just need to ensure you don't exceed (remember that software!?) the amount of RAM13:44
TheJuliatenks may be an option, but I've never used it.13:45
TheJuliaBifrost has playbooks for this as well13:45
*** bdodd has joined #openstack-ironic13:45
mnaseroh devstack actually does it13:45
mnaseri'll just use that then13:45
iurygregorydevstack has by default,  you can get local.conf from our jobs and change some variables :D13:46
*** ociuhandu has quit IRC13:47
*** ociuhandu has joined #openstack-ironic13:50
*** ociuhandu has quit IRC13:52
*** ociuhandu has joined #openstack-ironic13:52
*** mgoddard has joined #openstack-ironic13:57
*** ociuhandu has quit IRC14:04
*** ayoung has quit IRC14:05
dtantsurarne_wiebalck, TheJulia, jitter is probably a one-liner with futurist14:06
dtantsurwe just need to pick a different scheduling strategy IIRC14:06
TheJuliadtantsur: Yeah14:07
* TheJulia adds to the ptg14:07
TheJuliaalready there14:07
dtantsurmaybe Just Do It (tm)?14:08
* dtantsur wishes the strategies were better documented in https://docs.openstack.org/futurist/latest/reference/index.html#periodics14:09
* TheJulia adds more words to the ptg etherpad14:09
dtantsurlast_started_jitter is probably what we need14:09
*** ociuhandu has joined #openstack-ironic14:10
TheJuliapossibly, if we can set the base jitter factor on the size of the deployment, we would likely be golden14:11
dtantsurnot sure about the jitter factor, need to dive further14:11
TheJuliayeah, the docs render a little weird :(14:11
dtantsurI can make you a patch in like minutes14:12
TheJulia\o/14:12
dtantsurarne_wiebalck: will you be able to test?14:14
openstackgerritJulia Kreger proposed openstack/ironic master: Add prelude for Ironic 17.0.  https://review.opendev.org/c/openstack/ironic/+/78097414:15
TheJuliarpittau: ^^^14:15
*** ociuhandu has quit IRC14:15
openstackgerritJulia Kreger proposed openstack/ironic master: Version 17.0 mapping/doc updates  https://review.opendev.org/c/openstack/ironic/+/78230614:16
TheJuliajust a rebase14:16
*** ayoung has joined #openstack-ironic14:17
*** frigo has quit IRC14:19
TheJuliaiurygregory: question for you on https://review.opendev.org/c/openstack/ironic/+/77052614:20
openstackgerritDmitry Tantsur proposed openstack/ironic master: Use jitter for periodic tasks  https://review.opendev.org/c/openstack/ironic/+/78252914:21
dtantsurarne_wiebalck, TheJulia ^^14:21
openstackgerritMerged openstack/ironic master: Add known iDRAC virtual media boot issue  https://review.opendev.org/c/openstack/ironic/+/78243814:22
iurygregorylooking14:23
TheJuliaiurygregory: just posted second thing14:23
TheJuliaI likely need more coffee :)14:23
* iurygregory press f514:23
*** frigo has joined #openstack-ironic14:24
* TheJulia seriously considers going back to bed14:25
dtantsuras soon as you start seriously considering it, it's probably a good idea14:25
openstackgerritMerged openstack/python-ironicclient stable/wallaby: Fix --fields network_data  https://review.opendev.org/c/openstack/python-ironicclient/+/78213014:25
JayFI was sick for over half of last week. Let me assure you that laying down all day is overrated. At least by the third day :P14:26
rpittaufrigo: do you mind also adding the task number to the commit message in https://review.opendev.org/c/openstack/sushy-tools/+/782514 ?14:26
*** ociuhandu has joined #openstack-ironic14:27
TheJuliait gets super booring14:27
openstackgerritFrancois Rigault proposed openstack/sushy-tools master: Delete temporary file after media ejection  https://review.opendev.org/c/openstack/sushy-tools/+/78251414:28
openstackgerritFrancois Rigault proposed openstack/sushy-tools master: Delete temporary file after media ejection  https://review.opendev.org/c/openstack/sushy-tools/+/78251414:28
frigolike that rpittau ?14:30
rpittaufrigo: yes, thanks :)14:30
openstackgerritMerged openstack/bifrost master: Relax format of checksum file  https://review.opendev.org/c/openstack/bifrost/+/77857814:30
frigo\o/14:31
iurygregoryTheJulia, I've added some answers =)14:31
openstackgerritAlexander Evseev proposed openstack/bifrost master: Drop external tftp service in favor to use dnsmasq's one  https://review.opendev.org/c/openstack/bifrost/+/78253114:31
iurygregorywow ^14:32
TheJulialikely a good thing14:32
TheJuliamore people use dnsmasq now then ever before14:32
TheJuliaor ever before the older tftp services14:32
TheJuliaso...14:32
dtantsurwe do it in metal3 too14:32
dtantsurI suspect there may be upgrade concerns, let me see the patch14:32
*** ociuhandu has quit IRC14:35
TheJulialikely14:36
dtantsurbut it's always great to see complete strangers contributing14:37
TheJulia++14:37
* dtantsur wonders if Alexander is here14:37
iurygregory++14:38
dtantsurfg14:44
dtantsurmmm, won't work here, will it?14:44
TheJuliano14:44
TheJuliasadly14:44
dtantsur:(14:44
TheJuliaIf it did, would it be like putting on a VR headset?14:44
* dtantsur returns to fish14:44
dtantsurheh14:45
dtantsurbtw I've never tried one14:45
TheJuliaiurygregory: replied, one point of clarification needed. Do you mean that you wrote your unit tests execting it to already exist?14:45
iurygregoryTheJulia, yeah, we have a case where cipher_suite is not set for the node so driver_info['cipher_suite'] returns None14:46
TheJuliadtantsur: I've not tried the current generation, latest I've tried was first generation at home stuff. It was okay but since my vision is not perfect it looks blurry and i can see the pixel lines14:46
openstackgerritDmitry Tantsur proposed openstack/ironic master: [WIP] Support pre-built deploy/rescue ISO in Redfish  https://review.opendev.org/c/openstack/ironic/+/78226614:46
iurygregorybut I can change to get('cipher_suite') without problems =)14:46
*** outbrito has quit IRC14:46
TheJuliaiurygregory: so when does driver_info['cipher_suite'] get set first?14:47
iurygregoryTheJulia, https://github.com/openstack/ironic/blob/2773c5fb257f06226409e1f40c7820d98e3839ae/ironic/drivers/modules/ipmitool.py#L30614:48
TheJuliaahh14:48
TheJuliathat14:48
TheJulia\o/ for layers of indirection through naming14:48
TheJuliaiurygregory: in that case, I'd just amend the docs I guess14:49
TheJuliaw/r/t how to determine the supported cipher suites14:49
iurygregoryTheJulia, ack =) I will also add a test case with only one value in the list14:49
iurygregory=)14:49
TheJulia++14:50
*** frigo has quit IRC14:55
arne_wiebalckdtantsur: yes, I can test ... not sure if today, though15:03
mnaserdarn hmm15:06
mnasermy little raid patch seems to have not solved things (yet)15:06
mnaserdriver_internal_info does not seem to include the raid create/delte config with the right priority15:07
mnaserhttps://www.irccloud.com/pastebin/rxgq1GLE/15:08
mnasereven though it is reporting the following on startup15:08
mnaserMar 23 15:03:27 ironic-devstack ironic-conductor[25562]: DEBUG oslo_service.service [-] deploy.delete_configuration_priority = 5 {{(pid=25562) log_opt_values /usr/local/lib/python3.6/dist-packages/oslo_config/cfg.py:2589}}15:09
TheJuliahmm15:09
TheJuliacould it be loading/replacing priority from the agent itself15:10
mnaserhttps://www.irccloud.com/pastebin/FJ5O2Gmm/15:11
mnaserfollowed by15:12
mnaser[  141.209906] ironic-python-agent[442]: 2021-03-23 15:07:04.883 442 DEBUG root [-] Clean steps before deduplication: {'GenericHardwareManager': [{'step': 'erase_devices', 'priority': 10, 'interface': 'deploy', 'reboot_requested': False, 'abortable': True}, {'step': 'erase_devices_metadata', 'priority': 99, 'interface': 'deploy', 'reboot_requested': False, 'abortable': True}, {'step': 'delete_configuration',15:12
mnaser'priority': 0, 'interface': 'raid', 'reboot_requested': False, 'abortable': True}, {'step': 'create_configuration', 'priority': 0, 'interface': 'raid', 'reboot_requested': False, 'abortable': True}]} get_clean_steps /opt/ironic-python-agent/lib64/python3.6/site-packages/ironic_python_agent/extensions/clean.py:4215:12
mnaseri think the problem here is that clean_steps does not include anything except erase_devices_metadata and erase_devices15:14
openstackgerritDmitry Tantsur proposed openstack/ironic master: Support pre-built deploy/rescue ISO in Redfish  https://review.opendev.org/c/openstack/ironic/+/78226615:15
dtantsurTheJulia: would be cool to fit in wallaby ^^15:15
dtantsurmnaser: I have a vague feeling that automated in-band cleaning filtered out interfaces other than 'deploy'15:15
dtantsurbut don't quote me on that15:15
mnaseri'm trying to find the code that sets clean_steps for automated in-band cleaning15:16
dtantsurmnaser: look in ironic/drivers/modules/agent_base.py15:17
*** mkrai has joined #openstack-ironic15:17
dtantsurmnaser: https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/agent_base.py#L87315:18
dtantsurinterface='deploy'15:18
dtantsurI may be responsible for this code, and no, I don't remember why15:18
* dtantsur wonders if mgoddard remembers15:18
mnaserdtantsur: this is because raid is interface='raid' and so it wont include that step, right?15:20
mgoddarddtantsur: isn't it just that the deploy interface gathers all in-band steps?15:20
mgoddardmaybe not15:21
dtantsurmnaser: correct15:22
* mnaser is git blaming 15:22
arne_wiebalckTheJulia: software RAID and UEFI, something which we just ran into is that the ESPs get out of sync (which I considered to be a non-issue as the grub-efi.cfg is not in the ESP, but it seems it is ...) So, if the node is not booted in a while, but has updated kernels several times, the UEFI f/w may use an ESP which points to non-existing kernels ... or am I missing sth here?15:23
arne_wiebalckTheJulia: This results in nodes which do not boot.15:23
* TheJulia sighs15:24
mnaserdtantsur: https://opendev.org/openstack/ironic/commit/a19e9ce6759b018025790ca91b200796f63bb7eb this looks like the change that made it enforce deploy steps only15:24
mnaserit actually looks like it changed the behaviour then15:24
arne_wiebalckTheJulia: I did not understand initially why we never had an issue so far, but I think it only is a problem  when a sufficient number  of kernels is installed, so that the non-update ESP has only references to meanwhile deleted kernels.15:25
mnaseroh nevermind, it was already filtering for deploy before15:25
* mnaser does more git blaming15:25
mgoddarddtantsur: perhaps there was an intention to write a similar get_deploy_steps hook for other interfaces?15:26
mgoddardthat would make in-band raid steps appear on the raid interface15:26
TheJuliaarne_wiebalck: well... basically grub is doing stuff which will cause problems because its use model is predicated upon either the storage being reliable and redundant to begin with, or not at all and not caring. software raid is a unfortunate victim in this circumstance15:26
arne_wiebalckTheJulia: I think whatever updates grub-efi.cfg needs to search and update all ESPs.15:27
mnaserhttps://opendev.org/openstack/ironic/commit/534d9ee96ac738f24a23087a26c98804934ea72d -- looks like i went back 6 years ago15:27
mnaserand the first addition has "Filter steps to only return deploy steps"15:27
TheJuliaarne_wiebalck: that would take require convincing grub maintainers and their last thing was to actually break grub2-install instead of keeping compatability15:28
mnaserhttps://review.opendev.org/c/openstack/ironic/+/161453/19/ironic/drivers/modules/deploy_utils.py15:28
TheJuliaso.... I don't know how much success we will have, but the case can be made15:28
arne_wiebalckTheJulia: so, just to confirm we have an actual issue here, right?15:28
arne_wiebalckTheJulia: users will run into this sooner or later15:29
TheJulia?possibly?15:29
mnaserdtantsur / mgoddard: think it would make sense to append get_steps(..., interface='raid') into https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/agent_base.py#L858-L860 ?15:29
arne_wiebalckTheJulia: :-D15:29
arne_wiebalckTheJulia: what we could do is make the ESP a RAID-1 device, rather than two independent devices15:29
TheJuliaThat may be the only way15:30
arne_wiebalckTheJulia: the kernel would assemble it, and updates go to both disks15:30
dtantsuror use interface='deploy' for RAID steps, like in https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/hardware.py#L1877 ?15:30
TheJuliathe question may be 1) does the firmware see through it, and 2) can the firmware still mount it15:30
arne_wiebalckTheJulia: the UEFI f/w would not assemble the RAID but still be able to read it15:30
arne_wiebalckTheJulia: yes, this works15:30
arne_wiebalckTheJulia: our Ceph team does have a RAID1 ESP15:31
TheJuliaI'm not sure all platforms will be okay with the raid header15:31
dtantsurmnaser: an argument could be made that any deploy step coming from IPA should have interface='deploy'15:31
arne_wiebalckTheJulia: the header needs to be at the end15:31
TheJuliaarne_wiebalck: that is a relatively good sign15:31
TheJulia++15:31
dtantsur(although the same argument does not apply to clean steps, soooo)15:31
* dtantsur is confused15:31
mnaserdtantsur: yeah, and i guess the 'raid' interface is a thing because hardware raid can be a thing too15:31
*** mkrai has quit IRC15:32
mnaserso technically, as part of automated cleaning, you may actually want hardware raid steps to happen automagically15:32
dtantsurmnaser: well, yes, exactly. if you set raid_interface='idrac', you probably don't want software RAID to happen15:32
arne_wiebalckTheJulia: the only other (clonky) option is to mount ESPs regularly and sync15:32
*** mkrai has joined #openstack-ironic15:32
arne_wiebalckTheJulia: the only other option I see atm15:32
mnaserdtantsur: so either move raid steps to deploy interface or add get_steps(...,interface=raid)15:33
TheJuliaarne_wiebalck: I think we're going to need to backport a lot of grub/esp/uefi patches soon, so I think we may just bbackport this fix as well once we have it15:33
dtantsurmnaser: remind me, what exactly are you trying?15:33
mnaserdtantsur: i want to make automated cleaning actually delete_configuration for software raid, then run the disk wipes/etc, and then create_configuration again15:33
mnaserdtantsur: i did this https://opendev.org/openstack/ironic/commit/6ba1ecad17bea362f4f9ea8f1641e9d6d87bcfb8 but it looks like it's pretty much broken, because interface=raid15:34
mnaserso we're not really overriding anything by doing that15:34
arne_wiebalckTheJulia: ok ... I will first need to fix our ESP manually now to prevent more damage ...15:34
dtantsurokay, so automated cleaning and RAID..15:34
mgoddardI think the simplest option is to set interface=deploy in the HW manager, as dtantsur suggested15:35
arne_wiebalckTheJulia: ESPs ... plural ... many15:35
TheJuliaarne_wiebalck: good luck15:35
dtantsurmnaser: I think you need to update the 'agent' RAID interface with its own get_clean_steps.15:35
mgoddarddtantsur: +1, I think that's the 'correct' fix15:35
dtantsurmnaser: it could be that doing https://opendev.org/openstack/ironic/commit/6ba1ecad17bea362f4f9ea8f1641e9d6d87bcfb8 in the deploy interface is not right15:35
mgoddardbecause then the steps correctly show as being raid steps15:36
mgoddardand interface priorities will work15:36
dtantsuryes, and you don't get conflicts with hardware RAID15:36
mnasermgoddard: will they work though? even if i have get_steps(..., interface='deploy') there?15:36
dtantsurmnaser: no, in the RAID interface you need to use interface='raid'15:36
openstackgerritMerged openstack/python-ironicclient stable/victoria: Fix --fields network_data  https://review.opendev.org/c/openstack/python-ironicclient/+/78213115:36
mnaserso get_clean_steps inside the raid interface15:36
dtantsurpretty much a copy of get_deploy_steps with s/deploy/raid/15:36
dtantsuryes15:36
mnaserand get rid of the ones i added inside agent_base.py15:37
dtantsurI think so15:37
openstackgerritMerged openstack/ironic master: Add prelude for Ironic 17.0.  https://review.opendev.org/c/openstack/ironic/+/78097415:37
*** irclogbot_3 has quit IRC15:37
*** irclogbot_1 has joined #openstack-ironic15:38
TheJulia - Failed: 6048 \o/15:41
TheJuliahmmm15:43
TheJuliaanyone having issues on train if they rebuild their tox environment?15:43
mnaserhttps://www.irccloud.com/pastebin/5XG3Zj6m/15:43
mnaserdtantsur, mgoddard ^ going to try the above15:44
mnaserMar 23 15:44:45 ironic-devstack ironic-conductor[27273]: DEBUG ironic.drivers.base [None req-baa9c114-5eb8-4d77-8142-37d37687a643 None None] Found clean steps [{'step': 'create_configuration', 'priority': 0, 'abortable': False, 'argsinfo': None, 'interface': 'raid'}, {'step': 'delete_configuration', 'priority': 0, 'abortable': False, 'argsinfo': None, 'interface': 'raid'}] for interface raid {{(pid=27273)15:45
mnaser__new__ /opt/stack/ironic/ironic/drivers/base.py:261}}15:45
mnaserok.. ok.. looking good15:45
mnaserif that works, i wonder if i should move the config option to [raid]/create_configuration_priority ..15:46
openstackgerritJulia Kreger proposed openstack/ironic stable/train: Fixes the issue that instance bond port can't get IP address  https://review.opendev.org/c/openstack/ironic/+/78254315:49
mnaserhttps://www.irccloud.com/pastebin/llHYnZKB/15:49
mnaseryay thanks mgoddard / dtantsur ! :D15:49
*** irclogbot_1 has quit IRC15:49
mnaserironic_python_agent.errors.CleaningError: Clean step failed: Error performing clean_step create_configuration: Software RAID caused unknown error: Could not validate Software RAID config for f09c61e0-42bf-422d-acf0-375a3974e913: Software RAID Configuration requires RAID-1 for the first logical disk15:50
mnaserthat's just me being a bit slow this morning i guess15:50
*** mkrai has quit IRC15:51
* TheJulia sighs at backports that all have to be done manually15:52
*** irclogbot_0 has joined #openstack-ironic15:52
*** ociuhandu has joined #openstack-ironic15:56
dtantsurmnaser: np, yeah, the patch looks about right15:58
mnaseri'll test this here more and then propose a patch15:58
mnaserwith passing tests, etc.15:58
*** dking has quit IRC16:01
iurygregoryTheJulia, maybe because it's trying to run a base python3 train doesn't support?16:05
TheJuliaiurygregory: that is what I'm thinking as well16:05
iurygregoryIf I try locally will use 3.9 and things will *boom*16:05
TheJuliabut it errors in kombu...16:05
TheJuliaand import_lib16:05
iurygregorydo you have a link for the patch? I can run locally16:06
openstackgerritJulia Kreger proposed openstack/ironic stable/victoria: IPMI: Handle vendor set boot device differences  https://review.opendev.org/c/openstack/ironic/+/78254716:06
dtantsurTheJulia: I seem to recall these problems, yes16:08
dtantsurI tend to set basepython = python2 when dealing with train16:08
iurygregorymaybe worth setting in the tox.ini of stable/train =D16:08
rpittaummm that should be needed for pep8 only though16:08
iurygregoryeither python3.x or python216:09
TheJuliaI only have 3.8 right now16:09
TheJuliabut I could have sworn I ran tests last week16:09
iurygregory*magic*16:09
rpittauTheJulia: I think it would be worth to add ignore_basepython_conflict=true to tox.ini, otherwise it will ignore the python version you want to test and use the default one you have16:10
rpittauso if you run tox -epy27 but you have python 3.8, will run with python 3.816:11
rpittauthe problem is that I think oyu need also to increase the tox minversion16:11
TheJuliaI don't even think I have py216:12
openstackgerritDmitry Tantsur proposed openstack/ironic master: Support deploy vendor data in addition to network data  https://review.opendev.org/c/openstack/ironic/+/78254816:12
dtantsurdunno if it's a good idea or not, but it came to me ^^16:12
TheJuliaI've been going down the list of pending community identified backports and doing the needful. We keep forgetting to tag these things, so hopefully we'll get better with backport candidate16:13
dtantsuryeah, a tag is helpful when a backport is not trivial16:13
rpittauTheJulia: I just verified, the unit tests should run correctly locally, so I gues something weird with that patch16:15
TheJuliaOn a different patch I'm having issues on ussuri now, but it may just be transient16:16
* TheJulia re-runs16:16
iurygregoryI'm writting some script to add a hashtag to patches with the backport-candidate label16:17
iurygregoryWIP =)16:17
dtantsuriurygregory: why a hashtag?16:18
TheJuliaI think it was the consensus from a meeting like 1.5 months ago16:19
dtantsurI mean, we can filter by the label itself, no?16:19
dtantsurwhy another hash tag?16:19
iurygregorydtantsur, it would be easier to track with the tag I would say =)16:19
iurygregorywe can ofc look at just the label =)16:20
dtantsuriurygregory: well, if we create an ironic specific tag, yes16:20
iurygregoryif it's set or not =)16:20
iurygregoryironic-backport16:20
TheJuliai though twe were going to use the same tag16:20
iurygregoryironic-week-prio? .-.16:20
dtantsurbackports != weekly priorities16:20
iurygregoryyeah ^16:20
TheJuliatrue16:20
dtantsurdifferent actions needed16:20
dtantsurI agree with a new tag, but JFYI https://review.opendev.org/q/project:openstack/ironic+label:Backport-Candidate%252B116:20
rpittauI thought the tag was decided just for the priorities16:21
iurygregoryironic-week-prio it is16:21
rpittauyeah, jsut that16:21
iurygregoryhumm the url is not that bad =D16:21
TheJuliadtantsur: I tagged it because that is something that we absolutley need to get backported as grub is making hard breaking changes that are starting to filter in... :(16:21
TheJuliaThus, is a candidate :(16:22
iurygregorybut we would need the project set.. if my script works we would just search using a new hashtag and would cover all ironic projects16:23
dtantsurTheJulia: yeah, I'm showing how to use a label in queries16:23
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent master: Refactor: use mounted from ironic-lib  https://review.opendev.org/c/openstack/ironic-python-agent/+/78225916:24
TheJuliaoh16:24
TheJuliaokay16:24
TheJuliayeah16:24
TheJuliahmm16:24
iurygregoryand I was also thinking about working on the script to remove the ironic-week-prio after the patch is merged16:25
*** moshiur has quit IRC16:25
iurygregoryI think it would make sense16:26
TheJuliagah16:26
TheJuliaI see what happened and why things are so weird16:26
iurygregorythis is a good thing ^16:26
TheJuliawe need to be really careful with backports making sure there were no prior patches that also need to be backported that the patch is based upon16:26
TheJuliaexample: detect_vendor16:26
iurygregoryyeah16:26
TheJuliaor if there are, to grab them too16:27
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent master: [WIP] Hardware manager call to load configuration from vmedia  https://review.opendev.org/c/openstack/ironic-python-agent/+/78226216:27
dtantsurlooking at https://zuul.opendev.org/t/openstack/build/81cd79ceac694b2fbc400b42e0ef2e83/log/controller/logs/screen-ir-cond.txt (with jitter), periodic tasks do start to slowly drift away16:30
dtantsurbut it probably doesn't solve the restart problem since the maximum jitter is 5%16:30
rpittaudtantsur: https://bugs.python.org/issue3502216:30
dtantsurrpittau++16:31
TheJuliadtantsur: I think we can do that as a separate patch16:32
dtantsurre jitter?16:32
TheJuliadtantsur: I've been thinking a startup "size the deployment and hold the initailization for random second window based upon the size"16:32
dtantsurTheJulia: I was more thinking about randomizing the starting point of each periodic16:33
TheJulialike 1 second per conductor if >5 conductors or something like that16:33
dtantsurso that they a fixed but random distance apart16:33
TheJuliaand multiple by # of nodes or something like that16:33
dtantsuryou don't know the number of nodes on start-up16:33
TheJuliayeah16:33
TheJuliaI was thinking at least on conductor based data16:33
TheJuliaand maybe doing an index based count from the db which is an easy query16:33
TheJuliaselect count(id) from nodes;16:34
dtantsur*shrug* just randomizing it is probably easier16:34
TheJuliamaybe yeah16:34
* dtantsur tries one crazy idea16:34
TheJuliaI want it to be semi-aware so we give enough of a space window for some conductors to restart to naturally allow things to spread out to begin with16:35
dtantsuroh, well, of course futurist doesn't allow a custom strategy..16:35
dtantsura random offset for each periodics solves more problems: it reduces load peaks because of periodic tasks16:36
TheJuliayeah, I'm thinking something baked really early on in startup16:37
TheJuliabut yeah16:37
TheJuliaonly ideas, haven't tried to hack on it yet16:37
dtantsurI'll try my idea with a fixed offset16:37
TheJuliak16:37
openstackgerritMohammed Naser proposed openstack/ironic master: Allow running RAID cleaning steps with in-band cleaning  https://review.opendev.org/c/openstack/ironic/+/78255216:37
mnaserTheJulia / dtantsur / arne_wiebalck / mgoddard: ^ that works for me here locally16:40
dtantsurgreat16:40
mnaserhttps://www.irccloud.com/pastebin/TMGHkKtF/16:41
mnaserlooks awesome :)16:41
dtantsur:)16:46
TheJulia\o/16:48
*** uzumaki has joined #openstack-ironic16:57
*** lucasagomes has quit IRC17:00
*** iurygregory has quit IRC17:02
dtantsurTheJulia: I'm starting to think that a proper jitter is hard to implement without futurist changes :(17:04
*** ociuhandu_ has joined #openstack-ironic17:10
*** ociuhandu has quit IRC17:14
*** ociuhandu_ has quit IRC17:15
rpittaugood night! o/17:26
*** rpittau is now known as rpittau|afk17:26
*** iurygregory has joined #openstack-ironic17:29
*** uzumaki has quit IRC17:31
*** frigo has joined #openstack-ironic17:35
TheJuliadtantsur: start jitter, or proper jitter upfront? or jitter in general?17:41
dtantsurproper jitter upfront, I guess17:41
dtantsurwe can add jitter to spacing, but it's not exactly what we need17:42
TheJuliaI'm not sure we really can or *should* I guess17:42
TheJuliayay for moderately nebulous problems17:42
dtantsurif futurist allowed that, it would solve most of the problems17:42
TheJuliayeah17:42
dtantsurnow.. short of adding a sleep before each periodic task, I have no other ideas :)17:42
dtantsurautomating a sleep is something I can do, dunno how ugly it is17:43
TheJuliathat seems ugly17:44
dtantsurI can look into changing futurist, but it won't be backportable17:45
TheJuliaso hash ring population is part of the very start of the headache and the herd thundering17:45
TheJuliaso maybe not change futurist, but do the jitter that can evolve on its own in with the existing periodics, and then separately handle the startup behavior since that select can vary from 30seconds to 5 minutes in arne's deployment if they all collide17:46
TheJuliai guess what I'm saying is disjoint he problems17:47
TheJulias/he/the/17:47
TheJuliathey are definitely related, but they can be solved separately and the initial start would setup the later ones to be perfectly fine17:47
TheJuliaand arne shoudl end up with a even line on his graphs in the end17:47
TheJulia3 hour spans of meetings is just a bad idea17:47
openstackgerritAija Jauntēva proposed openstack/ironic master: Add configuration mold storage  https://review.opendev.org/c/openstack/ironic/+/76992817:57
TheJuliareviewjam?17:59
*** derekh has quit IRC18:03
openstackgerritAija Jauntēva proposed openstack/ironic master: Add import, export configuration to idrac-redfish  https://review.opendev.org/c/openstack/ironic/+/75942818:10
openstackgerritFrancois Rigault proposed openstack/sushy-tools master: Return an integer value for Cores and Threads  https://review.opendev.org/c/openstack/sushy-tools/+/78257718:14
openstackgerritFrancois Rigault proposed openstack/ironic-inspector master: [wip] Use port.id instead of port.uuid  https://review.opendev.org/c/openstack/ironic-inspector/+/78258018:20
arne_wiebalckAdded jitter manually to cut off the spikes. Looks even better then pre-update now :) https://usercontent.irccloud-cdn.com/file/Id7ZlkBH/ussuri_upgrade_db.png18:45
arne_wiebalcks/then/than/18:45
*** dtantsur is now known as dtantsur|afk18:55
*** dtantsur|afk is now known as dtantsur|afk|afk18:55
*** dtantsur|afk|afk is now known as dtantsur|afk18:55
*** frigo has quit IRC19:04
openstackgerritMerged openstack/ironic-python-agent master: Refactor: use mounted from ironic-lib  https://review.opendev.org/c/openstack/ironic-python-agent/+/78225920:14
*** frigo has joined #openstack-ironic20:30
openstackgerritMohammed Naser proposed openstack/ironic master: Allow running RAID cleaning steps with in-band cleaning  https://review.opendev.org/c/openstack/ironic/+/78255220:35
*** ociuhandu has joined #openstack-ironic20:39
*** frigo has quit IRC20:42
*** lmcgann has quit IRC20:53
stevebakerTheJulia: oh, what do you think of backporting IPA token support to stable/train, to make local development with new ironic easier20:58
stevebaker(it might be too hard)20:58
*** rcernin has joined #openstack-ironic21:01
JayFThat seems like the sort of thing that would be invalid to backport21:03
JayFI'd certainly not be a fan of that change going that far back...21:04
*** ociuhandu has quit IRC21:05
TheJuliaYeah, I wouldn't try to backport that21:06
TheJuliait was intended kind of to be a hard delimiter, even though it would make some development stuff harder it was also to enforce the support boundry established as well21:08
* TheJulia suspects she will just pickup the backport list tomorrow21:10
*** ociuhandu has joined #openstack-ironic21:11
TheJuliastevebaker: I mentioned this briefly on the call we were just on, but I've been going through "we should backport this" list on the whiteboard and trying to close those things out21:12
TheJuliaAnywya, will resume with ipmi stuffs tomorrow21:15
*** rcernin has quit IRC21:16
*** ociuhandu has quit IRC21:16
* TheJulia goes and exercises now that the migraine has actually subsided21:16
*** rcernin has joined #openstack-ironic21:46
*** rloo has quit IRC22:02
*** rcernin has quit IRC22:10
*** rcernin has joined #openstack-ironic22:10
*** hoonetorg has joined #openstack-ironic22:53
*** jamesden_ has quit IRC23:16
*** jamesdenton has joined #openstack-ironic23:17
openstackgerritMerged openstack/ironic master: Version 17.0 mapping/doc updates  https://review.opendev.org/c/openstack/ironic/+/78230623:36
openstackgerritFrancois Rigault proposed openstack/ironic-inspector master: Use port.id instead of port.uuid  https://review.opendev.org/c/openstack/ironic-inspector/+/78258023:43
jandersgood morning Ironic o/23:48
stevebakergood afternoon23:49

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!