| iurygregory | woot ironic-tempest-partition-uefi-redfish-vmedia green on 783722 (in a few minutes the last job should finish) | 00:51 |
|---|---|---|
| TheJulia | iurygregory: of course | 00:53 |
| TheJulia | except... metalsmith timed out | 00:53 |
| TheJulia | :( | 00:53 |
| TheJulia | a recheck soon | 00:53 |
| iurygregory | D: | 00:54 |
| janders | fingers crossed | 00:57 |
| *** gyee has quit IRC | 01:01 | |
| *** jamesdenton has quit IRC | 01:04 | |
| *** jamesden_ has joined #openstack-ironic | 01:05 | |
| *** iurygregory has quit IRC | 01:16 | |
| *** iurygregory has joined #openstack-ironic | 01:17 | |
| *** iurygregory has quit IRC | 01:18 | |
| *** iurygregory has joined #openstack-ironic | 01:18 | |
| openstackgerrit | Merged openstack/ironic-python-agent stable/ussuri: Mount all vfat partitions before calling grub2 https://review.opendev.org/c/openstack/ironic-python-agent/+/782349 | 01:58 |
| *** iurygregory has quit IRC | 02:08 | |
| *** iurygregory has joined #openstack-ironic | 02:09 | |
| *** uzumaki has quit IRC | 02:13 | |
| *** rcernin has quit IRC | 02:31 | |
| *** mkrai has joined #openstack-ironic | 02:33 | |
| openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Add iDRAC management via Redfish to idrac HW type https://review.opendev.org/c/openstack/ironic/+/721593 | 02:35 |
| openstackgerrit | Merged openstack/ironic-python-agent stable/ussuri: More refactoring of the image module https://review.opendev.org/c/openstack/ironic-python-agent/+/782350 | 02:36 |
| openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Option to enable bootloader config failure bypass https://review.opendev.org/c/openstack/ironic-python-agent/+/781569 | 02:36 |
| openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Prevent broken partition image UEFI deploys https://review.opendev.org/c/openstack/ironic-python-agent/+/782351 | 02:36 |
| openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Add fstab pointer to EFI partition https://review.opendev.org/c/openstack/ironic-python-agent/+/782352 | 02:36 |
| *** rcernin has joined #openstack-ironic | 02:38 | |
| *** mkrai has joined #openstack-ironic | 02:52 | |
| *** mkrai has quit IRC | 02:54 | |
| *** mkrai_ has joined #openstack-ironic | 02:54 | |
| *** rcernin has quit IRC | 03:07 | |
| *** rcernin has joined #openstack-ironic | 03:07 | |
| *** rcernin has quit IRC | 03:07 | |
| *** akahat has quit IRC | 03:08 | |
| *** rcernin has joined #openstack-ironic | 03:09 | |
| *** rcernin has quit IRC | 03:11 | |
| *** rcernin has joined #openstack-ironic | 03:12 | |
| *** rcernin has quit IRC | 03:14 | |
| *** rcernin has joined #openstack-ironic | 03:14 | |
| *** rcernin has quit IRC | 03:16 | |
| *** rcernin has joined #openstack-ironic | 03:16 | |
| *** rcernin has quit IRC | 03:18 | |
| *** rcernin has joined #openstack-ironic | 03:19 | |
| *** akahat has joined #openstack-ironic | 03:22 | |
| zer0c00l|afk | looks like the vmedia build is still borken | 03:37 |
| zer0c00l|afk | is there anything i could do to help | 03:37 |
| *** zer0c00l|afk is now known as zer0c00l | 03:38 | |
| janders | looks like https://review.opendev.org/c/openstack/ironic/+/783722 is now successfully verified and it's being merged | 03:49 |
| janders | fingers crossed | 03:49 |
| zer0c00l | janders: thanks | 03:49 |
| TheJulia | Well, In the gate according to zuul dashboard | 03:56 |
| TheJulia | https://zuul.opendev.org/t/openstack/status#783722 | 03:57 |
| TheJulia | odds are ~1.5 hours and then recheck all the +2'ed things | 03:57 |
| openstackgerrit | Jacob Anders proposed openstack/ironic master: Generic way to configure clean step priorites https://review.opendev.org/c/openstack/ironic/+/744117 | 04:12 |
| janders | stevebaker I applied your recommendations i/r/t unit tests in ^ - if you have time have a look and let me know if you'd like me to make any further changes. Thanks! | 04:12 |
| janders | meanwhile I will do one final (hopefully) lab test - spent all of yesterday fighting issues that would only happen in the lab and only with a specific config, should be all fixed now | 04:15 |
| janders | lab test worked | 04:26 |
| stevebaker | janders: ok, thanks | 04:44 |
| *** mkrai_ has quit IRC | 04:44 | |
| *** mkrai has joined #openstack-ironic | 04:45 | |
| janders | stevebaker thank you! :) | 04:50 |
| janders | all good points | 04:53 |
| openstackgerrit | Merged openstack/ironic master: Always add 'boot_method' vmedia in redfish/ilo vmedia boot https://review.opendev.org/c/openstack/ironic/+/783722 | 05:19 |
| janders | ^ \o/ | 05:20 |
| openstackgerrit | Merged openstack/ironic-python-agent master: Make the virtual media job voting https://review.opendev.org/c/openstack/ironic-python-agent/+/783834 | 05:20 |
| openstackgerrit | Merged openstack/ironic master: Fix configuration generation for ironic doc pages https://review.opendev.org/c/openstack/ironic/+/783756 | 05:36 |
| *** uzumaki has joined #openstack-ironic | 05:39 | |
| *** paras333 has joined #openstack-ironic | 05:40 | |
| TheJulia | Rechecked the rest of the review priorities | 05:43 |
| * TheJulia goes to bed | 05:43 | |
| *** paras333 has quit IRC | 05:44 | |
| janders | have a good break TheJulia :) | 05:55 |
| *** tzumainn has quit IRC | 06:22 | |
| zer0c00l | thanks! | 06:30 |
| arne_wiebalck | Good morning, ironic! | 06:32 |
| janders | hey arne_wiebalck o/ | 06:33 |
| openstackgerrit | Merged openstack/ironic-python-agent stable/ussuri: Option to enable bootloader config failure bypass https://review.opendev.org/c/openstack/ironic-python-agent/+/781569 | 06:33 |
| openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Prevent broken partition image UEFI deploys https://review.opendev.org/c/openstack/ironic-python-agent/+/782351 | 06:34 |
| arne_wiebalck | hey janders o/ | 06:34 |
| openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Add fstab pointer to EFI partition https://review.opendev.org/c/openstack/ironic-python-agent/+/782352 | 06:34 |
| *** paras3___ has joined #openstack-ironic | 06:40 | |
| *** paras3___ has quit IRC | 06:40 | |
| *** paras33__ has joined #openstack-ironic | 06:41 | |
| *** uzumaki has quit IRC | 06:53 | |
| *** mkrai has quit IRC | 06:57 | |
| *** jamesden_ has quit IRC | 07:08 | |
| *** jamesdenton has joined #openstack-ironic | 07:09 | |
| *** paras33__ has quit IRC | 07:15 | |
| *** rcernin has quit IRC | 07:25 | |
| *** tosky has joined #openstack-ironic | 07:33 | |
| *** ociuhandu has joined #openstack-ironic | 08:07 | |
| *** lucasagomes has joined #openstack-ironic | 08:09 | |
| openstackgerrit | Verification of a change to openstack/ironic failed: Add import, export configuration to idrac-redfish https://review.opendev.org/c/openstack/ironic/+/759428 | 08:13 |
| openstackgerrit | Kafilat Adeleke proposed openstack/ironic master: Aliases for a few unfortunately named state transitions https://review.opendev.org/c/openstack/ironic/+/784024 | 08:18 |
| *** derekh has joined #openstack-ironic | 08:30 | |
| *** ociuhandu has quit IRC | 08:36 | |
| *** mkrai has joined #openstack-ironic | 08:42 | |
| arne_wiebalck | TheJulia: stevebaker: Looking at this one https://review.opendev.org/c/openstack/ironic-python-agent/+/748260 once more: the ESP from the image uses the same UUID (right?), so while we may be lucky that the disk ESP will be mounted first, there is no real protection from having the partition inside the image mounted in addition I think ... | 08:43 |
| *** ociuhandu has joined #openstack-ironic | 08:52 | |
| *** ociuhandu has quit IRC | 08:53 | |
| *** ociuhandu has joined #openstack-ironic | 08:55 | |
| *** derekh has quit IRC | 09:21 | |
| *** derekh has joined #openstack-ironic | 09:21 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/bifrost stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/bifrost/+/784032 | 09:23 |
| openstackgerrit | OpenStack Release Bot proposed openstack/bifrost stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/bifrost/+/784033 | 09:23 |
| openstackgerrit | OpenStack Release Bot proposed openstack/bifrost master: Update master for stable/wallaby https://review.opendev.org/c/openstack/bifrost/+/784034 | 09:23 |
| openstackgerrit | OpenStack Release Bot proposed openstack/bifrost master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/bifrost/+/784035 | 09:23 |
| janders | wooohoo https://review.opendev.org/c/openstack/ironic/+/744117 CI is alive! reviews would be very welcome :) | 09:37 |
| *** rcernin has joined #openstack-ironic | 10:06 | |
| *** rcernin has quit IRC | 10:08 | |
| *** rcernin has joined #openstack-ironic | 10:08 | |
| *** jamesdenton has quit IRC | 10:20 | |
| *** jamesden_ has joined #openstack-ironic | 10:21 | |
| *** derekh has quit IRC | 10:26 | |
| *** derekh has joined #openstack-ironic | 10:26 | |
| *** k_mouza has joined #openstack-ironic | 10:30 | |
| iurygregory | good morning Ironic o/ | 10:38 |
| *** mkrai has quit IRC | 10:46 | |
| janders | hey iurygregory | 10:50 |
| iurygregory | janders, o/ | 10:50 |
| *** mugsie__ is now known as mugsie | 11:01 | |
| *** ociuhandu has quit IRC | 11:13 | |
| arne_wiebalck | bye everyone o/ | 11:17 |
| *** uzumaki has joined #openstack-ironic | 11:17 | |
| iurygregory | bye arne_wiebalck o/ | 11:18 |
| *** uzumaki has quit IRC | 11:19 | |
| *** k_mouza has quit IRC | 11:19 | |
| *** ociuhandu has joined #openstack-ironic | 11:29 | |
| *** ociuhandu has quit IRC | 11:34 | |
| *** dtantsur|afk is now known as dtantsur | 11:34 | |
| dtantsur | hi folks | 11:34 |
| * dtantsur had an early start and then a mid-day break | 11:35 | |
| dtantsur | folks, where do we stand with regards to the final releases? | 11:36 |
| *** k_mouza has joined #openstack-ironic | 11:37 | |
| *** k_mouza has quit IRC | 11:37 | |
| *** k_mouza has joined #openstack-ironic | 11:37 | |
| dtantsur | I assume https://review.opendev.org/c/openstack/ironic/+/759428 will make it | 11:39 |
| iurygregory | I'm wondering if we can hold the ironic release till tomorrow / later today for https://review.opendev.org/c/openstack/ironic/+/744117 | 11:40 |
| dtantsur | I'm reviewing it now | 11:40 |
| iurygregory | and maybe https://review.opendev.org/c/openstack/ironic/+/783759 | 11:40 |
| iurygregory | (CI should give +1 since it's back to normal) | 11:40 |
| dtantsur | priority overrides looks good to me | 11:41 |
| iurygregory | I will check in a few after some meetings | 11:41 |
| iurygregory | I can push the final release also (if you haven't done or if you really want to do it hehe) | 11:42 |
| dtantsur | I haven't done it, we have patches from the release team that can be updated | 11:43 |
| dtantsur | https://review.opendev.org/c/openstack/releases/+/783696 and https://review.opendev.org/c/openstack/releases/+/783675 | 11:43 |
| dtantsur | iurygregory: if you could review https://review.opendev.org/c/openstack/ironic/+/744117 we can add it | 11:43 |
| iurygregory | ack | 11:43 |
| iurygregory | yeah I will do in a few (almost 1:1 time) | 11:44 |
| ajya | can also this be included - https://review.opendev.org/c/openstack/ironic/+/721593 ? | 11:45 |
| *** ociuhandu has joined #openstack-ironic | 11:45 | |
| *** ociuhandu has quit IRC | 11:50 | |
| openstackgerrit | Merged openstack/ironic master: Add import, export configuration to idrac-redfish https://review.opendev.org/c/openstack/ironic/+/759428 | 11:53 |
| openstackgerrit | Merged openstack/ironic-inspector master: Update master for stable/wallaby https://review.opendev.org/c/openstack/ironic-inspector/+/783953 | 11:53 |
| openstackgerrit | Merged openstack/ironic-inspector stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/ironic-inspector/+/783951 | 11:53 |
| openstackgerrit | Merged openstack/ironic-inspector stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/ironic-inspector/+/783952 | 11:53 |
| *** sshnaidm|off is now known as sshnaidm | 11:57 | |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic master: Follow-up Automaticaly set cipher suite https://review.opendev.org/c/openstack/ironic/+/783759 | 11:58 |
| dtantsur | ajya: it's in merge conflict.. I'd like to include it, but it seems unlikely at this point | 12:01 |
| *** ociuhandu has joined #openstack-ironic | 12:01 | |
| dtantsur | iurygregory: thank you for updating, you overdid it a bit :) | 12:02 |
| *** ociuhandu has quit IRC | 12:10 | |
| rpioso | dtantsur: We're rebasing it. | 12:15 |
| janders | dtantsur iurygregory thanks for looking into https://review.opendev.org/c/openstack/ironic/+/744117 - much appreciated! :) | 12:26 |
| dtantsur | np, why are you still not asleep? :) | 12:26 |
| *** abhishekyadav has joined #openstack-ironic | 12:28 | |
| janders | just about to wrap up :) | 12:28 |
| *** kamlesh_chauvhan has joined #openstack-ironic | 12:29 | |
| *** kamlesh_chauvhan has quit IRC | 12:30 | |
| dtantsur | janders: re whether we need overrides for deploy steps: we have use cases for that | 12:30 |
| *** kamlesh_chauvhan has joined #openstack-ironic | 12:30 | |
| dtantsur | like running RAID setup in deploy time | 12:30 |
| iurygregory | dtantsur, ouch, sorry! | 12:31 |
| *** rcernin has quit IRC | 12:31 | |
| openstackgerrit | Merged openstack/bifrost stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/bifrost/+/784032 | 12:32 |
| janders | dtantsur that's great! | 12:32 |
| janders | well worth the extra work then | 12:33 |
| openstackgerrit | Merged openstack/bifrost master: Update master for stable/wallaby https://review.opendev.org/c/openstack/bifrost/+/784034 | 12:33 |
| janders | see you tomorrow Ironic o/ | 12:35 |
| *** kamlesh_chauvhan has quit IRC | 12:38 | |
| openstackgerrit | Merged openstack/bifrost master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/bifrost/+/784035 | 12:47 |
| openstackgerrit | Merged openstack/bifrost stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/bifrost/+/784033 | 12:47 |
| openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Add iDRAC management via Redfish to idrac HW type https://review.opendev.org/c/openstack/ironic/+/721593 | 13:02 |
| openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Add iDRAC management via Redfish to idrac HW type https://review.opendev.org/c/openstack/ironic/+/721593 | 13:06 |
| openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Add iDRAC management via Redfish to idrac HW type https://review.opendev.org/c/openstack/ironic/+/721593 | 13:08 |
| dtantsur | iurygregory: if you have a second, could you amend https://review.opendev.org/c/openstack/releases/+/783675 with an IPA release? | 13:15 |
| openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Add iDRAC management via Redfish to idrac HW type https://review.opendev.org/c/openstack/ironic/+/721593 | 13:15 |
| dtantsur | we can wait a few more hours with ironic, but the release team is already pinging us | 13:15 |
| iurygregory | dtantsur, right after the metal3 meeting I can do it | 13:16 |
| dtantsur | thank you | 13:16 |
| dtantsur | yeah, I somehow forgot you're on the same meeting :D | 13:16 |
| rpioso | dtantsur: The rebase of https://review.opendev.org/c/openstack/ironic/+/721593 has been completed. | 13:17 |
| dtantsur | It may be a bit late, sorry. We have a pressure to finish the release today, and even two successful trips through the CI can take hours at this moment of the day. | 13:18 |
| *** rloo has joined #openstack-ironic | 13:18 | |
| dtantsur | we can try it, I'll review after the current meeting. but no promises whatsoever at this point. | 13:18 |
| rpioso | dtantsur: ty | 13:19 |
| *** ociuhandu has joined #openstack-ironic | 13:20 | |
| *** rloo has quit IRC | 13:27 | |
| *** rloo has joined #openstack-ironic | 13:27 | |
| *** cp- has quit IRC | 13:31 | |
| *** tzumainn has joined #openstack-ironic | 13:39 | |
| *** abhishekyadav has quit IRC | 13:47 | |
| dtantsur | rpioso: (just asking, no action required) would it be handy to also provide reset_idrac/clear_job_queue as deploy steps? | 13:50 |
| TheJulia | good morning | 13:52 |
| rpioso | dtantsur: Good question. That might be handy. I need to confirm reset_idrac doesn't revert the creds to factory. The change we just rebased offers the steps via Redfish that have been available via WS-Man -- management protocol parity. For WS-Man, they have only been cleaning steps. It's likely deploy steps were not a thing when those merged. | 13:54 |
| * rpioso will be afk for a couple hours. | 13:55 | |
| *** rpioso is now known as rpioso|afk | 13:55 | |
| dtantsur | rpioso|afk: please do confirm that. we have an interest to run reset_idrac automatically in metal3 on enrollment, what you describe would prevent that. | 13:56 |
| dtantsur | morning TheJulia | 13:56 |
| TheJulia | I'm looking at 778058 trying to decide if we should -1 it on the fact that technically there is an api change there, but nothing mechanics wise that would be really blocking since it is on the internal side of things... and consumer would be unaware of the api really anywya. | 13:57 |
| dtantsur | TheJulia: is this re microversioning? I think we agreed to microversion the ramdisk API. | 13:58 |
| TheJulia | Yeah, the rpc stuffs are versioned, the ramdisk side is not | 13:59 |
| TheJulia | which seems super easy to remedy honestly | 13:59 |
| *** lmcgann has joined #openstack-ironic | 14:02 | |
| TheJulia | zer0c00l: you awake yet | 14:03 |
| TheJulia | so I think I grok why arun doesn't have a microversion | 14:05 |
| *** k_mouza has quit IRC | 14:05 | |
| * TheJulia needs to pull the other patch up to verify | 14:05 | |
| *** k_mouza has joined #openstack-ironic | 14:05 | |
| *** rcernin has joined #openstack-ironic | 14:12 | |
| *** rcernin has quit IRC | 14:17 | |
| TheJulia | zer0c00l: you've got a +2 from me, two asks in my comment and for any other reviewer my logic is noted as well. | 14:17 |
| *** ociuhandu has quit IRC | 14:19 | |
| *** ociuhandu has joined #openstack-ironic | 14:20 | |
| *** zbitter is now known as zaneb | 14:21 | |
| TheJulia | looks like a super quick ilo change https://review.opendev.org/c/openstack/ironic/+/783133 if anyone is interested | 14:22 |
| TheJulia | also uploaded the 25th :\ | 14:22 |
| * TheJulia -1's it | 14:23 | |
| *** jamesden_ has quit IRC | 14:24 | |
| *** jamesdenton has joined #openstack-ironic | 14:24 | |
| dtantsur | iurygregory, TheJulia, I'll trust you to update https://review.opendev.org/c/openstack/releases/+/783696 and https://review.opendev.org/c/openstack/releases/+/783675 by EOD today, taking into account any in-flight patches and so on | 14:27 |
| TheJulia | If any core reviewers want to take a look at https://review.opendev.org/c/openstack/ironic/+/778058 and consider it, I think it would be good to get in. It looks like the very last patch which needs reviews | 14:27 |
| * dtantsur has a headache and one more meeting ahead | 14:27 | |
| TheJulia | dtantsur: will do | 14:27 |
| TheJulia | ugh | 14:27 |
| dtantsur | TheJulia: the agent_status patch lacks microversioning... | 14:27 |
| dtantsur | not that I insist, but that's a commitment we've made | 14:28 |
| TheJulia | did you read my comments? | 14:28 |
| dtantsur | just read. they are reasonable to me, but they go against our microversioning commitment | 14:28 |
| TheJulia | I do agree with you, mentally its value vs really in the grand scheme kind of minor and I'm happy if they fix it later and we just leave this as is | 14:28 |
| *** ociuhandu has quit IRC | 14:29 | |
| dtantsur | *shrug* I don't have mental power for this discussion, and I won't cry if somebody just approves it | 14:29 |
| *** ociuhandu has joined #openstack-ironic | 14:29 | |
| TheJulia | I don't *really* think so because the rpc layer is still versioned in all of it. The api change seems not visible only usable | 14:29 |
| dtantsur | this is not how microversioning works | 14:29 |
| TheJulia | which.. sounds worse than it really is if they do patch it later | 14:30 |
| TheJulia | i know | 14:30 |
| dtantsur | I'll refer to https://specs.openstack.org/openstack/api-sig/guidelines/api_interoperability.html and consider my mission done :) | 14:30 |
| TheJulia | lol, okay | 14:30 |
| TheJulia | light at end of tunnel :) | 14:30 |
| *** rcernin has joined #openstack-ironic | 14:31 | |
| iurygregory | dtantsur, doing now | 14:32 |
| dtantsur | iurygregory: we're not ready with ironic just yet, please sync with Julia | 14:33 |
| dtantsur | IPA should be fine | 14:33 |
| iurygregory | yeah =) | 14:33 |
| iurygregory | working on the IPA now | 14:34 |
| TheJulia | agree on ipa | 14:35 |
| *** rcernin has quit IRC | 14:35 | |
| iurygregory | since we have a few features in ipa I'm pushing 6.7.0 | 14:46 |
| TheJulia | ++ | 14:55 |
| *** k_mouza has quit IRC | 15:00 | |
| *** k_mouza_ has joined #openstack-ironic | 15:00 | |
| iurygregory | ok, 7.0.0 after discussion in the release channel hehe | 15:02 |
| TheJulia | thanks | 15:05 |
| *** ociuhandu has quit IRC | 15:05 | |
| *** ociuhandu has joined #openstack-ironic | 15:06 | |
| *** k_mouza_ has quit IRC | 15:11 | |
| *** k_mouza has joined #openstack-ironic | 15:11 | |
| *** ociuhandu has quit IRC | 15:12 | |
| *** rcernin has joined #openstack-ironic | 15:26 | |
| *** rcernin has quit IRC | 15:31 | |
| *** ociuhandu has joined #openstack-ironic | 15:38 | |
| *** ociuhandu has quit IRC | 15:43 | |
| *** spotz has joined #openstack-ironic | 15:50 | |
| *** cp- has joined #openstack-ironic | 15:53 | |
| *** ociuhandu has joined #openstack-ironic | 15:59 | |
| *** rpioso|afk is now known as rpioso | 16:00 | |
| *** lucasagomes has quit IRC | 16:01 | |
| *** ociuhandu has quit IRC | 16:12 | |
| *** jamesdenton has quit IRC | 16:24 | |
| *** jamesdenton has joined #openstack-ironic | 16:25 | |
| openstackgerrit | Merged openstack/ironic master: Generic way to configure clean step priorites https://review.opendev.org/c/openstack/ironic/+/744117 | 16:30 |
| *** k_mouza_ has joined #openstack-ironic | 16:35 | |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic master: Follow-up Automaticaly set cipher suite https://review.opendev.org/c/openstack/ironic/+/783759 | 16:35 |
| iurygregory | ok it should be fine now the Follow-up | 16:36 |
| *** k_mouza has quit IRC | 16:39 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/ironic-python-agent stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/ironic-python-agent/+/784125 | 16:53 |
| openstackgerrit | OpenStack Release Bot proposed openstack/ironic-python-agent stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/ironic-python-agent/+/784126 | 16:53 |
| openstackgerrit | OpenStack Release Bot proposed openstack/ironic-python-agent master: Update master for stable/wallaby https://review.opendev.org/c/openstack/ironic-python-agent/+/784127 | 16:54 |
| openstackgerrit | OpenStack Release Bot proposed openstack/ironic-python-agent master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/ironic-python-agent/+/784128 | 16:54 |
| zer0c00l | TheJulia Ack | 16:54 |
| zer0c00l | TheJulia: are there any pointers you can show me towards implementing microversioning? | 16:54 |
| JayF | zer0c00l: I think there are already some examples in API code... let me find one | 16:56 |
| JayF | I had to look at all of this for the heartbeat-only agent stuff | 16:56 |
| zer0c00l | the rpcapi is versioned. the rest api isn't. | 16:57 |
| JayF | yes it is :) microversions | 16:57 |
| JayF | you not knowing about them is a testament to how good of a job we all did with making the tools negotiate them transparently | 16:57 |
| JayF | for instance: | 16:58 |
| JayF | https://opendev.org/openstack/ironic/src/branch/master/ironic/api/controllers/v1/utils.py#L1126 this method is called from https://opendev.org/openstack/ironic/src/branch/master/ironic/api/controllers/v1/ramdisk.py#L94 | 16:58 |
| JayF | and if you're not a new enough microversion, those endpoints don't even exist | 16:58 |
| JayF | for your change, I think you need to just not accept the new parameters if the microversion isn't new enough | 16:58 |
| JayF | and update the api-ref and microversions constants to bump the version and document the differences | 16:59 |
| JayF | I wonder if TheJulia and dtantsur would be OK with something like just adding the new microversino, documenting the behavior change, and not explicitly breaking if you pass new values with old microversions | 17:00 |
| JayF | but IDK | 17:00 |
| * JayF was on team it-doesnt-need-a-microversion but I don't have strong opinions on APIs generally | 17:00 | |
| *** derekh has quit IRC | 17:00 | |
| * dtantsur is on team it's-7pm-lets-open-some-wine | 17:01 | |
| dtantsur | I'm not sure how I ended up assuming a role of the microversions guardian in ironic, but I'm not ready to play it today :) | 17:02 |
| dtantsur | so whatever you folks decide, I'll live happily with it | 17:02 |
| JayF | I keep telling my boss it's 5 o'clock somewhere, but he keeps telling me I'm in america and to keep working /s | 17:02 |
| dtantsur | you US people have insane working conditions | 17:02 |
| * iurygregory is on team it's lunch time | 17:03 | |
| dtantsur | gah, I nearly wished everyone a good weekend... all you need to know about my state :) | 17:03 |
| dtantsur | have a good rest of the Odin's day and see you tomorrow | 17:04 |
| JayF | D | 17:04 |
| JayF | :D | 17:04 |
| *** k_mouza_ has quit IRC | 17:04 | |
| *** dtantsur is now known as dtantsur|afk | 17:04 | |
| TheJulia | JayF: zer0c00l: seriously, some guard would be good, and it is relatively simple to implement. And templates can be fixed with a backport if it comes down to it | 17:10 |
| TheJulia | I'd <3 to +2+A it and get it into the release | 17:10 |
| *** adrianc has quit IRC | 17:10 | |
| JayF | yeah I agree I don't think it'll be hard | 17:10 |
| *** adrianc has joined #openstack-ironic | 17:11 | |
| *** paras333 has joined #openstack-ironic | 17:11 | |
| TheJulia | uhh, brain... where did I put brain... oh there is the window I was typing in | 17:12 |
| *** paras333 has quit IRC | 17:15 | |
| *** rcernin has joined #openstack-ironic | 17:27 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-specs master: WIP: Xena priorities https://review.opendev.org/c/openstack/ironic-specs/+/784143 | 17:28 |
| TheJulia | Folks, I've just uploaded an initial start of priorities ^^^ for the cycle | 17:30 |
| TheJulia | I'd like to keep the list relatively short... at least as far as *big* items are concerned. | 17:30 |
| JayF | ^f 'warrior princess' 0/0 found. -2'd ;) | 17:31 |
| TheJulia | JayF: you need to make that case insensitive | 17:31 |
| JayF | I just actually started reading it, and I realize that now | 17:31 |
| JayF | :D | 17:31 |
| JayF | 10/10 good job | 17:32 |
| TheJulia | I got interrupted a few times while writing it by emails which are overlfowing today | 17:32 |
| TheJulia | but, yeah | 17:32 |
| TheJulia | anyway emails | 17:32 |
| JayF | I'll open that and review it at some point today | 17:32 |
| *** rcernin has quit IRC | 17:35 | |
| TheJulia | zer0c00l: not to pester, but fyi the gate was running 5+ hours so if a minimal check is going to be added, it needs to happen very soon | 17:47 |
| openstackgerrit | Merged openstack/ironic master: Add iDRAC management via Redfish to idrac HW type https://review.opendev.org/c/openstack/ironic/+/721593 | 17:52 |
| iurygregory | TheJulia, I can run the weekly-meeting =) | 17:53 |
| TheJulia | iurygregory: much appreciated | 17:53 |
| iurygregory | np | 17:53 |
| rpioso | TheJulia: Will the change ^^^ be included in Wallaby? | 17:55 |
| TheJulia | rpioso: we've not cut the release yet | 17:55 |
| TheJulia | so yes | 17:55 |
| rpioso | TheJulia: :-) | 17:55 |
| JayF | TheJulia: we anticipate working on that patch this afternoon | 18:05 |
| TheJulia | ok, we're in "works on first pass territory fwiw" | 18:06 |
| TheJulia | I'm happy to jump in on a call to collaborate as well | 18:06 |
| JayF | I think zer0c00l and I are going to pair on it | 18:06 |
| TheJulia | ok | 18:06 |
| JayF | might rope you in for a live-review or if we hit a barrier | 18:06 |
| TheJulia | ok | 18:06 |
| TheJulia | JayF: feel free to ping me | 18:29 |
| openstackgerrit | Merged openstack/ironic master: Fix Bandit check https://review.opendev.org/c/openstack/ironic/+/783749 | 18:42 |
| openstackgerrit | Merged openstack/ironic-python-agent stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/ironic-python-agent/+/784125 | 18:55 |
| *** jamesdenton has quit IRC | 18:56 | |
| *** jamesden_ has joined #openstack-ironic | 18:56 | |
| openstackgerrit | Merged openstack/ironic-python-agent stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/ironic-python-agent/+/784126 | 19:00 |
| openstackgerrit | Bob Fournier proposed openstack/ironic master: Restrict syncing of boot mode to Supermicro https://review.opendev.org/c/openstack/ironic/+/784156 | 19:03 |
| *** k_mouza has joined #openstack-ironic | 19:05 | |
| TheJulia | bfournie: do we need to backport that? | 19:08 |
| TheJulia | yup, we do need to | 19:10 |
| TheJulia | *sigh* | 19:10 |
| TheJulia | bfournie: I'm good with it, I single core approved it given context and timeline | 19:10 |
| *** k_mouza has quit IRC | 19:10 | |
| TheJulia | worst come to worst it will be the first backport | 19:11 |
| bfournie | TheJulia: we probably should backport it, yeah double *sigh* | 19:28 |
| bfournie | TheJulia: thanks | 19:28 |
| bfournie | TheJulia: I think the ramifications are limited though as it only caused a problem when changing the mode on dell, not during normal deployment | 19:29 |
| *** rcernin has joined #openstack-ironic | 19:31 | |
| *** rcernin has quit IRC | 19:36 | |
| TheJulia | yeah, I'm getting a little worried about the redfish fragmentation we're seeing | 19:52 |
| TheJulia | maybe fragmentation is the wrong word | 19:52 |
| TheJulia | the variation of opinionated under-hood mechanics | 19:52 |
| TheJulia | Totally get engines may be different, principal of breaks may be different, but hydraulic breaks work differently from air breaks.... kind of differences. | 19:53 |
| JayF | What you're saying is you want the oil drain plug located in a place that doesn't spill used oil over all the other redfish vendor hardware implementations? (ok, the metaphor broke) | 19:54 |
| TheJulia | JayF: a valve and quick connector would be appreciated | 19:55 |
| JayF | Sorry, for that you'll have to buy our EXL model which costs $25,000 more, but it has heated seats too, so it's really a deal. | 19:55 |
| TheJulia | I actually looked up the cost for those drain plug parts for my mobile command center... surprisingly expensive. | 19:56 |
| TheJulia | heated seats though... those sound nice.... | 19:58 |
| *** hjensas has quit IRC | 20:10 | |
| *** rcernin has joined #openstack-ironic | 20:30 | |
| *** jamesden_ has quit IRC | 20:38 | |
| *** jamesdenton has joined #openstack-ironic | 20:39 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic master: Add agent_status and agent_status_message params to heartbeat https://review.opendev.org/c/openstack/ironic/+/778058 | 20:49 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic master: Add agent_status and agent_status_message params to heartbeat https://review.opendev.org/c/openstack/ironic/+/778058 | 20:52 |
| TheJulia | iurygregory: fyi, 1 more rev | 20:56 |
| TheJulia | inbound | 20:57 |
| iurygregory | let me know and I will review =) | 20:57 |
| TheJulia | about 5 minutes, I'm watching jayf make the edits | 20:58 |
| JayF | O_O | 20:59 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic master: Add agent_status and agent_status_message params to heartbeat https://review.opendev.org/c/openstack/ironic/+/778058 | 21:00 |
| TheJulia | iurygregory: ^^ | 21:01 |
| iurygregory | ack | 21:01 |
| TheJulia | running pep8/unit testing now | 21:01 |
| iurygregory | wow | 21:01 |
| TheJulia | well, locally | 21:01 |
| TheJulia | JayF can't run tox locally | 21:01 |
| JayF | blame it on the mac | 21:02 |
| *** rcernin has quit IRC | 21:05 | |
| *** rcernin has joined #openstack-ironic | 21:05 | |
| iurygregory | LOL | 21:09 |
| iurygregory | :O | 21:09 |
| *** dhellmann_ has joined #openstack-ironic | 21:12 | |
| *** dhellmann has quit IRC | 21:12 | |
| *** dhellmann_ is now known as dhellmann | 21:14 | |
| TheJulia | iurygregory: one more inbound | 21:15 |
| iurygregory | ack | 21:15 |
| TheJulia | rloo pointed something out that was really valid | 21:15 |
| *** dhellmann has quit IRC | 21:16 | |
| rloo | TheJulia: really ? | 21:16 |
| *** dhellmann has joined #openstack-ironic | 21:17 | |
| TheJulia | rloo: always! | 21:20 |
| TheJulia | upload inbound shortly | 21:20 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic master: Add agent_status and agent_status_message params to heartbeat https://review.opendev.org/c/openstack/ironic/+/778058 | 21:21 |
| iurygregory | this is starting to look like a game XD "new enemy wave - inbound shortly" | 21:21 |
| iurygregory | hahaha | 21:21 |
| *** dhellmann has quit IRC | 21:23 | |
| *** dhellmann has joined #openstack-ironic | 21:25 | |
| TheJulia | yeah, it is looking very good | 21:27 |
| * rloo looks... | 21:27 | |
| iurygregory | may is just me but I couldn't find where we are using allow_status_in_heartbeat O.o | 21:28 |
| TheJulia | https://review.opendev.org/c/openstack/ironic/+/778058/18/ironic/api/controllers/v1/ramdisk.py#197 | 21:29 |
| *** rcernin has quit IRC | 21:30 | |
| iurygregory | oh ok | 21:30 |
| iurygregory | I missed that =) | 21:30 |
| iurygregory | it wouldn't hurt a unit test in ironic/tests/unit/api/controllers/v1/test_utils.py but I don't think it's mandatory since we have an idea on how it works etc | 21:33 |
| *** dansmith has quit IRC | 21:33 | |
| iurygregory | +2 from me | 21:34 |
| iurygregory | great job zer0c00l JayF =) | 21:34 |
| iurygregory | after CI runs I can +W | 21:34 |
| *** lmcgann has quit IRC | 21:34 | |
| iurygregory | if no other core does | 21:34 |
| iurygregory | TheJulia, so when 778058 we should be ready for ironic release, right? | 21:35 |
| iurygregory | or do we have any other patches we would like? | 21:35 |
| TheJulia | iurygregory: yup | 21:38 |
| *** dansmith has joined #openstack-ironic | 21:38 | |
| TheJulia | iurygregory: bob's change is failing due to ci unhappiness, but it can be backported once good | 21:38 |
| iurygregory | ack | 21:39 |
| *** rcernin has joined #openstack-ironic | 21:55 | |
| *** rcernin has quit IRC | 22:00 | |
| zer0c00l | :) | 22:02 |
| *** rcernin has joined #openstack-ironic | 22:13 | |
| *** rcernin has quit IRC | 22:18 | |
| openstackgerrit | Verification of a change to openstack/ironic failed: Follow-up Automaticaly set cipher suite https://review.opendev.org/c/openstack/ironic/+/783759 | 22:22 |
| *** rloo has quit IRC | 22:24 | |
| *** rcernin has joined #openstack-ironic | 22:32 | |
| *** rcernin has quit IRC | 22:32 | |
| *** rcernin has joined #openstack-ironic | 22:33 | |
| TheJulia | iurygregory: 2nd retry, zookeeper had a reconnection event appox 1hr ago per opendev channel | 22:37 |
| TheJulia | They are trying to figure it out, but yay more waiting :( | 22:37 |
| iurygregory | enr D: | 22:37 |
| iurygregory | I should read the #opendev channel more often :D | 22:38 |
| TheJulia | More like :-(::::: | 22:38 |
| iurygregory | yeah | 22:39 |
| openstackgerrit | Verification of a change to openstack/ironic failed: Follow-up Automaticaly set cipher suite https://review.opendev.org/c/openstack/ironic/+/783759 | 22:48 |
| iurygregory | LOL | 22:48 |
| *** rh-jlabarre has quit IRC | 22:48 | |
| *** jamesdenton has quit IRC | 22:57 | |
| *** jamesden_ has joined #openstack-ironic | 22:58 | |
| *** k_mouza has joined #openstack-ironic | 23:07 | |
| *** k_mouza has quit IRC | 23:12 | |
| *** tosky has quit IRC | 23:30 | |
| stevebaker | cursed | 23:30 |
| TheJulia | cursed is an understatement... I think. | 23:31 |
| TheJulia | and more cursed, 3rd retry | 23:34 |
| TheJulia | I'm getting a feeling we're going to need to recheck, the gate seems toasty | 23:53 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!