| opendevreview | Verification of a change to openstack/ironic-inspector failed: Fix & suppress oslo policy warnings https://review.opendev.org/c/openstack/ironic-inspector/+/799420 | 00:41 |
|---|---|---|
| *** pmannidi is now known as pmannidi|brb | 01:35 | |
| opendevreview | Steve Baker proposed openstack/ironic master: Defer checking image size until instance info is built https://review.opendev.org/c/openstack/ironic/+/799431 | 02:58 |
| opendevreview | Steve Baker proposed openstack/metalsmith master: Set image_disk_format from file extension for HTTP images https://review.opendev.org/c/openstack/metalsmith/+/798028 | 02:59 |
| arne_wiebalck | Good morning, Ironic! | 05:56 |
| arne_wiebalck | Thanks dtantsur, I will have a look. Your initial Victoria backport is what I am using atm. | 05:58 |
| dtantsur | morning ironic | 06:17 |
| arne_wiebalck | dtantsur: Good morning! Lab day? :-) | 06:32 |
| opendevreview | vinay50muddu proposed openstack/ironic master: [WIP] Clean step to remove CA certificates from iLO https://review.opendev.org/c/openstack/ironic/+/799562 | 06:44 |
| dtantsur | arne_wiebalck: exactly :) | 06:48 |
| *** rpittau|afk is now known as rpittau | 07:30 | |
| rpittau | good morning ironic! o/ | 07:31 |
| opendevreview | wushiming proposed openstack/metalsmith master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/metalsmith/+/799573 | 08:03 |
| cenne | Mornings rpittau dtantsur arne_wiebalck and Ironic! | 08:04 |
| dtantsur | hi cenne! how is it going? | 08:04 |
| arne_wiebalck | hey cenne o/ | 08:04 |
| rpittau | hey cenne :) | 08:04 |
| dtantsur | we have a crazy summer: it's either very hot or extremely rainy | 08:05 |
| cenne | o/ | 08:05 |
| cenne | Often humid here too, cloudy. | 08:05 |
| rpittau | heh same, with extreme cold wind :/ | 08:05 |
| opendevreview | Merged openstack/ironic master: API to pass fields to node object list https://review.opendev.org/c/openstack/ironic/+/792296 | 08:18 |
| janders | good morning arne_wiebalck dtantsur rpittau cenne and Ironic o/ | 08:41 |
| rpittau | hey janders :) | 08:41 |
| arne_wiebalck | hey janders o/ | 08:59 |
| dtantsur | folks, a couple of minor patches if you have time: https://review.opendev.org/c/openstack/bifrost/+/796002 https://review.opendev.org/c/openstack/bifrost/+/796914 https://review.opendev.org/c/openstack/sushy/+/797435 https://review.opendev.org/c/openstack/ironic/+/797512 | 09:05 |
| opendevreview | Merged openstack/ironic master: Fix oslo policy DeprecatedRule warnings https://review.opendev.org/c/openstack/ironic/+/799419 | 09:19 |
| opendevreview | Merged openstack/ironic stable/wallaby: Cache AgentClient on Task, not globally https://review.opendev.org/c/openstack/ironic/+/799532 | 09:22 |
| opendevreview | Aija Jauntēva proposed openstack/sushy master: Add Drive.volumes https://review.opendev.org/c/openstack/sushy/+/799612 | 09:24 |
| opendevreview | Merged openstack/ironic-inspector master: Fix & suppress oslo policy warnings https://review.opendev.org/c/openstack/ironic-inspector/+/799420 | 10:19 |
| opendevreview | Merged openstack/sushy master: Protect Connector against empty auth object https://review.opendev.org/c/openstack/sushy/+/797435 | 10:53 |
| opendevreview | Merged openstack/bifrost master: Clean up kernel params https://review.opendev.org/c/openstack/bifrost/+/796002 | 11:02 |
| opendevreview | Merged openstack/bifrost master: Skip running jobs on ironic and inspector unit tests https://review.opendev.org/c/openstack/bifrost/+/796914 | 11:02 |
| opendevreview | Dmitry Tantsur proposed openstack/sushy stable/wallaby: Protect Connector against empty auth object https://review.opendev.org/c/openstack/sushy/+/799583 | 11:04 |
| opendevreview | Merged openstack/ironic master: Nicer error message when a deploy step fails https://review.opendev.org/c/openstack/ironic/+/797512 | 11:06 |
| opendevreview | Dmitry Tantsur proposed openstack/sushy stable/victoria: Protect Connector against empty auth object https://review.opendev.org/c/openstack/sushy/+/799584 | 11:16 |
| ajya | janders: posted a comment | 12:01 |
| janders | ajya thank you! | 12:02 |
| * dtantsur -> lunch | 12:09 | |
| janders | dtantsur enjoy! | 12:11 |
| janders | see you tomorrow Ironic o/ | 12:11 |
| opendevreview | Merged openstack/sushy master: Fix Processor.sub_processors https://review.opendev.org/c/openstack/sushy/+/799503 | 12:13 |
| opendevreview | Merged openstack/ironic-inspector master: Add rbac scope enforcement handling to devstack plugin https://review.opendev.org/c/openstack/ironic-inspector/+/798359 | 12:42 |
| opendevreview | Aija Jauntēva proposed openstack/sushy master: Add resource root property https://review.opendev.org/c/openstack/sushy/+/799504 | 12:50 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-lib master: Use the json format output of qemu-img info https://review.opendev.org/c/openstack/ironic-lib/+/799664 | 12:58 |
| opendevreview | Merged openstack/ironic master: Defer checking image size until instance info is built https://review.opendev.org/c/openstack/ironic/+/799431 | 13:07 |
| TheJulia | Good morning | 13:12 |
| dtantsur | morning TheJulia | 13:12 |
| opendevreview | Merged openstack/metalsmith master: Set image_disk_format from file extension for HTTP images https://review.opendev.org/c/openstack/metalsmith/+/798028 | 13:15 |
| rpittau | good morning TheJulia :) | 13:17 |
| * TheJulia feels like she didn't sleep | 13:34 | |
| *** osmanlicilegi is now known as Guest4 | 13:34 | |
| TheJulia | do we have any patches to review jam on today? | 13:54 |
| JayF | If someone has some time this morning, getting https://review.opendev.org/c/openstack/ironic/+/780398 landed this morning would be extremely helpful to my downstream work | 14:08 |
| JayF | (Anaconda configdrive) | 14:08 |
| TheJulia | I can look once I wake up in a little bit | 14:09 |
| TheJulia | waking up this morning seems to be the slowest process | 14:10 |
| TheJulia | dtantsur: I guess is_public_api can be removed if it can be cleanly excised and identified as a no-op like the is_admin one was. | 14:15 |
| opendevreview | Ghanshyam proposed openstack/ironic-inspector stable/wallaby: Fix & suppress oslo policy warnings https://review.opendev.org/c/openstack/ironic-inspector/+/799590 | 14:20 |
| rpittau | gmann: not sure we can backport that, at least not with the requirements change | 14:24 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Remove train testing from ironic-tempest-plugin https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/799678 | 14:26 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: remove ebtables fix env var from wallaby stable job https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/799679 | 14:26 |
| gmann | rpittau: humm, but it is not bumping upper-constraints. we do support 3.7.0 as u-c. I can keep requirement.txt unchanged but that will be conflicting if someone try to run it with oslo.policy 3.6.11 | 14:26 |
| gmann | 3.6.1 | 14:26 |
| JayF | We 100% cannot backport that with the requirement change | 14:26 |
| rpittau | well 3.7.0 is wallaby though | 14:27 |
| JayF | No; stable/wallaby requirements.txt in ironic repo is =>3.6.2 | 14:27 |
| gmann | JayF: rpittau yeah, if we have to update in u-c then i can see your concern | 14:27 |
| JayF | because I was going to backport that change if it was compatible :( | 14:27 |
| gmann | yeah with new release with this backport anyone upgrading to new wallaby need new oslo policy also | 14:28 |
| gmann | but i see your concern on that which make sense I think 'why to upgrade oslo.policy also' | 14:29 |
| TheJulia | I'm not sure that is it | 14:29 |
| TheJulia | my perception is adherence to stable policy | 14:29 |
| gmann | yeah. thinking on JayF original point on how to fix warning in wallaby wihtout req update. | 14:31 |
| gmann | I think we cannot and may be just live with that in wallaby. | 14:31 |
| TheJulia | The alternative is to just run the service in scoped mode | 14:32 |
| TheJulia | which would be ideal, it *is* an admin service | 14:32 |
| gmann | TheJulia: you mean remove the deprecated rule? | 14:33 |
| TheJulia | no, set it to scope enforce | 14:34 |
| gmann | that does not solve these warning as they are from DeprecatedRule definition | 14:34 |
| TheJulia | Are they spamming constantly, or only on startup? | 14:34 |
| gmann | constantly as test init the policy everytime | 14:35 |
| TheJulia | *tests*, but operationally | 14:35 |
| gmann | operationally, on every API i think but need to check how ironic init the policy | 14:35 |
| TheJulia | ironic-inspector you mean ? | 14:36 |
| TheJulia | if ironic-inspector is every single time, then that is a bug that should be able to be fixed | 14:36 |
| TheJulia | Ironic, from what I've seen in the logs does not every single time when running | 14:36 |
| gmann | yeah, its not on every API. | 14:50 |
| gmann | I will abandon the backport. | 14:51 |
| dtantsur | gmann, JayF, sometimes we work around such problems by backporting changes so that they work with old versions | 14:56 |
| dtantsur | using try.. except AttributeError.. and such | 14:56 |
| dtantsur | we have done it many times with vendor libraries | 14:57 |
| dtantsur | if 3.7.0 is in wallaby, chances are high that a lot of consumers use it (but not everyone) | 14:57 |
| JayF | I'd be OK with that pattern; but given this just supresses a startup warning, it seems like maybe not the best place to apply that pattern | 15:04 |
| JayF | my interest level in this backport cratered when I realized it's just suppressing logs in tests and on startup | 15:04 |
| TheJulia | +1 to attributeerror | 15:18 |
| gmann | yeah, good idea but may be we can wait until anyone report 'too many warning i my logs' which should not be there as it is one time policy initialization | 15:22 |
| TheJulia | well, by this even being discussed, people are starting to observe/complain | 15:23 |
| dtantsur | btw I was also thinking about silencing oslo.policy messages in API logs | 15:32 |
| dtantsur | there are plenty of them even in the standalone case | 15:32 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-lib master: Use the json format output of qemu-img info https://review.opendev.org/c/openstack/ironic-lib/+/799664 | 15:41 |
| TheJulia | could we not change the default level at which the oslo.policy logging occurs | 15:41 |
| TheJulia | although, granted, not logging it means it will be difficult for people to know if access was valid or what the input was | 15:42 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Support "swift" for ramdisk_image_download_source https://review.opendev.org/c/openstack/ironic/+/799685 | 15:43 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Add Wallaby jobs https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/798143 | 15:44 |
| * TheJulia thinks gerrit needs coffee | 15:44 | |
| dtantsur | very true | 15:45 |
| TheJulia | I like the path of changing the default, unfortuantely the library default for logging is really verbose | 15:46 |
| dtantsur | we already silence debug logging from many libraries | 15:47 |
| TheJulia | Can I get some eyes on https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/797521 It updates us from using the old api client style in tempest to the newer standard as of ?4? years ago, and allows us to navigate someone trying to indicate if scope is being enforced. | 15:48 |
| TheJulia | Which requires the scoped client | 15:48 |
| TheJulia | https://review.opendev.org/c/openstack/ironic/+/778957 validates the change works as expected in the enforced mode as well | 15:49 |
| gmann | +1, with this we will disable it by default at least during migration to new RBAC - https://review.opendev.org/c/openstack/oslo.policy/+/799539 | 16:00 |
| opendevreview | Arne Wiebalck proposed openstack/ironic-python-agent master: Burn-in: Add network step https://review.opendev.org/c/openstack/ironic-python-agent/+/799687 | 16:06 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add note regarding configuration drives to tuning docs https://review.opendev.org/c/openstack/ironic/+/789623 | 16:12 |
| opendevreview | Arne Wiebalck proposed openstack/ironic-python-agent master: Burn-in: Add network step https://review.opendev.org/c/openstack/ironic-python-agent/+/799687 | 16:18 |
| rpittau | bye everyone! o/ | 16:39 |
| *** rpittau is now known as rpittau|afk | 16:39 | |
| arne_wiebalck | bye everyone o/ | 16:42 |
| JayF | review jammin' today? | 16:56 |
| dtantsur | not me | 17:10 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Avoid double file removal in create_boot_iso https://review.opendev.org/c/openstack/ironic/+/799695 | 17:11 |
| opendevreview | Merged openstack/ironic master: Add support for configdrive in anaconda interface https://review.opendev.org/c/openstack/ironic/+/780398 | 17:21 |
| opendevreview | Verification of a change to openstack/ironic failed: Add `boot_mode` and `secure_boot` to node object and expose in api https://review.opendev.org/c/openstack/ironic/+/797055 | 17:21 |
| *** mgoddard- is now known as mgoddard | 17:26 | |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] Bring boot_iso/deploy_iso handling in iLO closer to Redfish https://review.opendev.org/c/openstack/ironic/+/799696 | 17:34 |
| TheJulia | I was on calls and didn't see any on the agenda this morning :( | 17:38 |
| TheJulia | o/ mjturek | 17:42 |
| mjturek | o/ | 17:42 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] Bring boot_iso/deploy_iso handling in iLO closer to Redfish https://review.opendev.org/c/openstack/ironic/+/799696 | 17:45 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Document operators troubleshooting steps https://review.opendev.org/c/openstack/ironic/+/336055 | 17:45 |
| dtantsur | o/ | 17:47 |
| TheJulia | JayF: w/r/t https://review.opendev.org/c/openstack/ironic/+/797337/3/ironic/db/sqlalchemy/api.py weird.... I distinctly remember typing a whole thing out :\ | 18:10 |
| JayF | pixie ate your homewor^W comments? | 18:11 |
| TheJulia | I think so... | 18:11 |
| * TheJulia types out an even more verbose book | 18:26 | |
| TheJulia | hmm, someone changed our whiteboard to say we were on libera | 18:56 |
| JayF | DI did | 18:57 |
| JayF | oh | 18:57 |
| JayF | that's wrong | 18:57 |
| JayF | it said freenode before that :| | 18:57 |
| TheJulia | we're on oftc | 18:57 |
| JayF | Yeah; I know that, apparently I didn't when making that edit | 18:57 |
| TheJulia | c'est la vie | 18:57 |
| JayF | it saying libera was still 100x better than it saying freenode | 18:58 |
| JayF | lol | 18:58 |
| TheJulia | ++ | 18:58 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Allow node_sanitize function to be provided overrides https://review.opendev.org/c/openstack/ironic/+/794880 | 20:06 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Use selectinload for all list queries https://review.opendev.org/c/openstack/ironic/+/797337 | 20:06 |
| TheJulia | JayF: lmk if ^^^ has enough information or not | 20:24 |
| JayF | looking now | 20:31 |
| JayF | pretty much exactly what I was looking for, +2 to both | 20:33 |
| TheJulia | ack | 20:34 |
| TheJulia | arne_wiebalck: fyi ^^^ hopefully the tradeoff/impact is explained. And hopefully makes sense. | 20:35 |
| JayF | TheJulia: after the selectinload patch; that's it for this batch, right? And they can be backported to wallaby? Or is there some further-down-the-road stopping point? | 20:38 |
| TheJulia | JayF: that is it in ironic | 20:39 |
| JayF | \o/ | 20:39 |
| JayF | you have ideas for nova though, I presume? | 20:39 |
| JayF | some you've already expressed e.g. using cache for counts | 20:40 |
| TheJulia | Two. One I've been trying to convince nobodycam to upstream :) | 20:40 |
| TheJulia | the other is the cache | 20:40 |
| TheJulia | which reminds me... | 20:40 |
| * TheJulia goes and find's arne's message from yesterday | 20:40 | |
| JayF | nice. Please add me as a reviewer to those; I don't expect us to be able to backport those in nova but I may wanna pull them in downstream | 20:40 |
| TheJulia | oh, I did have a thought w/r/t ironic that the benchmark fake data creation should create some trait stuffs | 20:41 |
| TheJulia | JayF: k | 20:43 |
| TheJulia | JayF: also, wrt ironic, I *do* want to do the chassis lookup as a join | 20:46 |
| TheJulia | JayF: but right now, that doesn't seem like something possibleas a backport because it would actually change the expected object model by adding a field | 20:46 |
| JayF | What field? | 20:47 |
| TheJulia | chassis_id -> chassis_uuid | 20:47 |
| TheJulia | right now it is a lookup in our api code | 20:47 |
| JayF | And you're sure you can't change it back on the way out in API layer? | 20:47 |
| TheJulia | you folks have it commented out afaik | 20:47 |
| TheJulia | JayF: that requires another lookup or query in the api code | 20:47 |
| JayF | yeah, we basically have it patched out | 20:48 |
| TheJulia | it isen't in the default field list, I don't think, so it would only be on the detail list or view | 20:50 |
| JayF | I can't speak intellegently to what it looks like on master vs ocata | 20:50 |
| JayF | because I've not seen either version of that code enough lol | 20:50 |
| TheJulia | lol | 20:50 |
| TheJulia | yeah, I think I looked it up during the last discussion | 20:50 |
| JayF | reviewing your and cenne's patches has been the most API code I've read in my entire openstack tenure | 20:51 |
| TheJulia | but I can also see people or processes giving me "give me everything" not realizing that they are making it very slow from a standpoint of the sheer amount of data they are asking for | 20:51 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: remove ebtables fix env var from wallaby stable job https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/799679 | 21:11 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Handle pycadf missing https://review.opendev.org/c/openstack/ironic/+/799721 | 21:35 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP Handle pycdlib missing https://review.opendev.org/c/openstack/ironic/+/799721 | 21:40 |
| * TheJulia goes on a trek to the market | 21:46 | |
| janders | good morning Ironic o/ | 23:07 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!