| opendevreview | Jacob Anders proposed openstack/sushy master: Removing optional fields from insert_media payload https://review.opendev.org/c/openstack/sushy/+/802690 | 00:05 |
|---|---|---|
| janders | TheJulia ^ this should fix up all the bits you pointed out | 00:06 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Change defaults - optional insert_media attributes https://review.opendev.org/c/openstack/sushy/+/802452 | 01:09 |
| janders | how to DELETE a storyboard story? Creation crashed in-flight, so I re-created my story and now I have two. One needs to go. | 01:38 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Remove hardcoded parameters from insert_media call https://review.opendev.org/c/openstack/ironic/+/802643 | 01:40 |
| iurygregory | good morning Ironic o/ | 06:21 |
| opendevreview | Ian Wienand proposed openstack/ironic master: ci-workarounds/get_extra_logging.yaml : avoid grep failure https://review.opendev.org/c/openstack/ironic/+/802829 | 06:39 |
| cenne | good morning iurygregory, ironic. | 07:09 |
| *** rpittau|afk is now known as rpittau | 07:10 | |
| rpittau | good morning ironic! o/ | 07:10 |
| iurygregory | morning cenne rpittau o/ | 07:10 |
| rpittau | hey iurygregory :) | 07:13 |
| cenne | o/ hey all | 07:37 |
| iurygregory | I'm closing the Doodle for the Midcycle, based on the results the best dates are 23 24 25. I will check the time slots and will send an email to the openstack-discuss today | 07:49 |
| iurygregory | not sure if we will need 3 dates ofc, is just because the last midcycle lasted 3 days =) | 07:51 |
| rpittau | let's see how many topics we have | 07:57 |
| iurygregory | yeah | 07:59 |
| janders | good morning cenne rpittau iurygregory and Ironic o/ | 08:07 |
| iurygregory | hey janders o/ | 08:08 |
| cenne | hey janders o/ | 08:11 |
| rpittau | hey janders :) | 08:19 |
| dtantsur | morning ironic | 08:36 |
| * dtantsur -> dentist, brb | 09:13 | |
| opendevreview | Riccardo Pittau proposed openstack/ironic-inspector master: Increase version of hacking and pycodestyle https://review.opendev.org/c/openstack/ironic-inspector/+/802851 | 09:19 |
| jssfr | ugh, I only now noticed that my reply to a remark on my review was stuck in draft :( | 10:39 |
| opendevreview | Merged openstack/ironic master: Increase version of hacking and pycodestyle https://review.opendev.org/c/openstack/ironic/+/802675 | 10:40 |
| opendevreview | Merged openstack/sushy master: Increase version of hacking and pycodestyle https://review.opendev.org/c/openstack/sushy/+/802491 | 11:24 |
| rpittau | And my laptop crashed and it doesn't load from the disk..... | 12:03 |
| dtantsur | Oo | 12:08 |
| iurygregory | woot?! | 12:17 |
| rpittau | yeah, I'm trying to understand what's going on, live usb at the rescue | 12:22 |
| dtantsur | iurygregory: if you have a second: https://review.opendev.org/c/openstack/ironic/+/802664 | 12:24 |
| iurygregory | dtantsur, sure! I'm in a downstream meeting after it finishes I will look | 12:25 |
| dtantsur | cool! | 12:25 |
| iurygregory | dtantsur, we probably need a backport to 18.0 =) | 12:29 |
| dtantsur | iurygregory: good point, lemme check | 12:29 |
| iurygregory | tks! | 12:30 |
| rpittau | and I'm back, weird | 12:38 |
| cenne | Phew. LiveUSB saved you rpittau? | 12:50 |
| janders | dtantsur iurygregory rpittau would you have time to chat about the sushy patches (Inserted/WriteProtected removal)? | 12:53 |
| janders | if TheJulia and rpioso are around that woule be even more awesome | 12:53 |
| dtantsur | I'm on meetings, but will eavesdrop | 12:53 |
| rpittau | cenne: yeah, had to rebuild grub config for some reason | 12:53 |
| janders | thank you dtantsur - if it's easier we can sort this out in async - let's see who's available | 12:54 |
| rpittau | janders: I'm listening to europython but I'm available | 12:57 |
| cenne | rpittau for me it happens when it's powered off unexpectedly. The ssd doesn't get ready by the time bios does it's thing. A simple live boot and then reboot fixes it | 12:57 |
| cenne | * for me. | 12:58 |
| rpittau | mmm well first time for me since a while, not sure what happened | 12:58 |
| janders | thanks rpittau | 12:58 |
| janders | okay, I will drop my thoughts here for starters, let's see how we go | 12:59 |
| janders | in essence I think I addressed all reviewer comments on all three patches | 12:59 |
| janders | what I wanted to talk about in particular is the comment from rpioso https://review.opendev.org/c/openstack/sushy/+/802452/8/sushy/resources/manager/virtual_media.py#96 | 13:00 |
| janders | I like his approach more than what I did for the "backport candidate" sushy patch (it's more readable) but I'd still want to get to a point where we don't pass Inserted and WriteProtected from Ironic to sushy just to silently drop these (and not add them to payload) | 13:01 |
| janders | and while we're there I'd want to make default values of inserted and write_protected in sushy to be None as dtantsur suggested the other day | 13:02 |
| janders | ^ dtantsur rpittau iurygregory TheJulia rpioso what do you think? | 13:02 |
| janders | do we stay with the current state with three patches (backportable-sushy and master-only ironic and sushy-follow up)? | 13:03 |
| opendevreview | Merged openstack/bifrost bugfix/11.0: Install libvirt-python from source instead of a wheel https://review.opendev.org/c/openstack/bifrost/+/802749 | 13:09 |
| TheJulia | good morning | 13:10 |
| janders | hey TheJulia | 13:11 |
| iurygregory | janders, to me the actual approach makes totally sense (after the conversation we had with dtantsur yesterday) | 13:11 |
| iurygregory | good morning TheJulia | 13:11 |
| janders | thanks iurygregory | 13:12 |
| janders | I'm thinking the same, but wanted to see if we have consensus on that - quite a few different ideas in the review comments | 13:12 |
| janders | hence dropping this on IRC | 13:12 |
| iurygregory | yeah, it makes sense to bring up the conversation in IRC =) | 13:13 |
| dtantsur | janders: let's make sure we fix the problem in question first and foremast, and in a backportable way | 13:15 |
| dtantsur | all clean ups can be subject to other discussions | 13:15 |
| rpittau | janders: I'm on the same page as dtantsur, let's fix the issue and backport it first | 13:17 |
| janders | OK! thank you iurygregory dtantsur rpittau | 13:22 |
| TheJulia | every time we've tried to refactor and then fix, it just makes it more painful | 13:22 |
| janders | I will upload an updated version of https://review.opendev.org/c/openstack/sushy/+/802690 | 13:22 |
| janders | and let's focus on that | 13:22 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Removing optional fields from insert_media payload https://review.opendev.org/c/openstack/sushy/+/802690 | 13:30 |
| janders | ^ okay the backport candidate is ready to go - if you have time have a look and leave comments if anything more needs fixing - I will try to test it against some hardware tomorrow morning | 13:31 |
| janders | thanks iurygregory dtantsur rpittau TheJulia | 13:31 |
| iurygregory | tks janders ! | 13:31 |
| opendevreview | Verification of a change to openstack/ironic stable/wallaby failed: Fix regression in ramdisk deploy kernel parameters https://review.opendev.org/c/openstack/ironic/+/802664 | 13:59 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-lib master: Increase version of hacking and pycodestyle https://review.opendev.org/c/openstack/ironic-lib/+/802896 | 14:20 |
| opendevreview | Verification of a change to openstack/ironic stable/wallaby failed: Fix regression in ramdisk deploy kernel parameters https://review.opendev.org/c/openstack/ironic/+/802664 | 14:29 |
| rpioso | Good morning, ironic :) | 14:54 |
| rpioso | janders: Thank you for replying to my review comments. | 14:54 |
| opendevreview | Merged openstack/bifrost bugfix/11.0: bifrost-cli: fix relative paths in --extra-vars https://review.opendev.org/c/openstack/bifrost/+/801581 | 15:06 |
| opendevreview | Merged openstack/bifrost bugfix/11.0: Install sushy-oem-idrac for idrac-redfish-virtual-media https://review.opendev.org/c/openstack/bifrost/+/801580 | 15:06 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Increase version of hacking and pycodestyle https://review.opendev.org/c/openstack/ironic-python-agent/+/802903 | 15:08 |
| opendevreview | Verification of a change to openstack/ironic stable/wallaby failed: Fix regression in ramdisk deploy kernel parameters https://review.opendev.org/c/openstack/ironic/+/802664 | 15:08 |
| dtantsur | folks, I tiny patch needs 2nd +2: https://review.opendev.org/c/openstack/bifrost/+/802439 | 15:42 |
| JayF | if it's simple enough, I can approve | 15:51 |
| JayF | TIL we changed the name of that setting | 15:51 |
| JayF | there ya go dtantsur | 15:52 |
| dtantsur | yep, we made it consistent with other drivers and removed the duplicated prefix. thanks! | 15:52 |
| JayF | yeah I found the commit before I approved the change | 15:53 |
| JayF | don't want to wake up one day as a giant rubber stamp :P | 15:53 |
| opendevreview | Merged openstack/ironic master: ci-workarounds/get_extra_logging.yaml : avoid grep failure https://review.opendev.org/c/openstack/ironic/+/802829 | 15:55 |
| opendevreview | Merged openstack/ironic-inspector master: Increase version of hacking and pycodestyle https://review.opendev.org/c/openstack/ironic-inspector/+/802851 | 15:55 |
| rpittau | good night! o/ | 16:03 |
| *** rpittau is now known as rpittau|afk | 16:03 | |
| TheJulia | JayF: That is a weird visual | 16:16 |
| dtantsur | o/ | 17:05 |
| opendevreview | Merged openstack/bifrost master: Update deprecated pxe_append_params -> kernel_append_params https://review.opendev.org/c/openstack/bifrost/+/802439 | 17:07 |
| opendevreview | Verification of a change to openstack/ironic stable/wallaby failed: Fix regression in ramdisk deploy kernel parameters https://review.opendev.org/c/openstack/ironic/+/802664 | 17:30 |
| JayF | Why does our published DIB element unilaterally disable iptables? https://github.com/openstack/ironic-python-agent-builder/blob/master/dib/ironic-python-agent-ramdisk/post-install.d/80-ironic-python-agent-ramdisk#L27 | 17:37 |
| TheJulia | hmm, looks like that came from the original element | 17:54 |
| TheJulia | I wonder if it had to do with iscsi | 17:54 |
| JayF | it's not going to cause me a problem directly; but that's going to hurt any admin who needs to make an IPA ramdisk with firewall rules for compliance reasons | 17:55 |
| TheJulia | https://github.com/openstack/diskimage-builder/commit/dd7648277fa45f102c4dd30bde90bd44ecb8a553 | 17:56 |
| TheJulia | Looks like the original idea came in the original commit | 18:01 |
| TheJulia | err | 18:01 |
| TheJulia | no | 18:01 |
| TheJulia | no yes | 18:01 |
| TheJulia | https://github.com/openstack/diskimage-builder/commit/676b1b738db8a631a92b9a967a8d869dd776cac8#diff-55348da1267f2da1d076e0f7d837eff26bd21feee1562af4e3344313f0571c06 | 18:02 |
| JayF | yeah we should consider making that optional imo | 18:11 |
| JayF | or just don't touch it, but that isn't as backwards compat | 18:12 |
| TheJulia | I think it is *way* easier to do now.. . but yeah | 18:12 |
| TheJulia | stable reviews needed on https://review.opendev.org/q/project:openstack%252Fironic+branch:stable%252Fussuri+status:open | 18:15 |
| TheJulia | hmm, looks like the idrac one needs more reviews elsewhere first | 18:19 |
| * TheJulia does that | 18:19 | |
| *** sshnaidm is now known as sshnaidm|afk | 18:30 | |
| opendevreview | Merged openstack/ironic bugfix/18.0: Refactor iDRAC OEM extension manager calls https://review.opendev.org/c/openstack/ironic/+/795276 | 18:38 |
| JayF | I can look at those if you really need me to TheJulia but I generally avoid the hardware driver specific stuff due to lack of familiarity | 18:46 |
| TheJulia | I took care of the idrac ones | 18:56 |
| TheJulia | it was deduplication of code that I requested a long time ago in a galacy far away | 18:57 |
| TheJulia | galaxy | 18:57 |
| opendevreview | Merged openstack/ironic stable/victoria: Refactor iDRAC OEM extension manager calls https://review.opendev.org/c/openstack/ironic/+/795521 | 20:11 |
| opendevreview | Verification of a change to openstack/ironic stable/ussuri failed: Refactor iDRAC OEM extension manager calls https://review.opendev.org/c/openstack/ironic/+/795524 | 20:11 |
| bfournie | So I'm attempting to upgrade a bifrost setup to master, I've got an issue with the ironic db however and the install fails. When I run ironic-dbsync upgrade I get the multiple heads error "alembic.script.revision.MultipleHeads: Multiple heads are present for given argument 'head'; c1846a214450, bb57cc89ce78". I really don't have multiple heads though, I can see from alembic commands that 'c1846a214450' is the only h | 20:26 |
| bfournie | bb57cc89ce78' is on old revision I was testing with but did not commit. I'm the mysql cli but its not clear how I can remove references to bb57cc89ce78 however, I only see the valid one | 20:26 |
| bfournie | MariaDB [ironic]> select * from alembic_version; | 20:26 |
| bfournie | | version_num | | 20:26 |
| bfournie | | c1846a214450 | | 20:26 |
| bfournie | Any ideas how to find and clear the invalid revision bb57cc89ce78 from the ironic db? | 20:26 |
| TheJulia | bfournie: remove the file ? | 20:28 |
| TheJulia | it picks it up and can't do the upgrade as a result | 20:28 |
| bfournie | TheJulia: the revision file with 'bb57cc89ce78'"? yeah that no longer exists | 20:29 |
| bfournie | TheJulia: I did remove it but still get the error | 20:29 |
| TheJulia | no other wip database changes locally? | 20:30 |
| bfournie | TheJulia: so I was running with that revision prior to the upgrade but when I updated Ironic it was no longer referenced. Now I think I need to remove something directly in the ironic db but can't find it | 20:31 |
| TheJulia | hmm yeah | 20:31 |
| TheJulia | I'm not sure where that gets squirreled away in the db | 20:31 |
| TheJulia | you could dump it out to a sql file and look through it | 20:32 |
| bfournie | TheJulia: yeah let me try taht | 20:32 |
| bfournie | that | 20:32 |
| TheJulia | stevebaker: if you want to chat about grub, lmk | 20:35 |
| stevebaker | TheJulia: good morning, yes! | 20:37 |
| JayF | I just lost like, half a day to this: https://github.com/openstack/ironic-python-agent-builder/blob/master/dib/ironic-ramdisk-base/cleanup.d/99-ramdisk-create#L48 | 21:18 |
| JayF | it means if you install a package that depends on, say, /var/log/packagename/ existing in the IPA ramdisk, it completely breaks and there's no way to work around it | 21:19 |
| JayF | I guess I'll have to create the dir on boot in my ramdisk or something? | 21:19 |
| JayF | anyone have any ideas? | 21:25 |
| JayF | Yeah, I've convinced myself that line of code is doing more harm than good, I'm going to straight up PR a removal. It's not right of us to break any package trying to log to somewhere in /var/log | 21:29 |
| opendevreview | Julia Kreger proposed openstack/ironic master: DNM/WIP - Add FIPS jobs https://review.opendev.org/c/openstack/ironic/+/797739 | 21:31 |
| JayF | TheJulia: ^ you have any ideas, perhaps? | 21:31 |
| TheJulia | JayF: needing a folder in /var/log seems... weird | 21:34 |
| TheJulia | I guess it should be okay to remove the removal... or amend... maybe | 21:35 |
| JayF | TheJulia: There are a myriad of applications, I can probably find an example in public centos repos, that log to /var/log/appname/blah | 21:35 |
| JayF | Apache2 comes to mind | 21:35 |
| JayF | I'm trying to see if I can make the paths to prune configurable, but that seems like it'll be messy | 21:36 |
| TheJulia | I would thinkt hey would pre-create on launch, but I guess if they don't it would need to be created for permission reasons | 21:36 |
| JayF | In this case, it's 100% created in the RPM. | 21:37 |
| TheJulia | yeah | 21:37 |
| JayF | I am trying not to judge the rpm, it has problems but this really isn't one of them :D | 21:37 |
| TheJulia | it would need to be becasue of the different permissions as it launches with root privs and then sets it uid/gid to something else it is handcuffed from doing bad things | 21:37 |
| JayF | yeah I think I have a configurable approach that will maintain existing behavior | 21:40 |
| JayF | in exchange for my months of a near-infinite review ratio, I may want to cash in ALL of the favors to get this thing reviewed/merged quickly | 21:41 |
| JayF | or else I gotta patch it downstream and I'm running out of time this week lol | 21:41 |
| opendevreview | Jay Faulkner proposed openstack/ironic-python-agent-builder master: Allow configuration of paths to prune https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/802965 | 21:52 |
| JayF | this may be the ugliest bash I've ever written. Time to go cheer on the CI. | 21:52 |
| opendevreview | Jay Faulkner proposed openstack/ironic-python-agent-builder master: Allow configuration of paths to prune https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/802965 | 22:03 |
| JayF | ^ tested working downstream \o/ | 22:08 |
| TheJulia | stevebaker: so I figured out the issue with the fips jobs. They reboot the test machine and loose the ssh connection which kills the job... of course... | 22:09 |
| stevebaker | that would do it | 22:09 |
| kkillsfirst | Hello TheJulia, I was looking at the code from https://review.opendev.org/c/openstack/ironic/+/688977/6/ironic/drivers/modules/agent_base.py#63 . I was wanting to know where the LOG.info() outputs to? | 22:13 |
| TheJulia | kkillsfirst: my guess would be journald logging facility | 22:14 |
| JayF | `journalctl -u ironic-conductor` would show you that if you're unfamiliar kkillsfirst | 22:15 |
| kkillsfirst | Thank you, TheJulia and JayF. | 22:16 |
| TheJulia | I guess my worry is that... is it not? | 22:18 |
| TheJulia | JayF: fwiw, your patch looks good to me but I guess we'll wait on ci | 22:21 |
| JayF | TheJulia: thanks :) It's nice to be able to fix a thing upstream and it have urgency because I /can/ use it right away :D | 22:22 |
| JayF | lol | 22:22 |
| JayF | TheJulia: I'm stepping away for a bit; if you wanna vote in anticipation of CI-success I wouldn't object :P I'm going to keep an eye on it and ensure CI is happy on it | 22:25 |
| TheJulia | JayF: ack | 22:28 |
| janders | good morning Ironic o/ | 22:53 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!