opendevreview | Merged openstack/ironic-python-agent master: Trivial: minor fixes in error messages https://review.opendev.org/c/openstack/ironic-python-agent/+/807713 | 01:02 |
---|---|---|
TheJulia | o/ stevebaker | 01:03 |
TheJulia | I spent time reviewing today, if it didn't stand out :) | 01:03 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP: API endpoints to get node history https://review.opendev.org/c/openstack/ironic/+/803855 | 01:05 |
TheJulia | stevebaker: would appreciate a review on ^,, I *think* I only need to write one or two unit tests and then the policy checks | 01:05 |
TheJulia | which shouldn't take that long | 01:05 |
TheJulia | but not today brain things | 01:05 |
stevebaker | TheJulia: ok, I'll take a look | 01:05 |
TheJulia | I've tried to keep the whole thing in-line with the spec except I didn't do the pluggable backend stuffs | 01:06 |
TheJulia | if someone wants it, they can implement it | 01:06 |
stevebaker | ack | 01:08 |
* TheJulia goes and makes pizza | 01:12 | |
*** pmannidi is now known as pmannidi|AFK | 01:12 | |
opendevreview | Steve Baker proposed openstack/bifrost master: WIP support grub network boot https://review.opendev.org/c/openstack/bifrost/+/807220 | 01:54 |
*** pmannidi|AFK is now known as pmannidi | 02:52 | |
*** pmannidi is now known as pmannidi|brb | 04:11 | |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Enable parallel downloads and allow tuning concurrency https://review.opendev.org/c/openstack/ironic/+/807870 | 06:00 |
dtantsur | morning ironic | 06:00 |
dtantsur | TheJulia: re iter_nodes and stuff: I'm not inventing anything, just documenting the pattern that everyone already uses | 06:04 |
dtantsur | if I don't document, people will copy-paste it from redfish/ilo/idrac | 06:04 |
*** pmannidi|brb is now known as pmannidi | 06:08 | |
iurygregory | good morning dtantsur and Ironic o/ | 07:11 |
* dtantsur -> errands, brb | 07:44 | |
*** sshnaidm is now known as sshnaidm|off | 08:04 | |
xenwar | Hi all, I am trying to boot a serverw with two disks via Ironic using UBUNTU_20.04 image. Both raid 0 and raid 1 configurations would not result in proper booting, getting the following error. “VFS: Cannot open root device “PARTUUID=…..” or unknown-block(0,0): error -6 Thinking that this was caused by the raid configuration, I deleted the raid setup. However, this did not solve the problem. The last thing I seen in the console is (initram | 08:14 |
xenwar | When using Centos (with the raid), I did manage to boot successfully. | 08:15 |
xenwar | So, I was wondering if I need to change something for it to work. Or if there some documentation I cam follow. | 08:15 |
iurygregory | xenwar, maybe you can check the image-requirements we have for sw-raid https://docs.openstack.org/ironic/latest/admin/raid.html#image-requirements | 08:19 |
iurygregory | if you are trying to use local boot in the node the fina instance image needs the mdadm utility installed | 08:20 |
xenwar | iurygregory, thanks. The image does have the raid utilities installed. But, I will the rootfs_uuid described in the documentation you provided. | 08:24 |
iurygregory | good luck! | 08:24 |
xenwar | iurygregory, thanks. | 08:34 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix iDRAC import configuration job with errors https://review.opendev.org/c/openstack/ironic/+/805431 | 09:13 |
dtantsur | are we all set for a sushy-tools release? I have https://review.opendev.org/c/openstack/sushy-tools/+/806253 but it can wait | 12:35 |
iurygregory | dtantsur, I think we can request the release, I'm going to request one for ipa-builder and ironic-ui later today | 13:10 |
TheJulia | dtantsur: w/r/t iter_nodes, I have zero issues with documenting, but obviously we don't want patterns which could be problematic. In fact, we *should* fix the redfish one so it is more efficient | 13:22 |
dtantsur | TheJulia: redfish, ilo, idrac, irmc :) all drivers use this pattern | 13:22 |
dtantsur | and we don't really have a replacement (we cannot filter on the driver/interface name, they're not programatically accessible) | 13:23 |
TheJulia | we could have a field level match feature | 13:23 |
TheJulia | which would allow redfish and idrac at a minimum to use it some cases | 13:23 |
dtantsur | I'm not sure I follow | 13:23 |
TheJulia | that was what I suspected the issue is | 13:24 |
TheJulia | or disconnect is likely the better word | 13:24 |
TheJulia | let me caffinate and wake up | 13:24 |
dtantsur | coffee++ | 13:24 |
TheJulia | dtantsur: replied on https://review.opendev.org/c/openstack/ironic/+/803128 | 13:45 |
dtantsur | and I've just replied to your reply :) | 13:48 |
TheJulia | dtantsur: its not devstack | 13:49 |
TheJulia | it is literally the ansible base jobs to setup the test vms | 13:49 |
TheJulia | they dropped the db setup stuffs into projects when they ripped out out of infra | 13:49 |
dtantsur | okay, it's easy to check: let's see if postresql is being configured in a dsvm job | 13:49 |
TheJulia | I *believe* it is | 13:49 |
TheJulia | and it is being configured for things like unit tests | 13:50 |
dtantsur | so far nothing in https://zuul.opendev.org/t/openstack/build/8d52fc5278554ad596fb1bf1ff4cfd66/: no matches for test-setup in job-output.txt, postres disabled in devstack (although it is installed) | 13:52 |
dtantsur | okay, this is the role that invokes the script, let's trace its usage: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/test-setup/tasks/main.yaml | 13:53 |
dtantsur | (and omg how I like hardcoded script names instead of, you know, ansible..) | 13:54 |
TheJulia | https://opendev.org/opendev/infra-manual/src/branch/master/doc/source/drivers.rst#unit-test-set-up | 13:54 |
dtantsur | this is one usage: https://opendev.org/zuul/zuul-jobs/src/branch/master/playbooks/unittests/pre.yaml | 13:54 |
TheJulia | yup | 13:55 |
TheJulia | I ran across the docs before I ran into the job config | 13:55 |
dtantsur | seems to be unit tests only, I cannot find any hits in https://codesearch.opendev.org/?q=test-setup&i=nope&literal=nope&files=&excludeFiles=&repos= except for tox-related tests | 13:56 |
TheJulia | so its just unit tests then | 13:56 |
dtantsur | I would assume that devstack is responsible for databases in dsvm jobs | 13:56 |
TheJulia | seems that way yes | 13:56 |
dtantsur | TheJulia: if you want to restore ./tools now, I can quickly (re)approve | 13:57 |
dtantsur | or maybe it does not matter | 13:57 |
dtantsur | I've put W+1, I don't think we update ./tools often enough for it to matter | 13:58 |
dtantsur | I was just curious to figure out the logic behind the change | 13:58 |
TheJulia | for dsvm jobs, it really doesn't matter I think | 13:58 |
TheJulia | That was kind of my thinking as well behind my +2 | 13:58 |
TheJulia | dtantsur: indeed, yeah. | 13:59 |
dtantsur | so, periodic tasks and bad patterns.. yeah. dunno. | 13:59 |
TheJulia | up for chatting? | 14:00 |
dtantsur | voice? | 14:00 |
TheJulia | yeah | 14:00 |
dtantsur | yep | 14:00 |
TheJulia | https://meet.google.com/wzs-qewi-oix | 14:00 |
TheJulia | yay consensus | 14:36 |
TheJulia | iurygregory: So when I was chatting with dtantsur, we realized that we need to release ironic next week or at worst the week after | 14:47 |
iurygregory | TheJulia, ack | 14:49 |
* iurygregory adds a note | 14:49 | |
TheJulia | I think we should use the review jams next week to try and review items that would be good to get in and get them merged if possible | 14:49 |
iurygregory | agree, and on monday we should probably talk about the PTG also | 14:50 |
dtantsur | I have some nice cute patches to review ^_^ | 14:50 |
iurygregory | dtantsur, please define cute | 14:51 |
dtantsur | like kittens, but patches | 14:51 |
* iurygregory never saw dtantsur using ^_^ | 14:51 | |
dtantsur | srsly? | 14:51 |
iurygregory | yup | 14:51 |
dtantsur | I think I use even =^_^= all the time | 14:51 |
iurygregory | ^ this one is for the kittens :D | 14:51 |
TheJulia | dtantsur: only when your preparing for vacation, really :) | 14:52 |
TheJulia | at least on IRC :) | 14:52 |
dtantsur | oookay, I'll do it more often | 14:53 |
TheJulia | \o/ | 14:53 |
TheJulia | now, we just need to have a "kitten gif attached to each change" requirement | 14:53 |
dtantsur | if we switched to matrix, we could have kitten gifs here.. just saying ;) | 14:53 |
TheJulia | So looks like Steve provided review feedback on the history events work and raised a note that perhaps we should have a severity field | 14:54 |
TheJulia | so we can delineate errors from items which were more... informational. | 14:55 |
dtantsur | mmm, I recall asking the same thing at some point.. | 14:55 |
dtantsur | or maybe I just wanted to? | 14:55 |
TheJulia | I don't remember it coming up before but I'm kind of in agreement | 14:55 |
TheJulia | it would be good™ | 14:56 |
TheJulia | Any objections to adding it? | 14:59 |
iurygregory | none from my side, I think it makes sense | 15:00 |
Nisha_Agarwal | dtantsur, hi | 15:09 |
Nisha_Agarwal | good evening | 15:09 |
dtantsur | hi Nisha_Agarwal | 15:12 |
dtantsur | TheJulia: https://storyboard.openstack.org/#!/story/2009203 | 15:13 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix idrac-wsman forced hard power off https://review.opendev.org/c/openstack/ironic/+/808098 | 15:18 |
ajya | rpioso, TheJulia for the bz issue ^ | 15:18 |
TheJulia | ajya: Richard was just telling me about this :) | 15:20 |
Nisha_Agarwal | dtantsur, did u had a chance to look at https://review.opendev.org/c/openstack/ironic/+/799562 | 15:21 |
TheJulia | ajya: feedback posted | 15:25 |
* rpioso becomes giddy due to the speed and means of communications :-) | 15:27 | |
dtantsur | Nisha_Agarwal: no, sorry, no time so far | 15:29 |
ajya | TheJulia: thanks | 15:32 |
NobodyCam | Good Morning Ironic folks, wow Nisha_Agarwal long time | 15:41 |
Nisha_Agarwal | NobodyCam, :) yup | 15:42 |
NobodyCam | o/ | 15:42 |
Nisha_Agarwal | NobodyCam, not a constant contributor to ironic ..... | 15:42 |
NobodyCam | Glad to see you in channel | 15:43 |
TheJulia | good morning nobodycam | 15:48 |
NobodyCam | Good Morning TheJulia :) | 15:48 |
iurygregory | I'm a bit worried about https://review.opendev.org/c/openstack/ironic/+/803412 =( even if is just a doc change | 15:50 |
iurygregory | good morning NobodyCam | 15:50 |
iurygregory | o/ | 15:50 |
NobodyCam | morning iurygregory :) | 15:50 |
TheJulia | iurygregory: oh, agree, it reads horribly | 15:50 |
TheJulia | but I think it is a contextal issue at the same time | 15:51 |
TheJulia | and ideally, they should fix the behavior | 15:51 |
iurygregory | yeah | 15:51 |
TheJulia | but we don't know the risk/rate/etc | 15:51 |
iurygregory | exactly =( | 15:51 |
TheJulia | that whole aspect and being they also handle most of their user base support, was kind of why I +2'ed it, thinking... if they do feel pain, they'll fix it. | 15:52 |
iurygregory | humm I see | 15:52 |
TheJulia | i like your reply | 15:53 |
TheJulia | that may create some heartburn for them though | 15:53 |
opendevreview | Verification of a change to openstack/ironic master failed: Set postgresql password encryption for FIPS compliance https://review.opendev.org/c/openstack/ironic/+/803128 | 15:53 |
* TheJulia glares at ci | 15:53 | |
iurygregory | I know the docs will be important, we need the information available for our users (otherwise they will not be aware), maybe having some sort of message in their driver that will Log a warning would be good? | 16:03 |
TheJulia | It *sounds* like the bmc caches data and we can potentially end up with the cache at some transition point with the library | 16:12 |
TheJulia | Likely hardware, since I seem to remember somepalce recently they changed the models supported listing | 16:12 |
dtantsur | have a nice evening folks | 16:14 |
dtantsur | o/ | 16:14 |
TheJulia | you too dtantsur | 16:25 |
opendevreview | Merged openstack/ironic master: Use packaged grub efi for network boot https://review.opendev.org/c/openstack/ironic/+/806808 | 17:19 |
*** eandersson5 is now known as eandersson | 17:30 | |
opendevreview | Merged openstack/ironic master: Trivial: shorten the deploy/clean step failure message https://review.opendev.org/c/openstack/ironic/+/807718 | 17:32 |
opendevreview | Julia Kreger proposed openstack/ironic master: Implements node history: database https://review.opendev.org/c/openstack/ironic/+/768009 | 17:59 |
opendevreview | Julia Kreger proposed openstack/ironic master: Record node history and manage events in db https://review.opendev.org/c/openstack/ironic/+/803292 | 17:59 |
opendevreview | Tadeas Kot proposed openstack/ironic-inspector master: Add support for state selector in the list introspection https://review.opendev.org/c/openstack/ironic-inspector/+/807578 | 19:08 |
TheJulia | stevebaker: ping me when your around, I needs a favor | 20:17 |
stevebaker | TheJulia: I've just sat down | 20:17 |
TheJulia | fully caffinated and all?! | 20:17 |
stevebaker | amped and ready to go! | 20:18 |
TheJulia | awesome! | 20:20 |
opendevreview | Merged openstack/ironic master: Clean step to remove CA certificates from iLO https://review.opendev.org/c/openstack/ironic/+/799562 | 20:30 |
opendevreview | Steve Baker proposed openstack/bifrost master: WIP support grub network boot https://review.opendev.org/c/openstack/bifrost/+/807220 | 20:49 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP: API endpoints to get node history https://review.opendev.org/c/openstack/ironic/+/803855 | 21:59 |
TheJulia | stevebaker: ^^ | 21:59 |
TheJulia | I went ahead and hard coded it on the db query, we'll see if the unit tests blow up on it | 21:59 |
stevebaker | TheJulia: the sort by ascending created_at? I've since realised that we'll need to be careful with paging/marker/limit when the important records are at the end of the list. Just don't implement paging is the easiest option | 22:07 |
TheJulia | I was partially pondering just not supporting paging/marker/limit, but we can just pass it down through | 22:08 |
TheJulia | which sounds awful, but the history shouldn't be retained forever.... | 22:08 |
stevebaker | as long as the baremetal client command keeps fetching until there are no more records, it can be batched with paging | 22:10 |
TheJulia | the ... I can't think of what it is called... handles the paging/marker/limit stuffs | 22:10 |
TheJulia | well, paging support requires marker/limit logic | 22:10 |
TheJulia | fun for tomorrow if nothing comes up | 22:12 |
TheJulia | ... and if i can see | 22:12 |
stevebaker | O_o | 22:13 |
TheJulia | eye doctor appt | 22:14 |
TheJulia | I need new glasses, contacts, sun glasses | 22:14 |
TheJulia | I've been putting it off for... oh... well over a year | 22:14 |
stevebaker | ah yes, seeing is good. I highly recommend it | 22:16 |
TheJulia | I think I got my last batch of contacts right before the Boston Summit Keynote | 22:19 |
TheJulia | obviously, I've not worn contacts for a while | 22:19 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!