*** pmannidi is now known as pmannidi|brb | 00:14 | |
*** pmannidi|brb is now known as pmannidi | 01:02 | |
opendevreview | Steve Baker proposed openstack/bifrost master: WIP support grub network boot https://review.opendev.org/c/openstack/bifrost/+/807220 | 01:33 |
---|---|---|
stevebaker | TheJulia: soz I found something else https://review.opendev.org/c/openstack/tripleo-heat-templates/+/802740 | 02:08 |
*** pmannidi is now known as pmannidi|Lunch | 04:12 | |
*** pmannidi|Lunch is now known as pmannidi | 04:57 | |
opendevreview | Steve Baker proposed openstack/bifrost master: WIP support grub network boot https://review.opendev.org/c/openstack/bifrost/+/807220 | 05:04 |
opendevreview | Verification of a change to openstack/ironic master failed: Fix idrac-wsman set_power_state to wait on HW https://review.opendev.org/c/openstack/ironic/+/808098 | 05:46 |
arne_wiebalck | Good morning, Ironic! | 06:15 |
arne_wiebalck | iurygregory: could you please have a look and give a /lgtm on https://github.com/metal3-io/ironic-hardware-inventory-recorder-image/pull/12 ? | 06:44 |
iurygregory | good morning arne_wiebalck and Ironic o/ | 06:55 |
iurygregory | arne_wiebalck, sure in a few I will take a look | 06:55 |
arne_wiebalck | ty | 06:55 |
iurygregory | arne_wiebalck, I think I can only approve (not add lgtm) =( | 07:20 |
iurygregory | I will ask Derek or Bob to take a look | 07:21 |
*** hjensas is now known as hjensas|afk | 07:27 | |
arne_wiebalck | hmm ... from the workflow it looked liked reviewers can do /lgtm | 07:28 |
arne_wiebalck | anyway :) | 07:28 |
arne_wiebalck | thanks for trying | 07:28 |
iurygregory | hummm yeah I thought so also =( maybe they didn't update for this repo? | 07:29 |
arne_wiebalck | FWIW, I got a notification saying you approved the PR | 07:29 |
arne_wiebalck | maybe it just takes some time until this is picked up and actually merged? | 07:29 |
iurygregory | Yeah I approved the PR | 07:34 |
iurygregory | but I also added the lgtm .... | 07:34 |
iurygregory | but the bot didn't add the label | 07:35 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix clear foreign config in idrac-redfish RAID https://review.opendev.org/c/openstack/ironic/+/804848 | 07:39 |
arne_wiebalck | iurygregory: hmm, yeah, I see | 07:40 |
iurygregory | arne_wiebalck, that is why gerrit >>>>>>> github <3 | 07:41 |
arne_wiebalck | heh | 07:41 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix idrac-wsman set_power_state to wait on HW https://review.opendev.org/c/openstack/ironic/+/808098 | 07:58 |
opendevreview | Verification of a change to openstack/ironic master failed: Fix iDRAC import configuration job with errors https://review.opendev.org/c/openstack/ironic/+/805431 | 09:15 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-inspector master: Fix sqlalchemy https://review.opendev.org/c/openstack/ironic-inspector/+/808917 | 09:17 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-inspector master: Fix sqlalchemy https://review.opendev.org/c/openstack/ironic-inspector/+/808917 | 09:30 |
opendevreview | Merged openstack/ironic-python-agent-builder master: Use Ubuntu Focal instead of the default Bionic https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/808198 | 09:39 |
iurygregory | arne_wiebalck, if you have some time can you look at the inspector fix I pushed? (inspector CI is broken atm) =) | 09:45 |
opendevreview | Verification of a change to openstack/ironic master failed: Fix iDRAC import configuration job with errors https://review.opendev.org/c/openstack/ironic/+/805431 | 09:46 |
iurygregory | arne_wiebalck, I can change to data without problems =) | 10:04 |
ajya | any idea why many tests are failing with reno version conflict, e.g., https://review.opendev.org/c/openstack/ironic/+/808098 | 10:09 |
* iurygregory looks | 10:10 | |
iurygregory | this is the first time I see this failure tbh | 10:16 |
iurygregory | I'm wondering if there was some bump in u-c that is causing this | 10:17 |
iurygregory | ok, the change in the u-c is 1month old... | 10:19 |
iurygregory | I'm wondering if we can solve this by just bumping reno version... so pip will not complain | 10:27 |
iurygregory | ok, a lot of projects are using reno>=3.1.0 like us... wondering if they are also affected.. maybe is a new version of pip that was released | 10:32 |
ajya | this is another patch failing https://review.opendev.org/c/openstack/ironic/+/805431 | 10:34 |
ajya | it seems they started failing earlier today | 10:35 |
iurygregory | yeah I just saw, I've asked infra | 10:36 |
ajya | thanks | 10:37 |
opendevreview | Verification of a change to openstack/bifrost master failed: Keystone: consolidate uWSGI config, drop non-existing plugin https://review.opendev.org/c/openstack/bifrost/+/806121 | 10:45 |
iurygregory | YAY | 10:46 |
iurygregory | our CI is broken \o/ | 10:46 |
ajya | as expected :) | 10:47 |
iurygregory | yes | 10:48 |
iurygregory | (╯°□°)╯︵ ┻━┻ CI | 10:49 |
arne_wiebalck | iurygregory: I was just wondering if I missed sth :) | 11:53 |
opendevreview | Verification of a change to openstack/ironic master failed: Fix in-band cleaning for ramdisk and anaconda deploy https://review.opendev.org/c/openstack/ironic/+/807187 | 12:40 |
opendevreview | Verification of a change to openstack/ironic master failed: Move ramdisk deploy to its own module https://review.opendev.org/c/openstack/ironic/+/807590 | 12:40 |
iurygregory | ajya, feel free to recheck now (the issues from mirror01 should be fixed now) | 13:09 |
ajya | iurygregory: thanks, will do, also will update one patch that got feedback | 13:11 |
iurygregory | ack | 13:12 |
TheJulia | good morning | 13:13 |
TheJulia | iurygregory: what is broken? | 13:14 |
* TheJulia pokes at the docs job locally and gets different errors | 13:30 | |
opendevreview | Merged openstack/ironic-python-agent-builder master: Remove support for iSCSI deploy from the DIB builder https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/808214 | 13:33 |
TheJulia | Well, that is a good sign | 13:35 |
TheJulia | oh, it is a junk file that is getting pulled in locally | 13:36 |
TheJulia | doh | 13:36 |
iurygregory | TheJulia, seems like it was an issue with some of the mirrors | 13:37 |
iurygregory | ops not mirrors but the pypi's cdn | 13:38 |
iurygregory | seems like we can release ipa-builder \o/ | 13:40 |
iurygregory | ok, maybe we want to see if CI is happy about https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/776507 ? | 13:41 |
TheJulia | iurygregory: I guess, it would be good to know *why* of course | 13:44 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix clear foreign config in idrac-redfish RAID https://review.opendev.org/c/openstack/ironic/+/804848 | 13:44 |
iurygregory | TheJulia, "we're just proxying through whatever pypi's serving, and their cdn seems to sometimes serve obsolete content around montreal canada" =D | 13:45 |
iurygregory | from the #opendev channel according to fungi =) | 13:45 |
TheJulia | sweet | 13:46 |
TheJulia | iurygregory: why was in regards to the ipa-b patch | 13:46 |
iurygregory | oh! | 13:46 |
iurygregory | yeah, we don't have much information to understand why Riccardo wants to bump the version .-. | 13:47 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Support HttpHeaders in create_subscription https://review.opendev.org/c/openstack/ironic/+/806859 | 13:48 |
iurygregory | TheJulia, when you have some time today https://review.opendev.org/c/openstack/ironic-inspector/+/808917 quick fix for inspector CI (requirements only runs the cross job against ironic so I forgot to push a patch to inspector) | 13:50 |
TheJulia | approved | 13:57 |
TheJulia | iurygregory: I'd really prefer if we can get https://review.opendev.org/c/openstack/ironic/+/808806 into the release | 13:58 |
TheJulia | s/if/that/ | 13:58 |
iurygregory | will look at it now | 13:58 |
TheJulia | review jam? | 14:00 |
iurygregory | I can join | 14:01 |
TheJulia | well, if nobody else is going to join, it is kind of pointless I gues | 14:01 |
TheJulia | unless we want to just cooridnate reviews to wrap things up | 14:01 |
iurygregory | yeah, I know I have meeting right after the review jam :D | 14:02 |
TheJulia | me too | 14:02 |
ajya | I can join the jam | 14:03 |
TheJulia | Well, I'm on it and doing reviews | 14:04 |
TheJulia | https://review.opendev.org/c/openstack/ironic/+/755836 | 14:08 |
TheJulia | https://review.opendev.org/c/openstack/ironic-python-agent/+/803510 | 14:16 |
opendevreview | Verification of a change to openstack/ironic master failed: Move ramdisk deploy to its own module https://review.opendev.org/c/openstack/ironic/+/807590 | 14:29 |
iurygregory | https://review.opendev.org/c/openstack/ironic/+/804416 | 14:29 |
opendevreview | Verification of a change to openstack/ironic master failed: Fix in-band cleaning for ramdisk and anaconda deploy https://review.opendev.org/c/openstack/ironic/+/807187 | 14:29 |
opendevreview | Merged openstack/ironic-inspector master: Fix sqlalchemy https://review.opendev.org/c/openstack/ironic-inspector/+/808917 | 14:31 |
TheJulia | https://review.opendev.org/c/openstack/ironic-inspector/+/807578 | 14:39 |
TheJulia | https://review.opendev.org/c/openstack/ironic/+/803855 | 14:49 |
TheJulia | https://storyboard.openstack.org/#!/story/2002980 | 14:51 |
opendevreview | Merged openstack/ironic-inspector master: Update parameters for authtoken middleware https://review.opendev.org/c/openstack/ironic-inspector/+/805443 | 15:05 |
opendevreview | Merged openstack/bifrost master: Keystone: consolidate uWSGI config, drop non-existing plugin https://review.opendev.org/c/openstack/bifrost/+/806121 | 15:41 |
ajya | CI is back to green on my patches too | 16:00 |
ajya | stevebaker, TheJulia can you please revisit previously reviewed patch when you have time https://review.opendev.org/c/openstack/ironic/+/808098 Thanks | 16:00 |
ajya | and besides Julia another core reviewer maybe can take a look at this https://review.opendev.org/c/openstack/ironic/+/804112 | 16:01 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix idrac-wsman set_power_state to wait on HW https://review.opendev.org/c/openstack/ironic/+/808098 | 16:02 |
opendevreview | Derek Higgins proposed openstack/ironic-lib master: Allow qemu-img to write out zeros to disk https://review.opendev.org/c/openstack/ironic-lib/+/808993 | 16:03 |
opendevreview | Merged openstack/ironic master: Fix driver task pattern to reduce periodic db load https://review.opendev.org/c/openstack/ironic/+/808806 | 17:12 |
opendevreview | Merged openstack/ironic master: Fix iDRAC import configuration job with errors https://review.opendev.org/c/openstack/ironic/+/805431 | 17:12 |
opendevreview | Merged openstack/ironic master: Fix in-band cleaning for ramdisk and anaconda deploy https://review.opendev.org/c/openstack/ironic/+/807187 | 17:16 |
opendevreview | Merged openstack/ironic master: Implements node history: database https://review.opendev.org/c/openstack/ironic/+/768009 | 17:16 |
opendevreview | Verification of a change to openstack/ironic master failed: Move ramdisk deploy to its own module https://review.opendev.org/c/openstack/ironic/+/807590 | 17:33 |
opendevreview | Julia Kreger proposed openstack/ironic master: API endpoints to get node history https://review.opendev.org/c/openstack/ironic/+/803855 | 19:14 |
opendevreview | Julia Kreger proposed openstack/ironic master: Facilitate asset copy for bootloader ops https://review.opendev.org/c/openstack/ironic/+/806815 | 19:20 |
stevebaker | ajya: sure thing | 19:24 |
opendevreview | Merged openstack/ironic master: Record node history and manage events in db https://review.opendev.org/c/openstack/ironic/+/803292 | 20:04 |
opendevreview | Merged openstack/metalsmith master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/metalsmith/+/808253 | 20:50 |
opendevreview | Merged openstack/ironic master: Fix idrac-wsman set_power_state to wait on HW https://review.opendev.org/c/openstack/ironic/+/808098 | 20:58 |
opendevreview | Julia Kreger proposed openstack/ironic stable/wallaby: Fix idrac-wsman set_power_state to wait on HW https://review.opendev.org/c/openstack/ironic/+/808979 | 21:16 |
opendevreview | Julia Kreger proposed openstack/ironic stable/victoria: Fix idrac-wsman set_power_state to wait on HW https://review.opendev.org/c/openstack/ironic/+/808980 | 21:16 |
opendevreview | Julia Kreger proposed openstack/ironic stable/ussuri: Fix idrac-wsman set_power_state to wait on HW https://review.opendev.org/c/openstack/ironic/+/808981 | 21:17 |
opendevreview | Julia Kreger proposed openstack/ironic stable/train: Fix idrac-wsman set_power_state to wait on HW https://review.opendev.org/c/openstack/ironic/+/808982 | 21:17 |
opendevreview | Verification of a change to openstack/ironic bugfix/18.1 failed: Improve edge-case debugging for deployment and cleaning https://review.opendev.org/c/openstack/ironic/+/807262 | 21:35 |
opendevreview | Merged openstack/ironic master: Document eject_vmedia for Redfish https://review.opendev.org/c/openstack/ironic/+/808201 | 21:39 |
stevebaker | TheJulia: something I'll need to look into at some point, this bifrost job fails but returns SUCCESS to gerrit https://zuul.opendev.org/t/openstack/build/269cc992ef054c298ad392ea56e02552/log/job-output.txt#22943 https://review.opendev.org/c/openstack/bifrost/+/807220 | 22:04 |
opendevreview | Julia Kreger proposed openstack/ironic master: API endpoints to get node history https://review.opendev.org/c/openstack/ironic/+/803855 | 22:15 |
TheJulia | stevebaker: log collection is returning the rc 0 | 23:13 |
TheJulia | job is returning rc 2 | 23:13 |
TheJulia | so yeah... the runner script needs to be fixed | 23:14 |
TheJulia | I thought that was fixed.... *ages* ago | 23:14 |
stevebaker | I'm not seeing anything obvious in old unmerged reviews | 23:21 |
opendevreview | Verification of a change to openstack/ironic master failed: Add support for fields in drivers API https://review.opendev.org/c/openstack/ironic/+/804416 | 23:23 |
TheJulia | hmm | 23:25 |
TheJulia | could tee be suppressing it?! | 23:25 |
TheJulia | playbooks/ci/run.yaml | 23:25 |
stevebaker | TheJulia: I don't see a tee | 23:31 |
stevebaker | maybe the on_exit function needs to return its own error code | 23:32 |
TheJulia | ohh yes | 23:33 |
opendevreview | Julia Kreger proposed openstack/bifrost master: Re-exit with exit code https://review.opendev.org/c/openstack/bifrost/+/809018 | 23:34 |
stevebaker | I'm not seeing any examples or docs which discuss this | 23:36 |
TheJulia | I guess we will see? | 23:37 |
stevebaker | the search results for "man trap" are amusingly unhelpful | 23:38 |
TheJulia | rofl | 23:39 |
stevebaker | TheJulia: oh! this (-e) suggests we need a trap on ERR, as well as EXIT https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html | 23:41 |
opendevreview | Julia Kreger proposed openstack/bifrost master: Re-exit with exit code https://review.opendev.org/c/openstack/bifrost/+/809018 | 23:48 |
opendevreview | Julia Kreger proposed openstack/bifrost master: Explicitly trap on ERR https://review.opendev.org/c/openstack/bifrost/+/809018 | 23:50 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!