| waleedm_ | TheJulia, Hi Julia, I debugged it, I found kwargs missed here https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/clean.py#L76 | 08:14 |
|---|---|---|
| waleedm_ | TheJulia, and that's why the args didn't pass to the clean_step | 08:15 |
| TheJulia | good find waleedm_! | 08:15 |
| TheJulia | Could you post a patch for it? | 08:15 |
| waleedm_ | sure I'll do | 08:15 |
| TheJulia | Excellent, Thanks! | 08:15 |
| TheJulia | I know many contributors are either traveling today or recovering from traveling over the weekend. | 08:16 |
| waleedm_ | TheJulia, do you know if during deploy steps, we can do power cycle for the machine, or it's only reboot ? | 08:55 |
| TheJulia | waleedm_: yes | 09:35 |
| TheJulia | waleedm_: you need to explicitly indicate it if memory serves | 09:35 |
| TheJulia | waleedm_: https://github.com/openstack/ironic/blob/81f17f8a35b415db7a42c615a3b4392c95ab332b/ironic/drivers/modules/agent_base.py#L180 | 09:38 |
| TheJulia | waleedm_: the most important aspect in this is https://github.com/openstack/ironic/blob/81f17f8a35b415db7a42c615a3b4392c95ab332b/ironic/drivers/modules/agent_base.py#L215-L219 | 09:39 |
| TheJulia | Clear the agent token so the agent can re-establish connectivity after the reboot | 09:39 |
| TheJulia | otherwise it is locked out | 09:39 |
| waleedm_ | TheJulia, Ok I see but the point here is doing powercycle or reboot ? | 09:49 |
| TheJulia | yes | 09:51 |
| TheJulia | oh, are you thinking an explicit "go reboot now" step? | 09:51 |
| waleedm_ | TheJulia, no no it's ok to run at the end , but I need powercycle not reboot | 09:54 |
| opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Create fstab entry with appropriate label https://review.opendev.org/c/openstack/ironic-python-agent/+/844486 | 09:54 |
| opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Collect a full lsblk output in the ramdisk logs https://review.opendev.org/c/openstack/ironic-python-agent/+/844747 | 09:54 |
| opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Add `mount` and `parted -l` to the collected commands https://review.opendev.org/c/openstack/ironic-python-agent/+/844748 | 09:54 |
| TheJulia | waleedm_: ahh | 09:54 |
| opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Multipath Hardware path handling https://review.opendev.org/c/openstack/ironic-python-agent/+/844749 | 09:54 |
| TheJulia | hmmm | 09:54 |
| TheJulia | hmmmmm | 09:54 |
| TheJulia | JayF: Surely onmetal had to do the same? | 09:54 |
| iurygregory | good morning Ironic o/ | 10:06 |
| waleedm_ | TheJulia, How can I use " openstack baremetal deploy --deploy-steps" for tesing some deploy_steps ?! | 13:39 |
| waleedm_ | "openstack baremetal node deploy --deploy-steps... " | 13:40 |
| waleedm_ | Do I need a full deployment or there is something faster, and if I need a full deployment how to pass the deploy-steps t the deployment command ? | 13:41 |
| ajya | waleedm__: on which version are you? deploy-steps as arg was added in Wallaby to API, and CLI afterwards. Before that had to use deploy templates | 14:53 |
| cbouchar_ | Where to find ipxe_aa64.efi as defined in variable ipxe_bootfile_name_by_aarch? | 19:11 |
| TheJulia | cbouchar_: ipxe bootimgs packaging | 19:23 |
| cbouchar_ | keep getting x86_64 stuff | 19:23 |
| cbouchar_ | TheJulia: Retrying | 19:47 |
| *** mnasiadka_ is now known as mnasiadka | 19:53 | |
| JayF | TheJulia: hmm. we always used reboot_requested: true in clean steps | 21:06 |
| JayF | TheJulia: I think that was upstremed; but that was back when any power cycle was BMC off (wait for report power off) BMC on IIRC | 21:07 |
| JayF | so any corners around "soft vs hard reboots" probably didn't exist yet | 21:07 |
| JayF | TheJulia: https://github.com/openstack/ironic/commit/bf985bcdd94f953b7d72a2c28481cb2f3ff50508 | 21:08 |
| JayF | TheJulia: so it's not clear to me why that feature wouldn't work; if we somehow nerfed the cleaning reboot to be soft every time I'd consider that a regression | 21:08 |
| JayF | O | 21:09 |
| JayF | *I'm not working today, I've been sick, but obviously if you have further questions I'll see them eventually | 21:09 |
| TheJulia | JayF: so our perceptions are the same then, but I’ve not exhaustively checked the code… summit and running board meeting | 21:53 |
| TheJulia | And now sleep, because midnight is fashionable | 21:53 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!