| opendevreview | Verification of a change to openstack/ironic master failed: Fix redfish-virtual-media for newer iDRACs https://review.opendev.org/c/openstack/ironic/+/848107 | 00:13 |
|---|---|---|
| JayF | If someone else wants to put a review on this, it should (I hope) fix the IPA gate -> https://review.opendev.org/c/openstack/ironic/+/848345 | 04:11 |
| JayF | I've already put my +2 on it :) | 04:12 |
| TheJulia | \o/ | 04:13 |
| * TheJulia crashes as 5 am comes early | 04:16 | |
| *** akahat|ruck is now known as akahat | 05:42 | |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Prevent clear_job_queue failures on older iDRACs https://review.opendev.org/c/openstack/ironic/+/846859 | 06:08 |
| arne_wiebalck | Good morning, Ironic! | 06:29 |
| opendevreview | Verification of a change to openstack/ironic master failed: Fix redfish-virtual-media for newer iDRACs https://review.opendev.org/c/openstack/ironic/+/848107 | 06:52 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Prevent clear_job_queue and reset_idrac failures on older iDRACs https://review.opendev.org/c/openstack/ironic/+/846859 | 06:57 |
| janders | hey arne_wiebalck and Ironic o/ | 06:59 |
| janders | Happy Friday | 06:59 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Prevent clear_job_queue and reset_idrac failures on older iDRACs https://review.opendev.org/c/openstack/ironic/+/846859 | 06:59 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Prevent clear_job_queue and reset_idrac failures on older iDRACs https://review.opendev.org/c/openstack/ironic/+/846859 | 07:02 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Prevent clear_job_queue and reset_idrac failures on older iDRACs https://review.opendev.org/c/openstack/ironic/+/846859 | 07:06 |
| janders | ajya I added handling reset_idrac to ^ but having some issues with unit tests for the reset_idrac part: https://paste.openstack.org/show/bX1L2xKTHeCX9nzKMQnK/ | 07:09 |
| janders | I wonder if I need to add something to the test due to redfish_utils.wait_until_get_system_ready(task.node): https://review.opendev.org/c/openstack/ironic/+/846859/9/ironic/drivers/modules/drac/management.py#657 | 07:10 |
| janders | I'd appreciate any pointers. Thanks in advance. Heading off for some time but will be back in few hours. | 07:10 |
| ajya | Hi janders. The test tries to connect to real Redfish API which is not possible in unit tests. Something is missing from the mocking. | 07:12 |
| ajya | Looking at the existing test it's this: @mock.patch.object(redfish_utils, 'wait_until_get_system_ready', autospec=True) | 07:13 |
| ajya | and good morning Ironic, arne_wiebalck | 07:15 |
| arne_wiebalck | hey ajya o/ | 07:15 |
| opendevreview | Verification of a change to openstack/ironic master failed: CI: Pull in diskimage-builder until new release is cut https://review.opendev.org/c/openstack/ironic/+/848345 | 08:26 |
| opendevreview | Verification of a change to openstack/ironic-python-agent master failed: Drop python2 from bindep.txt https://review.opendev.org/c/openstack/ironic-python-agent/+/845371 | 08:26 |
| janders | ajya thank you, will give it a shot, will keep you posted | 10:46 |
| iurygregory | good morning Ironic | 11:08 |
| janders | hey iurygregory, Happy Friday! | 11:11 |
| janders | ajya replicating approach to wait_until_get_system_ready from the existing iDRAC reset tests definitely sorted out the timeouts, now I need to actually fix the tests, beyond that we should be good! thanks again | 11:21 |
| ajya | janders: welcome | 11:22 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Prevent clear_job_queue and reset_idrac failures on older iDRACs https://review.opendev.org/c/openstack/ironic/+/846859 | 11:31 |
| janders | ajya a follow up question: looking at the current test failures for the iDRAC reset part in the patch ^, I suspect the exception injection isn't working: https://review.opendev.org/c/openstack/ironic/+/846859/11/ironic/tests/unit/drivers/modules/drac/test_management.py#1510 | 11:44 |
| janders | (if I fiddle with the conditional to make it behave as if it was getting injected, tests succeed) | 11:44 |
| janders | I wonder if I need to do this differently for reset_idrac than for clear_job_queue? | 11:45 |
| janders | (possibly due to presence of wait_until_get_system_ready) | 11:45 |
| ajya | janders: try to mock the same method that ironic calls, that is manager.reset_idrac, not manager.idrac_card_service.reset_idrac https://opendev.org/openstack/sushy-oem-idrac/src/commit/aac2509f7b35b0a922f19165c61e71478616e75c/sushy_oem_idrac/resources/manager/manager.py#L534 | 12:03 |
| ajya | that's how they're different as reset_idrac does some more processing in the OEM extension | 12:03 |
| ajya | Hi iurygregory , TheJulia is it OK to backport also these fixes for Redfish RAID - https://review.opendev.org/c/openstack/ironic/+/823347 https://review.opendev.org/c/openstack/ironic/+/823312 https://review.opendev.org/c/openstack/ironic/+/823311/ back to Wallaby? | 12:05 |
| ajya | I'm backporting https://review.opendev.org/c/openstack/ironic/+/848128 but there is some code in unit tests that is needed from these ^ | 12:06 |
| * iurygregory looks | 12:06 | |
| ajya | otherwise the backport starts to look like a new code or combined from other patches that are not backported | 12:07 |
| TheJulia | I don't see why not.... | 12:11 |
| TheJulia | Also, good morning! | 12:11 |
| * TheJulia tries to wake up and hopes the caffiene results in words soon | 12:11 | |
| * TheJulia has to write a lot today | 12:12 | |
| opendevreview | Merged openstack/ironic master: Fix redfish-virtual-media for newer iDRACs https://review.opendev.org/c/openstack/ironic/+/848107 | 12:22 |
| iurygregory | yeah it should be good (sorry got interrupted by downstream questions...) | 12:24 |
| iurygregory | good morning TheJulia | 12:24 |
| ajya | good morning TheJulia | 12:26 |
| ajya | ok, will start backporting | 12:27 |
| janders | ajya that worked, thanks again! | 12:43 |
| janders | running all tests now, will push the revised version shortly | 12:44 |
| opendevreview | Aija Jauntēva proposed openstack/ironic stable/xena: Fix prepare ramdisk for 'wait' states https://review.opendev.org/c/openstack/ironic/+/848356 | 12:44 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Prevent clear_job_queue and reset_idrac failures on older iDRACs https://review.opendev.org/c/openstack/ironic/+/846859 | 12:47 |
| janders | ajya when you have time, it would be great if you can review ^, I think it incorporates all your feedback | 12:48 |
| janders | thanks for all your help today! | 12:48 |
| janders | see you next week Ironic, have a great weekend everyone o/ | 12:49 |
| ajya | see you, janders will try next week | 12:53 |
| TheJulia | \o/ one meeting done | 13:04 |
| opendevreview | Aija Jauntēva proposed openstack/ironic stable/wallaby: Fix prepare ramdisk for 'wait' states https://review.opendev.org/c/openstack/ironic/+/848444 | 13:09 |
| opendevreview | Aija Jauntēva proposed openstack/ironic stable/xena: Fix redfish RAID failed tasks https://review.opendev.org/c/openstack/ironic/+/848357 | 13:15 |
| opendevreview | Aija Jauntēva proposed openstack/ironic stable/wallaby: Fix redfish RAID failed tasks https://review.opendev.org/c/openstack/ironic/+/848358 | 13:16 |
| opendevreview | Aija Jauntēva proposed openstack/ironic stable/yoga: Fix redfish-virtual-media for newer iDRACs https://review.opendev.org/c/openstack/ironic/+/848359 | 13:18 |
| *** rcastillo is now known as rcastillo|rover | 13:31 | |
| opendevreview | Aija Jauntēva proposed openstack/ironic stable/xena: Fix redfish-virtual-media for newer iDRACs https://review.opendev.org/c/openstack/ironic/+/848450 | 13:42 |
| opendevreview | Aija Jauntēva proposed openstack/ironic stable/wallaby: Fix redfish-virtual-media for newer iDRACs https://review.opendev.org/c/openstack/ironic/+/848451 | 13:59 |
| opendevreview | Merged openstack/ironic stable/yoga: Fix Redfish RAID to update raid_config https://review.opendev.org/c/openstack/ironic/+/848128 | 14:02 |
| arne_wiebalck | mraineri: if you could provide us with a src rpm, that would be most convenient for us :) | 15:41 |
| mraineri | arne_wiebalck: Would pushing it to PyPI be the right spot for you? | 16:47 |
| TheJulia | NobodyCam: question when you have a few minutes regarding the snmp stuffs | 17:08 |
| TheJulia | JayF: of course, that CI fix broke on gate checks on a dhcp issue it looks like | 17:17 |
| TheJulia | unrelated of course :( | 17:17 |
| opendevreview | Verification of a change to openstack/ironic master failed: CI: Pull in diskimage-builder until new release is cut https://review.opendev.org/c/openstack/ironic/+/848345 | 17:38 |
| JayF | TheJulia: :| | 19:31 |
| TheJulia | and post-fail timeout on collecting the subunit file | 19:40 |
| TheJulia | ugh | 19:40 |
| TheJulia | when did it become almost 1 pm | 19:43 |
| TheJulia | (of course, my 5:30 AM was my first meeting) | 19:45 |
| opendevreview | Merged openstack/ironic master: CI: Pull in diskimage-builder until new release is cut https://review.opendev.org/c/openstack/ironic/+/848345 | 22:56 |
| TheJulia | \o/ | 22:57 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Fix passing kwargs in clean steps https://review.opendev.org/c/openstack/ironic-python-agent/+/845583 | 23:03 |
| TheJulia | JayF: quick revision of the release note: https://review.opendev.org/c/openstack/ironic-python-agent/+/845583 | 23:04 |
| TheJulia | derekh: With regards to https://review.opendev.org/c/openstack/ironic-python-agent/+/846177, is there a need/want to backport? | 23:09 |
| opendevreview | Verification of a change to openstack/ironic master failed: Auto-populate lessee for deployments https://review.opendev.org/c/openstack/ironic/+/818641 | 23:09 |
| TheJulia | NobodyCam: lets chat about https://review.opendev.org/c/openstack/ironic/+/840986 at some point soon | 23:10 |
| NobodyCam | yea | 23:12 |
| NobodyCam | and of course happy Friday Ironicer's | 23:12 |
| TheJulia | I'm slightly confused about it, but given some of the git confusion, perhaps a advanced git class might be helpful? | 23:14 |
| TheJulia | and my confusion is about git state more than anything | 23:15 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!