opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-ui master: DNM - Testing CI before Zed release https://review.opendev.org/c/openstack/ironic-ui/+/856353 | 01:33 |
---|---|---|
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent-builder master: DNM - Testing CI before Zed release https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/856354 | 01:33 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: DNM - Testing CI before Zed release https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/856355 | 01:33 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/networking-generic-switch master: DNM - Testing CI before Zed release https://review.opendev.org/c/openstack/networking-generic-switch/+/856356 | 01:33 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/networking-baremetal master: DNM - Testing CI before Zed release https://review.opendev.org/c/openstack/networking-baremetal/+/856357 | 01:33 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/bifrost master: DNM - Testing CI before Zed release https://review.opendev.org/c/openstack/bifrost/+/856358 | 01:35 |
opendevreview | OpenStack Release Bot proposed openstack/ironic-lib stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/ironic-lib/+/856412 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/ironic-lib stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/ironic-lib/+/856413 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/ironic-lib master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/ironic-lib/+/856414 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/metalsmith stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/metalsmith/+/856415 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/metalsmith stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/metalsmith/+/856416 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/metalsmith master: Update master for stable/zed https://review.opendev.org/c/openstack/metalsmith/+/856417 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/metalsmith master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/metalsmith/+/856418 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironic-inspector-client stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/856419 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironic-inspector-client stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/856420 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironic-inspector-client master: Update master for stable/zed https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/856421 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironic-inspector-client master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/856422 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironicclient stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/python-ironicclient/+/856423 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironicclient stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/python-ironicclient/+/856424 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironicclient master: Update master for stable/zed https://review.opendev.org/c/openstack/python-ironicclient/+/856425 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironicclient master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-ironicclient/+/856426 | 07:52 |
opendevreview | OpenStack Release Bot proposed openstack/sushy stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/sushy/+/856427 | 07:53 |
opendevreview | OpenStack Release Bot proposed openstack/sushy stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/sushy/+/856428 | 07:53 |
opendevreview | OpenStack Release Bot proposed openstack/sushy master: Update master for stable/zed https://review.opendev.org/c/openstack/sushy/+/856429 | 07:53 |
opendevreview | OpenStack Release Bot proposed openstack/sushy master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/sushy/+/856430 | 07:53 |
adam-rozman | Good day Ironic! | 08:02 |
opendevreview | Hayato Morita proposed openstack/ironic master: Add warning to notify requirements for vmedia boot https://review.opendev.org/c/openstack/ironic/+/854735 | 08:12 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Add a WarningsFixture https://review.opendev.org/c/openstack/ironic/+/856345 | 10:00 |
opendevreview | Stephen Finucane proposed openstack/ironic master: db: Resolve SAWarning warnings https://review.opendev.org/c/openstack/ironic/+/856349 | 10:00 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Enable SQLAlchemy 2.0 deprecation warnings https://review.opendev.org/c/openstack/ironic/+/856346 | 10:00 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Replace invalid UUIDs https://review.opendev.org/c/openstack/ironic/+/856347 | 10:00 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Comment out prints https://review.opendev.org/c/openstack/ironic/+/856348 | 10:00 |
dtantsur | TheJulia, iurygregory, JayF, I'm pondering automating getting event logs from BMCs if possible | 10:11 |
dtantsur | maybe akin to our ramdisk logs collection | 10:11 |
dtantsur | a lot of issues with virtual media could be made much more debuggable | 10:11 |
iurygregory | good morning ironic | 11:09 |
iurygregory | dtantsur, that makes a lot of sense I would say | 11:09 |
dtantsur | mraineri: hi! before I dive too deep into specs and forums, do you happen to remember if Redfish exposes the BMC event log? The thing that contains, among other things, reasons for failed virtual media connection? | 11:21 |
dtantsur | fg | 11:30 |
dtantsur | damn | 11:30 |
opendevreview | Dmitry Tantsur proposed openstack/ironic-inspector master: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/ironic-inspector/+/856488 | 11:43 |
dtantsur | this does not fix the problem for me locally :( | 11:44 |
dtantsur | ideas welcome | 11:44 |
opendevreview | Merged openstack/sushy stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/sushy/+/856427 | 11:56 |
opendevreview | Merged openstack/sushy stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/sushy/+/856428 | 11:56 |
opendevreview | Merged openstack/ironic-lib stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/ironic-lib/+/856412 | 12:02 |
opendevreview | Merged openstack/ironic-lib stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/ironic-lib/+/856413 | 12:02 |
opendevreview | Merged openstack/sushy master: Update master for stable/zed https://review.opendev.org/c/openstack/sushy/+/856429 | 12:13 |
iurygregory | going to test locally | 12:36 |
ajya | Hi iurygregory , if I remember correctly, few cycles ago you were looking at tempest+bifrost. What's the status there? | 12:49 |
iurygregory | ajya, due to downstream priorities I wasn't able to move forward on that .-. | 12:52 |
ajya | iurygregory: what are the thing necessary for this/why this combo isn't working? | 12:53 |
iurygregory | ajya, I wasn't able to full test, my wip was just installing tempest+ironic plugin and trying to generate the necessary config (I didn't attempt to run tests at that time) | 12:54 |
ajya | iurygregory: ok, thanks | 12:55 |
opendevreview | Merged openstack/sushy master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/sushy/+/856430 | 13:03 |
smachi | Hello ironic | 13:05 |
smachi | TheJulia I have added necessary comments on below path can you please have a look into it | 13:06 |
smachi | https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/848709 | 13:06 |
mraineri | dtantsur: Yes, you can get log information from a BMC via the LogService resource beneath a Manager resource; however, I don't know if you can reliably find events specific to virtual media connection failures | 13:09 |
mraineri | It might depend on the specific implementation, but I can see some vendors may not want to put those types of events in their logs since it can be very noisy in cases where the user's network is unstable | 13:10 |
dtantsur | hmm, I see. worth experimenting with, I guess. | 13:16 |
dtantsur | thanks! | 13:17 |
mraineri | You're welcome! | 13:17 |
opendevreview | Merged openstack/ironic-lib master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/ironic-lib/+/856414 | 13:20 |
opendevreview | Merged openstack/python-ironicclient master: Update master for stable/zed https://review.opendev.org/c/openstack/python-ironicclient/+/856425 | 13:20 |
TheJulia | GOOD MORNING | 13:32 |
opendevreview | Merged openstack/python-ironicclient master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-ironicclient/+/856426 | 13:36 |
opendevreview | Merged openstack/python-ironicclient stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/python-ironicclient/+/856423 | 13:36 |
opendevreview | Merged openstack/python-ironicclient stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/python-ironicclient/+/856424 | 13:36 |
TheJulia | ugh, tired and air quality is kind of not great due to a big fire near by | 13:42 |
TheJulia | I'm not terribly a fan of just blocking out and ignoring SQLAlchemy warnings until later :( | 13:54 |
opendevreview | Stephen Finucane proposed openstack/ironic-inspector master: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/ironic-inspector/+/856488 | 14:04 |
kamlesh6808c | Hi Julia , Would you please help to second review https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/853621 | 14:39 |
dtantsur | good mornign TheJulia | 15:16 |
dtantsur | the inspector workaround is passing unit tests: https://review.opendev.org/c/openstack/ironic-inspector/+/856488 | 15:16 |
TheJulia | approved | 15:19 |
TheJulia | I'm banging my head against just making it 2.0 compatible... | 15:19 |
TheJulia | making decent progress considering the changes, so far | 15:19 |
JayF | dtantsur++ I'm on board with that, especially if logging mechanisms are more robust in Redfish than ipmi :D | 15:20 |
* JayF has still never laid hands personally on a redfish machine | 15:20 | |
TheJulia | they are kind of nice | 15:21 |
TheJulia | that is as long as you've queried the thing holding the information you need :) | 15:21 |
JayF | yeah from observation it seems like (surprise!) inconsistencies between vendors are the most painful part? | 15:21 |
dtantsur | by far | 15:23 |
dtantsur | at least we're past things like cipher suite negotiation... | 15:23 |
* JayF remembers backporting a patch about cipher suites in sushy recently | 15:24 | |
dtantsur | mmmmmm? I think we had a discussion about hashing passwords, but it was on the Ironic side | 15:25 |
JayF | https://review.opendev.org/c/openstack/sushy/+/855555 hey look, there it is for stable/train waiting on a review lol | 15:26 |
JayF | > Do not send compression as acceptable encoding | 15:26 |
JayF | morning-brain mixed encoding and encryption | 15:27 |
TheJulia | the sarcasm there is... exceptional. | 15:27 |
JayF | Hey, so I think I'm likely to start streaming some of my upstream work (e.g. on twitch) | 15:27 |
JayF | does anyone have any specific interest? if so I'll take that into consideration when picking a time | 15:28 |
* JayF was going to start by doing bug triage that way | 15:28 | |
* dtantsur feels like some of his work could go to onlyfans.... | 15:28 | |
mallik | JayF: could you please take a look at the ilo patch https://review.opendev.org/c/openstack/ironic/+/853690 | 15:28 |
JayF | it's on my list now, but you'll need more than just me to land it | 15:29 |
mallik | dtantsur: could you please take a look at the ilo patch https://review.opendev.org/c/openstack/ironic/+/853690 | 15:29 |
* TheJulia hopes revised locking code does similar thing as before and prevents the random edge case we've seen sporatically in logs | 15:30 | |
mallik | JayF and dtantsur, I have addressed both of your comments in this patch | 15:30 |
JayF | so > hpe-gen9-dsvm-ironic-standalone-wholedisk-uefi-ilo-virtual-media-direct-python3 | 15:31 |
JayF | is just forever broken? | 15:31 |
mallik | yes | 15:32 |
JayF | Why still run it / leave it voting? | 15:32 |
TheJulia | stevebaker did mention a... sushy/proliantutils incompatability he found the other day, I told him to email Nisha | 15:32 |
TheJulia | \o/ only 6 unit tests fail now | 15:32 |
mallik | the 2 tests failing are due to infra is what our team triaged it and we are going to work on to resolve it. these 2 tests have been failing for sometime and nothing to do with the current patch. I will check with Nisha for the details. | 15:36 |
JayF | If there's an upstream breakage, and you put it in a story/task, you don't have to fix it alone :) | 15:36 |
JayF | I have a vested interest in keeping ilo/proliantutils/sushy all operating happily too :D | 15:36 |
mallik | ok | 15:36 |
* TheJulia is still stumped why do_allocate gets called twice | 15:39 | |
JayF | TheJulia: my entire tomorrow is open, if you wanna toss some time on it to pair on any of this ... I'll spend more time today trying to catch up to you in problem understanding :D | 15:40 |
TheJulia | JayF: ack, I have a blood draw in the morning... down the mountain | 15:40 |
TheJulia | so I'll be back around noon I think | 15:40 |
* JayF has to knock out the last story he owes Armada project today | 15:40 | |
JayF | Work in github actions for a while if you want to love zuul more :D | 15:41 |
TheJulia | heh | 15:41 |
TheJulia | That is... I have a blood draw down the mountain if we don't get an order to evacuate | 15:41 |
JayF | get that big bus fueled up and rarin' to go | 15:42 |
TheJulia | wheeeeeee: https://www.google.com/maps/d/u/1/viewer?mid=1JNa6NxSir7mKFQA3h_vMfflv31gS5Gs&ll=33.619314211393586%2C-116.80587582714843&z=11 | 15:42 |
TheJulia | I think we've got a half tank of diesel, way more than enough to get me down the hill into town | 15:43 |
JayF | y'all stay safe. Leave earlier than ordered if you must | 15:43 |
JayF | that's way more imporatant than sqlalchemy lol | 15:43 |
JayF | select * from location where condition != 'burny'; | 15:44 |
TheJulia | lol | 15:44 |
TheJulia | the locals say we're in a super safe spot anyway | 15:44 |
TheJulia | but yeah | 15:44 |
*** dviroel is now known as dviroel_ | 15:46 | |
TheJulia | All, with regards to the pending election, you need to be activated to receive emails from CIVS. | 16:03 |
TheJulia | Please see: https://lists.openstack.org/pipermail/openstack-discuss/2022-September/030405.html | 16:03 |
TheJulia | polling starts *monday* | 16:03 |
dtantsur | mmm, inconvenient.. I wonder how many people will miss the message | 16:06 |
TheJulia | who knows | 16:06 |
TheJulia | It has been a think for a while | 16:06 |
dtantsur | you're probably right, my email is already activated :) | 16:07 |
TheJulia | Okay, fixed my underlying issue... but still weirdness with some duplicate method calls | 16:09 |
JayF | How many ATCs in OpenStack don't follow the list | 16:11 |
JayF | that's wildly unfortunate :( | 16:11 |
TheJulia | Unfortunately CIVS got flagged for spamming a while back | 16:12 |
JayF | I figured, it's not ideal but it's not anyones' fault either | 16:16 |
opendevreview | Merged openstack/ironic-inspector master: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/ironic-inspector/+/856488 | 16:34 |
TheJulia | just a constraint of the times I guess | 16:45 |
dtantsur | lemme guess: the oslo.db patches should be backported to all bugfix branches in Zed? | 16:45 |
TheJulia | dtantsur: likely yes | 16:46 |
opendevreview | Dmitry Tantsur proposed openstack/ironic-inspector bugfix/11.0: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/ironic-inspector/+/856505 | 16:46 |
TheJulia | I *susupect* fixes for 2.0 won't be ready until after we cut Zed, but I don't think anything in it will be backwards incompatible | 16:46 |
opendevreview | Dmitry Tantsur proposed openstack/ironic-inspector bugfix/10.9: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/ironic-inspector/+/856506 | 16:46 |
dtantsur | yeah, I'm mostly worried about upper-constraints in the Zed branches | 16:46 |
TheJulia | likewise, if it has 2 somehow, then I'm going to cry lots | 16:46 |
dtantsur | I **hope** not | 16:47 |
TheJulia | but... this is just more time and a few weird methods which somehow get called twice... apparently deep inside taskmanager | 16:47 |
opendevreview | Dmitry Tantsur proposed openstack/ironic bugfix/21.0: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/ironic/+/856507 | 16:47 |
opendevreview | Dmitry Tantsur proposed openstack/ironic bugfix/20.2: Fix compatibility with oslo.db 12.1.0 https://review.opendev.org/c/openstack/ironic/+/856508 | 16:47 |
JayF | dtantsur: +2, I trust the V+1 to validate that change | 16:52 |
JayF | thanks | 16:52 |
JayF | same for inspector fixes | 16:53 |
TheJulia | okay.... I understand what the unit tests are seeing with autocommit off | 16:54 |
TheJulia | why is the huge, giant, unknown question | 16:54 |
dtantsur | :D | 16:54 |
* TheJulia has resorted to adding numerous print statements | 16:55 | |
dtantsur | I'm growing more and more understanding towards people who don't like ORMs :) | 16:55 |
TheJulia | heh | 16:55 |
dtantsur | the ironic-inspector-client CI is long broken, isn't it? | 16:56 |
TheJulia | uhh... It feels like it has broken every cycle with a minor thing | 16:58 |
iurygregory | dtantsur, not really | 16:59 |
iurygregory | https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/855110 | 16:59 |
iurygregory | it was working before we did the release | 16:59 |
dtantsur | huuuh | 16:59 |
iurygregory | :D | 16:59 |
dtantsur | then why does the functional job fail now | 16:59 |
dtantsur | mistery... | 16:59 |
iurygregory | *magic* | 17:00 |
iurygregory | wondering if is because we are still fixing the oslo.db problem... | 17:00 |
dtantsur | possibly | 17:00 |
dtantsur | sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) database is locked | 17:03 |
dtantsur | W | 17:04 |
dtantsur | T | 17:04 |
dtantsur | F | 17:04 |
dtantsur | Let's hope it's the oslo.db thing indeed | 17:04 |
iurygregory | Everyone, for TC and PTL elections since civs is used there is an action required to be able to vote https://lists.openstack.org/pipermail/openstack-discuss/2022-September/030405.html | 17:04 |
JayF | Julia posted that earlier too, we should probably try to get it in chat in most of the timezones | 17:05 |
JayF | I'll post something in here before my EOD | 17:05 |
dtantsur | An interesting fact: the antelope unit test set has py3.10 voting. I think it was non-voting in zed? | 17:05 |
iurygregory | dtantsur, correct... | 17:05 |
iurygregory | and it was using the new ubuntu if I recall | 17:06 |
iurygregory | or maybe it was just an attempt at that time | 17:06 |
* dtantsur is curious how rpittau's work on supporting jammy in bifrost is doing | 17:08 | |
opendevreview | Merged openstack/python-ironicclient master: remove unicode from code https://review.opendev.org/c/openstack/python-ironicclient/+/854477 | 17:08 |
dtantsur | anyone willing to try revive https://review.opendev.org/c/openstack/bifrost/+/848828/ before Riccardo comes back? | 17:08 |
JayF | dtantsur: I'll add it to my list, no promises, but I might be able to find some time tomorrow | 17:09 |
JayF | depends on how much progress I make on this final armada thing before I go full stacker again :D | 17:09 |
iurygregory | dtantsur, I can check now | 17:09 |
iurygregory | or attempt to make it work :D | 17:09 |
dtantsur | thx! I've issues a recheck to get the logs again | 17:09 |
JayF | btw since you all are here, if you ever need to ask for help with something async outside of IRC, feel free to add it to the incoming section here https://etherpad.opendev.org/p/JayFTODO | 17:10 |
opendevreview | Merged openstack/python-ironic-inspector-client master: Update master for stable/zed https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/856421 | 17:10 |
iurygregory | JayF, ack | 17:10 |
iurygregory | dtantsur, ok, I will keep an eye on it (I'm checking why bifrost and IPE are broken :D) | 17:11 |
opendevreview | Merged openstack/metalsmith master: Update master for stable/zed https://review.opendev.org/c/openstack/metalsmith/+/856417 | 17:13 |
dtantsur | once https://review.opendev.org/c/openstack/sushy-tools/+/844126/ merges, could someone please request a sushy-tools release? | 17:13 |
dtantsur | I got a request downstream to get it out (for another patch) | 17:13 |
opendevreview | Nisha Agarwal proposed openstack/ironic master: Adds create_csr and add_https_certificate clean step https://review.opendev.org/c/openstack/ironic/+/804486 | 17:16 |
iurygregory | dtantsur, I'm working on releases today, I can push a patch | 17:16 |
dtantsur | ++ | 17:17 |
opendevreview | Nisha Agarwal proposed openstack/ironic master: Adds create_csr and add_https_certificate clean step https://review.opendev.org/c/openstack/ironic/+/804486 | 17:22 |
dtantsur | see you tomorrow folks o/ | 17:24 |
opendevreview | Merged openstack/sushy-tools master: Add Chassis to ServiceRoot https://review.opendev.org/c/openstack/sushy-tools/+/844126 | 17:42 |
iurygregory | sushy-tools release https://review.opendev.org/c/openstack/releases/+/856554 | 17:49 |
opendevreview | Merged openstack/metalsmith master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/metalsmith/+/856418 | 18:37 |
opendevreview | Merged openstack/metalsmith stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/metalsmith/+/856415 | 18:37 |
opendevreview | Merged openstack/metalsmith stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/metalsmith/+/856416 | 18:37 |
opendevreview | Merged openstack/ironic-python-agent stable/yoga: Fix software raid output poisoning https://review.opendev.org/c/openstack/ironic-python-agent/+/854805 | 18:42 |
TheJulia | oh where oh where did I put my braiiiinnnns | 18:43 |
TheJulia | https://docs.sqlalchemy.org/en/14/dialects/sqlite.html#transaction-isolation-level-autocommit <--- screaming intensifies.... lots | 21:10 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Fix SQLAlchemy 2.0 Compatability https://review.opendev.org/c/openstack/ironic/+/856336 | 21:26 |
TheJulia | JayF: stevebaker[m]: I think I've got locking licked. And I think I now understand why some of the other behavior | 21:27 |
TheJulia | dtantsur: ^^^ | 21:27 |
TheJulia | at least, when autocommit is turned off | 21:27 |
JayF | what was the 'eureka' moment of it? | 21:27 |
TheJulia | reading about sqlite driver behavior and meshing that knowledge with autocommit behavior in sqlalchemy | 21:27 |
TheJulia | basically the take away is: sqlite consistency in unit testing basically kind of relies upon autocommit. Turn off autocommit... and well.. yeah :\ | 21:29 |
JayF | OH UNIT TESTS USE SQLITE | 21:30 |
JayF | holy cow, we trust that to mimic mysql behavior!? | 21:31 |
TheJulia | also transactional behavior is turned off with the default.... | 21:31 |
* JayF just lost a lot of confidence in our tests | 21:31 | |
TheJulia | well, some tests do, but yeah. The *real* test is going to be seeing what happens with that change in CI and then adjusting from there | 21:31 |
JayF | yeah, tempest is still real lol | 21:32 |
TheJulia | yup | 21:32 |
TheJulia | so anyway, I feel a bit more sane now | 21:32 |
TheJulia | ... or insane | 21:32 |
JayF | the unit test issues you were seeing make a lot more sense now | 21:32 |
JayF | the previous job, where we were wranging sqlalchemy: almost all of it was targetting sqlite | 21:32 |
TheJulia | I'm really not sure, but I think I need to go to the market | 21:32 |
JayF | and I suspect these are on the same razors edge of pain | 21:32 |
TheJulia | yeah, likely | 21:32 |
JayF | congrats on finding it \o/ | 21:33 |
TheJulia | I was finally like "why does it not have the value I suspect, and why does it seem to have the old value other times... WUT?!" | 21:33 |
TheJulia | and that led me to the docs | 21:33 |
TheJulia | and then it clicked, and yeah. | 21:33 |
TheJulia | what does one eat for a weekend when a small hurricane is coming up one side of a coast, and fire on the other side of the road?! | 21:35 |
JayF | drive thru on the way outta there | 21:39 |
TheJulia | I think we're going to stay put, it is just a huge headache to head down the mountain | 21:40 |
TheJulia | and we're in a nice safe cove it seems | 21:40 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!