opendevreview | Jacob Anders proposed openstack/sushy master: [WIP] Improve resiliency of eTag handling https://review.opendev.org/c/openstack/sushy/+/856123 | 00:00 |
---|---|---|
opendevreview | KOBAYASHI DAISUKE proposed openstack/ironic stable/xena: Check Fujitsu backport CI https://review.opendev.org/c/openstack/ironic/+/857309 | 08:10 |
opendevreview | Merged openstack/tenks master: Use Yoga branch of Kayobe for gating CI job https://review.opendev.org/c/openstack/tenks/+/857273 | 08:41 |
opendevreview | Ghanshyam proposed openstack/python-ironic-inspector-client master: Switch to 2023.1 Python3 unit tests and generic template name https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/856422 | 09:14 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix idrac-redfish RAID controller mode conversion https://review.opendev.org/c/openstack/ironic/+/855872 | 09:20 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Update sushy-oem-idrac version https://review.opendev.org/c/openstack/ironic/+/857597 | 09:20 |
opendevreview | Verification of a change to openstack/tenks master failed: Follow ups to venv https://review.opendev.org/c/openstack/tenks/+/857008 | 11:08 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use Yoga branch of Kayobe for gating CI job (p2) https://review.opendev.org/c/openstack/tenks/+/857648 | 11:40 |
iurygregory | good morning Ironic | 11:44 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Update sushy-oem-idrac version https://review.opendev.org/c/openstack/ironic/+/857597 | 12:17 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix idrac-redfish RAID controller mode conversion https://review.opendev.org/c/openstack/ironic/+/855872 | 12:27 |
opendevreview | Ebbex proposed openstack/bifrost master: Use a more traditional ansible approach to include_vars https://review.opendev.org/c/openstack/bifrost/+/855806 | 12:44 |
opendevreview | Ebbex proposed openstack/bifrost master: Refactor use of include_vars https://review.opendev.org/c/openstack/bifrost/+/855807 | 12:44 |
TheJulia | good morning | 12:53 |
arne_wiebalck | Good morning, Ironic! | 13:04 |
TheJulia | JayF: replied to some of your questions on the sqlalchemy phase 1 patch. btw... 1535.6 nodes/second is what it came back with, which is better than I would expect (in ci)... on a rax VM. 2145.9 on a previous job but that machine was paravirt so we can't really compare the runs. | 13:26 |
TheJulia | need to run them on the same machine at some point | 13:29 |
JayF | TheJulia: if you tell me how to run them, I can probably find time to do that test today | 13:34 |
TheJulia | we've got two dirty awful scripts under tools/benchmark, one to create mock db records in mysql with some consistency of chaos (indexing chaos that is, intentionally because index/cache poisoning is a thing...). We run them as part of a bifrost job against ironic since it needs a working ironic codebase/config, and it exercises api/object models for nodes which helped us improve performance last year. | 13:40 |
TheJulia | JayF: ^ | 13:40 |
TheJulia | code welcome there, btw | 13:40 |
TheJulia | The query counts are explicitly the same query structure nova asks for when doing the sync with ironic, just as an fyi | 13:40 |
JayF | All right. I have some ideas that might involve automating that... | 13:41 |
TheJulia | we do have it on a zuul job now, but again, we don't save the numbers aside from an etherpad when we need to do stuff like this | 13:43 |
JayF | Yeah I was talking about something more for my personal use where I could point it at 2 equivalent VMs or similar | 13:45 |
TheJulia | https://etherpad.opendev.org/p/ironic-performance | 13:45 |
TheJulia | old historical numbers ^ | 13:45 |
JayF | Bluntly, I don't trust the worker nodes that zuul uses to be sufficiently similar for this purpose | 13:45 |
TheJulia | ... we lost the link to that etherpad someplace :( | 13:45 |
TheJulia | oh, god, don't trust htem at all | 13:45 |
TheJulia | the performance is highly variable | 13:45 |
JayF | So I'll probably try to set up something that like is push button receive numbers from a more stable platform | 13:46 |
TheJulia | hmm... that etherpad feels truncated :( | 13:46 |
TheJulia | sounds good, I was just running the latter script locally on my desktop | 13:46 |
TheJulia | and yes, streaming netflix versus amazon video was also measurable on the results :) | 13:47 |
TheJulia | Anyway, email() | 13:47 |
smachi | Hi Julia | 13:58 |
smachi | if there are no further changes required with the patch https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/848709 | 13:59 |
smachi | can you please vote against it so it can get merged | 14:02 |
TheJulia | *sigh* | 14:20 |
opendevreview | Merged openstack/tenks master: Use Yoga branch of Kayobe for gating CI job (p2) https://review.opendev.org/c/openstack/tenks/+/857648 | 14:21 |
rloo | yeah. i thought about voting cuz i wasn't sure who the redhat folks would vote for. | 14:22 |
TheJulia | ptl election? | 14:22 |
rloo | yeah. i messed up with the cordocet whatever thingy. i think. no worries. | 14:23 |
TheJulia | I wouldn't guess on others, just vote the way you feel | 14:23 |
TheJulia | everyone! VOTE! | 14:23 |
opendevreview | Merged openstack/networking-baremetal master: Update master for stable/zed https://review.opendev.org/c/openstack/networking-baremetal/+/857313 | 14:29 |
opendevreview | Merged openstack/ironic-prometheus-exporter master: Update master for stable/zed https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/857318 | 14:29 |
opendevreview | Merged openstack/ironic-prometheus-exporter master: Switch to 2023.1 Python3 unit tests and generic template name https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/857319 | 15:10 |
JayF | https://review.opendev.org/c/openstack/ironic/+/857238 should be safe to review/merge, and needs to get in before zed is cut | 15:43 |
opendevreview | Kaifeng Wang proposed openstack/ironic master: Fix nodes stuck at cleaning when Network Service is unavailable https://review.opendev.org/c/openstack/ironic/+/857615 | 15:56 |
opendevreview | Kaifeng Wang proposed openstack/ironic master: Fix nodes stuck at cleaning on Network Service issues https://review.opendev.org/c/openstack/ironic/+/857615 | 15:59 |
opendevreview | Merged openstack/ironic master: Zed Ironic requires Sushy >4 https://review.opendev.org/c/openstack/ironic/+/857238 | 17:12 |
iurygregory | kaifeng =O | 19:03 |
TheJulia | it is a good find, just needs a release note I think | 19:05 |
JayF | Got a couple of stable patches that still need love: https://review.opendev.org/c/openstack/ironic/+/856191 https://review.opendev.org/c/openstack/ironic-python-agent/+/857064 | 20:32 |
JayF | clean backports, both passing tests | 20:32 |
JayF | We should also probably get this reviewed before zed is cut -> https://review.opendev.org/c/openstack/ironic-python-agent/+/852999/ | 21:30 |
JayF | (I have +2 on it now, needs one more -- but it's a beefy thing to review, as IPA stuff goes) | 21:31 |
JayF | and https://review.opendev.org/c/openstack/ironic/+/849587 has been waiting almost a week | 21:37 |
opendevreview | Jay Faulkner proposed openstack/ironic bugfix/20.2: Redfish: Consider password part of the session cache https://review.opendev.org/c/openstack/ironic/+/857771 | 21:40 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/xena: Fix software raid output poisoning https://review.opendev.org/c/openstack/ironic-python-agent/+/857772 | 21:57 |
opendevreview | Merged openstack/ironic master: Update sushy-oem-idrac version https://review.opendev.org/c/openstack/ironic/+/857597 | 22:11 |
opendevreview | Verification of a change to openstack/ironic bugfix/21.0 failed: Redfish: Consider password part of the session cache https://review.opendev.org/c/openstack/ironic/+/856191 | 22:11 |
iurygregory | will check the backports after my dinner =) | 22:29 |
JayF | I think Julia kicked a couple of them | 22:30 |
JayF | really the stuff that matters more now is the stuff with ironic-week-prio going into master | 22:30 |
JayF | so we can make sure it lands or people have a chance to round trip on feedback w/o missing zed | 22:30 |
opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Fix software raid output poisoning https://review.opendev.org/c/openstack/ironic-python-agent/+/857064 | 22:50 |
JayF | I'll need to re-run this a few times to gain confidence, but I did some testing (summarized badly here https://etherpad.opendev.org/p/ironic-sqlalchemy20-benchmarks)... | 22:51 |
JayF | basic results are current master: Took 12.000738382339478 seconds to return all 10000 nodes via nodes API call pattern. | 22:51 |
JayF | current master + Julia's phase 1 patch cherry-picked: Took 12.051380634307861 seconds to return all 10000 nodes via nodes API call pattern. | 22:51 |
JayF | I'm going to call this probably well within the margin of error | 22:52 |
JayF | TheJulia: ^ tl;dr performance is roughly equal in my basic testing; I can do something more controlled if you want, but I'm relatively convinced there's no significant perf impact in either direction | 22:52 |
opendevreview | Merged openstack/ironic-python-agent master: SoftwareRAID: Enable skipping RAIDS https://review.opendev.org/c/openstack/ironic-python-agent/+/852999 | 23:21 |
TheJulia | I wonder what it would be for 100k rows | 23:26 |
TheJulia | Granted, takes a ton of time to insert and modify that many…. | 23:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!