vanou | good morning ironic | 01:29 |
---|---|---|
arne_wiebalck | Good morning vanou and Ironic! | 06:33 |
rpittau | good morning ironic! o/ | 06:53 |
opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/8.6: [DNM] TEST CI https://review.opendev.org/c/openstack/ironic-python-agent/+/859782 | 07:29 |
janders | hey vanou arne_wiebalck rpittau and Ironic o/ | 08:12 |
arne_wiebalck | hey janders o/ | 08:13 |
rpittau | hey janders :) | 08:15 |
vanou | hi arne_wiebalck rpittau janders o/ | 08:34 |
kubajj | Good morning vanou arne_wiebalck rpittau janders and Ironic! | 08:36 |
vanou | good morning kubajj | 08:36 |
arne_wiebalck | hey kubajj o/ | 08:37 |
rpittau | hey vanou kubajj :) | 08:37 |
opendevreview | Jakob Meng proposed openstack/bifrost master: Explicitly fetch baremetal ports and use id on openstacksdk>=0.99.0 https://review.opendev.org/c/openstack/bifrost/+/859430 | 09:54 |
opendevreview | Jakob Meng proposed openstack/bifrost master: Explicitly fetch baremetal ports and use id on openstacksdk>=0.99.0 https://review.opendev.org/c/openstack/bifrost/+/859430 | 09:58 |
opendevreview | SONG SHUKUN proposed openstack/ironic master: Add support auth protocols for iRMC https://review.opendev.org/c/openstack/ironic/+/857035 | 11:15 |
Nisha_Agarwal | hey rpittau | 11:56 |
Nisha_Agarwal | TheJulia, hi | 11:57 |
Nisha_Agarwal | TheJulia, i updated the anaconda fix patch with test case | 11:57 |
rpittau | hey Nisha_Agarwal :) | 12:11 |
vanou | I proposed one backport patch against stable/xena (https://review.opendev.org/c/openstack/ironic/+/859502), it's helpful if someone review this. thx. | 12:21 |
Nisha_Agarwal | rpittau, there is a patch which i raised for anaconda deployment to work....i dont know if it would be possible to land it in zed if there are no comments after review.....https://review.opendev.org/c/openstack/ironic/+/859397 | 12:29 |
rpittau | Nisha_Agarwal: it's probably worth a release note | 12:31 |
opendevreview | Nisha Agarwal proposed openstack/ironic master: Fix the anaconda deploy for the ISO mounted https://review.opendev.org/c/openstack/ironic/+/859397 | 12:40 |
Nisha_Agarwal | rpittau, ^^^ | 12:40 |
Nisha_Agarwal | i have updated the patch with release notes. | 12:40 |
rpittau | Nisha_Agarwal: reviewed and I think it's backportable | 12:45 |
TheJulia | good morning | 13:14 |
rpittau | good morning TheJulia :) | 13:36 |
JayF | iurygregory: https://review.opendev.org/c/openstack/ironic/+/836966 (and generally grenade skip-release-testing) came up in TC meeting. You wanna take this over the finish line, or do you need me to take it over? | 15:13 |
JayF | I am about to send this to the ML as well, it's my intention to EOL any Ironic projects' branches, anything older than stable/train, since we don't seem to be porting anything that far back anyway. | 15:29 |
JayF | If you object or want to volunteer to maintain stein or older; lmk :) | 15:29 |
TheJulia | sounds good to me and would be inline with prior lazy conesenses | 15:30 |
JayF | Yeah I'll hit the ML for extra warning | 15:30 |
TheJulia | sgtm | 15:30 |
JayF | not that it's needed so much as I'm unlikely to do it this calendar week; so no reason to rush and not notify :) | 15:30 |
JayF | as part of that, I also wanna cut releases of all our stable branches that are not-em and our bugfix branches | 15:30 |
JayF | if we're going to be backporting stuff, might as well ensure those fixes are there for all users, not just those consuming git | 15:31 |
TheJulia | we will be blocked from releasing some of the older ones | 15:32 |
TheJulia | EM branches specifically will be blocked from releases | 15:32 |
* TheJulia hands JayF a table to flip | 15:33 | |
JayF | yeah, that's why I said not-em releases | 15:33 |
TheJulia | oh, sorry, didn't see that | 15:33 |
* TheJulia should be wearing glasses | 15:35 | |
JayF | I should be wearing a bubble. 2x sick in a month is pretty bad luck. | 15:37 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: WIP: Use declarative reader/writer separation https://review.opendev.org/c/openstack/ironic-inspector/+/463768 | 15:41 |
TheJulia | ugh :( | 15:41 |
TheJulia | not good, hopefully you feel better quickly | 15:41 |
TheJulia | I woke up with a migraine today, not exactly a good day as a result | 15:41 |
TheJulia | but, progress! | 15:41 |
JayF | Eh, I think I hit the bottom at some point yesterday. At this point, just a mild sore throat and my voice is threatening to leave me if I overuse it | 15:43 |
rpittau | see ya o/ | 15:51 |
JayF | o/ | 15:51 |
Nisha_Agarwal | rpittau, thanks :) | 16:15 |
Nisha_Agarwal | TheJulia, Please have a look at anaconda fix patch...i have added test case also and added more details in the bug also for the reason why that change is erquired | 16:16 |
Nisha_Agarwal | required* | 16:16 |
JayF | I'll take a look as well :) | 16:19 |
* JayF imagines julia's plate is overflowing | 16:19 | |
Nisha_Agarwal | JayF, Thanks | 16:21 |
Nisha_Agarwal | :) | 16:21 |
iurygregory | JayF, sorry was having lunch | 16:29 |
JayF | iurygregory: IRC is always asynchronous to me; I know you'll respond when you see it :) | 16:29 |
iurygregory | so the patch is ready for review | 16:30 |
JayF | I saw the comments still up there and were unsure if they were still valid | 16:30 |
JayF | if they aren't, I'll happily give it a fresh review | 16:30 |
iurygregory | yeah, I added a not with the explanation why the variable was required | 16:31 |
JayF | ack; that's what I thought but wanted to check | 16:31 |
JayF | I really try to avoid +2'ing patches that have open, unresolved comments | 16:32 |
iurygregory | no worries, we can also bring the patch to open discussion next week if necessary | 16:33 |
JayF | I gotta be honest, this is the most excited I've been for an openstack-wide goal | 16:33 |
JayF | this is gonna be a huge boon for people running openstack in production | 16:33 |
iurygregory | oh, master now is antelope, so maybe we should update to test yoga -> antelope right? | 16:34 |
JayF | absolutely | 16:35 |
iurygregory | will update the patch to see how it goes | 16:35 |
JayF | ack | 16:35 |
JayF | we should be testing y->[master] when antelope is master | 16:35 |
iurygregory | yeah | 16:35 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Add ironic-grenade-skip-level Job https://review.opendev.org/c/openstack/ironic/+/836966 | 16:43 |
Nisha_Agarwal | I see this error during anaconda deploy many times | 17:32 |
Nisha_Agarwal | ERROR ironic.conductor.utils [None req-57f6cba4-8aba-4722-a08e-387d19112dc9 None None] Node 6f444569-7385-4be2-9d88-e2f0b761987c failed deploy step {'step': 'deploy', 'priority': 100, 'argsinfo': None, 'interface': 'deploy'}: Validation of image href failed, reason: Scheme-less image href is not a UUID.: ironic.common.exception.ImageRefValidationFailed: Validation of image href failed, reason: Scheme-less image href is | 17:32 |
Nisha_Agarwal | not a UUID. | 17:32 |
Nisha_Agarwal | This error comes as the instance_image_info has one empty value .... | 17:33 |
Nisha_Agarwal | (Pdb) instance_image_info | 17:33 |
Nisha_Agarwal | {'kernel': ('http://172.17.1.37:8010/Stream9/images/pxeboot/vmlinuz', '/opt/stack/devstack/files/6f444569-7385-4be2-9d88-e2f0b761987c/kernel'), 'ramdisk': ('http://172.17.1.37:8010/Stream9/images/pxeboot/initrd.img', '/opt/stack/devstack/files/6f444569-7385-4be2-9d88-e2f0b761987c/ramdisk'), 'ks_template': ('http://172.17.1.37:8010/ks.cfg.template', '/opt/stack/devstack/files/6f444569-7385-4be2-9d88-e2f0b761987c/ks.cfg.templa | 17:33 |
Nisha_Agarwal | te'), 'ks_cfg': ('', '/opt/stack/devstack/files/6f444569-7385-4be2-9d88-e2f0b761987c/ks.cfg')} | 17:33 |
JayF | Next time if you use a pastebin, something like gist.github.com, and just paste the link in it'll be a lot more readable | 17:33 |
JayF | actually, if you can do that now I'd appreciate it, so I don't have to figure out what wrapping is intentional vs my irc client | 17:33 |
Nisha_Agarwal | :) | 17:34 |
Nisha_Agarwal | JayF, https://paste.openstack.org/show/blonFAKrbcN9ZdHodOvK/ | 17:37 |
JayF | I've looked and don't know the answer right off the top of my head; I'll circle back and take a look this afternoon my-time as long as I get deeper into my todo list. Probably a few hours even if I do get to it :/ | 17:38 |
Nisha_Agarwal | np | 17:42 |
opendevreview | Jakob Meng proposed openstack/bifrost master: [DNM] Explicitly fetch baremetal ports and use id on openstacksdk>=0.99.0 https://review.opendev.org/c/openstack/bifrost/+/859430 | 17:43 |
Nisha_Agarwal | JayF, i will raise the fix for the patch | 17:56 |
Nisha_Agarwal | for the issue above | 17:56 |
Nisha_Agarwal | found the reason | 17:56 |
JayF | What was it? | 17:56 |
JayF | Just to make me a bit smarter too :D | 17:56 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: WIP: Use declarative reader/writer separation https://review.opendev.org/c/openstack/ironic-inspector/+/463768 | 18:02 |
TheJulia | cbouchar: you might want to review the patches Nisha is posting w/r/t anaconda | 18:03 |
TheJulia | anyone happen to have a local running devstack in a working shape? | 18:14 |
JayF | TheJulia: what do you need? i have a VM I setup a few days back, but would have to power it on and tbh I never used it for anything yet | 18:16 |
* JayF also has a pretty full plate today | 18:16 | |
TheJulia | doesnt' need to be today at all | 18:18 |
* TheJulia should just build/update a new dev machine | 18:19 | |
TheJulia | dtantsur: so, we need to chat w/r/t allocations, with the varchar length of 255 chars... and utf8mb4 encoding... on innodb. | 18:53 |
TheJulia | dtantsur: for the name field specifically | 18:53 |
JayF | TheJulia: is it time to add the poop-emoji unit test? | 18:54 |
JayF | TheJulia: (poop emoji is the most memorable canary for utf8mb4, as it's a 4 byte character) | 18:54 |
TheJulia | JayF: well, the default encoding is shifting to 4 byte chars... which means 255 varchars exceeds the field max size of 767 bytes for varchar | 18:55 |
JayF | oh, I see | 18:55 |
TheJulia | yah, I think we either need to discuss truncating, or changing it to a text field | 18:56 |
TheJulia | luckily, a small table, so it shouldn't be a big a huge deal as long as it is indexed | 18:57 |
TheJulia | not indexed | 18:57 |
* TheJulia wonders if it can be queried by name | 18:57 | |
TheJulia | ugh, yeah, we allow it name or uuid matching | 19:00 |
TheJulia | maybe a longer discussion :\ | 19:14 |
TheJulia | so nodes.name is 63 chars | 19:57 |
TheJulia | Do we have any feeling on truncating down allocation's names? | 19:57 |
TheJulia | or converting it to a text field? | 19:57 |
JayF | Where do they come from? | 19:57 |
TheJulia | names are human supplied names | 19:57 |
JayF | truncation is very, very bad for a lot of cases and can lead to duplicates | 19:57 |
TheJulia | very true | 19:57 |
JayF | so I think we should take positive action to prevent truncation, either via error or by hashing the full name or something else | 19:58 |
JayF | literally anything but putting a truncated human-provided name in the db | 19:58 |
TheJulia | it almost seems like our only option is to go to text instead of varchar | 19:58 |
TheJulia | well, the user can query by name of allocation too :( | 19:58 |
TheJulia | insert sadness here | 19:58 |
TheJulia | so truncation just doesn't seem viable at all | 19:58 |
TheJulia | direct query text field means an index will be needed, albeit not awful rally | 19:59 |
TheJulia | but we'll need to pre-flight it and all | 19:59 |
TheJulia | but we have tools for that | 19:59 |
*** lifeless_ is now known as lifeless | 20:14 | |
*** tosky_ is now known as tosky | 21:24 | |
JayF | TheJulia: Iury[not here]: If one of you could give me 15 minutes tomorrow to go over my Ironic Zed summary slides, it'd be great. | 23:35 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!