Friday, 2022-10-07

TheJuliaJayF: yeah, basically needed to get it to a more consistent/cleaner format to start with and the age old patch I've been resurrecting has about 60% of the nuts and bolts pre-assembled00:02
TheJuliato at least, get started00:02
opendevreviewVerification of a change to openstack/ironic-python-agent bugfix/9.0 failed: Pin bgufix 9.0 ci jobs to zed  https://review.opendev.org/c/openstack/ironic-python-agent/+/85925500:35
vanougood morning ironic00:50
*** rcastillo|ruck is now known as rcastillo03:47
adam-rozmanGood morning Ironic !07:57
arne_wiebalckGood morning, Ironic!08:31
opendevreviewNisha Agarwal proposed openstack/ironic master: Fixes anaconda deploy for PXE boot  https://review.opendev.org/c/openstack/ironic/+/86005509:09
jm1dtantsur: hello :) what do we do about this? https://review.opendev.org/c/openstack/bifrost/+/859430/09:12
dtantsurjm1: left a couple of comments, thanks for the reminder10:42
adam-rozmandtantsur,iurygregory: Hi, if you have some free time please check https://review.opendev.org/c/openstack/ironic-python-agent/+/855866 I had +2 twice already so I think it is in good shape.10:44
dtantsuradam-rozman: sorry, a couple more comments10:47
dtantsuradam-rozman: JFYI this is how the final release notes look like: https://docs.openstack.org/releasenotes/ironic/zed.html10:48
adam-rozmandtantsur: thanks for the review, I will adjust the notes and the code10:49
iurygregorygood morning Ironic11:10
iurygregoryadam-rozman, sure I will take a look11:10
opendevreviewJakob Meng proposed openstack/bifrost master: Explicitly fetch baremetal ports and use id on openstacksdk>=0.99.0  https://review.opendev.org/c/openstack/bifrost/+/85943011:21
jm1dtantsur: thank you, very good comments, implemented them :)11:23
opendevreviewVerification of a change to openstack/ironic master failed: Add ironic-grenade-skip-level Job  https://review.opendev.org/c/openstack/ironic/+/83696611:42
iurygregoryTo utilize this module, the installed version of the openstacksdk library MUST be <=0.98.999.11:43
iurygregoryinteresting 11:44
adam-rozmaniurygregory: thanks!11:54
adam-rozmandtantsur: I have fixed 3 out of the 4 comments on my local branch but I have replyed to the first comment because I have question/suggestion related to that 11:56
adam-rozmandtantsur: nevermind I have answered my question12:01
opendevreviewKirill proposed openstack/python-ironicclient master: add support of new graphical console interface  https://review.opendev.org/c/openstack/python-ironicclient/+/86068812:48
opendevreviewKirill proposed openstack/ironic master: add vnc console  https://review.opendev.org/c/openstack/ironic/+/86068913:04
TheJuliagood morning13:27
iurygregorygood morning TheJulia 13:38
opendevreviewLukas Piwowarski proposed openstack/ironic master: Remove reference to 'all-plugin' tox environment  https://review.opendev.org/c/openstack/ironic/+/86069713:41
TheJuliadtantsur: any chance I can pose a question which requires a seek to about 6 years ago in memory?13:43
TheJuliadtantsur: nevermind, I went through the original change which added what I was looking at and it was somehow worked in as requirement without reveiwer request between versions, I guess in an attempt to rational handling of db race conditions... as a means to simulate such cases for unit testing which is... not great to add controlling logic :\13:53
dtantsurTheJulia: I can still try flexing my memory, but 6 years ago is a lot of time :)13:53
TheJuliaLooking closely, I'm fairly convinced it is pointless functionality which we don't expose and actually creates issues with ha-ification14:08
* TheJulia wonders why we never noticed this14:08
dtantsuryou're intriguing me :)14:09
TheJuliaversion_id on the db node object in inspector14:10
TheJuliawhich it looks like the code treats in the in-memory cached version_id as authortative over the db14:10
dtantsurokay, this is the part I've never fully understood14:10
TheJuliawhich means you can't bounce across inspector services14:10
dtantsurone of the reasons to merge inspector into ironic is to get rid of this code :D14:10
TheJuliayou'll be reported as race condition errors are occuring even though the in memory cache is... blah14:11
TheJulia++14:11
TheJuliawell, rip out version id now, make it easier to merge in14:11
TheJulia:)14:11
* TheJulia is going to go get breakfast14:11
sschmittQuestion for folks on a migration path for instance network booting. We manage a number of devices in ironic that lack any sort of OOB management and use SNMP for power management. Whats the best way to deploy these now?14:47
vanouJayF: Thanks for making factor out patch! I tried factor out patch for yoga, xena and wallaby on local lab. And they work. I added comment on yoga factor out patch which relates to release note I made on original backport patch. In release note of each https backport patch, it says packaging module is required. So should we modify such release note too? I'm not sure.14:53
dtantsursschmitt: have you seen https://docs.openstack.org/ironic/latest/admin/drivers/snmp.html?14:54
JayFvanou: as I understand it, release notes are to be treated as if they're for master Branch only. So I think it's fine14:54
TheJuliasschmitt: take a look at the ramdisk boot interface. So you can lock your hardware to always network booting. Downside… or positive side depending on how you look at it, it would be ephemeral14:56
TheJuliasschmitt: sorry, ramdisk deploy interface14:56
dtantsurno need for ramdisk boot really, as long as it's UEFI14:56
TheJuliaThat also helps avoid bootloaders trying to install with UEFI overrides14:56
dtantsurwith the netboot fallback even BIOS will work14:56
vanouJayF: Thanks. I understand.14:57
TheJuliaYeah, but they can’t redeploy if UEFI boot loader install smashes the settings14:57
sschmittWell even with that netboot fallback, how would one redeploy?14:57
TheJuliaNobodyCam has mentioned this is an issue14:57
TheJuliaWith UEFI specifically14:57
dtantsuryeah, a one-time efibootmgr call may be needed14:58
* TheJulia sips coffee14:58
TheJuliaI guess, there are a few different ways, but it all depends on overall workflow things need to be within14:58
sschmittyeah unfortunately ephemeral would not work for us here so I'll need to get creative I think14:59
TheJuliasschmitt: are they consistent machines?14:59
dtantsurif you control the instances, a one-time efibootmgr call may be the way15:00
dtantsuryou can even writing an ironic driver that automates it15:00
TheJuliaYeah, before tearing down I guess.15:00
dtantsur* write15:00
sschmittYeah I think that might be the best route15:01
TheJuliaThe restaurant I’m sitting in is like one step away from Disney eurobeats megamax like it plays in Harajuku15:01
TheJuliaErr, megamix15:02
TheJuliaYay autocorrect :(15:02
vanouJayF: Iury says modifying release note of backport patch is reasonable. And he says he will create another patch which only modifies release note to avoid running additional CI.15:04
vanouOn yoga factor out patch at Gerrit15:05
JayFI'm fine with that and I trust Iury to know the right thing to do15:05
dtantsurwe do modify release notes in backports from time to time15:05
TheJuliaWe do, and it does override the master published copy of we do if memory serves. Admittedly, the logic there is a little opaque15:06
vanouJayF: Thanks so much for quick work on factor out. iurygregory: Thanks for comment15:07
vanougood night15:09
TheJuliaGoodnight15:09
iurygregoryvanou, yw15:25
iurygregorygood night15:25
TheJuliasadness is 752 failing unit tests17:03
dtantsurOooo17:03
dtantsurMy sadness is called Init:CrashLoopBackOff17:03
TheJulia:(17:04
dtantsurokay, now another pod is crashing \o/17:07
TheJuliais there a dance video yet?17:07
dtantsurwait, it's running now \o/ but the pod I wanted is not running, soooooo17:09
dtantsurknow what, I better run to the woods17:10
TheJuliaheh17:10
* TheJulia can hear the owls hooting positively at the idea 17:10
dtantsurowls are wise (except for me)17:11
* dtantsur applies a random manifest and hopes for a miracle17:12
iurygregorydtantsur, ++ to run to the woods17:23
dtantsuractually, miracle happened, the pod is running :)17:23
TheJulia\o/17:23
dtantsurbut I'll still run to the woods until Tuesday afternoon, so see you on Wednesday17:23
TheJuliaThat is good, still have 752  failing tests17:23
TheJuliahave a good time in the woods!17:23
dtantsurthank you! I hope you tame these tests asap.17:24
dtantsurnice weekend to y'all17:24
iurygregoryenjoy your time off dtantsur o/17:24
iurygregoryJayF, I'm wondering if we want to consider https://review.opendev.org/c/openstack/ironic/+/860281 for bugfix/21.0 and bugfix/20.2 , thoughts? 17:25
JayFThose branches are locked to Zed requirements. Zed requires the packaging package so I wasn't going to backport it17:52
JayFBluntly, I think you represent the largest constituency a bug fix Branch users so I'm happy to take whatever you think is best on this one though17:53
JayF**of bugfix Branch users17:53
iurygregoryJayF, not really17:53
iurygregory20.2 supports py3617:53
iurygregoryZed requirements if I recall they don't support17:54
JayFIn ci, those branches are traditionally locked to the Zed branch of openstack/requirements17:54
JayFThat's what I was referring to17:54
iurygregoryyeah, now I'm wondering if makes sense for the 20.2... because it supports py36 but zed requirements dropped things for py36 .-.17:55
iurygregoryat least I think they did...17:55
JayFI don't have strong opinions about how these branches are managed other than that whatever decisions we make end up well documented17:58
opendevreviewJulia Kreger proposed openstack/ironic-inspector master: Use declarative reader/writer with enginefacade  https://review.opendev.org/c/openstack/ironic-inspector/+/46376818:01
opendevreviewJulia Kreger proposed openstack/ironic-inspector master: Initial SQLAlchemy 2.0 prep  https://review.opendev.org/c/openstack/ironic-inspector/+/86073118:01
* TheJulia laughs evilly18:01
TheJuliaso mostly got things sorted out in the prior patch, I think with those two, inspector should be good for sqlalchemy 2.018:01
TheJuliasigh, functional fails18:18
JayFiurygregory: I am confused by vanou's previous comment; combined with your and TheJulia's conversation about when/where release notes get modified18:18
JayFDoes someone have an action to backport a release note? Is that person me? 18:18
JayFalso can someone land https://review.opendev.org/c/openstack/ironic/+/86028118:18
JayFwe need to get that in and backported so I can get the stable release train moving again18:19
TheJuliaapproved18:19
JayFthanks 18:20
JayFhttps://review.opendev.org/c/openstack/ironic/+/860141 is next in that chain and passing tests fwiw18:21
TheJuliasomehow we're missing the cherry pick from label18:22
* TheJulia shrugs and pushes buttons18:22
* TheJulia steps away for a few while CI runs18:23
iurygregoryJayF, just in case you wanted the releasenote backported , my thoughts would be to do in another patch =)18:46
JayFI'm honestly confused based on the various comments if we should 1) change the rel note at all and 2) if we do; should we do it in a backport18:46
JayFI honestly have no idea, and I'd rather not pursue the "how exactly do backported relnotes work" rabbithole today18:47
TheJuliaif we're not removing the requirement off of master, we need to backport a reno change to represent the state on those versions18:47
TheJuliaotherwise it applies what is on master branch18:47
opendevreviewJay Faulkner proposed openstack/ironic stable/yoga: Stable only: Correct release note, packaging not required  https://review.opendev.org/c/openstack/ironic/+/86073818:49
JayFso ^ this is what we need18:49
TheJuliayes18:49
opendevreviewJay Faulkner proposed openstack/ironic bugfix/19.0: Stable only: Correct release note, packaging not required  https://review.opendev.org/c/openstack/ironic/+/86074018:50
opendevreviewJay Faulkner proposed openstack/ironic stable/xena: Stable only: Correct release note, packaging not required  https://review.opendev.org/c/openstack/ironic/+/86074118:51
opendevreviewJay Faulkner proposed openstack/ironic bugfix/18.1: Stable only: Correct release note, packaging not required  https://review.opendev.org/c/openstack/ironic/+/86074218:52
TheJuliasigh... 77 tests now fail18:55
opendevreviewJulia Kreger proposed openstack/ironic-inspector master: Use declarative reader/writer with enginefacade  https://review.opendev.org/c/openstack/ironic-inspector/+/46376819:09
opendevreviewJulia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 prep  https://review.opendev.org/c/openstack/ironic-inspector/+/86073119:09
TheJuliaWell, functional at least seemed to work now19:10
* TheJulia goes into town because staring at the computer is not going to work to get results faster19:11
opendevreviewMerged openstack/ironic stable/yoga: Stable only: Factor out addition of packaging lib  https://review.opendev.org/c/openstack/ironic/+/86028119:33
JayFhttps://review.opendev.org/c/openstack/ironic/+/860738 if we can get this merged, yoga will be ready for release 19:59
opendevreviewMerged openstack/ironic bugfix/19.0: Stable only: Factor out addition of packaging lib  https://review.opendev.org/c/openstack/ironic/+/86014120:01
opendevreviewVerification of a change to openstack/ironic stable/yoga failed: Add SNMPv3 authentication functionality  https://review.opendev.org/c/openstack/ironic/+/85055320:01
JayFI'm stepping out early; it's a nice day outside and I'm not being productive. I'll be around some this weekend if anyone needs me o/20:50
TheJuliao/20:56

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!