TheJulia | JayF: yeah, basically needed to get it to a more consistent/cleaner format to start with and the age old patch I've been resurrecting has about 60% of the nuts and bolts pre-assembled | 00:02 |
---|---|---|
TheJulia | to at least, get started | 00:02 |
opendevreview | Verification of a change to openstack/ironic-python-agent bugfix/9.0 failed: Pin bgufix 9.0 ci jobs to zed https://review.opendev.org/c/openstack/ironic-python-agent/+/859255 | 00:35 |
vanou | good morning ironic | 00:50 |
*** rcastillo|ruck is now known as rcastillo | 03:47 | |
adam-rozman | Good morning Ironic ! | 07:57 |
arne_wiebalck | Good morning, Ironic! | 08:31 |
opendevreview | Nisha Agarwal proposed openstack/ironic master: Fixes anaconda deploy for PXE boot https://review.opendev.org/c/openstack/ironic/+/860055 | 09:09 |
jm1 | dtantsur: hello :) what do we do about this? https://review.opendev.org/c/openstack/bifrost/+/859430/ | 09:12 |
dtantsur | jm1: left a couple of comments, thanks for the reminder | 10:42 |
adam-rozman | dtantsur,iurygregory: Hi, if you have some free time please check https://review.opendev.org/c/openstack/ironic-python-agent/+/855866 I had +2 twice already so I think it is in good shape. | 10:44 |
dtantsur | adam-rozman: sorry, a couple more comments | 10:47 |
dtantsur | adam-rozman: JFYI this is how the final release notes look like: https://docs.openstack.org/releasenotes/ironic/zed.html | 10:48 |
adam-rozman | dtantsur: thanks for the review, I will adjust the notes and the code | 10:49 |
iurygregory | good morning Ironic | 11:10 |
iurygregory | adam-rozman, sure I will take a look | 11:10 |
opendevreview | Jakob Meng proposed openstack/bifrost master: Explicitly fetch baremetal ports and use id on openstacksdk>=0.99.0 https://review.opendev.org/c/openstack/bifrost/+/859430 | 11:21 |
jm1 | dtantsur: thank you, very good comments, implemented them :) | 11:23 |
opendevreview | Verification of a change to openstack/ironic master failed: Add ironic-grenade-skip-level Job https://review.opendev.org/c/openstack/ironic/+/836966 | 11:42 |
iurygregory | To utilize this module, the installed version of the openstacksdk library MUST be <=0.98.999. | 11:43 |
iurygregory | interesting | 11:44 |
adam-rozman | iurygregory: thanks! | 11:54 |
adam-rozman | dtantsur: I have fixed 3 out of the 4 comments on my local branch but I have replyed to the first comment because I have question/suggestion related to that | 11:56 |
adam-rozman | dtantsur: nevermind I have answered my question | 12:01 |
opendevreview | Kirill proposed openstack/python-ironicclient master: add support of new graphical console interface https://review.opendev.org/c/openstack/python-ironicclient/+/860688 | 12:48 |
opendevreview | Kirill proposed openstack/ironic master: add vnc console https://review.opendev.org/c/openstack/ironic/+/860689 | 13:04 |
TheJulia | good morning | 13:27 |
iurygregory | good morning TheJulia | 13:38 |
opendevreview | Lukas Piwowarski proposed openstack/ironic master: Remove reference to 'all-plugin' tox environment https://review.opendev.org/c/openstack/ironic/+/860697 | 13:41 |
TheJulia | dtantsur: any chance I can pose a question which requires a seek to about 6 years ago in memory? | 13:43 |
TheJulia | dtantsur: nevermind, I went through the original change which added what I was looking at and it was somehow worked in as requirement without reveiwer request between versions, I guess in an attempt to rational handling of db race conditions... as a means to simulate such cases for unit testing which is... not great to add controlling logic :\ | 13:53 |
dtantsur | TheJulia: I can still try flexing my memory, but 6 years ago is a lot of time :) | 13:53 |
TheJulia | Looking closely, I'm fairly convinced it is pointless functionality which we don't expose and actually creates issues with ha-ification | 14:08 |
* TheJulia wonders why we never noticed this | 14:08 | |
dtantsur | you're intriguing me :) | 14:09 |
TheJulia | version_id on the db node object in inspector | 14:10 |
TheJulia | which it looks like the code treats in the in-memory cached version_id as authortative over the db | 14:10 |
dtantsur | okay, this is the part I've never fully understood | 14:10 |
TheJulia | which means you can't bounce across inspector services | 14:10 |
dtantsur | one of the reasons to merge inspector into ironic is to get rid of this code :D | 14:10 |
TheJulia | you'll be reported as race condition errors are occuring even though the in memory cache is... blah | 14:11 |
TheJulia | ++ | 14:11 |
TheJulia | well, rip out version id now, make it easier to merge in | 14:11 |
TheJulia | :) | 14:11 |
* TheJulia is going to go get breakfast | 14:11 | |
sschmitt | Question for folks on a migration path for instance network booting. We manage a number of devices in ironic that lack any sort of OOB management and use SNMP for power management. Whats the best way to deploy these now? | 14:47 |
vanou | JayF: Thanks for making factor out patch! I tried factor out patch for yoga, xena and wallaby on local lab. And they work. I added comment on yoga factor out patch which relates to release note I made on original backport patch. In release note of each https backport patch, it says packaging module is required. So should we modify such release note too? I'm not sure. | 14:53 |
dtantsur | sschmitt: have you seen https://docs.openstack.org/ironic/latest/admin/drivers/snmp.html? | 14:54 |
JayF | vanou: as I understand it, release notes are to be treated as if they're for master Branch only. So I think it's fine | 14:54 |
TheJulia | sschmitt: take a look at the ramdisk boot interface. So you can lock your hardware to always network booting. Downside… or positive side depending on how you look at it, it would be ephemeral | 14:56 |
TheJulia | sschmitt: sorry, ramdisk deploy interface | 14:56 |
dtantsur | no need for ramdisk boot really, as long as it's UEFI | 14:56 |
TheJulia | That also helps avoid bootloaders trying to install with UEFI overrides | 14:56 |
dtantsur | with the netboot fallback even BIOS will work | 14:56 |
vanou | JayF: Thanks. I understand. | 14:57 |
TheJulia | Yeah, but they can’t redeploy if UEFI boot loader install smashes the settings | 14:57 |
sschmitt | Well even with that netboot fallback, how would one redeploy? | 14:57 |
TheJulia | NobodyCam has mentioned this is an issue | 14:57 |
TheJulia | With UEFI specifically | 14:57 |
dtantsur | yeah, a one-time efibootmgr call may be needed | 14:58 |
* TheJulia sips coffee | 14:58 | |
TheJulia | I guess, there are a few different ways, but it all depends on overall workflow things need to be within | 14:58 |
sschmitt | yeah unfortunately ephemeral would not work for us here so I'll need to get creative I think | 14:59 |
TheJulia | sschmitt: are they consistent machines? | 14:59 |
dtantsur | if you control the instances, a one-time efibootmgr call may be the way | 15:00 |
dtantsur | you can even writing an ironic driver that automates it | 15:00 |
TheJulia | Yeah, before tearing down I guess. | 15:00 |
dtantsur | * write | 15:00 |
sschmitt | Yeah I think that might be the best route | 15:01 |
TheJulia | The restaurant I’m sitting in is like one step away from Disney eurobeats megamax like it plays in Harajuku | 15:01 |
TheJulia | Err, megamix | 15:02 |
TheJulia | Yay autocorrect :( | 15:02 |
vanou | JayF: Iury says modifying release note of backport patch is reasonable. And he says he will create another patch which only modifies release note to avoid running additional CI. | 15:04 |
vanou | On yoga factor out patch at Gerrit | 15:05 |
JayF | I'm fine with that and I trust Iury to know the right thing to do | 15:05 |
dtantsur | we do modify release notes in backports from time to time | 15:05 |
TheJulia | We do, and it does override the master published copy of we do if memory serves. Admittedly, the logic there is a little opaque | 15:06 |
vanou | JayF: Thanks so much for quick work on factor out. iurygregory: Thanks for comment | 15:07 |
vanou | good night | 15:09 |
TheJulia | Goodnight | 15:09 |
iurygregory | vanou, yw | 15:25 |
iurygregory | good night | 15:25 |
TheJulia | sadness is 752 failing unit tests | 17:03 |
dtantsur | Oooo | 17:03 |
dtantsur | My sadness is called Init:CrashLoopBackOff | 17:03 |
TheJulia | :( | 17:04 |
dtantsur | okay, now another pod is crashing \o/ | 17:07 |
TheJulia | is there a dance video yet? | 17:07 |
dtantsur | wait, it's running now \o/ but the pod I wanted is not running, soooooo | 17:09 |
dtantsur | know what, I better run to the woods | 17:10 |
TheJulia | heh | 17:10 |
* TheJulia can hear the owls hooting positively at the idea | 17:10 | |
dtantsur | owls are wise (except for me) | 17:11 |
* dtantsur applies a random manifest and hopes for a miracle | 17:12 | |
iurygregory | dtantsur, ++ to run to the woods | 17:23 |
dtantsur | actually, miracle happened, the pod is running :) | 17:23 |
TheJulia | \o/ | 17:23 |
dtantsur | but I'll still run to the woods until Tuesday afternoon, so see you on Wednesday | 17:23 |
TheJulia | That is good, still have 752 failing tests | 17:23 |
TheJulia | have a good time in the woods! | 17:23 |
dtantsur | thank you! I hope you tame these tests asap. | 17:24 |
dtantsur | nice weekend to y'all | 17:24 |
iurygregory | enjoy your time off dtantsur o/ | 17:24 |
iurygregory | JayF, I'm wondering if we want to consider https://review.opendev.org/c/openstack/ironic/+/860281 for bugfix/21.0 and bugfix/20.2 , thoughts? | 17:25 |
JayF | Those branches are locked to Zed requirements. Zed requires the packaging package so I wasn't going to backport it | 17:52 |
JayF | Bluntly, I think you represent the largest constituency a bug fix Branch users so I'm happy to take whatever you think is best on this one though | 17:53 |
JayF | **of bugfix Branch users | 17:53 |
iurygregory | JayF, not really | 17:53 |
iurygregory | 20.2 supports py36 | 17:53 |
iurygregory | Zed requirements if I recall they don't support | 17:54 |
JayF | In ci, those branches are traditionally locked to the Zed branch of openstack/requirements | 17:54 |
JayF | That's what I was referring to | 17:54 |
iurygregory | yeah, now I'm wondering if makes sense for the 20.2... because it supports py36 but zed requirements dropped things for py36 .-. | 17:55 |
iurygregory | at least I think they did... | 17:55 |
JayF | I don't have strong opinions about how these branches are managed other than that whatever decisions we make end up well documented | 17:58 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: Use declarative reader/writer with enginefacade https://review.opendev.org/c/openstack/ironic-inspector/+/463768 | 18:01 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: Initial SQLAlchemy 2.0 prep https://review.opendev.org/c/openstack/ironic-inspector/+/860731 | 18:01 |
* TheJulia laughs evilly | 18:01 | |
TheJulia | so mostly got things sorted out in the prior patch, I think with those two, inspector should be good for sqlalchemy 2.0 | 18:01 |
TheJulia | sigh, functional fails | 18:18 |
JayF | iurygregory: I am confused by vanou's previous comment; combined with your and TheJulia's conversation about when/where release notes get modified | 18:18 |
JayF | Does someone have an action to backport a release note? Is that person me? | 18:18 |
JayF | also can someone land https://review.opendev.org/c/openstack/ironic/+/860281 | 18:18 |
JayF | we need to get that in and backported so I can get the stable release train moving again | 18:19 |
TheJulia | approved | 18:19 |
JayF | thanks | 18:20 |
JayF | https://review.opendev.org/c/openstack/ironic/+/860141 is next in that chain and passing tests fwiw | 18:21 |
TheJulia | somehow we're missing the cherry pick from label | 18:22 |
* TheJulia shrugs and pushes buttons | 18:22 | |
* TheJulia steps away for a few while CI runs | 18:23 | |
iurygregory | JayF, just in case you wanted the releasenote backported , my thoughts would be to do in another patch =) | 18:46 |
JayF | I'm honestly confused based on the various comments if we should 1) change the rel note at all and 2) if we do; should we do it in a backport | 18:46 |
JayF | I honestly have no idea, and I'd rather not pursue the "how exactly do backported relnotes work" rabbithole today | 18:47 |
TheJulia | if we're not removing the requirement off of master, we need to backport a reno change to represent the state on those versions | 18:47 |
TheJulia | otherwise it applies what is on master branch | 18:47 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/yoga: Stable only: Correct release note, packaging not required https://review.opendev.org/c/openstack/ironic/+/860738 | 18:49 |
JayF | so ^ this is what we need | 18:49 |
TheJulia | yes | 18:49 |
opendevreview | Jay Faulkner proposed openstack/ironic bugfix/19.0: Stable only: Correct release note, packaging not required https://review.opendev.org/c/openstack/ironic/+/860740 | 18:50 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/xena: Stable only: Correct release note, packaging not required https://review.opendev.org/c/openstack/ironic/+/860741 | 18:51 |
opendevreview | Jay Faulkner proposed openstack/ironic bugfix/18.1: Stable only: Correct release note, packaging not required https://review.opendev.org/c/openstack/ironic/+/860742 | 18:52 |
TheJulia | sigh... 77 tests now fail | 18:55 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: Use declarative reader/writer with enginefacade https://review.opendev.org/c/openstack/ironic-inspector/+/463768 | 19:09 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 prep https://review.opendev.org/c/openstack/ironic-inspector/+/860731 | 19:09 |
TheJulia | Well, functional at least seemed to work now | 19:10 |
* TheJulia goes into town because staring at the computer is not going to work to get results faster | 19:11 | |
opendevreview | Merged openstack/ironic stable/yoga: Stable only: Factor out addition of packaging lib https://review.opendev.org/c/openstack/ironic/+/860281 | 19:33 |
JayF | https://review.opendev.org/c/openstack/ironic/+/860738 if we can get this merged, yoga will be ready for release | 19:59 |
opendevreview | Merged openstack/ironic bugfix/19.0: Stable only: Factor out addition of packaging lib https://review.opendev.org/c/openstack/ironic/+/860141 | 20:01 |
opendevreview | Verification of a change to openstack/ironic stable/yoga failed: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/850553 | 20:01 |
JayF | I'm stepping out early; it's a nice day outside and I'm not being productive. I'll be around some this weekend if anyone needs me o/ | 20:50 |
TheJulia | o/ | 20:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!