vanou | good morning ironic | 02:09 |
---|---|---|
arozman | hi Ironic | 07:02 |
arne_wiebalck | Good morning vanou arozman and Ironic! | 07:26 |
janders | hey vanou arozman arne_wiebalck and Ironic o/ | 07:50 |
arne_wiebalck | hey janders o/ | 07:50 |
rpittau | good morning ironic! o/ | 08:25 |
vanou | Hi arozman arne_wiebalck janders rpittau o/ | 08:35 |
rpittau | hey vanou :) | 08:35 |
opendevreview | Vanou Ishii proposed openstack/ironic bugfix/19.0: Deals with migration of tox base job to Ubuntu Jammy https://review.opendev.org/c/openstack/ironic/+/865802 | 08:39 |
opendevreview | kamlesh chauvhan proposed openstack/ironic-tempest-plugin master: OOB inspection timeout fix for idrac https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/865803 | 08:44 |
opendevreview | Vanou Ishii proposed openstack/ironic bugfix/18.1: Deals with migration of tox base job to Ubuntu Jammy https://review.opendev.org/c/openstack/ironic/+/865804 | 08:47 |
opendevreview | Vanou Ishii proposed openstack/ironic bugfix/19.0: Deals with migration of tox base job to Ubuntu Jammy https://review.opendev.org/c/openstack/ironic/+/865802 | 08:51 |
rpittau | vanou: I'm not sure we want to retroactively set our tests to run on jammy | 08:58 |
opendevreview | kamlesh chauvhan proposed openstack/ironic-tempest-plugin master: OOB inspection timeout fix for idrac https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/865803 | 08:59 |
opendevreview | kamlesh chauvhan proposed openstack/ironic-tempest-plugin master: OOB inspection timeout fix for idrac https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/865803 | 08:59 |
vanou | rpittau: Without these patches, Zuul tests at 18.1 & 19.0. There was update on Zuul base job in which openstack-tox based Zuul job uses Ubuntu Jammy. And Zuul job at 18.1/19.0 get affected with these change at Zuul base job. | 09:16 |
vanou | ^ Without these patches, Zuul tests at 18.1 & 19.0 fail. | 09:17 |
rpittau | vanou: ok, so the title is misleading then :) | 09:17 |
rpittau | vanou: thanks for taking care of that, I +2 them | 09:19 |
vanou | rpittau: yeah, title may confuse. sorry. And thanks for +2 :) | 09:20 |
vanou | After merge of these patches, I hope both https://review.opendev.org/c/openstack/ironic/+/864465 and https://review.opendev.org/c/openstack/ironic/+/864466 be merged. | 09:23 |
kubajj | Good morning Ironic! | 10:22 |
dtantsur | arne_wiebalck, JayF, just realized: I'll need to skip the meeting today | 11:06 |
arne_wiebalck | dtantsur: ack | 11:06 |
kubajj | dtantsur: what needs to be changed for the swift/no store? | 12:03 |
dtantsur | kubajj: you need to create a similar backend structure as exists in Inspector | 12:09 |
dtantsur | i.e. a configuration option that directs the store/load calls to a certain backend | 12:09 |
kubajj | is the same backed used for ironic as well? Or is Ironic db always PostgreSQL or MySQL? | 12:11 |
iurygregory | morning Ironic o/ | 12:21 |
dtantsur | kubajj: ironic does not have it now | 12:47 |
dtantsur | just follow the code in Inspector, it should clarify the scope | 12:48 |
kubajj | dtantsur: I am trying to figure out what is the goal. Do we want to be able to store the data in swift on ironic side if swift was used for inspector (and not store the data if nostore is used)? | 12:51 |
dtantsur | kubajj: correct | 13:03 |
kubajj | dtantsur: Ok, I think I will just do it in a follow-up. | 13:12 |
kubajj | dtantsur: should the configuration option be loaded from the ironic.conf? Should I check that it is the same as the option in inspector or that's unnecessary? | 13:39 |
*** rcastillo|rover is now known as rcastillo | 13:58 | |
TheJulia | good morning | 14:20 |
opendevreview | Danni Shi proposed openstack/ironic-python-agent master: Add an attestation extension https://review.opendev.org/c/openstack/ironic-python-agent/+/803510 | 14:29 |
* TheJulia wonders if we have a JayF this morning | 14:58 | |
JayF | we do, barely | 14:58 |
JayF | or at least some fraction thereof | 14:59 |
iurygregory | Are you ok, JayF? | 14:59 |
TheJulia | travel/jetlag? | 14:59 |
JayF | I've been travelling and am extra exhausted | 14:59 |
iurygregory | oh | 14:59 |
JayF | in my current time zone, yesterday was a 1am-9pm day | 15:00 |
JayF | #startmeeting ironic | 15:00 |
opendevmeet | Meeting started Mon Nov 28 15:00:38 2022 UTC and is due to finish in 60 minutes. The chair is JayF. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'ironic' | 15:00 |
JayF | o/ Who all is here this morning? | 15:00 |
iurygregory | o/ | 15:00 |
rpittau | o/ | 15:00 |
matfechner | o/ | 15:00 |
ajya | o/ | 15:01 |
erbarr | o/ | 15:01 |
JayF | #link agenda https://wiki.openstack.org/wiki/Meetings/Ironic | 15:01 |
JayF | as always our agenda is on the wiki | 15:01 |
JayF | #topic Announcements/Reminders | 15:01 |
JayF | Reminder: if you have patches that need review; hashtag them with ironic-week-prio, and similarly please take a look at tagged patches | 15:02 |
TheJulia | o/ I'm semi here, about to leave though :\ | 15:02 |
JayF | That's all we've got for announcements/reminders | 15:02 |
JayF | #topic Review action items | 15:02 |
JayF | There were no action items in the previous meeting, moving on. | 15:02 |
JayF | #topic Review Ironic CI Status | 15:02 |
rloo | o/ | 15:02 |
JayF | anyone have anything interesting to report about CI recently? | 15:03 |
JayF | I think things are running smooth-ish? | 15:03 |
* arne_wiebalck is still in another meeting, will fully join in a few minutes | 15:03 | |
JayF | OK; taking some silence as a no for inputs on CI issues. | 15:04 |
TheJulia | I've not noticed anything problematic CI wise | 15:04 |
JayF | #topic 2023.1 Work In Progress | 15:04 |
TheJulia | but I've only pushed a few limited patches as of recent | 15:04 |
JayF | #link https://etherpad.opendev.org/p/IronicWorkstreams2023.1 | 15:04 |
JayF | Looks like there are no updates in there since last week, not a big deal, please put some updates in there if you're working on something and want status tracked in the meeting. | 15:05 |
JayF | #topic Baremetal SIG | 15:05 |
rpittau | ci on bugfix branches is broken since the change to jammy | 15:05 |
JayF | I think we have this scheduled now, yeah? | 15:05 |
JayF | rpittau: ack; are you looking into that or should it go on my list? | 15:05 |
rpittau | there are 2 patches already. thanks to vanou | 15:05 |
rpittau | https://review.opendev.org/c/openstack/ironic/+/865802 | 15:06 |
rpittau | https://review.opendev.org/c/openstack/ironic/+/865804 | 15:06 |
JayF | I've got them open; will review after the meeting. | 15:07 |
rpittau | thanks | 15:07 |
JayF | OK; so with Baremetal SIG, didn't we get that scheduled? | 15:07 |
JayF | I think someone was going to send out meeting invites | 15:07 |
JayF | but most of the group who was working on that isn't here; I'll make sure to follow up separately with arne_wiebalck and dtantsur | 15:07 |
arne_wiebalck | the plan was also to advertise the *new* SIG cadence on an OpenInfra live | 15:08 |
JayF | That's right | 15:09 |
JayF | We have all those dates and coordination done? Or are there further actions that need to be taken? | 15:09 |
arne_wiebalck | I think we have a date for the next SIG meeting | 15:09 |
arne_wiebalck | Feb 8th ? | 15:09 |
JayF | #link https://etherpad.opendev.org/p/ironic-quarterly-meetup | 15:10 |
JayF | that's where our notes are, it seems | 15:10 |
JayF | > Wed, Feb 8th, 2023 at 3-5pm UTC | 15:10 |
JayF | I'm going to remove the BM SIG recurring topic now; I think we have it nailed down, yeah/ | 15:10 |
JayF | ? | 15:10 |
iurygregory | ++ | 15:11 |
JayF | Awesome; moving on | 15:11 |
JayF | There are no items for RFE review; skipping topic. | 15:11 |
JayF | #topic Open Discussion | 15:11 |
JayF | any items for open discussion today before we close out the meeting | 15:11 |
TheJulia | one item from me | 15:11 |
TheJulia | I'm looking at adding more metrics collection to ironic as a "for fun thing" at the moment | 15:12 |
TheJulia | and I'm wondering if we should count every timer metric that goes to ironic lib as also a counter call | 15:12 |
JayF | TheJulia: I *think* the library gives you that for free? | 15:12 |
TheJulia | so we have "count of calls" and "milliseconds spent" | 15:12 |
TheJulia | so, the code does not from what I've read | 15:12 |
JayF | count of calls is the same as a counter, isn't it? | 15:12 |
TheJulia | but it would be super easy to do | 15:13 |
TheJulia | call counts have to use the count decorator | 15:13 |
TheJulia | timer is just time spent | 15:13 |
TheJulia | as a wallclock | 15:13 |
JayF | oh I get you, you have to provide both decorators to get it | 15:13 |
TheJulia | ... or just do it in one... | 15:13 |
TheJulia | but yeah | 15:13 |
JayF | If I were writing that today it'd be free :D | 15:13 |
JayF | Now, don't go the other way | 15:13 |
kubajj | o/ | 15:13 |
JayF | timer = timer+counter is nice | 15:13 |
JayF | counter should exist without timing | 15:13 |
TheJulia | yeah, it does, but double decorating everything is silly | 15:13 |
TheJulia | when it already has timer | 15:14 |
JayF | yeah; I'm saying timer can imply counter and I'm onboard | 15:14 |
TheJulia | cool cool | 15:14 |
JayF | I'm less onboard with taking away the counter decorator | 15:14 |
JayF | beceause I think there are times when you want to count a thing that doesn't make sense to time | 15:14 |
TheJulia | arne_wiebalck: oh, you were curious about logging state changes, I'm not opposed and would happilly aapprove such a patch | 15:14 |
TheJulia | JayF: yeah, definitely not taking away a decorator | 15:15 |
TheJulia | because yes, there are times | 15:15 |
JayF | good stuff; I'm onboard then | 15:15 |
TheJulia | cool cool | 15:15 |
TheJulia | Anyway, that is all I have | 15:17 |
JayF | I think that's all the meeting has, too | 15:17 |
JayF | last call for anything else? | 15:17 |
TheJulia | meeting.do_we_end_meeting() ? | 15:17 |
* TheJulia steps out | 15:18 | |
JayF | #endmeeting | 15:18 |
opendevmeet | Meeting ended Mon Nov 28 15:18:45 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:18 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2022/ironic.2022-11-28-15.00.html | 15:18 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2022/ironic.2022-11-28-15.00.txt | 15:18 |
opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2022/ironic.2022-11-28-15.00.log.html | 15:18 |
TheJulia | iurygregory: going to step away for a couple hours, I'll ping you when I'm abck | 15:19 |
arne_wiebalck | TheJulia: ok, great, thanks! | 15:19 |
iurygregory | TheJulia, ack | 15:21 |
mraineri | dtantsur: I saw your comments on the Redfish profile; I was hoping to address some of them, but it looks like the pull request was merged | 15:35 |
mraineri | It should be an easy change though; if the "Bios" resource is truly optional for OpenStack, we can mark it as "Recommended" in a future edit | 15:36 |
mraineri | The same can also be done with IndicatorLED | 15:36 |
JayF | mraineri: So it's normal practice in this community for non-blocking feedback to be acknowledged with a follow up patch | 15:37 |
JayF | mraineri: feel free to make a new PR with just the changes you'd like to make | 15:37 |
mraineri | Sounds good! | 15:37 |
mraineri | I might pass that off to ajya though :) | 15:38 |
dtantsur | yeah, that was exactly my thought: no to block an important thing for something that can be fixed in a follow-up | 15:42 |
dtantsur | kubajj: you should not / cannot not access the inspector configuration from ironic | 15:43 |
dtantsur | so just use ironic.conf | 15:43 |
dtantsur | actually, during the migration, operators may *want* to have different backends in inspector and ironic, e.g. to avoid duplicate information | 15:43 |
ajya | mraineri: ok, will start a new patch, cc dtantsur JayF | 15:46 |
kubajj | dtantsur: makes sense, thanks | 15:49 |
kubajj | JayF or TheJulia (when you're back) could you have a look at https://review.opendev.org/c/openstack/ironic/+/864057 | 15:50 |
JayF | it's on my list | 15:51 |
JayF | don't forget you can #ironic-week-prio on that | 15:51 |
JayF | if it's ready for general review | 15:51 |
mraineri | Thanks ajya! Please tag me on it too | 15:56 |
opendevreview | Merged openstack/ironic bugfix/18.1: Deals with migration of tox base job to Ubuntu Jammy https://review.opendev.org/c/openstack/ironic/+/865804 | 16:16 |
opendevreview | Merged openstack/ironic bugfix/19.0: Deals with migration of tox base job to Ubuntu Jammy https://review.opendev.org/c/openstack/ironic/+/865802 | 16:20 |
kubajj | JayF: how do I actually add the hashtag? Do I just comment with the hashtag in the message? | 16:36 |
JayF | kubajj: click "show more" on the left side with all the other fields. hashtag is one. click edit and type in ironic-week-prio | 16:43 |
kubajj | Thanks JayF | 16:47 |
TheJulia | iurygregory: you around? | 16:55 |
iurygregory | TheJulia, yup | 17:00 |
TheJulia | iurygregory: do you have like 20 minutes to chat regarding ipe? | 17:03 |
JayF | .o(ipe?) | 17:03 |
iurygregory | TheJulia, yup | 17:04 |
iurygregory | JayF, ironic-prometheus-exporter | 17:04 |
JayF | oooh | 17:04 |
iurygregory | let me just answer a bz and I will have the 20min =) | 17:04 |
TheJulia | sure | 17:04 |
TheJulia | going to relaunch my web browser in the mean time | 17:05 |
rpittau | good night! o/ | 17:05 |
iurygregory | TheJulia, ok, I'm free | 17:14 |
TheJulia | https://meet.google.com/uuv-rxjw-zfp | 17:15 |
*** tzumainn_ is now known as tzumainn | 17:45 | |
TheJulia | iurygregory: thanks for the additional context, that helped tons | 17:46 |
iurygregory | TheJulia, yw | 17:49 |
opendevreview | Merged openstack/ironic master: Get inventory from Inspector https://review.opendev.org/c/openstack/ironic/+/864057 | 18:37 |
stevebaker[m] | good morning | 20:05 |
TheJulia | o/ | 20:12 |
TheJulia | stevebaker[m]: so stable/xena is fighting with me more | 21:48 |
TheJulia | I'm reaching enospoon sooner than I thought, so maybe I'll figure out why the test is failing :( | 21:50 |
TheJulia | tomorrow | 21:50 |
stevebaker[m] | TheJulia: OK, take care | 21:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!