| opendevreview | Merged openstack/ironic bugfix/18.1: Add support auth protocols for iRMC https://review.opendev.org/c/openstack/ironic/+/865950 | 00:07 |
|---|---|---|
| vanou | good morning ironic | 03:00 |
| opendevreview | Vanou Ishii proposed openstack/ironic master: [iRMC] identify BMC firmware version https://review.opendev.org/c/openstack/ironic/+/865074 | 06:15 |
| opendevreview | Vanou Ishii proposed openstack/ironic master: [iRMC] Handle IPMI incompatibility in iRMC S6 2.x https://review.opendev.org/c/openstack/ironic/+/865075 | 06:15 |
| rpittau | good morning ironic! o/ | 08:36 |
| opendevreview | Aija Jauntēva proposed openstack/sushy master: Fix volume deletion on newer iDRACs https://review.opendev.org/c/openstack/sushy/+/864845 | 09:22 |
| kubajj | good morning ironic! o/ | 09:25 |
| kubajj | dtantsur: are you around? I have some questions about the API | 11:15 |
| vanou | Hi rpittau kubajj | 11:21 |
| dtantsur | kubajj: around for ~ 30 minutes | 11:22 |
| vanou | JayF: Thanks for review on https://review.opendev.org/c/openstack/ironic/+/865950. If possible please review https://review.opendev.org/c/openstack/ironic/+/865951 too. | 11:22 |
| kubajj | dtantsur: I have created a very much WIP change, but I am not really sure what I am doing. Is it in the right direction? https://review.opendev.org/c/openstack/ironic/+/866876 | 11:24 |
| kubajj | Does node_ident have node.id or do I need to go back to db and implement get_bu_node_uuid? | 11:24 |
| dtantsur | kubajj: node.id is never user-facing | 11:25 |
| dtantsur | kubajj: the direction is absolutely right, left some comments for the next steps | 11:30 |
| kubajj | dtantsur: thanks, on it now | 11:30 |
| kubajj | dtantsur: so I need get_by_node_uuid, right? | 11:42 |
| dtantsur | kubajj: look at other places, I suspect what you actually need is to get the node first (taking into account policies) by UUID/name, then get the inventory by node.id | 11:47 |
| kubajj | dtantsur: I see, I'll have a look. Thanks | 11:48 |
| iurygregory | morning Ironic | 12:01 |
| rpittau | mmmm new gerrit interface is..... unteresting | 12:48 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/zed: Fix unit tests for Python 3.11 https://review.opendev.org/c/openstack/ironic/+/867298 | 12:49 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 13:59 |
| iurygregory | rpittau, don't we just need py3.11 fix in master? | 14:00 |
| rpittau | iurygregory: the debian bugs are against zed, so I'm backporting them | 14:01 |
| rpittau | besides, we should not use mocks as specs for other mocks anyway | 14:03 |
| opendevreview | Merged openstack/ironic-python-agent stable/xena: Warn when smartctl not found https://review.opendev.org/c/openstack/ironic-python-agent/+/867160 | 14:06 |
| vanou | JayF: Thanks for review on https://review.opendev.org/c/openstack/ironic/+/865074 and https://review.opendev.org/c/openstack/ironic/+/865075 I made change based on feedback. | 14:07 |
| iurygregory | rpittau, gotcha! | 14:09 |
| TheJulia | good morning | 14:21 |
| opendevreview | Merged openstack/ironic-python-agent stable/wallaby: Warn when smartctl not found https://review.opendev.org/c/openstack/ironic-python-agent/+/867161 | 14:23 |
| opendevreview | Merged openstack/ironic-python-agent stable/yoga: Warn when smartctl not found https://review.opendev.org/c/openstack/ironic-python-agent/+/867159 | 14:26 |
| kubajj | TheJulia: how do parameters get passed in the API? I am getting a "Missing mandatory parameter: node_ident" error. Is this any fimiliar? | 14:38 |
| TheJulia | kubajj: I'd have to actually see the code generating the exception to answer that question | 14:38 |
| TheJulia | truthfully, it depends on the API call | 14:38 |
| TheJulia | and where in the API | 14:39 |
| kubajj | TheJulia: I didn't want to push it to gerrit to trigger zuul, should I use the paste opendev? | 14:39 |
| TheJulia | because if we're in a nodes sub controller, i.e. /v1/nodes/node-uuid/magical-controller, we can extrapolate node-uuid which is the node_ident | 14:39 |
| TheJulia | kubajj: that is kind of like 6 or a half dozen, or a half empty vs half full glass of milk :) | 14:40 |
| TheJulia | kubajj: in other words, up to you, gerrit review is generally better since we can look at the multiple files and comment | 14:42 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: API for node inventory https://review.opendev.org/c/openstack/ironic/+/866876 | 14:47 |
| kubajj | TheJulia: ok, here it is ^ | 14:47 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 14:48 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: API for node inventory https://review.opendev.org/c/openstack/ironic/+/866876 | 14:52 |
| kubajj | also, TheJulia if you had a minute for https://review.opendev.org/c/openstack/ironic/+/866056 it would be very nice | 14:54 |
| TheJulia | kubajj: take a look at my comments, that should clear things up I think | 14:55 |
| TheJulia | so the new gerrit hides who has +2'ed unless you explicitly look | 14:55 |
| TheJulia | I guess that is a good bias reducer | 14:55 |
| TheJulia | oh, it still does, just a little differently | 14:57 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 15:04 |
| kubajj | TheJulia: what's the difference between calling there an instance like maintenance is and just adding it to subcontroller map? | 15:12 |
| JasonF | I'm going live for my office hours in the next 5 minutes or so; will be putting together the commands needed to retire bugfix branches and get an announcement out about it (to execute on the first week of Jan). | 15:53 |
| JasonF | Come join if you want @ youtube.com/jayofdoom | 15:53 |
| *** JasonF is now known as JayF | 15:53 | |
| TheJulia | unfortunately in the middle of a few things at the moment | 16:03 |
| TheJulia | unless I'm needed JayF | 16:03 |
| JayF | nope just extending an invitation | 16:03 |
| TheJulia | kubajj: offhand I don't remember | 16:03 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 Support https://review.opendev.org/c/openstack/ironic-inspector/+/860731 | 16:19 |
| dtantsur | oh, I need to re-review right? :) | 16:39 |
| TheJulia | Yes please | 16:40 |
| TheJulia | oh wait, didn't run tests locally | 16:40 |
| TheJulia | doh | 16:40 |
| opendevreview | Riccardo Pittau proposed openstack/sushy stable/zed: Handle proper code_status in unit test https://review.opendev.org/c/openstack/sushy/+/867209 | 16:40 |
| TheJulia | I got a water bill that was 2.5x the normal bill and was like "whiskey tango" | 16:40 |
| TheJulia | gah, stuff to fix :( | 16:40 |
| JayF | Alright, I have a couple of things that need some quick review | 16:44 |
| JayF | https://etherpad.opendev.org/p/IronicBugfixBranchCleanupEmail | 16:44 |
| JayF | https://etherpad.opendev.org/p/IronicBugfixBranchCleanupRFR | 16:44 |
| JayF | that's the draft email/tweet notice about branch retirement | 16:45 |
| JayF | and the commands I intend to use to retire them | 16:45 |
| JayF | please review email/tweet first so I can get the notice out ASAP | 16:45 |
| * JayF is taking the first "LGTM" and running with it | 16:45 | |
| opendevreview | Riccardo Pittau proposed openstack/ironic-inspector master: Update for tox 4 https://review.opendev.org/c/openstack/ironic-inspector/+/867541 | 16:49 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-inspector master: Update tox.ini for tox 4 https://review.opendev.org/c/openstack/ironic-inspector/+/867541 | 16:50 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 Support https://review.opendev.org/c/openstack/ironic-inspector/+/860731 | 16:53 |
| TheJulia | dtantsur: ^ better now | 16:53 |
| dtantsur | nice! | 16:53 |
| dtantsur | I'll see if I can still collect enough brainpower today. Otherwise tomorrow. | 16:53 |
| TheJulia | the diff should be fairly straight forward | 16:54 |
| TheJulia | ooh... new gerrit automatically brings up the latest change if your navigating on latest instead of the prior if it gets updated | 16:54 |
| rpittau | JayF: the list looks good, commands as well | 16:56 |
| rpittau | btw, I guess for mastodon will be a 'trumpet'? :) | 16:56 |
| TheJulia | huh? | 16:56 |
| rpittau | email/tweet/trumpet | 16:56 |
| TheJulia | I've not really gotten into the feel of mastedon | 16:57 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Update tox.ini for tox 4 https://review.opendev.org/c/openstack/ironic/+/867543 | 16:57 |
| TheJulia | err, mastodon | 16:57 |
| TheJulia | part of it is depression over loss of twitter | 16:58 |
| TheJulia | and the realization that the open commons kind of went poof | 16:58 |
| dtantsur | I miss it too, but mastodon has its own interesting vibes | 16:58 |
| rpittau | it is indeed, although lots of people/stuff I follow migrated, which is actually unexpected | 16:58 |
| rpittau | or started using mastodon in parallel anyway | 16:59 |
| TheJulia | I'm not nuking my account, but the amount of hate speach and bots following me is kind of insane | 17:00 |
| TheJulia | for like every person that disappears that was a follower, a bot now follows me | 17:00 |
| dtantsur | ugh | 17:00 |
| rpittau | terrible | 17:00 |
| TheJulia | and it is stupidly obvious since it is not like I'm a notable chef or travel personality | 17:00 |
| TheJulia | which is most of what they seemed to be geared around | 17:01 |
| JayF | rpittau: they are called "toots" | 17:01 |
| TheJulia | and they can be detected because stock photo use | 17:01 |
| JayF | rpittau: on mastodon | 17:01 |
| rpittau | JayF: oh right! :D | 17:01 |
| JayF | rpittau: which is why I just called it mastodon/twitter. Out of context "toot" is WTF-inducing lol | 17:01 |
| rpittau | lol | 17:01 |
| dtantsur | :D | 17:02 |
| * TheJulia wonders if there is any control to chagne the look of the new gerrit ui | 17:02 | |
| dtantsur | JayF, arne_wiebalck, re quarterly meetup: do we use this opendev video tool? my memory is increasingly patchy in the end of the year.. | 17:02 |
| dtantsur | cannot even recall how it's called... | 17:02 |
| dtantsur | I could maybe use RH gmeet, but it may be painful to use with non-RH accounts | 17:03 |
| opendevreview | Riccardo Pittau proposed openstack/sushy stable/zed: Handle proper code_status in unit test https://review.opendev.org/c/openstack/sushy/+/867209 | 17:04 |
| JayF | I have a zoom pro account, I'm happy to host anything whether I'm there or not | 17:04 |
| JayF | just let me know enough in advance to make the rooms up and such | 17:04 |
| JayF | that being said; I have no idea what tool we usually use. I do not recommend the opendev tool as all of the recording is done locally | 17:05 |
| rpittau | see ya! o/ | 17:05 |
| dtantsur | JayF: I think Zoom may be acceptable, especially since that's what Bare Metal SIG normally used (the CERN one) | 17:07 |
| dtantsur | unless anyone have better ideas, I'd go with your Zoom | 17:08 |
| JayF | When it gets closer, and we have a specific date, I'll set something up | 17:08 |
| TheJulia | The foundation uses zoom for most things, the only exception to that for streaming is Open Infra live used another service which offered some OBS like features | 17:08 |
| * TheJulia can't remember what it is called even though she was the one who introduced the foundation staff to it | 17:09 | |
| * TheJulia blames the pandemic | 17:09 | |
| JayF | oh yeah, we used that for the openinfralive | 17:09 |
| kubajj | TheJulia: dtantsur: I don't think that I can call the instance as maintenance does as I don't think that NodeController can pass node_ident to it. Am I missing something obvious? | 17:09 |
| JayF | but it's a presentation software, not a collaboration piece | 17:09 |
| JayF | so probably not the right tool for a BM SIG if we want user interactions | 17:09 |
| dtantsur | kubajj: it really should pass node_ident.. do you have the latest version of your patch up? | 17:16 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: API for node inventory https://review.opendev.org/c/openstack/ironic/+/866876 | 17:18 |
| kubajj | dtantsur: I do now ^ | 17:18 |
| dtantsur | okay, will look in a few | 17:18 |
| dtantsur | kubajj: I guess TheJulia has already spotted the problem :) | 17:34 |
| TheJulia | oh in __init__ ? | 17:36 |
| kubajj | oh, is it the self? | 17:36 |
| TheJulia | yeah, basically it is a bit of code that helps set self.node_ident | 17:38 |
| TheJulia | because it is a subcontroller | 17:38 |
| JayF | TheJulia: dtantsur: Workflow SQLA 2.0 for inspector? | 17:38 |
| TheJulia | JayF: sounds good to me | 17:38 |
| dtantsur | go for it | 17:38 |
| kubajj | TheJulia: but it's not the validating decorator, right? | 17:42 |
| TheJulia | I don't think so | 17:42 |
| TheJulia | I did look at it, at first glance and my thought was "are we missing a decorator" | 17:43 |
| TheJulia | but I don't think we were | 17:43 |
| kubajj | TheJulia: what is the difference between get_one, get_all and get? | 17:44 |
| TheJulia | get one is get /something and the one is something. get_all is get / | 17:45 |
| TheJulia | get, I think is the fallthrough catch of both, but you'll need to double check the pecan docs | 17:45 |
| JayF | so re: the failure on the inspector change | 17:59 |
| JayF | I wonder if we need something liek this for inspector grenade https://github.com/openstack/ironic/commit/bcde6e17411f6e56faf684a9d915859ecc01e7cc | 18:00 |
| kubajj | TheJulia: what is a subcontroller? | 18:10 |
| TheJulia | kubajj: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L1956-L1969 | 18:12 |
| TheJulia | so if you access the url of say /v1/nodes/<node_ident>/management, that link is from the NodesController to the subcontroller | 18:13 |
| kubajj | TheJulia: I am just trying to figure out how is my controller different from all the others. Is it because I use just get? | 18:15 |
| TheJulia | I'm not entirely sure off hand | 18:16 |
| TheJulia | ... what is the URL your expecting for someone to access it? | 18:17 |
| TheJulia | JayF: I hope neutron's plugin changes did't blow things up for us... too much | 18:19 |
| kubajj | TheJulia: just /v1/nodes/<node_ident>/inventory | 18:20 |
| JayF | TheJulia: I suspect we need that change for inspector grenade too | 18:21 |
| JayF | TheJulia: and that'll fix it up, but I wanna make sure it reproduces first | 18:21 |
| JayF | before I just throw guesses at the wall :) | 18:21 |
| TheJulia | ++ | 18:28 |
| TheJulia | kubajj: so I think that would need to be get_all instead of get | 18:28 |
| TheJulia | since the controller should resolve that as a get against the root | 18:29 |
| TheJulia | of the controller that is | 18:29 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add doc for lsblk: /dev/nvme0n1p2: not a block device https://review.opendev.org/c/openstack/ironic/+/867228 | 18:44 |
| opendevreview | Julia Kreger proposed openstack/sushy-tools master: Add SecureBoot support to the emulator, all drivers https://review.opendev.org/c/openstack/sushy-tools/+/842266 | 19:24 |
| opendevreview | Merged openstack/ironic stable/wallaby: Add support auth protocols for iRMC https://review.opendev.org/c/openstack/ironic/+/865951 | 19:50 |
| opendevreview | Merged openstack/ironic master: Catch any exception for Cleaning https://review.opendev.org/c/openstack/ironic/+/866933 | 21:37 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: [grenade] Explicitly enable Neutron ML2/OVS services in the CI job https://review.opendev.org/c/openstack/ironic-inspector/+/867573 | 21:40 |
| TheJulia | jayf ^ | 21:40 |
| JayF | +2, I'll land it with a single core review if it gets past CI and nobody else has looked | 21:48 |
| TheJulia | ++ | 21:49 |
| TheJulia | only difference is I turned off metering, we don't use it | 21:49 |
| JayF | makes sense | 21:49 |
| JayF | we need every byte of ram we can get | 21:49 |
| TheJulia | bingo | 21:50 |
| JayF | should we revise the job desc in ironic to claw that back, too? | 21:50 |
| TheJulia | eh. maybe. Since it is passing I'm not going to worry about it at the moment | 21:50 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Ironic doesn't use metering; don't start it in CI https://review.opendev.org/c/openstack/ironic/+/867574 | 21:51 |
| JayF | we'll see if this passes :) | 21:51 |
| * TheJulia thinks she is out of spoons for the day | 21:54 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!