opendevreview | Merged openstack/ironic-python-agent stable/ussuri: WIP Drop python2 from bindep.txt https://review.opendev.org/c/openstack/ironic-python-agent/+/862658 | 00:02 |
---|---|---|
TheJulia | JayF: awesome! Now to prep dinner | 00:28 |
iurygregory | JayF, let me sync with dtantsur and rpittau we can answer this tomorrow I would say, wdyt? | 01:36 |
JayF | I have no desire to cut bugfix releases unless we have contributors explicitly invested in them | 01:44 |
kamleshChauvhan | Good morning Ironic ! | 06:51 |
kamleshChauvhan | Need help to review https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/865803 & https://review.opendev.org/c/openstack/sushy/+/864845 | 06:52 |
codecap | Hi Guys, | 08:16 |
codecap | still need help with ironic setup by kolla-ansible. Ironic Inspector does not find the node, when being contacted during deployment. Hier the error message | 08:16 |
codecap | Look up error: Could not find a node for attributes {'bmc_address': ['10.40.11.68'], 'mac': ['4c:52:62:42:de:97', '4c:52:62:42:de:95', '4c:52:62:52:ae:2a', '4c:52:62:42:de:98', '4c:52:62:42:de:96', '4c:52:62:52:ae:2b']} | 08:16 |
codecap | Can somebody help ? | 08:16 |
rpittau | good morning ironic! o/ | 08:46 |
rpittau | JayF: if I'm reading it right antelope is due out in March, with FF in February. If we don't cut a bugfix branch now (or before mid january at the latest) it probably does not make sense to cut one at all at this point considering that ironic final antelope release will be between mid february and beginning of march (I'm thinking with my downstream mind for this) | 08:56 |
rpittau | JayF: sorry, actually ironic, ipa and inspector needs to be out by Feb 10, so even more we need a bugfix branch now or never | 08:59 |
rpittau | dtantsur, TheJulia ^ | 09:00 |
rpittau | I don't mind skipping bugfix, but for the sake of consistency we should at least cut one, even if it won't be consumed that much | 09:02 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix "'NoneType' object is not iterable" in RAID https://review.opendev.org/c/openstack/ironic/+/867117 | 09:21 |
dtantsur | rpittau, TheJulia, JayF, I think we should not diverge from our release plans without a good reason | 09:41 |
dtantsur | "middle of the holidays" is a good reason, "we forgot" - not so much :) | 09:41 |
dtantsur | remember, we hope that not only OpenShift consumers Ironic releases | 09:41 |
dtantsur | I think we only skipped releases for inspector when there were literally 0 functional changes | 09:44 |
dtantsur | JayF, TheJulia, not sure what you mean by "nothing about the release cadence in the spec", this spec is very clear on it: https://specs.openstack.org/openstack/ironic-specs/specs/approved/new-release-model.html#releasing | 09:45 |
dtantsur | or do you mean some other spec? | 09:45 |
rpittau | dtantsur: before being in the middle of holidays and forget again, I'll cut bugfix branches for ironic, ipa and inspector :) | 10:02 |
dtantsur | thanks! | 10:03 |
opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Fix create configuration unit tests https://review.opendev.org/c/openstack/ironic-python-agent/+/867780 | 10:52 |
opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Use pbr for versioning https://review.opendev.org/c/openstack/ironic-python-agent/+/867781 | 10:54 |
opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Update tox.ini for tox 4 https://review.opendev.org/c/openstack/ironic-python-agent/+/867782 | 10:54 |
kubajj | good morning everybody | 11:20 |
opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Update tox.ini for tox 4 https://review.opendev.org/c/openstack/ironic-python-agent/+/867782 | 11:21 |
opendevreview | kamlesh chauvhan proposed openstack/sushy stable/zed: Retry on iDRAC SYS518 errors for all requests https://review.opendev.org/c/openstack/sushy/+/867639 | 11:36 |
kamleshChauvhan | rpittau : Hi | 11:51 |
kamleshChauvhan | rpittau : I see patch https://review.opendev.org/c/openstack/sushy/+/864102 hasn't been backported. | 11:53 |
kamleshChauvhan | rpiitau : backporting of https://review.opendev.org/c/openstack/sushy/+/864911 is dependent on the same. | 12:04 |
opendevreview | Jakub Jelinek proposed openstack/ironic master: API for node inventory https://review.opendev.org/c/openstack/ironic/+/866876 | 12:49 |
kubajj | dtantsur: that's a draft of the release note and api-ref ^ | 12:51 |
rpittau | kamleshChauvhan: that has not been backproted because it's a feature, and we usually don't backports features | 12:59 |
kamleshChauvhan | rpittau : okay, Thanks. | 13:00 |
TheJulia | Brraaaaiiins. Also, good morning | 14:33 |
TheJulia | dtantsur: I'm fairly sure we skipped an ironic release once as well, but after years it has all become a blur | 14:36 |
TheJulia | and I think it was a few weeks into january with minimal changes outside of bug fixes since like a date in november | 14:37 |
TheJulia | or something like that | 14:37 |
TheJulia | my point was more "is there quantity/reason" | 14:38 |
TheJulia | I'm indifferent otherwise | 14:38 |
dtantsur | morning TheJulia | 14:39 |
opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 14:43 |
TheJulia | woot, nova side of shard key spec has 2x+2 | 14:51 |
dtantsur | \o/ | 14:57 |
TheJulia | Has anyone heard anything on service role implementation? | 14:58 |
JayF | dtantsur: I'm glad you found the release cadence stuff in a document. I thought I was going insane yesterday remembering having read it but being unable to find it | 15:00 |
opendevreview | Vanou Ishii proposed openstack/ironic master: [iRMC] Handle IPMI incompatibility in iRMC S6 2.x https://review.opendev.org/c/openstack/ironic/+/865075 | 15:04 |
opendevreview | Vanou Ishii proposed openstack/ironic master: Add argument to explicitly specify IPMI retry https://review.opendev.org/c/openstack/ironic/+/867808 | 15:04 |
rpittau | bye everyone see you tomorrow! o/ | 15:21 |
TheJulia | o/ | 15:21 |
TheJulia | JayF: a couple things on the shard api change, nothing super major aside from some rbac testing stuffs | 15:25 |
TheJulia | and api-ref build fails | 15:25 |
TheJulia | :) | 15:25 |
JayF | Nice. After that, it's filter ports by node.shard then write some docs, right? | 15:25 |
opendevreview | OpenStack Release Bot proposed openstack/ironic-python-agent bugfix/9.2: Update .gitreview for bugfix/9.2 https://review.opendev.org/c/openstack/ironic-python-agent/+/867816 | 15:27 |
TheJulia | basically yeah | 15:27 |
TheJulia | there is a thing on get /v1/nodes?shard=foo,bar | 15:27 |
TheJulia | but that can be in the next patch from my pov | 15:27 |
TheJulia | it may also just work, I don't remember how the filters get evaluated on just one cup of coffee | 15:27 |
TheJulia | hjensas: I just noticed there is one thing missing with the changes to use association proxy to speed node_uuid/chassis_uuid/allocation_uuid resolution. We don't have any release notes | 15:29 |
opendevreview | Jakub Jelinek proposed openstack/ironic master: API for node inventory https://review.opendev.org/c/openstack/ironic/+/866876 | 15:31 |
dtantsur | kubajj: 5 minutes from patch posted to a review is nearing my personal record ^^ :) | 15:37 |
JayF | dtantsur: would you be in opposition to changing the release policy to be every two months "as long as there is a sponsor to ensure the branch is maintained" or something similar | 15:40 |
JayF | dtantsur: basically, I want to change the policy such that we only cut bugfix releases if we know someone is packaging it | 15:40 |
dtantsur | JayF: I think I will, yes. I need to run now, happy to chat next week, but I don't want bugfix branches to end up something done only for Red Hat OpenShift | 15:40 |
JayF | otherwise it's just maintenance churn | 15:40 |
JayF | they mostly already are? | 15:41 |
dtantsur | maybe? | 15:41 |
dtantsur | we don't actually know how many people consume them. as always. | 15:41 |
JayF | I've never found a single user in the wild. I did take pypi stats and found a few thousand downloads; but a lot of people mirror all of openstack from pypi | 15:41 |
JayF | but I also know it's manual work, and unless we're going to make the releases tooling fix it, I am not a fan of just throwing time into a black hole | 15:41 |
JayF | s/fix it/support it/ | 15:42 |
dtantsur | JayF: if we think that nobody other than OCP is using bugfix branches we should stop doing them | 15:42 |
dtantsur | rpittau is making provisions to ensure we can live without old branches; we'll be able to use the same for new releases too | 15:42 |
kubajj | dtantsur: if swift is used, is it not covered by ironic object? I thought that Ironic objects were some kind of abstraction, but are they just for db? | 15:42 |
JayF | I mean, that's an even better answer to the problem as I present it. | 15:43 |
dtantsur | kubajj: I think they're only around DB | 15:43 |
dtantsur | (yes, my take on bugfix branches existence is completely different from my take on their extended maintenance) | 15:43 |
dtantsur | JayF: sorry, I need to run now, will be happy to elaborate further on Monday, but I think you got an idea | 15:44 |
JayF | dtantsur: you going to be @ Monday meeting? Can make it a topic there? | 15:44 |
dtantsur | most likely yes. ++ | 15:44 |
dtantsur | probably an ML topic as well since it may affect operators | 15:45 |
dtantsur | talk to you then o/ | 15:45 |
kubajj | dtantsur: could I get workflow for the alternative storage for inventory ( https://review.opendev.org/c/openstack/ironic/+/866056 ) then? I need to lead in the config option defined there to this change. | 15:48 |
JayF | dtantsur: yeah, my thought was, get an idea of a direction folks are OK with, then gather info. I don't wanna send something to the ML being like "what if we didn't bugfix branch anymore" without more than two cores weighing in on it :D | 15:49 |
kubajj | or TheJulia or JayF (about the workflow) | 15:50 |
JayF | I don't know off the top of my head; I know very little about inspector generally | 15:51 |
JayF | but if you haven't gotten help in ~an hour I have some free time | 15:51 |
* TheJulia sess a race for API version 1.81 brewing :) | 15:51 | |
JayF | it's not that bad of a rebase if you lose it | 15:52 |
kubajj | TheJulia: it's mine 😈 | 15:52 |
JayF | kubajj: better hurry; node sharding is coming after you :) | 15:52 |
TheJulia | well, you both have a few minor things to fix :) | 15:52 |
TheJulia | and some rbac tests to add :) | 15:52 |
JayF | like, for instance, breakfast | 15:52 |
kubajj | JayF: the change for the alternative storage is ready and has 2x +2, I just need to merge it | 15:52 |
TheJulia | mmmmmm breakfast | 15:53 |
JayF | I'm not fixing it; just going to go pick it up ;) | 15:53 |
kubajj | TheJulia: what is rbac? JayF you might win then :D | 15:53 |
TheJulia | Role Based Access Control | 15:53 |
TheJulia | we have tests that enumerate through a yaml file and run as a data driven test | 15:53 |
kubajj | TheJulia: ok, I'll have a look at them | 15:54 |
TheJulia | they basically run scenarios against the API to validate that access is granted, or denied based upon the policy | 15:54 |
TheJulia | think of it as an extra layer of security so we're validating the API behaves as we expect | 15:54 |
TheJulia | also, RBAC testing in the traditional python test model is super complex/painful, hence why it is a yaml file | 15:54 |
kubajj | TheJulia: is workflow automated or does somebody need to trigger it? I am unsure now | 15:56 |
TheJulia | someone needs to push a button | 15:56 |
TheJulia | for newer features/multi-change items, often we workflow stuff together | 15:56 |
TheJulia | or in relatively rapid sucession | 15:56 |
kubajj | TheJulia: and can I somehow tell my change that the config option exists, but just in another change? | 15:57 |
kubajj | for the swift support ^ | 16:01 |
TheJulia | well, we generally don't want to change config file parameters once we've merged | 16:02 |
TheJulia | so if you want to modify your original change, there is still time | 16:02 |
kubajj | TheJulia: I don't want to modify it. I need to use the config file parameter from the change enabling Swift (and NoStore) in the API one. | 16:04 |
TheJulia | OH! | 16:04 |
TheJulia | as long as the api change is after the base change with the config, your good | 16:04 |
kubajj | TheJulia: ok | 16:05 |
opendevreview | OpenStack Release Bot proposed openstack/ironic-inspector bugfix/11.2: Update .gitreview for bugfix/11.2 https://review.opendev.org/c/openstack/ironic-inspector/+/867825 | 16:05 |
opendevreview | OpenStack Release Bot proposed openstack/ironic bugfix/21.2: Update .gitreview for bugfix/21.2 https://review.opendev.org/c/openstack/ironic/+/867826 | 16:11 |
kubajj | TheJulia: should I raise a special NotFound if a user tries to access inventory of a node when the config is on NoStore? | 16:13 |
TheJulia | Likely NotFound with an error message | 16:17 |
TheJulia | I'm not sure there is a need to make another exception there | 16:18 |
TheJulia | but I'd convert the existing patterns first | 16:18 |
* TheJulia cries at the cover tests for ironic-inspector | 16:18 | |
JayF | yeah I saw that :( | 16:21 |
kubajj | I just realised that I probably need to implement a function to get the inventory from Swift 😮💨 | 16:25 |
kubajj | JayF: you're definitely winning this race | 16:26 |
JayF | it's not a race, fwiw | 16:26 |
JayF | and of course I was going to win | 16:26 |
JayF | ;) | 16:26 |
TheJulia | heh | 16:53 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 Support https://review.opendev.org/c/openstack/ironic-inspector/+/860731 | 17:06 |
JayF | I'm going to be testing all ironic projects against tox 4.0 today | 17:07 |
JayF | is anyone going to be around 12/22 when they un-pin tox 4.0 in case our gate explodes? | 17:08 |
TheJulia | if worst comes to worst, I can be pinged | 17:12 |
TheJulia | I'll be replacing a few appliances, redoing some baseboard | 17:12 |
JayF | I'm planning similar; where like I'll probably be off but not away | 17:14 |
TheJulia | yeah | 17:14 |
TheJulia | sigh, still not there with cover | 17:14 |
TheJulia | it is odd, version wise between CI and locally I get different counts | 17:16 |
TheJulia | and some different line numbers :( le sigh | 17:16 |
JayF | make sure you're rebased on master? | 17:21 |
JayF | it's going to do that before it runs tests in ci | 17:21 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 Support https://review.opendev.org/c/openstack/ironic-inspector/+/860731 | 17:29 |
TheJulia | yeah, rebased to upload | 17:29 |
opendevreview | Jay Faulkner proposed openstack/ironic master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867830 | 17:31 |
JayF | Can we land that ^^^ asap? We apparently have to fix stable branches too | 17:32 |
JayF | it's a formatting fix in the tox.ini, probably OK to land as a single core | 17:32 |
TheJulia | so they are no longer going to keep the stable branches pinned? | 17:32 |
TheJulia | seriously we have to now line separate? | 17:33 |
TheJulia | gah | 17:33 |
JayF | We're talking about it in -tc | 17:34 |
JayF | basically, even if it's pinned for stable we should backport it | 17:34 |
JayF | unless you want to keep tox <4 installed to run tests locally when pushing a stable change | 17:34 |
TheJulia | yeah, it is unpinned otherwise, which makes sense | 17:35 |
TheJulia | blarg | 17:35 |
TheJulia | that is a log of backporting | 17:35 |
JayF | this is tox's fault | 17:35 |
TheJulia | and a TON of gate overhead | 17:35 |
JayF | breaking changes are one thing | 17:35 |
JayF | stupid breaking changes are another | 17:35 |
TheJulia | workflowed that change as a single core approval, since it is non-code | 17:36 |
JayF | ack | 17:36 |
JayF | going to test inspector and the rest too | 17:36 |
TheJulia | k | 17:36 |
JayF | inspector (master) is happy \o/ | 17:36 |
TheJulia | okay, looks like cover test fixes work | 17:37 |
TheJulia | \o/ | 17:37 |
JayF | wallaby is not OK | 17:37 |
JayF | so I'll walk inspector and fix the first broken stable and we can backport from there | 17:37 |
JayF | TheJulia: \o/ | 17:37 |
JayF | it's only broken in inspector zed and earlier :| | 17:38 |
JayF | wow inspector zed local tests are hella broken | 17:39 |
JayF | jsonschema kaboom all over the place | 17:39 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector stable/zed: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867833 | 17:40 |
JayF | seeing if it happens in gate too | 17:40 |
opendevreview | Jay Faulkner proposed openstack/metalsmith master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867834 | 17:43 |
stuartgr_ | Hi. I'm trying to deploy Ubuntu 20.04 image with UEFI to a baremetal node using software RAID. The image has an ESP partition of exactly 550MiB but when IPA creates /dev/md0 to hold a copy of the ESP, it gets a capacity of (550MiB minus 64KiB). As a result, the command "cp /dev/md127p1 /dev/md0" fails with 'No space left on device' and the deployment fails. Any ideas how to fix this? | 17:44 |
TheJulia | JayF: joy :( | 17:48 |
TheJulia | stuartgr_: ugh, so... the default partition size was determiend as a reasonable maximum, considering all that *needs* to be in the ESP is grub, it sounds like it is just oversized and that would require a code change to handle | 17:49 |
JayF | ironic-lib is good \o/ | 17:50 |
JayF | ipe looks good \o/ | 17:51 |
stuartgr_ | My Ubuntu image came out of diskimage-builder so I'd expect a standard sized ESP | 17:54 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867835 | 17:56 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/zed: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867644 | 17:56 |
JayF | https://review.opendev.org/c/openstack/ironic-inspector/+/867833 and https://review.opendev.org/c/openstack/metalsmith/+/867834 have passed tests now if we want to land 'em I can start backporting them :D | 17:58 |
opendevreview | Merged openstack/ironic master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867830 | 18:02 |
opendevreview | Jay Faulkner proposed openstack/bifrost master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/bifrost/+/867838 | 18:03 |
jrosser | stuartgr_: did you find where the 550MiB in dib comes from, it doesnt appear as directly defined there as it is in ironic https://github.com/openstack/diskimage-builder/blob/master/diskimage_builder/lib/disk-image-create#L470-L480 | 18:06 |
opendevreview | Jay Faulkner proposed openstack/networking-baremetal master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-baremetal/+/867840 | 18:08 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867841 | 18:11 |
jrosser | stuartgr_: my search skills were insufficient, it is here https://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/elements/block-device-efi/block-device-default.yaml#L10 | 18:13 |
JayF | python-ironicclient is good \o/ | 18:13 |
opendevreview | Jay Faulkner proposed openstack/python-ironic-inspector-client master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/867842 | 18:14 |
JayF | sushy is good \o/ | 18:15 |
JayF | sushy-tools is good | 18:16 |
JayF | tenks is okay | 18:17 |
opendevreview | Jay Faulkner proposed openstack/virtualbmc master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/virtualbmc/+/867843 | 18:18 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867835 | 18:20 |
opendevreview | Jay Faulkner proposed openstack/metalsmith stable/zed: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867645 | 18:21 |
opendevreview | Jay Faulkner proposed openstack/metalsmith stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867646 | 18:21 |
opendevreview | Jay Faulkner proposed openstack/metalsmith stable/xena: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867647 | 18:22 |
opendevreview | Jay Faulkner proposed openstack/metalsmith stable/wallaby: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867648 | 18:22 |
opendevreview | Jay Faulkner proposed openstack/metalsmith stable/victoria: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867649 | 18:23 |
opendevreview | Jay Faulkner proposed openstack/metalsmith stable/ussuri: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867850 | 18:24 |
opendevreview | Jay Faulkner proposed openstack/metalsmith stable/train: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867851 | 18:24 |
TheJulia | jrosser: I'm wondering if it is a stock image they are trying to deploy | 18:24 |
opendevreview | Jay Faulkner proposed openstack/metalsmith stable/stein: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867852 | 18:24 |
TheJulia | thank you JayF | 18:24 |
JayF | I am no longer human | 18:25 |
JayF | I am a gerrit button mashing robot | 18:25 |
JayF | beep boop | 18:25 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector bugfix/11.0: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867853 | 18:26 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector bugfix/10.12: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867854 | 18:26 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector stable/yoga: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867855 | 18:26 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector bugfix/10.9: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867856 | 18:27 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector stable/xena: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867857 | 18:28 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector bugfix/10.7: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867858 | 18:28 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector stable/wallaby: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867859 | 18:30 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector stable/victoria: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867860 | 18:31 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector stable/ussuri: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867861 | 18:31 |
opendevreview | Jay Faulkner proposed openstack/ironic-inspector stable/train: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867862 | 18:31 |
opendevreview | Jay Faulkner proposed openstack/ironic bugfix/21.0: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867863 | 18:35 |
JayF | TheJulia: fwiw I am tagging all these as prio so if you feel like landing some, that should make it easy | 18:35 |
opendevreview | Jay Faulkner proposed openstack/ironic bugfix/20.2: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867864 | 18:35 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867865 | 18:36 |
opendevreview | Jay Faulkner proposed openstack/ironic bugfix/19.0: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867866 | 18:36 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/xena: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867867 | 18:36 |
opendevreview | Jay Faulkner proposed openstack/ironic bugfix/18.1: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867868 | 18:37 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/wallaby: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867869 | 18:38 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/victoria: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867870 | 18:38 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/victoria: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867870 | 18:39 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/ussuri: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867871 | 18:39 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/train: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867872 | 18:40 |
jrosser | TheJulia: stuartgr_ is working with me on this | 18:43 |
jrosser | its an image built with dib | 18:44 |
JayF | TheJulia: python-ironic-inspector-client is dying in CI functional tests with "Database is locked" errors from sqlite :| | 18:47 |
JayF | see https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/867842 :| | 18:48 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/zed: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867873 | 18:49 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867874 | 18:49 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867874 | 18:49 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867874 | 18:50 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/xena: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867875 | 18:50 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/wallaby: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867876 | 18:51 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/victoria: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867877 | 18:51 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/ussuri: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867878 | 18:52 |
opendevreview | Jay Faulkner proposed openstack/networking-generic-switch stable/train: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867879 | 18:52 |
JayF | jrosser: feel free to re-ping on that ansible change if it gets lost in the [gestures generally at gerrit and tox 4.0] | 18:55 |
jrosser | sure | 18:56 |
jrosser | i did totally fail to be able to use the ansible collection to configure anything to do with my ironic nodes though | 18:56 |
jrosser | token scope arrrrgh somehow makes them all not work for me where the rest of the modules seem ok | 18:57 |
iurygregory | JayF, can a go with single core approval in the tox patches or we should wait? | 18:59 |
JayF | iurygregory: land them with impunity | 18:59 |
JayF | iurygregory: if tests pass; it's fine | 18:59 |
iurygregory | JayF, ack o/ | 18:59 |
JayF | because I tested with tox 4.0 locally and tox 3.x is in the gate | 18:59 |
JayF | well, tested == `tox --showconfig` doesn't complain :) | 18:59 |
iurygregory | ok o/ | 19:01 |
opendevreview | Merged openstack/metalsmith stable/zed: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867645 | 19:07 |
opendevreview | Merged openstack/metalsmith master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867834 | 19:09 |
JayF | FYI as part of this; I realized we missed stable/stein metalsmith when EOL'ing old branches up thru stein | 19:09 |
JayF | so I've pushed that change to releases repo | 19:09 |
JayF | \ | 19:11 |
opendevreview | Merged openstack/metalsmith stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867646 | 19:12 |
opendevreview | Merged openstack/metalsmith stable/xena: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867647 | 19:12 |
opendevreview | Merged openstack/metalsmith stable/ussuri: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867850 | 19:12 |
opendevreview | Merged openstack/metalsmith stable/wallaby: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867648 | 19:12 |
opendevreview | Merged openstack/metalsmith stable/victoria: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867649 | 19:13 |
opendevreview | Merged openstack/metalsmith stable/train: Fixes for tox 4.0 https://review.opendev.org/c/openstack/metalsmith/+/867851 | 19:14 |
opendevreview | Merged openstack/ironic stable/zed: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867644 | 19:19 |
opendevreview | Merged openstack/ironic bugfix/20.2: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867864 | 19:22 |
opendevreview | Merged openstack/ironic stable/xena: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867867 | 19:22 |
opendevreview | Merged openstack/ironic stable/victoria: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867870 | 19:23 |
opendevreview | Merged openstack/networking-generic-switch master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867841 | 19:26 |
opendevreview | Merged openstack/networking-generic-switch stable/zed: Fixes for tox 4.0 https://review.opendev.org/c/openstack/networking-generic-switch/+/867873 | 19:27 |
opendevreview | Merged openstack/ironic stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867865 | 19:28 |
opendevreview | Merged openstack/ironic stable/wallaby: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867869 | 19:28 |
opendevreview | Merged openstack/ironic stable/train: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867872 | 19:28 |
stuartgr_ | jrosser: Thanks for finding the definition of ESP size in elements/block-device-efi/block-device-default.yaml. I reduced that to 525MiB and the image now successfully fits onto /dev/md0 :) | 19:29 |
jrosser | stuartgr_: were you able to do that via a dib parameter or did you have to do in and edit it? | 19:30 |
jrosser | *go in | 19:30 |
TheJulia | \o/ | 19:30 |
stuartgr_ | GRUB failed to find the correct partition after a reboot, but at least it's getting further than before | 19:30 |
jrosser | i wonder if this is because the 550M value in the ironi side doesnt account for some potential md superblock (?) | 19:31 |
JayF | jrosser: ++ that sounds really, really close to the right answer | 19:31 |
jrosser | and it exactly matches the value in dib so theres no room for anything else at all | 19:31 |
JayF | can one of you please put these details into a storyboard bug? | 19:31 |
JayF | so they aren't lost? | 19:31 |
stuartgr_ | I adjusted the value in the file, it wasn't clear how to change that from the commandline or env vars | 19:31 |
opendevreview | Merged openstack/ironic stable/ussuri: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867871 | 19:32 |
opendevreview | Merged openstack/ironic-inspector stable/zed: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867833 | 19:32 |
opendevreview | Merged openstack/ironic-inspector bugfix/10.9: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867856 | 19:32 |
opendevreview | Merged openstack/ironic-inspector bugfix/11.0: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867853 | 19:32 |
opendevreview | Merged openstack/ironic-inspector stable/yoga: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867855 | 19:32 |
opendevreview | Merged openstack/ironic-inspector stable/xena: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867857 | 19:32 |
stuartgr_ | I'll create a bug about this tomorrow - going home now | 19:34 |
opendevreview | Merged openstack/ironic-inspector stable/ussuri: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867861 | 19:34 |
opendevreview | Merged openstack/ironic-inspector stable/victoria: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867860 | 19:34 |
opendevreview | Merged openstack/ironic-inspector stable/wallaby: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867859 | 19:34 |
opendevreview | Merged openstack/ironic-inspector stable/train: [stable-only] Fixes for tox 4.0 compatability https://review.opendev.org/c/openstack/ironic-inspector/+/867862 | 19:34 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/zed: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867881 | 19:38 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/9.0: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867882 | 19:38 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/8.6: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867883 | 19:38 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867884 | 19:39 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/8.3: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867885 | 19:39 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/xena: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867886 | 19:39 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/8.1: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867887 | 19:40 |
jrosser | stuartgr_: could you add anything you think i've missed to https://storyboard.openstack.org/#!/story/2010473 | 19:40 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/8.1: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867887 | 19:40 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/wallaby: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867888 | 19:41 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/wallaby: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867888 | 19:41 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/victoria: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867889 | 19:41 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/victoria: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867889 | 19:42 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/ussuri: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867910 | 19:43 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/train: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867911 | 19:43 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/train: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867911 | 19:44 |
JayF | iurygregory: TheJulia: be a little more review-y when looking at the IPA fixes; there were conflicts at almost every step of the backport | 19:45 |
TheJulia | ack, joy | 19:45 |
JayF | I think they're all fine? | 19:45 |
JayF | Worst case will be I missed a random usedevelop= and the behavior will be funky in tox 4.0 (but not broken, just like, that will be ignored as a command) | 19:45 |
JayF | I think every one I posted has been backported thru; except the virtualbmc and inspector client changes which are failing CI | 19:47 |
JayF | virtualbmc looks like a breakage from the ubuntu version change, probably just needs a fix->bindep.txt or something | 19:47 |
JayF | inspector client is much, much more ominous given recent changes we landed (deadlocks in sqlite db in integration tests) | 19:47 |
JayF | after my noon meeting and a short break I'll ensure there are no others to backport then probably get in on trying to get virtualbmc gate happy | 19:48 |
iurygregory | JayF, ack | 19:53 |
JayF | well, ipa ussuri just failed so I'll have to followup on that | 19:54 |
JayF | I think I may be setting a personal record for most patches posted+landed in one day | 19:54 |
JayF | lol | 19:54 |
iurygregory | lol | 19:54 |
JayF | tox changes not needing to go thru devstack-based jobs is very helpful | 19:54 |
opendevreview | Merged openstack/ironic-python-agent master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867835 | 19:56 |
opendevreview | Merged openstack/ironic-python-agent stable/yoga: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867884 | 19:56 |
opendevreview | Merged openstack/ironic-python-agent bugfix/9.0: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867882 | 19:58 |
opendevreview | Merged openstack/ironic-python-agent stable/zed: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867881 | 19:58 |
opendevreview | Merged openstack/ironic-python-agent stable/xena: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867886 | 19:58 |
opendevreview | Merged openstack/ironic bugfix/19.0: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867866 | 20:05 |
opendevreview | Merged openstack/ironic-python-agent stable/wallaby: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867888 | 20:06 |
opendevreview | Merged openstack/ironic bugfix/18.1: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867868 | 20:08 |
opendevreview | Merged openstack/ironic bugfix/21.0: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic/+/867863 | 20:11 |
opendevreview | Merged openstack/ironic-inspector bugfix/11.2: Update .gitreview for bugfix/11.2 https://review.opendev.org/c/openstack/ironic-inspector/+/867825 | 20:11 |
*** dking is now known as Guest2270 | 21:08 | |
Guest2270 | Does anybody know the best way to find a list of commits that one has contributed to OpenStack? | 21:18 |
JayF | Guest2270: Hey, I think you lost your nickname friend :D | 21:21 |
JayF | Guest2270: there are a few ways; stackalytics.io used to be the preferred suggestion, but it hasn't been updated in a while | 21:21 |
JayF | there's a new foundation-sponsored git stats site (or just use github.com/openstack/ironic or whatever repos you care about and use the github tooling) | 21:21 |
JayF | But generally speaking; upstream strongly discourages number of commits or lines of code as a KPI | 21:22 |
JayF | instead we prefer patchsets or reviews which can reflect engagement in the project without tying that contribution to a net-new patch | 21:22 |
Guest2270 | yeah, my nick seems to still keep slipping off on this network. I need to get that fixed, but I've been lazy. | 21:23 |
JayF | likely you, or someone else, registered it | 21:24 |
JayF | and you keep getting kicked off it for not identifying | 21:24 |
JayF | you can do `/nick dking_` or similar if you want a temp one that won't go away :) | 21:24 |
Guest2270 | Yeah, I tried stackalytics, but as you said, it's out of date. I was just wanting to look at some of the updates for my own benefit. It's been a while since I've been able to push upstream. | 21:25 |
JayF | Yeah; I've been struggling with that with my PTL hat on | 21:25 |
*** Guest2270 is now known as dking_tmp | 21:25 | |
JayF | because I am supposed to review review stats | 21:25 |
JayF | but there's no real working place to get it until/unless I want to write a whole gerrit stats API client on my own :| | 21:25 |
JayF | https://openstack.biterg.io/app/kibana#/dashboard/Overview is the new, actually-supported stats place | 21:26 |
JayF | but it only gets data currently, I think, from git/mailing lists | 21:26 |
JayF | so it doesn't contain reviews which is why I don't use it frequently | 21:26 |
dking_tmp | I got spoiled by stackalytics. It never felt official, but it was nice, and I assumed it would always just be there. | 21:26 |
JayF | It was good and bad. | 21:27 |
dking_tmp | That's pretty neat. That looks a bit like Kibana? | 21:27 |
JayF | Back in the heyday of openstack, too many people were relying on metrics from stackalytics to manage employees at some places | 21:27 |
JayF | which led to weird stuff e.g. people "reviewing" using a spell checker just so they could get stats up | 21:28 |
dking_tmp | Crazy. | 21:31 |
dking_tmp | I really like that site. I'm a fan of Kibana. | 21:36 |
TheJulia | soooo many people using spell checkers | 21:42 |
TheJulia | my favorite was different dialect spellings | 21:42 |
JayF | So I recently had a blogpost published on my employers' blog (https://www.gresearch.co.uk/news) and it tripped me out the first time I read it | 21:48 |
JayF | because it was editing into british spelling | 21:48 |
JayF | NobodyCam: I miss your morning hellos in here, fwiw | 21:51 |
TheJulia | +1000000000 | 21:52 |
NobodyCam | Humm I may be able to encouraged to pick that back up ;) | 22:54 |
NobodyCam | We’ll give it a shot tomorrow and see how it goes | 22:54 |
JayF | I'm about to go live on my office hours in ~3 minutes at https://youtube.com/jayofdoom | 22:58 |
JayF | will probably be taking inventory of how many of those tox patches are left lol | 22:58 |
NobodyCam | Oh | 22:58 |
JayF | you should come by in the mornings and say hi again anyway :) | 22:58 |
JayF | it's nice to have more folks chatting in the channel | 22:58 |
JayF | we love you even if you don't have time to contribute, lol | 22:58 |
NobodyCam | LoL | 22:59 |
opendevreview | Jay Faulkner proposed openstack/virtualbmc master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/virtualbmc/+/867843 | 23:12 |
JayF | TheJulia: IDR if I showed you this; https://zuul.opendev.org/t/openstack/build/5beeaacf1161489e84a489b45f31bc6c | 23:32 |
JayF | TheJulia: during python-ironic-inspector-client functional tests > sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) database is locked | 23:32 |
JayF | Which implies to me our inspector sqla2.0 fixes are not complete | 23:32 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/8.6: Drop python2 from bindep.txt https://review.opendev.org/c/openstack/ironic-python-agent/+/867915 | 23:44 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/8.6: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867883 | 23:44 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/8.3: Drop python2 from bindep.txt https://review.opendev.org/c/openstack/ironic-python-agent/+/867916 | 23:45 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent bugfix/8.3: Fixes for tox 4.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/867885 | 23:45 |
* JayF puts https://review.opendev.org/c/openstack/ironic-inspector/+/860731 as a depends-on for that client test | 23:50 | |
opendevreview | Jay Faulkner proposed openstack/python-ironic-inspector-client master: Fixes for tox 4.0 https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/867842 | 23:51 |
NobodyCam | Nice office hours JayF | 23:58 |
JayF | lurking is not allowed, you gotta say hi in yt chat too :P | 23:59 |
JayF | seriously, I'll take any feedback if you have it, I've done maybe a dozen of those at this point | 23:59 |
NobodyCam | LoL that means I would have to sign in | 23:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!