Wednesday, 2023-01-04

opendevreviewJulia Kreger proposed openstack/ironic master: Use centos grub artifacts with centos ramdisk for vmedia  https://review.opendev.org/c/openstack/ironic/+/86910300:42
opendevreviewJulia Kreger proposed openstack/ironic master: Fix grub config path default  https://review.opendev.org/c/openstack/ironic/+/86913400:42
TheJuliaokay, lets see if *that* works00:42
TheJuliastevebaker[m]: you were right, it is environmental00:42
* TheJulia wishes grub would printf "couldn't find my config"00:43
stevebaker[m]oh yeah, I'm surprised ubuntu EFI assets ever worked in centos00:46
TheJuliawe wrote a half baked config that did work00:47
TheJuliaand the code always dropped in the ubuntu location00:47
TheJuliawith ubuntu artifacts00:47
opendevreviewJulia Kreger proposed openstack/ironic master: Use centos grub artifacts with centos ramdisk for vmedia  https://review.opendev.org/c/openstack/ironic/+/86910301:05
opendevreviewVerification of a change to openstack/ironic master failed: Temporarily mark redfish vmedia as non-voting  https://review.opendev.org/c/openstack/ironic/+/86910701:11
opendevreviewMerged openstack/ironic-python-agent master: Remove old, unused proxy.sh file  https://review.opendev.org/c/openstack/ironic-python-agent/+/86910501:19
TheJuliaipa-centos9-master.tar.gz2023-01-04 01:28393M 01:38
opendevreviewJulia Kreger proposed openstack/ironic master: CI: Reset VM footprint to 2.6GB  https://review.opendev.org/c/openstack/ironic/+/86913601:44
rpittaugood morning ironic! o/08:52
rpittauTheJulia, JayF, iurygregory, stevebaker[m], can you please have a look at https://review.opendev.org/c/openstack/ironic/+/868521 when you have a moment? besides being a very subtle issue we need that to unlock bifrost CI08:56
rpittaualso looking for final approval for https://review.opendev.org/c/openstack/ironic/+/86908409:04
zigoHi there! Can someone help me solve https://bugs.debian.org/1026524 ?09:10
rpittauzigo: hi! is that with inspector master ?09:10
zigorpittau: That's with stable/zed09:11
zigo(which hopefully will be part of Debian Bookworm if we solve this bug)09:11
rpittauok, I'll have a look in a minute09:12
zigoThanks !09:12
zigoIMO, that's probably an issue with the newer python3-cryptography package that has changed in Debian Unstable.09:13
rpittauI'm having issues with another lib at the moment09:25
opendevreviewMark Goddard proposed openstack/networking-generic-switch master: Document ngs_trunk_ports and ngs_physical_networks  https://review.opendev.org/c/openstack/networking-generic-switch/+/86831309:37
rpittauzigo: I was able to reproduce the issue, now let's see if I can confirm the root cause09:53
zigogr8 !09:54
opendevreviewRiccardo Pittau proposed openstack/ironic stable/zed: Fix CI  https://review.opendev.org/c/openstack/ironic/+/86878910:06
rpittauzigo: doesn't look like something related to cryptography, I'm seeing the same issue on master10:28
zigoOh, ok.10:29
opendevreviewMerged openstack/ironic-python-agent-builder stable/yoga: Remove /var/tmp/* from images  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/86912010:31
rpittauzigo: is it possible to get the exact python version used, I suspect a change in most recent python versions that broke (or fixed?!?) threading, it works fine in python 3.9 for example10:41
zigorpittau: Python 3.11.10:41
zigoCurrently, 3.11.1 in Debian Unstable.10:42
rpittauzigo: I confirm it does NOT work with python 3.11.1 and 3.10.9, it works with python 3.9.16 and 3.10.6, so there's been some change in threading recently that's causing the issue10:51
zigoOh, good to know!10:57
opendevreviewMerged openstack/networking-generic-switch master: Remove lib/neutron-legacy leftovers  https://review.opendev.org/c/openstack/networking-generic-switch/+/86819310:59
rpittauzigo: we're not directly using threading, we rely on oslo_concurrency lockutils module, maybe the oslo guys will be able to get a better understanding of what's going on11:01
zigorpittau: Oh, so you believe it's something to be fixed in oslo.concurrency then?11:01
rpittaumaybe11:02
rpittauanother possibility, now that I see it, is that the hack we were using for the release_lock function does not work anymore and we'll have to finally  deal with that :/11:13
iurygregorygood morning Ironic11:29
iurygregoryrpittau, https://review.opendev.org/c/openstack/ironic/+/868521 lgtm, just wondering if we could add a unit test, but I'm ok with it so I've +2 11:31
opendevreviewRiccardo Pittau proposed openstack/ironic master: Fix selinux context of published image hardlink  https://review.opendev.org/c/openstack/ironic/+/86852111:51
rpittauiurygregory: added the check to current unit tests ^11:52
iurygregoryrpittau, tyvm!11:53
opendevreviewStephen Finucane proposed openstack/ironic master: setup.py: Remove 'py_modules'  https://review.opendev.org/c/openstack/ironic/+/86919712:02
opendevreviewStephen Finucane proposed openstack/ironic-inspector master: setup.py: Remove 'py_modules'  https://review.opendev.org/c/openstack/ironic-inspector/+/86919812:05
iurygregoryinteresting... rpittau fyi ^12:12
iurygregoryI love the fact zuul already failed lol (*joke*)12:13
rpittauyep, saw that12:13
rpittaujust curious to understand if pbr does not use auto discovery how come the py_modules workaround works12:19
opendevreviewOleksandr Kozachenko proposed openstack/networking-generic-switch master: Add ArubaOS-CX switch support  https://review.opendev.org/c/openstack/networking-generic-switch/+/86859813:18
*** mraineri_ is now known as mraineri14:02
opendevreviewOleksandr Kozachenko proposed openstack/networking-generic-switch master: Add ArubaOS-CX switch support  https://review.opendev.org/c/openstack/networking-generic-switch/+/86859814:02
TheJuliagood morning14:09
TheJuliarpittau: question for you posted to https://review.opendev.org/c/openstack/ironic/+/86852114:12
zigorpittau: If I do:14:13
zigo            if isinstance(node_info._lock, type(threading.Lock())):14:13
zigo                if node_info._lock.is_locked():14:13
zigo                    node_info.release_lock()14:13
zigoThen the only errors I get are:14:13
zigoAssertionError: Expected 'release_lock' to be called once. Called 0 times.14:13
zigo(patching ironic_inspector/node_cache.py in release_lock() )14:14
zigoDoes this help?14:14
rpittauzigo: I'm trying different things, also something similar to that, I'm not sure what changed14:15
rpittauTheJulia: ack14:15
rpittauTheJulia: not sure we want to fall back to the copy, the hardlink would've been created at that point, unless we unlink it?14:19
TheJuliaI think we ought to14:20
TheJuliaI mean...14:20
TheJuliaI guess I feel like we've discovered a situation where we know it will fail14:20
TheJuliawe're just going to log it presently, which seems... bad14:20
TheJuliawe should really just be ensuring that the end goal is reached for the user14:20
TheJulia... Since not everyone will have logging access14:20
TheJuliaAt least, that is the internal conflict dialog going on in my head14:21
rpittauit could fail just because restorecon does not exist, but between handling that case or just fall back to copy, maybe the latter is safer14:22
TheJuliawell, and restorecon *should* raise OSError if not already caught14:23
TheJuliathe challenge here is if it is after the link14:23
TheJuliabecause copying over a link...14:23
* TheJulia wonders if that replaces the file...14:23
* TheJulia files the momentary thought under "unknown behavior"14:23
rpittausafer to unlink and raise oserror14:23
TheJuliayeah, if it fails.14:24
TheJuliaThe other thing is maybe we should be doing that *anyway* afterwards14:24
* zigo is preparing to file a CVE over a symlink attack... :)14:24
TheJuliaalso... it occurs to me that elevated privs are needed to run restorecon14:25
zigoNote: I have no clue what you're discussing, just trying to be funny ...14:25
TheJuliazigo: I figured :)14:25
rpittauzigo: sounds like something coming out from an anime, "symlink attack!"14:25
* TheJulia suddenly wonders if she is in a world where a giant robot is about to appear14:26
rpittauTheJulia: I think in our case we can run it as the dir belongs to the ironic user14:26
TheJuliahmm, yeah that should be the right way, but some people try shared group access14:27
TheJuliadunno14:27
TheJuliathere are too many ways to configure it!14:27
rpittau:D14:27
rpittaulet me handle the fallback first14:28
opendevreviewRiccardo Pittau proposed openstack/ironic master: Fix selinux context of published image hardlink  https://review.opendev.org/c/openstack/ironic/+/86852114:33
TheJuliaso https://review.opendev.org/c/openstack/ironic/+/869107 can now be abandoned if we can merge https://review.opendev.org/c/openstack/ironic/+/86910314:35
rpittauyep14:36
rpittauoh forgot to vote there :D14:36
rpittauiurygregory: when you have a minute can you please check https://review.opendev.org/c/openstack/ironic/+/869084 ?14:46
iurygregoryrpittau, sure14:47
rpittauthanks14:47
* TheJulia pokes tox14:54
TheJuliathere it goes14:56
* TheJulia wonders if a faster computer is needed now14:56
slaweqHi Ironic cores, can You review https://review.opendev.org/c/openstack/ironic/+/868191 ? Thx in advance14:57
TheJulia+2'ed, it likely won't pass until we get another fix merged first14:58
TheJuliaso holding off on workflow14:58
TheJuliaiurygregory: a quick review on https://review.opendev.org/c/openstack/ironic/+/869103 would also be appreicated which should allow us to un-wedge the ironic gate15:01
TheJuliaalso rpittau wrt ^^ that highlights a bug I'm working on fixing which is the possibility of vendor differences and the need to set it on at least per-node15:01
rpittauTheJulia: ack15:03
opendevreviewJulia Kreger proposed openstack/ironic master: Fix grub config path default  https://review.opendev.org/c/openstack/ironic/+/86913415:33
opendevreviewJulia Kreger proposed openstack/ironic master: Permit node level override of Grub ESP config path  https://review.opendev.org/c/openstack/ironic/+/86923015:33
TheJuliarpittau: you can single core approve https://review.opendev.org/c/openstack/ironic/+/867228 as it is doc only15:36
JayFThere's an email on ML saying to not set py_modules=[] in the setup.py file15:51
JayFI'm pretty sure we already did that...15:51
opendevreviewJulia Kreger proposed openstack/ironic master: [DOC] Add entry regarding cleaning+raid  https://review.opendev.org/c/openstack/ironic/+/86767415:53
JayFhttps://github.com/openstack/ironic/blob/master/setup.py#L21 + https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031658.html = :( 15:58
rpittauJayF: we did it in some places as workaround for an issue on unit tests16:02
JayFAccording to that post; it means you wouldn't be able to import ironic code16:04
JayFI don't have another source for that, but we need to make sure we revert when the pbr fixes go.16:04
rpittauJayF: weird, we put that in place because we were not able to import any module from ironic :)16:06
JayFLOL16:06
JayFI don't know the actual answer; but if that post is wrong we should reply16:06
JayFif it's right, we should revert when PBR is fixed16:06
JayFif it's a grey area then just spin around three times :P 16:07
* rpittau spin around three times16:07
JayFwhoa; now we're both dizzy! lol16:07
rpittauI sure am16:07
rpittauneed to leave now, let's wait for the pbr fix, I'll have a deeper look tomorrow if nothing has changed yet16:08
rpittauhave a great rest of the day o/16:08
JayFI might push up the revert change just to see how CI likes it16:08
JayFbut I won't land or pursue landing it until we know what's actually up16:08
* TheJulia worries we'll need whiskey or something before the week is out16:08
JayFI'm lucky in that at least I have a short day. I have live TV to attend! 16:09
JayF(wrestling event, and it's live on the east coast so it starts @ 4pm local)16:09
TheJuliaenjoy16:09
opendevreviewJay Faulkner proposed openstack/ironic master: Temporarily mark redfish vmedia as non-voting  https://review.opendev.org/c/openstack/ironic/+/86910716:10
opendevreviewMerged openstack/ironic-python-agent master: modify error word node  https://review.opendev.org/c/openstack/ironic-python-agent/+/86866916:12
opendevreviewMerged openstack/ironic master: Create IRONIC_VM_MACS_CSV_FILE if it does not exist  https://review.opendev.org/c/openstack/ironic/+/86908416:16
opendevreviewMerged openstack/ironic master: Add doc for lsblk: /dev/nvme0n1p2: not a block device  https://review.opendev.org/c/openstack/ironic/+/86722816:17
TheJuliaJayF: we don't need to move it to Non-voting, fixing shim worked16:17
JayFthat already landed? wow16:17
TheJulianot quiet yet, but 1x+2 and passed like a charm16:18
JayFmine or someone elses'?16:25
JayFdo I need to +2a? 16:25
TheJuliasomeone else's16:26
TheJuliayou can +2+a if you like16:26
TheJuliaThere are a couple follow-up patches upon my realization that "this is broken"16:26
TheJuliaone also fixes doc16:27
sschmittThis one is really out of left field, but has anyone ever tried integrating the ovn-bgpagent stuff with switches running EVPN-VXLAN for multi-tenant baremetal networking16:29
TheJuliasschmitt: out of the left star system... I think16:30
JayFI know some of those words ;) 16:30
sschmittsomeone's gotta ask the hard questions ;)16:30
TheJuliasshnaidm: afaik no, I'm assuming some glue or integration might be needd there16:30
TheJuliasince our docs say "use vlans", you can use vxlans if the switch/ml2 driver supports it16:30
JayFWe used vxlan managed by nicera for a time at one environment I worked in; but only in some special cases16:31
TheJuliathe switch becoming a router there with bgp integration.... and it doing the forwarding, *mindblown*16:31
JayFand IIRC none of that glue code was ever open source (and tbh it wasn't that good of a system either...)16:31
JayFTheJulia: yep, exactly. terminate vxlan at switch; expose vlans to endpoint16:31
TheJuliasschmitt: of course, it might just work, dunno16:31
JayFI bet you need a lot of glue to make it work16:31
JayFbut not anything significant16:32
sschmittthats what I was thinking16:32
TheJuliaI think the key is if the bgp agent talks to the switch directly in the vxlan native terms16:32
TheJuliathen things should go fairly cleanly, but yeah16:32
TheJuliadunno16:32
TheJuliasschmitt: so it occurs to me that networking-baremetal will not trigger on vxlan ports... but that might be okay16:42
sschmittWe actually have tested with a small change to that and it works16:43
TheJuliaoh good16:43
TheJuliafeel free to post it :)16:43
opendevreviewJulia Kreger proposed openstack/networking-generic-switch stable/yoga: Fix CI  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787416:46
TheJuliahmm, that wet stuff is falling from the sky again16:48
opendevreviewRiccardo Pittau proposed openstack/ironic master: Fix selinux context of published image hardlink  https://review.opendev.org/c/openstack/ironic/+/86852117:02
opendevreviewVerification of a change to openstack/ironic master failed: Use centos grub artifacts with centos ramdisk for vmedia  https://review.opendev.org/c/openstack/ironic/+/86910317:13
TheJuliaugh17:13
TheJuliaUGH17:13
JayFNo nasty opcode errors at least 17:22
JayF:\17:22
opendevreviewMerged openstack/sushy master: Fix exceeding retries  https://review.opendev.org/c/openstack/sushy/+/86767517:24
TheJuliawell, yeah17:38
TheJuliahttps://www.irccloud.com/pastebin/oPGlfVfF/17:38
TheJuliathat is a boot to ISO image file over http. EFI firmware said "nope!"17:40
TheJulialets hope it is transient17:40
opendevreviewVerification of a change to openstack/ironic master failed: Use centos grub artifacts with centos ramdisk for vmedia  https://review.opendev.org/c/openstack/ironic/+/86910317:44
JayFTheJulia: from your lips to zuul's ears :|17:44
JayFoh, that's the bad notification again17:45
JayFwhere ARM64 runs, doesn't change V+ vote, and notifies us again17:45
JayFthat dang bug fools me everytime :) 17:45
* TheJulia thinks it is time for another cup of coffee and then to jump back into metrics...17:48
JayFyeah, I'm looking at hardware enablement track chair stuff (it's me, arne, and dmitry) then I need to pick up on my shards work17:49
opendevreviewMerged openstack/ironic-inspector master: SQLAlchemy 2.0 Support  https://review.opendev.org/c/openstack/ironic-inspector/+/86073117:54
* TheJulia dances17:59
opendevreviewMerged openstack/networking-generic-switch master: Introduce new option ngs_save_configuration  https://review.opendev.org/c/openstack/networking-generic-switch/+/86831418:48
opendevreviewVerification of a change to openstack/networking-generic-switch master failed: Document ngs_trunk_ports and ngs_physical_networks  https://review.opendev.org/c/openstack/networking-generic-switch/+/86831318:48
JayFTheJulia: https://octodon.social/@nivex/10963246696191591219:15
JayFTheJulia: I think that's another instance of our bug; I already replied to him19:15
JayF(he's an old acquaintance from back in NC; you may have run into them as well)19:16
TheJuliaeh, we... do that all the time19:17
TheJuliabut that does seem weird19:17
JayFI'm saying, I think that's an instance of invalid opcode19:18
JayFjust that ipxe is swallowing it and returning a slightly different err19:18
JayFhttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug=102059419:18
TheJuliawell, the opcode fail we've seen is a cpu halting fault19:19
TheJuliawhich I don't think ipxe would consume19:19
JayFUnless ipxe was doing some kind of validation19:19
JayFwhich is possible but much less likely19:19
TheJuliaI bet that might be what they are hitting19:19
TheJuliahmm19:19
JayFhttps://ipxe.org/err/2e008019:20
TheJuliaurl is not accessible19:20
JayFTheJulia: use the debian link I put in here; he screwed up the link in the social post19:20
TheJuliaI did from the bug report19:21
TheJuliait is the artifact he linked to19:21
JayFoh; that's almost 10000% private on his network19:21
TheJuliathere is really no way to work that without being able to reproduce it and also see what the compiled option flags are in ipxe19:21
JayFint.home.nivex.net19:21
TheJuliayeah19:21
JayFI mean, I buy it's likely unrelated now19:21
JayFbut I wanted to check and see19:21
TheJuliayeah19:22
TheJuliaand you know... the opcode we got was from grub19:22
TheJulianot ipxe19:22
TheJuliabut grub doesn't handle hard failures very well19:22
TheJulia... partly by design where as ipxe has a bunch of fallback logic19:23
opendevreviewMerged openstack/ironic master: Use centos grub artifacts with centos ramdisk for vmedia  https://review.opendev.org/c/openstack/ironic/+/86910320:31
JayF\o/20:46
JayFGate is unblocked!20:46
TheJuliawoot20:55
opendevreviewMerged openstack/sushy master: Fix volume deletion on newer iDRACs  https://review.opendev.org/c/openstack/sushy/+/86484521:41
TheJuliawheee time for a new devstack machine22:02
opendevreviewJulia Kreger proposed openstack/ironic master: WIP: Get conductor metric data  https://review.opendev.org/c/openstack/ironic/+/86544722:30

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!