| arne_wiebalck | Good morning, Ironic! | 07:20 |
|---|---|---|
| opendevreview | Merged openstack/bifrost master: Use curl to download deploy image if get_url fails https://review.opendev.org/c/openstack/bifrost/+/868387 | 07:55 |
| opendevreview | Bartosz Bezak proposed openstack/bifrost stable/zed: Create /run/ironic runtime directory when service starts https://review.opendev.org/c/openstack/bifrost/+/871030 | 07:59 |
| opendevreview | Bartosz Bezak proposed openstack/bifrost stable/yoga: Create /run/ironic runtime directory when service starts https://review.opendev.org/c/openstack/bifrost/+/871031 | 07:59 |
| rpittau | good morning ironic! o/ | 08:25 |
| rpittau | dtantsur: we finally got logs from kubelet in metal3-ci integration job! It's failed but at least we can see what went wrong :D | 08:39 |
| kubajj | dtantsur: How would you go about testing the store_ and get_introspection_data (https://review.opendev.org/c/openstack/ironic/+/870799/4/ironic/drivers/modules/inspect_utils.py#61) I guess these need to be just functional (using the api)? What should be the next step? | 09:07 |
| kubajj | Good morning arne_wiebalck, rpittau, and Ironic! | 09:08 |
| rpittau | hey kubajj :) | 09:08 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/zed: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871032 | 09:25 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/21.0: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871033 | 09:25 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/20.2: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871052 | 09:29 |
| opendevreview | Vincent proposed openstack/bifrost master: Feature: Enable user_data's file generation https://review.opendev.org/c/openstack/bifrost/+/870017 | 09:29 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/yoga: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871053 | 09:30 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/19.0: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871038 | 09:31 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/xena: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871039 | 09:31 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/18.1: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871040 | 09:31 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost stable/zed: Fix CI https://review.opendev.org/c/openstack/bifrost/+/871041 | 09:37 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost stable/yoga: Fix CI https://review.opendev.org/c/openstack/bifrost/+/871042 | 09:37 |
| opendevreview | Vincent proposed openstack/bifrost master: Feature: Enable user_data's file generation https://review.opendev.org/c/openstack/bifrost/+/870017 | 09:38 |
| opendevreview | Vincent proposed openstack/bifrost master: Feature: Enable user_data's file generation https://review.opendev.org/c/openstack/bifrost/+/870017 | 09:43 |
| opendevreview | Vincent proposed openstack/bifrost master: Feature: Enable user_data's file generation https://review.opendev.org/c/openstack/bifrost/+/870017 | 09:43 |
| opendevreview | Vincent proposed openstack/bifrost master: Feature: Enable user_data's file generation https://review.opendev.org/c/openstack/bifrost/+/870017 | 09:50 |
| opendevreview | Vincent proposed openstack/bifrost master: Feature: Enable user_data's file generation https://review.opendev.org/c/openstack/bifrost/+/870017 | 09:51 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-python-agent bugfix/8.0: Update .gitreview for bugfix/8.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/871061 | 09:51 |
| opendevreview | Merged openstack/ironic master: CI: Fix race prone unit test in networking https://review.opendev.org/c/openstack/ironic/+/870995 | 10:09 |
| samuelkunkel[m] | Good morning | 10:32 |
| samuelkunkel[m] | rpittau: short question regarding https://review.opendev.org/c/openstack/sushy/+/870888, (its a bug in requests and I have added the workaround), how/where can I add a release note? | 10:33 |
| dtantsur | kubajj: I've move most of the testing to test_inspect_utils to be honest. That's where all variants of storage and retrieving (swift, db, disabled) should be exercised | 10:50 |
| dtantsur | the tests for inspector and API should probably mock the calls and just check they are done with the right arguments | 10:50 |
| kubajj | dtantsur: so should I mock the API/import the API base test class to inspect utils test for the get_introspection_data? | 11:00 |
| dtantsur | kubajj: I don't think you should touch the API there anyhow, just test the functions directly | 11:01 |
| kubajj | dtantsur: I'll look into it. I might be just confused as I haven't looked into it in a while. | 11:03 |
| iurygregory | good morning Ironic | 11:46 |
| rpittau | samuelkunkel[m]: you need to use reno https://docs.openstack.org/reno/latest/ | 13:02 |
| kubajj | dtantsur: I should remove it from store_introspection_data, right? (https://review.opendev.org/c/openstack/ironic/+/870799/comments/c0a09469_3d24f9f6) | 13:08 |
| kubajj | dtantsur: or do we want to duplicate it so that store_introspection_data covers all the cases? | 13:16 |
| dtantsur | kubajj: I'd do the latter | 13:17 |
| kubajj | Ok | 13:18 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/21.0: Pin tox to version lower than 4 https://review.opendev.org/c/openstack/ironic/+/871097 | 13:56 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/yoga: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871053 | 14:00 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/xena: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871039 | 14:02 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/19.0: Pin tox to version lower than 4 https://review.opendev.org/c/openstack/ironic/+/871098 | 14:06 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/18.1: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871040 | 14:09 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/20.2: Pin tox to version lower than 4 https://review.opendev.org/c/openstack/ironic/+/871099 | 14:12 |
| TheJulia | good morning | 14:13 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Reorganise Inventory Storage https://review.opendev.org/c/openstack/ironic/+/870799 | 15:20 |
| kubajj | TheJulia: good morning | 15:21 |
| kubajj | dtantsur: I have a quick question about the get_introspection_data. I am passing it the api and in 'database' case, I need to access api.request.context. Can I mock the api somehow? | 15:22 |
| dtantsur | kubajj: I think we have way to create a fake context, look in other unit tests | 15:23 |
| * dtantsur is on a wall of meetings now | 15:23 | |
| TheJulia | we do | 15:35 |
| TheJulia | *but* most of the time if memroy serves we just hand it a mock object if memory serves | 15:35 |
| TheJulia | memory | 15:35 |
| TheJulia | or set it to None | 15:35 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Reorganise Inventory Storage https://review.opendev.org/c/openstack/ironic/+/870799 | 15:39 |
| kubajj | TheJulia: I slightly modified the function call so it accepts just context and not the whole api. I you have any suggestions and have a minute, feedback would be appreciated. ^ | 15:40 |
| TheJulia | kubajj: I will try to take a look soon, I've got a meeting and I'm rescheduling some meetings | 15:55 |
| kubajj | TheJulia: thanks | 15:56 |
| rpittau | good night! o/ | 16:34 |
| TheJulia | kubajj: I think all you need is likely dmitry's suggestion on if the store == 'none' | 17:13 |
| TheJulia | or to be more precise if it does not == none | 17:14 |
| kubajj | TheJulia: I think I already have it https://review.opendev.org/c/openstack/ironic/+/870799/6/ironic/drivers/modules/inspector.py#371 | 17:15 |
| TheJulia | oh | 17:16 |
| TheJulia | I see, you did the inverse from what was there | 17:16 |
| TheJulia | I guess, the logical progression in my mind is eventually, we'll conditional off the introspection_client call | 17:16 |
| kubajj | TheJulia: I see. Should I change it now or do we change it once more stuff gets introduced? | 17:25 |
| TheJulia | I'm on the fence at the moment | 17:25 |
| TheJulia | not really sure, I think as is, it works, I just need to look at the tests | 17:26 |
| TheJulia | JayF: still have an issue with the rbac policy in your shards change, which boils down to a question of "do we allow project scoped readers to see /v1/shards at all? | 17:36 |
| JayF | I think the answer is "no" | 17:36 |
| TheJulia | okay, then we need to make it SYSTEM_READER, but we can leave the scope_types field the same to allow operators to change if they feel the need | 17:36 |
| JayF | ack | 17:37 |
| JayF | do you have time to talk about portcontroller stuff? | 17:37 |
| JayF | I have about 20 until my next meeting | 17:37 |
| TheJulia | sure, got a link? | 17:37 |
| JayF | yeah lemme make up a zoom | 17:37 |
| TheJulia | https://review.opendev.org/c/openstack/sushy-tools/+/842266 could use a core reviewer, I took a look and it seemed to be in good shape | 18:27 |
| TheJulia | a core reviewer that is not I or Steve | 18:27 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Docs: Troubleshooting: how to exit clean failed https://review.opendev.org/c/openstack/ironic/+/871129 | 19:35 |
| iurygregory | TheJulia, done =) | 19:58 |
| iurygregory | took some time to review it | 19:58 |
| TheJulia | muchas gracias | 20:06 |
| opendevreview | Tobias Urdin proposed openstack/ironic master: Use new get_rpc_client API from oslo.messaging https://review.opendev.org/c/openstack/ironic/+/871160 | 20:31 |
| opendevreview | Merged openstack/sushy-tools master: Add SecureBoot support to the emulator, all drivers https://review.opendev.org/c/openstack/sushy-tools/+/842266 | 20:53 |
| opendevreview | Tobias Urdin proposed openstack/ironic-inspector master: Use new get_rpc_client API from oslo.messaging https://review.opendev.org/c/openstack/ironic-inspector/+/871183 | 21:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!