| vanou | good morning ironic | 00:01 |
|---|---|---|
| vanou | JayF: I understand situation. I talk it with folks. | 00:01 |
| opendevreview | Merged openstack/ironic-inspector bugfix/10.7: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-inspector/+/871884 | 00:21 |
| opendevreview | OpenStack Proposal Bot proposed openstack/ironic-inspector master: Imported Translations from Zanata https://review.opendev.org/c/openstack/ironic-inspector/+/871918 | 02:18 |
| *** akahat is now known as akahat|ruck | 07:01 | |
| *** akahat|ruck is now known as akahat|rover | 07:01 | |
| rpittau | good morning ironic, happy Friday! o/ | 08:22 |
| rpittau | JayF: I'm going to remove the releasenotes job in all the bugfix branches that we support, it does not make sense to ahve that there | 10:06 |
| kubajj | dtantsur: When introspection is done and inspector stores it in a db, how does ironic get the data now? | 10:12 |
| rpittau | JayF: latest bugfix branches were created in december (ironic 21.2, inspector 11.2, ipa 9.2) but they're not consumed at the moment, at least by RH | 10:14 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/20.2: Remove reno job https://review.opendev.org/c/openstack/ironic/+/871971 | 10:20 |
| opendevreview | Verification of a change to openstack/ironic master failed: Fix grub config path default https://review.opendev.org/c/openstack/ironic/+/869134 | 10:25 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/21.0: Remove reno job https://review.opendev.org/c/openstack/ironic/+/871972 | 10:26 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/19.0: Remove reno job https://review.opendev.org/c/openstack/ironic/+/871973 | 10:30 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-inspector bugfix/11.0: Remove reno job https://review.opendev.org/c/openstack/ironic-inspector/+/871977 | 10:32 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-inspector bugfix/10.9: Remove reno job https://review.opendev.org/c/openstack/ironic-inspector/+/871978 | 10:33 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/9.0: Remove reno job https://review.opendev.org/c/openstack/ironic-python-agent/+/871979 | 10:38 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/8.3: Remove reno job https://review.opendev.org/c/openstack/ironic-python-agent/+/871980 | 10:39 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/8.1: iRemove reno job https://review.opendev.org/c/openstack/ironic-python-agent/+/871981 | 10:40 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/8.1: Remove reno job https://review.opendev.org/c/openstack/ironic-python-agent/+/871981 | 10:40 |
| iurygregory | good morning | 10:53 |
| dtantsur | kubajj: you literally wrote the code to get the data from inspector into ironic :) | 11:25 |
| kubajj | dtantsur: i know, but I'm trying to describe the current state (before the change) in my dissertation to describe the motivation behind the project. | 11:26 |
| dtantsur | yeah, so initially Ironic did not access this data. Now it uses inspector's API. | 11:27 |
| kubajj | dtantsur: but weren't you able to show the data through the baremetal command somehow? | 11:28 |
| dtantsur | kubajj: through the inspector's API and its CLI, yes | 11:42 |
| dtantsur | `baremetal introspection data save` | 11:43 |
| dtantsur | has nothing to do with ironic though | 11:43 |
| kubajj | dtantsur: and so how is the data used ? I thought it could be shown when you do baremetal node show as well | 11:45 |
| dtantsur | no, that was not possible | 11:45 |
| dtantsur | it was directly consumed by operators or used in 3rd party tooling like Metal3 | 11:45 |
| *** tosky_ is now known as tosky | 12:55 | |
| opendevreview | Merged openstack/ironic-specs master: Clarify model; bugfix branches not guaranteed https://review.opendev.org/c/openstack/ironic-specs/+/871535 | 13:11 |
| opendevreview | Merged openstack/ironic-inspector master: Rename NodeInfo._lock to avoid conflict with Mock._lock in tests https://review.opendev.org/c/openstack/ironic-inspector/+/869719 | 13:12 |
| dtantsur | Having bad memory means: trying to remember whether I've actually already announced the SIG meetup on the ML... | 13:45 |
| dtantsur | yep, just 2 weeks ago: https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031744.html | 13:46 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/9.0: Remove reno job and cap tox to version lower than 4 https://review.opendev.org/c/openstack/ironic-python-agent/+/871979 | 13:53 |
| iurygregory | this is what I call a nice Bios Registry URL /redfish/v1/Registries/BiosAttributeRegistryProt0.208.208.0 '-' | 14:01 |
| dtantsur | LOL | 14:02 |
| iurygregory | ZT Hardware... | 14:02 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/8.1: Remove reno job and cap tox to version lower than 4 https://review.opendev.org/c/openstack/ironic-python-agent/+/871981 | 14:03 |
| dtantsur | We have done great job making Redfish full-featured, the next iteration will be making it simpler | 14:03 |
| iurygregory | at least it returns a json uri in the location, and the funny thing is that some people said it returns gzip file... so I think i need to dig a little deeper to see if is because of FW or just another hardware model | 14:04 |
| iurygregory | oh nice it's a gzip "Content-Encoding: gzip" | 14:10 |
| iurygregory | and the url only shows "redfish/v1/Registries/BiosAttributeRegistryProt0.208.208.0.json" \o/ | 14:11 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/8.3: Remove reno job and cap tox to version lower than 4 https://review.opendev.org/c/openstack/ironic-python-agent/+/871980 | 14:14 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-inspector bugfix/11.0: Remove reno job and fix CI https://review.opendev.org/c/openstack/ironic-inspector/+/871977 | 14:18 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-inspector bugfix/10.9: Remove reno job and cap tox to version lower than 4 https://review.opendev.org/c/openstack/ironic-inspector/+/871978 | 14:19 |
| TheJulia | so tired | 15:00 |
| TheJulia | Good morning everyone | 15:00 |
| rpittau | good morning TheJulia :) | 15:02 |
| iurygregory | BIOS attribute registry BiosAttributeRegistryProt0.208.208.0 not available for language en \o/ | 15:09 |
| TheJulia | ugh | 15:09 |
| TheJulia | is there a drinking game for bios attribute registry errors? | 15:09 |
| iurygregory | I would totally buy one :D | 15:10 |
| iurygregory | good morning TheJulia o/ | 15:10 |
| TheJulia | Might be better for there to be a board game instead | 15:12 |
| * TheJulia thinks of the infamous "stackwater" | 15:12 | |
| TheJulia | hey folks, I've got a pending tempest fix that I'd like to get merged which addresses some orphaned test baremetal nodes, but tempest fixes are currently blocked by the anaconda job being wedged slightly. As some of the URLs are offering redirects out of http. https://review.opendev.org/c/openstack/ironic/+/871855 It is just a CI config change, passes as we would expect on the main ironic gate. | 15:21 |
| iurygregory | done =) | 15:36 |
| rpittau | have a great weekend! o/ | 15:41 |
| TheJulia | Thanks! | 15:59 |
| iurygregory | I love the fact that the Registry only has "en-US" in languages and our default is "en" so it gets ignored it seems .-. | 16:10 |
| iurygregory | going to grab some food before digging a bit more on how to fix this .-. | 16:11 |
| TheJulia | https://www.ovhcloud.com/en-ie/public-cloud/metal-instances/ <-- Interesting, although sounds like maybe they went ahead and did snapshot support downstream | 16:58 |
| TheJulia | their ironic repo is no longer public :( | 16:58 |
| TheJulia | I've emailed ttx, he knows them fairly well, maybe they might be willing to upstream it. | 17:14 |
| opendevreview | Merged openstack/ironic master: [CI] Swap anaconda urls https://review.opendev.org/c/openstack/ironic/+/871855 | 17:34 |
| iurygregory | WOW nice | 17:34 |
| TheJulia | I could use a second opinion on https://review.opendev.org/c/openstack/ironic/+/827295/13/releasenotes/notes/bug-1248022-71a6f5e04f30775e.yaml | 17:35 |
| dtantsur | TheJulia: I'd be wary of backporting this at the very least | 17:53 |
| opendevreview | Merged openstack/ironic master: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871862 | 17:53 |
| dtantsur | may confuse operators | 17:53 |
| TheJulia | yeah, I'm not thinking we backport it, tbh | 17:53 |
| dtantsur | have a nice weekend folks o/ | 17:53 |
| TheJulia | since it would introduce an entirely new config section | 17:53 |
| dtantsur | oh yeah true | 17:54 |
| TheJulia | although, optional | 17:54 |
| TheJulia | I'll revise it, label it as a feature, since it seems we're mutually hesitant there too | 17:55 |
| opendevreview | Julia Kreger proposed openstack/ironic master: [DOC] Set cleaning requirement with retirement https://review.opendev.org/c/openstack/ironic/+/871829 | 18:09 |
| JayF | rpittau: those bugfix branches need to be doc'd on the whiteboard then... :( | 18:30 |
| JayF | TheJulia: that change scares me | 18:31 |
| JayF | TheJulia: I've asked john garbutt to look at it too | 18:31 |
| kubajj | TheJulia: about https://review.opendev.org/c/openstack/ironic/+/871394/comments/2b563753_16ebef6b the reason why the exception is just caught and not acted on is that the inventory entry might not even exist. ClientException is raised in both cases when the swift object deletion fails and when the object does not exist in first place. | 18:32 |
| TheJulia | JayF: I was originally afraid, but lesser now when I realized it was only upon actual deletion of the node | 18:32 |
| TheJulia | kubajj: but we can check the exception... | 18:32 |
| kubajj | TheJulia: Just looking at the other comment :) | 18:33 |
| TheJulia | JayF: backport https://review.opendev.org/c/openstack/ironic/+/871862 ? | 18:33 |
| JayF | that's on my list for today | 18:33 |
| JayF | I volunteer offline on Friday mornings so I really don't get upstream until nowish | 18:34 |
| TheJulia | ahh, TIL | 18:34 |
| * JayF doing it now | 18:35 | |
| JayF | yeah, I do home deliveries of food boxes to folks in the area | 18:35 |
| TheJulia | ok | 18:35 |
| JayF | Rackspace, Yahoo, Okta, and now GR have always been cooperative with it which I appreciate | 18:35 |
| TheJulia | abandon the old wf-1'ed patches? | 18:36 |
| JayF | yep, will do it | 18:36 |
| JayF | doing the backport now | 18:36 |
| TheJulia | okay, I'm happy to do the abandoning | 18:36 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/zed: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872040 | 18:36 |
| JayF | if you wanna; feel free, but I can do it | 18:36 |
| JayF | just button mashing | 18:36 |
| JayF | and not urgent button mashing at that lol | 18:36 |
| kubajj | JayF: you worked at Rackspace? | 18:37 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/21.2: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871994 | 18:37 |
| JayF | kubajj: I was the first engineer hired for Rackspace OnMetal; the first ever OpenStack bare metal public cloud | 18:37 |
| JayF | I basically helped architect the agent, cleaning, and many of the things which are boring background items in ironic these days lol | 18:37 |
| JayF | my trick was just surrounding myself with really smart people and doing exactly what they said | 18:38 |
| JayF | :P | 18:38 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/21.0: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871995 | 18:38 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/20.2: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871996 | 18:38 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/yoga: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871997 | 18:38 |
| kubajj | JayF: so all the Rackspace, Inc. in IPA licenses were you. Cool | 18:38 |
| JayF | at Rackspace for like, 8.5? 9-ish years at that | 18:39 |
| JayF | I was on the team that made it all happen | 18:39 |
| JayF | someone built the API client for IPA and the server | 18:39 |
| JayF | and basically I hooked up all of cleanign and hardware managers to it | 18:39 |
| JayF | kubajj: for example https://www.youtube.com/watch?v=2Oi2T2pSGDU | 18:39 |
| JayF | that is what cleaning was when we implemented it downstream at Rackspace, then it turned into what we have today for cleaning | 18:40 |
| JayF | the only real part that came outta it that is obvious is the idea of steps, which has been plastered all over Ironic since | 18:40 |
| JayF | (and yes, Ironic states have gotten MUCH better in 8 years) | 18:40 |
| * JayF still stunned we used to think `state: null` was an OK thing lol | 18:40 | |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/19.0: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871998 | 18:41 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/xena: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871999 | 18:41 |
| JayF | kubajj: so what are your plans after your project is over? Going to stick around here? Are you done with schooling? What? | 18:42 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/18.1: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872000 | 18:42 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/wallaby: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872001 | 18:42 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/victoria: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872002 | 18:42 |
| kubajj | TheJulia: so what you are suggesting is catching just the 404 exceptions in the inspect utils function and raise one about swift entry not being deleted otherwise to avoid orphaning? I think that's reasonable. | 18:43 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/ussuri: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872003 | 18:43 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/train: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872004 | 18:43 |
| TheJulia | kubajj: yeah, I mean if it is a 404, there is nothing there which is okay | 18:43 |
| TheJulia | if and also, we don't log needlessly | 18:43 |
| kubajj | JayF: I will need to finish the exams and then most likely do one more year of uni. (I think I can't do an Ironic related project again though.) But even then I would like to contribute to some extent. I think I got a decent knowledge about ironic since summer :P | 18:45 |
| JayF | kubajj: I'm 100% serious: if you go applying for jobs, get some folks here to write you a rec. Maybe me/ TheJulia / dtantsur | 18:45 |
| TheJulia | ++++++ | 18:45 |
| JayF | kubajj: and you might get recruited in the process lol | 18:45 |
| TheJulia | Also, let us know, we might be able to point you in directions | 18:45 |
| TheJulia | Indeed :) | 18:46 |
| TheJulia | To quote BSG, all these things have happened before | 18:46 |
| * TheJulia hopes people get that reference | 18:47 | |
| kubajj | I will have to have a look when is the right time to apply and also where to apply to. Ngl, RedHat back home does not sound that bad, so any suggestions from TheJulia, dtantsur, or anybody would help I guess :D | 18:47 |
| * TheJulia is not a toaster | 18:47 | |
| JayF | kubajj: I'll also say; you also don't have to limit yourself to ironic, in both events | 18:48 |
| TheJulia | ++ | 18:48 |
| kubajj | TheJulia: what is BSG? Google found just British Society of Gastroenterology and I don't think that's what you meant :D | 18:48 |
| JayF | kubajj: if you could do another openstack project; we can probably help you handover to another service to do your project | 18:48 |
| JayF | kubajj: and/or if you get job hunting, any openstack dev job, most of the knowledge you used here will transfer | 18:48 |
| TheJulia | One of my interns was managing a whole team of developers in Nigeria at one point, then she moved and I think is back in school for her graduate degree | 18:49 |
| JayF | you're all in API/DB code, it's not going to be *that* different across the services | 18:49 |
| * TheJulia is super proud of our interns | 18:49 | |
| TheJulia | kubajj: Battlestar Galactica | 18:49 |
| kubajj | JayF: the problem with the fifth year project is that it needs to be more research based. They want us to produce a max 14 page article that we could publish | 18:49 |
| TheJulia | https://ew.com/recap/battlestar-galactica-recap-all-this-has-happened-and-all-this-will-happen-again/ | 18:50 |
| JayF | Adam MacArthur, who is the Co-authored-by on all those CI fix patches was an intern working on armadaproject.io; he did such a good job we (GR-OSS) hired him part time to keep going | 18:50 |
| JayF | he's great, super smart guy, too junior to avoid my nerd sniping him to regexp ;) | 18:50 |
| JayF | kubajj: ah, so you need something that's been around for about a decade, with an entire corpus of data about it that you could research. Hmmmmmmm | 18:50 |
| JayF | kubajj: I'll note that as a core in OpenStack, I get approximately 2 dozen emails a year asking me to fill out some horrible research survey about openstack (to the point where it's hard for me to believe you couldn't do better) | 18:51 |
| * TheJulia notes there is a larger OpenInfra community as well | 18:53 | |
| * TheJulia also notes one of them is rather... research focused | 18:53 | |
| JayF | what do you know about the larger openinfra community, TheJulia, you're only the [checks notes] chairwoman :P | 18:53 |
| JayF | lol | 18:53 |
| * TheJulia shrugs | 18:54 | |
| JayF | TheJulia: I just like celebrating that you're in charge of stuff \o/ lol | 18:55 |
| JayF | only org I've been a part of where I didn't assume the board was a bunch of stuffy people who have never heard of me ;) | 18:55 |
| JayF | TheJulia: more seriously; the busted Ironic backports are abandoned; you had W-1'd some of the IPA/inspector patches and I think those votes should be removed | 18:56 |
| kubajj | Does anybody know an easy way how to figure out how many tests are in the ironic, ipa and ironic-inspector repos? (I tried to look at zuul, but couldn't find it) | 18:57 |
| JayF | it's in zuul, lemme show you how to get there | 18:58 |
| kubajj | (I'm just trying to show the scale of the ironic repo in my dissertation) | 18:58 |
| JayF | pick a random patch (this process will work on the other repos too); I pick https://review.opendev.org/c/openstack/ironic-python-agent/+/566544 | 18:58 |
| JayF | scroll to the bottom, to the most recent Verified comment by zuul | 18:58 |
| JayF | click on the zuul link to any of the -py3x jobs | 18:58 |
| TheJulia | urge high to order https://www.etsy.com/listing/1359196789/funny-director-mug-for-director-gift-for | 18:59 |
| JayF | hit the logs tab -> job_output.txt | 18:59 |
| JayF | (I suggest RAW) | 18:59 |
| JayF | ^F -> "Ran:" | 18:59 |
| TheJulia | JayF: ack, I was going to pull the votes later but wanted to look at ironic itself first, which you just did so thanks! | 18:59 |
| JayF | which should get you this line -> | 18:59 |
| JayF | > 2023-01-11 14:11:33.530809 | ubuntu-focal | Ran: 836 tests in 7.4270 sec. | 18:59 |
| JayF | a couple notes: | 18:59 |
| JayF | 1) We run some tests conditionally based on environment; so for example in the gate for Ironic this number is higher than it usually is locally (because the gate sets up the mysql tests) | 19:00 |
| JayF | 2) This only covers unit tests; we have a huge number of tempest (full-openstack-integration) tests and some ironic standalone integration tests | 19:00 |
| TheJulia | 2a) Some of those tempest tests are also conditional based upon configuration or environment, as well. | 19:01 |
| kubajj | JayF: that's so smart. I got to the file in the morning, but did not manage to find the number there. | 19:01 |
| JayF | kubajj: it's not smart; it's more like I've had to go find it the long way and kept it bookmarked in my brain ;) | 19:01 |
| JayF | kubajj: remember the timestamp on that yt vid I posted earlier; 8 years ago; I have about a decade of openstacking on you at this point :P -- it's never about smart it's about familiar | 19:01 |
| iurygregory | would be ok to change the logic we have to select the language when trying to get a registry in sushy? https://opendev.org/openstack/sushy/src/branch/master/sushy/resources/registry/message_registry_file.py#L122-L123 I have a problem with a ZT hardware https://paste.opendev.org/show/bYzUsDm8FpBWSqusmJ7S/, sushy selects "en" based on the information it got from the HW, but when trying to retrieve the Bios Registry | 19:02 |
| iurygregory | it will fail, because we won't match "en" with "en-US" ... thoughts? | 19:02 |
| JayF | there's like, an entire blog post to be written on familiarity | 19:02 |
| JayF | iurygregory: I'm not familiar enough with sushy and use cases to give you a real answer; but it's hard for me to imagine you could do worse for a ISO language code parser | 19:03 |
| iurygregory | yeah, the vendor could have just used "en" like in all other resources they had... it would make our life easier :D | 19:04 |
| TheJulia | so wait a second | 19:05 |
| TheJulia | they say "en-US", we auto-lowercase it, but the file is actually housed at "en" ? | 19:05 |
| TheJulia | am I groking this properly? | 19:06 |
| kubajj | TheJulia: while I'm adding the doc-string. Should I add it to the store/get_introspection_data methods? | 19:06 |
| TheJulia | yeah, ideally | 19:07 |
| * JayF <3 docstrings | 19:07 | |
| JayF | if it's an important internal method, or any exported method, put a pydoc on it | 19:07 |
| JayF | the time spent to value provided of a basic docstring is HUGE | 19:07 |
| TheJulia | +++ | 19:07 |
| iurygregory | TheJulia, so we initialize sushy with language="en" https://opendev.org/openstack/sushy/src/branch/master/sushy/main.py#L208 | 19:07 |
| JayF | I used to say a lot working with legacy code; you can identify what the code does by reading it. You can only identify what the code /was supposed to do/ with comments/tickets/etc | 19:08 |
| TheJulia | iurygregory: so if "en" in ZT hardware field ; then use the ZT value? | 19:08 |
| * TheJulia suspects if the bmc uses a different alias, but our launched alias is within it, then maybe that is perfectly okay | 19:09 | |
| iurygregory | so we would check by vendor and add "en-US"? | 19:10 |
| iurygregory | almost like a supermicro problem lol | 19:10 |
| TheJulia | check what the vendor has/offers, and adopt it perhaps? | 19:10 |
| iurygregory | I only have one hardware to test, not even sure if things will change based on new FW... | 19:11 |
| iurygregory | but since is just a language thing it shouldn't cause trouble | 19:11 |
| iurygregory | I could also check the values from Languages for it and use the value https://opendev.org/openstack/sushy/src/branch/master/sushy/main.py#L607 https://opendev.org/openstack/sushy/src/branch/master/sushy/main.py#L611 | 19:12 |
| TheJulia | I mean, defaulting to "us" and finding out the thing only supports en-US, then I feel like we should just pick that and use "en-US" so we pickup and provide back the right registry entries | 19:14 |
| TheJulia | that way we don't change the underlying default, we just make it more capible of handling... oddities. | 19:14 |
| kubajj | TheJulia: is that worthy of its own change, or can I sneak it into the current one (it is still a related change in the chain) | 19:14 |
| TheJulia | kubajj: I would be fine sneaking it in, tbh, since that one is a follow-up to begin with | 19:15 |
| TheJulia | iurygregory: am I making sense? :) | 19:20 |
| kubajj | TheJulia: should I raise again a ClientException or is there any other one that fits it better? | 19:20 |
| TheJulia | I would add a new exception to ironic/common/exceptions.py | 19:20 |
| TheJulia | err, exception.py I think | 19:20 |
| opendevreview | Ghanshyam proposed openstack/ironic stable/wallaby: DNM: testing tempest pin for stable/wallaby https://review.opendev.org/c/openstack/ironic/+/872045 | 19:21 |
| iurygregory | TheJulia, let me grab more coffee XD I'm a bit lost I think, in sushy we are default to "en", the problem is just we don't accept "en-US" because it won't match... | 19:22 |
| TheJulia | Naming... is the hard part. Anyone have exception name ideas for kubajj ? | 19:22 |
| TheJulia | iurygregory: and I'm thinking, we can check to see if our default is in the offered string, and use that instead | 19:22 |
| kubajj | TheJulia: I was thinking SwiftObjectFailedToDelete or something | 19:22 |
| kubajj | but it's quite long | 19:22 |
| iurygregory | TheJulia, oh ok! | 19:22 |
| iurygregory | so just change the "if l.language.lower() == language" | 19:23 |
| JayF | kubajj: SwiftObjectStillExists (if you're catching a failed delete case) | 19:23 |
| TheJulia | or maybe UnableToDeleteOrphanedFile | 19:23 |
| TheJulia | oh, that could work too | 19:23 |
| JayF | Depends on if you want it swift-specific or not | 19:23 |
| TheJulia | the other case I just thought of, and that is harder. if swift is not configured, but I think if that was problematic it would fail in our CI | 19:23 |
| JayF | {Object,File,whatever}StillExists() is a good option too | 19:23 |
| TheJulia | ++ | 19:24 |
| JayF | I try really hard to avoid negatives in exceptions / method names | 19:24 |
| kubajj | TheJulia: but is the file going to become orphaned if we stop node destroy by this exception? | 19:24 |
| JayF | it's usually clearer to state what's going on than to say what isn't | 19:24 |
| kubajj | JayF: yeah, I think that might be better | 19:24 |
| TheJulia | aiui, if we destroy the node, we'll never be able to head down that path again and delete the file | 19:25 |
| TheJulia | ... unless someone recreates the node with the same values... | 19:26 |
| JayF | If we leave an orphaned file, we need to make sure we log that in a conductor log loudly | 19:26 |
| kubajj | TheJulia: but does the node get deleted if we halt the destruction by the exception? | 19:26 |
| JayF | not just API response | 19:26 |
| JayF | kubajj: The better question is: do we want a swift API outage/misconfiguration to prevent deletion of a node | 19:27 |
| JayF | And my hunch is "probably not" in cases where the Ironic install doesn't depend on swift for anything but inspection | 19:27 |
| TheJulia | if not configured, then I don't think we would | 19:28 |
| TheJulia | or should, but if configured, I think we should block node destruction if we're going to orphan a file based upon a transient outage | 19:28 |
| TheJulia | the issue is, few ever look at the logs, and heavily used services logs may be difficult to do cleanup of numerous records after the fact once finally noticed | 19:29 |
| JayF | So today, with an external inspector, what happens in this case? | 19:30 |
| TheJulia | file is orphaned | 19:30 |
| TheJulia | I think | 19:30 |
| TheJulia | but many also just don't use it or store locally instead | 19:30 |
| JayF | ack | 19:31 |
| TheJulia | today you would also just be able to delete the ironic node and an introspection entry would still be inspector | 19:31 |
| JayF | I kinda feel like it might be neeat to have a config option for this behavior | 19:31 |
| JayF | but that's more work and complexity so maybe I'm wrong? | 19:31 |
| TheJulia | I was kind of thinking an option might make sense, default it to be conservative/guarded | 19:32 |
| TheJulia | and then allow operators to do self detrimental things through config options if they *really* want to | 19:32 |
| JayF | Heh, see, I was thinking default it to existing behavior :) | 19:32 |
| TheJulia | with GIANT warnings of DOOM! | 19:33 |
| JayF | there's a reasonable argument to be made on both sides | 19:33 |
| TheJulia | yeah | 19:33 |
| JayF | I think a file orphaned in swift is like, a nothingburger on a scale of things I'd care about as an operator | 19:33 |
| kubajj | While we are talking about exceptions, I think I never catch anything if the inventory I am trying to get from db or swift does not exist 🤔 | 19:33 |
| JayF | and I don't think anyone is going to have swift pointed at a cloud service which would charge them forever for that handful of k | 19:33 |
| TheJulia | I think this is a case where we just encourage kubajj to do what he thinks makes the most sense | 19:33 |
| JayF | +++ | 19:34 |
| JayF | the person doing the work gets a quadrouple vote LOL | 19:34 |
| TheJulia | ++ | 19:34 |
| TheJulia | I personally hate to orphan things, but it is also a fixed container | 19:34 |
| TheJulia | so it is not quite like some of the larger operators who have grumbled about people just orphaning containers full of stuff | 19:35 |
| TheJulia | so the case is also kind of different | 19:35 |
| JayF | If I were doing it I'd: 1) make an option 2) default the option to the improved option to not orphan 3) make loud, loud noises in the inspector migration guide about this (and other) changes in behavior | 19:35 |
| TheJulia | https://review.opendev.org/c/openstack/ironic/+/871994 <-- gah | 19:35 |
| JayF | I assume we have a list of things that'll have to go in that guide, yeah? | 19:36 |
| JayF | TheJulia: I believe bugfix/21.2 was cut and is not being maintained per what rpittau said | 19:36 |
| TheJulia | I think we'll need to start writing it actually | 19:36 |
| JayF | TheJulia: the branch exists, it wasn't listed on any of our etherpads | 19:36 |
| TheJulia | ack | 19:36 |
| JayF | TBH; I'm a little upset that in all the bugfix branch auditing nobody (including me) caught this | 19:37 |
| JayF | no matter how much I try and clean up stuff there's something I missed | 19:37 |
| TheJulia | we're all only human | 19:37 |
| JayF | I should see if my doctor can fix that | 19:38 |
| TheJulia | Upgrade to cylon? | 19:38 |
| JayF | openstack server create "terminator-jay" | 19:38 |
| TheJulia | ... we never intended to turn contributors into metal.... | 19:42 |
| kubajj | TheJulia, JayF: I think I won't be able to finish the change today because it is getting late and I realised that there is still quite a lot to do. I might then wait for Monday and ask Dmitry what he thinks as well. If I remember correctly, he did not want to stop deleting the node if it fails. https://review.opendev.org/c/openstack/ironic/+/871394/comments/80554ab2_be177e55 | 19:44 |
| JayF | sounds like more and more evidence that making the behavior configurable might be the route | 19:44 |
| kubajj | JayF: yeah, seems so | 19:45 |
| JayF | and FWIW, if it's all in the same task you should be able to just bail and everything rollback and be fine, right? I think you get the "don't delete" for free if you raise | 19:45 |
| kubajj | JayF: yeah, but I realised that there is a problem with the _get functions as well. Swift might raise an exception, but I never catch it, so api would break I think. | 19:46 |
| JayF | makes sense | 19:47 |
| opendevreview | Verification of a change to openstack/ironic-python-agent bugfix/8.3 failed: Fix CI for bugfix/8.3 https://review.opendev.org/c/openstack/ironic-python-agent/+/868064 | 19:49 |
| opendevreview | Verification of a change to openstack/ironic-python-agent bugfix/8.3 failed: Drop python2 from bindep.txt https://review.opendev.org/c/openstack/ironic-python-agent/+/867916 | 19:49 |
| kubajj | TheJulia: What do you think should happen in inspect_utils/_get_introspection_data_from_swift if it fails to retrieve them? Should I just return empty values and log it? | 19:53 |
| opendevreview | Merged openstack/ironic bugfix/21.0: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871995 | 19:55 |
| TheJulia | kubajj: got a link to the code? | 19:56 |
| kubajj | TheJulia: https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/inspect_utils.py#L136 | 19:57 |
| opendevreview | Merged openstack/ironic-python-agent stable/yoga: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-python-agent/+/871891 | 19:58 |
| opendevreview | Merged openstack/ironic-inspector stable/train: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-inspector/+/871888 | 20:09 |
| TheJulia | on get, I guess if not found, likely return "None" ? | 20:10 |
| iurygregory | YAY Found registries for RootService: BiosAttributeRegistryProt0.208.208.0 | 20:12 |
| iurygregory | \o/ | 20:12 |
| opendevreview | Merged openstack/ironic-python-agent stable/xena: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-python-agent/+/871893 | 20:16 |
| opendevreview | Merged openstack/ironic-python-agent stable/victoria: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-python-agent/+/871896 | 20:16 |
| opendevreview | Merged openstack/ironic-python-agent stable/wallaby: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-python-agent/+/871895 | 20:16 |
| opendevreview | Merged openstack/ironic-python-agent bugfix/8.6: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-python-agent/+/871890 | 20:16 |
| opendevreview | Merged openstack/ironic-python-agent stable/ussuri: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-python-agent/+/871897 | 20:16 |
| opendevreview | Merged openstack/ironic-python-agent stable/train: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-python-agent/+/871898 | 20:16 |
| opendevreview | Merged openstack/ironic-inspector stable/xena: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-inspector/+/871883 | 20:26 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/sushy master: [WIP] Handle non-default language for registries https://review.opendev.org/c/openstack/sushy/+/872049 | 20:43 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Delete resource provider after node deletion. https://review.opendev.org/c/openstack/ironic/+/827295 | 21:05 |
| TheJulia | JayF: ^^ I cleaned up the commit message and added on to the reno. The recommendation to do this has come up in general in the past, so not a terribly surprising. | 21:07 |
| TheJulia | oh! | 21:07 |
| * TheJulia goes back and edits again | 21:07 | |
| opendevreview | Julia Kreger proposed openstack/ironic master: Delete resource provider after node deletion. https://review.opendev.org/c/openstack/ironic/+/827295 | 21:13 |
| TheJulia | likely needs other doc changes... | 21:13 |
| TheJulia | but minimum is there I think | 21:13 |
| opendevreview | Merged openstack/ironic stable/ussuri: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872003 | 21:40 |
| opendevreview | Merged openstack/ironic-inspector stable/ussuri: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-inspector/+/871887 | 21:40 |
| opendevreview | Merged openstack/ironic stable/victoria: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872002 | 21:42 |
| opendevreview | Merged openstack/ironic-inspector stable/wallaby: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-inspector/+/871885 | 21:42 |
| opendevreview | Merged openstack/ironic bugfix/20.2: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871996 | 21:43 |
| opendevreview | Merged openstack/ironic-inspector stable/yoga: Make reno ignore bugfix eol tags https://review.opendev.org/c/openstack/ironic-inspector/+/871881 | 21:43 |
| opendevreview | Merged openstack/ironic bugfix/19.0: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871998 | 21:57 |
| opendevreview | Merged openstack/ironic bugfix/18.1: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872000 | 21:57 |
| opendevreview | Merged openstack/ironic stable/xena: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871999 | 22:09 |
| opendevreview | Merged openstack/ironic master: Fix grub config path default https://review.opendev.org/c/openstack/ironic/+/869134 | 22:09 |
| JayF | Is there anyone who'd be willing to do one of my OSS Office Hours as a guest helping demo/show off bifrost? I know miserably little about it, and I'd like to increase my knowledge as well as create a video (the VOD) I can use to promote it. | 22:12 |
| opendevreview | Merged openstack/ironic stable/zed: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872040 | 22:35 |
| opendevreview | Merged openstack/ironic stable/wallaby: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/872001 | 22:35 |
| opendevreview | Merged openstack/ironic stable/yoga: Move and fix reno config for releasenotes job https://review.opendev.org/c/openstack/ironic/+/871997 | 22:47 |
| TheJulia | JayF: likely someone else is the best candidate at this point, it has been a while for me. | 23:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!