| opendevreview | Steve Baker proposed openstack/ironic-python-agent-builder master: Don't install dlrn-deps.repo if DIB_YUM_REPO_CONF is set https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/877567 | 00:44 |
|---|---|---|
| *** dking is now known as Guest7900 | 01:46 | |
| *** Guest7900 is now known as dking | 01:46 | |
| opendevreview | Steve Baker proposed openstack/ironic-python-agent-builder master: Add DIB_IPA_HARDWARE_RDO to define repo behaviour https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/877567 | 01:52 |
| arne_wiebalck | Good morning, Ironic! | 07:17 |
| rpittau | good morning ironic! o/ | 08:24 |
| opendevreview | Mohammed Boukhalfa proposed openstack/sushy-tools master: Add fake_ipa inspection, lookup and heartbeater to fake system https://review.opendev.org/c/openstack/sushy-tools/+/875366 | 08:39 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Use main branch of metal3-dev-env to run metal3 integration job https://review.opendev.org/c/openstack/ironic/+/877600 | 09:21 |
| mgoddard | morning Ironic | 09:23 |
| mgoddard | does anyone fancy this patch chain with their coffee? https://review.opendev.org/q/I7bec6cfacb9d1558bc514c07386583436759f4df | 09:23 |
| mgoddard | --patch chain-- set of backports | 09:25 |
| dtantsur | on it | 10:28 |
| dtantsur | mgoddard: was it before stable/2023.1 was created? | 10:29 |
| dtantsur | yeah, seems so | 10:33 |
| mgoddard | thanks dtantsur :) | 10:33 |
| dtantsur | https://review.opendev.org/c/openstack/bifrost/+/877515 is ready for review | 10:34 |
| mgoddard | we've hit it twice on wallaby -> xena upgrade, I wonder why nobody else did | 10:34 |
| dtantsur | not so many use BIOS settings? we use them in metal3, but we don't do upgrades as normal people do :) | 10:34 |
| mgoddard | yeah, could be so | 10:37 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost stable/xena: DNM test the CI https://review.opendev.org/c/openstack/bifrost/+/877612 | 10:44 |
| dtantsur | rpittau: I don't know why, but https://review.opendev.org/c/openstack/bifrost/+/877515 seems to work; I'm checking all branches now | 10:45 |
| dtantsur | see e.g. https://review.opendev.org/c/openstack/bifrost/+/877513 passing everything but the upgrade job | 10:45 |
| rpittau | dtantsur: re https://review.opendev.org/c/openstack/bifrost/+/877515 I think it makes sense, we're using jammy as base for the upgrade, and the playbooks for the CI are taken from master, so the fix applies, no? | 10:52 |
| dtantsur | rpittau: this one is fine because it upgrades from 2023.1, yes. just a note: playbooks are still mostly taken from the branch, only the stuff specific to the CI is always from the new branch. | 10:53 |
| rpittau | right | 10:54 |
| dtantsur | problems begin on releases which used focal for upgrade, so 2023.1 and older | 10:54 |
| rpittau | yeah, I'm checking the other one you linked | 10:54 |
| dtantsur | We can drop upgrades Wallaby-Xena since Wallaby is EOL. everything else is a problem. | 10:54 |
| dtantsur | s/EOL/EM/ | 10:54 |
| rpittau | ack | 10:54 |
| dtantsur | I'd still love to understand why the breakage even happened, given that the file list looks old.... | 10:55 |
| rpittau | I had an interesting discussion in the ubuntu channel yesterday, unfortunately the list reported in the packages site is not to be considered as a source of truth | 10:56 |
| rpittau | the only way to know the real content of the package is from the package itself | 10:57 |
| dtantsur | that explains | 11:00 |
| rpittau | so we need to go back in time and change aaaaaaaall the shim-signed file name for focal | 11:01 |
| dtantsur | mgoddard: re your question ^^^ | 11:01 |
| rpittau | so I think we will need one for yoga too | 11:03 |
| dtantsur | and even for xena. I'm testing the CI there to evaluate the scope of the drama. | 11:05 |
| rpittau | oh, yeah, probably, if it runs on focal | 11:05 |
| dtantsur | let's start with fixing master anyway | 11:05 |
| rpittau | yep | 11:06 |
| iurygregory | morning Ironic | 11:48 |
| opendevreview | Merged openstack/ironic stable/zed: Fix online upgrades for Bios/Traits https://review.opendev.org/c/openstack/ironic/+/877409 | 12:03 |
| dtantsur | rpittau: xena passes with focal O______o | 12:12 |
| dtantsur | ahhh.. maybe we don't try to unpack packages in xena? | 12:12 |
| dtantsur | yeah, I only backported it to yoga, so yoga is the last branch to fix | 12:13 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost stable/yoga: Backport the jammy shimx64.efi.signed fix including focal https://review.opendev.org/c/openstack/bifrost/+/877626 | 12:14 |
| rpittau | ok, cool, I'll have a look after lunch | 12:28 |
| opendevreview | Merged openstack/ironic stable/yoga: Fix online upgrades for Bios/Traits https://review.opendev.org/c/openstack/ironic/+/877490 | 12:47 |
| opendevreview | Merged openstack/ironic stable/xena: Fix online upgrades for Bios/Traits https://review.opendev.org/c/openstack/ironic/+/877491 | 12:47 |
| opendevreview | Merged openstack/ironic bugfix/21.3: Fix online upgrades for Bios/Traits https://review.opendev.org/c/openstack/ironic/+/877495 | 12:47 |
| opendevreview | Merged openstack/ironic bugfix/21.2: Fix online upgrades for Bios/Traits https://review.opendev.org/c/openstack/ironic/+/877496 | 12:48 |
| opendevreview | Verification of a change to openstack/ironic stable/2023.1 failed: Wipe Agent Token when cleaning timeout occcurs https://review.opendev.org/c/openstack/ironic/+/877394 | 14:55 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Fixes Secureboot with Anaconda deploy https://review.opendev.org/c/openstack/ironic/+/860820 | 15:04 |
| TheJulia | curious that on the arm pipeline completing, it reports a failure to verify, but the job is still running | 15:06 |
| dtantsur | TheJulia: yep, it happens on every recheck. Good morning! | 15:06 |
| TheJulia | I guess I'm just sleepy enough that it really registered with me today | 15:07 |
| TheJulia | but come to think of it I've seen it before | 15:07 |
| dtantsur | I remember getting really confused the first time :) | 15:07 |
| dtantsur | TheJulia: would you be able to check bifrost fixes for the Focal issue today? | 15:07 |
| TheJulia | what is really weird is the arm pipeline succeeded | 15:07 |
| TheJulia | just ones on the bifrost repo? | 15:08 |
| dtantsur | yeah, it just posts the old status | 15:08 |
| dtantsur | TheJulia: https://review.opendev.org/c/openstack/bifrost/+/877626 https://review.opendev.org/c/openstack/bifrost/+/877515 first | 15:08 |
| TheJulia | I'm guessing in that order as well? | 15:08 |
| dtantsur | then https://review.opendev.org/c/openstack/bifrost/+/877514 and finally https://review.opendev.org/c/openstack/bifrost/+/877513 | 15:08 |
| TheJulia | k | 15:09 |
| dtantsur | TheJulia: the master change can merge at any time, the rest in the reverse order | 15:09 |
| dtantsur | (yoga to 2023.1) | 15:09 |
| TheJulia | ack | 15:09 |
| TheJulia | fwiw, they look good to me, I'll happily single core approve the other two once the time comes | 15:13 |
| dtantsur | thx! | 15:13 |
| TheJulia | np | 15:13 |
| dtantsur | now that we're merging inspector, I wonder if we should return the JSON RPC code to Ironic from ironic-lib.. | 15:14 |
| TheJulia | hmm | 15:15 |
| TheJulia | Is there a compelling reason why other than dependencies ? | 15:15 |
| TheJulia | I see ironic-lib stuff as super stable substrate and the jsonrpc stuffs feel like that to me | 15:15 |
| dtantsur | yeah, you're probably right (and I have too many other things to do) | 15:15 |
| TheJulia | I know this feeling well | 15:16 |
| opendevreview | Merged openstack/ironic-inspector stable/2023.1: tests: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/ironic-inspector/+/877010 | 15:37 |
| opendevreview | Merged openstack/ironic-inspector bugfix/11.3: tests: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/ironic-inspector/+/877012 | 15:38 |
| opendevreview | Harald Jensås proposed openstack/metalsmith stable/yoga: Get ports by 'binding:host_id' query filter https://review.opendev.org/c/openstack/metalsmith/+/877633 | 15:55 |
| opendevreview | Harald Jensås proposed openstack/metalsmith stable/xena: Get ports by 'binding:host_id' query filter https://review.opendev.org/c/openstack/metalsmith/+/877634 | 15:55 |
| opendevreview | Harald Jensås proposed openstack/metalsmith stable/wallaby: Get ports by 'binding:host_id' query filter https://review.opendev.org/c/openstack/metalsmith/+/877635 | 15:55 |
| opendevreview | Merged openstack/sushy master: Exclude all files starting with . from flake8 tests https://review.opendev.org/c/openstack/sushy/+/877077 | 16:00 |
| rpittau | Bye everyone see you tomorrow o/ | 16:07 |
| JayF | o/ | 16:09 |
| opendevreview | Merged openstack/bifrost stable/yoga: Backport the jammy shimx64.efi.signed fix including focal https://review.opendev.org/c/openstack/bifrost/+/877626 | 16:32 |
| opendevreview | Verification of a change to openstack/bifrost master failed: Upgrade from 2023.1 and use Jammy for the upgrade job https://review.opendev.org/c/openstack/bifrost/+/877515 | 16:48 |
| opendevreview | Merged openstack/ironic stable/2023.1: Wipe Agent Token when cleaning timeout occcurs https://review.opendev.org/c/openstack/ironic/+/877394 | 17:56 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Framework for DPU management/orchustration https://review.opendev.org/c/openstack/ironic-specs/+/874189 | 18:09 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Add service steps framework https://review.opendev.org/c/openstack/ironic-specs/+/872349 | 18:28 |
| TheJulia | JayF: still pondering state name, but added a note | 18:28 |
| TheJulia | gah, out of service is really growing on me | 18:37 |
| JayF | TheJulia: the state we want is "MAINTENANCE" but we have to deprecate the binary flag and break every user ever first /s | 18:40 |
| TheJulia | well, maybe not. Maintenance is understood purpose/use wise | 19:02 |
| TheJulia | a field team person actually opened a comment on a call with "maintenance is "stop polling power, don't allow it to proceed" | 19:03 |
| TheJulia | and noted that is not "I'm doing things to it!" | 19:03 |
| JayF | I sorta view this as a piece of the problem, right? | 19:07 |
| JayF | if we have: MANAGEABLE, OUT OF SERVICE, and node.maintenance | 19:07 |
| JayF | unless someone has a PhD in Ironic, it's going to sound all really similar to them | 19:07 |
| JayF | which is why I have a little pause about adding something liek OUT OF SERVICE ... it seems like we haven't taken a holistic view to this ... maybe ever? | 19:07 |
| TheJulia | This might be a case where a holistic approach might be the enemy | 19:09 |
| TheJulia | just thinking outloud there | 19:09 |
| * TheJulia waits for a meeting attendee to arrrive | 19:10 | |
| * TheJulia wonders if google home can do a lightswitch rave | 19:10 | |
| JayF | I'm just thinking of a world where more people use Ironic API directly, the more concepts we have that "are the same but have different meanings if you really understand them" is just complexity | 19:11 |
| JayF | in like, undertanding/dealing with our APIs | 19:11 |
| JayF | where I'm stuck is: I'm not sure what the better solution is; but I'm not sure we've even looked for one really (maybe you have, but Ironic-the-project hasn't really :D) | 19:12 |
| JayF | I guess I semi-lament the time when almost-any sensible systems admin/operator could look at a node detail and have any idea what was going on :/ | 19:22 |
| opendevreview | Verification of a change to openstack/bifrost master failed: Upgrade from 2023.1 and use Jammy for the upgrade job https://review.opendev.org/c/openstack/bifrost/+/877515 | 19:35 |
| stevebaker[m] | good morning | 19:50 |
| JayF | o/ | 20:06 |
| opendevreview | Merged openstack/bifrost stable/zed: Repair Focal support https://review.opendev.org/c/openstack/bifrost/+/877514 | 20:22 |
| TheJulia | JayF: I think the issue ends up being rooted in maintenance as a name encompasses a lot of different things, so anything which encroaches on it use/interaction wise, even distinctly different from it's base meaning/function, then kind of expands the entire discussion | 20:33 |
| TheJulia | JayF: I guess to counter that, we wouldn't create a maintenance state and move a node to it upon loosing the ability to sync with the power state | 20:33 |
| TheJulia | stevebaker[m]: o/ | 20:33 |
| JayF | I almost think like, node.maintenance could be like, node.offline or something like that | 20:33 |
| JayF | and it'd maybe give a better implication of what it does | 20:33 |
| JayF | idk though, it's all just a mess and there's no cleaning it up without rethinking the api from scratch-ish | 20:34 |
| TheJulia | yeah, and one of the reasons people do like ironic is often we work to avoid such major changes (and still try to be thoughtful) | 20:41 |
| JayF | yeah like, we're clearly going to land on "do it with a name that's not confusing" ... but I wish it were better | 20:47 |
| JayF | I just don't know if better even exists | 20:47 |
| TheJulia | it is a journey | 20:55 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Framework for DPU management/orchustration https://review.opendev.org/c/openstack/ironic-specs/+/874189 | 21:42 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/872834 already has my +2, needs more love, it's a good fix we should probably backport... | 22:25 |
| TheJulia | JayF: it is a feature though... | 22:51 |
| JayF | Gracefully shutting down is a feature? Not assumed-default behavior? | 22:52 |
| JayF | I guess I can see that perspective but this seems way more positively impactful than half of the hardware stuff we backport | 22:52 |
| JayF | is there a risk of it causing bad things for operators who aren't aware it's coming down the pipe? | 22:52 |
| TheJulia | graceful shutdown has never been a feature | 23:01 |
| TheJulia | it has always been "shutdown hard", other conductors can pickup the pieces" | 23:01 |
| TheJulia | but... | 23:02 |
| JayF | I'm saying I don't view graceful shutdown as a feature | 23:02 |
| TheJulia | if we do backport it, lets change the release note :) | 23:02 |
| TheJulia | because... I can go along with it | 23:02 |
| JayF | I view it as a worked-around bad behavior we've had for years | 23:02 |
| JayF | if that makes sense? | 23:02 |
| JayF | but again, I can grok the other view | 23:02 |
| TheJulia | this is a feature can also be a bugfix, lets just change the reno on backport because otherwise people are going to refuse or make us jump through hoops | 23:03 |
| JayF | worse case releases team will ask us to make a minor bump with it | 23:03 |
| JayF | which probably isn't terrible | 23:03 |
| JayF | and I was thinking just get it back to 2023.1, so that soon-to-upgraders get it | 23:03 |
| JayF | maybe not an all-the-way-back backport | 23:04 |
| * TheJulia shrugs and takes migraine meds | 23:04 | |
| JayF | I can go either way on this for sure :D | 23:05 |
| JayF | go feel better, it's EOD for me too o/ | 23:05 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: WIP: cross-conductor rpc https://review.opendev.org/c/openstack/ironic-specs/+/873662 | 23:05 |
| opendevreview | Merged openstack/bifrost stable/2023.1: Repair Focal support and bring back the main voting jobs https://review.opendev.org/c/openstack/bifrost/+/877513 | 23:28 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!