vanou | good morning ironic | 04:27 |
---|---|---|
opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Handle MissingAttributeError when using OOB inspections to fetch MACs https://review.opendev.org/c/openstack/ironic/+/880575 | 04:46 |
opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Handle MissingAttributeError when using OOB inspections to fetch MACs https://review.opendev.org/c/openstack/ironic/+/880575 | 04:47 |
arne_wiebalck | Good morning vanou and Ironic! | 06:49 |
rpittau | good morning ironic! o/ | 07:30 |
stephenfin | Morning. You probably have your own tests for this, but https://review.opendev.org/c/openstack/requirements/+/879743 might be helpful to root out remaining SQLA 2.0 issues. Looks like there are a few at least | 09:27 |
opendevreview | Stephen Finucane proposed openstack/ironic master: db: Resolve SAWarning warnings https://review.opendev.org/c/openstack/ironic/+/856349 | 09:34 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Replace invalid UUIDs https://review.opendev.org/c/openstack/ironic/+/856347 | 09:34 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Comment out prints https://review.opendev.org/c/openstack/ironic/+/856348 | 09:34 |
vanou | Hi arne_wiebalck | 10:56 |
dtantsur | thanks for the heads-up stephenfin | 11:36 |
iurygregory | morning Ironic | 12:01 |
TheJulia | good morning | 12:39 |
rpittau | good morning TheJulia :) | 12:50 |
opendevreview | Verification of a change to openstack/ironic master failed: Prepare [inspector]require_managed_boot to change to True in the future https://review.opendev.org/c/openstack/ironic/+/877470 | 12:54 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Remove netifaces usage https://review.opendev.org/c/openstack/ironic-python-agent/+/879984 | 14:25 |
TheJulia | samuelkunkel[m]: just a reminder w/r/t https://review.opendev.org/c/openstack/sushy/+/880542 | 14:42 |
TheJulia | dtantsur: I was *really* hoping not to have to touch every test doing anything uefi bootloader record related with https://review.opendev.org/c/openstack/ironic-python-agent/+/879897 *sigh* | 14:49 |
dtantsur | TheJulia: it's understandable, although unfortunate. IN any case, it's worth a comment (and the str() part is technically wrong, although will work for you) | 14:51 |
TheJulia | I know, it was all to avoid touching a ton of tests :) | 14:52 |
TheJulia | hence why the decode check | 14:52 |
* dtantsur sadface @ netifaces | 14:52 | |
dtantsur | TheJulia: https://stackoverflow.com/questions/57093853/detecting-available-network-adapters-with-python is hinting at psutil (which I suspect we already use) as a way to list interfaces | 14:54 |
TheJulia | https://review.opendev.org/c/openstack/ironic-python-agent/+/879897/4/releasenotes/notes/fixes-efibootmgr-character-encoding-19e531ba694824c1.yaml <-- wrt that comment, the sample data we've gotten can have multibyte if it is stored with it, and we even got garbage out of our own test VMs when I got hexdump data out of it... (yes, this actually happens on our test vms today, just we hid it by forcing utf8 encoding) | 14:54 |
TheJulia | ... which is invalid | 14:54 |
TheJulia | dtantsur: ip is already a requirement which we use elsewhere, I don't remember why off hand | 14:55 |
dtantsur | TheJulia: sure, I'm just not the biggest fan of parsing `ip addr` output | 14:56 |
dtantsur | https://paste.opendev.org/show/b2ocscuZRaG99nymD9PB/ | 14:56 |
dtantsur | and we do indeed already use psutil | 14:57 |
TheJulia | ahh, that is not horrible | 14:57 |
TheJulia | please add a comment, I'll try to revisit it between meetings and efibootmgr fun :( | 14:58 |
TheJulia | Speaking of... | 14:59 |
* dtantsur sees at least 2 forks of netifaces, ugh | 14:59 | |
TheJulia | #startmeeting ironic | 15:00 |
opendevmeet | Meeting started Mon Apr 17 15:00:07 2023 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'ironic' | 15:00 |
TheJulia | o/ | 15:00 |
TheJulia | #chair JayF | 15:00 |
opendevmeet | Current chairs: JayF TheJulia | 15:00 |
dtantsur | o/ | 15:00 |
iurygregory | o/ | 15:00 |
TheJulia | Good Morning everyone and welcome to this week's edition of the Ironic team meeting | 15:00 |
TheJulia | I'm TheJulia, and I'll be your host this week as JayF is busy at the moment. | 15:00 |
rpittau | o/ | 15:00 |
TheJulia | You might remember me from... *insert simpsons reference here* | 15:00 |
TheJulia | Our agenda can be found on the wiki. | 15:01 |
TheJulia | #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting | 15:01 |
TheJulia | Is it just four of us this morning? | 15:01 |
iurygregory | probably .-. | 15:02 |
rpittau | looks like it | 15:02 |
TheJulia | Well, then... I guess we can keep this quick | 15:02 |
TheJulia | #topic Announcements / Reminders | 15:02 |
TheJulia | #info Standing Reminder to review patches tagged with ironic-week-prio. | 15:03 |
TheJulia | #link https://tinyurl.com/ironic-weekly-prio-dash | 15:03 |
TheJulia | Additionally, please be mindful to check for existing patches which may not be tagged and remember to tag your own patches when they are ready. | 15:03 |
TheJulia | Does anyone have anything they would like to announce? | 15:03 |
rpittau | thanks for the +2 on the ipa-builder patches TheJulia :) | 15:03 |
TheJulia | No problem! :) | 15:04 |
TheJulia | Oh, One note, we're less than 60 days from the Open Infra Summit! | 15:04 |
TheJulia | It looks like we had no action items from our last meeting, so we can skip that portion of the meeting. | 15:05 |
TheJulia | Onward! | 15:05 |
TheJulia | #topic Review Ironic CI status & update whiteboard if needed | 15:05 |
TheJulia | AFAIK, CI status appears to be good except for ironic-grenade which seems to be fail happy | 15:06 |
* dtantsur hasn't looked into the grenade failures since last time | 15:07 | |
rpittau | heh me neither | 15:07 |
TheJulia | gmann: any chance we can get eyes on https://review.opendev.org/c/openstack/grenade/+/879674 ? Our failure rate, counting explicit failures and unknown failures is like 50% on the grenade job. | 15:08 |
TheJulia | And we've been able to confirm by looking at our patch to change the settings that the job will complete as expected. | 15:09 |
TheJulia | Hmm, we don't even have a whiteboard link on the meeting agenda anymore | 15:09 |
TheJulia | Anyway, onward! | 15:10 |
TheJulia | #topic ironic-python-agent-builder changes | 15:10 |
TheJulia | rpittau: I beleive these are yours? | 15:10 |
rpittau | I think it's an old topic, we discussed already about that | 15:10 |
TheJulia | Any further discussion required, or just reviews? | 15:10 |
rpittau | anyway, changes are ongoing | 15:10 |
rpittau | just reviews | 15:10 |
TheJulia | okay, are we safe to remove the agenda item then? | 15:10 |
rpittau | yep | 15:10 |
TheJulia | ack, will do | 15:11 |
TheJulia | #topic PyPI Maintainer Audit | 15:11 |
TheJulia | I don't have any evidence for this, but apparently we're making progress... but this may be an old item? | 15:11 |
TheJulia | Anyone have anything on this or shall we proceed onward? | 15:11 |
dtantsur | I've removed me from Ironic projects, that's all I know :) | 15:11 |
TheJulia | heh | 15:11 |
TheJulia | okay | 15:11 |
TheJulia | I guess then we can proceed onward after the crickets make their appropriate sounds for a few moments | 15:12 |
TheJulia | #topic VirtualPDU | 15:12 |
TheJulia | Latest status is that the VirtualPDU repo has been moved into the openstack namespace in gerrit, however there is an outstanding issue with the redirect on the original namespace repo it seems on github. I believe that is still under determination of a forward path. | 15:14 |
TheJulia | #topic | 15:14 |
TheJulia | err | 15:14 |
TheJulia | #topic Open Discussion | 15:14 |
rpittau | yeah I was planning to ask for a release | 15:14 |
TheJulia | Does anyone have anything they would like to discuss? | 15:14 |
TheJulia | rpittau: ack | 15:14 |
JayF | thank you for doing that dtantsur :) I'll update my notes shortly | 15:15 |
TheJulia | dtantsur: at some point I'd love to chat about https://review.opendev.org/c/openstack/ironic-specs/+/873662?usp=search with you, but not today. :) | 15:16 |
dtantsur | absolutely not today, Wednesday the earliest | 15:16 |
dtantsur | but happily | 15:16 |
TheJulia | works for me | 15:16 |
TheJulia | I'm out Thursday/Friday, fwiw | 15:16 |
TheJulia | Looks like I've doomed myself to spending a ton of time working on steps this cycle :) | 15:18 |
JayF | Make sure to get high quality shoes ;) | 15:18 |
TheJulia | heh | 15:18 |
TheJulia | before YVR, hopefully | 15:18 |
TheJulia | Although, sandals would be more prophecy compliant :) | 15:19 |
TheJulia | Well folks, thanks and have a great week! | 15:19 |
rpittau | thanks! you too | 15:20 |
TheJulia | #endmeeting | 15:20 |
opendevmeet | Meeting ended Mon Apr 17 15:20:36 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:20 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2023/ironic.2023-04-17-15.00.html | 15:20 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2023/ironic.2023-04-17-15.00.txt | 15:20 |
opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2023/ironic.2023-04-17-15.00.log.html | 15:20 |
TheJulia | speaking of fun stuff, I didn't realize verify steps worked the way they do. That has all sorts of fun logic which will be needed for reserved step names and child node step execution | 15:21 |
* TheJulia has a 4 hour meeting-less window *gasp* | 15:24 | |
TheJulia | dtantsur: wednesday actually works really well since I think I'll be able to connect with stevebaker later that day on the same subject | 15:26 |
NobodyCam | Good Morning Ironic Folks, Happy Monday | 15:29 |
TheJulia | good morning | 15:30 |
NobodyCam | o/ TheJulia | 15:30 |
rpittau | good night! o/ | 15:55 |
TheJulia | g'night | 15:56 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Fix UTF-16 result handling for efibootmgr https://review.opendev.org/c/openstack/ironic-python-agent/+/879897 | 16:15 |
TheJulia | well, that was easier than I thought it would be | 16:15 |
TheJulia | dtantsur: w/r/t psutil, that has a weakness which we can filter out with using ip... unfortunately. we can end up with a link level or privacy address. my machine's non-privacy global valid ipv6 address is 7 entries below the entry we would pick and we don't have a way with the data to delineate them short of doing after the fact record evaluation :\ | 16:32 |
samuelkunkel[m] | TheJulia: thanks for the reminder. Had scheduled it for this afternoon but had to take a trip to the hospital with my son :/ | 17:02 |
samuelkunkel[m] | Guess will have a look tomorrow | 17:02 |
JayF | Hope your son recovers :( | 17:02 |
samuelkunkel[m] | Its fine again. He had a severe constipation. But the docs got it fixed :) | 17:04 |
samuelkunkel[m] | He is already starting to harass his sister. So this is a good sign he is fine :) | 17:05 |
TheJulia | heh, that does seem like a good sign! | 17:07 |
gmann | TheJulia: done | 17:11 |
TheJulia | gmann: much appreciated, thanks | 17:11 |
TheJulia | Crystal: https://github.com/openstack/ironic-python-agent/blob/0304c73c0e95699650a147c1bb5ea0a5ef6861f1/ironic_python_agent/hardware.py#L1430-L1453 | 18:14 |
TheJulia | and the docs you want are at https://docs.openstack.org/ironic-python-agent/latest/admin/hardware_managers.html#cleaning-safeguards | 18:15 |
TheJulia | So, your specific need, you want to specify the exact devices to erase | 18:15 |
Crystal | Thank you Julia!! | 18:15 |
TheJulia | and this model is *everything but the devices it is told* | 18:15 |
TheJulia | this is because you don't know what else has been attached | 18:15 |
TheJulia | if a thumbd rive or an extra server is in a device outside of inventory parameters | 18:15 |
TheJulia | so, a little different | 18:15 |
TheJulia | Also, we try to avoid exact device by name matching because the order on some hardware is not static | 18:16 |
TheJulia | it gets governed by device initialization order | 18:16 |
TheJulia | hence why hints is a thing | 18:16 |
TheJulia | so, that dictionary, would need to be saved to the contents of the node's properties | 18:17 |
TheJulia | its a little akward, but it is also meant to be static. CERN developed that feature because they had a subset of nodes which has data they need to preserve from user to user of the physical machine | 18:17 |
Crystal | Ohhh interesting! That makes sense. Thank you again for the pointers and the explanation!! | 18:19 |
TheJulia | dtantsur: another item for us to discuss is agent checksums with remote sources and md5 :( | 18:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!