opendevreview | Merged openstack/ironic master: Explicitly pin CIRROS_VERSION https://review.opendev.org/c/openstack/ironic/+/883983 | 01:41 |
---|---|---|
iurygregory | \o/ | 01:51 |
iurygregory | recheck in the patch to see grenade green <3 | 01:51 |
TheJulia | \o/ | 01:53 |
iurygregory | grenade success <3 | 03:27 |
TheJulia | Now, nothing else is allowed to break! | 03:27 |
iurygregory | YES! | 03:28 |
iurygregory | and we should probably merge the DPU patch before merging https://review.opendev.org/c/openstack/ironic/+/883968 I would say | 03:31 |
iurygregory | now I'm going to sleep, midnight already, and i have early meeting | 03:32 |
opendevreview | Merged openstack/ironic-tempest-plugin master: CI: Advance stable jobs to 2023.1 https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/883600 | 03:45 |
opendevreview | Julia Kreger proposed openstack/ironic master: Support sha256/sha512 with the ilo firmware upgrade logic https://review.opendev.org/c/openstack/ironic/+/882164 | 03:51 |
opendevreview | Verification of a change to openstack/ironic stable/yoga failed: [stable-only] [CI] BFV, RBAC jobs marked non-voting https://review.opendev.org/c/openstack/ironic/+/883589 | 04:07 |
opendevreview | Julia Kreger proposed openstack/ironic master: Handle nova policy change https://review.opendev.org/c/openstack/ironic/+/883998 | 04:37 |
opendevreview | Merged openstack/ironic-python-agent-builder stable/2023.1: Add checksum generation support https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/883569 | 05:17 |
opendevreview | Verification of a change to openstack/ironic master failed: Explicitly use a session for DB version check https://review.opendev.org/c/openstack/ironic/+/883967 | 05:58 |
* TheJulia has a growing urge to start reverting devstack changes | 06:03 | |
TheJulia | looks like the default policy changes which merged are tanking multiple jobs for us, the posted change should fix us up, in theory | 06:04 |
rpittau | good morning ironic! o/ | 07:00 |
opendevreview | Merged openstack/ironic stable/yoga: [stable-only] [CI] BFV, RBAC jobs marked non-voting https://review.opendev.org/c/openstack/ironic/+/883589 | 07:42 |
opendevreview | Verification of a change to openstack/ironic master failed: Explicitly use a session for DB version check https://review.opendev.org/c/openstack/ironic/+/883967 | 08:46 |
opendevreview | Merged openstack/ironic master: Remove indicators list by component from api-ref https://review.opendev.org/c/openstack/ironic/+/882710 | 09:05 |
opendevreview | Merged openstack/metalsmith master: Reduce retry timeout for Metalsmith CI https://review.opendev.org/c/openstack/metalsmith/+/883683 | 10:44 |
opendevreview | Merged openstack/metalsmith master: Update MD5 checksum references https://review.opendev.org/c/openstack/metalsmith/+/882170 | 10:45 |
iurygregory | good morning Ironic | 10:53 |
iurygregory | really? I went to sleep and CI went broken again >.< (ofc the fix for grenade didn't get merged, sad =( ) | 10:54 |
dtantsur | iurygregory: :( which fix is the most important now? | 10:54 |
iurygregory | dtantsur, probably https://review.opendev.org/c/openstack/ironic/+/883998 | 10:55 |
iurygregory | I've +W already | 10:56 |
opendevreview | Merged openstack/ironic master: Handle nova policy change https://review.opendev.org/c/openstack/ironic/+/883998 | 12:10 |
dtantsur | yay | 12:14 |
iurygregory | ok time to recheck the fix for grenade | 12:23 |
iurygregory | nothing is allowed to break now | 12:26 |
opendevreview | Mark Goddard proposed openstack/bifrost master: Restart systemd services on failure https://review.opendev.org/c/openstack/bifrost/+/884198 | 12:58 |
TheJulia | good morning | 13:19 |
iurygregory | good morning TheJulia | 13:20 |
iurygregory | grenade fix on check \o/ bfv is green again | 13:20 |
TheJulia | I was worried about bfv, stumbled upon a super weird failure yesterday | 13:23 |
iurygregory | yeah, but the fix was quick \o/ great job TheJulia =D | 13:37 |
TheJulia | mgoddard: o/ w/r/t https://review.opendev.org/c/openstack/bifrost/+/884198 was there a specific failure? | 13:42 |
mgoddard | TheJulia: often when we reboot, bifrost services (in a kolla container) don't all come up properly | 14:26 |
mgoddard | TheJulia: mariadb seems the root cause, preventing ironic from starting | 14:26 |
TheJulia | mgoddard: ahh, that *would* do it | 14:26 |
mgoddard | didn't find a solution to mariadb, but this seemed like a step forward at least | 14:26 |
TheJulia | if it was anything else, I would wonder if there is a bug to fix | 14:26 |
TheJulia | the only other way is a precise order | 14:27 |
mgoddard | systemd should make it possible | 14:27 |
TheJulia | if you know the service names :) | 14:27 |
mgoddard | but in this case mariadb just isn't running at all, and unsure why | 14:28 |
TheJulia | weird | 14:32 |
TheJulia | systemd is only going to retry so many times | 14:32 |
iurygregory | hopefully in 1h30min the DB fix will be merged \o/ | 14:34 |
TheJulia | indeed | 14:36 |
opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Fix rbac indicator tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/882619 | 14:59 |
opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Add RBAC specific tempest jobs to gate plugin https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/882312 | 14:59 |
opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: rbac - Fix vif_attach expected return values https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/883032 | 14:59 |
TheJulia | just rebases | 14:59 |
opendevreview | Julia Kreger proposed openstack/ironic master: execute on child node support https://review.opendev.org/c/openstack/ironic/+/880545 | 15:09 |
opendevreview | Julia Kreger proposed openstack/ironic master: Add hold steps https://review.opendev.org/c/openstack/ironic/+/879060 | 15:10 |
opendevreview | Julia Kreger proposed openstack/ironic master: Enable vendor interfaces to be called as steps https://review.opendev.org/c/openstack/ironic/+/879089 | 15:10 |
opendevreview | Julia Kreger proposed openstack/ironic master: DNM: Move Ironic to scope enforced https://review.opendev.org/c/openstack/ironic/+/884235 | 15:17 |
opendevreview | Julia Kreger proposed openstack/ironic-inspector master: DNM: Change inspector to enforce scope https://review.opendev.org/c/openstack/ironic-inspector/+/884236 | 15:20 |
iurygregory | I'm surprised that the job that requires more time is the metalsmith-integration-glance-centos8-legacy | 15:22 |
TheJulia | I'm thinking we ought to drop it, tbh | 15:24 |
TheJulia | so! in other thoughts, which is a better name "sleep" or "pause" | 15:24 |
iurygregory | for? | 15:24 |
TheJulia | sleep/pause steps | 15:24 |
iurygregory | oh | 15:24 |
TheJulia | "power_on", "pause|sleep", "power_off", "pause|sleep", "power_on", "do_magical_thing" | 15:25 |
iurygregory | sleep steps would only make sense to me if the only thing it could do is "sleep X" | 15:25 |
TheJulia | well the original idea was without argument, it just sleeps until the next heartbeat | 15:25 |
TheJulia | so a pause | 15:25 |
JayF | TheJulia: pause or wait | 15:25 |
TheJulia | or a sleep | 15:25 |
JayF | TheJulia: very much not sleep | 15:25 |
JayF | sleep is a power action that means a specific thing for computers | 15:26 |
JayF | and unless we're doing that thing, we shouldn't use that word | 15:26 |
TheJulia | oh, good point | 15:26 |
dtantsur | reminder: we added the metalsmith job to get coverage for a feature that is not covered otherwise | 15:26 |
iurygregory | I'm +1 to pause | 15:26 |
TheJulia | dtantsur: which was? | 15:26 |
dtantsur | TheJulia: local legacy boot for partition images | 15:27 |
dtantsur | i.e. all the grub-install magic in IPA | 15:27 |
TheJulia | oh, right | 15:27 |
* TheJulia wonders how long we should keep that going | 15:27 | |
dtantsur | not that it *requires* metalsmith, but so far it's the only job that exercises it | 15:27 |
dtantsur | well, people still use legacy boot.... | 15:28 |
TheJulia | unfortunately | 15:28 |
dtantsur | *nod* | 15:28 |
TheJulia | although, we've really been pushing in my area to get rid of partition image usage | 15:28 |
TheJulia | maybe a topic for next spring's PTG | 15:28 |
dtantsur | I've definitely met at least one operator who said "I'll migrate away from Ironic if you drop partition images" | 15:29 |
dtantsur | not sure how serious they were, of course | 15:29 |
JayF | partition *legacy boot*, right? | 15:29 |
JayF | not partition uefi? | 15:29 |
dtantsur | partition + uefi is kinda-sorta checked in cirros jobs | 15:29 |
dtantsur | (by using the asset copy mechanism) | 15:29 |
* TheJulia wonders how many vendors are carrying proto-legacy-boot-firmware-stuffs | 15:30 | |
TheJulia | ... (then again, it wasn't universally dropped by the hardware vendors) | 15:30 |
dtantsur | it's all UEFI emulating BIOS nowadays, right? | 15:30 |
TheJulia | not *always* | 15:30 |
dtantsur | oh no | 15:30 |
TheJulia | we've run across some weird hardware which has the option, but it just ignores the request | 15:31 |
TheJulia | and then other hardware which has it "grayed out" | 15:31 |
* TheJulia doesn't want to encourage folks to consider beverages early | 15:31 | |
dtantsur | it's not that early here :D | 15:32 |
* dtantsur has a bottle of local blueberry wine | 15:32 | |
TheJulia | I know yummie | 15:32 |
TheJulia | err | 15:32 |
TheJulia | yummie | 15:32 |
TheJulia | I know a lot of people don't comprehend the actual *advantage* to uefi | 15:32 |
dtantsur | not everyone even understands the difference :) | 15:33 |
TheJulia | well, it is a 32bit-ism | 15:33 |
TheJulia | :) | 15:33 |
TheJulia | I have the Star Trek Voyager episode "nemesis" playing in the background. This feels like the clash, and 32bit is the nemesis. | 15:34 |
TheJulia | so the consensus is pause > wait > sleep right? | 15:35 |
JayF | I am like .00001% more of a fan of wait than pause | 15:35 |
TheJulia | hmmmmmmm | 15:37 |
JayF | I can't tell you *why* I have this association | 15:41 |
JayF | but I think wait is for a set period of time. Wait 30 seconds. Wait until 2pm. etc | 15:41 |
TheJulia | go vote https://civs1.civs.us/cgi-bin/vote.pl?id=E_f7b08705f48174a4&akey=d4fce31a35c805a0 :) | 15:41 |
JayF | Pause is indefinate. You pause until someone hits play. | 15:41 |
TheJulia | true | 15:41 |
TheJulia | I'm leaning towards wait personally | 15:42 |
TheJulia | 2 votes so far | 15:44 |
TheJulia | could I get reviews on https://review.opendev.org/c/openstack/ironic/+/883577 and https://review.opendev.org/c/openstack/ironic/+/883578 ? | 16:04 |
JayF | looking | 16:04 |
JayF | +2A | 16:05 |
iurygregory | \o/ | 16:20 |
rpittau | good night! o/ | 16:21 |
iurygregory | gn rpittau o/ | 16:22 |
JayF | o/ | 16:22 |
iurygregory | the longest 1min today https://zuul.opendev.org/t/openstack/status#883967 | 16:23 |
iurygregory | Estimated time remaining < 30 seconds | 16:24 |
opendevreview | Merged openstack/ironic master: Explicitly use a session for DB version check https://review.opendev.org/c/openstack/ironic/+/883967 | 16:44 |
iurygregory | \o/ | 16:44 |
iurygregory | yay | 16:44 |
iurygregory | now we can go with patches that have DB changes \o/ | 16:44 |
TheJulia | \o/ | 16:58 |
TheJulia | wheeeeeeeeeee | 16:58 |
TheJulia | closing poll, 3 votes | 17:06 |
TheJulia | wait wins, pause wins with 2 votes, other is 3rd... and sleep 4 | 17:06 |
opendevreview | Julia Kreger proposed openstack/ironic stable/wallaby: Fix Cinder Integration fallout from CVE-2023-2088 https://review.opendev.org/c/openstack/ironic/+/883581 | 17:38 |
TheJulia | I *think* that will work, it is a sort of weird case | 17:38 |
TheJulia | we'll see, I'll likely need to add a unit tests but getting tons of unrelated weird failures which I think is just my local repo | 17:39 |
opendevreview | Merged openstack/ironic stable/2023.1: Fix Cinder Integration fallout from CVE-2023-2088 https://review.opendev.org/c/openstack/ironic/+/883577 | 17:55 |
opendevreview | Merged openstack/ironic stable/zed: Fix Cinder Integration fallout from CVE-2023-2088 https://review.opendev.org/c/openstack/ironic/+/883578 | 18:05 |
TheJulia | reviews on https://review.opendev.org/c/openstack/ironic/+/883579?usp=search and https://review.opendev.org/c/openstack/ironic/+/883580 pleaes :) | 18:43 |
JayF | We should've enabled BFV job with those same PRs | 18:52 |
JayF | too late now but we should re-voting them asap | 18:52 |
ashinclouds[m] | Yeah | 18:54 |
TheJulia | Err yeah | 18:54 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/2023.1: Cinder bugs fixed; make BFV job vote again https://review.opendev.org/c/openstack/ironic/+/884280 | 19:35 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/2023.1: [ci] [stable-only] Cinderfixed; make BFV job vote https://review.opendev.org/c/openstack/ironic/+/884280 | 19:35 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/2023.1: [ci] [stable-only] Cinder fixed; make BFV job vote https://review.opendev.org/c/openstack/ironic/+/884280 | 19:36 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/zed: [ci] [stable-only] Cinder fixed; make BFV job vote https://review.opendev.org/c/openstack/ironic/+/884220 | 19:36 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/yoga: [ci] [stable-only] Cinder fixed; make BFV job vote https://review.opendev.org/c/openstack/ironic/+/884221 | 19:36 |
JayF | did we determine that https://review.opendev.org/c/openstack/ironic/+/883699 did nothing? | 19:48 |
JayF | I saw some chatter about mysql counters in grenade, curious if that patch is still valid | 19:48 |
opendevreview | Julia Kreger proposed openstack/ironic stable/wallaby: DNM Fix Cinder Integration fallout from CVE-2023-2088 https://review.opendev.org/c/openstack/ironic/+/883581 | 19:52 |
TheJulia | I think it helped with python 3.10 | 19:52 |
TheJulia | the question is what base python is being used | 19:52 |
JayF | so it will do no harm and potentially good to merge it | 19:52 |
JayF | it's not a noop change or actively harmful | 19:52 |
JayF | sounds like a do-it to me | 19:52 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/2023.1: CI: Disable mysql counters for grenade https://review.opendev.org/c/openstack/ironic/+/883699 | 19:53 |
opendevreview | Jay Faulkner proposed openstack/ironic master: Add ironic-grenade-skip-level Job https://review.opendev.org/c/openstack/ironic/+/836966 | 19:59 |
JayF | grenade (both) actually passed ^ \o/ I rebased it so the other jobs could pass | 20:02 |
NobodyCam | Good morning Ironic Folks, Happy Hump day | 20:07 |
NobodyCam | oh rescue more needs to hart beat :( | 20:08 |
JayF | o/ | 20:08 |
JayF | rescue mode does this: | 20:08 |
NobodyCam | \o JayF | 20:08 |
JayF | 1) boots a ramdisk / 2) ramdisk does usual lookup/hb flow / 3) ramdisk gets command to flip network as conductor flips networks in neutron | 20:09 |
* JayF curious what your actual goal is | 20:09 | |
NobodyCam | :) | 20:09 |
NobodyCam | boot a ramdisk on top of an instance that automatically runs some hardware tests and then boots back in to the instance | 20:10 |
JayF | you want active steps | 20:10 |
JayF | coming to an ironic near you in a few months, we hope | 20:10 |
NobodyCam | nice | 20:11 |
JayF | no real way to do that in Ironic today without patching | 20:11 |
NobodyCam | yep, I for see some hacking | 20:11 |
JayF | active steps (or what did we call them, service steps?) basically let you automate arbitrary steps, ala cleaning | 20:11 |
JayF | just on a machine that's active | 20:11 |
JayF | so active -> servicing -> active | 20:11 |
TheJulia | service steps | 20:11 |
JayF | plus some extra magic things TheJulia is adding that I think some crazy green NICs need ;) | 20:12 |
NobodyCam | hehehehe | 20:12 |
* JayF remains team red until NobodyCam ships him a 4090Ti | 20:12 | |
NobodyCam | LoL | 20:12 |
NobodyCam | oh looks like lunch is ready... BRB | 20:13 |
* TheJulia will need an array of 4090s | 20:14 | |
TheJulia | RAIGPU | 20:14 |
TheJulia | sounds sort of like a star wars character | 20:16 |
JayF | sounds like a brand of tomato sauce | 20:16 |
NobodyCam | hehheh | 20:25 |
TheJulia | https://review.opendev.org/c/openstack/ironic-specs/+/872349 <-- could use a +A.... | 20:26 |
TheJulia | oh, where are we at with sharding client patches? | 20:27 |
JayF | openstacksdk is landed | 20:38 |
JayF | I haven't looked at python-ironicclient in a while tbh | 20:38 |
JayF | I need to. Will set aside time tomorrow. | 20:38 |
TheJulia | k | 20:40 |
opendevreview | Maksim Malchuk proposed openstack/ironic-python-agent-builder master: Extend the DIB_CHECKSUM variable usage https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/881299 | 20:44 |
opendevreview | Merged openstack/ironic-specs master: Add service steps framework https://review.opendev.org/c/openstack/ironic-specs/+/872349 | 20:51 |
iurygregory | Thanks for doing the rebase while I was out JayF o/ | 21:22 |
iurygregory | https://review.opendev.org/c/openstack/ironic/+/883580 didn't pass bfv job... | 21:25 |
TheJulia | oh joy | 21:27 |
TheJulia | okay | 21:27 |
TheJulia | so xena and wallaby | 21:27 |
TheJulia | good to konw | 21:27 |
iurygregory | yeah | 21:27 |
TheJulia | c'est la vie | 21:27 |
TheJulia | I expected this on wallaby | 21:27 |
TheJulia | of sorts | 21:27 |
iurygregory | I will try to take a look (added to my list here) | 21:28 |
opendevreview | Julia Kreger proposed openstack/ironic master: Add hold steps https://review.opendev.org/c/openstack/ironic/+/879060 | 21:37 |
opendevreview | Julia Kreger proposed openstack/ironic master: Add wait step https://review.opendev.org/c/openstack/ironic/+/879061 | 21:37 |
opendevreview | Julia Kreger proposed openstack/ironic stable/wallaby: DNM Fix Cinder Integration fallout from CVE-2023-2088 https://review.opendev.org/c/openstack/ironic/+/883581 | 21:42 |
TheJulia | so yeah, we're jut navigating around support/behavior on the url format | 21:43 |
TheJulia | I think if we just drop our shorterner it might just work, there were some funky caveats/behavior around it | 21:43 |
opendevreview | Julia Kreger proposed openstack/ironic master: follow-up on DPU change api-ref https://review.opendev.org/c/openstack/ironic/+/884301 | 22:28 |
opendevreview | Merged openstack/ironic-tempest-plugin master: Fix rbac indicator tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/882619 | 22:31 |
TheJulia | \o/ | 22:49 |
iurygregory | \o/ | 23:06 |
opendevreview | Merged openstack/ironic stable/yoga: Fix Cinder Integration fallout from CVE-2023-2088 https://review.opendev.org/c/openstack/ironic/+/883579 | 23:18 |
opendevreview | Merged openstack/ironic master: DPU modeling - parent_node DB/Model/API https://review.opendev.org/c/openstack/ironic/+/880114 | 23:18 |
* TheJulia dances | 23:18 | |
opendevreview | Julia Kreger proposed openstack/ironic master: execute on child node support https://review.opendev.org/c/openstack/ironic/+/880545 | 23:18 |
opendevreview | Julia Kreger proposed openstack/ironic master: Add hold steps https://review.opendev.org/c/openstack/ironic/+/879060 | 23:18 |
iurygregory | I'm surprised that it didn't cause merge conflict with https://review.opendev.org/c/openstack/ironic/+/883968/ | 23:19 |
iurygregory | O.o | 23:19 |
iurygregory | now it's time for me to update my DB patch and change revision etc | 23:20 |
NobodyCam | crazy question would anyone be interested in a patch to bypass rescue wait mode? to boot up non ipa rescue images? | 23:21 |
NobodyCam | ie a configuration option to enable / disable rescue wait ? | 23:21 |
TheJulia | could you elaborate a little more? | 23:22 |
iurygregory | this would probably require some discussion I think (maybe at the weekly meeting) | 23:22 |
iurygregory | or maybe I'm thinking too much XD | 23:22 |
TheJulia | I'm trying to understand what the underlying issue is | 23:22 |
TheJulia | iurygregory: sorry for the revision issues, we're going to be goin gback and forth I suspect | 23:22 |
TheJulia | and I just double checked mine, no model_query usage | 23:22 |
TheJulia | we'll just need to be mindful moving forward | 23:23 |
NobodyCam | rescue wait expects a hart beat. The image I am deploying is a hardware test image, it is not built on a ipa image, so it is unable to hart beat. But it I skip rescue wait things work as expected. | 23:24 |
iurygregory | TheJulia, no worries, I was planning to have your patch landing first, since it also contains a bump in API etc | 23:24 |
iurygregory | newbie question, do a need to create a new revision or I can just update the down_revision and Revises in https://review.opendev.org/c/openstack/ironic/+/883031/12/ironic/db/sqlalchemy/alembic/versions/163040c5513f_add_firmware_information.py to match revision in your patch TheJulia ? | 23:28 |
TheJulia | NobodyCam: oh, your deploying a custom ramdisk without an agent | 23:28 |
NobodyCam | correct | 23:28 |
TheJulia | ahh :\ | 23:28 |
TheJulia | dunno, tbh | 23:28 |
TheJulia | iurygregory: just update down_revision | 23:29 |
TheJulia | *magic* | 23:29 |
iurygregory | =O | 23:29 |
iurygregory | nice | 23:29 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Add DB model for Firmware https://review.opendev.org/c/openstack/ironic/+/883031 | 23:37 |
opendevreview | Julia Kreger proposed openstack/ironic stable/xena: DNM: Test commit to get unpatched logs https://review.opendev.org/c/openstack/ironic/+/884302 | 23:53 |
TheJulia | to get logs w/r/t cinder, because I think we have a harder break to contend with on xena/wallaby | 23:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!