| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Trivial: attach versions to release series https://review.opendev.org/c/openstack/ironic/+/895778 | 09:47 |
|---|---|---|
| dtantsur | JayF, you may want this ^^^ before the release | 09:47 |
| dtantsur | hjensas, hey, thank you for https://bugs.launchpad.net/ironic/+bug/2036455, are you planning on fixing it yourself? | 09:54 |
| dtantsur | (or we can probably give it to oureachy interns, if we get any) | 10:28 |
| iurygregory | good morning ironic | 11:25 |
| opendevreview | Harald Jensås proposed openstack/ironic master: inspect_utils, handle bracketed IPv6 redfish addr https://review.opendev.org/c/openstack/ironic/+/895807 | 11:27 |
| hjensas | dtantsur: yes, I have proposed patches to both ironic-inspector and ironic. | 11:30 |
| dtantsur | thx! | 11:37 |
| iurygregory | why I'm not surprised to see someone asking if openstack projects are planning to change the coding language from Python to Go? :D | 12:20 |
| dtantsur | jesus... | 12:26 |
| ravlew | Good morning ironic | 12:37 |
| ravlew | jsyk this job was successful even though one of the tasks failed: https://zuul.opendev.org/t/openstack/build/9edff21bb28e4f0ba96d7cca55e93268 | 12:38 |
| ravlew | 1 job failed here: https://cc0741b30642056b8bca-c8461721173beff53bec22363106ef2b.ssl.cf5.rackcdn.com/893946/1/check/bifrost-integration-redfish-vmedia-uefi-centos-8/9edff21/logs/bifrost.log | 12:39 |
| ravlew | Ensure logrotate service is started returned "msg": "Could not find the requested service logrotate: host" | 12:39 |
| ravlew | also looking for some core reviews for bifrost logrotate backports to Antelope https://review.opendev.org/c/openstack/bifrost/+/893949 and Zed https://review.opendev.org/c/openstack/bifrost/+/893950 | 12:45 |
| opendevreview | Harald Jensås proposed openstack/ironic master: inspect_utils, handle bracketed IPv6 redfish addr https://review.opendev.org/c/openstack/ironic/+/895807 | 12:55 |
| opendevreview | Harald Jensås proposed openstack/ironic-inspector master: Handle bracketed IPv6 redfish_address https://review.opendev.org/c/openstack/ironic-inspector/+/895734 | 13:01 |
| TheJulia | brraaaaiiinnnsss | 13:16 |
| opendevreview | Huy Mai proposed openstack/sushy-tools master: Add fake_ipa inspection, lookup and heartbeater to fake system https://review.opendev.org/c/openstack/sushy-tools/+/875366 | 13:18 |
| adam-metal3 | dtantsur, hi, I have seen you increased the priority of the multipathd issue, is someone already working on it or is it still fine if I do it ? I had no time yet but soon... | 13:36 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: Update the project status and move broken jobs to experimental https://review.opendev.org/c/openstack/ironic-inspector/+/895164 | 13:38 |
| TheJulia | JayF: dtantsur: so the job ended up swapping launching 4 1 GB VMs on an 8 GB test node.... And OOMing. :\ | 13:39 |
| TheJulia | I've tuned it down as such. | 13:39 |
| dtantsur | I expected something like that | 13:44 |
| JayF | thank you Julia for that | 14:03 |
| iurygregory | I think I fixed the DB problem \o/ | 14:09 |
| opendevreview | Kaifeng Wang proposed openstack/ironic-python-agent master: Fix un-serialized hwinfo returned from IPA https://review.opendev.org/c/openstack/ironic-python-agent/+/894894 | 14:11 |
| dtantsur | JayF, it's outreachy time, wdyt about this idea: https://etherpad.opendev.org/p/ironic-outreachy ? | 14:12 |
| JayF | dtantsur: when does outreachy start? | 14:12 |
| JayF | dtantsur: I have an MLH fellow starting their fellowship next week (means they should be in IRC in a couple weeks) | 14:13 |
| dtantsur | JayF, it will be something like Dec-Feb, but the projects need to be submitted by end of Sep | 14:13 |
| JayF | DM'd you the equivalent for my fellowship; it's just a googley doc so don't want it in the channel | 14:14 |
| * TheJulia needs new sinuses | 14:17 | |
| JayF | dtantsur: reflecting on the content of that etherpad, two comments: 1) client/sdk should be first class, not bonus 2) Just personally, seems like we could prioritize the fields to migrate out (maybe cpu_arch and *_network first?) | 14:29 |
| opendevreview | Jake Hutchinson proposed openstack/bifrost master: Bifrost NTP configuration https://review.opendev.org/c/openstack/bifrost/+/895691 | 14:30 |
| opendevreview | Merged openstack/ironic stable/2023.1: Fix anaconda stage2_id loading from image properties https://review.opendev.org/c/openstack/ironic/+/883575 | 14:30 |
| dtantsur | JayF, 1) I sorta agree, but it may simply fall out of the 3 months window | 14:34 |
| dtantsur | 2) I put network stuff last as it's somewhat more complex (I mean, the location in the code where they're used) | 14:34 |
| JayF | ah that's a good point | 14:35 |
| JayF | and cpu_arch has some config tied into it now | 14:35 |
| JayF | (kuba's changes) | 14:35 |
| JayF | dtantsur: TheJulia: FYI https://github.com/openstack/oslo.db/commit/115c3247b486c713176139422647144108101ca3 is about to be released and included in 2023.2 | 14:38 |
| JayF | dtantsur: TheJulia: That should eliminate any straggler node locking issues and also hide them so I wanted you to be aware | 14:39 |
| TheJulia | ... I want booze | 14:39 |
| dtantsur | fun.... | 14:45 |
| JayF | real fail in the latest grenade run, it seems? | 14:53 |
| JayF | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f72/895164/5/experimental/ironic-inspector-grenade/f723908/controller/logs/grenade.sh_log.txt | 14:53 |
| JayF | > 2023-09-19 14:26:52.578 | No attached ports found to associate floating IP with | 14:53 |
| TheJulia | nova_server1 failed to create | 15:01 |
| TheJulia | Node 72a1883e-a7b8-495e-8bf2-c8614ecab2e2 moved to provision state "deploy failed" from state "wait call-back"; target provision state is "active" | 15:03 |
| TheJulia | wow, not enough ram | 15:03 |
| TheJulia | lets fix that | 15:03 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: Update the project status and move broken jobs to experimental https://review.opendev.org/c/openstack/ironic-inspector/+/895164 | 15:03 |
| JayF | What do folks think abuot https://review.opendev.org/c/openstack/ironic/+/765569 ? | 15:46 |
| JayF | (port name API changes) | 15:46 |
| JayF | I am not keen on landing a new API microversion a couple of days before we release | 15:46 |
| JayF | but I didn't want to make that decision in a vacuum | 15:46 |
| JayF | we either need to land it nowish or make it wait | 15:46 |
| JayF | unless we know of an urgent need for this change; I'd rather it wait | 15:47 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/863999/ should be landed for the release, needs 1 more +2; it's a kinda-bugfix that is unlikely to be backportable so we need to get it in | 15:48 |
| dtantsur | https://review.opendev.org/c/openstack/ironic/+/895778 has a release note fix | 15:49 |
| JayF | I've got a +2 on that | 15:49 |
| dtantsur | yeah, thanks, highlighting for other reviewers | 15:50 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/895729 needs another +2A as well for redfish v6 fix | 15:50 |
| JayF | dtantsur: opinions on port name API? | 15:50 |
| dtantsur | thinking | 15:50 |
| JayF | The more I think abuot it and look at context (it's been ongoing since Dec 2022) the more I land on "wait and have it be the first patch after release is cut" | 15:50 |
| JayF | we don't even have client support for name | 15:51 |
| dtantsur | true | 15:51 |
| JayF | syntax sugar without client support is just a potential to break stuff IMO | 15:51 |
| opendevreview | Jake Hutchinson proposed openstack/bifrost master: Bifrost NTP configuration https://review.opendev.org/c/openstack/bifrost/+/895691 | 15:51 |
| dtantsur | hmm, I don't like the new version of the Harald's patch.. | 15:52 |
| JayF | I'll be interested to see your comment | 15:52 |
| JayF | inspector hooks landing in Ironic before release is not useful, right? Those only become living code when we are done with inspector? | 15:54 |
| JayF | re: https://review.opendev.org/c/openstack/ironic/+/890817 (I am trying not to pop things in the gate unless we need them for release, since gate is highly loaded) | 15:54 |
| dtantsur | JayF, they can be used today, but chances are high most people won't use them | 15:55 |
| JayF | ack; I will wait on that one too | 15:55 |
| dtantsur | okay, the Harald's patch is fine, I forgot about some exotic cases in parsing Redfish stuff | 15:57 |
| JayF | dtantsur: you forgot to +2, you just +A'd :P | 15:57 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/895729 not that it /really/ matters but it wouldn't hurt to make it right lol | 15:57 |
| dtantsur | I do that pretty often when I'm lazy :D | 16:02 |
| JayF | you don't get credit in stats for a review on that, I think | 16:02 |
| dtantsur | poor me | 16:02 |
| JayF | which likely doesn't matter for you but it does for some | 16:02 |
| JayF | lol | 16:02 |
| JayF | I think at this point people know you're doing stuff though :P | 16:02 |
| dtantsur | they seem to be getting used to me, apparently :D | 16:03 |
| iurygregory | https://paste.opendev.org/show/bu8hVLWX7jxYcNUE4lZb/ \o/ | 16:23 |
| iurygregory | but the node is still in clean wait for some reason... | 16:23 |
| iurygregory | https://paste.opendev.org/show/bnohAuBsl8o78zeA8QNE/ | 16:24 |
| JayF | CI failed as well, I wonder if that means there's something missing inthe state transition that should be findable | 16:25 |
| iurygregory | https://paste.opendev.org/show/bz9QAdUqUHuhxq6G9FDN/ | 16:26 |
| JayF | https://zuul.opendev.org/t/openstack/build/37a73dcb494043e094c4d08b199a6d6b 3 hour timeout is highly sucpisious | 16:26 |
| iurygregory | \o/ it worked | 16:26 |
| * iurygregory is crying | 16:26 | |
| JayF | nice | 16:26 |
| JayF | now just convince CI and you'll be the big winner ;) | 16:26 |
| iurygregory | well, first I need to update the patch based on the reviews and re-test hehe | 16:27 |
| iurygregory | after going to the doc appointment I have in 30min | 16:27 |
| iurygregory | brb | 16:27 |
| opendevreview | Merged openstack/ironic master: redfish_address - wrap_ipv6 address https://review.opendev.org/c/openstack/ironic/+/895729 | 17:20 |
| opendevreview | Merged openstack/ironic master: inspect_utils, handle bracketed IPv6 redfish addr https://review.opendev.org/c/openstack/ironic/+/895807 | 17:41 |
| opendevreview | Harald Jensås proposed openstack/ironic stable/2023.1: redfish_address - wrap_ipv6 address https://review.opendev.org/c/openstack/ironic/+/895795 | 18:44 |
| JayF | TheJulia !!!! ironic-inspector-grenade https://zuul.opendev.org/t/openstack/build/76929125092441838cffe7cad5620306 : SUCCESS in 56m 10s | 18:53 |
| JayF | tempest is still failing but you fixed grenade | 18:53 |
| * JayF throws a ticker-tape parade | 18:53 | |
| opendevreview | Verification of a change to openstack/ironic stable/wallaby failed: [iRMC] Fix parse_driver_info bug enforcing SNMP v3 under FIPS mode https://review.opendev.org/c/openstack/ironic/+/885246 | 18:57 |
| iurygregory | do we need to approve any patches to unblock the inspector CI? let me know | 19:12 |
| JayF | I'll let you know. I might try to figure out the tempest job before we land that, and I think if we get them passing we'll want to move them back out of experimental | 19:15 |
| opendevreview | Jay Faulkner proposed openstack/ironic-inspector master: Fix bindep for debian bookworm for py3.11 https://review.opendev.org/c/openstack/ironic-inspector/+/895855 | 19:45 |
| iurygregory | TheJulia, regarding https://review.opendev.org/c/openstack/ironic/+/885425/5/ironic/drivers/modules/redfish/firmware.py#300 do you think we should add a new config? just double checking since I'm pushing a new patch set in a few | 19:49 |
| iurygregory | also if anyone has thoughts about the other two comments that are open let me know | 19:49 |
| JayF | iurygregory: when in doubt, I typically go the route of new config | 19:50 |
| JayF | but that may not be a good universal rule; it's just mine :) | 19:50 |
| iurygregory | I'm trying to figure out the save_and_reraise_exception and if we should handle get_task with try/except | 19:50 |
| iurygregory | JayF, I would totally add a new config, but names will be very close to the ones we have and people can get confused pretty easily I would say =) | 19:51 |
| JayF | yep | 19:51 |
| JayF | that's the other side | 19:51 |
| JayF | that's why I say I may not be right :D | 19:51 |
| iurygregory | got it =) | 19:51 |
| JayF | iurygregory: I just posted a comment about that get_task -- we should ensure a bug gets filed for those other uses that don't have err handlind | 19:52 |
| JayF | iurygregory: so we can fix+backport the fix after firmware is done | 19:52 |
| * iurygregory looks | 19:52 | |
| iurygregory | JayF, ack =) | 19:53 |
| iurygregory | JayF, now I'm wondering if we don't already cover the case of errors in get_task, this is from TaskMonitor in sushy and we are already handling error when we get the TaskMonitor via redfish_utils.get_task_monitor ... | 20:06 |
| JayF | I'll be honest, I trust you know more than me | 20:06 |
| iurygregory | <thinking face> | 20:06 |
| JayF | but if there is a bug lets make sure it gets more than a note in a gerrit change :D | 20:06 |
| iurygregory | ++ | 20:07 |
| iurygregory | or maybe we should be first using the property https://github.com/openstack/sushy/blob/82772d3424d739b69fd096a169ab211aa7adc737/sushy/taskmonitor.py#L152 and in case is None we do get_task to initialize it... | 20:09 |
| * iurygregory grabs more coffee | 20:09 | |
| JayF | tempest job is still failing with partition image shenanigans in inspector | 20:43 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: RedfishFirmware Interface https://review.opendev.org/c/openstack/ironic/+/885425 | 21:25 |
| TheJulia | JayF: did the held node reveal anything? | 21:27 |
| TheJulia | or was it for a different job? | 21:27 |
| JayF | TheJulia: I held one for grenade, for overnight last night, the issue you had fixed before I was on IRC | 21:27 |
| JayF | TheJulia: so there is no held one for the partition job | 21:28 |
| JayF | I can ask them to hold one for that but my thought was ... update your PR, lets land it, then do tempest as a separate change? | 21:28 |
| TheJulia | you could hold one, but I have good confidence in the overall code state. Test bitrot most likely | 21:28 |
| JayF | Me too | 21:28 |
| TheJulia | Well, it was Dmitry's changeset | 21:28 |
| TheJulia | originally | 21:28 |
| JayF | I think at this point we all own it a little? lol | 21:29 |
| TheJulia | heh, yeah | 21:29 |
| JayF | I'd prefer grenade be back in check, even if -nv | 21:29 |
| JayF | given it's working right now | 21:29 |
| TheJulia | I'm fine with the release note as-is, fwiw | 21:29 |
| JayF | I have a +2 on the change | 21:29 |
| TheJulia | k | 21:29 |
| TheJulia | jfdi'ed | 21:30 |
| JayF | in that case also https://review.opendev.org/c/openstack/ironic-inspector/+/895855 that one please | 21:30 |
| TheJulia | JayF: did you see, the in the original state of the zuul project config, the tempest job your chasing was non-voting to begin with... I wonder how long it has been nv | 21:31 |
| JayF | heh. hehehehe. heheheheheheheheheheheheheheheheheheheheh 😭😭😭😭😭😭😭😭😭😭😭😭😭 | 21:32 |
| TheJulia | ewwww | 21:34 |
| TheJulia | so, that job, should likely have been shutdown a while ago | 21:34 |
| JayF | yes | 21:34 |
| TheJulia | explicitly set to netboot | 21:34 |
| JayF | TheJulia: That elicitied a major WTF to me when I saw it, and started searching our code for references to that env var | 21:35 |
| JayF | TheJulia: my brain went more like "of course it doesn't work if it says netboot" than "of course it's bitrotted if it says netboot" LOL | 21:35 |
| TheJulia | TheJulia and dtantsur have since murdered "classic netboot", and grub now has to work, and it may never have in the image | 21:35 |
| JayF | yep | 21:35 |
| * JayF goes to kill that job | 21:36 | |
| JayF | well I gotta wait for yours to merge | 21:36 |
| JayF | I'll kill it in the morning lol | 21:36 |
| TheJulia | ok | 21:36 |
| TheJulia | so the difference is managed_boot | 21:36 |
| TheJulia | and it is the only job where that flag is set | 21:36 |
| TheJulia | so maybe move that flag elsewhere... *shrug* | 21:36 |
| JayF | Or just make damned sure we migrate inspector next cycle | 21:36 |
| JayF | and slim our matrix down | 21:37 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: CI: re-add genade job to normal CI queues https://review.opendev.org/c/openstack/ironic-inspector/+/895863 | 21:37 |
| * JayF gets in his openstack time machine and convinces everyone that inspector was a part of Ironic all along | 21:37 | |
| JayF | [opens eyes] did it work? | 21:37 |
| TheJulia | No, what did you change?!?! My cats have been replaced with moopsy | 21:38 |
| TheJulia | And if you don't get that reference: https://www.youtube.com/watch?v=P2oMlTFUJgo | 21:39 |
| JayF | geeze, spoilers for lower decks :D | 21:39 |
| JayF | that is hilarious | 21:40 |
| * TheJulia needs many moopsy | 21:40 | |
| opendevreview | Merged openstack/ironic-inspector master: Update the project status and move broken jobs to experimental https://review.opendev.org/c/openstack/ironic-inspector/+/895164 | 22:30 |
| opendevreview | Merged openstack/ironic-inspector master: Fix bindep for debian bookworm for py3.11 https://review.opendev.org/c/openstack/ironic-inspector/+/895855 | 22:31 |
| JayF | \o/ | 22:32 |
| TheJulia | iurygregory: one thing on https://review.opendev.org/c/openstack/ironic/+/885425 | 22:38 |
| TheJulia | just for consistency and all | 22:38 |
| iurygregory | TheJulia, tks | 22:44 |
| iurygregory | I'm wondering which number it should be | 22:45 |
| iurygregory | in cleaning I added before management, thinking about the same in deploy (if makes sense) | 22:45 |
| TheJulia | likely 3 or 4 | 22:47 |
| TheJulia | closer to the hardware is generally lower, for some reason deploy is in the middle | 22:47 |
| TheJulia | *shrug* | 22:47 |
| TheJulia | also firmware is closer to management, I guess any number could be made argument wise | 22:47 |
| iurygregory | ack =) | 22:47 |
| JayF | deploy is almost always talking about doing stuff to the disk | 22:48 |
| JayF | so it makes sense as kinda close to the hardware | 22:48 |
| JayF | I can see it | 22:48 |
| TheJulia | yeah | 22:48 |
| TheJulia | management *should* be lower in the lists, but it is not | 22:48 |
| TheJulia | c'est la vie | 22:48 |
| TheJulia | iurygregory: take a look at like 70, but admittedly I don't grok verify steps | 22:49 |
| * iurygregory looks | 22:49 | |
| * TheJulia runs to the market | 22:50 | |
| iurygregory | the part about highest value will be executed first? | 22:50 |
| TheJulia | no, likely should put it in the list there too | 22:51 |
| TheJulia | since anytime a step can be executed with the reference order | 22:51 |
| iurygregory | ack | 22:51 |
| iurygregory | jesus, I just noticed the list is not in order :D | 22:51 |
| iurygregory | 7,9,10,8,11,12 | 22:52 |
| JayF | good thing you care and are editing that code | 22:52 |
| JayF | it won't be disordered long! | 22:52 |
| iurygregory | consider it done =) | 22:53 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: RedfishFirmware Interface https://review.opendev.org/c/openstack/ironic/+/885425 | 22:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!