| rpittau | good morning ironic! o/ | 07:19 |
|---|---|---|
| adam-metal3 | good morning | 07:21 |
| iurygregory | good morning Ironic | 11:34 |
| iurygregory | rpittau, hey o/ since you worked in adding the metal3-integration job , I'm a bit puzzled why in the Firmware Interface patches it was green but in metal3 I see sqlalchemy complaining https://github.com/metal3-io/ironic-image/pull/438 .-. | 11:48 |
| rpittau | iurygregory: that looks a bit different from the "old" sqlite issue, it's telling you that the constraint for a value is set to NULL and it should not be | 12:08 |
| iurygregory | agree, I'm just wondering why metal3-integration didn't catch it | 12:09 |
| iurygregory | trying to figure out how to fix this tbh | 12:17 |
| rpittau | iurygregory: maybe there's some default value that is not set in metal3? | 12:22 |
| rpittau | iurygregory: at which point is that happening? | 12:24 |
| iurygregory | this was the change I did https://github.com/metal3-io/ironic-image/pull/438/files | 12:24 |
| rpittau | iurygregory: yeah, I saw the patch, but when is the error happening? :) | 12:24 |
| iurygregory | rpittau, from the logs I got from the job, it seems like after it enters in cleaning | 12:27 |
| iurygregory | the conductor does Getting Firmware Components for node 4561c0ef-bd24-44d2-b855-fcbc12efc28a node_cache_firmware_components /usr/lib/python3.9/site-packages/ironic/conductor/utils.py:1837 | 12:28 |
| rpittau | iurygregory: so during the test phase not the first provisioning phase? | 12:28 |
| rpittau | nvm I see that it fails during provisioning | 12:29 |
| iurygregory | humm I have the feeling sushy-tools is missing information D: | 12:29 |
| rpittau | could be | 12:30 |
| iurygregory | and this is causing the error | 12:30 |
| rpittau | maybe we need to bump its version | 12:30 |
| rpittau | https://github.com/metal3-io/ironic-image/blob/main/resources/sushy-tools/Dockerfile#L3 | 12:30 |
| * iurygregory looks | 12:31 | |
| rpittau | iurygregory: no, wait, my bad, I read the logs completely wrong, the failure is in the test phase, so we don't catch it in ironic CI integration job | 12:34 |
| rpittau | we run provisioning but not testing because of limitations in the CI resources | 12:34 |
| TheJulia | good morning | 12:34 |
| rpittau | good morning TheJulia :) | 12:34 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Advanced vmedia deployment test ops https://review.opendev.org/c/openstack/ironic/+/898010 | 12:36 |
| iurygregory | rpittau, I see | 12:37 |
| iurygregory | I think I found the issue | 12:37 |
| iurygregory | https://github.com/openstack/ironic/blob/341f80e24dc06a2149aa3ad9730309a57c98283a/ironic/drivers/modules/redfish/firmware.py#L93-L95 | 12:37 |
| iurygregory | I expect that we will always have the bios information from the BMC | 12:38 |
| rpittau | ah there you go :) | 12:38 |
| iurygregory | and sushy-tools doesn't have the field BiosVersion https://github.com/openstack/sushy-tools/blob/0246649c06c0ec2a7579f087ebf26f9fbdceffdd/sushy_tools/emulator/templates/system.json | 12:38 |
| iurygregory | :D | 12:38 |
| iurygregory | time for a quick PR adding the field, and later I will add try except in cache_firmware_component to handle the case where we can't find the information | 12:39 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: Add test for dhcp-less vmedia based deployment https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/898006 | 12:44 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/sushy-tools master: Add BiosVersion field to System https://review.opendev.org/c/openstack/sushy-tools/+/899262 | 12:44 |
| * TheJulia tries to wake up | 12:47 | |
| iurygregory | rpittau, I think this will likely help ^ | 12:47 |
| iurygregory | just double checking we would need a new release and bump the version in metal3 right? | 12:48 |
| rpittau | iurygregory: yes, or I guess you could use an hash, you could also run a test with your patch slightly modifying the sushy-tools container and running a PR with that | 12:56 |
| JayF | can someone explain the physics of how my alarm, despite being set to the same time for three days, seems to be going off earlier and earlier each day :P (emphasis on the *seems* :D) | 12:58 |
| iurygregory | rpittau, the first part I understand, the second one I'm thinking on how it could be done... | 12:58 |
| JayF | ptg in 2 mins | 12:58 |
| TheJulia | JayF: see definition of being cursed | 13:04 |
| iurygregory | if anyone has spare time for reviews today, I would appreciate some eyes on https://review.opendev.org/c/openstack/sushy-tools/+/899262 https://review.opendev.org/c/openstack/ironic/+/897989 =) | 17:09 |
| JayF | I have a couple trivials up on IPA I should tag as prio | 17:11 |
| iurygregory | ack | 17:12 |
| JayF | https://review.opendev.org/c/openstack/ironic-python-agent/+/369245 https://review.opendev.org/c/openstack/ironic-python-agent/+/899214 | 17:13 |
| iurygregory | I was about to say i don't see in https://review.opendev.org/q/hashtag:ironic-week-prio+status:open+project:openstack/ironic-python-agent | 17:13 |
| JayF | I was tagging them right then :D | 17:14 |
| iurygregory | ohhhhh | 17:14 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: WIP/DNM: Get rid of simple-init (but keep glean) https://review.opendev.org/c/openstack/ironic-python-agent/+/895519 | 17:17 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Advanced vmedia deployment test ops https://review.opendev.org/c/openstack/ironic/+/898010 | 17:29 |
| JayF | Do we have someone who is volunteering for "Cleaning up RAID created by tenants"? | 17:41 |
| JayF | it's a carryover item we haven't mentioned yet | 17:41 |
| JayF | If there is a small group of Ironic cores particularly interested in the Ironic docs problem as discussed in Monday's meeting, and would be interested in a separate meeting to discuss requirements around if we contracted in a documentation expert, please let me know. We'd likely be having a meeting to chat about it downstream mid/late November. | 18:38 |
| JayF | TheJulia: dtantsur ^ | 18:38 |
| JayF | to be clear; it'd include one of my leaders from GR-OSS downstream | 18:38 |
| dtantsur | JayF: i'm interested in the docs topic | 18:50 |
| * dtantsur should really stop staring at the internet and go get some food | 18:50 | |
| JayF | What times are best for you, for a scheduled meeting? | 18:50 |
| dtantsur | JayF: Tuesday is usually pretty free for me (except for 13:00 UTC), also Monday right before our meeting | 18:51 |
| JayF | I mean more like in terms of, time of day, you're CEST? | 18:52 |
| dtantsur | CEST, yep, normally active between 8:00 and 17:00 UTC | 18:52 |
| JayF | ack | 18:53 |
| opendevreview | Merged openstack/ironic-python-agent master: Remove standby.cache_image support https://review.opendev.org/c/openstack/ironic-python-agent/+/899214 | 19:02 |
| opendevreview | Jay Faulkner proposed openstack/ironic-specs master: [Draft] 2024.1 vPTG Planning Notes: Ironic Work Items https://review.opendev.org/c/openstack/ironic-specs/+/899297 | 19:07 |
| JayF | please feel free to JFDI edit any todo items in there, or really just anything that seems off kilter | 19:08 |
| TheJulia | ack | 19:13 |
| TheJulia | Would ya'all be up for another PTG topic tomorrow? | 19:18 |
| TheJulia | of the semi-fun idea variety? | 19:19 |
| iurygregory | TheJulia, if we have time, why not? =) | 22:05 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Advanced vmedia deployment test ops https://review.opendev.org/c/openstack/ironic/+/898010 | 22:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!