| opendevreview | Merged openstack/ironic master: Change snmp job to not use a focal node https://review.opendev.org/c/openstack/ironic/+/893824 | 00:49 |
|---|---|---|
| rpittau | happy friday ironic! o/ | 08:04 |
| adam-metal3 | happy friday o/ | 08:08 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [trivial] remove note on non-voting snmp job https://review.opendev.org/c/openstack/ironic/+/902358 | 08:16 |
| opendevreview | Adam Rozman proposed openstack/ironic master: fix nits related to image server bauth https://review.opendev.org/c/openstack/ironic/+/902363 | 09:19 |
| opendevreview | Merged openstack/ironic bugfix/23.1: Update .gitreview for bugfix/23.1 https://review.opendev.org/c/openstack/ironic/+/902251 | 09:53 |
| iurygregory | good morning Ironic | 11:10 |
| opendevreview | Jakob Meng proposed openstack/sushy-tools master: Use existing nvram path in libvirt driver to support session daemon mode https://review.opendev.org/c/openstack/sushy-tools/+/902418 | 13:54 |
| TheJulia | good morning | 14:22 |
| JayF | edebeste: o/ welcome friend! | 14:43 |
| JayF | morning all. I am medicated and hopefully that will get me through a larger amount of the day :) | 14:47 |
| TheJulia | good morning medicated one! | 14:48 |
| TheJulia | Hopefully feeling better? | 14:50 |
| JayF | incrementally so | 14:59 |
| JayF | one of those things where like, if one dose of antibiotics has me feeling more human this morning, I have hope for the weekend lol | 14:59 |
| iurygregory | glad to hear you are feeling better JayF o/ | 15:13 |
| TheJulia | JayF: awesome! | 15:23 |
| rpittau | bye everyone, have a great weekend! o/ | 15:37 |
| TheJulia | o/ | 15:38 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Handle internal server errors while configuring secure boot https://review.opendev.org/c/openstack/ironic/+/902431 | 16:38 |
| TheJulia | Hi, my name is Julia, and I just spent an hour tying to figure out why a piece of code was not working to realize it was the indentation was off on one line from a copy/paste. | 17:00 |
| dtantsur | Python is great, isn't it? | 17:01 |
| * dtantsur regularly finds himself changing a wrong function | 17:01 | |
| * JayF pats his IDE on the head | 17:11 | |
| iurygregory | normally my IDE would tell me about the indentation =X | 17:14 |
| dtantsur | It won't help if both wrong and right indentation is correct from the syntax perspective :) | 17:15 |
| iurygregory | ok maybe is a dump question, but I've spent enough time already trying to test something locally.... I'm trying to handle the ProxyError in https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/inspector.py#L123-L154 , I have the feeling we are not retrying at all .-. I've setup a Flask to raise ProxyError https://paste.opendev.org/show/bMMI56J6UPGD575Nc96q/ and this is the code I was using to make the | 17:28 |
| iurygregory | requests https://paste.opendev.org/show/b1SeTD0tkavXqgw6ImOl/ but in my output I only get "Sending POST request to 127.0.0.1:5000" once .-. https://paste.opendev.org/show/bM2NJ1KIHFmWhkIsdwFL/ | 17:28 |
| dtantsur | iurygregory: have you fixed https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/inspector.py#L148 ? | 17:29 |
| TheJulia | In this case, the indentation was actually correct, but not for what I was trying to do | 17:29 |
| iurygregory | dtantsur, I've tested without that line also | 17:30 |
| dtantsur | iurygregory: not "without that line" but actually, you know, make something raise the exception you expect :) | 17:31 |
| iurygregory | but I still don't see the message "Sending... " 3 times in my terminal | 17:31 |
| iurygregory | dtantsur, the flask application is responding with 502 .-. | 17:31 |
| iurygregory | 127.0.0.1 - - [01/Dec/2023 14:30:20] "POST / HTTP/1.1" 502 - | 17:31 |
| dtantsur | so what? requests does not raise by default | 17:31 |
| iurygregory | seems like it | 17:31 |
| dtantsur | I've mentioned it already the last time: this code does not use raise_for_status or anything else that would turn HTTP status codes into exceptions | 17:32 |
| iurygregory | I'm wondering about using raise_for_status | 17:32 |
| dtantsur | without it, any HTTP code will result in a Response object. Any. | 17:32 |
| dtantsur | Only TCP-level connection issues result in an exception right now. | 17:32 |
| iurygregory | woot | 17:33 |
| iurygregory | raise_for_status seems to be the thing | 17:33 |
| iurygregory | if I use it and I change the type of exception in the decorator it works | 17:34 |
| iurygregory | so maybe in _post_to_inspector we should check what is the response and raise the exception accordingly ? | 17:34 |
| dtantsur | Yep, that's one way to fix that. | 17:35 |
| iurygregory | https://paste.opendev.org/show/bA13AbkfNQnWsHydtoN3/ the code that worked locally =) | 17:36 |
| iurygregory | something along the lines https://paste.opendev.org/show/bbSwAoOyjucaJMxog31E/ | 17:38 |
| iurygregory | time to create a new IPA bug | 17:42 |
| iurygregory | https://bugs.launchpad.net/ironic-python-agent/+bug/2045429 | 17:47 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Handle Power On/Off for child node cases https://review.opendev.org/c/openstack/ironic/+/896570 | 18:17 |
| TheJulia | okay, I think that covers it for that | 18:18 |
| TheJulia | Time to take the corgi overlord to the location of "one week of corgi playtime" | 18:19 |
| iurygregory | one week of corgi playtime, I'm sure the corgi will have a lot of fun =) | 18:20 |
| dtantsur | Good to be a corgi | 18:20 |
| TheJulia | As long as he doesn't suddenly bring home a girlfriend, I'm okay with him having fun | 18:21 |
| dtantsur | Well, that happens with kids pretty often | 18:21 |
| * dtantsur done that | 18:21 | |
| TheJulia | True... | 18:22 |
| opendevreview | Jakob Meng proposed openstack/sushy-tools master: Use existing nvram path in libvirt driver to support session daemon mode https://review.opendev.org/c/openstack/sushy-tools/+/902418 | 18:53 |
| JayF | dtantsur: question re https://review.opendev.org/c/openstack/ironic/+/900568/7#message-b900d8d2768d4b3977431714a9e2db8cb8b8d184 -- should we hide new keys in JSON fields behind new API microversions? | 20:06 |
| JayF | dtantsur: response in gerrit would be appreciated since this is a proxied question for my MLH fellow not on IRC :) | 20:07 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Add volume name to Redfish RAID volumes https://review.opendev.org/c/openstack/ironic/+/902446 | 20:57 |
| masghar | Once (hopefully) this is green in the CI, can someone please review it? (Asking so that when it merges, I can have a fresh ironic rpm for testing in ironic-image)..I wonder how frequently those rpms are created | 21:04 |
| opendevreview | Merged openstack/ironic master: fix nits related to image server bauth https://review.opendev.org/c/openstack/ironic/+/902363 | 21:13 |
| JayF | FYI; boushra and I noticed that webapi-version-history.rst wasn't updated with the latest change to add virtual media plug/unplug via API | 21:27 |
| JayF | the update she's pushing to her change for ovn vtep support (coming up soon) will include an update for that | 21:27 |
| JayF | since we updated it for her microversion, too | 21:27 |
| JayF | We're also cleaning up some tech debt around api-ref for port.local_link_connection | 21:28 |
| iurygregory | masghar, if you mean downstream we will only build rpms after the change is in sync in openstack-ironic downstream, if you mean in metal3 I think it uses ironic source code so after it merges if you install things it will pull latest code (you can also build an ironic image with a gerrit change =) ) | 21:39 |
| TheJulia | masghar: A release note would be good, I guess I'm also trying to understand any additional context. Was this just not working if we have a disk_name field?! | 21:43 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent master: [WIP] Retry in inspector errors https://review.opendev.org/c/openstack/ironic-python-agent/+/902448 | 21:45 |
| TheJulia | folks, I'm wrapping up my day. If there is anything you need speak soon :) | 21:49 |
| iurygregory | have a great weekend everyone! | 21:50 |
| TheJulia | I'm out next week, back the week after, and then out until January | 21:50 |
| * TheJulia whispers "httpboot" "httpboot" "httpboot" | 21:50 | |
| iurygregory | oh wow =O | 21:50 |
| iurygregory | PTO for me only on January :D | 21:51 |
| TheJulia | Ugh: https://bugs.launchpad.net/ironic/+bug/2045191 | 21:51 |
| iurygregory | oh perfect | 21:52 |
| iurygregory | another corner case =) | 21:53 |
| JayF | 'our' implementation makes me wonder if that is a gigabyte employee | 21:53 |
| JayF | (doubtful after some digging) | 21:54 |
| TheJulia | yeah | 21:55 |
| TheJulia | Apparently there is an exact name match which is a director of the local art museum | 21:56 |
| TheJulia | I've replied requesting more information | 22:11 |
| JayF | TheJulia: janders: Wonder if we should get janders' tool to them to get a schema for their BMC | 22:25 |
| TheJulia | Just need the system endpoint, really | 22:27 |
| TheJulia | but overall it would be interesting too | 22:27 |
| opendevreview | Merged openstack/ironic master: Improve logging in the dnsmasq DHCP provider https://review.opendev.org/c/openstack/ironic/+/902091 | 23:20 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!