| dking | JayF: FYI, I'm currently at a diff of 245 lines making the updates before refactoring. Every update so far has involved a get_managers call that had to be mocked. I suspect the refactor wouldn't be more than 20 lines and be more general use. I'll probably have to continue this tomorrow. | 00:32 |
|---|---|---|
| JayF | You can do the refactor first if you want, like I said, just please post it as a separate thing regardless of the ordering :) | 00:33 |
| dking | JayF: Oh, thank you. That would be much more helpful. | 00:33 |
| JayF | yeah, that's what I meant earlier; I'm sorry if it wasn't clear | 00:34 |
| JayF | it's just a question of landing one change before you get what you want or two :) | 00:34 |
| JayF | (what you want == the actual change to make it easier to skip things in custom managers) | 00:34 |
| opendevreview | Merged openstack/ironic master: Tempest test with only wholedisk for some jobs https://review.opendev.org/c/openstack/ironic/+/913270 | 00:46 |
| opendevreview | Merged openstack/ironic master: Release notes prelude for 2024.1/24.1 https://review.opendev.org/c/openstack/ironic/+/912679 | 01:58 |
| opendevreview | Merged openstack/ironic master: docs: augment admin troubleshooting docs for system scope context https://review.opendev.org/c/openstack/ironic/+/908203 | 01:58 |
| opendevreview | Merged openstack/ironic master: Update regex to detect closed branch https://review.opendev.org/c/openstack/ironic/+/912730 | 01:58 |
| opendevreview | OpenStack Proposal Bot proposed openstack/ironic-inspector master: Imported Translations from Zanata https://review.opendev.org/c/openstack/ironic-inspector/+/906935 | 03:04 |
| rpittau | good morning ironic! o/ | 08:16 |
| rpittau | TheJulia, iurygregory, thanks for investigating the issue with the CI jobs! :) | 08:30 |
| Nisha_Agarwal | rpittau, i saw the proliantutils and ironic patches | 11:53 |
| Nisha_Agarwal | Are they mandatory for this release? or can be done in next release? | 11:54 |
| iurygregory | good morning Ironic | 12:15 |
| iurygregory | rpittau, np! | 12:15 |
| dtantsur | https://review.opendev.org/c/openstack/ironic/+/910642 is pretty easy, could I get some reviews? | 12:40 |
| rpittau | Nisha_Agarwal: the changes need to happen for this release or we'll have a conflict, pysnmp-lextudio is maintained and updated and it works just fine with the standard pyasn1 | 12:58 |
| iurygregory | dtantsur, +2 | 12:58 |
| dtantsur | thanks! | 13:00 |
| Nisha_Agarwal | rpittau, yeah i got it after seeing the patch in ironic for snmp power driver | 13:02 |
| rpittau | Nisha_Agarwal: thanks | 13:02 |
| dtantsur | iurygregory: I have a question that may puzzle you.. but do you by chance know as a result of your testing, if firmware upgrade on Dell creates a BIOS config job? | 13:03 |
| dtantsur | context: trying to understand if https://issues.redhat.com/browse/OCPBUGS-30065 affects firmware upgrades too | 13:03 |
| dtantsur | janders: JFYI a side branch of our discussion ^^^ | 13:03 |
| iurygregory | dtantsur, soo, I only tested in dell directly via redfish a while ago, let me grab the dells I have and test via SimpleUpdate to see how it goes, and I will let you know | 13:06 |
| dtantsur | ++ thx | 13:25 |
| iurygregory | rpittau, you had a patch you would like to get in the release right? | 13:42 |
| iurygregory | if you have the link handy I can check things | 13:42 |
| rpittau | iurygregory: yeah, it's already merged, the redfish attach/detach vmedia implementation | 13:42 |
| iurygregory | nice! | 13:42 |
| iurygregory | dtantsur, I will be testing in a R640 iDRAC9 (the only I have access atm) | 13:43 |
| dtantsur | wfm | 13:43 |
| iurygregory | JayF, I'm just trying to remember if we do the release mappings after we cut a release, or before it | 14:08 |
| JayF | Before | 14:09 |
| opendevreview | Merged openstack/ironic master: Support more standard way of passing lists via query strings https://review.opendev.org/c/openstack/ironic/+/910642 | 14:09 |
| iurygregory | so I think we need the patch for it | 14:10 |
| iurygregory | https://review.opendev.org/q/project:openstack/ironic+status:open+branch:master doesn't have one | 14:11 |
| dtantsur | ideally, merge https://review.opendev.org/c/openstack/ironic-python-agent/+/910209 before the release | 14:13 |
| iurygregory | I'm thinking about the ironic one atm | 14:13 |
| iurygregory | at least from the open patches we have they can be backported | 14:13 |
| iurygregory | so I think we are already good to cut the release | 14:14 |
| iurygregory | any volunteer to create the release mapping? \o/ | 14:16 |
| rpittau | iurygregory: I can do it but on Monday | 14:18 |
| iurygregory | ack, I will take care in a few min | 14:18 |
| iurygregory | just trying to finish some testing | 14:18 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: Import disk_{utils,partitioner} from ironic-lib https://review.opendev.org/c/openstack/ironic-python-agent/+/912476 | 14:37 |
| dtantsur | Honestly, this turned out larger than I hoped for.. but anyway | 14:37 |
| rpittau | bye everyone, have a great weekend! o/ | 15:31 |
| iurygregory | bye rpittau o/ enjoy the weekend! | 15:31 |
| *** shadower is now known as Guest2847 | 15:37 | |
| *** shadower7 is now known as shadower | 15:37 | |
| TheJulia | Anyone still around to do some quick reviews ? | 16:41 |
| *** dmellado74522 is now known as dmellado | 16:41 | |
| TheJulia | https://review.opendev.org/q/project:openstack/ironic+branch:unmaintained/xena+status:open | 16:42 |
| JayF | iurygregory: are you working on release mapping or do you need me to? | 17:06 |
| * JayF really needs to bail out early today but wants to ensure ironic release is on greased rails ready to go before he does | 17:06 | |
| TheJulia | if someone does them, I'll review them real quick | 17:25 |
| TheJulia | I'm thinking of bailing early myself actually | 17:25 |
| JayF | I'm in a meeting, will push after (before I leave today) unless someone else gets it or claims it first | 17:26 |
| TheJulia | I have two other things to do first, so lets consider it a race | 17:27 |
| opendevreview | Merged openstack/ironic-python-agent master: Use assert_not_called https://review.opendev.org/c/openstack/ironic-python-agent/+/910209 | 17:30 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: Import disk_{utils,partitioner} from ironic-lib https://review.opendev.org/c/openstack/ironic-python-agent/+/912476 | 17:45 |
| iurygregory | JayF, since we will push next week I will push on monday the release mapping | 17:57 |
| iurygregory | sorry I was having lunch | 17:57 |
| JayF | is there a reason we're waiting until tomorrow:? | 17:57 |
| JayF | sounded like in -release they said they were going to force a cut monday if we hadn't | 17:57 |
| iurygregory | rpittau and I talked with them | 17:58 |
| iurygregory | we will wait for proliantutils and scciclient patches to merge and have the new versions | 17:58 |
| iurygregory | just to be on the safe side | 17:58 |
| JayF | aight, sounds good, will leave it in your capable hands | 17:58 |
| iurygregory | tks! | 17:59 |
| JayF | although I may do the release mapping today anyway | 17:59 |
| iurygregory | ack | 17:59 |
| JayF | because it's nice to have done and we shouldn't be merging api-updating stuff this late (we have none pending, right?) | 17:59 |
| iurygregory | I can review it, we are not planning on merging any api change | 17:59 |
| iurygregory | ++ | 17:59 |
| iurygregory | yes | 17:59 |
| TheJulia | The coordinated release was a mistake | 18:05 |
| TheJulia | :)( | 18:06 |
| TheJulia | err :) | 18:06 |
| dtantsur | err != nil? | 18:06 |
| * dtantsur has light brain damage from go | 18:06 | |
| iurygregory | too much go | 18:06 |
| iurygregory | =X | 18:06 |
| iurygregory | and would be err := lol | 18:07 |
| dtantsur | :D | 18:08 |
| TheJulia | brains | 18:12 |
| TheJulia | enobrains | 18:12 |
| JayF | We cut a release in novemember tha tdidn't get added to release mappings :( | 18:23 |
| JayF | fixing it with the release mappings pr | 18:24 |
| JayF | well, and the feb one | 18:24 |
| TheJulia | ugh | 18:27 |
| TheJulia | we need a release rediness ci job which tosses an error when it sees a new tag appear which is not in a lit | 18:28 |
| JayF | uh | 18:28 |
| JayF | 23.1.0 tag looks weird to me | 18:28 |
| JayF | nope nevermind | 18:28 |
| JayF | got it mixed up with 24.0 | 18:28 |
| JayF | okay yeah it's weird | 18:29 |
| JayF | https://github.com/openstack/ironic/blame/24.0.0/ironic/common/release_mappings.py https://pypi.org/project/ironic/24.0.0/ was cut feb 1 2024 | 18:29 |
| JayF | https://github.com/openstack/ironic/commit/ed946c4d55cb647177c3f88498fc3442ced9a63c is dated jan 19 | 18:30 |
| JayF | must be a weird merge timing thing, looks like the release was cut just before that commit | 18:30 |
| iurygregory | ouch | 18:31 |
| iurygregory | .-. | 18:31 |
| TheJulia | on a plus side, it is all about upgrading to *that* release with the latest version being able to contain the mapping data | 18:34 |
| JayF | the biggest impact is it's harder to do after the fact :D | 18:34 |
| TheJulia | yeah, but just means you can't do a pin over at on the latest | 18:35 |
| TheJulia | until say 24.0.1 is cut | 18:36 |
| JayF | I don't know what exactly you mean | 18:36 |
| JayF | we need to backport, to bugfix/ branches, the correct mappings? | 18:36 |
| TheJulia | the mappings exist purely for pinning | 18:37 |
| JayF | yeah, I know that | 18:37 |
| TheJulia | otherwise it is upgrade to latest master state | 18:37 |
| JayF | I'm confused as to if they need to be source or destination | 18:37 |
| JayF | e.g. if we need to backport these to bugfix/ or not :) | 18:37 |
| TheJulia | eh... maybe 23.1 to 24.0, but "meh" | 18:37 |
| TheJulia | there is no published guarantee for upgrades from bugfix branches. | 18:37 |
| JayF | I wanted to know for knowledge purposes | 18:40 |
| JayF | I have no intentions of doing the manual backport it'd require :D | 18:40 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Release mappings for 23.1, 24.0, 24.1/2024.1 https://review.opendev.org/c/openstack/ironic/+/913440 | 18:44 |
| JayF | TheJulia: iurygregory: ^ should be good | 18:44 |
| iurygregory | JayF, ack | 18:44 |
| JayF | if you all wanna get anything +2A'd that you want in the release | 18:44 |
| JayF | I'm going to do a recheck pass tonight or tomorrow morning | 18:44 |
| JayF | and try to get anything thru the gate that is struggling for our release | 18:45 |
| TheJulia | LGTM | 18:51 |
| TheJulia | and yes, I double checked versions | 18:51 |
| iurygregory | ++, I'm just wondering if we really need to keep the old references like yoga, zed.. https://review.opendev.org/c/openstack/ironic/+/913440/1/ironic/common/release_mappings.py#742 | 18:52 |
| TheJulia | iurygregory: I thought of that as well, but definitely can be later | 18:53 |
| iurygregory | yup ++ | 18:53 |
| TheJulia | and likely needs a little thoguth put into it | 18:53 |
| iurygregory | yeah, just checked we used to keep Actual release and the one before | 18:54 |
| iurygregory | https://github.com/openstack/ironic/blob/stable/wallaby/ironic/common/release_mappings.py#L368C1-L370C53 | 18:55 |
| JayF | It's one of those things where ... it causes zero pain to leave it, and it removes functionality to remove it | 18:55 |
| JayF | what's the goal? | 18:55 |
| iurygregory | tbh I'm not aware of the main reason | 18:57 |
| iurygregory | bbl, gym time | 18:57 |
| TheJulia | JayF: traditionally to narrow the upgrade by name window | 19:01 |
| JayF | honestly I'm really, really curious in practice how many people are using rolling upgrades | 19:03 |
| TheJulia | The impression is more classical operators, yes but without specifics. Deployment tools seem to be more steam-rollery because really letting someone stop someplace with a pin is sort of silly in that case | 19:08 |
| TheJulia | I'm heading out folks, have a great weekend | 19:12 |
| JayF | I'm stepping off IRC for a bit; DMs should ding my phone if you need me urgently | 19:12 |
| JayF | jinx! | 19:12 |
| JayF | :D have a good one Julia o/ | 19:12 |
| opendevreview | Merged openstack/ironic master: Release mappings for 23.1, 24.0, 24.1/2024.1 https://review.opendev.org/c/openstack/ironic/+/913440 | 22:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!