| opendevreview | cid proposed openstack/ironic master: Use the ``microversion-parse`` to parse version headers in API requests https://review.opendev.org/c/openstack/ironic/+/916149 | 00:30 |
|---|---|---|
| opendevreview | cid proposed openstack/ironic-inspector master: Use the microversion-parse to parse version headers in API requests https://review.opendev.org/c/openstack/ironic-inspector/+/916151 | 00:49 |
| opendevreview | cid proposed openstack/ironic-inspector master: Use the microversion-parse to parse version headers in API requests https://review.opendev.org/c/openstack/ironic-inspector/+/916151 | 00:51 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Delete the CUSTOM_RAID template after test has finished https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/914981 | 02:00 |
| opendevreview | Steve Baker proposed openstack/metalsmith master: Use bootloader element instead of grub2 https://review.opendev.org/c/openstack/metalsmith/+/916018 | 03:15 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Correct logging call in _heartbeat_service_wait method https://review.opendev.org/c/openstack/ironic/+/915394 | 03:56 |
| opendevreview | Steve Baker proposed openstack/metalsmith master: Use bootloader element instead of grub2 https://review.opendev.org/c/openstack/metalsmith/+/916018 | 04:28 |
| rpittau | good morning ironic! o/ | 06:57 |
| opendevreview | Merged openstack/ironic-prometheus-exporter master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/906779 | 07:44 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Correct logging call in _heartbeat_service_wait method https://review.opendev.org/c/openstack/ironic/+/915394 | 07:47 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Correct logging call in _heartbeat_service_wait method https://review.opendev.org/c/openstack/ironic/+/915394 | 07:47 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Remove redundant priority override code from service steps https://review.opendev.org/c/openstack/ironic/+/916167 | 07:54 |
| opendevreview | Merged openstack/ironic master: Use .coveragerc file https://review.opendev.org/c/openstack/ironic/+/907557 | 07:59 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Unprovision iso ramdisk boot from test https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/914980 | 08:31 |
| *** jph5 is now known as jph | 10:15 | |
| *** srelf_ is now known as ContinuitySR | 11:04 | |
| iurygregory | good morning Ironic | 11:49 |
| *** jph6 is now known as jph | 12:45 | |
| opendevreview | Riccardo Pittau proposed openstack/ironic-specs master: [WIP] Add work items for 2024.2 Dalmatian development cycle https://review.opendev.org/c/openstack/ironic-specs/+/916295 | 13:07 |
| rpittau | woah finally found the time to start on this ^ | 13:08 |
| TheJulia | good morning | 13:13 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: fix vif tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/916299 | 13:34 |
| TheJulia | so turns out we have api contract tests which explicitly expect lower level interface behavior with neutron enabled, which has meant... they haven't been getting tested in a long time. | 14:23 |
| TheJulia | wheeeeeee | 14:23 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: fix vif tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/916299 | 15:00 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Fix device_type description for attach/detach vmedia for Redfish https://review.opendev.org/c/openstack/ironic/+/916306 | 15:19 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: WIP: Intermediate networking service https://review.opendev.org/c/openstack/ironic-specs/+/916126 | 15:27 |
| * rpittau running on fumes | 16:11 | |
| rpittau | see ya tomorrow! o/ | 16:11 |
| TheJulia | energy preservation is key | 16:11 |
| TheJulia | goodnight! | 16:11 |
| dtantsur | rpittau: the docstring change is very-very wrong | 16:12 |
| dtantsur | if it's actually the case, we need to fix teh code | 16:12 |
| * JayF plugs into the wall for a quick boost of powah | 16:13 | |
| TheJulia | so, in theory, tempest only needs to support the last handfull of versions. Does that mean we should feel okay about removing tests written in the very early days of ironic that would just be a complete PITA to keep around? | 16:28 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Fix device_type in attach/detach vmedia for Redfish https://review.opendev.org/c/openstack/ironic/+/916306 | 16:32 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Fix device_type in attach/detach vmedia for Redfish https://review.opendev.org/c/openstack/ironic/+/916306 | 16:38 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Fix device_type in attach/detach vmedia for Redfish https://review.opendev.org/c/openstack/ironic/+/916306 | 16:39 |
| JayF | TheJulia: very hard to answer that question in the generic | 16:40 |
| TheJulia | Yeah, it is a hard one | 16:41 |
| * TheJulia tries a path | 16:41 | |
| JayF | one or two specific examples to establish the pattern would be helpful | 16:41 |
| TheJulia | the tl;dr is we have not been running the vif tests... well... forever. But fixing them breaks other tests (https://99fe0e35c4a879c3b6d5-38c1c93822110964c15749f1b6ae66e8.ssl.cf2.rackcdn.com/916299/2/check/ironic-tempest-functional-python3/52e6924/testr_results.html) and it is all sort of rooted in a blend of pattern and evolution | 16:43 |
| TheJulia | so maybe not as bad as I thought | 16:51 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: fix vif tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/916299 | 16:51 |
| JayF | So basically all the tests pass, but getting them configured so that all of them can pass at the same time is complex, for "our tempest tests have organically grown over decade+" reasons? | 16:56 |
| TheJulia | well, the issue is we shouldn't put ourselves in a place where configuration has to be the thing | 16:56 |
| TheJulia | because that makes it painfully more difficult | 16:56 |
| TheJulia | I think some of my resulting issues are my own doing, time in CI will tell | 16:56 |
| JayF | makes sense | 17:02 |
| JayF | well, that means, it's in the shape of problems I know we have lol | 17:02 |
| TheJulia | yeah | 17:05 |
| dtantsur | TheJulia: I'd take a radical position and say that support for any releases that are not maintained is optional | 17:12 |
| TheJulia | That is a good data point, thanks | 17:13 |
| JayF | I mostly agree with that, and thought it was obviousish, with the exception of tests that confirm our versioned API contract is upheld | 17:13 |
| dtantsur | Sure. But vifs in node.extra were not versioned, so I'm not sure how to treat them in this regard. | 17:14 |
| dtantsur | (insert my usual rant about JSON fields lol) | 17:14 |
| JayF | mmm | 17:15 |
| TheJulia | well, the old vif stuff doesn't even apply here, it more started with were were were not running the tests period. | 17:26 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: fix vif tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/916299 | 18:05 |
| opendevreview | Merged openstack/sushy-oem-idrac master: Add codespell non voting test https://review.opendev.org/c/openstack/sushy-oem-idrac/+/914517 | 18:12 |
| opendevreview | Merged openstack/ironic master: Small Doc Fix: Moved user export for devstack guide. https://review.opendev.org/c/openstack/ironic/+/916022 | 18:12 |
| opendevreview | cid proposed openstack/ironic master: Follow-up: Use ``microversion-parse`` to parse version headers in API requests https://review.opendev.org/c/openstack/ironic/+/916149 | 18:54 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: fix vif tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/916299 | 18:58 |
| opendevreview | cid proposed openstack/ironic-inspector master: Follow-up: Use ``microversion-parse`` to parse version headers in API requests https://review.opendev.org/c/openstack/ironic-inspector/+/916151 | 19:18 |
| opendevreview | Merged openstack/ironic master: CI: Unpack cirros image partition jobs https://review.opendev.org/c/openstack/ironic/+/914772 | 19:20 |
| opendevreview | Merged openstack/ironic stable/zed: Fix anaconda stage2_id loading from image properties https://review.opendev.org/c/openstack/ironic/+/883576 | 19:20 |
| janders | Hi Ironicers. I'm after a second +2 for these two patches if anyone has time (these are a part of fixing service steps, among some others): | 20:40 |
| janders | https://review.opendev.org/c/openstack/ironic/+/915394 | 20:40 |
| janders | https://review.opendev.org/c/openstack/ironic/+/916167 | 20:40 |
| janders | thanks in advance! | 20:40 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: fix vif tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/916299 | 20:40 |
| * TheJulia crosses her fingers | 20:41 | |
| TheJulia | JayF: done | 20:44 |
| TheJulia | err | 20:44 |
| TheJulia | JayF: sorry! | 20:44 |
| TheJulia | janders: done | 20:44 |
| stevebaker[m] | Good morning, this is green finally https://review.opendev.org/c/openstack/metalsmith/+/916018 | 20:48 |
| TheJulia | \o/ | 21:09 |
| opendevreview | cid proposed openstack/ironic-inspector master: Follow-up: Use ``microversion-parse`` to parse version headers in API requests https://review.opendev.org/c/openstack/ironic-inspector/+/916151 | 21:54 |
| opendevreview | Merged openstack/ironic master: Correct logging call in _heartbeat_service_wait method https://review.opendev.org/c/openstack/ironic/+/915394 | 21:59 |
| opendevreview | Merged openstack/ironic master: Remove redundant priority override code from service steps https://review.opendev.org/c/openstack/ironic/+/916167 | 21:59 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: fix vif tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/916299 | 22:12 |
| opendevreview | Merged openstack/metalsmith master: Use bootloader element instead of grub2 https://review.opendev.org/c/openstack/metalsmith/+/916018 | 22:27 |
| opendevreview | Steve Baker proposed openstack/ironic master: Replace cinderclient usage with openstacksdk https://review.opendev.org/c/openstack/ironic/+/900265 | 23:15 |
| *** jph1 is now known as jph | 23:37 | |
| janders | Thank you TheJulia | 23:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!