Tuesday, 2024-05-28

rpittaugood morning ironic! o/07:03
*** srelf_ is now known as Continuity08:02
ContinuityMorning Ironic o/08:02
JayFDo we have any plans currently to hook up the existing ilo driver (not redfish) to firmware interface?09:23
JayFI wonder if it's as simple as plumbing the redfish support into the ilo driver for some hardware09:23
JayFFYI gate is currently broken09:35
JayFI put https://review.opendev.org/c/openstack/ironic/+/920365 up on Thursday to fix one issue, it was not reviewed09:35
JayFand it appears we have some kinda pip issue preventing pep8 from running in the gate, I'm looking into that now09:36
JayFI'm going to stack a patch on that to fix pep809:38
JayFactually making it one patch or else it won't merge lol09:38
opendevreviewJay Faulkner proposed openstack/ironic master: Fix CI issues in codespell/pep8  https://review.opendev.org/c/openstack/ironic/+/92036509:39
JayFiurygregory: dtantsur: TheJulia: please someone land ^ when you are working o/09:39
* JayF waves from London09:39
rpittauJayF: I'm having a look now09:40
JayFoh hey, that's right, you're in my tz :D 09:40
rpittau:D09:40
JayFor well, I'm in yours or closer to it09:40
rpittauwe're a train ride away!09:41
JayFI'll note I'm in Paris on Monday with no plans, if it's close enough and you wanna grab lunch or a chat we can, but otherwise I'd see you Weds/Thurs09:41
vicentHi, I hope this is the place to ask about ironic. I am exploring the multi-tenant networking on devstack. I tried both https://docs.openstack.org/networking-baremetal/latest/contributor/quickstart-multitenant.html and https://docs.openstack.org/ironic/latest/contributor/ironic-multitenant-networking.html none of those work on a clean ubuntu 22.04 VM. I guess the difference is the first uses OVS 09:55
vicentand the second OVN. I could make the first work with some manual changes and restarting services. Which one would be the recommended way though?09:55
JayFHey vicent o/09:55
JayFI'm not surprised those devstack configs are somewhat outta date, sadly09:56
JayFI'm sure what you want to do is possible but it may take a little bit of coaxing 09:56
JayFalthough honestly that ngs (networking-generic-switch) devstack config looks pretty good09:56
JayFIs your goal just to try out Ironic multitenant networking? To do development? What's the bigger goal you wanna accomplish09:57
vicentI had to comment out the network for instances variables. 10.0.1.0/24 somehow didn't work. Then I had to restart the ir-neutronagt in the middle of the stack.sh. Then it worked09:58
vicentI also have to remove the dnsmasq folder between instantiations. That one and the ~/.vbmc folder don't get cleaned.09:59
JayFis it possible you have 10.0.1.0/24 on your local subnet?09:59
vicentMy goal for now it is to understand the possibilities or multitenant networking on ironic and maybe some development.10:00
JayFAlso, generally speaking, it's best to restart with a clean ubuntu when trying to re-stack a devstack setup IME. I usually keep a snapshot of everything ready before stack.sh.10:00
JayFI suspect if you've been trying to modify config and re-stack that may explain some of your difficulty10:00
vicentI see, I will try that10:01
vicentNo, 10.0.1.0/24 is not on my local subnet10:02
JayFYeah definately make sure your local LAN isn't overlapping the network setup there10:02
JayFdarn10:02
JayFI've not done serious development on NGS in a while, or I'd give more specific help. 10:02
vicentBut using the default is fine, so I will keep that.10:02
JayFPlease report back if you don't have success, we'll want to get that doc fixed up.10:03
JayFI'll note that the Ironic (not NGS/multitenant) devstack guide is more up to date and may have useful pointers10:03
vicentI have a conceptual question. Do we have the tenant/provider distinction on ironic? at the end both would be mapping to a physical network on the ToR switch...10:04
JayFso cleaning_network / provisioning_network / service_network (and so forth)10:04
JayFare the provider networks, basically10:04
JayFwhere nodes are when they are not running a workload10:04
vicentAnd when running a workload?10:05
JayFthen at deploy time, once the image is written, I think the flow is we power off the node; make calls to neutron (which may call NGS when configured) to change networks; boot the machine into a tenant network10:05
JayFit's all incredibly slick when configured; but admittedly getting all the pieces in line can be tough the first time10:05
JayFtl;dr: yes we support tenant networks10:05
vicentI see usually those tenant networks are using vlans. Can I use other tunnel mechanisms there, for instance vxlan or geneve?10:06
vicentassuming the TOR switch supports them10:07
JayFI think technically we might support vxlan but not vlan10:07
JayFit's a common patch to allow vlans through, and we're working on supporting it more officially without a neutron: https://review.opendev.org/c/openstack/ironic-specs/+/91612610:08
JayFI'll note we have more people familiar with NGS in American TZs, I'm usually PST but am visiting UK this week :D 10:08
vicentmy devstack local.conf have Q_ML2_TENANT_NETWORK_TYPE=vlan , and that seems to be working. On the switch the tenant and provider networks looks the same.10:08
vicentOk, I will wait tomorrow to read the comments :)10:09
JayFTheJulia: ^ if you have time when you're up, you might be able to say a couple sentences and help vicent get pointed in the right direction10:10
vicentAnother question. Does NGS work with multiple switches? I saw several can be configured on the ngs ml2 file, but I was wondering if neutron would know to configure the tenant and provider networks on multiple switches. 10:12
JayFYes; and I don't know how :)10:14
JayFsorry you got the IPA expert not the NGS expert :D 10:14
JayFask me about cleaning nodes and you will get less i don't knows LOL10:14
JayFsomething that may help you out10:14
JayFpush a patch to ngs, literally anything10:14
JayFlook at the CI logs10:14
JayFthat might give you some insight into what a working setup looks like10:15
JayFhttps://review.opendev.org/c/openstack/networking-generic-switch/+/919593 has a recent result you could look at 10:16
JayFwith https://zuul.opendev.org/t/openstack/build/18acda8b806e49159952bf30e8122914being most likely the best relevant example10:16
JayF(it's multinode which means we run two devstacks and they coordinate, it can be easier to test networking that way)10:16
JayFah no, the logs are gone because it's too old10:17
JayFI'll recheck it, it'll have new logs in about an hour10:17
vicentI get an error when trying to view the build. Do I need to sign in?10:17
JayFno, it's because it's too old, I should've clicked before copying it 10:17
JayFI approved that change, it'll run CI again, look for the comment from zuul voting "Verified+2" in about an hour and it'll have a new set of logs10:18
JayFthey expire after a few days10:18
JayF(we set up and tear down thousands of clouds every day so we can't keep all the info forever :D)10:18
vicentOk, thanks for the hint JayF. I will keep looking.10:19
opendevreviewJay Faulkner proposed openstack/ironic master: Remove outdated information from contributor guide  https://review.opendev.org/c/openstack/ironic/+/92064910:19
JayFthanks for the inspiration to do ^ that 10:20
JayF:D 10:20
JayFhaving the less-tested devstack configs on the front door with the detailed ones hidden is not ideal10:20
opendevreviewJay Faulkner proposed openstack/ironic master: Update front page of contributor guide  https://review.opendev.org/c/openstack/ironic/+/92064910:35
iurygregorygood morning ironic o/10:48
opendevreviewDmitry Tantsur proposed openstack/ironic master: [PoC] Render the redfish interop profile in the docs  https://review.opendev.org/c/openstack/ironic/+/92057410:50
JayFo/10:51
JayFiurygregory: https://review.opendev.org/c/openstack/ironic/+/920365 needs one more core review to unbreak the gate11:26
JayFif you can, it'd be helpful11:26
iurygregoryJayF, sure looking now11:26
opendevreviewMerged openstack/networking-generic-switch master: [CI] Remove not defined job from queue  https://review.opendev.org/c/openstack/networking-generic-switch/+/91959311:45
opendevreviewKaifeng Wang proposed openstack/ironic master: Fix some typo in servicing doc  https://review.opendev.org/c/openstack/ironic/+/92032311:46
opendevreviewJay Faulkner proposed openstack/ironic master: Update front page of contributor guide  https://review.opendev.org/c/openstack/ironic/+/92064912:16
opendevreviewElod Illes proposed openstack/networking-generic-switch stable/2024.1: [CI] Remove not defined job from queue  https://review.opendev.org/c/openstack/networking-generic-switch/+/92065512:31
opendevreviewElod Illes proposed openstack/networking-generic-switch stable/2023.2: [CI] Remove not defined job from queue  https://review.opendev.org/c/openstack/networking-generic-switch/+/92065912:38
opendevreviewElod Illes proposed openstack/networking-generic-switch stable/2023.1: [CI] Remove not defined job from queue  https://review.opendev.org/c/openstack/networking-generic-switch/+/92066012:39
opendevreviewJay Faulkner proposed openstack/ironic master: Update front page of contributor guide  https://review.opendev.org/c/openstack/ironic/+/92064912:42
opendevreviewVerification of a change to openstack/ironic master failed: Fix CI issues in codespell/pep8  https://review.opendev.org/c/openstack/ironic/+/92036512:46
opendevreviewVerification of a change to openstack/ironic master failed: Fix CI issues in codespell/pep8  https://review.opendev.org/c/openstack/ironic/+/92036513:02
TheJuliagood morning13:08
pocoyo_2468/who13:26
opendevreviewMerged openstack/ironic-inspector master: Fix codespell reported errors  https://review.opendev.org/c/openstack/ironic-inspector/+/92039913:29
pocoyo_2468/help13:30
* TheJulia raises an eyebrow13:30
pocoyo_2468/msg ebilj did u receive this13:30
TheJuliapocoyo_2468: could you be in the wrong channel?13:30
pocoyo_2468i am not sure 13:31
TheJuliaWhat channel were you seeking?13:31
pocoyo_2468i am just trying a vscode extension that acts as an irc client13:32
pocoyo_2468i got to here and now i am unsure how to send direct msg to my colleague13:32
TheJuliaInteresting13:33
TheJuliaI've not heard of such an extension13:33
pocoyo_2468it's called vsirc13:33
TheJulianeat, but it sounds/seems like from your messages into channel that it doesn't really grok / commands13:36
TheJuliaThat or it expects those commands to be sent on like a server tab13:36
pocoyomaybe but everything so far used / commands 13:41
pocoyo_2468first i used: /connect irc.oftc.net13:41
pocoyo_2468then: /join #openstack-ironic13:42
pocoyo_2468and now i am here ☺️13:42
dtantsurcurious13:47
dtantsurTheJulia, JayF, a question on the Redfish profile versioning (tagging you two since the three of us are most likely to care)13:47
dtantsurhttps://opendev.org/openstack/ironic/src/branch/master/redfish-interop-profiles/OpenStackIronicProfile.v1_0_0.json has 1.0.0 inside and its file name, and this seems to be by design13:47
dtantsurI'm not changing/fixing it. Is the expectation that I actually leave the old file alone and create a 1_1_0?13:48
dtantsurThe old file seems to be slightly wrong in a few places, but nothing catastrophic13:48
dtantsurI suspect the DMTF way is to freeze the old version, but I wonder how much of a heavyweight process it is for us13:49
dtantsurAnd how much we care about a not-quite-correct profile still available in master13:49
dtantsurOpinions?13:49
TheJuliaI'd just fix the file and update the versions to match latest, I'm not sure we can enforce version freezing realistically13:56
dtantsurTheJulia: latest = 1.1.0 in this case? or you mean the version of ironic itself?14:02
TheJulia1.1.0 I think14:03
TheJuliasince it would be versioned separately14:03
dtantsur++14:03
dtantsurTheJulia: re https://bugs.launchpad.net/ironic/+bug/2067073: you mention iPXE incompatibility with the secure boot, but grub does not have this problem, does it?14:21
dtantsurNot objecting to ISOs, it will be even handier for us in OpenShift, just clarifying14:22
TheJuliaFor grub, you *can* load shim directly, and shim will then load the grub efi binary 14:22
TheJuliabut shim is married only to grub, and stevebaker did sort of push shim folks to see if we could also support loading ipxe, it would need to be signed by the vendor's key loaded in shim and it would need to be named the same static filename as grub14:23
TheJulia.... which is obviously far from ideal as well14:23
TheJuliaBut, you can just use grub if compiled for network booting14:24
TheJuliawell, shim+grub14:24
dtantsuryeah, that's what I meant14:26
dtantsurI'm also wondering if the difference between an ISO and grub boot is significant enough to justify a new boot interface14:26
TheJuliain ironic's case of configuration, boot_interface needs to be set to pxe, the associated template needs to be the grub config, the grub initial chain loader config needs to be grub.cfg14:26
dtantsuryeah, it's probably different enough14:27
dtantsurfor ISOs, we need to support both building them and taking provided images (like for virtual media)14:27
dtantsurquite a lot of differences14:27
TheJuliapxe was always intended to be a "you just pxe boot" and we just mix and match, I still see people who use it with ipxe....14:27
TheJuliayeah14:27
dtantsurokay, I'm +2 to the RFE14:28
TheJuliacool cool14:28
opendevreviewJay Faulkner proposed openstack/ironic master: Update front page of contributor guide  https://review.opendev.org/c/openstack/ironic/+/92064914:34
dtantsurhttps://review.opendev.org/c/openstack/ironic/+/920574 is my WIP effort to fix and render the profile14:35
JayFWhat is the /use case/ for 2067073? I am struggling to understand when you'd want ironic to send an iso vs bootloader14:35
JayFIt seems like a different-in-name/format only option; which implies to me I'm missing something14:36
TheJuliaBasically, different formatting/modeling. The use case in mind is to support direct network booting of host from UEFI firmware so they can boot with Secure Boot directly from the ISO. The only way we do that today is via the OOB URL, but there are still people (still!) who insist on IPMI, or who just want to network boot all the time (i.e. some can't support out of band BMC connectivity for virtual media.14:39
JayFso to clarify:14:40
JayFexisting way is multi-stage, you get a loader (ipxe/grub) which gets a thing14:40
JayFnew proposed way is one stage, you get an iso which has it all baked in14:40
TheJuliayes, and the important fact is ipxe is not signed, nor will ever be publically signed most likely14:41
JayFI'm assuming this isn't the default for $hardware_support reasons, lowest common demominator hardware won't have it?14:41
TheJuliaAND EU entities are moving towards mandating SecureBoot in all operatin gmodes14:41
TheJuliaoperating modes14:41
JayFit doesn't sound like there's any downside to the ISO-based method as described14:41
TheJuliafirmware support being the needful14:41
JayFso here's a question, I'm legitimately curious and it *feels* like something we should have in our docs 14:42
TheJuliaIt really is just another variation of httpboot, one I sort of skipped past and only did it for Redfish HttpBootUri support14:42
JayFif you had hardware that could do * today14:42
JayFwhat is the "best" for most use cases?14:42
JayFredfish+http-iso?14:42
JayFredfish+virtual media, actually?14:42
TheJuliareally it depends on the use case and capabilities14:43
JayFI'm saying ignore capabilities, assume this is magic hardware which implements everything including mutually exclusive stuff, somehow14:43
TheJuliaMy experience thus far is that tends to be magical hardware which doesn't exist ;)14:44
TheJuliaMix in the operational constraints and folks quickly develop opinions14:44
TheJuliaBut, I do think your raising a really valid point, what do we recommend14:44
TheJuliaand we sort of let people "figure that out on their own"14:44
JayFanother way of saying that is "BYODecoderRing14:44
JayFlol14:45
JayFpart of why I ask is on my slide where I say, basically "use redfish hardware" at cern14:45
JayFI didn't know if there was a point in saying "also use a better boot interface if you can, like X/Y/Z"14:45
TheJulianot every boot interface supports every capability either14:46
TheJuliaThat is something I think we've got written down in docs, but it also is not the clearest thing either14:47
JayFthe matrix is real :D 14:47
JayFhonestly, we need like one of those giant wikipedia tables, where the y is "capabilities" and the x is some combo of boot and deploy interfaces14:47
TheJulia... I feel like we tried to head down that path at one point and someone -2'ed it14:48
TheJuliaor -1'ed it because it was not providing the 10 foot view14:48
* TheJulia sighs14:49
JayFsounds like something we would've done a while ago, but not today14:49
* TheJulia goes with trying to get downstream docs sorted14:49
JayFgood luck :) I'm about to EOD and try to keep myself awake until a proper time to sleep UK time14:49
TheJuliaAnother variation of sorts is if you go look at specific feature docs, we tend to also note the details and context into that at the very beginning of the section14:51
TheJulia"oh, I want to do z" "z is only supported with interface x,y"14:51
* JayF builds a pivot table /s14:51
JayFspeaking of docs - https://review.opendev.org/c/openstack/ironic/+/920649 is a fix that was inspired by the chat earlier14:53
JayFjust trying to move things out of the root document that are less-updated14:53
TheJuliaThinking about the reality of mandated secure boot, perhaps it is time to deprecate boot from volume...15:01
JayFI have no objection15:02
JayFbut we'd need to send it around some15:02
JayFI'll add it to my "stuff you maybe shouldn't use" slide for CERN talk15:03
TheJulia++15:03
JayFand note it basically is impossible to secure boot with bfv15:03
JayFand see if anyone squeals15:03
TheJuliait is not impossible, but BFV requires iPXE, so there is just a non-easy path to get there15:03
TheJuliaone we can never actually test upstream15:03
TheJuliaand one where vendors just won't engage15:03
JayFisn't there hardware-assisted bfv?15:04
TheJuliaoh, right15:04
JayFwhich doesn't need ipxe?15:04
TheJuliayeah15:04
TheJuliayou're right there15:04
JayFwhen you said that, I assumed you meant non-hardware bfv15:04
JayFbut to be fair we can't test the hardware-assisted bfv anyway15:04
TheJuliaFJ and to an extent iLO had added some support for that15:04
TheJuliayup15:04
JayFit's in there https://usercontent.irccloud-cdn.com/file/xo0YMuMt/image.png15:06
TheJuliaI feel like "remote Volume" might be an important delienator15:06
JayF"Network Boot from Volume"15:08
rpittauthat falls into "remote attestation" right? which is a different thing15:08
TheJuliaattestation is the act of measuring the system secure boot runtime state and then telling an attestation server if your "good" or "not"15:09
opendevreviewMerged openstack/ironic-lib master: Fix codespell reported errors  https://review.opendev.org/c/openstack/ironic-lib/+/92042515:10
opendevreviewMerged openstack/networking-baremetal master: Fix codespell reported errors  https://review.opendev.org/c/openstack/networking-baremetal/+/92042715:12
TheJuliavicent: so the question of ovs vs ovn is sort of a "what are you seeking" from Neutron question. The reality is OVN has OVS under the hood, but it has some additional constraints, you'll generally want to head in the OVN direction though, but it has an open list of challenges with Bare Metal host in our docs. If you don't find that link, let me know I can dig it up.15:15
TheJuliavicent: I woudl also expect the networking-baremetal docs to be far more out of date than the ironic docs, but configuration wise ironic also has a CI job which exercises some of the aspects. I'm not sure why the 10.1.0.0/24 network didn't work but if you can provide more details regarding that it might help. .vbmc is something I think can happen if you have re-stacks which are not fully cleaned up, so it oculd be your 15:18
TheJuliaprocess of stacking and unstacking? We tend to recommend use of sushy-tools as opposed to virtual bmc, the difference with devstack is to use redfish instead of ipmi.15:18
TheJuliavicent: regarding vxlan or geneve, not with networking-generic-switch. With later ironic's we did add OTAP config passing to OVN, but I think you have to individually configure the switch to point into the fabric15:19
TheJuliavicent: ngs can be configured for multiple switches as far as I'm aware15:20
TheJuliavicent: just separate configuration sections for each switch15:20
vicentTheJulia: I understand OVN or OVS are just a way to simulate the ToR switch on devstack, but on real baremetal those are not there. Correct?15:25
TheJuliaactually not really15:26
TheJuliaSo... OVS and OVN are what drives Neutron's engagement in terms of networking in general15:26
TheJuliain Devstack, yes, basically drive OVS (even with ovn being used) to handle port attachments/detachments for simulating baremetal switchports being toggled15:27
TheJuliaOVN/OVS still get used in terms of however you tie Neutron into the network in a full deployment15:27
vicentBut on ironic with neutron, the mech driver is baremetal with NGS talking to the physical ToR15:28
TheJuliayes15:29
TheJuliafor neutron as a networking node, ovs/ovn is the other side of a vlan trunk port so it sees the tagged networks and does things like setup routers15:29
TheJuliaand DHCP15:29
vicentOk, I see, and the provision-network and the other provider infra networks15:30
TheJuliayup15:30
TheJuliahttps://docs.openstack.org/ironic/latest/admin/ovn-networking.html <-- the ovn related issues/challenges I alluded to earlier15:31
opendevreviewMerged openstack/ironic master: Fix CI issues in codespell/pep8  https://review.opendev.org/c/openstack/ironic/+/92036515:35
opendevreviewAdam Rozman proposed openstack/sushy-tools master: improve volume boot mode support  https://review.opendev.org/c/openstack/sushy-tools/+/91211315:38
samcat116For that note in the OVN doc on NAT, does that only apply if your provisioning/cleaning network is itself NATed? Or does that apply to any deployed network with a FIP in front of it. I assume it wouldn't normally deploy through the FIP in that case15:40
vicentTheJulia: Thanks at lot for your answers. I think I have what I need to continue studying and trying things. JayF mentioned project mercury: https://review.opendev.org/c/openstack/ironic-specs/+/916126/6/specs/approved/mercury.rst It seems interesting. I will try to keep an eye on it.15:43
opendevreviewDmitry Tantsur proposed openstack/ironic-inspector master: [DNM] Instrument to debug memory leaks  https://review.opendev.org/c/openstack/ironic-inspector/+/92027515:47
TheJuliasamcat116: if the cleaning/provision networks are natted15:47
TheJuliaerr15:48
TheJuliasamcat116: I don't remember how that came up at this point15:48
TheJuliavicent: thanks, trying to build initial interest15:49
opendevreviewMerged openstack/sushy-tools master: Fix codespell reported errors  https://review.opendev.org/c/openstack/sushy-tools/+/92042915:52
rpittaugood night! o/15:56
opendevreviewMerged openstack/networking-generic-switch stable/2024.1: [CI] Remove not defined job from queue  https://review.opendev.org/c/openstack/networking-generic-switch/+/92065516:00
opendevreviewMerged openstack/networking-generic-switch master: Fix codespell reported errors  https://review.opendev.org/c/openstack/networking-generic-switch/+/92042816:01
opendevreviewAdam Rozman proposed openstack/sushy-tools master: improve volume boot mode support  https://review.opendev.org/c/openstack/sushy-tools/+/91211316:02
opendevreviewAdam Rozman proposed openstack/sushy-tools master: improve volume support in nova driver  https://review.opendev.org/c/openstack/sushy-tools/+/91211316:05
opendevreviewAdam Rozman proposed openstack/sushy-tools master: improve volume support in nova driver  https://review.opendev.org/c/openstack/sushy-tools/+/91211316:06
opendevreviewAdam Rozman proposed openstack/sushy-tools master: improve volume support in nova driver  https://review.opendev.org/c/openstack/sushy-tools/+/91211316:08
opendevreviewMerged openstack/ironic-inspector master: Fix negative lookahead assertion syntax error  https://review.opendev.org/c/openstack/ironic-inspector/+/92028116:24
opendevreviewcid proposed openstack/ironic master: wip: Provision aarch64 fake-bare-metal-vms  https://review.opendev.org/c/openstack/ironic/+/91544116:29
TheJuliacid: wow that failed fast17:05
TheJuliaI'm sensing config wise soemthing is  little misaligned there17:06
cidTheJulia: One of the fastest :D17:09
TheJuliafailing fast is always best :)17:09
cidI think I know what the problem is too17:09
opendevreviewJulia Kreger proposed openstack/ironic-python-agent-builder master: Block cloud-init user-data loading  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/92018417:12
cidTheJulia: I think the sooner, the closer home the problem might be, in this case, config.17:12
opendevreviewJulia Kreger proposed openstack/ironic-python-agent-builder master: Block glean-early.sh from running  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/92018317:23
opendevreviewcid proposed openstack/ironic master: wip: Provision aarch64 fake-bare-metal-vms  https://review.opendev.org/c/openstack/ironic/+/91544117:35
opendevreviewJulia Kreger proposed openstack/ironic master: WIP Advanced vmedia deployment test ops  https://review.opendev.org/c/openstack/ironic/+/89801017:35
cidTheJulia: If you get a free hand before EOD, I would like to learn how to implement the latest review on this: https://review.opendev.org/c/openstack/ironic/+/91722917:36
TheJuliahmmm17:40
TheJuliaoh right17:42
TheJuliaso my comment points to not using os to modify the host process environment, but to call execute() with env_variables={'VARIABLE_NAME': 'value'}17:42
cidYes, done that.17:43
TheJuliaokay, which latest review then?17:43
cidI can't seem to be able to replace the _persist_ipmi_password with the _exec_ipmitool17:43
cidAs JayF suggested17:44
cidI can push what I have going, but it's not passing unittest17:46
TheJuliayeah, that would likely help17:48
TheJuliaHmm, I forgot how complex this whole exec is17:59
TheJuliaI guess I might make _make_password_file somewhat of a noop with minimal code, and separately assemble the environment variable18:04
opendevreviewcid proposed openstack/ironic master: Flexible IPMI credential persistence method configuration  https://review.opendev.org/c/openstack/ironic/+/91722918:08
cidHmm,,, 18:11
TheJuliaYeah, I guess I'd do something like "yield None" in the method to create the fileand that could also be a signal to handle it as the environment variable18:14
cidSorry, I think you misunderstand me, or ...18:16
cidI was referring to JayF's comment: "Unless there's a good reason it's not, we should switch this code to use _exec_ipmitool -- it's the only code that's independently managing credentials."18:16
cid#1575 in the change.18:17
TheJuliaoh18:19
TheJuliaahh18:19
TheJuliait is generating the full command, which is why18:20
cidYea.18:23
cidOk, please, let me let you ... thanks!18:23
TheJuliaI think your on the right path there, just unit tests will need to be changed18:26
cidnoted18:35
opendevreviewcid proposed openstack/ironic master: Flexible IPMI credential persistence method configuration  https://review.opendev.org/c/openstack/ironic/+/91722918:47
cid\o20:12
opendevreviewMerged openstack/ironic-python-agent-builder master: Block cloud-init user-data loading  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/92018421:23
opendevreviewJulia Kreger proposed openstack/ironic master: WIP Advanced vmedia deployment test ops  https://review.opendev.org/c/openstack/ironic/+/89801021:49

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!