Monday, 2024-07-29

opendevreviewIury Gregory Melo Ferreira proposed openstack/sushy-tools master: Update irrelevant-files for sushy-jobs  https://review.opendev.org/c/openstack/sushy-tools/+/92506901:22
opendevreviewMerged openstack/sushy-tools master: Add fake system driver docs  https://review.opendev.org/c/openstack/sushy-tools/+/92492001:55
opendevreviewJacob Anders proposed openstack/bifrost master: [DNM] test UUID VM definitions  https://review.opendev.org/c/openstack/bifrost/+/92507404:28
opendevreviewJacob Anders proposed openstack/bifrost master: [DNM] test UUID VM definitions  https://review.opendev.org/c/openstack/bifrost/+/92507405:47
rpittaugood morning ironic! o/06:43
opendevreviewJacob Anders proposed openstack/bifrost master: [DNM] test UUID VM definitions  https://review.opendev.org/c/openstack/bifrost/+/92507408:12
jandershey rpittau o/08:12
rpittauhey janders :)08:12
opendevreviewJacob Anders proposed openstack/bifrost master: [WIP] Use libvirt UUIDs instead of VM names in Redfish system_ids  https://review.opendev.org/c/openstack/bifrost/+/92507408:31
drannouHello ironic08:35
opendevreviewMohammed Boukhalfa proposed openstack/sushy-tools master: Extend the fake systems driver with external systems status notifier  https://review.opendev.org/c/openstack/sushy-tools/+/92311108:46
opendevreviewMohammed Boukhalfa proposed openstack/sushy-tools master: Extend the fake systems driver with external systems status notifier  https://review.opendev.org/c/openstack/sushy-tools/+/92311108:58
opendevreviewMohammed Boukhalfa proposed openstack/sushy-tools master: Extend the fake systems driver with external systems status notifier  https://review.opendev.org/c/openstack/sushy-tools/+/92311110:27
iurygregorygood morning ironic11:09
opendevreviewJonas Schäfer proposed openstack/ironic-python-agent master: agent: make _find_routable_addr dual-stack capable  https://review.opendev.org/c/openstack/ironic-python-agent/+/92508711:11
jssfro/ I just opened https://review.opendev.org/c/openstack/ironic-python-agent/+/925087 by accident because I didn't expect that `git review` does things instead of showing a help page. I haven't checked the tests or lints yet, so sorry for the noise.11:13
iurygregoryjssfr, no worries =)11:15
dtantsurjssfr: you can mark it as not ready by using "Workflow -1" in the UI11:27
jssfrlet me find out how to log in :) it's been a while :)11:30
jssfrdo I just post "Workflow -1" in the comments?11:31
jssfrI found a "Mark as Work in Progress" button11:32
jssfrdid that do the right thing?11:32
dtantsurjssfr: "Reply" button, then select a Workflow vote -111:34
dtantsurOr you can mark as WIP (I've never used this feature, it's quite new)11:34
jssfrI apparently just did the latter11:34
jssfrtext search on the page doesn't find a "reply"11:35
jssfrah, "Start review"11:35
opendevreviewJonas Schäfer proposed openstack/ironic-python-agent master: agent: make _find_routable_addr dual-stack capable  https://review.opendev.org/c/openstack/ironic-python-agent/+/92508711:37
jssfralright, added tests :)11:37
opendevreviewJonas Schäfer proposed openstack/ironic-python-agent master: agent: make _find_routable_addr work with IPv4- and IPv6-only setups  https://review.opendev.org/c/openstack/ironic-python-agent/+/92508711:38
opendevreviewMohammed Boukhalfa proposed openstack/sushy-tools master: Extend the fake systems driver with external systems status notifier  https://review.opendev.org/c/openstack/sushy-tools/+/92311112:04
drannouDoes anyone has some times to check my bug report https://bugs.launchpad.net/ironic/+bug/2072336 ?12:15
drannoufor me, it's a huge problem, because it's hidden, and at the end it will reach a motherboard limit12:16
cidLooking...12:25
* cid oh, seems I already did. Someone with more experience will need to now.12:27
drannouthe patch is very simple, I already apply it on our infra, but I don't know all motherboard integrations, may be some are using UTF-16, but that would be wired in my POV12:28
dtantsurdrannou: do you just assume utf-8 or what's the fix?12:31
drannoudtantsur: yes, only replace utf-16 to utf-8 in the decode call12:31
drannouif someone has some running nodes, that had multiple install, to check the EFI boot entries and confirm the bug ?12:34
dtantsurI wonder why utf-16 was added. TheJulia was it you?12:34
dtantsurmaybe we can try both..12:34
drannouhttps://github.com/openstack/ironic-python-agent/commit/76accfb880474445a5dcb07825889123b3dd023712:36
TheJuliaIt is *supposed* to be utf-16, but obviously sometimes jr is not. :(12:37
dtantsurokay, so we at least should not just blindly revert it. maybe if we fail with UnicodeError, we can try utf-812:37
TheJuliaS/jr/it/12:37
TheJuliaI unfortunately have had customer cases come up with utf-16 encoded regional accent characters12:39
drannouYep not really surprising, but the problem is that it has a huge impact on my hosts: after multiple install, the host refuse to boot automatically, I have to manually select the boot entry in the bios12:40
TheJuliaThat sounds like a vendor firmware bug12:47
TheJuliahonestly12:47
TheJuliaplus, we should be removing old entries12:48
drannouMay be but we should catch this problem to not create a new bug12:52
TheJuliaI guess13:02
TheJuliaso about 3 months ago, stevebaker posted https://github.com/openstack/ironic-python-agent/commit/215fecd4470e868e1bac9737417e166a7e10fb6413:04
TheJuliaWould be reasonable to backport I guess13:04
TheJuliaAlso, good morning everyone13:06
rpittauhey TheJulia :)13:11
drannouI saw this commit, but IPA was already doing some clean, so yes it's an improvement, but not fixing the problem :). But I just made a test by removing the ignore errors, and catching the exception, it's working 13:13
TheJuliaWell, ideally it should actually prevent the case your ultimately hitting with excess entries if properly decoded13:15
TheJuliathe issue, I think is your running the command and the data is unreadable as a result13:15
TheJulia... Which makes me wonder what distribution your using as well13:16
drannouon my IPA ? Debian 1213:16
TheJuliaInteresting. I wonder if Debian is defaulting with anything which would impact efibootmgr's behavior13:33
opendevreviewAdam Rozman proposed openstack/ironic-specs master: propose root partition and configdrive encryption  https://review.opendev.org/c/openstack/ironic-specs/+/92499313:36
TheJuliabraaaains13:38
opendevreviewAdam Rozman proposed openstack/ironic-specs master: propose root partition and configdrive encryption  https://review.opendev.org/c/openstack/ironic-specs/+/92499313:46
opendevreviewMerged openstack/ironic master: Log node UUID and not entire node instance to avoid logging its driver_info field  https://review.opendev.org/c/openstack/ironic/+/92483814:28
rpittau#startmeeting ironic15:00
opendevmeetMeeting started Mon Jul 29 15:00:16 2024 UTC and is due to finish in 60 minutes.  The chair is rpittau. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
opendevmeetThe meeting name has been set to 'ironic'15:00
rpittauHello everyone!15:00
rpittauWelcome to our weekly meeting!15:00
rpittauThe meeting agenda can be found here:15:00
rpittau#link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_July_29.2C_202415:00
TheJuliao/15:01
mohammedo/15:01
JayFO/15:02
cardoeo/15:02
rpittaualright let's start15:03
masgharo/15:03
rpittau#topic Announcements/Reminders15:03
cido/15:03
rpittau#info Standing reminder to review patches tagged ironic-week-prio and to hashtag any patches ready for review with ironic-week-prio15:03
rpittau#link https://tinyurl.com/ironic-weekly-prio-dash15:03
iurygregoryo/15:03
rpittau2-3 patches that looks ready there15:04
rpittau#info 2024.2 Dalmatian Release Schedule15:05
rpittau#link  https://releases.openstack.org/dalmatian/schedule.html15:05
rpittaunew bugfix branches will be requested this week15:05
rpittauwe're at R-9, 3 weeks to release for non-client libraries15:05
rpittau#info he next OpenInfra PTG which will take place October 21-25, 2024 virtually! Registration is now open!15:06
rpittau#link https://ptg.openinfra.dev15:06
rpittauthe ironic team has been registered!15:06
rpittauand JayF prepared a meetpad page15:06
rpittau#link https://etherpad.opendev.org/p/ironic-ptg-october-202415:06
TheJulia... 21-st through 25th... right when I was planning on being on vacation :(15:06
TheJuliale-sigh15:06
rpittauput your ides/suggestions/comments there15:06
rpittauTheJulia: d'oh15:06
rpittauI may miss a couple of days too, probably half of that week15:07
rpittauwell, we'll see15:07
rpittauanything else we want to announce/remind ?15:08
JayFI'll note that that ptg schedule is also within a stone's throw of my brother's wedding. I don't have a direct conflict, but I could see enough of us having trouble that we may want to have some type of off-cycle ironic sync15:08
rpittauJayF: let's see how many people are available and then we can definitely think about having a separate sync, maybe reducing the official PTG time15:09
TheJuliaHonestly, I think more high bandwidth/sync communiation is better than once every six months15:09
TheJuliaso if we have a pre-ptg sync, we could at least get some stuff raised up/identified for wider discussion15:10
JayFThat's actually a pretty good observation. At a minimum, consider bringing back spuc... We could also consider doing a once-monthly video meeting similar to what the TC does15:10
TheJuliawhich would better enable us to move forward with one person who might have previously been critical for the discussion to take place15:10
rpittausure, although IMHO the PTG helps on planning for the next release, so we should still decide on priorities for the next cycle15:10
TheJuliaSanity presevation unconference often did end up being some deep technical discussion15:11
TheJuliarpittau: agree completely15:11
TheJuliaI just don't think we should shoehorn all activities including problem definition into the PTG and expect success to result15:11
JayF++15:12
TheJulialike Adam's whole disk encryption proposal.... that might need some advance discussion before planning or at least base context sharing15:12
rpittauI guess we can come up with the priorities during other discussions and then just write them down to have them ready for the next cycle15:12
JayFTheJulia: I just wanna talk with him about it b/c it's so dang cool :D 15:12
TheJuliaWell, spreading understanding is distinctly different than defining and deciding on priorities15:13
TheJuliaJayF: oh my, I haven't even read it yet becuase insanely busy15:13
JayFwe've often combined what and how in PTG15:13
* TheJulia resists for now15:13
JayFsplitting them is wise15:13
TheJuliawe don't have to entirely split, just... spread context, and it doesn't have to be formal15:14
JayFTheJulia: eh, more that I'm a sicko who appreciates seeing crap I've manually done in a gentoo desktop get mainstream enough that I might to get it for my day job :D15:14
TheJuliaeh, that is more Freaky, TBH :)15:14
cardoeSomeone likes self flogging.15:14
TheJuliaheh15:14
JayFnot exactly :D15:15
TheJuliaOkay, back to the topic at hand!15:15
JayFIt's not that tough anyway, dracut supports it well15:15
rpittaulet's see how many topics we have for the PTG first15:15
TheJuliaI do think bringing back the SPUC is worthwhile just from a contributor connection/relationship building standpoint15:15
JayF++ especially with new folks in the community15:16
cardoeCan someone define SPUC? (sorry newbie here)15:16
TheJuliaSanity Preservation Un-Conference15:16
masghar(Also listening)15:16
TheJuliaA weekly call we did during the pandemic to give people an outlet to vent/connect/relate15:16
TheJuliaAnd discuss any topics in high bandwidth15:17
masgharOh that sounds nice15:17
TheJuliaKeep in mind, when we started it, most of the core contributors were loosing all remaining sanity15:17
TheJuliaBut it really did help15:17
JayFWe eventually gave up on sanity preservation15:18
JayFbut friendship is valuable even for those who have no sanity :) 15:18
TheJulia++15:18
rpittauI agree15:18
rpittauif we bring that back maybe we could do it once per month or something like that15:18
TheJuliaAnyway, lets get meeting back on track15:18
rpittauyep15:18
rpittau#topic Review Ironic CI status15:19
TheJuliaAnything that is not weekly makes it hard to keep it in mind, fwiw.15:19
rpittau#info ironic CI was impacted by an issue caused by the removal of simplejson from osc reqs15:19
JayFstevebaker[m] and I are doing a stable branch CI audit, I think much of that is in better shape than usual15:19
JayFbut I need to check in to see how far we've gotten 15:20
rpittauJayF: I think I reviewed most of the changes already15:20
rpittaubtw this is the meetpad link15:20
rpittau#link https://etherpad.opendev.org/p/ironic-ci-audit-july-202415:20
JayFyeah I just haven't checked that in a couple days, had other distractions15:22
rpittauI'll have another look at the patches during the week15:22
rpittauprobably we need to clarify that anything that still uses CS8 must be removed or made non-voting15:22
rpittaunot sure it's worth to upgrade to CS9 unless we still maintain the branch15:23
TheJuliaRemoved, I believe15:23
TheJuliasince the base images are also gone and the jobs just get ignored as a result15:24
rpittauyeah, actually better not waste CI resources15:24
TheJulia++15:24
rpittauanything else CI related ?15:24
rpittaualright so we don't have discussion topics, unless someone has something to bring up15:25
JayFI think cardoe had something for open discussion15:26
rpittausure thing15:26
cardoeHello all. Got a few asks.15:26
cardoeSo working on an effort around a sizeable amount of machines living in Ironic (multiple ones that we'll have as regions)15:27
cardoeOur deployment is centered around Kubernetes and we're using OpenStack Helm.15:27
cardoeWe're letting people consume the hardware via Nova and some like jamesdenton consume it via baremetal directly.15:27
cardoeJust wanted to share that context.15:27
TheJuliaInteresting....15:27
TheJuliacontext++15:28
JayFoh, you're working on my old cluster, or something adjacent to it :D 15:28
cardoeHappy to give more details anytime as well.15:28
cardoeSo we've tried to use the redfish inspector via sushy and there's quite a bit of bits lacking.15:28
JayFI'm sorry and/or you're welcome as appropriate :)15:28
chris218Hi is the meeting still ongoing?15:28
TheJuliachris218: yes, cardoe has the floor15:29
cardoeI've been monkey patching some more endpoints into sushy because I know there's a specific targeted profile, but how much appetite is there to extensions there?15:29
cardoee.g. ethernet_interfaces is busted on a bunch of hardware.15:29
cardoehttps://review.opendev.org/c/openstack/ironic/+/92494315:29
TheJuliacardoe: so there is a lot of history here, so I guess to sort of start off15:29
cardoee.g. Dell R76xx family of hardware with iDRAC 9 7.x.y.z returns only the 2 on board 1GB interfaces and then an empty MAC address and none of the other NIC cards plugged in.15:30
TheJuliaThe out-of-band introspection is minimal information, but I think we would accept patches to obtain/match identify more within reason15:30
TheJuliaethernet_interfaces themselves has a long, painful, history15:30
cardoeRight. I've switched us to using Ports15:30
TheJuliacool cool15:30
dtantsurYou have a fix though, it just needs to be moved to sushy?15:30
cardoeWell the fix for that change request is to just filter out the empty MAC. Which is done in a few places in Ironic code. Probably should be centralized.15:31
TheJuliaso the other challenge there is depending on the cards, the interface between the BMC and the firmware (i.e. is it dell's version fo the firmware, or chipset OEM's card, or even third party firwmare), your going to get different BMC reporting behavior *as well*15:31
cardoeMy "full" fix is to stop using ethernet_interfaces and use the ports endpoint in Redfish, but that's a big change to the interop profile.15:31
TheJuliafiltering the empty mac makes sense15:32
dtantsurcardoe: yeah, also we cannot stop using them - we'll definitely find a hardware that only has EthernetInterfaces...15:32
cardoeI've got piles of HP and Dell gear only that I'm testing against. So that's gonna be my bias filter.15:32
dtantsur(we've been in similar positions several times)15:32
TheJuliathe underlying problem is.... I'm trying to think of the protocol used for out of band communications between the BMC and the cards, it knows it is a nic, but not enough information/support to pass along the mac address15:32
TheJuliaso filtering empty makes *tons* of sense15:32
dtantsurbut we definitely need to fix sushy to rule out empty strings. if you're not planning on it, we should probably Just Do It ourselves15:33
cardoeSo would there be an appetite for adding a "ports" interface to sushy? Ironic doesn't have to depend on it.15:33
dtantsurTheJulia: we already have "is not None" already btw, but that does not capture empty strings15:33
TheJuliaI would be happy to review such patches15:33
cardoeYou don't have to do it. You gimme $TIME and I'll cherry-pick them out and push them to gerrit15:34
dtantsurcardoe: we're open for any standard-compliant extensions that open new possibilities for Ironic or adjacent projects15:34
TheJuliadtantsur: yeah, that was sort of what I was figuring15:34
cardoeYeah so my Ports implementation follows the DMTF spec15:34
rpittauthat's a great selling point :)15:35
cardoeI tried to make it as identical how you guys have done the others. But I'm sure there's some stuff I've missed and don't know. I'm happy to get review and do the lift to get it landed.15:35
JayFthat sounds like about as easy of a change as we'll ever have to approve from a theoretical standpoint. A standards-compliant implementation of a redfish endpoint mimicing existing style :D 15:35
cardoeEssentially I'm trying to add as much of what Ironic Inspector did into the Redfish inspector.15:35
cardoeTo have as much out of band as possible.15:36
dtantsur++15:36
cardoeWhen I send a human into the DC to fix up a box, I wanna quickly out of band make sure the hardware they swapped is where it's suppose to be.15:36
cardoeand before they get back to their desk be able to tell them "no go back and fix it"15:37
TheJuliaThe one thing to keep in mind, you may still want a full OS to boot and look for any devices, because BMC support and reporting replies on firmware on the card behaving on the i2c bus15:37
TheJulia++15:37
cardoe100%. We're doing out-of-band not using the ironic redfish inspector today. But I'm pushing my team to use sushy (our fork) for all of that.15:37
cardoeThen we're flipping it to ironic inspector to do the more complete inspection.15:38
TheJuliavery cool15:38
TheJuliaSounds good15:38
cardoeSwitching to the "agent" currently.15:38
cardoeJust wondering if we can maybe contribute this to the redfish inspector eventually.15:38
cardoeOr land our sushy bits into actual upstream.15:39
JayFI think the answer is very yes15:39
cardoeWe did some Dell specific bits in our sushy fork which now wanting us to fork sushy-oem-idrac and get it there.15:39
cardoeOkay good.15:39
JayFI think we've considered in the past rolling sushy-oem-drac back into sushy15:39
JayFmight be worth having a larger discussion about that if it makes what you're doing easier, too15:39
cardoeThe other issue we've got is for new hardware out of the box (or maybe pallet? or shipping container? I dunno never seen the gear in person)15:39
cardoeA lot of Dell stuff doesn't PXE boot for example.15:40
TheJuliasushy-oem-idrac is largely for the super-specific behavior dell doesn't intend to change/fix/make compliant15:40
cardoeWe do some Redfish calls to fix it up15:40
dtantsuris virtual media an option (instead of pxe)?15:40
TheJuliawill the dell gear do httpboot out of the box?15:40
cardoeNot sure. I need to still test with that.15:41
cardoeThat was my backport question cause the idrac driver doesn't allow redfish-https15:41
TheJuliaoh, to send a network boot url out of band?15:41
cardoeyeah. It's on a REAL soon sprint for someone to work that.15:42
cardoeAnd confirm15:42
TheJuliayeah, that is likely just a bug from my point of view15:42
cardoeI assume httpboot you meant redfish-https15:42
TheJuliayeah, one of the flavors15:42
TheJuliathere are two distinct http boot flavors15:42
cardoeSo we poke the BIOS settings via redfish15:43
dtantsurvirtual media exists for somewhat longer though15:43
TheJuliaI think dell gear from the factory ships leaning towards httpboot out of the box, but I've never seen a fresh from the factory box which has not been modified by well meaning humans15:43
cardoeyeah virtual media doesn't work on the last dozen? or more racks we've gotten from Dell.15:43
TheJuliaoh joy15:44
cardoehttps://paste.opendev.org/show/bpoxYEvFBbqHpsGTy1IF/ https://paste.opendev.org/show/bUZln4wKQ1eINnjpTscw/15:44
TheJuliacardoe: if you can get us details in a bug, we might be able to assist with that15:44
dtantsurhuh, interesting. we have bugs from time to time, but never seen any issues at scale15:44
cardoeWill do.15:44
cardoeI mean I didn't try EVERY server in the rack15:44
TheJuliaI think this one has appeared in very recent firmware15:45
TheJulia"Virtual Media is detached or Virtual Media devices are already in use."15:45
cardoeBut n is definitely n>115:45
cardoeyes. These boxes all came with iDRAC9 7.00.60.0015:45
TheJuliaI ?think? Iury was starting to look a week or two ago15:45
* iurygregory looks15:45
cardoeWhatever the 6.x.y.z version was didn't do this.15:45
TheJuliayeah15:46
cardoeSo to that effect, I tried to use the bios config of the redfish driver in Ironic.15:46
iurygregoryoh I saw this error once15:46
TheJuliaAnything else cardoe? I think chris218 was next up :)15:46
cardoeBut it doesn't allow for disable_ramdisk=True15:46
iurygregorybut it was also a networking problem15:46
dtantsurcardoe: re disable_ramdisk, janders and I have mid-terms plans to look into that (in the context of servicing)15:46
iurygregoryironic couldn't reach the address I had the vmedia15:46
cardoeokay I'll work with janders on that.15:47
cardoePerfect. I'll give up the floor. Thank you all.15:47
rpittaucardoe:  would be nice to continue the discussion, please open a bug and we'll look into it :)15:47
rpittauthanks!15:47
TheJuliaThanks cardoe!15:47
rpittauany other discussion topics?15:47
cardoeJust wanna say thank you all for the hard work. I wanna make sure we contribute back and get my folks engaged so thanks for entertaining me and my questions.15:47
TheJuliachris218: you were wondering if the meeting was still in progress? Do you have a topic for discussion?15:48
TheJuliaI guess something got their attention.15:50
* TheJulia shrugs15:50
cidchris218 is probably away from the keyboard.15:51
rpittaulet's move on15:51
rpittau#topic Bug Deputy Updates15:51
rpittaucid: anything to report?15:51
cidNothing really. 15:51
cidOnly a new bug was filed and someone help me with triaging it.15:51
* cid one15:52
rpittauok cool15:52
rpittauany volunteer for bug deputy for this week ?15:52
iurygregoryI can 15:53
rpittauthanks iurygregory :)15:53
rpittau#topic RFE review15:53
rpittauwe have an rfe to discuss apparently https://review.opendev.org/c/openstack/sushy-tools/+/92311115:54
JayFThere seems to be a lot of ... undocumented context around the direction of sushy-tools?15:54
mohammeda tiny patch on sushy-tools. It's a minimal and generic hook that can be enabled to send status changes to a pluggable component's API endpoint15:54
JayFI don't have a strong care about it, other than worrying about if this complexity could be maintained if the folks interested in these advanced features went away15:54
dtantsurJayF: not really a lot, the root is very simple: the group of us wants to adapt sushy-tools for scale-testing Ironic15:54
dtantsurlike, scale scale15:55
JayFThat sounds like a worthy thing, and exciting, but without the plan laid out for upstream about how it's being done, it does make it difficult to review15:55
dtantsurthen there is some history on how we came to this specific proposal15:55
TheJuliaI think the problem is the original discussion didn't spread wide so ongoing context is lost15:55
dtantsurJayF: have you seen the updated docs? https://review.opendev.org/c/openstack/sushy-tools/+/923111/14/doc/source/user/dynamic-emulator.rst15:56
TheJulia(Hey, this is the sort of thing SPUC would have helped with! *ducks*)15:56
dtantsurSPUUUC \o/15:56
mohammedWhy do we need it? It extends the fake system, which is currently insufficient for testing end-to-end Ironic deployments.15:56
masgharSPUC++15:56
JayFI guess I just wish I could see the whole picture15:56
mohammedwho will use it? For now, but not limited to, the fake IPA (which mocks some real IPA command executions). This component is in progress on the Metal3 org, and we plan to integrate it with the fake system using this interface.15:56
JayFright now it feels like I'm reviewing the "y" of the xy problem on all these changes because I can't see the bigger picture15:56
chris218TheJulia: nah I had a question about implementing custom ironic driver15:57
JayFwhich is mostly fine, I rarely review sushy* stuff anyway, but it seems to need the review attention now15:57
mohammedNote: Sushy-tools emulates Redfish-compliant hardware, creating a "fake" environment to mimic the behavior of physical hardware for testing and development purposes. The fake system within sushy-tools adds another layer of simulation, creating fake drivers and components on top of the already emulated hardware environment. Essentially, the fake system is a "fake of the fake" and is intended only for testing purposes. I 15:57
mohammedjust want to use it, and if there is no motivation to merge it into sushy-tools, I can host it elsewhere to continue using it effectively.15:57
cardoeI mean I've thought about using something similar to that for some "fast" tests.15:58
TheJuliaI think it is likely okay15:58
TheJuliait being the doing a thing, not having looked at the content yet15:58
cardoeBut our concern has definitely been to not pull a Crowd Strike and implement our behavior to the fake implementation and then have issues in prod.15:58
TheJulia.... too soon15:59
* TheJulia had to deal with airline flight drama15:59
mohammedi do not think sushy will run in any prod env 16:00
dtantsurcardoe: sushy-tools is something that should not exist in production hence we're trying to put everything there16:00
dtantsurmohammed: please avoid confusion: sushy vs sushy-tools16:00
dtantsursushy is a Python library that Ironic uses16:00
JayFmohammed: yeah, mainly my question in the review was in an attempt to have this conversation happen16:00
rpittauI guess we need to keep discussing that, maybe one ore more reviews with questions/answers in the patch could help16:00
JayFmohammed: the conversation has happened, people are more on the same page, I think you'll get this all landed16:01
TheJuliaJayF: ++16:01
dtantsurI think the patch looks solid, I just spotted one issue with power state handling16:01
rpittaualright then :)16:01
rpittaugoing to close the meeting, we're a couple of minutes out16:02
rpittauthanks all!16:02
rpittau#endmeeting16:02
opendevmeetMeeting ended Mon Jul 29 16:02:14 2024 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:02
opendevmeetMinutes:        https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-07-29-15.00.html16:02
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-07-29-15.00.txt16:02
opendevmeetLog:            https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-07-29-15.00.log.html16:02
TheJuliachris218: feel free to pose your question, the brains are all sort of still engaged16:02
adam-metal3oh so the meetng ends at this time not starts :(16:04
chris218I'm planning to implement driver for intel amt for my homelab and had a few questions, for example I can query amt if secure boot is supported but can't enable/disable it, also can't query whether UEFI/Legacy boot is configured16:04
chris218also I know staging drivers have amt implementation (haven't tested it) but I know console for example isn't implemented with it16:04
TheJuliaadam-metal3: hi!16:04
rpittaugood night! o/16:04
TheJuliachris218: might depend on the chips you have with that AMT16:04
TheJuliachris218: since some CPUs don't actually have LegacyBios anymore16:05
cardoedtantsur: 16:05
chris218yea lenovo doesn't like to enable all the features it's 8th gen thinkcentre16:05
TheJuliawhat model cpus do you have?16:05
cardoedtantsur:  https://review.opendev.org/c/openstack/ironic/+/924943 so I'll stick that somewhere more common. There's a spot within the wrapper of sushy in Ironic.16:05
adam-metal3TheJulia: hi!16:05
dtantsurcardoe: why not sushy itself? it literally has the check, it just does not go far enough.16:06
chris218thinkstation on the other hand even supports httpboot :(16:06
chris218I have 6 nodes with i5-8600t 16:06
cardoeYeah that's what I was gonna say it should drag up into sushy16:06
TheJuliacoffee lake derived16:07
TheJuliaYeah, they should support legacybios16:08
TheJuliabut yeah, lenovo may have locked that out16:08
chris218yea, it supports it but I can't enable/disable it through amt, should I just omit functions relating to those features in ironic driver?16:09
cardoeOH I just remembered the PTG thing I wanted to ask16:11
cardoeSo some projects have started to adopt using Python Type Whispering^H^H^HHinting and generating OpenAPI from that.16:11
cardoeHappy to expand on that.16:12
cardoeBut you could utilize something like mypy for testing then as well.16:12
adam-metal3I wanted to ask but for some reason I had the meeting time in my calendar shifted one hour, is there anyone who might have read the disk partition encryption proposal, are there any thoughts about it?16:15
chris218Hmm since when does sushy-tools have nova support?17:08
chris218It uses "libvirt:pxe-first" metadata attribute which never was implemented and was used here: https://opendev.org/openstack/openstack-virtual-baremetal/src/branch/stable/2.0/patches/nova/nova-pxe-boot.patch17:11
TheJulia... OVB17:12
TheJuliaMaybe talk to stevebaker17:12
TheJuliachris218: or hjensas, stevebaker did it to support test VMs with nova backing17:54
chris218tbh it's not an issue for me I just found it and thought you guys might want to know18:03
TheJuliaoh, so I *think*  it needs to be used with an ipxe base image which forces loading into it18:09
chris218nah ipxe base image works without it, that metadata parameter does nothing there's no even mention of it in nova source code18:25
chris218you need that 3 line patch linked above to make it work with libvirt but it never got into upstream18:26
TheJuliachris218: oh yeah, I know it would work without it :)19:06
TheJuliabecause it is ipxe in a disk19:06
TheJuliaanyway, stevebaker[m] ^^19:07
cidA little runbook demo video: https://youtu.be/00PJS4SXFYQ. I thought it might help with review.19:46
opendevreviewcid proposed openstack/ironic master: Use gerunds for task headings  https://review.opendev.org/c/openstack/ironic/+/92512919:46
cido/19:49
opendevreviewDoug Goldstein proposed openstack/sushy master: avoid MAC addresses that are the empty string  https://review.opendev.org/c/openstack/sushy/+/92513019:50
cardoeHow about that dtantsur ^19:50
cardoeAre there some better examples of RAID configuration somewhere. Tried to do something like... {"size_gb": 10000, "number_of_physical_disks": 12, "raid_level": "1+0", "is_root_volume": false, "disk_type": "ssd"} I'm only able to set size_gb to the size of a singular disk.19:53
JayFCid: is that linked in the change?19:53

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!