| rpittau | good morning ironic! o/ | 07:34 |
|---|---|---|
| masghar | Good morning! | 08:06 |
| *** jcosmao is now known as Guest425 | 08:13 | |
| opendevreview | Merged openstack/ironic master: Follow up to the runbooks change (#922142) https://review.opendev.org/c/openstack/ironic/+/925917 | 10:27 |
| iurygregory | good morning ironic | 10:33 |
| * TheJulia caffinates | 14:20 | |
| opendevreview | Doug Goldstein proposed openstack/ironic master: idrac: inherit driver interface from redfish https://review.opendev.org/c/openstack/ironic/+/926227 | 14:59 |
| JayF | I just asked a couple of folks privately, but https://review.opendev.org/q/topic:ironic-guest-metadata really needs reviews if people have a sec | 15:06 |
| cardoe | dtantsur: I noticed that my https://review.opendev.org/c/openstack/ironic/+/926227 is a different approach to your https://review.opendev.org/c/openstack/ironic/+/902107 I'm happy to drop mine or take any feedback on mine to make it complete with what you wanted. | 15:14 |
| dtantsur | cardoe: I don't mind taking your approach, I don't have time to work on mine. | 15:18 |
| dtantsur | we'll need to do my change one day, it's not mutually exclusive with yours | 15:18 |
| dtantsur | and we probably need to remove the no longer accessible wsman interfaces | 15:18 |
| dtantsur | and add a release note | 15:18 |
| * dtantsur is in a meeting, thus the chaotic c omments | 15:19 | |
| cardoe | Well the wsman interfaces are gone already. | 15:20 |
| dtantsur | ahhh hmmm. I'm terribly out of date then. | 15:20 |
| cardoe | So the idrac driver is now a superset of the redfish. Unfortunately since it implements a bunch of the supported fields itself as things have gotten added to the redfish, they haven't been added to the Dell. So just as a first swag I made the idrac inherit from the redfish. | 15:21 |
| dtantsur | yeah, it's a fair call | 15:21 |
| TheJulia | JayF: I commented on your ironic patch and left a -1, sorry. On a plus side, you were aware it was coming :) | 15:21 |
| dtantsur | note though that the order of classes in all these lists actually matter for the calculation of the default interface | 15:22 |
| dtantsur | I'll put your patch on my queue and try to provide a more sanely sounding comment when I get some rest (probably tomorrow) | 15:22 |
| cardoe | I appreciate it. | 15:22 |
| rpittau | bye everyone, see you on friday o/ | 15:54 |
| JayF | the -1 always existed in your head, now I know about it :P | 15:55 |
| opendevreview | Elod Illes proposed openstack/metalsmith master: DNM: gate health test https://review.opendev.org/c/openstack/metalsmith/+/926299 | 15:59 |
| JayF | That's not a great sign ^ | 16:04 |
| JayF | Has anyone given metalsmith the needful care and feeding this cycle | 16:04 |
| * JayF asked Elod if there was something specific he was concerned about | 16:10 | |
| JayF | > only those libs that haven't merged any patch recently (in the last 45 days) < this is why, so not a big deal | 16:15 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/925756 is a very easy review and something that improves our docs a lot if someone wants to land it | 18:38 |
| JayF | trying to get it in before it conflicts with anything | 18:38 |
| JayF | https://review.opendev.org/c/openstack/python-ironicclient/+/924101 also would be nice to land before client freeze (~1wk) | 19:00 |
| opendevreview | cid proposed openstack/ironic master: [WIP] Add inspection rules https://review.opendev.org/c/openstack/ironic/+/918303 | 19:24 |
| cid | o/ | 19:24 |
| opendevreview | Merged openstack/ironic master: Link to configuration options https://review.opendev.org/c/openstack/ironic/+/925756 | 19:38 |
| iurygregory | forum session submitted \o/ | 20:08 |
| opendevreview | Merged openstack/python-ironicclient master: Add CLI support for runbooks https://review.opendev.org/c/openstack/python-ironicclient/+/924101 | 20:10 |
| JayF | Thanks for landing those, and g/l Iury | 20:57 |
| cardoe | Well I'll rebase https://review.opendev.org/c/openstack/python-ironicclient/+/924895 and I was hoping to get it landed before the client freeze as well. | 21:45 |
| JayF | link it in here when you rebase and I'll reissue my vote | 21:46 |
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient master: support passing disable_ramdisk for clean and service state https://review.opendev.org/c/openstack/python-ironicclient/+/924895 | 21:56 |
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient master: support passing disable_ramdisk for clean and service state https://review.opendev.org/c/openstack/python-ironicclient/+/924895 | 22:02 |
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient master: support passing disable_ramdisk for clean and service state https://review.opendev.org/c/openstack/python-ironicclient/+/924895 | 22:04 |
| cardoe | There no white space changes in cid's part. /me shake fist at editor. | 22:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!