opendevreview | Merged openstack/ironic stable/2023.2: CI: Remove grenade jobs for 2023.2 https://review.opendev.org/c/openstack/ironic/+/928294 | 00:24 |
---|---|---|
opendevreview | Verification of a change to openstack/ironic stable/2023.1 failed: CI: stable/2023.1 - remove partition and older non-voting jobs https://review.opendev.org/c/openstack/ironic/+/928290 | 01:36 |
*** dtantsur_ is now known as dtantsur | 01:57 | |
opendevreview | Verification of a change to openstack/ironic stable/2023.1 failed: CVE-2024-44982: Harden all image handling and conversion code https://review.opendev.org/c/openstack/ironic/+/927972 | 02:48 |
*** ex_tnode8 is now known as ex_tnode | 04:31 | |
dtantsur | TheJulia, JayF, a very late question, but does any of you maintain a list of things we disabled/removed/changed temporary to push the changes through? | 10:50 |
opendevreview | Verification of a change to openstack/ironic stable/2023.1 failed: CI: stable/2023.1 - remove partition and older non-voting jobs https://review.opendev.org/c/openstack/ironic/+/928290 | 11:13 |
opendevreview | Verification of a change to openstack/ironic stable/2023.1 failed: CVE-2024-44982: Harden all image handling and conversion code https://review.opendev.org/c/openstack/ironic/+/927972 | 11:22 |
cardoe | One that we likely will want to land before the release is https://review.opendev.org/c/openstack/ironic/+/926961 I was doing a review on the release notes and for Ironic this functionality is mentioned but that's the docs for the functionality. | 12:55 |
TheJulia | dtantsur: Only thing I removed was long broken bit rotted jobs on unmaintained branches. The grenade removal was not necessary yet, but once 2023.1 goes unmaintained, it was going to break anyway | 12:58 |
TheJulia | thatw as grenade on 2023.2 | 12:58 |
opendevreview | OpenStack Release Bot proposed openstack/ironic-lib stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/ironic-lib/+/928354 | 13:08 |
opendevreview | OpenStack Release Bot proposed openstack/ironic-lib stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/ironic-lib/+/928357 | 13:08 |
opendevreview | OpenStack Release Bot proposed openstack/metalsmith stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/metalsmith/+/928361 | 13:08 |
opendevreview | OpenStack Release Bot proposed openstack/metalsmith stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/metalsmith/+/928362 | 13:08 |
opendevreview | OpenStack Release Bot proposed openstack/metalsmith master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/metalsmith/+/928365 | 13:08 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironic-inspector-client stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/928367 | 13:08 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironic-inspector-client stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/928368 | 13:08 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironic-inspector-client master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/928369 | 13:09 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironicclient stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/python-ironicclient/+/928370 | 13:09 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironicclient stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/python-ironicclient/+/928371 | 13:09 |
opendevreview | OpenStack Release Bot proposed openstack/python-ironicclient master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/python-ironicclient/+/928372 | 13:09 |
opendevreview | OpenStack Release Bot proposed openstack/sushy stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/sushy/+/928373 | 13:09 |
opendevreview | OpenStack Release Bot proposed openstack/sushy stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/sushy/+/928374 | 13:09 |
opendevreview | OpenStack Release Bot proposed openstack/sushy master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/sushy/+/928375 | 13:09 |
opendevreview | Merged openstack/ironic stable/2023.1: CI: stable/2023.1 - remove partition and older non-voting jobs https://review.opendev.org/c/openstack/ironic/+/928290 | 13:24 |
TheJulia | \o/ | 13:25 |
cardoe | success! | 13:41 |
TheJulia | indeed! | 14:13 |
TheJulia | ugh, why is grenade still on zed | 14:27 |
* TheJulia sighs | 14:27 | |
opendevreview | Merged openstack/ironic stable/2023.1: CVE-2024-44982: Harden all image handling and conversion code https://review.opendev.org/c/openstack/ironic/+/927972 | 14:41 |
dtantsur | yay! | 14:50 |
* dtantsur adds ironic-lib future to the PTG topics | 14:52 | |
opendevreview | Merged openstack/sushy master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/sushy/+/928375 | 14:56 |
opendevreview | Merged openstack/sushy stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/sushy/+/928373 | 14:56 |
opendevreview | Merged openstack/sushy stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/sushy/+/928374 | 14:59 |
TheJulia | yeouch 2024-09-06 14:51:32.607500 | controller | {0} ironic_tempest_plugin.tests.scenario.test_baremetal_basic_ops.BaremetalBasicOpsAndRescue.test_baremetal_server_ops_wholedisk_image [2162.904526s] ... ok | 15:00 |
dtantsur | that took a while | 15:00 |
opendevreview | Merged openstack/python-ironicclient master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/python-ironicclient/+/928372 | 15:02 |
opendevreview | Merged openstack/python-ironicclient stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/python-ironicclient/+/928370 | 15:02 |
opendevreview | Merged openstack/ironic-lib stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/ironic-lib/+/928354 | 15:03 |
opendevreview | Merged openstack/ironic-lib stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/ironic-lib/+/928357 | 15:03 |
opendevreview | Merged openstack/python-ironicclient stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/python-ironicclient/+/928371 | 15:03 |
opendevreview | Merged openstack/python-ironic-inspector-client master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/928369 | 15:05 |
opendevreview | Merged openstack/python-ironic-inspector-client stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/928367 | 15:05 |
opendevreview | Merged openstack/python-ironic-inspector-client stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/928368 | 15:05 |
* dtantsur is backporting CVE patches to OCP and already wants to scream | 15:05 | |
cardoe | dtantsur: is there a wiki to add stuff to PTG topics? there was something recently I think JayF told me to bring up. | 15:15 |
dtantsur | cardoe: https://etherpad.opendev.org/p/ironic-ptg-october-2024 | 15:15 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent stable/2023.1: CI: Dial back CI jobs for 2023.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/928453 | 15:35 |
TheJulia | JayF: when your on, lets chat about butfix/9.9 | 15:37 |
dtantsur | as a data point: in metal3 we want to eventually use bugfix (or really any) branches for IPA. but we currently do not. | 15:38 |
TheJulia | I think that is unreasonable unless there is help to maintain CI on those branches. We can't simply swallow that and further spread limited resources | 15:40 |
TheJulia | today, they bitrot | 15:40 |
dtantsur | isn't 9.9 past the mark where we said we would maintain branches? | 15:41 |
TheJulia | You guys said it needed to be kept longer... | 15:42 |
* TheJulia shrugs | 15:42 | |
dtantsur | it could have been about Ironic, we're not using IPA yet | 15:42 |
TheJulia | I highly doubt that | 15:42 |
dtantsur | Well, the current state of things is. Metal3 relies on Ironic branches for some time. The oldest we use now is 24.0. Metal3 does not use IPA branches. | 15:43 |
TheJulia | Why don't we just turn off all testing, merge the fix, the branch will be gone soon | 15:43 |
dtantsur | From the OCP perspective, bugfix branches are helpful but nothing more. We have our own forks. | 15:43 |
dtantsur | TheJulia: where I'm aiming at is: the branch should have been deleted already, and we don't really need to fix it. | 15:44 |
TheJulia | Well, we committed to merging it on the basis we were told not to delete it | 15:44 |
TheJulia | because it was apparently needed | 15:44 |
TheJulia | So, there is a middle ground neither of us are on | 15:44 |
TheJulia | so we have to find it | 15:44 |
dtantsur | I cannot speak for all consumers | 15:44 |
TheJulia | exactly | 15:45 |
dtantsur | All I wanted to do is to give you the Metal3 perspective on bugfix/9.9 in IPA | 15:45 |
JayF | I'm on board to kill all jobs on bugfix 9.9 to get it landed | 15:46 |
JayF | There's still an issue with IPA stable 2023.1. I'm going to continue looking at it today but I would suggest we consider disabling tempest on that temporarily too since it keeps failing on downloading centos | 15:46 |
TheJulia | JayF: I just pushed a patch up for that | 15:47 |
JayF | But I'm going to take one more swing at looking to see if there's a fix from ironic I can cherry pick over to IPA | 15:47 |
JayF | Awesome thank you very much | 15:47 |
JayF | That patch doesn't appear to be disabling more than mine did? | 15:47 |
JayF | Even that one job you still have enabled was failing on that patch that still labeled disable the examples job | 15:47 |
TheJulia | I didn't see another patch on ipa 2023.1 | 15:48 |
JayF | It's listed as a merge conflict against your patch right now if you want to quick link I'll grab it for you too | 15:48 |
JayF | https://review.opendev.org/c/openstack/ironic-python-agent/+/928014 | 15:48 |
TheJulia | I commented out the dib build job | 15:49 |
TheJulia | in mine | 15:50 |
TheJulia | because the URL has changed and at this point we're going to spend way more time trying to get that working than makes sense | 15:50 |
JayF | Okay, at first glance I thought you had disabled the same job I did | 15:50 |
JayF | I'm a little frustrated because I've thrown a lot of different things at that and it's perplexing to me why it's broken on IPA but not ironic | 15:50 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent bugfix/9.9: CI: Disable bugfix/9.9 testing https://review.opendev.org/c/openstack/ironic-python-agent/+/928455 | 15:51 |
TheJulia | I *suspect* we forced the generic jobs over to tinycore a while back on the ironic jobs | 15:52 |
JayF | Yeah that was the kind of patch I was going to look for to cherry pick over | 15:52 |
JayF | Honestly I don't feel that bad if we have to bypass CI on that Branch given that I know it was tested manually | 15:52 |
JayF | And I think it gets unmaintained in what, 3 months? | 15:53 |
dtantsur | if you mean 9.9, 1 month ago? | 15:53 |
JayF | I mean stable/2023.1 IPA | 15:54 |
dtantsur | estimated 2024-10-30 | 15:54 |
dtantsur | 15:54 | |
JayF | To be clear, I did not test any of the bugfix IPA patches in Dev stack | 15:54 |
JayF | Yeah, that's what I figured, about a month or so after our next release | 15:54 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent bugfix/9.9: CI: Disable bugfix/9.9 testing https://review.opendev.org/c/openstack/ironic-python-agent/+/928455 | 15:57 |
TheJulia | I think I need to have *something* in the list | 15:58 |
clarkb | at the very least you'll need noop jobs in check and gate so that things can be merged | 15:58 |
TheJulia | clarkb: do you have an example job name? | 15:59 |
dtantsur | IMO if you don't even run unit tests, it's worse than removing the branch | 15:59 |
TheJulia | or is it literal "noop" ? | 15:59 |
dtantsur | it's a disservice to whoever is trying to consume it | 15:59 |
TheJulia | for bugfix/9.9, there is no way | 15:59 |
clarkb | TheJulia: it is literally `noop` it is a built in zuul return success immediately function for these situations | 16:00 |
dtantsur | then close it and move on | 16:00 |
TheJulia | requirements are toast, we could spend days on this | 16:00 |
clarkb | just use that as the job name in both check and gate and I think you'll be good | 16:00 |
JayF | thanks :) | 16:00 |
TheJulia | thanks | 16:01 |
JayF | cardoe: fwiw things like our PTG etherpad are usually indexed on the Ironic whiteboard, linked from /topic | 16:01 |
JayF | cardoe: don't assume all info in there is up to date, but it usually has links out to useful stuff | 16:01 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent bugfix/9.9: CI: Disable bugfix/9.9 testing https://review.opendev.org/c/openstack/ironic-python-agent/+/928455 | 16:02 |
TheJulia | okay, lets see how zuul likes this | 16:02 |
TheJulia | welp... templates didn't apply | 16:04 |
JayF | honestly maybe just add pep8? | 16:15 |
JayF | we know that passes and it might be the easiest solution | 16:16 |
* JayF would do it but doesn't want to cross streams | 16:16 | |
dtantsur | and gives you at least protection against things like missing imports | 16:16 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent bugfix/9.9: CI: Disable bugfix/9.9 testing https://review.opendev.org/c/openstack/ironic-python-agent/+/928455 | 16:19 |
TheJulia | The template did apply | 16:19 |
TheJulia | fwiw | 16:19 |
TheJulia | so the vmeida job, I think worked in a past run. I'm guessing we're just getting different resonses from mirrors? | 16:22 |
TheJulia | *shrug* | 16:22 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent stable/2023.1: CI: Dial back CI jobs for 2023.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/928453 | 16:25 |
JayF | TheJulia: https://github.com/openstack/ironic/commit/86358c89e80cb2d078d1aef705cb1609e22da5bb do we maybe need this? | 16:27 |
JayF | (in ipa) | 16:27 |
JayF | I am +1 to that recent patch anyway | 16:27 |
TheJulia | thoughts on just disabling the unit test: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_376/927975/4/check/openstack-tox-py36/37664f0/testr_results.html ? | 16:28 |
JayF | yes | 16:28 |
JayF | if you remmeber we almost considered not even putting the test module in the backports | 16:29 |
TheJulia | JayF: we're getting a 404, so it might mask it, dunno | 16:29 |
JayF | disable with prejudice | 16:29 |
JayF | TheJulia: yeah, your more aggro patch to just stop the broken tempest jobs I think is better | 16:29 |
JayF | TheJulia: although I guess we should consider if that means the new IPA ramdisks will fail in post... | 16:29 |
TheJulia | yeah, it is expected for us to dial stuff back as time goes on | 16:29 |
TheJulia | and we're bad at that :) | 16:30 |
JayF | yeah as long as ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/a966dbf3e4cc4b8fa5f3934a966235d8 : FAILURE in 4m 13s (non-voting) fails | 16:30 |
JayF | we are not going to release a new fixed IPA | 16:30 |
JayF | so merging the patch until we fix that seems useless? IDK | 16:30 |
JayF | > Task Build a DIB image failed running on host ubuntu-focal | 16:31 |
JayF | focal seems bad | 16:31 |
JayF | and the failure there is what that ironic commit fixes | 16:31 |
JayF | good | 16:31 |
* JayF applies that ironic commit | 16:32 | |
JayF | wait, we should have that, shouldn't we? | 16:32 |
JayF | hmmm | 16:32 |
JayF | oh, it's not a devstack job I bet | 16:32 |
TheJulia | yeah, focal is bad | 16:33 |
JayF | we should also check and verify we built new ramdisks for other IPA branches | 16:33 |
JayF | I'll do that after I get down this 2023.1 rabbithole | 16:33 |
JayF | I can nearly guarantee they aren't since this bug needed fixing in IPA-B to fix those jobs :( | 16:35 |
TheJulia | ugh | 16:35 |
JayF | and it's all in ansible :( | 16:36 |
JayF | ooh, I wonder if getting off focal fixes this entirely | 16:37 |
JayF | since it might punt that XML problem | 16:38 |
TheJulia | my revised ironic job dialback for yoga https://review.opendev.org/c/openstack/ironic/+/928296 | 16:40 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/2023.1: DNM: Science https://review.opendev.org/c/openstack/ironic-python-agent/+/928457 | 16:41 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/2023.1: DNM: Science https://review.opendev.org/c/openstack/ironic-python-agent/+/928457 | 16:42 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/2023.1: DNM: Science https://review.opendev.org/c/openstack/ironic-python-agent/+/928457 | 16:44 |
* JayF wishes we never split out ipa-b :( | 16:52 | |
JayF | I think my science is working though | 16:52 |
JayF | https://zuul.opendev.org/t/openstack/stream/10682d7872cd419b9092db35631977e5?logfile=console.log | 16:52 |
JayF | just changing the nodeset in IPA is enough | 16:52 |
JayF | and all other IPA stable branches got ramdisks posted | 16:56 |
JayF | hooray | 16:56 |
JayF | I'm going to stack a change on top of your dial back CI jobs change to do the removal of the examples job and fix the build | 16:56 |
JayF | then we might be in business | 16:56 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/2023.1: [stable-only] Multiple job fixes https://review.opendev.org/c/openstack/ironic-python-agent/+/928014 | 17:02 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/2023.1: Inspect non-raw images for safety https://review.opendev.org/c/openstack/ironic-python-agent/+/927979 | 17:02 |
* JayF crosses fingers | 17:02 | |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/2023.1: [stable-only] Multiple job fixes https://review.opendev.org/c/openstack/ironic-python-agent/+/928014 | 17:05 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/2023.1: Inspect non-raw images for safety https://review.opendev.org/c/openstack/ironic-python-agent/+/927979 | 17:05 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Migrate to oslo.utils-based format_inspector https://review.opendev.org/c/openstack/ironic-python-agent/+/928463 | 17:33 |
JayF | The changes to how format_inspector in oslo utils work is minimal, thankfully :) | 17:34 |
TheJulia | that is good | 17:45 |
* TheJulia is ready for weekend() | 17:45 | |
JayF | can you re-vote on the other two IPA stable/2023.1 patches attached to yours (^^^ those)? | 17:47 |
JayF | I think they'll all land at this point if approved | 17:47 |
TheJulia | https://review.opendev.org/c/openstack/ironic/+/927975 could use a review vote, the CI fix patch is not stacked with it and also running now | 17:49 |
JayF | +2 and I'll explicitly say here I'm very OK with you workflowing it once the CI is happy | 17:52 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Cleanup usage of imported-from-ironic-lib disk_utils https://review.opendev.org/c/openstack/ironic-python-agent/+/928465 | 18:09 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Use populate_image for all calls to write images https://review.opendev.org/c/openstack/ironic-python-agent/+/928466 | 18:09 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Cleanup usage of imported-from-ironic-lib disk_utils https://review.opendev.org/c/openstack/ironic-python-agent/+/928466 | 18:10 |
TheJulia | JayF: looks like the only thing blocking us on https://review.opendev.org/q/I7fac5c64f89aec39e9755f0930ee47ff8f7aed47 is just yoga right now. Looks like we're going to have to recheck it once it fails | 19:02 |
JayF | do you need me to +A anything r/n? | 19:03 |
TheJulia | nah, just +2 stuff if you could unless we just don't care about merge ordering :) | 19:03 |
JayF | +2A and recheck on yoga | 19:04 |
TheJulia | errrr | 19:04 |
TheJulia | the fix for yoga ci hasn't merged yet | 19:04 |
JayF | OH | 19:04 |
TheJulia | yeah | 19:04 |
TheJulia | no worries | 19:04 |
JayF | if only you had said that like, an hour ago <.< >.> (you did lolsob) | 19:04 |
TheJulia | lol | 19:04 |
TheJulia | it happens | 19:05 |
JayF | I anticipate I'm going to ride off into the sunset in the next hour-90m and make up the time this weekend, so if there's anything I need to keep an eye on other than approving those as they pop in, lmk | 19:10 |
TheJulia | I'm pretty much in the darkness of sthe sunset now | 19:10 |
* TheJulia rechecks the yoga ci change | 19:11 | |
JayF | yeah, I think I'm going to go walk over to my desktop and record my "Ironic security alert" vid then head in that direction :) | 19:13 |
JayF | I also have a deck about it, you all are welcome to use it if you need to explain what's up to anyone management-y https://docs.google.com/presentation/d/1dW8ShIgcE5GPP9rk4EBh8VxPHOFSCV_zusRRY_1SIqQ/edit?usp=sharing | 19:14 |
opendevreview | Merged openstack/ironic-python-agent stable/2023.1: CI: Dial back CI jobs for 2023.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/928453 | 19:17 |
opendevreview | Merged openstack/ironic-python-agent stable/2023.1: [stable-only] Multiple job fixes https://review.opendev.org/c/openstack/ironic-python-agent/+/928014 | 19:47 |
opendevreview | Merged openstack/ironic-python-agent stable/2023.1: Inspect non-raw images for safety https://review.opendev.org/c/openstack/ironic-python-agent/+/927979 | 19:47 |
JayF | hoorah | 19:47 |
cardoe | mnaser: why is OSH so weird sometimes!? | 20:22 |
JayF | https://review.opendev.org/c/openstack/ironic-python-agent/+/927985 and it's cherry-picked friends have been updated. We should land 'em but it's not extremely urgent given we've put in every notice these aren't getting patched and I'm skeptical anyone reads README files ;) | 21:39 |
TheJulia | https://review.opendev.org/q/I7fac5c64f89aec39e9755f0930ee47ff8f7aed47 yoga is on it's way | 22:44 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!