| cardoe | milad: not sure I understand what you are looking for. | 00:41 |
|---|---|---|
| cardoe | Is there a filter in gerrit for +2/+1 changes that just need workflow for all the ironic owned projects? | 00:42 |
| JayF | we have so many repos you can't do it with a single query | 01:42 |
| JayF | https://opendev.org/x/gerrit-dash-creator I think this still works | 01:43 |
| opendevreview | Kaifeng Wang proposed openstack/python-ironicclient master: Fix detailed node history list https://review.opendev.org/c/openstack/python-ironicclient/+/928495 | 03:09 |
| dtantsur | TheJulia, JayF, thoughts about scaling back inspector jobs on ironic-tempest-plugin? | 12:03 |
| TheJulia | no objections on my end | 13:04 |
| TheJulia | JayF: looks like we still need to do the needful w/r/t ironic-lib | 13:18 |
| dtantsur | TheJulia: may I update your https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/928284 ? it's failing the CI again anyway :( | 13:39 |
| TheJulia | dtantsur: go right ahead | 13:40 |
| * TheJulia has no idea what change that is right now | 13:40 | |
| dtantsur | dropping scope enforced jobs | 13:40 |
| TheJulia | ahh | 13:40 |
| dtantsur | so dropping more jobs in the same change makes certain sense | 13:40 |
| dtantsur | TheJulia: do you remember if anaconda jobs were supposed to be voting? They're voting in the check queue but not in the gate. | 13:42 |
| TheJulia | ideally yes | 13:43 |
| TheJulia | we've let too much stuff bit rot in the non-voting state | 13:43 |
| dtantsur | okay, I'll fix that | 13:43 |
| TheJulia | I think it might not be because it is a *long* job, but it might have in the past | 13:44 |
| dtantsur | TheJulia: the problem is: we need to either make it non-voting OR add it to the gate | 13:44 |
| TheJulia | there was a time it was broken due to another bugfix and we didn't catch it until later | 13:44 |
| dtantsur | the current state of things is invalid | 13:44 |
| TheJulia | I'm not going to get into this discussion this morning | 13:45 |
| dtantsur | voting it is | 13:45 |
| cardoe | JayF: I was just asking cause I was wondering if it would be helpful to have a "reviewed by core folks and passing CI so now needs a workflow review" | 13:49 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-tempest-plugin master: CI: scale back the number of inspector and scope enforced jobs https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/928284 | 13:51 |
| dtantsur | here goes ^^^ | 13:51 |
| masghar | So when triaging bugs, if there is a fix in progress and it looks like a valid bug, one can go ahead and mark it triaged, right? | 14:05 |
| masghar | And you do this by changing the status field? But it feels backwards to make it go from In Progress to Triaged | 14:06 |
| dtantsur | In Progress status should be left alone, only New/Confirmed get changed | 14:07 |
| masghar | Alright | 14:07 |
| cardoe | "project:openstack/$REPO (status:reviewed AND -status:merged AND -is:abandoned)" is what I've been using | 14:48 |
| * TheJulia yawns | 15:01 | |
| masghar | Do we have the meeting today? | 15:02 |
| TheJulia | I'm wondering the same thing | 15:02 |
| TheJulia | Do we remember who was going to run it? | 15:02 |
| * dtantsur blank memory | 15:03 | |
| TheJulia | #startmeeting ironic | 15:03 |
| opendevmeet | Meeting started Mon Sep 9 15:03:10 2024 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:03 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:03 |
| opendevmeet | The meeting name has been set to 'ironic' | 15:03 |
| TheJulia | o/ | 15:03 |
| TheJulia | This is easy :) | 15:03 |
| dtantsur | o/ | 15:03 |
| masghar | o/ | 15:03 |
| TheJulia | Looking at our agenda, it is not updated for this week | 15:04 |
| TheJulia | https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_August_26.2C_2024 | 15:04 |
| TheJulia | #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_August_26.2C_2024 | 15:04 |
| TheJulia | I think the tl;dr is we're close to release week | 15:04 |
| TheJulia | We also seem to be really lacking quorum | 15:04 |
| dtantsur | I think rpittau mentioned he would be back right before the time comes | 15:04 |
| dtantsur | yeahh | 15:04 |
| TheJulia | So is there anything to discuss which does not require quorum ? | 15:04 |
| cardoe | Any high priority items for the release? | 15:05 |
| cardoe | I know openstacksdk hasn't gotten the runbooks merge yet. | 15:05 |
| cardoe | There's some release note updates for Ironic | 15:05 |
| cardoe | But those are all outside of this group's control. | 15:05 |
| TheJulia | At this point, it is too late to merge it into the sdk | 15:05 |
| TheJulia | sine that would have been 5-6 weeks ago by library schedule | 15:05 |
| TheJulia | I don't *think* we really have any high priority items aside from last week's CVE | 15:06 |
| * TheJulia would like the last two months back now | 15:06 | |
| masghar | 2 months :O | 15:06 |
| TheJulia | Yeah... | 15:06 |
| TheJulia | It has not been a fun few months | 15:07 |
| cardoe | I've got a pile of patches waiting for the workflow eye | 15:07 |
| TheJulia | cardoe: list them out. I can't promise to look at them today, the wife wants me to go to the doctor | 15:07 |
| dtantsur | I'm still dealing with the downstream fallout of the CVE, and 2 more core reviewers from my team are out | 15:07 |
| cardoe | https://review.opendev.org/c/openstack/ironic/+/919779 https://review.opendev.org/c/openstack/ironic/+/928106 https://review.opendev.org/c/openstack/ironic/+/927828 | 15:07 |
| dtantsur | TheJulia: doctor comes first, I hope everything turns out fine! | 15:08 |
| cardoe | btw they're not my patches they're just a list I've compiled from the various repos. | 15:08 |
| TheJulia | yeah, I still have some downstream stuffs to do as well | 15:08 |
| TheJulia | blarg | 15:08 |
| cardoe | https://review.opendev.org/c/openstack/ironic-python-agent/+/926973 https://review.opendev.org/c/openstack/ironic-python-agent/+/926546 | 15:08 |
| cardoe | https://review.opendev.org/c/openstack/sushy/+/927444 https://review.opendev.org/c/openstack/sushy/+/927670 | 15:09 |
| cardoe | Those are the 3 repos I've been watching. I'm gonna try to craft a dashboard from what Jay linked to make it easier for folks. | 15:09 |
| cardoe | Bunch of old merge conflict ones I wanna mark as abandoned if possible. | 15:10 |
| dtantsur | eh, most of them already +2'ed by me | 15:10 |
| TheJulia | cool | 15:11 |
| TheJulia | merge conflicts as in stuff just abandoned? or just stuff which *really* just needs a rebasing? | 15:12 |
| cardoe | Mostly abandoned. But I’m just going through it while I’m totally listening on a Zoom call. | 15:12 |
| TheJulia | heh | 15:13 |
| TheJulia | okay | 15:13 |
| cardoe | Some doc ones seemed applicable and I’ve pinged the author on them. | 15:13 |
| TheJulia | I guess we should get multiple eyes unless they are pointless patches | 15:13 |
| TheJulia | ++ | 15:13 |
| cardoe | I posted the filter I’ve been using above. | 15:13 |
| TheJulia | cool, well then is there anything else today? | 15:14 |
| masghar | The bug dashboard looks all clear today | 15:15 |
| masghar | Nothing untriaged | 15:15 |
| masghar | (atleast no untriaged bugs for September) | 15:16 |
| TheJulia | Excellent, Thanks! | 15:16 |
| TheJulia | Well, if there is nothing else we can wrap our semi-informal quorum-less meeting :) | 15:16 |
| TheJulia | #endmeeting | 15:18 |
| opendevmeet | Meeting ended Mon Sep 9 15:18:25 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:18 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-09-09-15.03.html | 15:18 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-09-09-15.03.txt | 15:18 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-09-09-15.03.log.html | 15:18 |
| opendevreview | Verification of a change to openstack/sushy master failed: fix spelling and make codespell pass https://review.opendev.org/c/openstack/sushy/+/927444 | 15:53 |
| opendevreview | Merged openstack/sushy master: EthernetInterface without an Id https://review.opendev.org/c/openstack/sushy/+/927670 | 16:18 |
| opendevreview | Merged openstack/ironic-python-agent master: Check for the existence of an IPMI device https://review.opendev.org/c/openstack/ironic-python-agent/+/926973 | 16:44 |
| opendevreview | Merged openstack/ironic-python-agent master: [doc] Clarify Step return values https://review.opendev.org/c/openstack/ironic-python-agent/+/926546 | 16:44 |
| rmart04 | Hi All. We recently merged the CVE2024-44982 code and we are having some issues with checksums after image conversion. Anyone familiar? | 18:39 |
| TheJulia | Greetings, unfortunately yes. What exactly is your issue? | 18:40 |
| TheJulia | Also, what options are you using for image_download_source and force_raw ? | 18:42 |
| rmart04 | :) Excellent! We have noticed during builds that the conductor pulls the image down, converts it, feeds it to the ipa as RAW rather than QCOW2, and the IPA shows a checksum mismatch, we are using force_raw: false, and image_download_source not set, I think the default is local? | 18:45 |
| TheJulia | So the default should be http not local for image_download_source. Local implies download and convert. | 18:51 |
| TheJulia | Hmm I guess there is an edge case there. Could you file a bug in launchpad and I can look at it in the next day or two. Changing image_download_source to http should fix you right up. | 18:52 |
| TheJulia | Image_download_source of http implies just cache it locally | 18:55 |
| rmart04 | Ah OK you are right, the default is http after all. Yes the image is being pulled and cached, but it is not what the IPA is expecting in terms of checksum as it's RAW instead of QCOW | 19:03 |
| TheJulia | Sounds like you’re somehow running with local? Is it being asserted on the node level? | 19:05 |
| TheJulia | it can be set in driver_info, and instance_info for a node. instance_info of course gets wiped | 19:22 |
| rmart04 | thanks ill review those | 19:28 |
| TheJulia | rmart04: stepping away to get some lunch while waiting for the pharmacy to reopen, I'll check-in a little later. | 19:29 |
| rmart04 | BTW We are still on Xena, this was a backport, we don't have IPA side though, could be why? | 19:29 |
| TheJulia | rmart04: did you pull the patch from the bug or the patch off what merged into gerrit? | 19:32 |
| TheJulia | We didnt do the ipa side specifically due to regression risk, the logic is a little different with the named releases | 19:35 |
| TheJulia | Ironic always downloads the artifact, there was a spacing offset in the logic that we did notice only once we hit code review which we didn’t pickup when we were testing the fix | 19:35 |
| rmart04 | Yeah we pulled the merged version from gerrit | 19:39 |
| TheJulia | Okay, sigh, I know where to look the | 19:39 |
| TheJulia | Then. Please file something into launchpad and I’ll take a look hopefully later this afternoon. I think I know where this is going sideways. | 19:42 |
| rmart04 | Thanks Julia | 19:45 |
| cardoe | dtantsur: poke on https://review.opendev.org/c/openstack/ironic/+/891505 | 19:49 |
| JayF | TheJulia: I just received a report of almost an identical situation. I don't have all the same information but the shape appears to be the same | 20:10 |
| JayF | ... And I just realized that it is the identical situation 😅 | 20:16 |
| opendevreview | Verification of a change to openstack/ironic master failed: Remove default override for RBAC config options https://review.opendev.org/c/openstack/ironic/+/928283 | 20:18 |
| cardoe | Can I add depends on other people’s patches? Like that default RBAC I think depends on another change we have in the pipeline. | 20:21 |
| stevebaker[m] | cardoe: not on the same project, they have to be moved into the same series of changes | 20:22 |
| cardoe | Ah. Bummer. I’m just trying help go through the patch backlog. | 20:23 |
| clarkb | stevebaker[m]: you can actually depends on in the same project | 20:23 |
| stevebaker[m] | oh! cool | 20:24 |
| cardoe | Like I think https://review.opendev.org/c/openstack/ironic/+/928106 needs to land before the default RBAC | 20:24 |
| clarkb | its less useful for gerrit because you can stack changes, but it is a critical feature in zuul for github support because github doesn't understand you might want to stack PRs | 20:24 |
| cardoe | I can stack others? Basically wanting to triage patches for you all. | 20:25 |
| clarkb | I would only change the git commit order if people are aware of it otherwise things my get weird if they need to push updates to fix bugs or rebase to address conflicts. But depends-on will work just fine | 20:26 |
| cardoe | Ah I don’t wanna change their commit. | 20:27 |
| TheJulia | JayF: I bet this all goes back to that last minute logic change | 20:27 |
| cardoe | I’ll just leave comments. | 20:27 |
| TheJulia | cardoe: sometimes that is the best thing, if they are not responsive | 20:28 |
| TheJulia | Or just to busy | 20:28 |
| TheJulia | Fwiw, for any of my changes, it is acceptable to me for folks to come in and revise them. All I ask is a heads up. | 20:29 |
| JayF | TheJulia: it sounds like this is unconditionally converting to raw | 20:36 |
| JayF | TheJulia: even with the force-inspect option set to False | 20:36 |
| TheJulia | Defaults to true for the inspection those older branches | 20:37 |
| JayF | basically on disk we're seeing images that *were* qcow2 now showing up as raw, regardless of [conductor]conductor_always_validates_images | 20:37 |
| JayF | we've tested it in both configuration setttings | 20:37 |
| opendevreview | Merged openstack/sushy master: fix spelling and make codespell pass https://review.opendev.org/c/openstack/sushy/+/927444 | 20:38 |
| TheJulia | On what based version? | 20:38 |
| JayF | https://github.com/openstack/ironic/commit/1fa22f7db218733d3317405b3673d01f7965f1c8#diff-8b456263d6afeaacf8e2fd6801d5628d73c81e13c66ce182f6ac7ba54ac7097aR418 | 20:39 |
| JayF | xena | 20:39 |
| JayF | I'm pretty sure that unconditionally converts to raw | 20:40 |
| JayF | well that's in image_to_raw, no crap it does | 20:41 |
| TheJulia | Ugh, yeah, that would do it too | 20:41 |
| JayF | https://github.com/openstack/ironic/commit/1fa22f7db218733d3317405b3673d01f7965f1c8#diff-b14998ac7b85505afc5a8616eaf21f99279134729b02d45bf0ea2065f7b917d5R352 seems curious too | 20:41 |
| JayF | I'll get a xena devstack spun up tomorrow and try to reproduce it | 20:43 |
| TheJulia | Okay, I’m waiting for the pharmacy to fill a med my insurance rejected :( | 20:43 |
| JayF | yeah, I was similarly waylaid at medical stuff this morning | 20:44 |
| TheJulia | I likely won’t have spoons by the time I get home. | 20:44 |
| JayF | Tomorrow I'll get it reproduced in devstack and we'll find the issue | 20:45 |
| TheJulia | okay, yeah, somehow I missed a minor patch delta between them after zed | 21:20 |
| TheJulia | since re-cherry-picking was out of the question | 21:20 |
| TheJulia | https://review.opendev.org/c/openstack/ironic/+/928709 should fix it up | 21:34 |
| TheJulia | I don't have that version of python on my desktop at the moment, so I'll just have to trust test results | 21:35 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!