| cardoe | JayF: you make me laugh. sushy’s style | 00:22 |
|---|---|---|
| rpittau | good morning ironic! o/ | 08:00 |
| opendevreview | Merged openstack/tenks master: Bump minimum Python and Ansible versions https://review.opendev.org/c/openstack/tenks/+/921620 | 09:07 |
| cid | Hey, welcome back, rpittau , \o/ | 09:13 |
| rpittau | thanks cid :) | 09:57 |
| opendevreview | Will Szumski proposed openstack/bifrost master: Fix checksum parsing for Rocky Linux https://review.opendev.org/c/openstack/bifrost/+/929753 | 10:09 |
| opendevreview | Merged openstack/ironic-inspector master: Imported Translations from Zanata https://review.opendev.org/c/openstack/ironic-inspector/+/927701 | 10:28 |
| opendevreview | Verification of a change to openstack/ironic stable/2023.2 failed: [CI][stable only] fix zuul config https://review.opendev.org/c/openstack/ironic/+/926637 | 10:59 |
| rpittau | I'm still dealing with tons of messages/mails, but I realized that we're close to final release week \o/ | 11:22 |
| rpittau | looking at the changes left I think we can wait for the final release for ironic-inspector too, even if the latest release is more than 2 months old | 11:22 |
| rpittau | actually looking a the list again there are a couple of changes that we may want to add now, I'll propose a release | 11:26 |
| dtantsur | folks, https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/928284 reduces the CI load on ironic-tempest-plugin quite a bit, could you check it? | 11:32 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: Trivial: fix variable in formatting https://review.opendev.org/c/openstack/ironic-python-agent/+/929766 | 11:35 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: Add support for Ubuntu 24.04 https://review.opendev.org/c/openstack/bifrost/+/928895 | 11:40 |
| dtantsur | I think we should land ^^^ before the final release | 11:42 |
| dtantsur | we're a bit overdue with 24.04 support since it's 24.09 now :) | 11:45 |
| rpittau | dtantsur: I think ubuntu noble support is planned for epoxy | 12:08 |
| dtantsur | OpenStack-wide probably, but Bifrost is on a faster cadence than OpenStack | 12:10 |
| dtantsur | somebody can try to install it on 24.04 already, while the current version of OpenStack won't hit any productions until next year (at best) :) | 12:11 |
| rpittau | right, well LGTM :) | 12:15 |
| dtantsur | mmm, the vmedia job fails? interesting | 12:26 |
| dtantsur | error: can't find command `linuxefi' | 12:26 |
| *** mnasiadka1 is now known as mnasiadka | 12:28 | |
| dtantsur | is it time we stop using linuxefi at all? | 12:32 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: Fix missed occurrence of SETUPTOOLS_USE_DISTUTILS https://review.opendev.org/c/openstack/bifrost/+/929769 | 12:34 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: Support OVMF with 4M flash storage https://review.opendev.org/c/openstack/bifrost/+/929770 | 12:36 |
| dtantsur | rpittau: I've split out the relevant fixes ^^ since I don't think I can spend time on linuxefi now.. | 12:36 |
| rpittau | ack | 12:40 |
| opendevreview | Merged openstack/ironic-lib stable/2023.1: Fix invalid UTF-8 characters in execute output https://review.opendev.org/c/openstack/ironic-lib/+/926719 | 12:49 |
| opendevreview | Merged openstack/ironic-inspector master: Don't fail if data already migrated https://review.opendev.org/c/openstack/ironic-inspector/+/924172 | 12:55 |
| opendevreview | Merged openstack/ironic stable/2023.2: [CI][stable only] fix zuul config https://review.opendev.org/c/openstack/ironic/+/926637 | 12:55 |
| opendevreview | Merged openstack/sushy master: add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/sushy/+/929693 | 13:09 |
| TheJulia | Good morning even though I've already been up for like an hour since slack started exploding at 5:04 AM | 13:10 |
| dtantsur | ouch :( | 13:11 |
| dtantsur | slack-- | 13:11 |
| TheJulia | Good conversations | 13:11 |
| JayF | dtantsur: in Gentoo that moved into a gnu-efi package recently | 13:11 |
| TheJulia | but... yeah | 13:11 |
| TheJulia | JayF: your up early too | 13:11 |
| JayF | I'm literally on my phone in a dark bedroom checking things | 13:11 |
| TheJulia | go back to bed! | 13:11 |
| dtantsur | agreed ^^^ | 13:12 |
| TheJulia | well, more like put the phone down | 13:12 |
| JayF | I tried plenty lol | 13:12 |
| TheJulia | cuddle a cat, dog, wifey | 13:12 |
| dtantsur | few things have helped my mental health as much as staring less at my phone | 13:12 |
| TheJulia | stuffed animal | 13:12 |
| TheJulia | chtulhu | 13:12 |
| TheJulia | anything which is not a phone :) | 13:12 |
| rpittau | stuffed cthulhu :) | 13:12 |
| JayF | dtantsur: I apply that in an evening direction | 13:12 |
| TheJulia | stuffed cthulhu++ | 13:12 |
| JayF | Basically I wake up and start work so I can be done asap | 13:12 |
| * TheJulia lacks stuffed cthulhus at the moment | 13:13 | |
| TheJulia | I'm sort of the same way | 13:13 |
| TheJulia | but I do it for overlap reasons | 13:13 |
| TheJulia | Then again I got scheduled for a 6 am call tomorrow | 13:14 |
| TheJulia | Fall is definitely here in SoCal wine country | 13:17 |
| TheJulia | one step away from hot apple cider and hot chocolate | 13:18 |
| dtantsur | yummy! | 13:18 |
| JayF | fall here is more about grey and wet lol | 13:20 |
| TheJulia | Where I am right now, it is very much about clouds rolling in off the ocean and their tops being like 150 feet up in the air | 13:26 |
| TheJulia | and some fog | 13:26 |
| dtantsur | romantic! | 13:27 |
| TheJulia | at my actual home, it is wind until the jetstream shifts | 13:27 |
| TheJulia | well, wind and dust | 13:27 |
| opendevreview | Merged openstack/python-ironicclient master: Fix detailed node history list https://review.opendev.org/c/openstack/python-ironicclient/+/928495 | 13:27 |
| cardoe | rpittau: does my answer make sense on https://review.opendev.org/c/openstack/sushy/+/929704 | 14:12 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: Fix: ignore resolve error while looking up node https://review.opendev.org/c/openstack/ironic-inspector/+/925326 | 14:25 |
| rpittau | cardoe: my point on pycodestyle was just about dropping it from the requirements, not dropping it entirely, do we trust the version installed by flake8 by default? we used to constrain it for compatibility reasons | 14:28 |
| cardoe | flake8 has tighter constraints than sushy did | 14:29 |
| rpittau | alright | 14:37 |
| rpittau | I'm still a bit concerned about the python versions difference between local and CI, but we can give that a try | 14:37 |
| cardoe | I don't disagree with you. That's why it's never worked for me locally. | 14:37 |
| cardoe | tox -e pep8 has always failed for me locally on sushy. | 14:37 |
| cardoe | There's a PTG item to discuss code style and pre-commit and linting. I was just putting together some changes to highlight how the tooling code work. | 14:39 |
| cardoe | We don't have to merge that change until after PTG. | 14:39 |
| opendevreview | Verification of a change to openstack/sushy master failed: switch to pre-commit for style checks https://review.opendev.org/c/openstack/sushy/+/929704 | 14:40 |
| rpittau | yeah, I was considering that, put -1 Wfor now | 14:40 |
| cardoe | I've got a patch that actually tightens the code style and pins things to target a specific Python version. | 14:40 |
| cardoe | It matches what other OpenStack projects have in their pipelines. clarkb shared it recently I think. | 14:40 |
| cardoe | But of sushy it results in every single file being touched. | 14:41 |
| opendevreview | Merged openstack/ironic-inspector master: Drop SQLALCHEMY_WARN_20 https://review.opendev.org/c/openstack/ironic-inspector/+/929533 | 14:42 |
| cardoe | I'm also not skipping stuff like the sphinx config cause those projects don't. Plus the issues with the sphinx config are from humans hand editing the config and not how sphinx-quickstart generates it. | 14:42 |
| TheJulia | Anything needing my attention after I walk Mr. Corgi before I jump into focus time for the day? | 14:46 |
| clarkb | cardoe: it was stephenfin and sean mooney discussing how other projects use precommit and linters. I was just calling out some of the pre commit behaviors that I find less than ideal to make sure we are ok with those concessions | 14:47 |
| rpittau | TheJulia: if you could check https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/928958 would be great :) | 14:47 |
| cardoe | clarkb: got a list of those? | 14:48 |
| JayF | cardoe: rpittau: if we want more consistent behavior in CI runs on things like the pep8 or docs target, I think we'll have to set a basepython. I often have to patch my tox.ini to avoid it using an unsupported newer version of python. | 14:49 |
| cardoe | I do think in the end if OpenStack as a whole wants to adopt linters and such that exist upstream and OpenStack specific style isn't in them. Either gonna work to add that style upstream or just adopt the available style. | 14:49 |
| stephenfin | cardoe: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/Q5M7RGCSSFHFIK3RA7MTSY4K6KKOECNE/#GGF3YWEKYMC7GVTGIRCIFM53YUU4TSAK | 14:49 |
| rpittau | JayF: just for the pep8 job sounds good actually | 14:49 |
| cardoe | JayF: 100% agreed. We need a base that's constant. | 14:50 |
| cardoe | JayF: but if we use ruff, we don't need that. | 14:50 |
| clarkb | the need for a git repo meta package to install things frp pypi is just silly imo and introduces extra potential failure points | 14:50 |
| clarkb | but as long as I'm not asked to debug "github failed" (which it does fairly often) I don't care too much | 14:50 |
| rpittau | JayF: if you have a moment can you please havea look at https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/928284 ? | 14:50 |
| stephenfin | cardoe: iiuc clarkb's comments were mainly around how pre-commit sources/installs things (from Git rather than PyPI) and the implications of same, as opposed to the linters themselves | 14:51 |
| stephenfin | (and yes, clarkb I do need to repond to your reply. Just been a busy week so far 0:) ) | 14:51 |
| TheJulia | rpittau: done | 14:52 |
| rpittau | TheJulia: thanks :) | 14:52 |
| clarkb | stephenfin: yup exactly, when it comes to the linters themselves I think the bset thing is the thing that introduces the least friction for reviewers during review and when writing things whatever that may be for the group of people | 14:52 |
| stephenfin | ++ | 14:52 |
| stephenfin | JayF: Do you find basepython affects linters? Personally I've always seen the issue with docs, which mainly stems from us holding back various deps in u-c | 14:53 |
| cardoe | clarkb: ++ agreed. asottile won't change anything btw. It's his way of the highway. | 14:53 |
| cardoe | stephenfin: when using pycodestyle it 100% does. | 14:53 |
| stephenfin | (Asking out of curiosity. Running Fedora 40 with py3.12 means I nearly always have to set basepython to build docs, but never anything else) | 14:54 |
| cardoe | The biggest change is when Python introduced its new AST parser. | 14:55 |
| stephenfin | cardoe: Can honestly say I've never run into that. Very interesting. Any idea why? | 14:55 |
| stephenfin | I know mypy can be version dependent also but you can (and should) configure the version it's testing again to side-step that | 14:56 |
| cardoe | You can see it on sushy today. Run tox -e pep8 with a Python 3.8 vs 3.12 | 14:56 |
| stephenfin | e.g. https://opendev.org/openstack/openstacksdk/commit/7db657a8c4e1f2f291c6aa9fb185e33ce4835085 | 14:56 |
| * stephenfin looks | 15:01 | |
| stephenfin | cardoe: Ah, that's fair. You're running into an area of the code I fixed a bug in recently, namely, Python 3.12 added new tokens for f-strings. Bumping to flake8 7.x (maybe earlier) will definitely fix things, but point taken :) | 15:04 |
| stephenfin | The bug fwiw https://github.com/PyCQA/flake8/pull/1949 From experience on that, agreed on things being way or the highway 😅 | 15:05 |
| opendevreview | Takashi Natsume proposed openstack/ironic-inspector master: Fix a wrong assertion method https://review.opendev.org/c/openstack/ironic-inspector/+/929815 | 15:08 |
| cardoe | I'm just throwing some stuff out there and seeing what folks are happy with. I ultimately want this to be stupid easy for maintainers and even easier for contributors to avoid a friction to contribution and friction to maintainers reviewing/merging. | 15:09 |
| cardoe | I was a maintainer on the Xen Project for a while. They had their own code style that they stuck to. Things were debated for years about someone needs to contribute their format to clang-format so that their style could be in there. No one wanted to work on it. They got a Summer of Code student that did it. Got it mostly there into a release. By the time it finally got over the finish line the style had slightly changed. | 15:14 |
| stephenfin | Makes sense. fwiw, in SDK deliverables we have had been using the pre-commit model described in that mail and bumping the versions often (to the point that I'll likely get a bot to do it at some point) | 15:14 |
| TheJulia | stupid easy is double++ good | 15:22 |
| TheJulia | anything which creates friction or pain == bad | 15:22 |
| * TheJulia gets away with making such broad statements for $reasons ;) | 15:24 | |
| masghar | Do we have a recommended python version for ironic master branch? | 15:36 |
| rpittau | masghar: in theory what's supported based on setup.cfg, but probably better what's actually tested in CI, so Python 3.9 (from bifrost CS9 jobs) and Python 3.10 (from ubuntu jobs) | 15:40 |
| masghar | rpittau: thanks! I have python 3.9 locally, so it should be okay | 15:42 |
| masghar | I ran tox -e py3 on master branch and got 2 failing tests, and my first thought was python version | 15:42 |
| rpittau | mmm there should be no difference in test results between py3.9 to py3.11 | 15:45 |
| rpittau | good night! o/ | 15:48 |
| masghar | alright, o/ | 15:49 |
| TheJulia | I *highly* recommend 3.11 since it gives much obvious "you have a typo" errors | 15:57 |
| clarkb | we've found it to be much quicker in some circumstances too | 15:58 |
| TheJulia | Yes, the GIL changes I beleive | 16:09 |
| TheJulia | or that might have been 3.12 | 16:09 |
| clarkb | 3.13 makes the GIL optional but is still enabled by default. but ya in general since like 3.9 they have been making small performance improvements with each release. 3.11 seemed to have the biggest impact for zuul | 16:10 |
| TheJulia | I thought the gil stuff already shipped in 3.11 or 3.12. Maybe I'm thinking the dynamic recompile stuffs | 16:13 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Add tempest tests for runbooks https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/928958 | 16:57 |
| opendevreview | Merged openstack/ironic master: Add microversion headers to root ('/') endpoint https://review.opendev.org/c/openstack/ironic/+/928491 | 16:59 |
| opendevreview | Merged openstack/ironic master: Drop SQLALCHEMY_WARN_20 https://review.opendev.org/c/openstack/ironic/+/929396 | 16:59 |
| JayF | we need to not forget release mappings this release, we often do | 17:51 |
| opendevreview | Merged openstack/ironic-inspector master: Fix: ignore resolve error while looking up node https://review.opendev.org/c/openstack/ironic-inspector/+/925326 | 17:55 |
| TheJulia | heh | 18:14 |
| TheJulia | yeah | 18:14 |
| TheJulia | https://github.com/openstack/ironic/blob/master/ironic/common/release_mappings.py#L685 https://github.com/openstack/releases/blob/master/deliverables/dalmatian/ironic.yaml#L9-L22 | 18:16 |
| TheJulia | seriously guys.... | 18:16 |
| TheJulia | seriously | 18:16 |
| JayF | I was worried about that | 18:35 |
| * JayF had a chat about how this worked with c i d and adam today so it came to mind | 18:35 | |
| TheJulia | almost have a patch | 18:35 |
| TheJulia | oh, looks like because we did 25.0 and then 26.0, we broke a test | 18:37 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Update release mappings https://review.opendev.org/c/openstack/ironic/+/929839 | 18:45 |
| TheJulia | no sense to keep the test, I guess | 18:45 |
| TheJulia | JayF: ^^ | 18:48 |
| TheJulia | added rpittau as a reviewer | 18:52 |
| JayF | yeah I pointed adamcarthur5 at that config + ironic local dev, we're trying to find a way to emulate a really, really old ironic API microversion | 19:17 |
| JayF | basically trying to ensure https://github.com/openstack-exporter/openstack-exporter/pull/378 doesn't break people who have older clouds | 19:17 |
| JayF | (and we'll be adding more metrics that make sense, and I'm sure those will get newer and newer as we go) | 19:18 |
| JayF | so I'm glad we thought about it and found this out before cutting an integrated release :D | 19:18 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: CI: scale back the number of inspector and scope enforced jobs https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/928284 | 20:15 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!