rpittau | good morning ironic! o/ | 07:05 |
---|---|---|
kubajj | good morning rpittau, and ironic! o/ | 07:55 |
opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent stable/2024.2: Warn when the provided checksum algorithm does not match the detected https://review.opendev.org/c/openstack/ironic-python-agent/+/933072 | 07:56 |
timeu | sinfo -Rl | 08:26 |
opendevreview | Will Szumski proposed openstack/bifrost master: Switches to using CentOS Stream latest https://review.opendev.org/c/openstack/bifrost/+/932173 | 10:29 |
opendevreview | cid proposed openstack/ironic master: Add support for node name in port creation https://review.opendev.org/c/openstack/ironic/+/930944 | 10:43 |
opendevreview | Merged openstack/ironic-python-agent master: Migrate to oslo.utils-based format_inspector https://review.opendev.org/c/openstack/ironic-python-agent/+/928463 | 10:43 |
opendevreview | Merged openstack/ironic-python-agent stable/2024.2: Warn when the provided checksum algorithm does not match the detected https://review.opendev.org/c/openstack/ironic-python-agent/+/933072 | 11:00 |
TheJulia | good morning | 12:36 |
rpittau | good morning TheJulia :) | 12:37 |
* TheJulia tries to wake up | 12:42 | |
* iurygregory sends coffee to TheJulia | 12:42 | |
TheJulia | I have coffee, it just doesn't seem to be working :) | 12:42 |
iurygregory | I need two mugs of coffee to start working :D | 12:43 |
* dtantsur team decaf nowadays :( | 12:43 | |
iurygregory | I use decaf at night only | 12:44 |
rpittau | 10 minutes to "Ironic Epoxy PTG - Part 3" | 12:50 |
dtantsur | Still not Friday, damn | 12:52 |
TheJulia | dtantsur: if you invent a fast forward to friday button, I'll gladly press it | 12:53 |
iurygregory | ++ | 12:54 |
JayF | Running about 5 minutes late. Feel free to start without me | 13:00 |
cardoe | Morning all. I’m running late. Something I had yesterday is not agreeing with me. | 13:13 |
opendevreview | Jay Faulkner proposed openstack/ironic master: Use patched dnsmasq from PPA https://review.opendev.org/c/openstack/ironic/+/933104 | 13:29 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent stable/2024.1: Warn when the provided checksum algorithm does not match the detected https://review.opendev.org/c/openstack/ironic-python-agent/+/933105 | 13:32 |
opendevreview | Merged openstack/sushy-tools master: Reject node power off requests to align with ironic supporting NCSI https://review.opendev.org/c/openstack/sushy-tools/+/932623 | 13:51 |
cardoe | rpittau: we should be good to land https://review.opendev.org/c/openstack/sushy/+/931321 | 14:03 |
rpittau | cardoe: once https://review.opendev.org/c/openstack/releases/+/933079 is merged | 14:04 |
cardoe | I guess it won't make the tag at the correct place if we land stuff on top? | 14:04 |
cardoe | ironic/doc/source/configuration/config.rst:3: CRITICAL: Duplicate ID: "disk_utils.image_convert_memory_limit". [docutils] | 14:10 |
cardoe | side effect of some disk_utils changes and oslo.utils? | 14:11 |
opendevreview | Doug Goldstein proposed openstack/ironic master: Enable WSGI module entrypoint for Ironic https://review.opendev.org/c/openstack/ironic/+/927635 | 14:20 |
rpittau | cardoe: I've removed the -W from https://review.opendev.org/c/openstack/sushy/+/931321 | 14:34 |
JayF | After you send the email, dtantsur, I might do a video on inspector deprecation too. Maybe try to emphasize the "wow one less service to deploy, less complexity, hell yeah" parts of it :D | 14:38 |
opendevreview | Nicholas Kuechler proposed openstack/ironic master: docs: adds link to oslo_messaging_notifications documentation https://review.opendev.org/c/openstack/ironic/+/933119 | 14:51 |
dtantsur | JayF: nice! | 14:52 |
JayF | "Operators asked us to simplify upgrading openstack: how about one less service to worry about!" | 14:52 |
JayF | if we message it right operators should be able to see the deprecation as the win it is | 14:52 |
JayF | cardoe: that's usually an indicator you're using mismatched ironic/ironic-lib versions | 14:54 |
JayF | cardoe: because we've been moving stuff around | 14:54 |
cardoe | So that's appearing in the docs runs in CI | 14:54 |
JayF | on master? | 14:55 |
JayF | https://review.opendev.org/c/openstack/ironic-lib/+/928776 I wonder if it's using a released version of ironic-lib instead of git | 14:55 |
JayF | this is the change it's missing | 14:55 |
cardoe | So I noticed it when I rebased your WSGI branch | 14:55 |
cardoe | And I rebased to master | 14:55 |
JayF | yeah this would've been caused by the CVE fix | 14:55 |
JayF | if we had an ironic-lib loaded for docs run that didn't have 928776 | 14:56 |
cardoe | man I love patches like that... all red no green | 14:56 |
JayF | like I said, 99% sure we'll find the issue is for some reason it using pypi ironic-lib | 14:56 |
JayF | all red no green is better than some cases lol | 14:56 |
opendevreview | Doug Goldstein proposed openstack/ironic master: Enable WSGI module entrypoint for Ironic https://review.opendev.org/c/openstack/ironic/+/927635 | 14:58 |
cardoe | https://zuul.opendev.org/t/openstack/build/29cc8370643a4a13a5677c007158bd9e/log/sphinx-build-pdf.log was the log btw. | 14:59 |
cardoe | There's a lot of scary easy_install stuff in there too | 14:59 |
JayF | I think the actual failure was the wsgi thing at the end | 14:59 |
JayF | not those duplicate ids | 14:59 |
JayF | but imbw | 14:59 |
JayF | I hope I'm wrong because otherwise this is gonna be no fun | 15:00 |
JayF | er, I mean, I'm not wrong | 15:00 |
iurygregory | rpittau, you have 6yrs of ironic no ? :D | 15:03 |
rpittau | well, almost :) | 15:03 |
iurygregory | next month? | 15:03 |
iurygregory | :D | 15:03 |
rpittau | yeah | 15:04 |
iurygregory | nice! | 15:04 |
rpittau | :) | 15:04 |
cardoe | JayF: oh yeah it was the wsgi stuff at the end. I just noticed it first there. I checked some other branches and it had the same warnings. | 15:14 |
cardoe | autodoc: failed to import module 'wsgi' from module 'ironic'; the module executes module level statement and it might call sys.exit(). [autodoc.import_object] | 15:15 |
JayF | either way, it's an interesting find that docs jobs use released versions of deps | 15:15 |
cardoe | Guess need to see how someone worked around that... was it nova? | 15:15 |
JayF | you can likely just configure autodoc to skip that module | 15:15 |
dtantsur | Are we back in the Ironic room? | 16:00 |
* dtantsur had a break | 16:00 | |
JayF | we're still in neutron atm | 16:00 |
JayF | but slowly coming to a close | 16:00 |
rpittau | we'll be back in ironic room in 10 minutes | 16:04 |
cardoe | JayF: if ya help me with the autodoc thing, https://review.opendev.org/c/openstack/ironic/+/927635 should be good. | 16:41 |
shermanm | not to interrupt any current conversations, but we (Chameleon) would be really interested in the serial and graphical console topics mentioned in the etherpad from yesterday | 16:57 |
iurygregory | good to know shermanm! | 16:57 |
shermanm | and I went down a similar road of trying a goconserver proof of concept for read only serial consoles | 16:58 |
shermanm | or in particular, keeping a single persistent ipmi SoL session open per server, then exposing a read-only stream to the console log, and read-write stream to the interactive console | 16:58 |
shermanm | to avoid the "only one user at a time" ipmi SoL issue | 16:59 |
JayF | We did decide to punt on *serial*/text console support due to reports of issues in the wild with interrupts for enabling serial consoles | 16:59 |
JayF | but to move forward with the graphical, VNC-based consoles typically found on redfish servers, including a top level requirement for read-only capability | 16:59 |
JayF | that's my understanding of it anyway | 17:00 |
TheJulia | That is a good high level tl;dr | 17:01 |
TheJulia | shermanm: if more discussion or revisiting is needed, please let us know and we can set aside some time during this week to discuss more | 17:01 |
TheJulia | in the man time, I think I'm going to go take a short nap | 17:01 |
JayF | also we're just generally willing to talk to you about stuff whenever | 17:01 |
TheJulia | ++ | 17:01 |
JayF | except we're all outta juice from PTG this week | 17:01 |
TheJulia | Our Battery Management Systems are causing alarms to be raised recharge | 17:02 |
TheJulia | raised to recharge | 17:02 |
shermanm | of course, I just wanted to mention while there were some eyes on the topics :) I'm unfortunately chasing like 3 other deadlines this week, so I haven't been able to engage with the PTG more | 17:03 |
JayF | we've all been there | 17:03 |
JayF | TheJulia: btw, did you see my comment on IPA metrics: we send metrics literally for *4* API calls in IPA, that's it | 17:03 |
JayF | I already have the vendoring+deprecation for IPA up | 17:04 |
TheJulia | shermanm: cool. Let’s chat next week if you have time :) | 17:11 |
TheJulia | JayF: I did not, ack | 17:11 |
* TheJulia engaged hibernation mode | 17:12 | |
iurygregory | hibernation mode ++ | 17:34 |
iurygregory | I'm going to take a nap, go to the gym, and come back to work at night | 17:34 |
JayF | same, stepping out for a long lunch then will find some other mindless patch to do (that IPA metrics one was downright relaxing) | 17:36 |
cardoe | do the docs patch for https://review.opendev.org/c/openstack/ironic/+/927635 | 18:06 |
opendevreview | Jay Faulkner proposed openstack/ironic master: Use patched dnsmasq from PPA https://review.opendev.org/c/openstack/ironic/+/933104 | 19:33 |
opendevreview | cid proposed openstack/ironic master: Fix double JSON encoding of error message https://review.opendev.org/c/openstack/ironic/+/931795 | 19:34 |
opendevreview | cid proposed openstack/ironic master: Fix double JSON encoding of error message https://review.opendev.org/c/openstack/ironic/+/931795 | 19:45 |
opendevreview | Julia Kreger proposed openstack/networking-baremetal master: WIP: prevent break on communications failure https://review.opendev.org/c/openstack/networking-baremetal/+/933149 | 19:46 |
JayF | cardoe: so the difference between ironic change and nova change is that ironic.wsgi is a top level module that executes code, in nova it's a second-level module (nova.wsgi.blah) | 19:46 |
JayF | cardoe: So nova doesn't have the problem; I suspect I can figure out how to make it not choke on the layout it's in now | 19:47 |
JayF | https://opendev.org/openstack/nova/src/branch/master/nova/wsgi note the empty __init__.py there | 19:47 |
JayF | I think if I moved ours into a module dir like that, it'd work | 19:47 |
opendevreview | Julia Kreger proposed openstack/networking-baremetal master: WIP: prevent break on communications failure https://review.opendev.org/c/openstack/networking-baremetal/+/933149 | 19:49 |
TheJulia | hjensas: so ^ got the curiosity of me | 19:49 |
TheJulia | I'm afraid the cases which make sense to fail don't really seem immediately possible in the code | 19:51 |
TheJulia | unless AttributeError was somehow surfaced | 19:51 |
cardoe | https://review.opendev.org/c/openstack/networking-baremetal/+/929650 I ran into something similar which is what prompted that patch | 19:53 |
opendevreview | Jay Faulkner proposed openstack/ironic master: Enable WSGI module entrypoint for Ironic https://review.opendev.org/c/openstack/ironic/+/927635 | 19:53 |
JayF | cardoe: ^ there ya go | 19:53 |
cardoe | TheJulia: my comment was to you. | 19:55 |
cardoe | JayF: looks good assuming it passes I'll squish my pyproject.toml bits into yours and we can land that. | 19:56 |
JayF | why together? | 19:56 |
JayF | why not land this, then land that | 19:56 |
JayF | use Depends-On to make sure CI is happy at the end of the chain | 19:56 |
JayF | smaller patches are /usually/ better IME | 19:56 |
TheJulia | cardoe: Interesting, in this case it seems like it was launched with correct config, but message bus communication was broken for long enough for things to basically have a hard break | 19:56 |
TheJulia | cardoe: and then nothing else was ever logged again | 19:57 |
TheJulia | cardoe: of course, only discovered once the logs had entirely rolled off... :\ | 19:57 |
cardoe | JayF: so I forgot you had a pyproject.toml change. yours has a relnote which is good. we both touched pyproject.toml the same way. But I touched requirements.txt as the other reviewers had asked. | 19:57 |
JayF | cardoe: you wanna smash them together into one superior version, and abandon the other one? | 19:57 |
cardoe | yes | 19:58 |
JayF | I don't care which way it goes, but I'd rather you take care of that piece as I had one other thing I wanted to knock out in my remaining time | 19:58 |
JayF | ty | 19:58 |
cardoe | and I'll set depends on | 19:58 |
cardoe | I don't need to relnote changes like https://review.opendev.org/c/openstack/ironic/+/933020 because that's just a driver_internal_info change right? | 19:58 |
JayF | does it have any operator-facing change? | 19:59 |
JayF | fix a bug? | 19:59 |
JayF | I always err on the side of a release note, but if there's nothing the operator can/should notice there's nothing to put in it :D | 19:59 |
opendevreview | Doug Goldstein proposed openstack/ironic master: add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/ironic/+/927544 | 20:01 |
cardoe | So that change is an internal refactor to dedup some code. | 20:03 |
cardoe | But it causes the code path to just share 1 driver_internal_info piece of data that it uses for tracking the step state. | 20:03 |
cardoe | If that style is okay, I was gonna dedup a few things around redfish. | 20:07 |
cardoe | Like tracking of tasks. | 20:07 |
TheJulia | Regarding the baremetal sig, any thoughts on: https://etherpad.opendev.org/p/rsuBNy15l33xVr_lZ9G_ | 20:09 |
opendevreview | Verification of a change to openstack/ironic master failed: Gracefully handle bad request exception https://review.opendev.org/c/openstack/ironic/+/931849 | 20:15 |
JayF | TheJulia: you mind minor edit suggestions just being done in that? starting with s/Baremetal/Bare Metal/ | 20:15 |
TheJulia | it was always referred to as baremetal as a single word, also verified by glancing at the etherpad | 20:16 |
TheJulia | but go right ahead | 20:16 |
JayF | oh really? | 20:16 |
TheJulia | yeah | 20:16 |
JayF | https://opendev.org/openstack/governance-sigs/src/branch/master/sigs.yaml#L52 | 20:16 |
JayF | consistently inconsistant then | 20:17 |
TheJulia | lolz | 20:17 |
TheJulia | yay | 20:17 |
TheJulia | okay | 20:17 |
JayF | I saw this file literally Monday which is why I had that spelling in mind | 20:17 |
JayF | I do not care at all if we've mixed it, it doesn't matter | 20:17 |
TheJulia | we can do 2 words | 20:17 |
TheJulia | not an issue then | 20:17 |
JayF | I realize that was ambiguous: it doesn't matter == I don't care if it's two or one word | 20:18 |
JayF | one mild suggestion, just trying to ensure it's clear the only thing going away is the structure/name | 20:20 |
JayF | and calling operators to action to come join us here/ml/etc | 20:20 |
TheJulia | good idea, I was sort of thinking the same after I dropped the link to the pad | 20:20 |
TheJulia | Suggestion accepted | 20:21 |
JayF | just a thought: Given Arne is still technically a chair, we might wanna give him a heads up at all lol | 20:23 |
TheJulia | yeah | 20:23 |
TheJulia | didn't realize it was a formally defined sig until.. well.. minutes ago | 20:24 |
* TheJulia emails him | 20:24 | |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Cleanup usage of imported-from-ironic-lib disk_utils https://review.opendev.org/c/openstack/ironic-python-agent/+/928466 | 20:33 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Remove use of ironic_lib i18n module https://review.opendev.org/c/openstack/ironic-python-agent/+/930080 | 20:33 |
opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Migrate more trivial code from ironic-lib https://review.opendev.org/c/openstack/ironic-python-agent/+/928779 | 20:33 |
JayF | dtantsur: calling your attention to this: https://review.opendev.org/c/openstack/ironic-python-agent/+/928463/4#message-26d82d96c2c1cdd6f57d9f688acee0bac73dd45a tl;dr not returning specific image failure reasons in node.last_error is an intentional security optimization | 20:34 |
TheJulia | Email to arne sent | 20:40 |
opendevreview | Julia Kreger proposed openstack/ironic master: CI: Detail job removal permission https://review.opendev.org/c/openstack/ironic/+/933151 | 20:41 |
opendevreview | Julia Kreger proposed openstack/ironic master: CI: Remove legacy metalsmith job https://review.opendev.org/c/openstack/ironic/+/933152 | 20:49 |
cardoe | JayF: that autodocs thing didn't work | 20:51 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: CI: Remove metalsmith legacy jobs https://review.opendev.org/c/openstack/ironic-python-agent/+/933153 | 20:51 |
JayF | .o(it did locally) | 20:54 |
JayF | I'm going to let CI results run, since it 100% worked for me locally | 20:55 |
opendevreview | Julia Kreger proposed openstack/metalsmith master: CI: Remove metalsmith legacy jobs https://review.opendev.org/c/openstack/metalsmith/+/933154 | 20:57 |
opendevreview | Julia Kreger proposed openstack/ironic master: CI: Change 4k block device job to use LVM https://review.opendev.org/c/openstack/ironic/+/931061 | 21:09 |
cardoe | JayF: https://zuul.opendev.org/t/openstack/build/b3325db378c74ae8b4415698c8d0cd7f/logs that's the latest run | 21:23 |
TheJulia | JayF: I looked at your dnsmasq change and it doesn't appear to be crashing anymore | 21:58 |
TheJulia | I checked the logs on the multinode job | 21:58 |
JayF | if you cedhcek and see it's happy, do a recheck if you can | 22:01 |
JayF | I wanna get several clean runs in a row b4 I report back | 22:01 |
TheJulia | done | 22:08 |
clarkb | out of curiousity does anyone know why centos 9 stream seems to be affected by the pip/wheel/project.toml behavior stuff when ubuntu noble and jammy don't appear to be? | 22:10 |
clarkb | is it a case of different versions of tools due to different versions of python? | 22:10 |
TheJulia | unfortunately I don't know of the details of this issue | 22:14 |
JayF | cardoe: there are some kinda version shenanigans afoot, I'll dig | 22:21 |
opendevreview | Verification of a change to openstack/ironic master failed: Gracefully handle bad request exception https://review.opendev.org/c/openstack/ironic/+/931849 | 22:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!