opendevreview | Steve Baker proposed openstack/ironic master: WIP Add novnc-proxy service https://review.opendev.org/c/openstack/ironic/+/939191 | 00:53 |
---|---|---|
opendevreview | Steve Baker proposed openstack/ironic master: WIP add VNC auth type to novnc-proxy https://review.opendev.org/c/openstack/ironic/+/939192 | 00:53 |
opendevreview | Steve Baker proposed openstack/ironic master: WIP create idrac graphical console driver https://review.opendev.org/c/openstack/ironic/+/939193 | 00:53 |
opendevreview | Merged openstack/ironic unmaintained/yoga: Calculate missing checksum for file:// based images https://review.opendev.org/c/openstack/ironic/+/938623 | 06:36 |
opendevreview | cid proposed openstack/ironic master: API/Testing: Inspection rules migration https://review.opendev.org/c/openstack/ironic/+/939217 | 07:20 |
opendevreview | cid proposed openstack/ironic master: Apply Rules: inspection rules migration https://review.opendev.org/c/openstack/ironic/+/939218 | 07:20 |
opendevreview | cid proposed openstack/ironic master: DB: migrate inspection rules' database https://review.opendev.org/c/openstack/ironic/+/939318 | 07:20 |
rpittau | good morning ironic! o/ | 07:45 |
*** dmellado075539377 is now known as dmellado07553937 | 08:49 | |
opendevreview | cid proposed openstack/ironic master: API/Testing: Inspection rules migration https://review.opendev.org/c/openstack/ironic/+/939217 | 10:16 |
opendevreview | cid proposed openstack/ironic master: Apply Rules: inspection rules migration https://review.opendev.org/c/openstack/ironic/+/939218 | 10:16 |
janders | TheJulia JayF I haven't used hold/unhold/noop steps. Is there any prior art on this I could tap into? Thanks in advance :) | 10:57 |
opendevreview | Jakub Jelinek proposed openstack/ironic-python-agent master: Fix RAID volume name https://review.opendev.org/c/openstack/ironic-python-agent/+/939340 | 12:41 |
rpittau | JayF: are you already working also on removing ironic-lib dep from sushy-tools ? | 13:37 |
JayF | rpittau: I will today, apparently 😂 | 14:14 |
rpittau | lol | 14:15 |
JayF | janders: https://docs.openstack.org/ironic/latest/admin/steps.html#reserved-functional-steps | 14:30 |
TheJulia | brraaaaaaainnnssss | 14:50 |
TheJulia | I guess I ought to make more coffee | 14:50 |
dtantsur | JFYI I won't have enough energy for this networking meeting (and will be out for the next one) | 14:51 |
TheJulia | dtantsur: ack, thanks | 14:59 |
TheJulia | dtantsur: anything you need raised during it? | 15:00 |
* TheJulia recommends a hot chocolate and warm blanket for mid-afternoon naps | 15:00 | |
dtantsur | TheJulia: empty brain, sorry | 15:04 |
dtantsur | I hope to have some ideas after the vacation | 15:04 |
TheJulia | meeting over | 15:16 |
TheJulia | consensus on moving to irc | 15:16 |
TheJulia | Any objection to weekly? | 15:16 |
TheJulia | (We'll need to order super glue and cover the IRC channel floor with it before the first IRC meeting!) | 15:16 |
TheJulia | rpittau: JayF ^ | 15:17 |
rpittau | I'm ok with that | 15:17 |
rpittau | also the glue :D | 15:17 |
JayF | Y'all want to have the meeting in IRC? Feel free | 15:17 |
kubajj | not meeting related, but if any of you had a minute (the change fixes one line and then makes sure the tests pass accordingly), I pushed a bug fix for a bug which I introduced in Zed 🫠https://review.opendev.org/c/openstack/ironic-python-agent/+/939340 | 15:23 |
TheJulia | o/ shermanm | 15:27 |
TheJulia | shermanm: So, we reached consensus on the call that we should move the networking meeting to be an irc meeting moving forward | 15:27 |
shermanm | happy new year and all that! slowly catching back up on things | 15:27 |
shermanm | sounds good | 15:28 |
JayF | kubajj: I suspect that will conflict with my ironic-lib removal patch, one of us will have to rebase. I'll take care of yours if mine lands and I notice o/\ | 15:37 |
kubajj | JayF: then maybe I can rebase, mine is tiny | 15:38 |
kubajj | bug-fixes are usually added back to previous branches, right? should I do that as well, once it is merged? | 15:39 |
JayF | I already marked it as backportable | 15:42 |
JayF | and you can do it or whoever lands it can, just depends on who gets around to it :) | 15:42 |
kubajj | JayF: ok, thanks :) | 15:49 |
rpittau | good night! o/ | 17:05 |
-opendevstatus- NOTICE: The paste service at paste.opendev.org will have a short (15-20) minute outage momentarily to replace the underlying server. | 17:08 | |
JayF | ironic-inspector uses ir-lib too :\ | 18:57 |
cardoe | gah I missed the networking call. and that's what I'm fighting today. :( | 22:03 |
cardoe | sorry I've been a bit MIA. I've been given a bit of a tight deadline and smack dab in the middle of the window I've got some planned PTO for a week. (end of this month) so it's even more stress to make things work. | 22:04 |
opendevreview | Steve Baker proposed openstack/ironic master: WIP Add novnc-proxy service https://review.opendev.org/c/openstack/ironic/+/939191 | 22:46 |
opendevreview | Steve Baker proposed openstack/ironic master: WIP add VNC auth type to novnc-proxy https://review.opendev.org/c/openstack/ironic/+/939192 | 22:46 |
opendevreview | Steve Baker proposed openstack/ironic master: WIP create idrac graphical console driver https://review.opendev.org/c/openstack/ironic/+/939193 | 22:46 |
TheJulia | dtantsur: do you remember the default path that configuratoin file for credientals gets housed at? specifically I think it is going to be necessary to make that part of the mvp to support ironic having some way to find/auth against container registries *as a service* and not as a user | 22:52 |
TheJulia | dtantsur: also, if you can share your example again that would be awesome because otherwise I think I need to do it from memory | 22:53 |
TheJulia | cardoe: sorry :( Hopefully the stress lets up | 22:53 |
janders | JayF I tried passing hold step, still no luck: https://paste.opendev.org/show/bJOph0AsOEMkFclqMsIb/ | 22:55 |
janders | for the sake of simplicity and user-friendliness should we aim to make this "trick" work with empty steps? | 22:56 |
JayF | that looks SUPER wrong to me | 22:56 |
JayF | like, it should work | 22:56 |
JayF | you are on new enough ironic? | 22:56 |
janders | it's metal3 stuff let me see what gets deployed | 22:56 |
JayF | I mean, that should be well into new enough then | 22:56 |
janders | I'm close to downstream master so agreed | 22:57 |
JayF | I don't know what to tell you other than it SEEMS to me like it's possible there's a bug there | 22:58 |
janders | version is 26.2.0.dev321 | 22:59 |
janders | yeah there may be something missing in servicing code | 22:59 |
janders | but having said that it feels to me like for the purpose of this requirement ("being able to get a node from service failed back to active") we just need to make sure that empty steps work | 23:00 |
JayF | is hold a service step? | 23:01 |
JayF | you might need to use pause | 23:01 |
TheJulia | it is supposed to be | 23:01 |
TheJulia | about to switch gears to looking at this | 23:02 |
* JayF is going to finish his sushy-tools change and look awy | 23:02 | |
TheJulia | so that error is getting raised by _validate_user_steps() | 23:06 |
opendevreview | Jay Faulkner proposed openstack/sushy-tools master: Import needed ironic-lib code https://review.opendev.org/c/openstack/sushy-tools/+/939400 | 23:08 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP OCI container adjacent artifact support https://review.opendev.org/c/openstack/ironic/+/937896 | 23:09 |
TheJulia | so, yeah, does look like a bug | 23:10 |
TheJulia | just... super surprising we didn't detect it nor encounter it | 23:11 |
JayF | honestly in a cursory look I was thinking the same (that we might not account for reserved steps in validation) | 23:17 |
TheJulia | yup | 23:17 |
TheJulia | that is exactly it | 23:17 |
JayF | I wonder if setting an interface at all makes a difference | 23:17 |
TheJulia | ... it might be, I'm not 100% sure | 23:18 |
JayF | it shouldn't matter per the docs, but that would be an easy difference in testing | 23:18 |
TheJulia | I apparently wrote the power stuff in early 2023 it looks like | 23:18 |
* JayF just trying to explain how we would've not encountered this yet | 23:18 | |
TheJulia | lack of use most likely | 23:18 |
TheJulia | or it was there and got shuffled in a rebase or who knows | 23:18 |
TheJulia | going to write a reno and post it | 23:19 |
JayF | shuffled up in a rebase 😅 | 23:19 |
TheJulia | I dunno, I'm flabbergasted | 23:20 |
* JayF shuffling ironic-lib code around like a deck of cards | 23:20 | |
JayF | it's basically the category of thing I'm worried the ironic-lib changes could do :) | 23:20 |
TheJulia | blah | 23:22 |
opendevreview | Julia Kreger proposed openstack/ironic master: Fix hold/wait step logic in step validation https://review.opendev.org/c/openstack/ironic/+/939401 | 23:22 |
TheJulia | JayF: regarding container image stuffs | 23:22 |
TheJulia | I'm likely going to have to develop support to read from an authenticated endpoint out of the gate, so if you have opinions to apply there, please note them. I think the format dmitry proposed was actually what the container libraries use, which I think its a list key'ed by domain name. | 23:23 |
TheJulia | janders: above is a patch, if that doesn't make everything right as rain, please let me know | 23:24 |
JayF | I honestly don't know what that looks like, technologically, in the conatiner world | 23:25 |
JayF | but it makes more sense to me it's more than a token :) | 23:26 |
TheJulia | here is the scary bit | 23:26 |
TheJulia | if you authenticate with it, because in that world, you use your token and you send along auth with the "password" as the token | 23:26 |
TheJulia | it sends it back as the bearer! | 23:27 |
TheJulia | the email value dmitry had is just for humans to go "where did this come from" | 23:27 |
JayF | so I have to send two secrets to authenticate, and it sends one of them back?! | 23:30 |
opendevreview | Steve Baker proposed openstack/ironic master: WIP devstack start ironic-novnc-proxy as ir-novnc https://review.opendev.org/c/openstack/ironic/+/939402 | 23:44 |
TheJulia | JayF: one, a pre-shared token | 23:54 |
JayF | and that gets sent back? | 23:55 |
TheJulia | JayF: it that gets re-used as the bearer token | 23:55 |
TheJulia | yeah | 23:55 |
JayF | someone looked at WEP | 23:55 |
JayF | went "looks good for a container registry" | 23:55 |
TheJulia | lol | 23:55 |
TheJulia | Way better than IPMI | 23:55 |
TheJulia | Clippy appears an says "I hear you sent the wrong password... have you considered $PASSWORD" | 23:56 |
TheJulia | JayF: found the example dmitry shared | 23:58 |
TheJulia | https://paste.opendev.org/show/b7amWp4OqDggCvwsy5QY/ | 23:58 |
JayF | hahahahahahahaTHUD | 23:59 |
JayF | I'm so glad everyone is using the "better" container ecosystem | 23:59 |
JayF | It's much better than the [checks notes] full RBAC support provided by Glance | 23:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!