| opendevreview | Takashi Kajinami proposed openstack/networking-generic-switch master: Update project URL https://review.opendev.org/c/openstack/networking-generic-switch/+/953359 | 01:07 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove Python 3.9 support https://review.opendev.org/c/openstack/ironic/+/953360 | 01:12 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-inspector master: Remove Python 3.9 support https://review.opendev.org/c/openstack/ironic-inspector/+/953361 | 01:12 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-ui master: Remove Python 3.9 support https://review.opendev.org/c/openstack/ironic-ui/+/953362 | 01:13 |
| opendevreview | Takashi Kajinami proposed openstack/python-ironicclient master: Remove Python 3.9 support https://review.opendev.org/c/openstack/python-ironicclient/+/953363 | 01:13 |
| opendevreview | Takashi Kajinami proposed openstack/python-ironic-inspector-client master: Remove Python 3.9 support https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/953364 | 01:14 |
| opendevreview | Takashi Kajinami proposed openstack/networking-generic-switch master: Remove Python 3.9 support https://review.opendev.org/c/openstack/networking-generic-switch/+/953365 | 01:14 |
| opendevreview | Takashi Kajinami proposed openstack/networking-baremetal master: Remove Python 3.9 support https://review.opendev.org/c/openstack/networking-baremetal/+/953366 | 01:15 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove Python 3.9 support https://review.opendev.org/c/openstack/ironic/+/953360 | 02:12 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-inspector master: Remove Python 3.9 support https://review.opendev.org/c/openstack/ironic-inspector/+/953361 | 02:13 |
| opendevreview | Takashi Kajinami proposed openstack/networking-generic-switch master: Remove Python 3.9 support https://review.opendev.org/c/openstack/networking-generic-switch/+/953365 | 02:15 |
| opendevreview | Takashi Kajinami proposed openstack/python-ironic-inspector-client master: Remove Python 3.9 support https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/953364 | 02:15 |
| opendevreview | Takashi Kajinami proposed openstack/python-ironicclient master: Remove Python 3.9 support https://review.opendev.org/c/openstack/python-ironicclient/+/953363 | 02:15 |
| opendevreview | Takashi Kajinami proposed openstack/networking-baremetal master: Remove Python 3.9 support https://review.opendev.org/c/openstack/networking-baremetal/+/953366 | 02:15 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-ui master: Remove Python 3.9 support https://review.opendev.org/c/openstack/ironic-ui/+/953362 | 02:24 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Redfish Firmware Interface - NIC Support https://review.opendev.org/c/openstack/ironic/+/953394 | 03:06 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Fix Sensor Data values https://review.opendev.org/c/openstack/ironic/+/953395 | 04:20 |
| rpittau | good morning ironic! o/ | 06:43 |
| rpittau | congrats dtantsur, iurygregory and janders :) | 06:44 |
| rpittau | tkajinam: thanks for them, but all the py3.9 removal patches will have to wait :) | 06:45 |
| queensly[m] | Good morning | 06:48 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Build ironic-python-agent DIB image with CentOS Stream 10 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/950965 | 07:08 |
| tkajinam | rpittau, ok. in case you want me to abandon these now then lmk | 07:33 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove rootwrap https://review.opendev.org/c/openstack/ironic/+/953404 | 07:50 |
| rpittau | tkajinam: no need to abandon them, we'll just have to wait a little :) | 07:52 |
| tkajinam | rpittau, ack. ok ! | 07:52 |
| Continuity | TheJulia: yes koala | 08:17 |
| opendevreview | Abhishek Bongale proposed openstack/ironic master: fix: handle unexpected 'loop' in actions field https://review.opendev.org/c/openstack/ironic/+/953323 | 08:43 |
| opendevreview | Syed Haseeb Ahmed proposed openstack/ironic master: Add interface name to inventory for inspection hooks https://review.opendev.org/c/openstack/ironic/+/953414 | 09:30 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove rootwrap https://review.opendev.org/c/openstack/ironic/+/953404 | 10:20 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove rootwrap https://review.opendev.org/c/openstack/ironic/+/953404 | 10:21 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Use specific util methods in vfat image creation https://review.opendev.org/c/openstack/ironic/+/953417 | 10:34 |
| dtantsur | cardoe: (without looking at your patch just yet): does the inventory zoo situation affect the core inventory as well or only the plugin_data part? | 10:36 |
| iurygregory | good morning ironic | 11:16 |
| opendevreview | Syed Haseeb Ahmed proposed openstack/ironic master: Add interface name to inventory for inspection hooks https://review.opendev.org/c/openstack/ironic/+/953414 | 11:18 |
| clif | gm ironic o/ | 12:18 |
| rpittau | patch to build IPA with centos stream 10 passes CI \o/ | 12:54 |
| rpittau | https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/950965 | 12:54 |
| iurygregory | \o/ | 12:57 |
| cardoe | dtantsur: I’m only concerning myself with the core inventory and not the core. | 12:59 |
| cardoe | Errr and not plugin data. | 12:59 |
| dtantsur | And even that has variations? omg | 13:00 |
| * dtantsur takes full blame for this mess | 13:01 | |
| dtantsur | cardoe: https://review.opendev.org/c/openstack/ironic/+/944868 is not looking bad, but I don't recognize some of the fields and it misses some that IPA does send | 13:14 |
| cardoe | I forget what I started with but it wasn’t IPA. I’m gonna switch to that. | 13:16 |
| cardoe | I think I used the ironic mock data as the initial template. | 13:17 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: Provide usable __repr__ for serializable objects https://review.opendev.org/c/openstack/ironic-python-agent/+/953454 | 13:59 |
| *** gdelnc is now known as Mufasa | 14:24 | |
| *** Mufasa is now known as gdelnc | 14:24 | |
| opendevreview | cid proposed openstack/ironic master: Fix inspection rules validation https://review.opendev.org/c/openstack/ironic/+/953464 | 14:45 |
| opendevreview | Abhishek Bongale proposed openstack/ironic stable/2025.1: fix: handle unexpected 'loop' in actions field https://review.opendev.org/c/openstack/ironic/+/953465 | 14:56 |
| opendevreview | Takashi Kajinami proposed openstack/virtualpdu master: Fix home_page url https://review.opendev.org/c/openstack/virtualpdu/+/953471 | 15:30 |
| opendevreview | Merged openstack/virtualpdu master: Fix home_page url https://review.opendev.org/c/openstack/virtualpdu/+/953471 | 16:04 |
| opendevreview | Queensly Kyerewaa Acheampongmaa proposed openstack/ironic master: Add manual clean step to set BMC clock via Redfish Manager https://review.opendev.org/c/openstack/ironic/+/953477 | 16:55 |
| opendevreview | cid proposed openstack/ironic master: Fix inspection rules validation https://review.opendev.org/c/openstack/ironic/+/953464 | 17:01 |
| TheJulia | Continuity: Ahh, hmm... I guess it occurs to me maybe we're doing something we shouldn't be doing in general. I'll try to discuss with Harald and see what his thoughts are | 17:02 |
| opendevreview | Verification of a change to openstack/ironic master failed: Change the novncproxy service code to handle eventlet-lessness https://review.opendev.org/c/openstack/ironic/+/953351 | 17:46 |
| cardoe | dtantsur: can we just throw away the serializable thing and just use dataclasses? | 18:29 |
| cardoe | So I'll use BlockDevice as an example... https://github.com/openstack/ironic-python-agent/blob/883e3cf057aa1e3f7ed5a6fd485e7ab62a8cfd55/ironic_python_agent/hardware.py#L793 | 18:32 |
| cardoe | The serializable_fields are what is sent because we use the base class's method to create the object to submit. | 18:32 |
| cardoe | But https://github.com/openstack/ironic-python-agent/blob/883e3cf057aa1e3f7ed5a6fd485e7ab62a8cfd55/ironic_python_agent/hardware.py#L1101 is one way stuff is gathered up which isn't going through the serialize | 18:40 |
| cardoe | https://github.com/openstack/ironic-python-agent/blob/883e3cf057aa1e3f7ed5a6fd485e7ab62a8cfd55/ironic_python_agent/inspector.py#L261 is the call | 18:41 |
| cardoe | because the inspector creates the payload like... https://github.com/openstack/ironic-python-agent/blob/883e3cf057aa1e3f7ed5a6fd485e7ab62a8cfd55/ironic_python_agent/encoding.py#L67-L72 | 18:42 |
| cardoe | Except that the child functions in list_hardware_info() aren't creating objects that are inheriting from Serializable in most cases. They're creating regular dicts. So what's executing is line 72. | 18:43 |
| cardoe | So the shape of the data that IPA seems to imply isn't actually 100% correct because there's no enforcement. | 18:43 |
| cardoe | So here's what I'm doing with my patch, I've just dumped via an updated IPA 6 different hardware models. I'll update the fields to match the intersection between them for the best compatibility. I'm going to make the behavior treat the inventory as if its empty if what's stored in swift or the DB doesn't match that shape. | 18:48 |
| opendevreview | Verification of a change to openstack/ironic master failed: Change the novncproxy service code to handle eventlet-lessness https://review.opendev.org/c/openstack/ironic/+/953351 | 18:49 |
| cardoe | Today that means the redfish inspector won't be valid. Haseeb on my team is working on making it conform. But it also means that some older IPAs and some ironic-inspector migrated data won't be valid either. | 18:50 |
| cardoe | I'm going to add a "version" field to the inspection data. I'm only focused on the inspection data and not the plugin data. I feel that plugin_data should be owned by the different hooks and it's their choice how to shape their field. | 18:51 |
| cardoe | It'll just be an integer and we start with 0. | 18:51 |
| cardoe | You know what. I'll take this out of IRC and make a bug. | 18:51 |
| * TheJulia blinks and realizes she is only now looking at IRC for the second time all day | 18:59 | |
| opendevreview | Syed Haseeb Ahmed proposed openstack/ironic master: Add interface name to inventory for inspection hooks https://review.opendev.org/c/openstack/ironic/+/953414 | 19:04 |
| opendevreview | Merged openstack/ironic master: Change the novncproxy service code to handle eventlet-lessness https://review.opendev.org/c/openstack/ironic/+/953351 | 21:19 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!