| opendevreview | Merged openstack/ironic master: fix redfish processor inspection https://review.opendev.org/c/openstack/ironic/+/955537 | 03:02 |
|---|---|---|
| opendevreview | Merged openstack/ironic master: allow running inspection hooks on redfish interface https://review.opendev.org/c/openstack/ironic/+/933066 | 03:53 |
| opendevreview | Merged openstack/ironic master: api: Add schema for allocations API (responses) https://review.opendev.org/c/openstack/ironic/+/928921 | 05:35 |
| queensly[m] | Good morning ironic o/ | 08:17 |
| opendevreview | Merged openstack/ironic master: ci: grenade: restart neutron services https://review.opendev.org/c/openstack/ironic/+/956801 | 12:29 |
| TheJulia | good morning | 13:29 |
| opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for bios API (versioning) https://review.opendev.org/c/openstack/ironic/+/952147 | 13:30 |
| opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for bios API (requests) https://review.opendev.org/c/openstack/ironic/+/952148 | 13:30 |
| opendevreview | Merged openstack/ironic master: api: Add schema for bios API (versioning) https://review.opendev.org/c/openstack/ironic/+/952147 | 15:38 |
| opendevreview | Verification of a change to openstack/ironic master failed: api: Add schema for bios API (requests) https://review.opendev.org/c/openstack/ironic/+/952148 | 16:24 |
| TheJulia | cid: https://review.opendev.org/c/openstack/ironic/+/957044/ is a quick review, fwiw | 17:20 |
| cid | ++ | 17:21 |
| TheJulia | https://review.opendev.org/c/openstack/ironic/+/956512 and https://review.opendev.org/c/openstack/ironic/+/956504 as well | 17:21 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Optional indirection API use https://review.opendev.org/c/openstack/ironic/+/956504 | 17:21 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Revert "ci: temporary metal3 integration job disable" https://review.opendev.org/c/openstack/ironic/+/956953 | 17:21 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Clean-up misc eventlet references https://review.opendev.org/c/openstack/ironic/+/955632 | 17:21 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add an unservice verb https://review.opendev.org/c/openstack/ironic/+/957563 | 17:50 |
| TheJulia | janders: what do you think about ^. I suspect its too late to get it merged this cycle because of the necessary client change. | 17:51 |
| JayF | I would personally not -1 an API change because client freeze has happened. It's way easier for someone to get an intermediate release of a client :) | 18:07 |
| JayF | but also understand if we wanna apply some brakes to ensure we don't churn more during eventlet migration/testing | 18:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add an unservice verb https://review.opendev.org/c/openstack/ironic/+/957563 | 18:13 |
| TheJulia | JayF: yeah, I'm not expectin gto land it this cycle | 18:14 |
| TheJulia | because of the client freeze has already passed | 18:14 |
| TheJulia | I'd honestly rather land instance_name or anything else at the moment | 18:15 |
| TheJulia | I really want to focus on getting the eventlet stuff landed | 18:15 |
| JayF | makes sense to me | 18:16 |
| JayF | I agree | 18:16 |
| JayF | and btw, I suggested to cid and clif that we put clif's port stuff in front of instance_name | 18:17 |
| JayF | just so one patch gets rebased instead of 4 | 18:17 |
| JayF | but those landing this cycle is not super important to me tbh without the rest of the networking stuff, but obviously code landing is nicer :D | 18:17 |
| TheJulia | yeah, I was thinking of trying to review cliff's stuff after lunch | 18:17 |
| TheJulia | yeah | 18:17 |
| JayF | TheJulia: I'm going over clif's outstanding changes now, will apply ironic-week-prio to the ones I am +2 on, maybe we can (some of?) get 'em landed as soon as todayish | 18:19 |
| TheJulia | ok | 18:19 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add a new 'category' field to the Port object https://review.opendev.org/c/openstack/ironic/+/955447 | 18:23 |
| JayF | oh hell | 18:23 |
| JayF | clif: I screwed and updated (with edit) that ^^ patch in your series, and detached it from the group. I feel dumb but you'll have to repush that patch forward to make em stick together | 18:23 |
| JayF | 100% my bad I shoulda just left the comment and moved on :-| | 18:24 |
| JayF | well we can land up to 955447 lol | 18:25 |
| clif | Looks like I need to rebase the portgroup stuff? | 18:31 |
| TheJulia | rpittau: thank you for your netlify fix on the website :) | 18:32 |
| TheJulia | I'm still expecting the staff's maintainer to do something but ... that hasn't happened yet so I need to follow-up | 18:32 |
| clif | so for same repo stuff I don't need "Depends-On" to chain a series of commits together? | 18:32 |
| TheJulia | Depends-On is logical, not actual structural | 18:33 |
| clif | I love logic though | 18:33 |
| TheJulia | logic is our friends, but yeah | 18:33 |
| clif | so how does gerrit/git review treat things if I submit a series of commits? | 18:33 |
| TheJulia | its just the stacking of the commits which is the right way to have them together | 18:33 |
| TheJulia | each commit is a change getting its own changeset | 18:34 |
| clif | does it matter if I branch for each commit? | 18:34 |
| TheJulia | no, you don't need to branch the commits individually | 18:34 |
| clif | well that should save me some work in the future then, thanks | 18:34 |
| TheJulia | I typically just download (git review -d NNNNNN), edit, git commit --amend ; git commit -x NNNNNX to layer the next patch on top and when done issue "git review" to upload all the updated change sets to gerrit | 18:37 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add a new 'physical_network' field to the Portgroup object https://review.opendev.org/c/openstack/ironic/+/955625 | 18:40 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add a new 'category' field to the Portgroup object https://review.opendev.org/c/openstack/ironic/+/955713 | 18:41 |
| clif | hopefully good to go now on the rest of those reviews | 18:41 |
| clif | oh wait need to fix that whitespace issue | 18:43 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add a new 'category' field to the Portgroup object https://review.opendev.org/c/openstack/ironic/+/955713 | 18:44 |
| clif | now it should be good | 18:44 |
| JayF | clif: an alternative to the path TheJulia suggested: I `git review -d` the last patch in the set, add *new* commits to fix the issues, with things like "REBASE ME INTO THE PORT.VENDOR COMMIT" as the message, then when everything is happy, I use rebase -i to put those patches into the right place in the stack | 18:47 |
| TheJulia | Yeah, definitely have done that as well | 18:50 |
| JayF | I think I also ... unreasonably enjoy git rebase -i. It's fun to just move a line up or down and the commit follow it (assuming they are not conflicting) | 18:52 |
| TheJulia | ... and I'm sitting here thinking of git "experts" who are afraid of "git rebase" and think I'll just respond with "git reflog"! | 18:52 |
| JayF | When teaching new folks I usually say 2 things: 1) none of these commands are as scary as they seem 2) anytime a command seems scary just copy the entire repo to a different folder before running it | 18:54 |
| JayF | once I learned cp -a repo repo-bak worked, there was never any reason to be afraid of advanced ops | 18:54 |
| TheJulia | :) | 18:57 |
| TheJulia | it is so nice to have a working blog update ability these days | 18:57 |
| TheJulia | JayF: so, regarding the eventlet removal blog post.... I'm tempted to just approve it since I think the biggest barrier we've had to website updates has been ourselves trying to drive a gerrit like review pattern. | 19:05 |
| JayF | it was on my list to review it today, I can pop that to the top of my queue and do it r/n if you want another set of eyes before JFDI | 19:07 |
| TheJulia | I would kind of love to just get it posted, I've already done some edits/cleanup to it and fixed the formatting | 19:07 |
| JayF | I mean, JFDI and I can do an after the fact review | 19:07 |
| JayF | it's a git repo, more commits are always possible | 19:07 |
| TheJulia | +++++ | 19:07 |
| TheJulia | yeah, I think that is totally the model to take | 19:08 |
| TheJulia | just fix it | 19:08 |
| TheJulia | or update it if we want | 19:08 |
| TheJulia | its all good | 19:08 |
| TheJulia | It needs dr daniel jackson from the stargate movie drawing the 3d space plot | 19:08 |
| TheJulia | I think, if nothing explodes, we can allow eventlet stuff to begin landing on monday | 20:37 |
| JayF | \o/ | 20:52 |
| opendevreview | Merged openstack/ironic-prometheus-exporter master: Move bifrost cs9 job to non-voting https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/957454 | 21:15 |
| opendevreview | Merged openstack/ironic master: Add RELEASE_MAPPING entry for 30.0 release https://review.opendev.org/c/openstack/ironic/+/957164 | 21:26 |
| opendevreview | Merged openstack/ironic master: Add RELEASE_MAPPING entry for 31.0 release https://review.opendev.org/c/openstack/ironic/+/957166 | 21:26 |
| opendevreview | Merged openstack/ironic master: Add a new 'vendor' field to the Port object https://review.opendev.org/c/openstack/ironic/+/954966 | 21:29 |
| opendevreview | Merged openstack/ironic master: Always rebuild sphinx env on doc build https://review.opendev.org/c/openstack/ironic/+/957471 | 21:35 |
| janders | TheJulia w/r/t https://review.opendev.org/c/openstack/ironic/+/957563 it looks reasonable, I'd need to lab test it (can do Monday, Saturday here already) to say more | 21:38 |
| janders | I wonder - due to freezes etc, would it be possible to merge https://review.opendev.org/c/openstack/ironic/+/956972/3 in this cycle to give folks ability to get out from failed service | 21:39 |
| janders | and with time move off the abort pathway onto cleaner unservice pathway? | 21:39 |
| janders | that could be the ultimate "have the cake and eat it" approach | 21:40 |
| janders | I need something workable in Ironic to plug a downstream feature into, otherwise we'll have to kill this feature in the current release which will make people sad (although not the end of the world) | 21:41 |
| janders | for context of what feature are we talking about: we were hoping to open up firmware updates as a GA feature in metal3 but it's scary without being able to give user a clear way of getting out from a failed firmware update attempt | 21:46 |
| janders | it seems to me 957563 is going to be hard to get in due to API change, while 956972 doesn't involve API changes so should be OK | 21:55 |
| janders | it is also quite a trivial change unlikely to break things unrelated to servicing | 22:11 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!