| TheJulia | stevebaker[m]: ack | 00:38 |
|---|---|---|
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: Simplify some logic in IPE https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/958714 | 03:26 |
| abongale | good morning ironic o/ | 08:37 |
| queensly[m] | Good morning o/ | 08:48 |
| opendevreview | Hervé Beraud proposed openstack/ironic master: Add hacking check to ban eventlet imports https://review.opendev.org/c/openstack/ironic/+/958738 | 09:33 |
| dtantsur | cardoe: since metal3 already defaults to quay.io, it feels naturally (to me) to pick up IPA images from there too | 10:08 |
| dtantsur | ta-dam!! https://www.cncf.io/blog/2025/08/27/metal3-io-becomes-a-cncf-incubating-project/ | 10:19 |
| iurygregory | UHULLLLLLLLLLLLL | 11:34 |
| JayF | I didn't know ironic was a CNCF project 😂 | 12:54 |
| dtantsur | and an incubating one! | 12:54 |
| dtantsur | TheJulia: hey, do I get it right that instance_info[image_pull_secret] accepts the token itself, not the entire configuration? | 12:55 |
| TheJulia | Well, being in the larger LF family enables things to get mentioned in press releases without issue/concern... so things become easier | 12:55 |
| TheJulia | dtantsur: that is correct, if you want to hand the process the config, you can use the override setting if it is not at the expected path | 12:56 |
| TheJulia | that code matches by hostname if memory serves | 12:56 |
| dtantsur | TheJulia: we need to document how to use image_pull_secret then.. I'm not sure the users are familiar with the format | 12:56 |
| * TheJulia tried to leave others *all the options* | 12:56 | |
| TheJulia | Interesting you'd say that because the mapping seemed quite direct to me, at least with OCP in mind | 12:57 |
| dtantsur | We mention the config in https://docs.openstack.org/ironic/latest/admin/oci-container-registry.html#authentication but don't say "you need to get this stuff from the right section" | 12:57 |
| TheJulia | Yeah, often not drawn as a direct line | 12:58 |
| TheJulia | I'll make a doc update after I have another cup of coffee in hand | 12:58 |
| dtantsur | And that means we need to extract the token in BMO. Should not be hard though. | 12:59 |
| dtantsur | (background: I start feeling that mounting the OCP's pull secret is a dead end - in addition to it being surprisingly hard) | 12:59 |
| TheJulia | I thought you were going to use the path of just pulling the credentials from the cluster and presenting it to ironic in general? | 12:59 |
| TheJulia | (... oh. that stinks) | 12:59 |
| dtantsur | yeah, cooling down a bit about this idea | 12:59 |
| TheJulia | :( | 12:59 |
| TheJulia | I guess it depends on what as well | 12:59 |
| dtantsur | Especially since I've realized that per-host pull secrets are probably inevitable anyway (custom registries, private quay accounts) | 13:00 |
| TheJulia | Fair enough, I think there is some frameworks to do container level injections for specific use credentials as well, so going broader for image access could definitely be harder | 13:02 |
| JayF | TheJulia: I figured it was something like that. Not that I actually care, it was just funny to read | 13:05 |
| dtantsur | Yeah, a trivial oversight. The blog post was composed really quickly, basically in one evening, by a few busy people. | 13:06 |
| TheJulia | It is what it is, I'm sooo worried ;) </sarcasm> | 13:07 |
| TheJulia | lol | 13:08 |
| TheJulia | we need to get john garbutt to join in the idrac fun :) | 13:16 |
| dtantsur | what did he do to you? :) | 13:16 |
| TheJulia | .... he posted two patches which screamed idrac ;) | 13:19 |
| TheJulia | and now I'm curious :) | 13:19 |
| TheJulia | and more, curious because I care and want things to work | 13:19 |
| TheJulia | less actual curiosity, but its the only word i have to describe the feeling | 13:19 |
| opendevreview | Julia Kreger proposed openstack/ironic master: docs: trivial: clarify pull secrets for OCI image access https://review.opendev.org/c/openstack/ironic/+/958765 | 13:26 |
| TheJulia | dtantsur: lmk if that provides more clarity | 13:26 |
| dtantsur | TheJulia: much better, maybe mention explicitly extracting the value under the right host key? (and point to the example below?) | 13:28 |
| TheJulia | hmmm | 13:28 |
| TheJulia | your looking at it very differently then, but I see your point | 13:28 |
| TheJulia | revising | 13:28 |
| opendevreview | Julia Kreger proposed openstack/ironic master: docs: trivial: clarify pull secrets for OCI image access https://review.opendev.org/c/openstack/ironic/+/958765 | 13:40 |
| TheJulia | okay, a bit more verbose and allowing for direct lines to be drawn | 13:40 |
| opendevreview | Julia Kreger proposed openstack/ironic master: docs: trivial: clarify pull secrets for OCI image access https://review.opendev.org/c/openstack/ironic/+/958765 | 13:48 |
| TheJulia | dtantsur: revised, thanks! | 13:49 |
| JayF | TheJulia: those two patches are not targeting at fixing a Dell for what it's worth | 13:59 |
| JayF | TheJulia: The ones from John. | 14:00 |
| TheJulia | Oh, oh :( | 14:00 |
| JayF | I think maybe there's just a pattern of new stuff is weirdly shaped | 14:00 |
| TheJulia | -a popular white box vendor? | 14:00 |
| TheJulia | Yeah, likely | 14:01 |
| JayF | I'm generally not permitted to say specifically what hardware we use in public. | 14:01 |
| TheJulia | K | 14:01 |
| opendevreview | Merged openstack/ironic master: Follow-up: Fix improper HTTP status code usage https://review.opendev.org/c/openstack/ironic/+/958663 | 14:34 |
| clif | is tenks a defunct/dead project? the link on the bug deputy page sends me to a 404 page on launchpad | 14:59 |
| clif | well, it looks active-ish when I look at the repo | 15:00 |
| clif | commits from 9 months ago at least | 15:01 |
| clif | hmm maybe the project tracking for tenks has moved here: https://storyboard.openstack.org/#!/project/openstack/tenks | 15:05 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Revert "Switch from local RPC to automated JSON RPC on localhost" https://review.opendev.org/c/openstack/ironic/+/958776 | 15:11 |
| opendevreview | Clif Houck proposed openstack/ironic master: Tenks bug tracker has moved https://review.opendev.org/c/openstack/ironic/+/958777 | 15:16 |
| JayF | clif: it should be on launchpad, not storyboard | 15:22 |
| JayF | clif: but also tenks is ... probably getting close to time for it to go out to pasture | 15:22 |
| JayF | or for our stackhpc friends to maintain it better | 15:23 |
| clif | should be? ok, but right now the documentation for the project points to the link I posted | 15:32 |
| clif | if the project itself is linking to storyboard.openstack.org what should we link to? | 15:33 |
| JayF | I'm saying it's a project-governance-bug that there's no launchpad tracker for it | 15:34 |
| JayF | we as a project are not supposed to be on storyboard anymore | 15:34 |
| JayF | that being said; the fact it's wrong is emblematical of how dead that project is | 15:34 |
| JayF | so 1) from a bug deputy perspective I wouldn't worry about it and 2) we really need to retire it OR do the legwork to make it right | 15:34 |
| * JayF votes to retire it | 15:34 | |
| clif | it does have a commit from a couple of months ago | 15:37 |
| clif | are you just saying it shouldn't be part of openstack anymore? | 15:38 |
| JayF | I'm saying IMO it's not an ironic project, it's just a roommate for ironic in practice :) | 15:39 |
| JayF | Retiring things requires concern about them though, so you end up in this ... semi-rotten state where only the parts that directly impact folks get addressed | 15:39 |
| JayF | and there aren't many folks using it to be impacted | 15:39 |
| clif | should I just drop it from the bug deputy list then? | 15:43 |
| JayF | I would +2 such a change personally | 15:44 |
| clif | fair enough | 15:45 |
| JayF | the real evidence it's borderline dead from an openstack release perspective: last tagged release was Jan 2024 afaict https://github.com/openstack/tenks/tree/2.0.0 and it added... python 3.10 support :D | 15:45 |
| TheJulia | I like the analogy | 15:52 |
| TheJulia | (the, its a friend that lives in our house) | 15:52 |
| JayF | it'd be more work for us to retire tenks than anyone who works on other parts of openstack have spent on it in years combined | 15:53 |
| TheJulia | yeah | 15:53 |
| JayF | so we just leave the guy on couch alone and let 'em sleep ;) | 15:53 |
| TheJulia | heh | 15:53 |
| TheJulia | yeah | 15:53 |
| opendevreview | Merged openstack/networking-baremetal master: tox: Remove ineffective ignore_basepython_conflict https://review.opendev.org/c/openstack/networking-baremetal/+/957631 | 16:27 |
| opendevreview | Merged openstack/networking-generic-switch master: Ignore newly enforced pep8 rules https://review.opendev.org/c/openstack/networking-generic-switch/+/958708 | 16:29 |
| tkajinam | hmm I don't know why all of the flake8 plugins from neutron-lib are now enabled | 16:32 |
| tkajinam | I'm seeing the same problem started hitting heat suddenly, too... | 16:33 |
| tkajinam | I suspect any change in hacking/flake8 caused this but I didn't find anything clearly related... | 16:33 |
| TheJulia | tkajinam: fun :( | 16:36 |
| TheJulia | tkajinam: https://opendev.org/openstack/neutron-lib/commit/9b6a1aafc394df6e29cde3534167e53279f727f6 | 16:42 |
| TheJulia | I guess if neutron-lib is installed, then the new rules get pulled in | 16:42 |
| tkajinam | ohhh k | 16:42 |
| tkajinam | I'll revert it | 16:42 |
| tkajinam | they can use local-plugins to enable these plugins afaik | 16:43 |
| TheJulia | Yeah, seems like it is crossing project boundaries | 16:43 |
| tkajinam | or probably they should have default off | 16:43 |
| tkajinam | maybe default off is a better approach | 16:43 |
| TheJulia | maybe, dunno, they likely need to be aware of it and revert (and release again) | 16:44 |
| tkajinam | ( I was checking only hacking directory. that's a good fine | 16:44 |
| tkajinam | yeah | 16:44 |
| TheJulia | I guess that is the other problem, if the release team will even let them release it at this point | 16:44 |
| tkajinam | yeah | 16:44 |
| TheJulia | (I was like, wait a second... and used codesearch for N530) | 16:44 |
| tkajinam | anyway I'll report a bug to kick the discussion | 16:45 |
| TheJulia | cool, thanks! | 16:45 |
| opendevreview | Merged openstack/networking-generic-switch master: Minor doc generation fixes https://review.opendev.org/c/openstack/networking-generic-switch/+/958498 | 16:59 |
| opendevreview | Steve Baker proposed openstack/networking-generic-switch master: Create service plugin to configure security groups https://review.opendev.org/c/openstack/networking-generic-switch/+/949834 | 17:19 |
| opendevreview | Clif Houck proposed openstack/ironic master: Remove tenks references https://review.opendev.org/c/openstack/ironic/+/958798 | 17:37 |
| TheJulia | qotd: As a project, what kind of building is Ironic?! | 18:12 |
| JayF | We're the sub basement with all the creepy creepy corners | 18:38 |
| TheJulia | Has anyone considered AI driven code review? | 20:51 |
| TheJulia | to at least be a basic first pass? | 20:51 |
| JayF | If we were github, I'd probably have tried it on ironic. | 20:53 |
| JayF | Generally, I am ... suspicious it'd be useful | 20:53 |
| JayF | especially given how much *I* have to rein in the tool even when I'm using it | 20:53 |
| JayF | they really, really like to follow some average of all python patterns even when you give it lots of context about how openstack does things | 20:54 |
| TheJulia | Just toying with claude and some specific changes, and it was interesting to see what it was coming back with | 20:54 |
| JayF | Plus apparently the copilot code review stuff on github can't be blocked at a project level... so I don't love that. | 20:54 |
| JayF | How did you do it? just git review -d and point claude asking it to review HEAD | 20:54 |
| TheJulia | and... interestingly enough, it was coming back with some feedback which mirrors some of the review feedback | 20:54 |
| TheJulia | yup | 20:54 |
| TheJulia | "review git commit $blah, and evaluate risk of regression, provide a summary in 80 words" | 20:55 |
| TheJulia | fun is added when you ask it to provide a risk analysis table, or when you ask it to do so as if it was shakespear | 20:55 |
| JayF | I've done that pattern before where I have claude do a thing in window A, then ask claude in window B to review it | 20:55 |
| JayF | I think you can use /agent to do that in one window now | 20:55 |
| JayF | My biggest claude pattern I think is useful: I have ~/dev/openstack/ with a CLAUDE.md, all my openstack projects checked out beneath. That allows you to use other openstack projects as templates. | 20:56 |
| JayF | For the wsgi docs change, that's the approach I took; I had it use other wsgi examples from openstack | 20:56 |
| TheJulia | I've been using it with repos in isolation, but that is likely a better case for some cross-project related patterning | 20:59 |
| JayF | well I started it because of asking questions about nova ironic driver and ironic behavior | 21:00 |
| JayF | just makes it easier to reason about when you can say "do X similarly to how they did it in path/to/module" | 21:00 |
| TheJulia | yeah | 21:01 |
| JayF | btw if you wanna see | 21:01 |
| JayF | https://www.irccloud.com/pastebin/VgwvIPWd/claude-md.txt | 21:02 |
| opendevreview | Verification of a change to openstack/networking-generic-switch master failed: Create service plugin to configure security groups https://review.opendev.org/c/openstack/networking-generic-switch/+/949834 | 21:13 |
| TheJulia | gaaaah | 21:13 |
| * cardoe stares at the wall. | 21:25 | |
| TheJulia | so, that job should have passed but nova failed | 21:26 |
| TheJulia | which is sort of the same | 21:26 |
| * TheJulia stares at the wall. | 21:26 | |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add node.instance_name https://review.opendev.org/c/openstack/ironic/+/952790 | 22:41 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/957613/4#message-dcae860b0e59de395e9a75f3742a6c7a839960e3 if other folks have a different opinion or agree please say so | 22:43 |
| opendevreview | Merged openstack/ironic master: Add hacking check to ban eventlet imports https://review.opendev.org/c/openstack/ironic/+/958738 | 23:00 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!