| opendevreview | Steve Baker proposed openstack/networking-generic-switch master: WIP Add security group support to ovs https://review.opendev.org/c/openstack/networking-generic-switch/+/956519 | 04:10 |
|---|---|---|
| abongale | gkk | 08:31 |
| abongale | good morning ironic o/ | 08:32 |
| opendevreview | Morten Stephansen proposed openstack/ironic-python-agent master: Removed redundant side-effects https://review.opendev.org/c/openstack/ironic-python-agent/+/959114 | 10:00 |
| opendevreview | Grzegorz Koper proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Arista devices https://review.opendev.org/c/openstack/networking-generic-switch/+/959118 | 10:59 |
| opendevreview | Grzegorz Koper proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Arista devices https://review.opendev.org/c/openstack/networking-generic-switch/+/959118 | 11:16 |
| *** srelf_ is now known as Continuity | 13:21 | |
| dtantsur | zigo: yep, ironic-inspector-client will not be a separate thing. Most commands are available in ironicclient already. Remove now or wait for the ironic-inspector removal. | 14:49 |
| cardoe | dtantsur: biggest complaints I've heard is the inventory data being just 1 command with a blob of data vs structured output from the inspector CLI | 14:51 |
| dtantsur | cardoe: yeah, these ones did not get moved over. It's not a hard task even, but we need to collectively agree on client-side processing on such scale. | 14:52 |
| zigo | Thanks | 14:55 |
| opendevreview | Clif Houck proposed openstack/ironic master: Remove tenks reference in bug-deputy doc https://review.opendev.org/c/openstack/ironic/+/958798 | 15:09 |
| clif | JayF: quickest +2 in the west? | 15:10 |
| JayF | that's what happens when you submit a ~1 line change and I see it in IRC while I reading IRC | 15:10 |
| clif | :) | 15:10 |
| cardoe | TheJulia: So if we ignore the evil wizard behind the curtain and make a 1 line patch to either Cinder or to Nova. The NVMe attachment works. | 16:10 |
| cardoe | https://opendev.org/openstack/nova/src/commit/73724fef9a66c4df3d018e7368067f883b1ed9e2/nova/virt/ironic/driver.py#L2058 that line right there needs to set the property to "nqn" instead of "initiator" | 16:11 |
| cardoe | Or we patch the Cinder side to accept "initiator" instead of "nqn" | 16:12 |
| cardoe | I think the reality is there needs to be some agreement on a stable API there because for NVMe the field is "nqn" and for iSCSI the field is "iqn" and I'm sure somewhere some other path was "initiator" when that code was written. | 16:13 |
| cardoe | My initial jump to conclusions here is that it should be "initiator" as the stable interface and then that gets routed to whatever is needed based on the backend. | 16:13 |
| cardoe | The evil wizard behind the curtains is some out of band code that I've got which listens to the RabbitMQ notifications and fires off some extra openstack CLI commands. | 16:14 |
| cardoe | Cause today the nova libvirt driver itself listens for those and sends a RPC to os-brick. | 16:15 |
| cardoe | But the listening for the notifications and doing an operation isn't unrealistic and matches how some of the neutron stuff in conductor works today. | 16:16 |
| cardoe | skrobul and I will sketch this out in the coming weeks and we can add a PTG topic or a bug. | 16:17 |
| TheJulia | good morning | 16:28 |
| TheJulia | cardoe: out of curiosity, nqn for nvme, but not iscsi? | 16:31 |
| TheJulia | yeah, basically what you said | 16:31 |
| cardoe | Yeah. It's "iqn" for iscsi. | 16:31 |
| TheJulia | I'd just abstract it back if we could | 16:31 |
| cardoe | Well I think initiator makes sense and Cinder should just abstract that for us. | 16:32 |
| cardoe | It puts too much of the logic around which backend is in play into the caller of the APIs. | 16:32 |
| cardoe | Especially when in every other case they're abstracting away the backend from the caller since they are using cinder-scheduler to pick one for you. | 16:33 |
| TheJulia | yeah, the backends get to have their own logic since it just defines the broad bounds/process | 16:34 |
| TheJulia | I do concur, cinder should just abstract it | 16:35 |
| opendevreview | Merged openstack/ironic master: Remove tenks reference in bug-deputy doc https://review.opendev.org/c/openstack/ironic/+/958798 | 16:51 |
| JayF | we need to land https://review.opendev.org/c/openstack/ironic-inspector/+/958068 | 16:58 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/28.0: Memoize calls to bcrypt.checkpw https://review.opendev.org/c/openstack/ironic/+/959220 | 17:01 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.2: Memoize calls to bcrypt.checkpw https://review.opendev.org/c/openstack/ironic/+/959221 | 17:01 |
| TheJulia | ... I'm seriously wondering why when we're shutting it down next cycle? | 17:22 |
| TheJulia | I mean, maintenance mode | 17:22 |
| TheJulia | so, maybe, but yeah | 17:22 |
| opendevreview | Merged openstack/ironic-inspector master: Set an explicit neutron endpoint for grenade https://review.opendev.org/c/openstack/ironic-inspector/+/959039 | 17:24 |
| JayF | TheJulia: I'm not going to remove the old way, but it seems harmless and potentially good to merge that, especially since the TC goal related to it is marked "done" | 17:26 |
| JayF | I also wouldn't have written this patch but no value in not mashing the buttons | 17:27 |
| TheJulia | yeah | 17:28 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.2: Memoize calls to bcrypt.checkpw https://review.opendev.org/c/openstack/ironic/+/959221 | 17:30 |
| JayF | I'm on the fence on if that was the right move or not | 17:30 |
| JayF | (the way I backportedd that to 2024.2) | 17:34 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Don't fail early if no config drive found https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/957253 | 17:44 |
| opendevreview | Merged openstack/ironic-inspector master: Drop description for ZeroMQ https://review.opendev.org/c/openstack/ironic-inspector/+/958359 | 17:48 |
| opendevreview | Merged openstack/networking-generic-switch master: Create service plugin to configure security groups https://review.opendev.org/c/openstack/networking-generic-switch/+/949834 | 17:50 |
| TheJulia | It looks like CI might be happy-ish today?! | 18:15 |
| opendevreview | Verification of a change to openstack/ironic stable/2025.1 failed: Memoize calls to bcrypt.checkpw https://review.opendev.org/c/openstack/ironic/+/958316 | 18:16 |
| opendevreview | Merged openstack/networking-generic-switch master: Support security groups in netmiko base class https://review.opendev.org/c/openstack/networking-generic-switch/+/949835 | 18:23 |
| TheJulia | Reminder folks: https://review.opendev.org/c/openstack/releases/+/958489 <-- cycle highlights | 18:24 |
| TheJulia | JayF: I took care of the trailing whitespace | 18:24 |
| JayF | I mostly give up in that repo | 18:25 |
| JayF | their automated tools readd whitespace helpfully | 18:25 |
| TheJulia | huh? | 18:25 |
| TheJulia | oh, heh | 18:25 |
| JayF | so I don't worry as much about formatting unless it causes V-1 | 18:25 |
| JayF | TheJulia: hey lookie at the short we just posted :D https://www.youtube.com/shorts/vhCuPyJF6HU | 18:25 |
| opendevreview | Merged openstack/ironic master: doc: Fix installation of grub/shim EFI images in CentOS https://review.opendev.org/c/openstack/ironic/+/955590 | 18:27 |
| opendevreview | Verification of a change to openstack/ironic master failed: doc: Drop explicit version for CentOS/RHEL https://review.opendev.org/c/openstack/ironic/+/955594 | 18:27 |
| TheJulia | cardoe: https://etherpad.opendev.org/p/ironic-ptg-2026.1#L50 | 18:38 |
| TheJulia | janders: so going back to the Settings sub-resource, or whatever gets defined as the sub object (since it is a free for all structurally. I think the original work moves us along, the issue is just providing consistency. The thing I'm wondering is if more needs to be done that is not obvious/clear. | 19:14 |
| opendevreview | Jay Faulkner proposed openstack/ironic-tempest-plugin master: Anaconda science -- more ram? https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/958588 | 19:16 |
| opendevreview | Merged openstack/ironic-python-agent master: Removed redundant side-effects https://review.opendev.org/c/openstack/ironic-python-agent/+/959114 | 20:21 |
| opendevreview | Julia Kreger proposed openstack/sushy master: Handle idrac10 moving some boot items https://review.opendev.org/c/openstack/sushy/+/958578 | 20:31 |
| TheJulia | so everything I raised an eyebrow at, I'm good with. | 20:32 |
| TheJulia | janders: ^ | 20:32 |
| opendevreview | Merged openstack/bifrost master: Recover the CI https://review.opendev.org/c/openstack/bifrost/+/957847 | 20:58 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add a new 'physical_network' field to the Portgroup object https://review.opendev.org/c/openstack/ironic/+/955625 | 21:31 |
| adamcarthur5 | Hi TheJulia and JayF - just wanted to bump https://review.opendev.org/c/openstack/ironic-specs/+/952533?tab=comments for a review, its been a while | 23:45 |
| opendevreview | Merged openstack/bifrost master: Do not pass empty values to instance_info https://review.opendev.org/c/openstack/bifrost/+/953336 | 23:53 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!