| TheJulia | cardoe: comments welcome, I think the evpn way is the go-to way when I really think of it, because then we balance hot spotting versus a huge amount of complexity, but I would need to go udnerstand the evpn model and all that | 00:06 |
|---|---|---|
| TheJulia | It still might need to be a service, u dunno | 00:16 |
| TheJulia | err, I dunno | 00:16 |
| cardoe | TheJulia: first review comment… `pre-commit install` in your shell in the ironic-specs directory. | 00:31 |
| TheJulia | Yeah, its still a wip which I know won't pass linting rightnow | 00:33 |
| *** bbezak_ is now known as bbezak | 06:22 | |
| abongale | good morning ironic o/ | 07:49 |
| opendevreview | Grzegorz Koper proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Arista devices https://review.opendev.org/c/openstack/networking-generic-switch/+/959118 | 09:39 |
| FreemanBoss[m] | good morning | 09:39 |
| opendevreview | Grzegorz Koper proposed openstack/networking-generic-switch master: Fix incorrect command when unplugging bond subports https://review.opendev.org/c/openstack/networking-generic-switch/+/959423 | 09:50 |
| opendevreview | Grzegorz Koper proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Arista devices https://review.opendev.org/c/openstack/networking-generic-switch/+/959118 | 10:48 |
| opendevreview | Grzegorz Koper proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Arista devices https://review.opendev.org/c/openstack/networking-generic-switch/+/959118 | 10:49 |
| opendevreview | Jakub Jelinek proposed openstack/ironic-python-agent master: Fix skip block devices for RAID arrays https://review.opendev.org/c/openstack/ironic-python-agent/+/937342 | 11:06 |
| kubajj | We are sorry for the size of the patch ^ | 11:07 |
| opendevreview | Bartosz Bezak proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Arista devices https://review.opendev.org/c/openstack/networking-generic-switch/+/959118 | 12:08 |
| opendevreview | luocanhui proposed openstack/ironic master: Add UT for metrics modules https://review.opendev.org/c/openstack/ironic/+/958028 | 12:18 |
| TheJulia | folks, could we get more eyes on https://review.opendev.org/c/openstack/ironic/+/959389 I'd like to get a final release out the door sooner rather than later | 13:29 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Replace unused oslo.service options https://review.opendev.org/c/openstack/ironic/+/959510 | 13:46 |
| cardoe | +2 | 14:12 |
| TheJulia | Only one more core for the reno! | 14:31 |
| dtantsur | TheJulia: we don't use the term "introspection" any more in Ironic, is it something you want to fix? | 14:32 |
| TheJulia | dtantsur: why don't you rev the text directly | 14:33 |
| TheJulia | In the interests of speed | 14:33 |
| dtantsur | The question is whether you want to lose the +2 :) | 14:33 |
| TheJulia | and efficiency | 14:33 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Add a prelude for 2025.2 https://review.opendev.org/c/openstack/ironic/+/959389 | 14:34 |
| dtantsur | updated and +2 | 14:34 |
| TheJulia | workflowed, thanks | 14:54 |
| TheJulia | Anyone screaming to not release 32.0.0 once merged? | 15:13 |
| JayF | ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh | 15:13 |
| JayF | [screaming unrelated to release] | 15:14 |
| * dtantsur is worried | 15:14 | |
| TheJulia | dtantsur: normal worried, or earth shattering oh noes? | 15:15 |
| * TheJulia is largely just trying to drive the loop here, ensure we release to ensure the feedback engine will loop around again since it is all a self-feeding machine | 15:16 | |
| dtantsur | I'm worried by JayF screaming (unrelated to release) | 15:16 |
| TheJulia | oh, good | 15:17 |
| JayF | dtantsur: does anyone need a specific reason to scream these days? I think there's lots of screaming left unscreamed. Just evening the scales. | 15:17 |
| dtantsur | I don't have anything blocking the release. https://review.opendev.org/c/openstack/ironic/+/958072 and https://review.opendev.org/c/openstack/ironic/+/955762 could be nice but also could be backported | 15:17 |
| dtantsur | JayF: fair enough. I'm not screaming only because if I start I'm not going to end | 15:18 |
| JayF | I have a sore throat so I had to scream in IRC instead of IRL | 15:18 |
| JayF | approved both those with a recheck | 15:20 |
| dtantsur | thanks! | 15:20 |
| TheJulia | Worst comes to worst, we can backport them in | 15:20 |
| opendevreview | Merged openstack/ironic master: Add a prelude for 2025.2 https://review.opendev.org/c/openstack/ironic/+/959389 | 15:20 |
| frickler | speaking of releases, did you see https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/7THC2L43DYKEQUURQ6OFIV2P7SLM4SXL/ ? (ipa-builder and network-baremetal) | 15:36 |
| jovial | I'm updating the introspection rules in kayobe to be compatible with the built-in inspector. I can't seem to figure how to replicated the is-empty condition. I've come up with this hacky workaround: https://gist.github.com/jovial/c78cefea45b7eecb2cb5718bfb263abb Is there a better way? | 15:37 |
| jovial | I did try and use one-of: https://gist.github.com/jovial/5ed015a01bc8a23d392176a475392512 but that didn't work | 15:41 |
| jovial | Essentially, I wanted to recreate that logic of not updating a property if a value has already been set | 15:43 |
| jovial | I think the difference is that the old is-empty used to work with missing values: https://github.com/openstack/ironic-inspector/commit/50b989474d874c6004dd2b4f0c1ec598007a2fcb | 15:47 |
| TheJulia | frickler: I can't load the url right now, but if its ttx's email from 1.5-ish days ago, its literally the next item I'm going to address unless someone runs infront of me with hair on fire. :) | 16:05 |
| TheJulia | jovial: I guess I'm sort of wondering why you'd have such a rule mapping behavior like that anyhow. But that doesn't takeaway from the base question on the match which someone will need to dig into | 16:07 |
| TheJulia | frickler: yeah, thats the email, it finally loaded here | 16:08 |
| jovial | TheJulia: As in only setting a field if it wasn't already set? For this particular case, I was trying to replicate the old behavior, where you could manually set the property on a handful of nodes and have it automatically set on others. I guess the other option is just always set it. | 16:12 |
| TheJulia | I guess your making it consistent in a way in your environment, or at least attempting to. But it should not be changing at all across deploys/operations *unless* the hardware is being changed actively | 16:14 |
| TheJulia | at which point, it sort of makes sense, I guess | 16:14 |
| TheJulia | A super-quick ipa-b patch: https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/959255 | 16:21 |
| jovial | In particular, I quite like the root device hint as otherwise, I believe, it selects the smallest disk and that could change if your root disk dies and then you end up imaging the wrong disk | 16:22 |
| TheJulia | just some wireless firmwares to remove | 16:22 |
| TheJulia | jovial: fair, and it is the smallest device greater than ?4 GB? in side. | 16:22 |
| TheJulia | size | 16:23 |
| TheJulia | so, looks like ironic, networking-generic-switch, networking-baremetal, ironic-inspector. | 16:27 |
| TheJulia | and ironic-python-agent-builder | 16:29 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add a new 'category' field to the Portgroup object https://review.opendev.org/c/openstack/ironic/+/955713 | 16:31 |
| TheJulia | and ironic-python-agent as well it looks like | 16:41 |
| opendevreview | Merged openstack/ironic master: Replace unused oslo.service options https://review.opendev.org/c/openstack/ironic/+/959510 | 16:45 |
| TheJulia | heh, already have to rev the stack of releases, woot! | 16:45 |
| TheJulia | frickler and ironic-cores: https://review.opendev.org/q/topic:%22ironic-releases-2025.2%22 | 16:54 |
| JayF | no ironic-inspector in 2026.1, right? | 17:00 |
| JayF | I'm going to run the paperwork to retire metalsmith after the release; curious if I should make it a twofer | 17:01 |
| TheJulia | I *think* that is what we said, we'd need to doublecheck release notes | 17:04 |
| clif | It looks like people are already aware of https://bugs.launchpad.net/ironic/+bug/2121702 but it's new as of six days ago, unassigned, and importance is undecided | 17:05 |
| clif | if someone is looking at this please assign yourself and triage | 17:06 |
| TheJulia | I'm 95% sure its legit in the latest version and is related in different projects being used to admin ironic versus who created the networks | 17:09 |
| clif | JayF: I guess this is the bug you were trying to gently point me at if I needed a break from the yaml config stuff | 17:09 |
| JayF | that's not the bug I was pointing you at | 17:12 |
| clif | oh | 17:12 |
| JayF | but it sure as hell would be a baptism by fire into the RBAC/network intersection | 17:12 |
| JayF | and would be a valuable use of time | 17:12 |
| JayF | this may end up being a "this is a spec and year worth of work" bug rather than something trivially fixable, but it'd still be neat to know | 17:13 |
| clif | you're certainly selling me on it | 17:13 |
| JayF | well I've said to you before that I think improving the model between ironic/nova/neutron around advanced networking would be nice | 17:15 |
| TheJulia | FWIW, the bug which was linked above should be relatively trivial | 17:19 |
| TheJulia | just requires getting the context and likely adding an extra argument under the hood so we know not to use the requestor context, we've got at least one other place where we've had to do that in the past | 17:19 |
| JayF | oh nice | 17:27 |
| TheJulia | The issue is, networking has a few different paths of invocation, and we're grabbing the context and using it when we can | 17:29 |
| JayF | sounds like a perfect place for someone to get familiar with the seams around ironic and neutron :D | 17:34 |
| JayF | +1 on those release changes | 17:45 |
| * JayF will be heading out after his meeting in ~hour on a sick day | 17:45 | |
| TheJulia | ack ack | 17:53 |
| TheJulia | I'm eating lunch in a little bit and likely will just take tomorrow off in addition to next week | 17:54 |
| opendevreview | Merged openstack/ironic master: JSON-RPC: disable server-side logging with rpc_transport=none https://review.opendev.org/c/openstack/ironic/+/958072 | 18:48 |
| opendevreview | Verification of a change to openstack/ironic master failed: Log how long power sync and sensor collections take https://review.opendev.org/c/openstack/ironic/+/955762 | 18:48 |
| opendevreview | Verification of a change to openstack/ironic master failed: Add a suggestive warning around power and sensor syncs https://review.opendev.org/c/openstack/ironic/+/955821 | 18:48 |
| TheJulia | sigh | 18:50 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!